##// END OF EJS Templates
rhodecode-enterprise-ce
RSS
vcs: Minimal change to expose the shadow repository...
vcs: Minimal change to expose the shadow repository Based on my original research, this was the "minimal" starting point. It shows that three concepts are needed for the "repo_name": * From the security standpoint we think of the shadow repository having the same ACL as the target repository of the pull request. This is because the pull request itself is considered to be a part of the target repository. Out of this thought, the variable "acl_repo_name" is used whenever we want to check permissions or when we need the database configuration of the repository. An alternative name would have been "db_repo_name", but the usage for ACL checking is the most important one. * From the web interaction perspective, we need the URL which was originally used to get to the repository. This is because based on this base URL commands can be identified. Especially for Git this is important, so that the commands are correctly recognized. Since the URL is in the focus, this is called "url_repo_name". * Finally we have to deal with the repository on the file system. This is what the VCS layer deal with normally, so this name is called "vcs_repo_name". The original repository interaction is a special case where all three names are the same. When interacting with a pull request, these three names are typically all different. This change is minimal in a sense that it just makes the interaction with a shadow repository barely work, without checking any special constraints yet. This was the starting point for further work on this topic.
marcink - - Load All Authors

File last commit:

r1:854a839a default
r887:175782be default
Show More
test_csrf.py
89 lines | 2.6 KiB | text/x-python | PythonLexer
/ rhodecode / tests / lib / middleware / test_csrf.py
History | Source | Raw |Copy content |Copy permalink
marcink
project: added all source files and assets
 r1 # -*- coding: utf-8 -*-
# Copyright (C) 2010-2016 RhodeCode GmbH
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License, version 3
# (only), as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# This program is dual-licensed. If you wish to learn more about the
# RhodeCode Enterprise Edition, including its added features, Support services,
# and proprietary license terms, please see https://rhodecode.com/licenses/
import wsgiref.simple_server
import pytest
import webtest
from rhodecode.lib.middleware import csrf
def test_origin_checker_no_origin():
app = csrf.OriginChecker(
wsgiref.simple_server.demo_app, 'https://safe.org')
app = webtest.TestApp(app)
app.post('/foo')
def test_origin_checker_null_origin():
app = csrf.OriginChecker(
wsgiref.simple_server.demo_app, 'https://safe.org')
app = webtest.TestApp(app)
app.post('/foo', headers={'Origin': 'null'})
@pytest.mark.parametrize('origin', [
'http://safe.org',
'http://safe.org:80',
'http://safe.org http://redirect',
])
def test_origin_checker_valid_origin(origin):
app = csrf.OriginChecker(
wsgiref.simple_server.demo_app, 'http://safe.org')
app = webtest.TestApp(app)
app.post('/foo', headers={'Origin': origin})
@pytest.mark.parametrize('origin', [
'https://safe.org',
'https://safe.org:443',
'https://safe.org https://redirect',
])
def test_origin_checker_valid_origin_https(origin):
app = csrf.OriginChecker(
wsgiref.simple_server.demo_app, 'https://safe.org')
app = webtest.TestApp(app)
app.post('/foo', headers={'Origin': origin})
@pytest.mark.parametrize('origin', [
'http://www.evil.org',
'https://www.evil.org',
'foo',
])
def test_origin_checker_invalid_origin(origin):
app = csrf.OriginChecker(
wsgiref.simple_server.demo_app, 'https://safe.org')
app = webtest.TestApp(app)
app.post('/foo', headers={'Origin': origin}, status=403)
def test_origin_checker_invalid_origin_skipped_url():
app = csrf.OriginChecker(
wsgiref.simple_server.demo_app, 'https://safe.org', skip_urls=['/foo'])
app = webtest.TestApp(app)
app.post('/foo', headers={'Origin': 'http://www.evil.org'})