##// END OF EJS Templates
goto-switcher: optimized performance and query capabilities....
goto-switcher: optimized performance and query capabilities. - Previous implementation had on significant bug. The use of LIMIT 20 was limiting results BEFORE auth checks. In case of large ammount of similarly named repositories user didn't had access too, the result goto search was empty. This was becuase first 20 items fetched didn't pass permission checks and final auth list was empty. To fix this we now use proper filtering for auth using SQL. It means we first check user allowed repositories, and add this as a filter so end result from database is already to only the accessible repositories.

File last commit:

r2014:b776c5e0 default
r2038:2bdf9d4d default
Show More
repo_strip.py
116 lines | 4.2 KiB | text/x-python | PythonLexer
repo-strip: rename file to adjust same naming as other views....
r1723 # -*- coding: utf-8 -*-
# Copyright (C) 2017-2017 RhodeCode GmbH
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License, version 3
# (only), as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# This program is dual-licensed. If you wish to learn more about the
# RhodeCode Enterprise Edition, including its added features, Support services,
# and proprietary license terms, please see https://rhodecode.com/licenses/
import logging
from pyramid.view import view_config
from rhodecode.apps._base import RepoAppView
from rhodecode.lib import audit_logger
security: fix self-xss inside repo strip view.
r1809 from rhodecode.lib import helpers as h
repositories: rewrote whole admin section to pyramid....
r2014 from rhodecode.lib.auth import (
LoginRequired, HasRepoPermissionAnyDecorator, CSRFRequired)
repo-strip: rename file to adjust same naming as other views....
r1723 from rhodecode.lib.ext_json import json
log = logging.getLogger(__name__)
class StripView(RepoAppView):
def load_default_context(self):
c = self._get_local_tmpl_context()
# TODO(marcink): remove repo_info and use c.rhodecode_db_repo instead
c.repo_info = self.db_repo
self._register_global_c(c)
return c
@LoginRequired()
@HasRepoPermissionAnyDecorator('repository.admin')
@view_config(
repositories: rewrote whole admin section to pyramid....
r2014 route_name='edit_repo_strip', request_method='GET',
repo-strip: rename file to adjust same naming as other views....
r1723 renderer='rhodecode:templates/admin/repos/repo_edit.mako')
def strip(self):
c = self.load_default_context()
c.active = 'strip'
c.strip_limit = 10
return self._get_template_context(c)
@LoginRequired()
@HasRepoPermissionAnyDecorator('repository.admin')
security: added missing csrf checks in few missing views.
r1811 @CSRFRequired()
repo-strip: rename file to adjust same naming as other views....
r1723 @view_config(
route_name='strip_check', request_method='POST',
renderer='json', xhr=True)
def strip_check(self):
from rhodecode.lib.vcs.backends.base import EmptyCommit
data = {}
rp = self.request.POST
for i in range(1, 11):
chset = 'changeset_id-%d' % (i,)
check = rp.get(chset)
security: fix self-xss inside repo strip view.
r1809
repo-strip: rename file to adjust same naming as other views....
r1723 if check:
data[i] = self.db_repo.get_changeset(rp[chset])
if isinstance(data[i], EmptyCommit):
security: fix self-xss inside repo strip view.
r1809 data[i] = {'rev': None, 'commit': h.escape(rp[chset])}
repo-strip: rename file to adjust same naming as other views....
r1723 else:
data[i] = {'rev': data[i].raw_id, 'branch': data[i].branch,
'author': data[i].author,
'comment': data[i].message}
else:
break
return data
@LoginRequired()
@HasRepoPermissionAnyDecorator('repository.admin')
security: added missing csrf checks in few missing views.
r1811 @CSRFRequired()
repo-strip: rename file to adjust same naming as other views....
r1723 @view_config(
route_name='strip_execute', request_method='POST',
renderer='json', xhr=True)
def strip_execute(self):
from rhodecode.model.scm import ScmModel
c = self.load_default_context()
user = self._rhodecode_user
rp = self.request.POST
data = {}
for idx in rp:
commit = json.loads(rp[idx])
# If someone put two times the same branch
if commit['branch'] in data.keys():
continue
try:
ScmModel().strip(
repositories: rewrote whole admin section to pyramid....
r2014 repo=self.db_repo,
repo-strip: rename file to adjust same naming as other views....
r1723 commit_id=commit['rev'], branch=commit['branch'])
log.info('Stripped commit %s from repo `%s` by %s' % (
repositories: rewrote whole admin section to pyramid....
r2014 commit['rev'], self.db_repo_name, user))
repo-strip: rename file to adjust same naming as other views....
r1723 data[commit['rev']] = True
audit-logs: use specific web/api calls....
r1806 audit_logger.store_web(
audit-logs: implemented full audit logs across application....
r1829 'repo.commit.strip', action_data={'commit_id': commit['rev']},
repo=self.db_repo, user=self._rhodecode_user, commit=True)
repo-strip: rename file to adjust same naming as other views....
r1723
except Exception as e:
data[commit['rev']] = False
log.debug('Stripped commit %s from repo `%s` failed by %s, exeption %s' % (
commit['rev'], self.db_repo_name, user, e.message))
return data