rhodecode-enterprise-ce Files · docs/collaboration/approve-pull-request.rst

fix(permissions): added a common way to update private flag via repo model...

fix(permissions): added a common way to update private flag via repo model - this allows to have a one and only one way to control the flag with the business logic shared - added test for that - changed view to use this method instead of DB update and custom permissions flush - fixed a case when update of repo settings didn't flush permissions actually while it should when private flag changed

marcink - - Load All Authors

File last commit:

r3290:ac4e4e5a default


                r5551:5b9b5ed2

default

Download file

             approve-pull-request.rst
        
                    19 lines
            
             | 690 B
            
                | text/x-rst
            
             |
                RstLexer
            
             / docs / collaboration / approve-pull-request.rst
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        marcink
    
project: added all source files and assets

              r1
            
      Approve |prs|

      -------------

      To approve a |pr|, use the following steps:

      1. Select :menuselection:`username --> Notifications --> Pull Requests`

         and open the |pr| you with to approve

      2. Leave your review comments inline, or in the commit message.

      3. Leave a commit message that outlines the review.

      4. Set the review status to :guilabel:`Approved`

      5. Select :guilabel:`Comment`

        marcink
    
docs: added SAML documentation....

              r3290
            
      If you approve the |pr|, you will be able to merge automatically if |RCE|

        marcink
    
project: added all source files and assets

              r1
            
      detects that it can do so safely. You will see this message:

      :guilabel:`This pull request can be automatically merged.`

      Otherwise you will need to merge the |pr| locally and push your changes, see

      :ref:`manual-merge-requests-ref`.

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

marcink project: added all source files and assets	r1	Approve \|prs\|
		-------------

		To approve a \|pr\|, use the following steps:

		1. Select :menuselection:`username --> Notifications --> Pull Requests`
		and open the \|pr\| you with to approve
		2. Leave your review comments inline, or in the commit message.
		3. Leave a commit message that outlines the review.
		4. Set the review status to :guilabel:`Approved`
		5. Select :guilabel:`Comment`

marcink docs: added SAML documentation....	r3290	If you approve the \|pr\|, you will be able to merge automatically if \|RCE\|
marcink project: added all source files and assets	r1	detects that it can do so safely. You will see this message:

		:guilabel:`This pull request can be automatically merged.`

		Otherwise you will need to merge the \|pr\| locally and push your changes, see
		:ref:`manual-merge-requests-ref`.