##// END OF EJS Templates
pull-requests: only allow actual reviewers to leave status/votes....
pull-requests: only allow actual reviewers to leave status/votes. Other participants aren't allowed that, they could only sent text comments to not distract from actual votes that count towards the overall review.

File last commit:

r4509:b5299f6d stable
r4513:8c4f7e94 stable
Show More
utils.py
111 lines | 3.8 KiB | text/x-python | PythonLexer
pull-request: extended default reviewers functionality....
r1769 # -*- coding: utf-8 -*-
code: update copyrights to 2020
r4306 # Copyright (C) 2016-2020 RhodeCode GmbH
pull-request: extended default reviewers functionality....
r1769 #
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License, version 3
# (only), as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# This program is dual-licensed. If you wish to learn more about the
# RhodeCode Enterprise Edition, including its added features, Support services,
# and proprietary license terms, please see https://rhodecode.com/licenses/
pull-requests: limit the ammount of data saved in default reviewers data for better memory usage...
r4509 from rhodecode.lib import helpers as h, rc_cache
pull-request: extended default reviewers functionality....
r1769 from rhodecode.lib.utils2 import safe_int
pull-requests: fix way how pull-request calculates common ancestors....
r4346 from rhodecode.model.pull_request import get_diff_info
reviewers: added observers as another way to define reviewers....
r4500 from rhodecode.model.db import PullRequestReviewers
# V3 - Reviewers, with default rules data
# v4 - Added observers metadata
REVIEWER_API_VERSION = 'V4'
pull-request: extended default reviewers functionality....
r1769
reviewers: added observers as another way to define reviewers....
r4500 def reviewer_as_json(user, reasons=None, role=None, mandatory=False, rules=None, user_group=None):
pull-request: extended default reviewers functionality....
r1769 """
Returns json struct of a reviewer for frontend
:param user: the reviewer
:param reasons: list of strings of why they are reviewers
:param mandatory: bool, to set user as mandatory
"""
reviewers: added observers as another way to define reviewers....
r4500 role = role or PullRequestReviewers.ROLE_REVIEWER
if role not in PullRequestReviewers.ROLES:
raise ValueError('role is not one of %s', PullRequestReviewers.ROLES)
pull-request: extended default reviewers functionality....
r1769
return {
'user_id': user.user_id,
events: re-organizate events handling....
r1789 'reasons': reasons or [],
default-reviewers: introduce new voting rule logic that allows...
r2484 'rules': rules or [],
reviewers: added observers as another way to define reviewers....
r4500 'role': role,
pull-request: extended default reviewers functionality....
r1769 'mandatory': mandatory,
default-reviewers: introduce new voting rule logic that allows...
r2484 'user_group': user_group,
pull-request: extended default reviewers functionality....
r1769 'username': user.username,
security: use new safe escaped user attributes across the application....
r1815 'first_name': user.first_name,
'last_name': user.last_name,
default-reviewers: introduce new voting rule logic that allows...
r2484 'user_link': h.link_to_user(user),
pull-request: extended default reviewers functionality....
r1769 'gravatar_link': h.gravatar_url(user.email, 14),
}
pull-requests: limit the ammount of data saved in default reviewers data for better memory usage...
r4509 def to_reviewers(e):
if isinstance(e, (tuple, list)):
return map(reviewer_as_json, e)
else:
return reviewer_as_json(e)
def get_default_reviewers_data(current_user, source_repo, source_ref, target_repo, target_ref,
include_diff_info=True):
pull-requests: fix way how pull-request calculates common ancestors....
r4346 """
Return json for default reviewers of a repository
"""
pull-request: extended default reviewers functionality....
r1769
pull-requests: limit the ammount of data saved in default reviewers data for better memory usage...
r4509 diff_info = {}
if include_diff_info:
diff_info = get_diff_info(
source_repo, source_ref.commit_id, target_repo, target_ref.commit_id)
pull-request: extended default reviewers functionality....
r1769
reasons = ['Default reviewer', 'Repository owner']
reviewers: use target repo owner as default reviewer in case of CE edition....
r3230 json_reviewers = [reviewer_as_json(
reviewers: added observers as another way to define reviewers....
r4500 user=target_repo.user, reasons=reasons, mandatory=False, rules=None, role=None)]
pull-request: extended default reviewers functionality....
r1769
pull-requests: limit the ammount of data saved in default reviewers data for better memory usage...
r4509 compute_key = rc_cache.utils.compute_key_from_params(
current_user.user_id, source_repo.repo_id, source_ref.type, source_ref.name,
source_ref.commit_id, target_repo.repo_id, target_ref.type, target_ref.name,
target_ref.commit_id)
pull-request: extended default reviewers functionality....
r1769 return {
pull-requests: fix way how pull-request calculates common ancestors....
r4346 'api_ver': REVIEWER_API_VERSION, # define version for later possible schema upgrade
pull-requests: limit the ammount of data saved in default reviewers data for better memory usage...
r4509 'compute_key': compute_key,
pull-requests: fix way how pull-request calculates common ancestors....
r4346 'diff_info': diff_info,
reviewers: use target repo owner as default reviewer in case of CE edition....
r3230 'reviewers': json_reviewers,
pull-request: extended default reviewers functionality....
r1769 'rules': {},
'rules_data': {},
}
def validate_default_reviewers(review_members, reviewer_rules):
"""
Function to validate submitted reviewers against the saved rules
"""
reviewers = []
reviewer_by_id = {}
for r in review_members:
reviewer_user_id = safe_int(r['user_id'])
reviewers: added observers as another way to define reviewers....
r4500 entry = (reviewer_user_id, r['reasons'], r['mandatory'], r['role'], r['rules'])
pull-request: extended default reviewers functionality....
r1769
reviewer_by_id[reviewer_user_id] = entry
reviewers.append(entry)
return reviewers
reviewers: added observers as another way to define reviewers....
r4500
def validate_observers(observer_members):
return {}