rhodecode-enterprise-ce Files · docs/code-review/approve-changes.rst

shadow-repos: use safer way to destroy shadow repositories....

shadow-repos: use safer way to destroy shadow repositories. we had reported errors on removal of shadow repos. Not reproduced, however suspecting are filesystem sync/symlink race-conditions on shared storage. End result were existing shadow-repo directories that tricked rhodecode into thinking shadow repos is existing, but infact it was a dummy structure semi-removed. Using shutil.move we ENSURE rhodecode doesn't read those back even if removal fails.

marcink - - Load All Authors

File last commit:

r1:854a839a default


                r2777:f1cc2e3d

default

Download file

             approve-changes.rst
        
                    12 lines
            
             | 353 B
            
                | text/x-rst
            
             |
                RstLexer
            
             / docs / code-review / approve-changes.rst
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        marcink
    
project: added all source files and assets

              r1
            
      .. _code-approve-changes-ref:

      Approve Code Changes

      --------------------

      To approve commits, use the following steps:

      1. Open the commit for review

      2. Leave your comments inline or in the message box.

      3. Set the review status from the drop-down menu and select :guilabel:`Comment`

      .. image:: ../images/set-ci-status.png

         :alt: Setting Commit Status

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

marcink project: added all source files and assets	r1	.. _code-approve-changes-ref:

		Approve Code Changes
		--------------------

		To approve commits, use the following steps:

		1. Open the commit for review
		2. Leave your comments inline or in the message box.
		3. Set the review status from the drop-down menu and select :guilabel:`Comment`

		.. image:: ../images/set-ci-status.png
		:alt: Setting Commit Status