rhodecode-enterprise-ce Files · docs/code-review/review-diffs.rst

shadow-repos: use safer way to destroy shadow repositories....

shadow-repos: use safer way to destroy shadow repositories. we had reported errors on removal of shadow repos. Not reproduced, however suspecting are filesystem sync/symlink race-conditions on shared storage. End result were existing shadow-repo directories that tricked rhodecode into thinking shadow repos is existing, but infact it was a dummy structure semi-removed. Using shutil.move we ENSURE rhodecode doesn't read those back even if removal fails.

marcink - - Load All Authors

File last commit:

r1:854a839a default


                r2777:f1cc2e3d

default

Download file

             review-diffs.rst
        
                    42 lines
            
             | 1.0 KiB
            
                | text/x-rst
            
             |
                RstLexer
            
             / docs / code-review / review-diffs.rst
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        marcink
    
project: added all source files and assets

              r1
            
      .. _code-diff-side-ref:

      Reviewing Diffs

      ---------------

      Diffs are representations of changes made between different changesets of

      a file. |RCE| provides 4 different types of diffs for each commit or

      changeset, and depending on your preference you can use whichever for code

      review purposes.

      * Plain diff

      * Full diff

      * Side-by-side diff

      * Raw diff

      Reviewing Changes

      -----------------

      |RCM| displays all code changes made with each commit. Removed content is

      marked in red and new content in green.

      .. image:: ../images/plain-diff.png

         :alt: Plain Diff

      Side-By-Side Diffs

      ------------------

      To review code with a side-by-side diff, use the following steps:

      1. Open the repository in which you wish to review a file

      2. Select the revision you wish to review

      3. Select the side-by-side diff icon beside the file name

      .. image:: ../images/side-by-side-diff.png

         :alt: Side by side diff

      Notifying Users

      ---------------

      To notify other users of you comments, or requests for feedback,

      see :ref:`review-notifications-ref`

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

marcink project: added all source files and assets	r1	.. _code-diff-side-ref:

		Reviewing Diffs
		---------------

		Diffs are representations of changes made between different changesets of
		a file. \|RCE\| provides 4 different types of diffs for each commit or
		changeset, and depending on your preference you can use whichever for code
		review purposes.

		* Plain diff
		* Full diff
		* Side-by-side diff
		* Raw diff

		Reviewing Changes
		-----------------

		\|RCM\| displays all code changes made with each commit. Removed content is
		marked in red and new content in green.

		.. image:: ../images/plain-diff.png
		:alt: Plain Diff

		Side-By-Side Diffs
		------------------

		To review code with a side-by-side diff, use the following steps:

		1. Open the repository in which you wish to review a file
		2. Select the revision you wish to review
		3. Select the side-by-side diff icon beside the file name

		.. image:: ../images/side-by-side-diff.png
		:alt: Side by side diff


		Notifying Users
		---------------

		To notify other users of you comments, or requests for feedback,
		see :ref:`review-notifications-ref`