rhodecode-enterprise-ce Files · docs/collaboration/review-pull-request.rst

shadow-repos: use safer way to destroy shadow repositories....

shadow-repos: use safer way to destroy shadow repositories. we had reported errors on removal of shadow repos. Not reproduced, however suspecting are filesystem sync/symlink race-conditions on shared storage. End result were existing shadow-repo directories that tricked rhodecode into thinking shadow repos is existing, but infact it was a dummy structure semi-removed. Using shutil.move we ENSURE rhodecode doesn't read those back even if removal fails.

marcink - - Load All Authors

File last commit:

r1:854a839a default


                r2777:f1cc2e3d

default

Download file

             review-pull-request.rst
        
                    27 lines
            
             | 850 B
            
                | text/x-rst
            
             |
                RstLexer
            
             / docs / collaboration / review-pull-request.rst
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        marcink
    
project: added all source files and assets

              r1
            
      .. _review-requests-ref:

      Review a |pr|

      -------------

      To review a pull request, use the following steps:

      1. Open the review request from

         :menuselection:`Admin --> Repositories --> repo name --> Pull Requests --> Awaiting my review`

      2. Leave your review comments inline, or in the commit message.

      3. Set the review status from one of the following options:

         * :guilabel:`Not Reviewed`

         * :guilabel:`Approved`

         * :guilabel:`Approved & Closed`

         * :guilabel:`Rejected`

         * :guilabel:`Rejected & Closed`

         * :guilabel:`Under Review`

      4. Select Comment

      When the |pr| is approved by all reviewers you will be able to merge

      automatically if |RCM| detects that it can do so safely. You will see this

      message: `This pull request can be automatically merged.`

      If rejected, you can fix the issues raised during review and then update the

      |pr|.

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

marcink project: added all source files and assets	r1	.. _review-requests-ref:

		Review a \|pr\|
		-------------

		To review a pull request, use the following steps:

		1. Open the review request from
		:menuselection:`Admin --> Repositories --> repo name --> Pull Requests --> Awaiting my review`
		2. Leave your review comments inline, or in the commit message.
		3. Set the review status from one of the following options:

		* :guilabel:`Not Reviewed`
		* :guilabel:`Approved`
		* :guilabel:`Approved & Closed`
		* :guilabel:`Rejected`
		* :guilabel:`Rejected & Closed`
		* :guilabel:`Under Review`

		4. Select Comment

		When the \|pr\| is approved by all reviewers you will be able to merge
		automatically if \|RCM\| detects that it can do so safely. You will see this
		message: `This pull request can be automatically merged.`

		If rejected, you can fix the issues raised during review and then update the
		\|pr\|.