diff --git a/rhodecode/lib/codeblocks.py b/rhodecode/lib/codeblocks.py --- a/rhodecode/lib/codeblocks.py +++ b/rhodecode/lib/codeblocks.py @@ -368,19 +368,18 @@ class DiffSet(object): adding highlighting, side by side/unified renderings and line diffs """ - HL_REAL = 'REAL' # highlights using original file, slow - HL_FAST = 'FAST' # highlights using just the line, fast but not correct - # in the case of multiline code - HL_NONE = 'NONE' # no highlighting, fastest + HL_REAL = 'REAL' # highlights using original file, slow + HL_FAST = 'FAST' # highlights using just the line, fast but not correct + # in the case of multiline code + HL_NONE = 'NONE' # no highlighting, fastest def __init__(self, highlight_mode=HL_REAL, repo_name=None, source_repo_name=None, source_node_getter=lambda filename: None, target_node_getter=lambda filename: None, source_nodes=None, target_nodes=None, - max_file_size_limit=150 * 1024, # files over this size will - # use fast highlighting - comments=None, + # files over this size will use fast highlighting + max_file_size_limit=150 * 1024, ): self.highlight_mode = highlight_mode @@ -391,8 +390,6 @@ class DiffSet(object): self.target_nodes = target_nodes or {} self.repo_name = repo_name self.source_repo_name = source_repo_name or repo_name - self.comments = comments or {} - self.comments_store = self.comments.copy() self.max_file_size_limit = max_file_size_limit def render_patchset(self, patchset, source_ref=None, target_ref=None): @@ -518,20 +515,6 @@ class DiffSet(object): hunkbit.target_file_path = target_file_path filediff.hunks.append(hunkbit) - left_comments = {} - if source_file_path in self.comments_store: - for lineno, comments in self.comments_store[source_file_path].items(): - left_comments[lineno] = comments - - if target_file_path in self.comments_store: - for lineno, comments in self.comments_store[target_file_path].items(): - left_comments[lineno] = comments - - # left comments are one that we couldn't place in diff lines. - # could be outdated, or the diff changed and this line is no - # longer available - filediff.left_comments = left_comments - return filediff def parse_hunk(self, hunk, source_file, target_file): diff --git a/rhodecode/templates/changeset/changeset_file_comment.mako b/rhodecode/templates/changeset/changeset_file_comment.mako --- a/rhodecode/templates/changeset/changeset_file_comment.mako +++ b/rhodecode/templates/changeset/changeset_file_comment.mako @@ -28,7 +28,7 @@
-
+
% if comment.comment_type == 'todo': % if comment.resolved:
diff --git a/rhodecode/templates/codeblocks/diffs.mako b/rhodecode/templates/codeblocks/diffs.mako --- a/rhodecode/templates/codeblocks/diffs.mako +++ b/rhodecode/templates/codeblocks/diffs.mako @@ -223,37 +223,59 @@ collapse_all = len(diffset.files) > coll %endif %endfor + <% unmatched_comments = (inline_comments or {}).get(filediff.patch['filename'], {}) %> + ## outdated comments that do not fit into currently displayed lines - % for lineno, comments in filediff.left_comments.items(): + % for lineno, comments in unmatched_comments.items(): - %if c.diffmode == 'unified': - - - - - - ${inline_comments_container(comments, inline_comments)} - - - %elif c.diffmode == 'sideside': - - - - - % if lineno.startswith('o'): + %if c.diffmode == 'unified': + % if loop.index == 0: + + + +
+ ${_('Unmatched inline comments below')} +
+ + + % endif + + + + + ${inline_comments_container(comments, inline_comments)} - % endif - + + + %elif c.diffmode == 'sideside': + % if loop.index == 0: + + + +
+ ${_('Unmatched comments below')} +
+ + + % endif + + + + + % if lineno.startswith('o'): + ${inline_comments_container(comments, inline_comments)} + % endif + - - - - % if lineno.startswith('n'): - ${inline_comments_container(comments, inline_comments)} - % endif - - - %endif + + + + % if lineno.startswith('n'): + ${inline_comments_container(comments, inline_comments)} + % endif + + + %endif % endfor @@ -512,18 +534,20 @@ from rhodecode.lib.diffs import NEW_FILE <%! -def get_comments_for(comments, filename, line_version, line_number): +def get_comments_for(diff_type, comments, filename, line_version, line_number): if hasattr(filename, 'unicode_path'): filename = filename.unicode_path if not isinstance(filename, basestring): return None - line_key = '{}{}'.format(line_version, line_number) + line_key = '{}{}'.format(line_version, line_number) ## e.g o37, n12 + if comments and filename in comments: file_comments = comments[filename] if line_key in file_comments: - return file_comments[line_key] + data = file_comments.pop(line_key) + return data %> <%def name="render_hunk_lines_sideside(hunk, use_comments=False, inline_comments=None)"> @@ -542,16 +566,17 @@ def get_comments_for(comments, filename, data-line-no="${line.original.lineno}" >
- <% loc = None %> + + <% line_old_comments = None %> %if line.original.get_comment_args: - <% loc = get_comments_for(inline_comments, *line.original.get_comment_args) %> + <% line_old_comments = get_comments_for('side-by-side', inline_comments, *line.original.get_comment_args) %> %endif - %if loc: - <% has_outdated = any([x.outdated for x in loc]) %> + %if line_old_comments: + <% has_outdated = any([x.outdated for x in line_old_comments]) %> % if has_outdated: - + % else: - + % endif %endif
@@ -574,8 +599,8 @@ def get_comments_for(comments, filename, %endif ${line.original.action} ${line.original.content or '' | n} - %if use_comments and line.original.lineno and loc: - ${inline_comments_container(loc, inline_comments)} + %if use_comments and line.original.lineno and line_old_comments: + ${inline_comments_container(line_old_comments, inline_comments)} %endif @@ -585,16 +610,16 @@ def get_comments_for(comments, filename,
%if line.modified.get_comment_args: - <% lmc = get_comments_for(inline_comments, *line.modified.get_comment_args) %> + <% line_new_comments = get_comments_for('side-by-side', inline_comments, *line.modified.get_comment_args) %> %else: - <% lmc = None%> + <% line_new_comments = None%> %endif - %if lmc: - <% has_outdated = any([x.outdated for x in lmc]) %> + %if line_new_comments: + <% has_outdated = any([x.outdated for x in line_new_comments]) %> % if has_outdated: - + % else: - + % endif %endif
@@ -616,8 +641,8 @@ def get_comments_for(comments, filename, ${render_add_comment_button()} %endif ${line.modified.action} ${line.modified.content or '' | n} - %if use_comments and line.modified.lineno and lmc: - ${inline_comments_container(lmc, inline_comments)} + %if use_comments and line.modified.lineno and line_new_comments: + ${inline_comments_container(line_new_comments, inline_comments)} %endif @@ -639,7 +664,7 @@ def get_comments_for(comments, filename,
%if comments_args: - <% comments = get_comments_for(inline_comments, *comments_args) %> + <% comments = get_comments_for('unified', inline_comments, *comments_args) %> %else: <% comments = None%> %endif