diff --git a/rhodecode/api/tests/test_get_repo_changeset.py b/rhodecode/api/tests/test_get_repo_changeset.py --- a/rhodecode/api/tests/test_get_repo_changeset.py +++ b/rhodecode/api/tests/test_get_repo_changeset.py @@ -54,7 +54,7 @@ class TestGetRepoChangeset(object): details=details, ) response = api_call(self.app, params) - expected = 'commit_id must be a string value' + expected = "commit_id must be a string value got instead" assert_error(id_, expected, given=response.body) @pytest.mark.parametrize("details", ['basic', 'extended', 'full']) @@ -137,5 +137,5 @@ class TestGetRepoChangeset(object): details=details, ) response = api_call(self.app, params) - expected = 'commit_id must be a string value' + expected = "commit_id must be a string value got instead" assert_error(id_, expected, given=response.body) diff --git a/rhodecode/lib/vcs/backends/base.py b/rhodecode/lib/vcs/backends/base.py --- a/rhodecode/lib/vcs/backends/base.py +++ b/rhodecode/lib/vcs/backends/base.py @@ -735,7 +735,7 @@ class BaseRepository(object): def _validate_commit_id(self, commit_id): if not isinstance(commit_id, compat.string_types): - raise TypeError("commit_id must be a string value") + raise TypeError("commit_id must be a string value got {} instead".format(type(commit_id))) def _validate_commit_idx(self, commit_idx): if not isinstance(commit_idx, (int, long)): diff --git a/rhodecode/templates/codeblocks/diffs.mako b/rhodecode/templates/codeblocks/diffs.mako --- a/rhodecode/templates/codeblocks/diffs.mako +++ b/rhodecode/templates/codeblocks/diffs.mako @@ -367,15 +367,17 @@ return '%s_%s_%i' % (h.md5_safe(commit+f ## outdated comments that are made for a file that has been deleted % for filename, comments_dict in (deleted_files_comments or {}).items(): + <% display_state = 'display: none' open_comments_in_file = [x for x in comments_dict['comments'] if x.outdated is False] if open_comments_in_file: display_state = '' + fid = str(id(filename)) %>
-
+