diff --git a/rhodecode/apps/admin/tests/test_admin_settings.py b/rhodecode/apps/admin/tests/test_admin_settings.py --- a/rhodecode/apps/admin/tests/test_admin_settings.py +++ b/rhodecode/apps/admin/tests/test_admin_settings.py @@ -485,7 +485,7 @@ class TestAdminSystemInfo(object): update_data = { 'versions': [ { - 'version': '100.3.1415926535', + 'version': '100.0.0', 'general': 'The latest version we are ever going to ship' }, { @@ -502,15 +502,15 @@ class TestAdminSystemInfo(object): update_data = { 'versions': [ { - 'version': '0.0.0', + 'version': '4.0.0', 'general': 'The first version we ever shipped' } ] } + text = f"Your current version, {rhodecode.__version__}, is up-to-date as it is equal to or newer than the latest available version, 4.0.0." with mock.patch(UPDATE_DATA_QUALNAME, return_value=update_data): response = self.app.get(route_path('admin_settings_system_update')) - response.mustcontain( - 'This instance is already running the latest stable version') + response.mustcontain(text) def test_system_update_bad_response(self, autologin_user): with mock.patch(UPDATE_DATA_QUALNAME, side_effect=ValueError('foo')): diff --git a/rhodecode/templates/admin/settings/settings_system.mako b/rhodecode/templates/admin/settings/settings_system.mako --- a/rhodecode/templates/admin/settings/settings_system.mako +++ b/rhodecode/templates/admin/settings/settings_system.mako @@ -84,6 +84,6 @@ diff --git a/rhodecode/templates/admin/settings/settings_system_update.mako b/rhodecode/templates/admin/settings/settings_system_update.mako --- a/rhodecode/templates/admin/settings/settings_system_update.mako +++ b/rhodecode/templates/admin/settings/settings_system_update.mako @@ -1,25 +1,30 @@ ## upgrade block rendered afte on-click check
-

+ %if c.should_upgrade: - A new version is available: + A new version is available ! +
+
+ %if c.latest_data.get('title'): - ${h.literal(c.latest_data['title'])} + RhodeCode ${c.latest_ver} - ${h.literal(c.latest_data['title'])} %else: - ${c.latest_ver} + RhodeCode ${c.latest_ver} %endif %else: - This instance is already running the latest stable version ${c.latest_ver}. + Your current version, ${c.cur_ver}, is up-to-date as it is equal to or newer than the latest available version, ${c.latest_ver}. %endif -

+ % if c.should_upgrade and c.important_notices: -
Important notes for this release:
- % endif +