# HG changeset patch # User Martin Bornhold # Date 2016-10-06 14:10:40 # Node ID 21c331ba4eeb08d2708d5fbcf8b6e0897040e599 # Parent 706ee3c3416c8a94216e4e0f38504632270c5985 vcs: Remove custom response header which contains backend key. We used this custom header to skip the error handling. This is no linger needed since the VCS middleware is moved above of the error handling. diff --git a/rhodecode/lib/middleware/simplesvn.py b/rhodecode/lib/middleware/simplesvn.py --- a/rhodecode/lib/middleware/simplesvn.py +++ b/rhodecode/lib/middleware/simplesvn.py @@ -89,10 +89,6 @@ class SimpleSvnApp(object): if h.lower() not in self.IGNORED_HEADERS ] - # Add custom response header to indicate that this is a VCS response - # and which backend is used. - headers.append(('X-RhodeCode-Backend', 'svn')) - return headers diff --git a/rhodecode/lib/middleware/utils/scm_app_http.py b/rhodecode/lib/middleware/utils/scm_app_http.py --- a/rhodecode/lib/middleware/utils/scm_app_http.py +++ b/rhodecode/lib/middleware/utils/scm_app_http.py @@ -116,10 +116,6 @@ class VcsHttpProxy(object): if not wsgiref.util.is_hop_by_hop(h) ] - # Add custom response header to indicate that this is a VCS response - # and which backend is used. - response_headers.append(('X-RhodeCode-Backend', self._backend)) - # TODO: johbo: Better way to get the status including text? status = str(response.status_code) start_response(status, response_headers) diff --git a/rhodecode/lib/middleware/utils/wsgi_app_caller_client.py b/rhodecode/lib/middleware/utils/wsgi_app_caller_client.py --- a/rhodecode/lib/middleware/utils/wsgi_app_caller_client.py +++ b/rhodecode/lib/middleware/utils/wsgi_app_caller_client.py @@ -94,10 +94,6 @@ class RemoteAppCaller(object): data, status, headers = self._remote_wsgi.handle( clean_environ, input_data, *self._args, **self._kwargs) - # Add custom response header to indicate that this is a VCS response - # and which backend is used. - headers.append(('X-RhodeCode-Backend', self._backend)) - log.debug("Got result from proxy, returning to WSGI container") start_response(status, headers) diff --git a/rhodecode/tests/lib/middleware/test_simplesvn.py b/rhodecode/tests/lib/middleware/test_simplesvn.py --- a/rhodecode/tests/lib/middleware/test_simplesvn.py +++ b/rhodecode/tests/lib/middleware/test_simplesvn.py @@ -157,7 +157,6 @@ class TestSimpleSvnApp(object): expected_headers = [ ('MS-Author-Via', 'DAV'), ('SVN-Supported-Posts', 'create-txn-with-props'), - ('X-RhodeCode-Backend', 'svn'), ] response_headers = self.app._get_response_headers(headers) assert sorted(response_headers) == sorted(expected_headers) @@ -192,7 +191,6 @@ class TestSimpleSvnApp(object): expected_response_headers = [ ('SVN-Supported-Posts', 'create-txn-with-props'), ('MS-Author-Via', 'DAV'), - ('X-RhodeCode-Backend', 'svn'), ] request_mock.assert_called_once_with( self.environment['REQUEST_METHOD'], expected_url,