# HG changeset patch
# User Marcin Kuzminski <marcin@rhodecode.com>
# Date 2018-06-19 10:35:45
# Node ID 241bd1e7b39c0feab3751b1b36d4f3cdb67cfb43
# Parent  f77aceafe42d2aca6e75f30e92532d2917c53330

pull-requests: fixed case of unresolved comments attached to removed file in pr.

- This makes removed files that still have unresolved TODO visible. Before
those file were hidden and unable to merge because of TODO requirements.

diff --git a/rhodecode/templates/codeblocks/diffs.mako b/rhodecode/templates/codeblocks/diffs.mako
--- a/rhodecode/templates/codeblocks/diffs.mako
+++ b/rhodecode/templates/codeblocks/diffs.mako
@@ -263,8 +263,13 @@ collapse_all = len(diffset.files) > coll
 
     ## outdated comments that are made for a file that has been deleted
     % for filename, comments_dict in (deleted_files_comments or {}).items():
-
-        <div class="filediffs filediff-outdated" style="display: none">
+        <%
+            display_state = 'display: none'
+            open_comments_in_file = [x for x in comments_dict['comments'] if x.outdated is False]
+            if open_comments_in_file:
+                display_state = ''
+        %>
+        <div class="filediffs filediff-outdated" style="${display_state}">
             <input ${collapse_all and 'checked' or ''} class="filediff-collapse-state" id="filediff-collapse-${id(filename)}" type="checkbox">
             <div class="filediff" data-f-path="${filename}"  id="a_${h.FID('', filename)}">
                 <label for="filediff-collapse-${id(filename)}" class="filediff-heading">
@@ -291,7 +296,7 @@ collapse_all = len(diffset.files) > coll
 
                         <td></td>
                         <td class="cb-text cb-${op_class(BIN_FILENODE)}" ${c.diffmode == 'unified' and 'colspan=4' or 'colspan=5'}>
-                        ${_('File was deleted in this version, and outdated comments were made on it')}
+                        ${_('File was deleted in this version. There are still outdated/unresolved comments attached to it.')}
                         </td>
                     </tr>
                     %if c.diffmode == 'unified':