# HG changeset patch
# User Marcin Kuzminski <marcin@rhodecode.com>
# Date 2018-06-18 18:39:02
# Node ID 5a43c6a792ca73ec46f345858ff92f85b12bba06
# Parent  ce641b45650035f89dbd8061cf25f5ac9de6246a

pull-requests: lock submit on pull request to prevent double submission on fast click.

diff --git a/rhodecode/public/js/src/rhodecode/pullrequests.js b/rhodecode/public/js/src/rhodecode/pullrequests.js
--- a/rhodecode/public/js/src/rhodecode/pullrequests.js
+++ b/rhodecode/public/js/src/rhodecode/pullrequests.js
@@ -41,10 +41,10 @@ var prButtonLock = function(lockEnabled,
       }
       var checksMeet = prButtonLockChecks.compare && prButtonLockChecks.reviewers;
       if (lockEnabled) {
-          $('#save').attr('disabled', 'disabled');
+          $('#pr_submit').attr('disabled', 'disabled');
       }
       else if (checksMeet) {
-          $('#save').removeAttr('disabled');
+          $('#pr_submit').removeAttr('disabled');
       }
 
       if (msg) {
diff --git a/rhodecode/templates/pullrequests/pullrequest.mako b/rhodecode/templates/pullrequests/pullrequest.mako
--- a/rhodecode/templates/pullrequests/pullrequest.mako
+++ b/rhodecode/templates/pullrequests/pullrequest.mako
@@ -98,7 +98,7 @@
                             </div>
                             <div class="input">
                                 <div class="pr-submit-button">
-                                    ${h.submit('save',_('Submit Pull Request'),class_="btn")}
+                                    <input id="pr_submit" class="btn" name="save" type="submit" value="${_('Submit Pull Request')}">
                                 </div>
                                 <div id="pr_open_message"></div>
                             </div>
@@ -171,6 +171,7 @@
   var defaultTargetRepoData = ${c.default_repo_data['target_refs_json']|n};
 
   var $pullRequestForm = $('#pull_request_form');
+  var $pullRequestSubmit = $('#pr_submit', $pullRequestForm);
   var $sourceRepo = $('#source_repo', $pullRequestForm);
   var $targetRepo = $('#target_repo', $pullRequestForm);
   var $sourceRef = $('#source_ref', $pullRequestForm);
@@ -510,6 +511,10 @@
 
   });
 
+  $pullRequestForm.on('submit', function(e){
+      prButtonLock(true, null, 'all');
+  });
+
   prButtonLock(true, "${_('Please select source and target')}", 'all');
 
   // auto-load on init, the target refs select2