# HG changeset patch
# User Marcin Kuzminski <marcin@rhodecode.com>
# Date 2019-10-28 10:09:38
# Node ID 5bbd362b99b3620f0a45b76cd6bec78aba89f48d
# Parent  de7d5f3b83a7be941c3d4ce34a07acf1633bb088

diffs: fixed outdated files in pull-requests re-using the filediff raw_id for anchor generation.

In some cases when there are no longer any files this caused error since filediff wasn't present.
In addition this generated wrong ids since it used a last-defined attribute on a for loop.

Fixes #5567

diff --git a/rhodecode/templates/codeblocks/diffs.mako b/rhodecode/templates/codeblocks/diffs.mako
--- a/rhodecode/templates/codeblocks/diffs.mako
+++ b/rhodecode/templates/codeblocks/diffs.mako
@@ -290,10 +290,12 @@ collapse_all = len(diffset.files) > coll
             open_comments_in_file = [x for x in comments_dict['comments'] if x.outdated is False]
             if open_comments_in_file:
                 display_state = ''
+            fid = str(id(filename))
         %>
         <div class="filediffs filediff-outdated" style="${display_state}">
             <input ${(collapse_all and 'checked' or '')} class="filediff-collapse-state" id="filediff-collapse-${id(filename)}" type="checkbox" onchange="updateSticky();">
-            <div class="filediff" data-f-path="${filename}"  id="a_${h.FID(filediff.raw_id, filename)}">
+            <div class="filediff" data-f-path="${filename}"  id="a_${h.FID(fid, filename)}">
+
                 <label for="filediff-collapse-${id(filename)}" class="filediff-heading">
                     <div class="filediff-collapse-indicator"></div>
                     <span class="pill">
@@ -304,7 +306,7 @@ collapse_all = len(diffset.files) > coll
                         ## file op, doesn't need translation
                         <span class="pill" op="removed">removed in this version</span>
                     </span>
-                    <a class="pill filediff-anchor" href="#a_${h.FID(filediff.raw_id, filename)}">¶</a>
+                    <a class="pill filediff-anchor" href="#a_${h.FID(fid, filename)}">¶</a>
                     <span class="pill-group" style="float: right">
                         <span class="pill" op="deleted">-${comments_dict['stats']}</span>
                     </span>