# HG changeset patch # User Marcin Kuzminski # Date 2017-09-20 18:27:28 # Node ID ba9e03f02f66a287b2ffd2d03fb4da5c72cdfb0b # Parent 44a9216248327f72aba62aa8277d528c50dbd95b user-groups-audit: properly link to user_group when doing api actions of remove and add an user on user group. diff --git a/rhodecode/api/views/user_group_api.py b/rhodecode/api/views/user_group_api.py --- a/rhodecode/api/views/user_group_api.py +++ b/rhodecode/api/views/user_group_api.py @@ -464,6 +464,7 @@ def add_user_to_user_group(request, apiu raise JSONRPCError('user group `%s` does not exist' % ( usergroupid,)) + old_values = user_group.get_api_data() try: ugm = UserGroupModel().add_user_to_group(user_group, user) success = True if ugm is not True else False @@ -474,7 +475,8 @@ def add_user_to_user_group(request, apiu if success: user_data = user.get_api_data() audit_logger.store_api( - 'user_group.edit.member.add', action_data={'user': user_data}, + 'user_group.edit.member.add', + action_data={'user': user_data, 'old_data': old_values}, user=apiuser) Session().commit() @@ -534,6 +536,7 @@ def remove_user_from_user_group(request, raise JSONRPCError( 'user group `%s` does not exist' % (usergroupid,)) + old_values = user_group.get_api_data() try: success = UserGroupModel().remove_user_from_group(user_group, user) msg = 'removed member `%s` from user group `%s`' % ( @@ -543,7 +546,8 @@ def remove_user_from_user_group(request, if success: user_data = user.get_api_data() audit_logger.store_api( - 'user_group.edit.member.delete', action_data={'user': user_data}, + 'user_group.edit.member.delete', + action_data={'user': user_data, 'old_data': old_values}, user=apiuser) Session().commit()