# HG changeset patch # User Marcin Kuzminski # Date 2017-10-17 18:32:23 # Node ID d21fb0df6cda686da696bdff89df1876c94432e6 # Parent ea8785586b24d08370bd49d97645e82b1919ab30 db: prevent empty IN queries that generally are performance problem, and triggers sql warnings. diff --git a/rhodecode/apps/admin/views/user_groups.py b/rhodecode/apps/admin/views/user_groups.py --- a/rhodecode/apps/admin/views/user_groups.py +++ b/rhodecode/apps/admin/views/user_groups.py @@ -100,7 +100,7 @@ class AdminUserGroupsView(BaseAppView, D auth_user_group_list = UserGroupList( UserGroup.query().all(), perm_set=['usergroup.admin']) - allowed_ids = [] + allowed_ids = [-1] for user_group in auth_user_group_list: allowed_ids.append(user_group.users_group_id) diff --git a/rhodecode/apps/repository/views/repo_forks.py b/rhodecode/apps/repository/views/repo_forks.py --- a/rhodecode/apps/repository/views/repo_forks.py +++ b/rhodecode/apps/repository/views/repo_forks.py @@ -90,7 +90,7 @@ class RepoForksView(RepoAppView, DataGri acl_check = HasRepoPermissionAny( 'repository.read', 'repository.write', 'repository.admin') repo_id = self.db_repo.repo_id - allowed_ids = [] + allowed_ids = [-1] for f in Repository.query().filter(Repository.fork_id == repo_id): if acl_check(f.repo_name, 'get forks check'): allowed_ids.append(f.repo_id)