# HG changeset patch # User Marcin Kuzminski # Date 2019-10-23 12:57:44 # Node ID f55b1af6b559383bc70e36e360cfe83b8694e4d7 # Parent 786403b10c68c1964e72e2eef461f59ee8541ba0 tests: fixed some warnings on tests diff --git a/rhodecode/tests/vcs_operations/conftest.py b/rhodecode/tests/vcs_operations/conftest.py --- a/rhodecode/tests/vcs_operations/conftest.py +++ b/rhodecode/tests/vcs_operations/conftest.py @@ -280,10 +280,13 @@ def branch_permission_setter(request): rule_id = None write_perm_id = None + write_perm = None + rule = None def _branch_permissions_setter( repo_name, username, pattern='*', permission='branch.push_force'): global rule_id, write_perm_id + global rule, write_perm repo = Repository.get_by_repo_name(repo_name) repo_id = repo.repo_id @@ -293,8 +296,6 @@ def branch_permission_setter(request): rule_perm_obj = Permission.get_by_key(permission) - write_perm = None - # add new entry, based on existing perm entry perm = UserRepoToPerm.query() \ .filter(UserRepoToPerm.repository_id == repo_id) \ @@ -323,8 +324,6 @@ def branch_permission_setter(request): Session().add(rule) Session().commit() - global rule, write_perm - return rule @request.addfinalizer