# HG changeset patch
# User Martin Bornhold <martin@rhodecode.com>
# Date 2016-06-28 10:07:10
# Node ID f9e2ba9bf4f9fc421ec58cc5d4041948d6b90429
# Parent  f65fe1f1c9292e9da39b200a17b1c1d1ef0504cc

authn: Only lookup settings from DB if they are really used.

When computing the form defaults only query the DB if we
need the value from DB.

diff --git a/rhodecode/authentication/views.py b/rhodecode/authentication/views.py
--- a/rhodecode/authentication/views.py
+++ b/rhodecode/authentication/views.py
@@ -59,9 +59,9 @@ class AuthnPluginViewBase(object):
         # Compute default values for the form. Priority is:
         # 1. Passed to this method 2. DB value 3. Schema default
         for node in schema:
-            value = self.plugin.get_setting_by_name(
-                node.name, node.default)
-            defaults.setdefault(node.name, value)
+            if node.name not in defaults:
+                defaults[node.name] = self.plugin.get_setting_by_name(
+                    node.name, node.default)
 
         template_context = {
             'defaults': defaults,