# HG changeset patch
# User RhodeCode Admin <admin@rhodecode.com>
# Date 2024-06-18 12:03:06
# Node ID fdcdfe77962af5829836caafedf6a461b8376d48
# Parent  06dae70ce5c71088ec9b81ed3666fe44f8f6b383

feat(archive-cache): added option to define a configurable top-level bucket for all shards

diff --git a/rhodecode/config/config_maker.py b/rhodecode/config/config_maker.py
--- a/rhodecode/config/config_maker.py
+++ b/rhodecode/config/config_maker.py
@@ -204,6 +204,7 @@ def sanitize_settings_and_apply_defaults
     settings_maker.make_setting('archive_cache.objectstore.url', jn(default_cache_dir, 'archive_cache'), default_when_empty=True,)
     settings_maker.make_setting('archive_cache.objectstore.key', '')
     settings_maker.make_setting('archive_cache.objectstore.secret', '')
+    settings_maker.make_setting('archive_cache.objectstore.bucket_root', 'rhodecode-archive-cache')
     settings_maker.make_setting('archive_cache.objectstore.bucket_shards', 8, parser='int')
 
     settings_maker.make_setting('archive_cache.objectstore.cache_size_gb', 10, parser='float')
diff --git a/rhodecode/lib/archive_cache/backends/fanout_cache.py b/rhodecode/lib/archive_cache/backends/fanout_cache.py
--- a/rhodecode/lib/archive_cache/backends/fanout_cache.py
+++ b/rhodecode/lib/archive_cache/backends/fanout_cache.py
@@ -115,6 +115,7 @@ class FileSystemShard(BaseShard):
 
 
 class FileSystemFanoutCache(BaseCache):
+    shard_name = 'shard_%03d'
 
     def __init__(self, locking_url, **settings):
         """
@@ -150,7 +151,7 @@ class FileSystemFanoutCache(BaseCache):
         self._shards = tuple(
             FileSystemShard(
                 index=num,
-                directory=os.path.join(directory, 'shard_%03d' % num),
+                directory=os.path.join(directory, self.shard_name % num),
                 **settings,
             )
             for num in range(self._count)
diff --git a/rhodecode/lib/archive_cache/backends/objectstore_cache.py b/rhodecode/lib/archive_cache/backends/objectstore_cache.py
--- a/rhodecode/lib/archive_cache/backends/objectstore_cache.py
+++ b/rhodecode/lib/archive_cache/backends/objectstore_cache.py
@@ -41,12 +41,15 @@ class S3Shard(BaseShard):
         key = settings.pop('archive_cache.objectstore.key')
         secret = settings.pop('archive_cache.objectstore.secret')
 
+        # TODO: Add it all over the place...
+        self._bucket_root = settings.pop('archive_cache.objectstore.bucket_root')
+
         self.fs = fsspec.filesystem('s3', anon=False, endpoint_url=endpoint_url, key=key, secret=secret)
 
     @property
     def bucket(self):
         """Cache bucket."""
-        return self._bucket
+        return os.path.join(self._bucket_root, self._bucket)
 
     def _get_keyfile(self, archive_key) -> tuple[str, str]:
         key_file = f'{archive_key}-{self.key_suffix}'
@@ -56,6 +59,10 @@ class S3Shard(BaseShard):
         return self.fs.open(path, 'wb')
 
     def _write_file(self, full_path, iterator, mode):
+        if self._bucket_root:
+            if not self.fs.exists(self._bucket_root):
+                self.fs.mkdir(self._bucket_root)
+
         # ensure bucket exists
         destination = self.bucket
         if not self.fs.exists(destination):
@@ -106,6 +113,7 @@ class S3Shard(BaseShard):
 
 
 class ObjectStoreCache(BaseCache):
+    shard_name = 'shard-bucket-%03d'
 
     def __init__(self, locking_url, **settings):
         """
@@ -134,7 +142,7 @@ class ObjectStoreCache(BaseCache):
         self._shards = tuple(
             S3Shard(
                 index=num,
-                bucket='rhodecode-archivecache-%03d' % num,
+                bucket=self.shard_name % num,
                 **settings,
             )
             for num in range(self._count)