Public user group profile Task #5326

rhodecode/apps/user_group_profile/__init__.py

@@ -0,0 +1,27 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2018 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+
+def includeme(config):
+    config.add_route(
+        name='user_group_profile',
+        pattern='/_profile_user_group/{user_group_name}')
+    # Scan module for configuration decorators.
+    config.scan('.views', ignore='.tests')

rhodecode/apps/user_group_profile/tests/__init__.py

@@ -0,0 +1,19 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2018 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/

rhodecode/apps/user_group_profile/tests/test_user_group.py

@@ -0,0 +1,76 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2010-2018 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+from rhodecode.model.user_group import UserGroupModel
+from rhodecode.tests import (
+    TestController, TEST_USER_REGULAR_LOGIN, TEST_USER_REGULAR_PASS)
+from rhodecode.tests.fixture import Fixture
+from rhodecode.tests.utils import AssertResponse
+
+fixture = Fixture()
+
+
+def route_path(name, **kwargs):
+    return '/_profile_user_group/{user_group_name}'.format(**kwargs)
+
+
+class TestUsersController(TestController):
+
+    def test_user_group_profile(self, user_util):
+        self.log_user(TEST_USER_REGULAR_LOGIN, TEST_USER_REGULAR_PASS)
+        user, usergroup = user_util.create_user_with_group()
+
+        response = self.app.get(route_path('profile_user_group', user_group_name=usergroup.users_group_name))
+        response.mustcontain(usergroup.users_group_name)
+        response.mustcontain(user.username)
+
+    def test_user_can_check_own_group(self, user_util):
+        user = user_util.create_user(
+            TEST_USER_REGULAR_LOGIN, password=TEST_USER_REGULAR_PASS, email='[e-mail]')
+        self.log_user(TEST_USER_REGULAR_LOGIN, TEST_USER_REGULAR_PASS)
+        usergroup = user_util.create_user_group(owner=user)
+        response = self.app.get(route_path('profile_user_group', user_group_name=usergroup.users_group_name))
+        response.mustcontain(usergroup.users_group_name)
+        response.mustcontain(user.username)
+
+    def test_user_can_not_check_other_group(self, user_util):
+        self.log_user(TEST_USER_REGULAR_LOGIN, TEST_USER_REGULAR_PASS)
+        user_group = user_util.create_user_group()
+        UserGroupModel().grant_user_permission(user_group, self._get_logged_user(), 'usergroup.none')
+        response = self.app.get(route_path('profile_user_group', user_group_name=user_group.users_group_name), status=404)
+        assert response.status_code == 404
+
+    def test_another_user_can_check_if_he_is_in_group(self, user_util):
+        self.log_user(TEST_USER_REGULAR_LOGIN, TEST_USER_REGULAR_PASS)
+        user = user_util.create_user(
+            'test-my-user', password='qweqwe', email='[e-mail]')
+        user_group = user_util.create_user_group()
+        UserGroupModel().add_user_to_group(user_group, user)
+        UserGroupModel().grant_user_permission(user_group, self._get_logged_user(), 'usergroup.read')
+        response = self.app.get(route_path('profile_user_group', user_group_name=user_group.users_group_name))
+        response.mustcontain(user_group.users_group_name)
+        response.mustcontain(user.username)
+
+    def test_with_anonymous_user(self, user_util):
+        user = user_util.create_user(
+            'test-my-user', password='qweqwe', email='[e-mail]')
+        user_group = user_util.create_user_group()
+        UserGroupModel().add_user_to_group(user_group, user)
+        response = self.app.get(route_path('profile_user_group', user_group_name=user_group.users_group_name), status=302)
+        assert response.status_code == 302
  No newline at end of file

rhodecode/apps/user_group_profile/views.py

@@ -0,0 +1,53 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2018 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import logging
+
+from pyramid.httpexceptions import HTTPNotFound
+from pyramid.view import view_config
+
+from rhodecode.apps._base import BaseAppView
+from rhodecode.lib.auth import HasUserGroupPermissionAnyDecorator, LoginRequired, NotAnonymous
+from rhodecode.model.db import UserGroup, User
+
+
+log = logging.getLogger(__name__)
+
+
+class UserGroupProfileView(BaseAppView):
+
+    @LoginRequired()
+    @NotAnonymous()
+    @HasUserGroupPermissionAnyDecorator('usergroup.read', 'usergroup.write', 'usergroup.admin',)
+    @view_config(
+        route_name='user_group_profile', request_method='GET',
+        renderer='rhodecode:templates/user_group/user_group.mako')
+    def user_group_profile(self):
+        c = self._get_local_tmpl_context()
+        c.active = 'profile'
+        self.db_user_group_name = self.request.matchdict.get('user_group_name')
+        c.user_group = UserGroup().get_by_group_name(self.db_user_group_name)
+        if not c.user_group:
+            raise HTTPNotFound()
+        group_members_obj = sorted((x.user for x in c.user_group.members),
+                                   key=lambda u: u.username.lower())
+        c.group_members = group_members_obj
+        c.anonymous = self._rhodecode_user.username == User.DEFAULT_USER
+        return self._get_template_context(c)

rhodecode/templates/user_group/profile.mako

@@ -0,0 +1,70 b''
+<%namespace name="base" file="/base/base.mako"/>
+
+<div class="panel panel-default user-profile">
+    <div class="panel-heading">
+        <h3 class="panel-title">${_('User group profile')}</h3>
+        %if h.HasPermissionAny('hg.admin')():
+            ${h.link_to(_('Edit'), h.route_path('edit_user_group', user_group_id=c.user_group.users_group_id), class_='panel-edit')}
+        %endif
+    </div>
+
+    <div class="panel-body user-profile-content">
+
+        <div class="fieldset">
+            <div class="left-label">
+                ${_('Group Name')}:
+            </div>
+            <div class="right-content">
+                ${c.user_group.users_group_name}
+            </div>
+        </div>
+        <div class="fieldset">
+            <div class="left-label">
+                ${_('Owner')}:
+            </div>
+            <div class="group_member">
+                ${base.gravatar(c.user_group.user.email, 16)}
+                <span class="username user">${h.link_to_user(c.user_group.user)}</span>
+
+            </div>
+        </div>
+        <div class="fieldset">
+            <div class="left-label">
+                ${_('Active')}:
+            </div>
+            <div class="right-content">
+                ${c.user_group.users_group_active}
+            </div>
+        </div>
+        % if not c.anonymous:
+            <div class="fieldset">
+                <div class="left-label">
+                    ${_('Members')}:
+                </div>
+                <div class="right-content">
+                <table id="group_members_placeholder" class="rctable group_members">
+                    <th>${_('Username')}</th>
+                    % if c.group_members:
+                      % for user in c.group_members:
+                        <tr>
+                          <td id="member_user_${user.user_id}" class="td-author">
+                            <div class="group_member">
+                              ${base.gravatar(user.email, 16)}
+                              <span class="username user">${h.link_to(h.person(user), h.route_path('user_edit',user_id=user.user_id))}</span>
+                              <input type="hidden" name="__start__" value="member:mapping">
+                              <input type="hidden" name="member_user_id" value="${user.user_id}">
+                              <input type="hidden" name="type" value="existing" id="member_${user.user_id}">
+                              <input type="hidden" name="__end__" value="member:mapping">
+                            </div>
+                          </td>
+                        </tr>
+                      % endfor
+                    % else:
+                      <tr><td colspan="2">${_('No members yet')}</td></tr>
+                    % endif
+                </table>
+                </div>
+            </div>
+        % endif
+    </div>
+</div>
  No newline at end of file

rhodecode/templates/user_group/user_group.mako

@@ -0,0 +1,46 b''
+<%inherit file="/base/base.mako"/>
+
+<%def name="title()">
+   ${_('User group')}: ${c.user_group.users_group_name}
+    %if c.rhodecode_name:
+        &middot; ${h.branding(c.rhodecode_name)}
+    %endif
+</%def>
+
+<%def name="breadcrumbs_links()">
+    ${_('User group')}: ${c.user_group.users_group_name}
+</%def>
+
+<%def name="menu_bar_nav()">
+    ${self.menu_items(active='my_account')}
+</%def>
+
+<%def name="main()">
+<div class="box">
+  <div class="title">
+      ${self.breadcrumbs()}
+  </div>
+
+  <div class="sidebar-col-wrapper scw-small">
+    ##main
+    <div class="sidebar">
+        <ul class="nav nav-pills nav-stacked">
+        <li class="${'active' if c.active=='profile' else ''}">
+              <a href="${h.route_path('user_group_profile', user_group_name=c.user_group.users_group_name)}">${_('User Group Profile')}</a></li>
+          ## These placeholders are here only for styling purposes. For every new item added to the list, you should remove one placeholder
+          <li class="placeholder"><a href="#" style="visibility: hidden;">placeholder</a></li>
+          <li class="placeholder"><a href="#" style="visibility: hidden;">placeholder</a></li>
+          <li class="placeholder"><a href="#" style="visibility: hidden;">placeholder</a></li>
+          <li class="placeholder"><a href="#" style="visibility: hidden;">placeholder</a></li>
+          <li class="placeholder"><a href="#" style="visibility: hidden;">placeholder</a></li>
+          <li class="placeholder"><a href="#" style="visibility: hidden;">placeholder</a></li>
+        </ul>
+    </div>
+
+    <div class="main-content-full-width">
+        <%include file="/user_group/${c.active}.mako"/>
+    </div>
+  </div>
+</div>
+
+</%def>

rhodecode/config/middleware.py

@@ -226,6 +226,7 b' def includeme(config):'
     config.include('rhodecode.apps.user_group')
     config.include('rhodecode.apps.search')
     config.include('rhodecode.apps.user_profile')
+    config.include('rhodecode.apps.user_group_profile')
     config.include('rhodecode.apps.my_account')
     config.include('rhodecode.apps.svn_support')
     config.include('rhodecode.apps.ssh_support')

rhodecode/lib/helpers.py

@@ -896,6 +896,13 b' def link_to_user(author, length=0, **kwa'
         return escape(display_person)
 
 
+def link_to_group(users_group_name, **kwargs):
+    return link_to(
+        escape(users_group_name),
+        route_path('user_group_profile', user_group_name=users_group_name),
+        **kwargs)
+
+
 def person(author, show_attr="username_and_name"):
     user = discover_user(author)
     if user:

rhodecode/lib/utils.py

@@ -134,13 +134,17 b' def get_user_group_slug(request):'
     elif getattr(request, 'matchdict', None):
         # pyramid
         _user_group = request.matchdict.get('user_group_id')
-
+        _user_group_name = request.matchdict.get('user_group_name')
         try:
+            if _user_group:
             _user_group = UserGroup.get(_user_group)
+            elif _user_group_name:
+                _user_group = UserGroup.get_by_group_name(_user_group_name)
+
             if _user_group:
                 _user_group = _user_group.users_group_name
         except Exception:
-            log.exception('Failed to get user group by id')
+            log.exception('Failed to get user group by id and name')
             # catch all failures here
             return None
 

rhodecode/templates/admin/repo_groups/repo_group_edit_permissions.mako

@@ -98,7 +98,7 b''
                              ${_user_group.users_group_name}
                          </a>
                         %else:
-                         ${_user_group.users_group_name}
+                         ${h.link_to_group(_user_group.users_group_name)}
                         %endif
                     </td>
                     <td class="td-action">

rhodecode/templates/admin/repos/repo_edit_permissions.mako

@@ -89,7 +89,7 b''
                              ${_user_group.users_group_name}
                          </a>
                         %else:
-                         ${_user_group.users_group_name}
+                         ${h.link_to_group(_user_group.users_group_name)}
                         %endif
                     </td>
                     <td class="td-action">

rhodecode/templates/admin/user_groups/user_group_edit_perms.mako

@@ -100,7 +100,7 b''
                              ${_user_group.users_group_name}
                          </a>
                         %else:
-                         ${_user_group.users_group_name}
+                         ${h.link_to_group(_user_group.users_group_name)}
                         %endif
                     </td>
                     <td class="td-action">