release: Merge default into stable for release preparation

docs/integrations/ci.rst

@@ -0,0 +1,97 b''
+.. _integrations-ci:
+
+CI Server integration
+=====================
+
+
+RhodeCode :ref:`integrations-webhook` integration is a powerfull tool to allow
+interaction with systems like Jenkin, Bamboo, TeamCity, CircleCi or any other
+CI server that allows triggering a build using HTTP call.
+
+Below are few examples on how to use :ref:`integrations-webhook` to trigger
+a CI build.
+
+
+General Webhook
++++++++++++++++
+
+:ref:`integrations-webhook` allows sending a JSON payload information to specified
+url with GET or POST methods. There are several variables that could be used
+in the URL greatly extending the flexibility of this type of integration.
+
+Most of the modern CI systems such as Jenkins, TeamCity, Bamboo or CircleCi
+allows triggering builds via GET or POST calls.
+
+:ref:`integrations-webhook` can be either specified per each repository or
+globally, if your CI maps directly to all your projects a global
+:ref:`integrations-webhook` integration can be created and will trigger builds
+for each change in projects. If only some projects allow triggering builds a
+global integration will also work because mostly a CI system will ignore a
+call for unspecified builds.
+
+
+.. note::
+
+    A quick note on security. It's recommended to allow IP restrictions
+    to only allow RhodeCode server to trigger builds. If you need to
+    specify username and password this could be done by embedding it into a
+    trigger URL, e.g. `http://user:[e-mail]/job/${project_id}
+
+
+If users require to provide any custom parameters, they can be stored for each
+project inside the :ref:`repo-xtra`. For example to migrate a current job that
+has a numeric build id, storing this as `jenkins_build_id` key extra field
+the url would look like that::
+
+    http://server/job/${extra:jenkins_build_id}/
+
+
+.. note::
+
+    Please note that some variables will result in multiple calls.
+    e.g. for |HG| specifying `${branch}` will trigger as many builds as how
+    many branches the suer actually pushed. Same applies to `${commit_id}`
+    This will trigger many builds if many commits are pushed. This allows
+    triggering individual builds for each pushed commit.
+
+
+Jenkins
++++++++
+
+To use Jenkins CI with RhodeCode, a Jenkins Build with Parameters should be used.
+Plugin details are available here: https://wiki.jenkins.io/display/JENKINS/Build+With+Parameters+Plugin
+
+If the plugin is configured, RhodeCode can trigger builds automatically by
+calling such example url provided in :ref:`integrations-webhook` integration::
+
+    http://server/job/${project_id}/build-branch-${branch}/buildWithParameters?token=TOKEN&PARAMETER=value&PARAMETER2=value2
+
+
+Team City
++++++++++
+
+To use TeamCity CI it's enough to call the API and provide a buildId.
+Example url after configuring :ref:`repo-xtra` would look like that::
+
+    http://teacmtiyserver/viewType.html?buildTypeId=${extra:tc_build_id}
+
+
+Each project can have many build configurations.
+buildTypeId which is a unique ID for each build configuration (job).
+
+
+CircleCi
+++++++++
+
+To use CircleCi, a POST call needs to be triggered. Example build url would
+look like this::
+
+    http://cicleCiServer/project/${repo_type}/${username}/${repo_id}/tree/${branch}
+
+
+Circle Ci expects format of::
+
+    POST: /project/:vcs-type/:username/:project/tree/:branch
+
+
+CircleCi API documentation can be found here: https://circleci.com/docs/api/v1-reference/

docs/release-notes/release-notes-4.8.0.rst

@@ -0,0 +1,103 b''
+|RCE| 4.8.0 |RNS|
+-----------------
+
+Release Date
+^^^^^^^^^^^^
+
+- 2017-06-30
+
+
+New Features
+^^^^^^^^^^^^
+
+- Code Review: added new reviewers logic. This features now is Common Criteria
+  compatible and allows to define Mandatory (non-removable) reviewers.
+  In addition new options were added to forbid adding new reviewers or forbid
+  author of commits or the pull request itself to be a reviewer of the code.
+- Audit logs: introducing new audit logs tracking most important actions in
+  the system. Admins can track important events such as deletion of resources,
+  permissions changes, user groups changes. Each event tracks users with his
+  IP and user agent.
+- Mercurial: enabled evolve extensions. Each repository can be now configured
+  to support evolve, commit phases, and evolve state are also shown in
+  commit and changelog views.
+- VCS: expose newly pushed bookmarks or branches as quick links to open a
+  pull request on client output. Allows easier pull request creation via CLI.
+
+
+General
+^^^^^^^
+
+- Core: ported many views into pure pyramid code with python3.6 compatibility.
+  Now almost 80% of the code is ported, and future ready. It's our ongoing
+  effort to allow support for modern python version.
+- Comments: show author tag in pull request comments to easily
+  discover the author of changes in discussions.
+- Files: allow specifying custom filename for uploaded files via web interface.
+- Pull requests: changed who is allowed to close a pull request. Now it's only
+  super-admin, owner or person who can merge.
+  Before it was every reviewer can close. Which really doesn't make sense.
+- Users: show that user is disabled when editing his properties.
+- Integrations: expose user_id, and username in Webhook integration
+  templates arguments.
+- Integrations: exposed extra repo variables in template arguments of
+  Webhook integration.
+- Login: add link when using external auth to make it easier to login
+  using oauth providers, such as Google or Github.
+- Maintenance: added svn verify command to tasks to be able to verify the
+  filesystem and repo formats from web interface. Allows much easier tracking
+  of incompatible filesystem storage of subversion repositories.
+- Events: expose permalink urls for pull requests, and repositories.
+  Permalink url should provide a non-changeable url that can be used in
+  external system.
+- Svn: increase possibility to specify compatibility to pre 1.9 version.
+
+
+Security
+^^^^^^^^
+
+- security(high): fixed possibility to delete other users inline comments
+  for users who were repository admins.
+- security(med): fixed XSS inside the tooltip for author string.
+- security(med): fixed stored XSS in notifications inbox.
+- security(med): use custom writer for RST rendering to prevent injection of javascript: tags.
+- security(med): escape flash messaged VCS errors to prevent reflected XSS attacks.
+- security(low): use 404 instead of 403 code on permission decorator to
+  prevent brute force resource discovery attacks.
+- security(low): fixed self XSS inside autocomplete files view.
+- security(low): fixed self Xss inside repo strip view.
+- security(low): fixed self Xss inside the email add functionality.
+- security(none): use new safe escaped user attributes across the application.
+  Will prevent all possible XSS attack vectors from user stored attributes.
+  This specially can come from external authentication systems which doesn't
+  validate the data.
+
+
+Performance
+^^^^^^^^^^^
+
+
+
+
+Fixes
+^^^^^
+
+- Pull requests: make sure we process comments in the order of IDS when
+  linking them. In some edge cases it could lead to comments not displaying
+  correctly.
+- Emails: fixed newlines in email templates that can break email sending code.
+- Markdown: fixed hr and strong tags styling.
+- Notifications: fixed problem with 500 errors on non-numeric entries in url.
+- API: use simple schema validator to be consistent how we validate between
+  API and web views for create user and create user_group calls.
+- Users: fixed problem with personal repo group wasn't shown for disabled users.
+- Oauth: improve Google extraction of first/last name from returned data.
+
+
+Upgrade notes
+^^^^^^^^^^^^^
+
+
+- API: the `update_pull_request` method will no longer support a close action.
+  Users should use the existing `close_pull_request` method which allows
+  specifying a message and status while closing a pull request.
  No newline at end of file

rhodecode/apps/admin/tests/test_admin_audit_logs.py

@@ -0,0 +1,187 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2010-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import os
+import csv
+import datetime
+
+import pytest
+
+from rhodecode.tests import *
+from rhodecode.tests.fixture import FIXTURES
+from rhodecode.model.db import UserLog
+from rhodecode.model.meta import Session
+from rhodecode.lib.utils2 import safe_unicode
+
+
+def route_path(name, params=None, **kwargs):
+    import urllib
+    from rhodecode.apps._base import ADMIN_PREFIX
+
+    base_url = {
+        'admin_home': ADMIN_PREFIX,
+        'admin_audit_logs': ADMIN_PREFIX + '/audit_logs',
+
+    }[name].format(**kwargs)
+
+    if params:
+        base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
+    return base_url
+
+
+class TestAdminController(TestController):
+
+    @pytest.fixture(scope='class', autouse=True)
+    def prepare(self, request, pylonsapp):
+        UserLog.query().delete()
+        Session().commit()
+
+        def strptime(val):
+            fmt = '%Y-%m-%d %H:%M:%S'
+            if '.' not in val:
+                return datetime.datetime.strptime(val, fmt)
+
+            nofrag, frag = val.split(".")
+            date = datetime.datetime.strptime(nofrag, fmt)
+
+            frag = frag[:6]  # truncate to microseconds
+            frag += (6 - len(frag)) * '0'  # add 0s
+            return date.replace(microsecond=int(frag))
+
+        with open(os.path.join(FIXTURES, 'journal_dump.csv')) as f:
+            for row in csv.DictReader(f):
+                ul = UserLog()
+                for k, v in row.iteritems():
+                    v = safe_unicode(v)
+                    if k == 'action_date':
+                        v = strptime(v)
+                    if k in ['user_id', 'repository_id']:
+                        # nullable due to FK problems
+                        v = None
+                    setattr(ul, k, v)
+                Session().add(ul)
+            Session().commit()
+
+        @request.addfinalizer
+        def cleanup():
+            UserLog.query().delete()
+            Session().commit()
+
+    def test_index(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs'))
+        response.mustcontain('Admin audit logs')
+
+    def test_filter_all_entries(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs'))
+        all_count = UserLog.query().count()
+        response.mustcontain('%s entries' % all_count)
+
+    def test_filter_journal_filter_exact_match_on_repository(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs',
+                                params=dict(filter='repository:rhodecode')))
+        response.mustcontain('3 entries')
+
+    def test_filter_journal_filter_exact_match_on_repository_CamelCase(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs',
+                                params=dict(filter='repository:RhodeCode')))
+        response.mustcontain('3 entries')
+
+    def test_filter_journal_filter_wildcard_on_repository(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs',
+                                params=dict(filter='repository:*test*')))
+        response.mustcontain('862 entries')
+
+    def test_filter_journal_filter_prefix_on_repository(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs',
+                                params=dict(filter='repository:test*')))
+        response.mustcontain('257 entries')
+
+    def test_filter_journal_filter_prefix_on_repository_CamelCase(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs',
+                                params=dict(filter='repository:Test*')))
+        response.mustcontain('257 entries')
+
+    def test_filter_journal_filter_prefix_on_repository_and_user(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs',
+                                params=dict(filter='repository:test* AND username:demo')))
+        response.mustcontain('130 entries')
+
+    def test_filter_journal_filter_prefix_on_repository_or_target_repo(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs',
+                                params=dict(filter='repository:test* OR repository:rhodecode')))
+        response.mustcontain('260 entries')  # 257 + 3
+
+    def test_filter_journal_filter_exact_match_on_username(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs',
+                               params=dict(filter='username:demo')))
+        response.mustcontain('1087 entries')
+
+    def test_filter_journal_filter_exact_match_on_username_camelCase(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs',
+                                params=dict(filter='username:DemO')))
+        response.mustcontain('1087 entries')
+
+    def test_filter_journal_filter_wildcard_on_username(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs',
+                                params=dict(filter='username:*test*')))
+        entries_count = UserLog.query().filter(UserLog.username.ilike('%test%')).count()
+        response.mustcontain('{} entries'.format(entries_count))
+
+    def test_filter_journal_filter_prefix_on_username(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs',
+                                params=dict(filter='username:demo*')))
+        response.mustcontain('1101 entries')
+
+    def test_filter_journal_filter_prefix_on_user_or_other_user(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs',
+                                params=dict(filter='username:demo OR username:volcan')))
+        response.mustcontain('1095 entries')  # 1087 + 8
+
+    def test_filter_journal_filter_wildcard_on_action(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs',
+                                params=dict(filter='action:*pull_request*')))
+        response.mustcontain('187 entries')
+
+    def test_filter_journal_filter_on_date(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs',
+                                params=dict(filter='date:20121010')))
+        response.mustcontain('47 entries')
+
+    def test_filter_journal_filter_on_date_2(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_audit_logs',
+                                params=dict(filter='date:20121020')))
+        response.mustcontain('17 entries')

rhodecode/apps/admin/tests/test_admin_main_views.py

@@ -0,0 +1,82 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2010-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import pytest
+
+from rhodecode.tests import TestController
+from rhodecode.tests.fixture import Fixture
+
+fixture = Fixture()
+
+
+def route_path(name, params=None, **kwargs):
+    import urllib
+    from rhodecode.apps._base import ADMIN_PREFIX
+
+    base_url = {
+        'admin_home': ADMIN_PREFIX,
+        'pullrequest_show': '/{repo_name}/pull-request/{pull_request_id}',
+        'pull_requests_global': ADMIN_PREFIX + '/pull-request/{pull_request_id}',
+        'pull_requests_global_0': ADMIN_PREFIX + '/pull_requests/{pull_request_id}',
+        'pull_requests_global_1': ADMIN_PREFIX + '/pull-requests/{pull_request_id}',
+
+    }[name].format(**kwargs)
+
+    if params:
+        base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
+    return base_url
+
+
+class TestAdminMainView(TestController):
+
+    def test_redirect_admin_home(self):
+        self.log_user()
+        response = self.app.get(route_path('admin_home'), status=302)
+        assert response.location.endswith('/audit_logs')
+
+    def test_redirect_pull_request_view(self, view):
+        self.log_user()
+        self.app.get(
+            route_path(view, pull_request_id='xxxx'),
+            status=404)
+
+    @pytest.mark.backends("git", "hg")
+    @pytest.mark.parametrize('view', [
+        'pull_requests_global',
+        'pull_requests_global_0',
+        'pull_requests_global_1',
+    ])
+    def test_redirect_pull_request_view(self, view, pr_util):
+        self.log_user()
+        pull_request = pr_util.create_pull_request()
+        pull_request_id = pull_request.pull_request_id
+
+        response = self.app.get(
+            route_path(view, pull_request_id=pull_request_id),
+            status=302)
+        assert response.location.endswith(
+            'pull-request/{}'.format(pull_request_id))
+
+        repo_name = pull_request.target_repo.repo_name
+        redirect_url = route_path(
+            'pullrequest_show', repo_name=repo_name,
+            pull_request_id=pull_request.pull_request_id)
+
+        assert redirect_url in response.location

rhodecode/apps/admin/views/audit_logs.py

@@ -0,0 +1,73 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017  RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import logging
+
+from pyramid.view import view_config
+from sqlalchemy.orm import joinedload
+
+from rhodecode.apps._base import BaseAppView
+from rhodecode.model.db import UserLog
+from rhodecode.lib.user_log_filter import user_log_filter
+from rhodecode.lib.auth import LoginRequired, HasPermissionAllDecorator
+from rhodecode.lib.utils2 import safe_int
+from rhodecode.lib.helpers import Page
+
+log = logging.getLogger(__name__)
+
+
+class AdminAuditLogsView(BaseAppView):
+    def load_default_context(self):
+        c = self._get_local_tmpl_context()
+        self._register_global_c(c)
+        return c
+
+    @LoginRequired()
+    @HasPermissionAllDecorator('hg.admin')
+    @view_config(
+        route_name='admin_audit_logs', request_method='GET',
+        renderer='rhodecode:templates/admin/admin_audit_logs.mako')
+    def admin_audit_logs(self):
+        c = self.load_default_context()
+
+        users_log = UserLog.query()\
+            .options(joinedload(UserLog.user))\
+            .options(joinedload(UserLog.repository))
+
+        # FILTERING
+        c.search_term = self.request.GET.get('filter')
+        try:
+            users_log = user_log_filter(users_log, c.search_term)
+        except Exception:
+            # we want this to crash for now
+            raise
+
+        users_log = users_log.order_by(UserLog.action_date.desc())
+
+        p = safe_int(self.request.GET.get('page', 1), 1)
+
+        def url_generator(**kw):
+            if c.search_term:
+                kw['filter'] = c.search_term
+            return self.request.current_route_path(_query=kw)
+
+        c.audit_logs = Page(users_log, page=p, items_per_page=10,
+                            url=url_generator)
+        return self._get_template_context(c)

rhodecode/apps/admin/views/main_views.py

@@ -0,0 +1,63 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017  RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import logging
+
+
+from pyramid.httpexceptions import HTTPFound
+from pyramid.view import view_config
+
+from rhodecode.apps._base import BaseAppView
+from rhodecode.lib import helpers as h
+from rhodecode.lib.auth import (LoginRequired, HasPermissionAllDecorator)
+from rhodecode.model.db import PullRequest
+
+
+log = logging.getLogger(__name__)
+
+
+class AdminMainView(BaseAppView):
+
+    @LoginRequired()
+    @HasPermissionAllDecorator('hg.admin')
+    @view_config(
+        route_name='admin_home', request_method='GET')
+    def admin_main(self):
+        # redirect _admin to audit logs...
+        raise HTTPFound(h.route_path('admin_audit_logs'))
+
+    @LoginRequired()
+    @view_config(route_name='pull_requests_global_0', request_method='GET')
+    @view_config(route_name='pull_requests_global_1', request_method='GET')
+    @view_config(route_name='pull_requests_global', request_method='GET')
+    def pull_requests(self):
+        """
+        Global redirect for Pull Requests
+
+        :param pull_request_id: id of pull requests in the system
+        """
+
+        pull_request_id = self.request.matchdict.get('pull_request_id')
+        pull_request = PullRequest.get_or_404(pull_request_id, pyramid_exc=True)
+        repo_name = pull_request.target_repo.repo_name
+
+        raise HTTPFound(
+            h.route_path('pullrequest_show', repo_name=repo_name,
+                         pull_request_id=pull_request_id))

rhodecode/apps/home/__init__.py

@@ -0,0 +1,49 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+from rhodecode.config import routing_links
+
+
+def includeme(config):
+
+    config.add_route(
+        name='home',
+        pattern='/')
+
+    config.add_route(
+        name='user_autocomplete_data',
+        pattern='/_users')
+
+    config.add_route(
+        name='user_group_autocomplete_data',
+        pattern='/_user_groups')
+
+    config.add_route(
+        name='repo_list_data',
+        pattern='/_repos')
+
+    config.add_route(
+        name='goto_switcher_data',
+        pattern='/_goto_data')
+
+    # register our static links via redirection mechanism
+    routing_links.connect_redirection_links(config)
+
+    # Scan module for configuration decorators.
+    config.scan()

rhodecode/apps/home/tests/__init__.py

@@ -0,0 +1,40 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+
+def assert_and_get_content(result):
+    repos = []
+    groups = []
+    commits = []
+    for data in result:
+        for data_item in data['children']:
+            assert data_item['id']
+            assert data_item['text']
+            assert data_item['url']
+            if data_item['type'] == 'repo':
+                repos.append(data_item)
+            elif data_item['type'] == 'group':
+                groups.append(data_item)
+            elif data_item['type'] == 'commit':
+                commits.append(data_item)
+            else:
+                raise Exception('invalid type %s' % data_item['type'])
+
+    return repos, groups, commits
  No newline at end of file

rhodecode/apps/home/tests/test_get_goto_switched_data.py

@@ -0,0 +1,151 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import json
+
+import pytest
+
+from . import assert_and_get_content
+from rhodecode.tests import TestController, TEST_USER_ADMIN_LOGIN
+from rhodecode.tests.fixture import Fixture
+
+from rhodecode.lib.utils import map_groups
+from rhodecode.model.repo import RepoModel
+from rhodecode.model.repo_group import RepoGroupModel
+from rhodecode.model.db import Session, Repository, RepoGroup
+
+fixture = Fixture()
+
+
+def route_path(name, params=None, **kwargs):
+    import urllib
+
+    base_url = {
+        'goto_switcher_data': '/_goto_data',
+    }[name].format(**kwargs)
+
+    if params:
+        base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
+    return base_url
+
+
+class TestGotoSwitcherData(TestController):
+
+    required_repos_with_groups = [
+        'abc',
+        'abc-fork',
+        'forks/abcd',
+        'abcd',
+        'abcde',
+        'a/abc',
+        'aa/abc',
+        'aaa/abc',
+        'aaaa/abc',
+        'repos_abc/aaa/abc',
+        'abc_repos/abc',
+        'abc_repos/abcd',
+        'xxx/xyz',
+        'forked-abc/a/abc'
+    ]
+
+    @pytest.fixture(autouse=True, scope='class')
+    def prepare(self, request, pylonsapp):
+        for repo_and_group in self.required_repos_with_groups:
+            # create structure of groups and return the last group
+
+            repo_group = map_groups(repo_and_group)
+
+            RepoModel()._create_repo(
+                repo_and_group, 'hg', 'test-ac', TEST_USER_ADMIN_LOGIN,
+                repo_group=getattr(repo_group, 'group_id', None))
+
+            Session().commit()
+
+        request.addfinalizer(self.cleanup)
+
+    def cleanup(self):
+        # first delete all repos
+        for repo_and_groups in self.required_repos_with_groups:
+            repo = Repository.get_by_repo_name(repo_and_groups)
+            if repo:
+                RepoModel().delete(repo)
+                Session().commit()
+
+        # then delete all empty groups
+        for repo_and_groups in self.required_repos_with_groups:
+            if '/' in repo_and_groups:
+                r_group = repo_and_groups.rsplit('/', 1)[0]
+                repo_group = RepoGroup.get_by_group_name(r_group)
+                if not repo_group:
+                    continue
+                parents = repo_group.parents
+                RepoGroupModel().delete(repo_group, force_delete=True)
+                Session().commit()
+
+                for el in reversed(parents):
+                    RepoGroupModel().delete(el, force_delete=True)
+                    Session().commit()
+
+    def test_returns_list_of_repos_and_groups(self, xhr_header):
+        self.log_user()
+
+        response = self.app.get(
+            route_path('goto_switcher_data'),
+            extra_environ=xhr_header, status=200)
+        result = json.loads(response.body)['results']
+
+        repos, groups, commits = assert_and_get_content(result)
+
+        assert len(repos) == len(Repository.get_all())
+        assert len(groups) == len(RepoGroup.get_all())
+        assert len(commits) == 0
+
+    def test_returns_list_of_repos_and_groups_filtered(self, xhr_header):
+        self.log_user()
+
+        response = self.app.get(
+            route_path('goto_switcher_data'),
+            params={'query': 'abc'},
+            extra_environ=xhr_header, status=200)
+        result = json.loads(response.body)['results']
+
+        repos, groups, commits = assert_and_get_content(result)
+
+        assert len(repos) == 13
+        assert len(groups) == 5
+        assert len(commits) == 0
+
+    def test_returns_list_of_properly_sorted_and_filtered(self, xhr_header):
+        self.log_user()
+
+        response = self.app.get(
+            route_path('goto_switcher_data'),
+            params={'query': 'abc'},
+            extra_environ=xhr_header, status=200)
+        result = json.loads(response.body)['results']
+
+        repos, groups, commits = assert_and_get_content(result)
+
+        test_repos = [x['text'] for x in repos[:4]]
+        assert ['abc', 'abcd', 'a/abc', 'abcde'] == test_repos
+
+        test_groups = [x['text'] for x in groups[:4]]
+        assert ['abc_repos', 'repos_abc',
+                'forked-abc', 'forked-abc/a'] == test_groups

rhodecode/apps/home/tests/test_get_repo_list_data.py

@@ -0,0 +1,103 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import json
+
+from . import assert_and_get_content
+from rhodecode.tests import TestController
+from rhodecode.tests.fixture import Fixture
+from rhodecode.model.db import Repository
+
+fixture = Fixture()
+
+
+def route_path(name, params=None, **kwargs):
+    import urllib
+
+    base_url = {
+        'repo_list_data': '/_repos',
+    }[name].format(**kwargs)
+
+    if params:
+        base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
+    return base_url
+
+
+class TestRepoListData(TestController):
+
+    def test_returns_list_of_repos_and_groups(self, xhr_header):
+        self.log_user()
+
+        response = self.app.get(
+            route_path('repo_list_data'),
+            extra_environ=xhr_header, status=200)
+        result = json.loads(response.body)['results']
+
+        repos, groups, commits = assert_and_get_content(result)
+
+        assert len(repos) == len(Repository.get_all())
+        assert len(groups) == 0
+        assert len(commits) == 0
+
+    def test_returns_list_of_repos_and_groups_filtered(self, xhr_header):
+        self.log_user()
+
+        response = self.app.get(
+            route_path('repo_list_data'),
+            params={'query': 'vcs_test_git'},
+            extra_environ=xhr_header, status=200)
+        result = json.loads(response.body)['results']
+
+        repos, groups, commits = assert_and_get_content(result)
+
+        assert len(repos) == len(Repository.query().filter(
+            Repository.repo_name.ilike('%vcs_test_git%')).all())
+        assert len(groups) == 0
+        assert len(commits) == 0
+
+    def test_returns_list_of_repos_and_groups_filtered_with_type(self, xhr_header):
+        self.log_user()
+
+        response = self.app.get(
+            route_path('repo_list_data'),
+            params={'query': 'vcs_test_git', 'repo_type': 'git'},
+            extra_environ=xhr_header, status=200)
+        result = json.loads(response.body)['results']
+
+        repos, groups, commits = assert_and_get_content(result)
+
+        assert len(repos) == len(Repository.query().filter(
+            Repository.repo_name.ilike('%vcs_test_git%')).all())
+        assert len(groups) == 0
+        assert len(commits) == 0
+
+    def test_returns_list_of_repos_non_ascii_query(self, xhr_header):
+        self.log_user()
+        response = self.app.get(
+            route_path('repo_list_data'),
+            params={'query': 'ć_vcs_test_ą', 'repo_type': 'git'},
+            extra_environ=xhr_header, status=200)
+        result = json.loads(response.body)['results']
+
+        repos, groups, commits = assert_and_get_content(result)
+
+        assert len(repos) == 0
+        assert len(groups) == 0
+        assert len(commits) == 0

rhodecode/apps/home/tests/test_get_user_data.py

@@ -0,0 +1,112 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import json
+import pytest
+
+from rhodecode.tests import TestController
+from rhodecode.tests.fixture import Fixture
+
+
+fixture = Fixture()
+
+
+def route_path(name, params=None, **kwargs):
+    import urllib
+
+    base_url = {
+        'user_autocomplete_data': '/_users',
+        'user_group_autocomplete_data': '/_user_groups'
+    }[name].format(**kwargs)
+
+    if params:
+        base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
+    return base_url
+
+
+class TestUserAutocompleteData(TestController):
+
+    def test_returns_list_of_users(self, user_util, xhr_header):
+        self.log_user()
+        user = user_util.create_user(active=True)
+        user_name = user.username
+        response = self.app.get(
+            route_path('user_autocomplete_data'),
+            extra_environ=xhr_header, status=200)
+        result = json.loads(response.body)
+        values = [suggestion['value'] for suggestion in result['suggestions']]
+        assert user_name in values
+
+    def test_returns_inactive_users_when_active_flag_sent(
+            self, user_util, xhr_header):
+        self.log_user()
+        user = user_util.create_user(active=False)
+        user_name = user.username
+
+        response = self.app.get(
+            route_path('user_autocomplete_data',
+                       params=dict(user_groups='true', active='0')),
+            extra_environ=xhr_header, status=200)
+        result = json.loads(response.body)
+        values = [suggestion['value'] for suggestion in result['suggestions']]
+        assert user_name in values
+
+        response = self.app.get(
+            route_path('user_autocomplete_data',
+                       params=dict(user_groups='true', active='1')),
+            extra_environ=xhr_header, status=200)
+        result = json.loads(response.body)
+        values = [suggestion['value'] for suggestion in result['suggestions']]
+        assert user_name not in values
+
+    def test_returns_groups_when_user_groups_flag_sent(
+            self, user_util, xhr_header):
+        self.log_user()
+        group = user_util.create_user_group(user_groups_active=True)
+        group_name = group.users_group_name
+        response = self.app.get(
+            route_path('user_autocomplete_data',
+                       params=dict(user_groups='true')),
+            extra_environ=xhr_header, status=200)
+        result = json.loads(response.body)
+        values = [suggestion['value'] for suggestion in result['suggestions']]
+        assert group_name in values
+
+    @pytest.mark.parametrize('query, count', [
+        ('hello1', 0),
+        ('dev', 2),
+    ])
+    def test_result_is_limited_when_query_is_sent(self, user_util, xhr_header,
+                                                  query, count):
+        self.log_user()
+
+        user_util._test_name = 'dev-test'
+        user_util.create_user()
+
+        user_util._test_name = 'dev-group-test'
+        user_util.create_user_group()
+
+        response = self.app.get(
+            route_path('user_autocomplete_data',
+                       params=dict(user_groups='true', query=query)),
+            extra_environ=xhr_header, status=200)
+
+        result = json.loads(response.body)
+        assert len(result['suggestions']) == count

rhodecode/apps/home/tests/test_get_user_group_data.py

@@ -0,0 +1,117 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import json
+
+import pytest
+
+from rhodecode.tests import TestController
+from rhodecode.tests.fixture import Fixture
+
+
+fixture = Fixture()
+
+
+def route_path(name, params=None, **kwargs):
+    import urllib
+
+    base_url = {
+        'user_autocomplete_data': '/_users',
+        'user_group_autocomplete_data': '/_user_groups'
+    }[name].format(**kwargs)
+
+    if params:
+        base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
+    return base_url
+
+
+class TestUserGroupAutocompleteData(TestController):
+
+    def test_returns_list_of_user_groups(self, user_util, xhr_header):
+        self.log_user()
+        user_group = user_util.create_user_group(active=True)
+        user_group_name = user_group.users_group_name
+        response = self.app.get(
+            route_path('user_group_autocomplete_data'),
+            extra_environ=xhr_header, status=200)
+        result = json.loads(response.body)
+        values = [suggestion['value'] for suggestion in result['suggestions']]
+        assert user_group_name in values
+
+    def test_returns_inactive_user_groups_when_active_flag_sent(
+            self, user_util, xhr_header):
+        self.log_user()
+        user_group = user_util.create_user_group(active=False)
+        user_group_name = user_group.users_group_name
+
+        response = self.app.get(
+            route_path('user_group_autocomplete_data',
+                       params=dict(active='0')),
+            extra_environ=xhr_header, status=200)
+        result = json.loads(response.body)
+        values = [suggestion['value'] for suggestion in result['suggestions']]
+        assert user_group_name in values
+
+        response = self.app.get(
+            route_path('user_group_autocomplete_data',
+                       params=dict(active='1')),
+            extra_environ=xhr_header, status=200)
+        result = json.loads(response.body)
+        values = [suggestion['value'] for suggestion in result['suggestions']]
+        assert user_group_name not in values
+
+    @pytest.mark.parametrize('query, count', [
+        ('hello1', 0),
+        ('dev', 1),
+    ])
+    def test_result_is_limited_when_query_is_sent(self, user_util, xhr_header, query, count):
+        self.log_user()
+
+        user_util._test_name = 'dev-test'
+        user_util.create_user_group()
+
+        response = self.app.get(
+            route_path('user_group_autocomplete_data',
+                       params=dict(user_groups='true',
+                                   query=query)),
+            extra_environ=xhr_header, status=200)
+
+        result = json.loads(response.body)
+
+        assert len(result['suggestions']) == count

rhodecode/apps/home/views.py

@@ -0,0 +1,304 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import re
+import logging
+
+from pyramid.view import view_config
+
+from rhodecode.apps._base import BaseAppView
+from rhodecode.lib import helpers as h
+from rhodecode.lib.auth import LoginRequired, NotAnonymous, \
+    HasRepoGroupPermissionAnyDecorator
+from rhodecode.lib.index import searcher_from_config
+from rhodecode.lib.utils2 import safe_unicode, str2bool
+from rhodecode.lib.ext_json import json
+from rhodecode.model.db import func, Repository, RepoGroup
+from rhodecode.model.repo import RepoModel
+from rhodecode.model.repo_group import RepoGroupModel
+from rhodecode.model.scm import ScmModel, RepoGroupList, RepoList
+from rhodecode.model.user import UserModel
+from rhodecode.model.user_group import UserGroupModel
+
+log = logging.getLogger(__name__)
+
+
+class HomeView(BaseAppView):
+
+    def load_default_context(self):
+        c = self._get_local_tmpl_context()
+        c.user = c.auth_user.get_instance()
+        self._register_global_c(c)
+        return c
+
+    @LoginRequired()
+    @view_config(
+        route_name='user_autocomplete_data', request_method='GET',
+        renderer='json_ext', xhr=True)
+    def user_autocomplete_data(self):
+        query = self.request.GET.get('query')
+        active = str2bool(self.request.GET.get('active') or True)
+        include_groups = str2bool(self.request.GET.get('user_groups'))
+        expand_groups = str2bool(self.request.GET.get('user_groups_expand'))
+        skip_default_user = str2bool(self.request.GET.get('skip_default_user'))
+
+        log.debug('generating user list, query:%s, active:%s, with_groups:%s',
+                  query, active, include_groups)
+
+        _users = UserModel().get_users(
+            name_contains=query, only_active=active)
+
+        def maybe_skip_default_user(usr):
+            if skip_default_user and usr['username'] == UserModel.cls.DEFAULT_USER:
+                return False
+            return True
+        _users = filter(maybe_skip_default_user, _users)
+
+        if include_groups:
+            # extend with user groups
+            _user_groups = UserGroupModel().get_user_groups(
+                name_contains=query, only_active=active,
+                expand_groups=expand_groups)
+            _users = _users + _user_groups
+
+        return {'suggestions': _users}
+
+    @LoginRequired()
+    @NotAnonymous()
+    @view_config(
+        route_name='user_group_autocomplete_data', request_method='GET',
+        renderer='json_ext', xhr=True)
+    def user_group_autocomplete_data(self):
+        query = self.request.GET.get('query')
+        active = str2bool(self.request.GET.get('active') or True)
+        expand_groups = str2bool(self.request.GET.get('user_groups_expand'))
+
+        log.debug('generating user group list, query:%s, active:%s',
+                  query, active)
+
+        _user_groups = UserGroupModel().get_user_groups(
+            name_contains=query, only_active=active,
+            expand_groups=expand_groups)
+        _user_groups = _user_groups
+
+        return {'suggestions': _user_groups}
+
+    def _get_repo_list(self, name_contains=None, repo_type=None, limit=20):
+        query = Repository.query()\
+            .order_by(func.length(Repository.repo_name))\
+            .order_by(Repository.repo_name)
+
+        if repo_type:
+            query = query.filter(Repository.repo_type == repo_type)
+
+        if name_contains:
+            ilike_expression = u'%{}%'.format(safe_unicode(name_contains))
+            query = query.filter(
+                Repository.repo_name.ilike(ilike_expression))
+            query = query.limit(limit)
+
+        all_repos = query.all()
+        # permission checks are inside this function
+        repo_iter = ScmModel().get_repos(all_repos)
+        return [
+            {
+                'id': obj['name'],
+                'text': obj['name'],
+                'type': 'repo',
+                'obj': obj['dbrepo'],
+                'url': h.route_path('repo_summary', repo_name=obj['name'])
+            }
+            for obj in repo_iter]
+
+    def _get_repo_group_list(self, name_contains=None, limit=20):
+        query = RepoGroup.query()\
+            .order_by(func.length(RepoGroup.group_name))\
+            .order_by(RepoGroup.group_name)
+
+        if name_contains:
+            ilike_expression = u'%{}%'.format(safe_unicode(name_contains))
+            query = query.filter(
+                RepoGroup.group_name.ilike(ilike_expression))
+            query = query.limit(limit)
+
+        all_groups = query.all()
+        repo_groups_iter = ScmModel().get_repo_groups(all_groups)
+        return [
+            {
+                'id': obj.group_name,
+                'text': obj.group_name,
+                'type': 'group',
+                'obj': {},
+                'url': h.route_path('repo_group_home', repo_group_name=obj.group_name)
+            }
+            for obj in repo_groups_iter]
+
+    def _get_hash_commit_list(self, auth_user, hash_starts_with=None):
+        if not hash_starts_with or len(hash_starts_with) < 3:
+            return []
+
+        commit_hashes = re.compile('([0-9a-f]{2,40})').findall(hash_starts_with)
+
+        if len(commit_hashes) != 1:
+            return []
+
+        commit_hash_prefix = commit_hashes[0]
+
+        searcher = searcher_from_config(self.request.registry.settings)
+        result = searcher.search(
+            'commit_id:%s*' % commit_hash_prefix, 'commit', auth_user,
+            raise_on_exc=False)
+
+        return [
+            {
+                'id': entry['commit_id'],
+                'text': entry['commit_id'],
+                'type': 'commit',
+                'obj': {'repo': entry['repository']},
+                'url': h.url('changeset_home',
+                             repo_name=entry['repository'],
+                             revision=entry['commit_id'])
+            }
+            for entry in result['results']]
+
+    @LoginRequired()
+    @view_config(
+        route_name='repo_list_data', request_method='GET',
+        renderer='json_ext', xhr=True)
+    def repo_list_data(self):
+        _ = self.request.translate
+
+        query = self.request.GET.get('query')
+        repo_type = self.request.GET.get('repo_type')
+        log.debug('generating repo list, query:%s, repo_type:%s',
+                  query, repo_type)
+
+        res = []
+        repos = self._get_repo_list(query, repo_type=repo_type)
+        if repos:
+            res.append({
+                'text': _('Repositories'),
+                'children': repos
+            })
+
+        data = {
+            'more': False,
+            'results': res
+        }
+        return data
+
+    @LoginRequired()
+    @view_config(
+        route_name='goto_switcher_data', request_method='GET',
+        renderer='json_ext', xhr=True)
+    def goto_switcher_data(self):
+        c = self.load_default_context()
+
+        _ = self.request.translate
+
+        query = self.request.GET.get('query')
+        log.debug('generating goto switcher list, query %s', query)
+
+        res = []
+        repo_groups = self._get_repo_group_list(query)
+        if repo_groups:
+            res.append({
+                'text': _('Groups'),
+                'children': repo_groups
+            })
+
+        repos = self._get_repo_list(query)
+        if repos:
+            res.append({
+                'text': _('Repositories'),
+                'children': repos
+            })
+
+        commits = self._get_hash_commit_list(c.auth_user, query)
+        if commits:
+            unique_repos = {}
+            for commit in commits:
+                unique_repos.setdefault(commit['obj']['repo'], []
+                    ).append(commit)
+
+            for repo in unique_repos:
+                res.append({
+                    'text': _('Commits in %(repo)s') % {'repo': repo},
+                    'children': unique_repos[repo]
+                })
+
+        data = {
+            'more': False,
+            'results': res
+        }
+        return data
+
+    def _get_groups_and_repos(self, repo_group_id=None):
+        # repo groups groups
+        repo_group_list = RepoGroup.get_all_repo_groups(group_id=repo_group_id)
+        _perms = ['group.read', 'group.write', 'group.admin']
+        repo_group_list_acl = RepoGroupList(repo_group_list, perm_set=_perms)
+        repo_group_data = RepoGroupModel().get_repo_groups_as_dict(
+            repo_group_list=repo_group_list_acl, admin=False)
+
+        # repositories
+        repo_list = Repository.get_all_repos(group_id=repo_group_id)
+        _perms = ['repository.read', 'repository.write', 'repository.admin']
+        repo_list_acl = RepoList(repo_list, perm_set=_perms)
+        repo_data = RepoModel().get_repos_as_dict(
+            repo_list=repo_list_acl, admin=False)
+
+        return repo_data, repo_group_data
+
+    @LoginRequired()
+    @view_config(
+        route_name='home', request_method='GET',
+        renderer='rhodecode:templates/index.mako')
+    def main_page(self):
+        c = self.load_default_context()
+        c.repo_group = None
+
+        repo_data, repo_group_data = self._get_groups_and_repos()
+        # json used to render the grids
+        c.repos_data = json.dumps(repo_data)
+        c.repo_groups_data = json.dumps(repo_group_data)
+
+        return self._get_template_context(c)
+
+    @LoginRequired()
+    @HasRepoGroupPermissionAnyDecorator(
+        'group.read', 'group.write', 'group.admin')
+    @view_config(
+        route_name='repo_group_home', request_method='GET',
+        renderer='rhodecode:templates/index_repo_group.mako')
+    @view_config(
+        route_name='repo_group_home_slash', request_method='GET',
+        renderer='rhodecode:templates/index_repo_group.mako')
+    def repo_group_main_page(self):
+        c = self.load_default_context()
+        c.repo_group = self.request.db_repo_group
+        repo_data, repo_group_data = self._get_groups_and_repos(
+            c.repo_group.group_id)
+
+        # json used to render the grids
+        c.repos_data = json.dumps(repo_data)
+        c.repo_groups_data = json.dumps(repo_group_data)
+
+        return self._get_template_context(c)

rhodecode/apps/my_account/tests/test_my_account_emails.py

@@ -0,0 +1,93 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2010-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import pytest
+
+from rhodecode.apps._base import ADMIN_PREFIX
+from rhodecode.model.db import User, UserEmailMap
+from rhodecode.tests import (
+    TestController, TEST_USER_ADMIN_LOGIN, TEST_USER_REGULAR_EMAIL,
+    assert_session_flash)
+from rhodecode.tests.fixture import Fixture
+
+fixture = Fixture()
+
+
+def route_path(name, **kwargs):
+    return {
+        'my_account_emails':
+            ADMIN_PREFIX + '/my_account/emails',
+        'my_account_emails_add':
+            ADMIN_PREFIX + '/my_account/emails/new',
+        'my_account_emails_delete':
+            ADMIN_PREFIX + '/my_account/emails/delete',
+    }[name].format(**kwargs)
+
+
+class TestMyAccountEmails(TestController):
+    def test_my_account_my_emails(self):
+        self.log_user()
+        response = self.app.get(route_path('my_account_emails'))
+        response.mustcontain('No additional emails specified')
+
+    def test_my_account_my_emails_add_existing_email(self):
+        self.log_user()
+        response = self.app.get(route_path('my_account_emails'))
+        response.mustcontain('No additional emails specified')
+        response = self.app.post(route_path('my_account_emails_add'),
+                                 {'new_email': TEST_USER_REGULAR_EMAIL,
+                                  'csrf_token': self.csrf_token})
+        assert_session_flash(response, 'This e-mail address is already taken')
+
+    def test_my_account_my_emails_add_mising_email_in_form(self):
+        self.log_user()
+        response = self.app.get(route_path('my_account_emails'))
+        response.mustcontain('No additional emails specified')
+        response = self.app.post(route_path('my_account_emails_add'),
+                                 {'csrf_token': self.csrf_token})
+        assert_session_flash(response, 'Please enter an email address')
+
+    def test_my_account_my_emails_add_remove(self):
+        self.log_user()
+        response = self.app.get(route_path('my_account_emails'))
+        response.mustcontain('No additional emails specified')
+
+        response = self.app.post(route_path('my_account_emails_add'),
+                                 {'new_email': '[e-mail]',
+                                  'csrf_token': self.csrf_token})
+
+        response = self.app.get(route_path('my_account_emails'))
+
+        email_id = UserEmailMap.query().filter(
+            UserEmailMap.user == User.get_by_username(
+                TEST_USER_ADMIN_LOGIN)).filter(
+            UserEmailMap.email == '[e-mail]').one().email_id
+
+        response.mustcontain('[e-mail]')
+        response.mustcontain('<input id="del_email_id" name="del_email_id" '
+                             'type="hidden" value="%s" />' % email_id)
+
+        response = self.app.post(
+            route_path('my_account_emails_delete'), {
+                'del_email_id': email_id,
+                'csrf_token': self.csrf_token})
+        assert_session_flash(response, 'Email successfully deleted')
+        response = self.app.get(route_path('my_account_emails'))
+        response.mustcontain('No additional emails specified')

rhodecode/apps/my_account/tests/test_my_account_simple_views.py

@@ -0,0 +1,76 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2010-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import pytest
+
+from rhodecode.apps._base import ADMIN_PREFIX
+from rhodecode.model.db import User, UserEmailMap, Repository, UserFollowing
+from rhodecode.tests import (
+    TestController, TEST_USER_ADMIN_LOGIN, TEST_USER_REGULAR_EMAIL,
+    assert_session_flash)
+from rhodecode.tests.fixture import Fixture
+
+fixture = Fixture()
+
+
+def route_path(name, **kwargs):
+    return {
+        'my_account_repos':
+            ADMIN_PREFIX + '/my_account/repos',
+        'my_account_watched':
+            ADMIN_PREFIX + '/my_account/watched',
+        'my_account_perms':
+            ADMIN_PREFIX + '/my_account/perms',
+        'my_account_notifications':
+            ADMIN_PREFIX + '/my_account/notifications',
+    }[name].format(**kwargs)
+
+
+class TestMyAccountSimpleViews(TestController):
+
+    def test_my_account_my_repos(self, autologin_user):
+        response = self.app.get(route_path('my_account_repos'))
+        repos = Repository.query().filter(
+            Repository.user == User.get_by_username(
+                TEST_USER_ADMIN_LOGIN)).all()
+        for repo in repos:
+            response.mustcontain('"name_raw": "%s"' % repo.repo_name)
+
+    def test_my_account_my_watched(self, autologin_user):
+        response = self.app.get(route_path('my_account_watched'))
+
+        repos = UserFollowing.query().filter(
+            UserFollowing.user == User.get_by_username(
+                TEST_USER_ADMIN_LOGIN)).all()
+        for repo in repos:
+            response.mustcontain(
+                '"name_raw": "%s"' % repo.follows_repository.repo_name)
+
+    def test_my_account_perms(self, autologin_user):
+        response = self.app.get(route_path('my_account_perms'))
+        assert_response = response.assert_response()
+        assert assert_response.get_elements('.perm_tag.none')
+        assert assert_response.get_elements('.perm_tag.read')
+        assert assert_response.get_elements('.perm_tag.write')
+        assert assert_response.get_elements('.perm_tag.admin')
+
+    def test_my_account_notifications(self, autologin_user):
+        response = self.app.get(route_path('my_account_notifications'))
+        response.mustcontain('Test flash message')

rhodecode/apps/ops/__init__.py

@@ -0,0 +1,35 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+from rhodecode.config.routing import ADMIN_PREFIX
+
+
+def admin_routes(config):
+    config.add_route(
+        name='ops_ping',
+        pattern='/ping')
+
+
+def includeme(config):
+
+    config.include(admin_routes, route_prefix=ADMIN_PREFIX + '/ops')
+
+    # Scan module for configuration decorators.
+    config.scan()

rhodecode/apps/ops/views.py

@@ -0,0 +1,54 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import logging
+
+from pyramid.view import view_config
+
+from rhodecode.apps._base import BaseAppView
+
+
+log = logging.getLogger(__name__)
+
+
+class OpsView(BaseAppView):
+
+    def load_default_context(self):
+        c = self._get_local_tmpl_context()
+        c.user = c.auth_user.get_instance()
+        self._register_global_c(c)
+        return c
+
+    @view_config(
+        route_name='ops_ping', request_method='GET',
+        renderer='json_ext')
+    def ops_ping(self):
+        data = {
+            'instance': self.request.registry.settings.get('instance_id'),
+        }
+        if getattr(self.request, 'user'):
+            data.update({
+                'caller_ip': self.request.user.ip_addr,
+                'caller_name': self.request.user.username,
+            })
+        return {'ok': data}
+
+
+

rhodecode/apps/repo_group/__init__.py

@@ -0,0 +1,33 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+from rhodecode.apps._base import add_route_with_slash
+
+
+def includeme(config):
+
+    # Summary
+    add_route_with_slash(
+        config,
+        name='repo_group_home',
+        pattern='/{repo_group_name:.*?[^/]}', repo_group_route=True)
+
+    # Scan module for configuration decorators.
+    config.scan()
+

rhodecode/apps/repository/tests/test_pull_requests_list.py

@@ -0,0 +1,83 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2010-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import pytest
+from rhodecode.model.db import Repository
+
+
+def route_path(name, params=None, **kwargs):
+    import urllib
+
+    base_url = {
+        'pullrequest_show_all': '/{repo_name}/pull-request',
+        'pullrequest_show_all_data': '/{repo_name}/pull-request-data',
+    }[name].format(**kwargs)
+
+    if params:
+        base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
+    return base_url
+
+
[e-mail]("git", "hg")
[e-mail]('autologin_user', 'app')
+class TestPullRequestList(object):
+
+    @pytest.mark.parametrize('params, expected_title', [
+        ({'source': 0, 'closed': 1}, 'Closed Pull Requests'),
+        ({'source': 0, 'my': 1}, 'opened by me'),
+        ({'source': 0, 'awaiting_review': 1}, 'awaiting review'),
+        ({'source': 0, 'awaiting_my_review': 1}, 'awaiting my review'),
+        ({'source': 1}, 'Pull Requests from'),
+    ])
+    def test_showing_list_page(self, backend, pr_util, params, expected_title):
+        pull_request = pr_util.create_pull_request()
+
+        response = self.app.get(
+            route_path('pullrequest_show_all',
+                       repo_name=pull_request.target_repo.repo_name,
+                       params=params))
+
+        assert_response = response.assert_response()
+        assert_response.element_equals_to('.panel-title', expected_title)
+        element = assert_response.get_element('.panel-title')
+        element_text = assert_response._element_to_string(element)
+
+    def test_showing_list_page_data(self, backend, pr_util, xhr_header):
+        pull_request = pr_util.create_pull_request()
+        response = self.app.get(
+            route_path('pullrequest_show_all_data',
+                       repo_name=pull_request.target_repo.repo_name),
+            extra_environ=xhr_header)
+
+        assert response.json['recordsTotal'] == 1
+        assert response.json['data'][0]['description'] == 'Description'
+
+    def test_description_is_escaped_on_index_page(self, backend, pr_util, xhr_header):
+        xss_description = "<script>alert('Hi!')</script>"
+        pull_request = pr_util.create_pull_request(description=xss_description)
+
+        response = self.app.get(
+            route_path('pullrequest_show_all_data',
+                       repo_name=pull_request.target_repo.repo_name),
+            extra_environ=xhr_header)
+
+        assert response.json['recordsTotal'] == 1
+        assert response.json['data'][0]['description'] == \
+               "&lt;script&gt;alert(&#39;Hi!&#39;)&lt;/script&gt;"

rhodecode/apps/repository/tests/test_repo_settings.py

@@ -0,0 +1,233 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2010-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import mock
+import pytest
+
+from rhodecode.lib.utils2 import str2bool
+from rhodecode.lib.vcs.exceptions import RepositoryRequirementError
+from rhodecode.model.db import Repository, UserRepoToPerm, Permission, User
+from rhodecode.model.meta import Session
+from rhodecode.tests import (
+    url, HG_REPO, TEST_USER_ADMIN_LOGIN, TEST_USER_REGULAR_LOGIN,
+    assert_session_flash)
+from rhodecode.tests.fixture import Fixture
+
+fixture = Fixture()
+
+
+def route_path(name, params=None, **kwargs):
+    import urllib
+
+    base_url = {
+        'edit_repo': '/{repo_name}/settings',
+        'edit_repo_advanced': '/{repo_name}/settings/advanced',
+        'edit_repo_caches': '/{repo_name}/settings/caches',
+        'edit_repo_perms': '/{repo_name}/settings/permissions',
+    }[name].format(**kwargs)
+
+    if params:
+        base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
+    return base_url
+
+
+def _get_permission_for_user(user, repo):
+    perm = UserRepoToPerm.query()\
+        .filter(UserRepoToPerm.repository ==
+                Repository.get_by_repo_name(repo))\
+        .filter(UserRepoToPerm.user == User.get_by_username(user))\
+        .all()
+    return perm
+
+
[e-mail]('autologin_user', 'app')
+class TestAdminRepoSettings(object):
+    @pytest.mark.parametrize('urlname', [
+        'edit_repo',
+        'edit_repo_caches',
+        'edit_repo_perms',
+        'edit_repo_advanced',
+    ])
+    def test_show_page(self, urlname, app, backend):
+        app.get(route_path(urlname, repo_name=backend.repo_name), status=200)
+
+    def test_edit_accessible_when_missing_requirements(
+            self, backend_hg, autologin_user):
+        scm_patcher = mock.patch.object(
+            Repository, 'scm_instance', side_effect=RepositoryRequirementError)
+        with scm_patcher:
+            self.app.get(route_path('edit_repo', repo_name=backend_hg.repo_name))
+
+    @pytest.mark.parametrize('urlname', [
+        'repo_vcs_settings',
+        'repo_settings_issuetracker',
+        'edit_repo_fields',
+        'edit_repo_remote',
+        'edit_repo_statistics',
+    ])
+    def test_show_page_pylons(self, urlname, app):
+        app.get(url(urlname, repo_name=HG_REPO))
+
+    @pytest.mark.parametrize('update_settings', [
+        {'repo_description': 'alter-desc'},
+        {'repo_owner': TEST_USER_REGULAR_LOGIN},
+        {'repo_private': 'true'},
+        {'repo_enable_locking': 'true'},
+        {'repo_enable_downloads': 'true'},
+    ])
+    def test_update_repo_settings(self, update_settings, csrf_token, backend, user_util):
+        repo = user_util.create_repo(repo_type=backend.alias)
+        repo_name = repo.repo_name
+
+        params = fixture._get_repo_create_params(
+                csrf_token=csrf_token,
+                repo_name=repo_name,
+                repo_type=backend.alias,
+                repo_owner=TEST_USER_ADMIN_LOGIN,
+                repo_description='DESC',
+
+                repo_private='false',
+                repo_enable_locking='false',
+                repo_enable_downloads='false')
+        params.update(update_settings)
+        self.app.post(
+            route_path('edit_repo', repo_name=repo_name),
+            params=params, status=302)
+
+        repo = Repository.get_by_repo_name(repo_name)
+        assert repo.user.username == \
+               update_settings.get('repo_owner', repo.user.username)
+
+        assert repo.description == \
+               update_settings.get('repo_description', repo.description)
+
+        assert repo.private == \
+               str2bool(update_settings.get(
+                   'repo_private', repo.private))
+
+        assert repo.enable_locking == \
+               str2bool(update_settings.get(
+                   'repo_enable_locking', repo.enable_locking))
+
+        assert repo.enable_downloads == \
+               str2bool(update_settings.get(
+                   'repo_enable_downloads', repo.enable_downloads))
+
+    def test_update_repo_name_via_settings(self, csrf_token, user_util, backend):
+        repo = user_util.create_repo(repo_type=backend.alias)
+        repo_name = repo.repo_name
+
+        repo_group = user_util.create_repo_group()
+        repo_group_name = repo_group.group_name
+        new_name = repo_group_name + '_' + repo_name
+
+        params = fixture._get_repo_create_params(
+                csrf_token=csrf_token,
+                repo_name=new_name,
+                repo_type=backend.alias,
+                repo_owner=TEST_USER_ADMIN_LOGIN,
+                repo_description='DESC',
+                repo_private='false',
+                repo_enable_locking='false',
+                repo_enable_downloads='false')
+        self.app.post(
+            route_path('edit_repo', repo_name=repo_name),
+            params=params, status=302)
+        repo = Repository.get_by_repo_name(new_name)
+        assert repo.repo_name == new_name
+
+    def test_update_repo_group_via_settings(self, csrf_token, user_util, backend):
+        repo = user_util.create_repo(repo_type=backend.alias)
+        repo_name = repo.repo_name
+
+        repo_group = user_util.create_repo_group()
+        repo_group_name = repo_group.group_name
+        repo_group_id = repo_group.group_id
+
+        new_name = repo_group_name + '/' + repo_name
+        params = fixture._get_repo_create_params(
+                csrf_token=csrf_token,
+                repo_name=repo_name,
+                repo_type=backend.alias,
+                repo_owner=TEST_USER_ADMIN_LOGIN,
+                repo_description='DESC',
+                repo_group=repo_group_id,
+                repo_private='false',
+                repo_enable_locking='false',
+                repo_enable_downloads='false')
+        self.app.post(
+            route_path('edit_repo', repo_name=repo_name),
+            params=params, status=302)
+        repo = Repository.get_by_repo_name(new_name)
+        assert repo.repo_name == new_name
+
+    def test_set_private_flag_sets_default_user_permissions_to_none(
+            self, autologin_user, backend, csrf_token):
+
+        # initially repository perm should be read
+        perm = _get_permission_for_user(user='default', repo=backend.repo_name)
+        assert len(perm) == 1
+        assert perm[0].permission.permission_name == 'repository.read'
+        assert not backend.repo.private
+
+        response = self.app.post(
+            route_path('edit_repo', repo_name=backend.repo_name),
+            params=fixture._get_repo_create_params(
+                repo_private='true',
+                repo_name=backend.repo_name,
+                repo_type=backend.alias,
+                repo_owner=TEST_USER_ADMIN_LOGIN,
+                csrf_token=csrf_token), status=302)
+
+        assert_session_flash(
+            response,
+            msg='Repository %s updated successfully' % (backend.repo_name))
+
+        repo = Repository.get_by_repo_name(backend.repo_name)
+        assert repo.private is True
+
+        # now the repo default permission should be None
+        perm = _get_permission_for_user(user='default', repo=backend.repo_name)
+        assert len(perm) == 1
+        assert perm[0].permission.permission_name == 'repository.none'
+
+        response = self.app.post(
+            route_path('edit_repo', repo_name=backend.repo_name),
+            params=fixture._get_repo_create_params(
+                repo_private='false',
+                repo_name=backend.repo_name,
+                repo_type=backend.alias,
+                repo_owner=TEST_USER_ADMIN_LOGIN,
+                csrf_token=csrf_token), status=302)
+
+        assert_session_flash(
+            response,
+            msg='Repository %s updated successfully' % (backend.repo_name))
+        assert backend.repo.private is False
+
+        # we turn off private now the repo default permission should stay None
+        perm = _get_permission_for_user(user='default', repo=backend.repo_name)
+        assert len(perm) == 1
+        assert perm[0].permission.permission_name == 'repository.none'
+
+        # update this permission back
+        perm[0].permission = Permission.get_by_key('repository.read')
+        Session().add(perm[0])
+        Session().commit()

rhodecode/apps/repository/tests/test_repo_settings_advanced.py

@@ -0,0 +1,150 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2010-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import pytest
+
+from rhodecode.lib.utils2 import safe_unicode, safe_str
+from rhodecode.model.db import Repository
+from rhodecode.model.repo import RepoModel
+from rhodecode.tests import (
+    HG_REPO, GIT_REPO, assert_session_flash, no_newline_id_generator)
+from rhodecode.tests.fixture import Fixture
+from rhodecode.tests.utils import repo_on_filesystem
+
+fixture = Fixture()
+
+
+def route_path(name, params=None, **kwargs):
+    import urllib
+
+    base_url = {
+        'repo_summary_explicit': '/{repo_name}/summary',
+        'repo_summary': '/{repo_name}',
+        'edit_repo_advanced': '/{repo_name}/settings/advanced',
+        'edit_repo_advanced_delete': '/{repo_name}/settings/advanced/delete',
+        'edit_repo_advanced_fork': '/{repo_name}/settings/advanced/fork',
+        'edit_repo_advanced_locking': '/{repo_name}/settings/advanced/locking',
+        'edit_repo_advanced_journal': '/{repo_name}/settings/advanced/journal',
+
+    }[name].format(**kwargs)
+
+    if params:
+        base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
+    return base_url
+
+
[e-mail]('autologin_user', 'app')
+class TestAdminRepoSettingsAdvanced(object):
+
+    def test_set_repo_fork_has_no_self_id(self, autologin_user, backend):
+        repo = backend.repo
+        response = self.app.get(
+            route_path('edit_repo_advanced', repo_name=backend.repo_name))
+        opt = """<option value="%s">vcs_test_git</option>""" % repo.repo_id
+        response.mustcontain(no=[opt])
+
+    def test_set_fork_of_target_repo(
+            self, autologin_user, backend, csrf_token):
+        target_repo = 'target_%s' % backend.alias
+        fixture.create_repo(target_repo, repo_type=backend.alias)
+        repo2 = Repository.get_by_repo_name(target_repo)
+        response = self.app.post(
+            route_path('edit_repo_advanced_fork', repo_name=backend.repo_name),
+            params={'id_fork_of': repo2.repo_id,
+                    'csrf_token': csrf_token})
+        repo = Repository.get_by_repo_name(backend.repo_name)
+        repo2 = Repository.get_by_repo_name(target_repo)
+        assert_session_flash(
+            response,
+            'Marked repo %s as fork of %s' % (repo.repo_name, repo2.repo_name))
+
+        assert repo.fork == repo2
+        response = response.follow()
+        # check if given repo is selected
+
+        opt = 'This repository is a fork of <a href="%s">%s</a>' % (
+            route_path('repo_summary', repo_name=repo2.repo_name),
+            repo2.repo_name)
+
+        response.mustcontain(opt)
+
+        fixture.destroy_repo(target_repo, forks='detach')
+
+    @pytest.mark.backends("hg", "git")
+    def test_set_fork_of_other_type_repo(
+            self, autologin_user, backend, csrf_token):
+        TARGET_REPO_MAP = {
+            'git': {
+                'type': 'hg',
+                'repo_name': HG_REPO},
+            'hg': {
+                'type': 'git',
+                'repo_name': GIT_REPO},
+        }
+        target_repo = TARGET_REPO_MAP[backend.alias]
+
+        repo2 = Repository.get_by_repo_name(target_repo['repo_name'])
+        response = self.app.post(
+            route_path('edit_repo_advanced_fork', repo_name=backend.repo_name),
+            params={'id_fork_of': repo2.repo_id,
+                    'csrf_token': csrf_token})
+        assert_session_flash(
+            response,
+            'Cannot set repository as fork of repository with other type')
+
+    def test_set_fork_of_none(self, autologin_user, backend, csrf_token):
+        # mark it as None
+        response = self.app.post(
+            route_path('edit_repo_advanced_fork', repo_name=backend.repo_name),
+            params={'id_fork_of': None, '_method': 'put',
+                    'csrf_token': csrf_token})
+        assert_session_flash(
+            response,
+            'Marked repo %s as fork of %s'
+            % (backend.repo_name, "Nothing"))
+        assert backend.repo.fork is None
+
+    def test_set_fork_of_same_repo(self, autologin_user, backend, csrf_token):
+        repo = Repository.get_by_repo_name(backend.repo_name)
+        response = self.app.post(
+            route_path('edit_repo_advanced_fork', repo_name=backend.repo_name),
+            params={'id_fork_of': repo.repo_id, 'csrf_token': csrf_token})
+        assert_session_flash(
+            response, 'An error occurred during this operation')
+
+    @pytest.mark.parametrize(
+        "suffix",
+        ['', u'ąęł' , '123'],
+        ids=no_newline_id_generator)
+    def test_advanced_delete(self, autologin_user, backend, suffix, csrf_token):
+        repo = backend.create_repo(name_suffix=suffix)
+        repo_name = repo.repo_name
+        repo_name_str = safe_str(repo.repo_name)
+
+        response = self.app.post(
+            route_path('edit_repo_advanced_delete', repo_name=repo_name_str),
+            params={'csrf_token': csrf_token})
+        assert_session_flash(response,
+                             u'Deleted repository `{}`'.format(repo_name))
+        response.follow()
+
+        # check if repo was deleted from db
+        assert RepoModel().get_by_repo_name(repo_name) is None
+        assert not repo_on_filesystem(repo_name_str)

rhodecode/apps/repository/tests/test_vcs_settings.py

@@ -0,0 +1,117 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2010-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import mock
+import pytest
+
+import rhodecode
+from rhodecode.model.settings import SettingsModel
+from rhodecode.tests import url
+from rhodecode.tests.utils import AssertResponse
+
+
+def route_path(name, params=None, **kwargs):
+    import urllib
+
+    base_url = {
+        'edit_repo': '/{repo_name}/settings',
+    }[name].format(**kwargs)
+
+    if params:
+        base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
+    return base_url
+
+
[e-mail]('autologin_user', 'app')
+class TestAdminRepoVcsSettings(object):
+
+    @pytest.mark.parametrize('setting_name, setting_backends', [
+        ('hg_use_rebase_for_merging', ['hg']),
+    ])
+    def test_labs_settings_visible_if_enabled(
+            self, setting_name, setting_backends, backend):
+        if backend.alias not in setting_backends:
+            pytest.skip('Setting not available for backend {}'.format(backend))
+
+        vcs_settings_url = url(
+            'repo_vcs_settings', repo_name=backend.repo.repo_name)
+
+        with mock.patch.dict(
+                rhodecode.CONFIG, {'labs_settings_active': 'true'}):
+            response = self.app.get(vcs_settings_url)
+
+        assertr = AssertResponse(response)
+        assertr.one_element_exists('#rhodecode_{}'.format(setting_name))
+
+    @pytest.mark.parametrize('setting_name, setting_backends', [
+        ('hg_use_rebase_for_merging', ['hg']),
+    ])
+    def test_labs_settings_not_visible_if_disabled(
+            self, setting_name, setting_backends, backend):
+        if backend.alias not in setting_backends:
+            pytest.skip('Setting not available for backend {}'.format(backend))
+
+        vcs_settings_url = url(
+            'repo_vcs_settings', repo_name=backend.repo.repo_name)
+
+        with mock.patch.dict(
+                rhodecode.CONFIG, {'labs_settings_active': 'false'}):
+            response = self.app.get(vcs_settings_url)
+
+        assertr = AssertResponse(response)
+        assertr.no_element_exists('#rhodecode_{}'.format(setting_name))
+
+    @pytest.mark.parametrize('setting_name, setting_backends', [
+        ('hg_use_rebase_for_merging', ['hg']),
+    ])
+    def test_update_boolean_settings(
+            self, csrf_token, setting_name, setting_backends, backend):
+        if backend.alias not in setting_backends:
+            pytest.skip('Setting not available for backend {}'.format(backend))
+
+        repo = backend.create_repo()
+
+        settings_model = SettingsModel(repo=repo)
+        vcs_settings_url = url(
+            'repo_vcs_settings', repo_name=repo.repo_name)
+
+        self.app.post(
+            vcs_settings_url,
+            params={
+                'inherit_global_settings': False,
+                'new_svn_branch': 'dummy-value-for-testing',
+                'new_svn_tag': 'dummy-value-for-testing',
+                'rhodecode_{}'.format(setting_name): 'true',
+                'csrf_token': csrf_token,
+            })
+        setting = settings_model.get_setting_by_name(setting_name)
+        assert setting.app_settings_value
+
+        self.app.post(
+            vcs_settings_url,
+            params={
+                'inherit_global_settings': False,
+                'new_svn_branch': 'dummy-value-for-testing',
+                'new_svn_tag': 'dummy-value-for-testing',
+                'rhodecode_{}'.format(setting_name): 'false',
+                'csrf_token': csrf_token,
+            })
+        setting = settings_model.get_setting_by_name(setting_name)
+        assert not setting.app_settings_value

rhodecode/apps/repository/utils.py

@@ -0,0 +1,76 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+from rhodecode.lib import helpers as h
+from rhodecode.lib.utils2 import safe_int
+
+
+def reviewer_as_json(user, reasons=None, mandatory=False):
+    """
+    Returns json struct of a reviewer for frontend
+
+    :param user: the reviewer
+    :param reasons: list of strings of why they are reviewers
+    :param mandatory: bool, to set user as mandatory
+    """
+
+    return {
+        'user_id': user.user_id,
+        'reasons': reasons or [],
+        'mandatory': mandatory,
+        'username': user.username,
+        'first_name': user.first_name,
+        'last_name': user.last_name,
+        'gravatar_link': h.gravatar_url(user.email, 14),
+    }
+
+
+def get_default_reviewers_data(
+        current_user, source_repo, source_commit, target_repo, target_commit):
+
+    """ Return json for default reviewers of a repository """
+
+    reasons = ['Default reviewer', 'Repository owner']
+    default = reviewer_as_json(
+        user=current_user, reasons=reasons, mandatory=False)
+
+    return {
+        'api_ver': 'v1',  # define version for later possible schema upgrade
+        'reviewers': [default],
+        'rules': {},
+        'rules_data': {},
+    }
+
+
+def validate_default_reviewers(review_members, reviewer_rules):
+    """
+    Function to validate submitted reviewers against the saved rules
+
+    """
+    reviewers = []
+    reviewer_by_id = {}
+    for r in review_members:
+        reviewer_user_id = safe_int(r['user_id'])
+        entry = (reviewer_user_id, r['reasons'], r['mandatory'])
+
+        reviewer_by_id[reviewer_user_id] = entry
+        reviewers.append(entry)
+
+    return reviewers

rhodecode/apps/repository/views/repo_bookmarks.py

@@ -0,0 +1,50 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2011-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+import logging
+
+from pyramid.httpexceptions import HTTPNotFound
+from pyramid.view import view_config
+
+from rhodecode.apps._base import BaseReferencesView
+from rhodecode.lib.auth import (LoginRequired, HasRepoPermissionAnyDecorator)
+from rhodecode.lib import helpers as h
+
+log = logging.getLogger(__name__)
+
+
+class RepoBookmarksView(BaseReferencesView):
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator(
+        'repository.read', 'repository.write', 'repository.admin')
+    @view_config(
+        route_name='bookmarks_home', request_method='GET',
+        renderer='rhodecode:templates/bookmarks/bookmarks.mako')
+    def bookmarks(self):
+        c = self.load_default_context()
+
+        if not h.is_hg(self.db_repo):
+            raise HTTPNotFound()
+
+        ref_items = self.rhodecode_vcs_repo.bookmarks.items()
+        self.load_refs_context(
+            ref_items=ref_items, partials_template='bookmarks/bookmarks_data.mako')
+
+        return self._get_template_context(c)

rhodecode/apps/repository/views/repo_branches.py

@@ -0,0 +1,51 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2011-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import logging
+from pyramid.view import view_config
+
+from rhodecode.apps._base import BaseReferencesView
+from rhodecode.lib.auth import (LoginRequired, HasRepoPermissionAnyDecorator)
+
+
+log = logging.getLogger(__name__)
+
+
+class RepoBranchesView(BaseReferencesView):
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator(
+        'repository.read', 'repository.write', 'repository.admin')
+    @view_config(
+        route_name='branches_home', request_method='GET',
+        renderer='rhodecode:templates/branches/branches.mako')
+    def branches(self):
+        c = self.load_default_context()
+        c.closed_branches = self.rhodecode_vcs_repo.branches_closed
+        # NOTE(marcink):
+        # we need this trick because of PartialRenderer still uses the
+        # global 'c', we might not need this after full pylons migration
+        self._register_global_c(c)
+
+        ref_items = self.rhodecode_vcs_repo.branches_all.items()
+        self.load_refs_context(
+            ref_items=ref_items, partials_template='branches/branches_data.mako')
+
+        return self._get_template_context(c)

rhodecode/apps/repository/views/repo_caches.py

@@ -0,0 +1,78 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2011-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import logging
+
+from pyramid.httpexceptions import HTTPFound
+from pyramid.view import view_config
+
+from rhodecode.apps._base import RepoAppView
+from rhodecode.lib.auth import LoginRequired, HasRepoPermissionAnyDecorator, \
+    CSRFRequired
+from rhodecode.lib import helpers as h
+from rhodecode.model.meta import Session
+from rhodecode.model.scm import ScmModel
+
+log = logging.getLogger(__name__)
+
+
+class RepoCachesView(RepoAppView):
+    def load_default_context(self):
+        c = self._get_local_tmpl_context()
+
+        # TODO(marcink): remove repo_info and use c.rhodecode_db_repo instead
+        c.repo_info = self.db_repo
+
+        self._register_global_c(c)
+        return c
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator('repository.admin')
+    @view_config(
+        route_name='edit_repo_caches', request_method='GET',
+        renderer='rhodecode:templates/admin/repos/repo_edit.mako')
+    def repo_caches(self):
+        c = self.load_default_context()
+        c.active = 'caches'
+
+        return self._get_template_context(c)
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator('repository.admin')
+    @CSRFRequired()
+    @view_config(
+        route_name='edit_repo_caches', request_method='POST')
+    def repo_caches_purge(self):
+        _ = self.request.translate
+        c = self.load_default_context()
+        c.active = 'caches'
+
+        try:
+            ScmModel().mark_for_invalidation(self.db_repo_name, delete=True)
+            Session().commit()
+            h.flash(_('Cache invalidation successful'),
+                    category='success')
+        except Exception:
+            log.exception("Exception during cache invalidation")
+            h.flash(_('An error occurred during cache invalidation'),
+                    category='error')
+
+        raise HTTPFound(h.route_path(
+            'edit_repo_caches', repo_name=self.db_repo_name))
  No newline at end of file

rhodecode/apps/repository/views/repo_permissions.py

@@ -0,0 +1,98 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2011-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import logging
+
+import deform
+from pyramid.httpexceptions import HTTPFound
+from pyramid.view import view_config
+
+from rhodecode.apps._base import RepoAppView
+from rhodecode.forms import RcForm
+from rhodecode.lib import helpers as h
+from rhodecode.lib import audit_logger
+from rhodecode.lib.auth import (
+    LoginRequired, HasRepoPermissionAnyDecorator,
+    HasRepoPermissionAllDecorator, CSRFRequired)
+from rhodecode.model.db import RepositoryField, RepoGroup
+from rhodecode.model.forms import RepoPermsForm
+from rhodecode.model.meta import Session
+from rhodecode.model.repo import RepoModel
+from rhodecode.model.scm import RepoGroupList, ScmModel
+from rhodecode.model.validation_schema.schemas import repo_schema
+
+log = logging.getLogger(__name__)
+
+
+class RepoSettingsPermissionsView(RepoAppView):
+
+    def load_default_context(self):
+        c = self._get_local_tmpl_context()
+
+        # TODO(marcink): remove repo_info and use c.rhodecode_db_repo instead
+        c.repo_info = self.db_repo
+
+        self._register_global_c(c)
+        return c
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator('repository.admin')
+    @view_config(
+        route_name='edit_repo_perms', request_method='GET',
+        renderer='rhodecode:templates/admin/repos/repo_edit.mako')
+    def edit_permissions(self):
+        c = self.load_default_context()
+        c.active = 'permissions'
+        return self._get_template_context(c)
+
+    @LoginRequired()
+    @HasRepoPermissionAllDecorator('repository.admin')
+    @CSRFRequired()
+    @view_config(
+        route_name='edit_repo_perms', request_method='POST',
+        renderer='rhodecode:templates/admin/repos/repo_edit.mako')
+    def edit_permissions_update(self):
+        _ = self.request.translate
+        c = self.load_default_context()
+        c.active = 'permissions'
+        data = self.request.POST
+        # store private flag outside of HTML to verify if we can modify
+        # default user permissions, prevents submition of FAKE post data
+        # into the form for private repos
+        data['repo_private'] = self.db_repo.private
+        form = RepoPermsForm()().to_python(data)
+        changes = RepoModel().update_permissions(
+            self.db_repo_name, form['perm_additions'], form['perm_updates'],
+            form['perm_deletions'])
+
+        action_data = {
+            'added': changes['added'],
+            'updated': changes['updated'],
+            'deleted': changes['deleted'],
+        }
+        audit_logger.store_web(
+            'repo.edit.permissions', action_data=action_data,
+            user=self._rhodecode_user, repo=self.db_repo)
+
+        Session().commit()
+        h.flash(_('Repository permissions updated'), category='success')
+
+        raise HTTPFound(
+            self.request.route_path('edit_repo_perms', repo_name=self.db_repo_name))

rhodecode/apps/repository/views/repo_pull_requests.py

@@ -0,0 +1,584 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2011-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import logging
+
+import collections
+from pyramid.httpexceptions import HTTPFound, HTTPNotFound
+from pyramid.view import view_config
+
+from rhodecode.apps._base import RepoAppView, DataGridAppView
+from rhodecode.lib import helpers as h, diffs, codeblocks
+from rhodecode.lib.auth import (
+    LoginRequired, HasRepoPermissionAnyDecorator)
+from rhodecode.lib.utils import PartialRenderer
+from rhodecode.lib.utils2 import str2bool, safe_int, safe_str
+from rhodecode.lib.vcs.backends.base import EmptyCommit
+from rhodecode.lib.vcs.exceptions import CommitDoesNotExistError, \
+    RepositoryRequirementError, NodeDoesNotExistError
+from rhodecode.model.comment import CommentsModel
+from rhodecode.model.db import PullRequest, PullRequestVersion, \
+    ChangesetComment, ChangesetStatus
+from rhodecode.model.pull_request import PullRequestModel, MergeCheck
+
+log = logging.getLogger(__name__)
+
+
+class RepoPullRequestsView(RepoAppView, DataGridAppView):
+
+    def load_default_context(self):
+        c = self._get_local_tmpl_context(include_app_defaults=True)
+        # TODO(marcink): remove repo_info and use c.rhodecode_db_repo instead
+        c.repo_info = self.db_repo
+        c.REVIEW_STATUS_APPROVED = ChangesetStatus.STATUS_APPROVED
+        c.REVIEW_STATUS_REJECTED = ChangesetStatus.STATUS_REJECTED
+        self._register_global_c(c)
+        return c
+
+    def _get_pull_requests_list(
+            self, repo_name, source, filter_type, opened_by, statuses):
+
+        draw, start, limit = self._extract_chunk(self.request)
+        search_q, order_by, order_dir = self._extract_ordering(self.request)
+        _render = PartialRenderer('data_table/_dt_elements.mako')
+
+        # pagination
+
+        if filter_type == 'awaiting_review':
+            pull_requests = PullRequestModel().get_awaiting_review(
+                repo_name, source=source, opened_by=opened_by,
+                statuses=statuses, offset=start, length=limit,
+                order_by=order_by, order_dir=order_dir)
+            pull_requests_total_count = PullRequestModel().count_awaiting_review(
+                repo_name, source=source, statuses=statuses,
+                opened_by=opened_by)
+        elif filter_type == 'awaiting_my_review':
+            pull_requests = PullRequestModel().get_awaiting_my_review(
+                repo_name, source=source, opened_by=opened_by,
+                user_id=self._rhodecode_user.user_id, statuses=statuses,
+                offset=start, length=limit, order_by=order_by,
+                order_dir=order_dir)
+            pull_requests_total_count = PullRequestModel().count_awaiting_my_review(
+                repo_name, source=source, user_id=self._rhodecode_user.user_id,
+                statuses=statuses, opened_by=opened_by)
+        else:
+            pull_requests = PullRequestModel().get_all(
+                repo_name, source=source, opened_by=opened_by,
+                statuses=statuses, offset=start, length=limit,
+                order_by=order_by, order_dir=order_dir)
+            pull_requests_total_count = PullRequestModel().count_all(
+                repo_name, source=source, statuses=statuses,
+                opened_by=opened_by)
+
+        data = []
+        comments_model = CommentsModel()
+        for pr in pull_requests:
+            comments = comments_model.get_all_comments(
+                self.db_repo.repo_id, pull_request=pr)
+
+            data.append({
+                'name': _render('pullrequest_name',
+                                pr.pull_request_id, pr.target_repo.repo_name),
+                'name_raw': pr.pull_request_id,
+                'status': _render('pullrequest_status',
+                                  pr.calculated_review_status()),
+                'title': _render(
+                    'pullrequest_title', pr.title, pr.description),
+                'description': h.escape(pr.description),
+                'updated_on': _render('pullrequest_updated_on',
+                                      h.datetime_to_time(pr.updated_on)),
+                'updated_on_raw': h.datetime_to_time(pr.updated_on),
+                'created_on': _render('pullrequest_updated_on',
+                                      h.datetime_to_time(pr.created_on)),
+                'created_on_raw': h.datetime_to_time(pr.created_on),
+                'author': _render('pullrequest_author',
+                                  pr.author.full_contact, ),
+                'author_raw': pr.author.full_name,
+                'comments': _render('pullrequest_comments', len(comments)),
+                'comments_raw': len(comments),
+                'closed': pr.is_closed(),
+            })
+
+        data = ({
+            'draw': draw,
+            'data': data,
+            'recordsTotal': pull_requests_total_count,
+            'recordsFiltered': pull_requests_total_count,
+        })
+        return data
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator(
+        'repository.read', 'repository.write', 'repository.admin')
+    @view_config(
+        route_name='pullrequest_show_all', request_method='GET',
+        renderer='rhodecode:templates/pullrequests/pullrequests.mako')
+    def pull_request_list(self):
+        c = self.load_default_context()
+
+        req_get = self.request.GET
+        c.source = str2bool(req_get.get('source'))
+        c.closed = str2bool(req_get.get('closed'))
+        c.my = str2bool(req_get.get('my'))
+        c.awaiting_review = str2bool(req_get.get('awaiting_review'))
+        c.awaiting_my_review = str2bool(req_get.get('awaiting_my_review'))
+
+        c.active = 'open'
+        if c.my:
+            c.active = 'my'
+        if c.closed:
+            c.active = 'closed'
+        if c.awaiting_review and not c.source:
+            c.active = 'awaiting'
+        if c.source and not c.awaiting_review:
+            c.active = 'source'
+        if c.awaiting_my_review:
+            c.active = 'awaiting_my'
+
+        return self._get_template_context(c)
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator(
+        'repository.read', 'repository.write', 'repository.admin')
+    @view_config(
+        route_name='pullrequest_show_all_data', request_method='GET',
+        renderer='json_ext', xhr=True)
+    def pull_request_list_data(self):
+
+        # additional filters
+        req_get = self.request.GET
+        source = str2bool(req_get.get('source'))
+        closed = str2bool(req_get.get('closed'))
+        my = str2bool(req_get.get('my'))
+        awaiting_review = str2bool(req_get.get('awaiting_review'))
+        awaiting_my_review = str2bool(req_get.get('awaiting_my_review'))
+
+        filter_type = 'awaiting_review' if awaiting_review \
+            else 'awaiting_my_review' if awaiting_my_review \
+            else None
+
+        opened_by = None
+        if my:
+            opened_by = [self._rhodecode_user.user_id]
+
+        statuses = [PullRequest.STATUS_NEW, PullRequest.STATUS_OPEN]
+        if closed:
+            statuses = [PullRequest.STATUS_CLOSED]
+
+        data = self._get_pull_requests_list(
+            repo_name=self.db_repo_name, source=source,
+            filter_type=filter_type, opened_by=opened_by, statuses=statuses)
+
+        return data
+
+    def _get_pr_version(self, pull_request_id, version=None):
+        pull_request_id = safe_int(pull_request_id)
+        at_version = None
+
+        if version and version == 'latest':
+            pull_request_ver = PullRequest.get(pull_request_id)
+            pull_request_obj = pull_request_ver
+            _org_pull_request_obj = pull_request_obj
+            at_version = 'latest'
+        elif version:
+            pull_request_ver = PullRequestVersion.get_or_404(version)
+            pull_request_obj = pull_request_ver
+            _org_pull_request_obj = pull_request_ver.pull_request
+            at_version = pull_request_ver.pull_request_version_id
+        else:
+            _org_pull_request_obj = pull_request_obj = PullRequest.get_or_404(
+                pull_request_id)
+
+        pull_request_display_obj = PullRequest.get_pr_display_object(
+            pull_request_obj, _org_pull_request_obj)
+
+        return _org_pull_request_obj, pull_request_obj, \
+               pull_request_display_obj, at_version
+
+    def _get_diffset(self, source_repo_name, source_repo,
+                     source_ref_id, target_ref_id,
+                     target_commit, source_commit, diff_limit, fulldiff,
+                     file_limit, display_inline_comments):
+
+        vcs_diff = PullRequestModel().get_diff(
+            source_repo, source_ref_id, target_ref_id)
+
+        diff_processor = diffs.DiffProcessor(
+            vcs_diff, format='newdiff', diff_limit=diff_limit,
+            file_limit=file_limit, show_full_diff=fulldiff)
+
+        _parsed = diff_processor.prepare()
+
+        def _node_getter(commit):
+            def get_node(fname):
+                try:
+                    return commit.get_node(fname)
+                except NodeDoesNotExistError:
+                    return None
+
+            return get_node
+
+        diffset = codeblocks.DiffSet(
+            repo_name=self.db_repo_name,
+            source_repo_name=source_repo_name,
+            source_node_getter=_node_getter(target_commit),
+            target_node_getter=_node_getter(source_commit),
+            comments=display_inline_comments
+        )
+        diffset = diffset.render_patchset(
+            _parsed, target_commit.raw_id, source_commit.raw_id)
+
+        return diffset
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator(
+        'repository.read', 'repository.write', 'repository.admin')
+    # @view_config(
+    #     route_name='pullrequest_show', request_method='GET',
+    #     renderer='rhodecode:templates/pullrequests/pullrequest_show.mako')
+    def pull_request_show(self):
+        pull_request_id = safe_int(
+            self.request.matchdict.get('pull_request_id'))
+        c = self.load_default_context()
+
+        version = self.request.GET.get('version')
+        from_version = self.request.GET.get('from_version') or version
+        merge_checks = self.request.GET.get('merge_checks')
+        c.fulldiff = str2bool(self.request.GET.get('fulldiff'))
+
+        (pull_request_latest,
+         pull_request_at_ver,
+         pull_request_display_obj,
+         at_version) = self._get_pr_version(
+            pull_request_id, version=version)
+        pr_closed = pull_request_latest.is_closed()
+
+        if pr_closed and (version or from_version):
+            # not allow to browse versions
+            raise HTTPFound(h.route_path(
+                'pullrequest_show', repo_name=self.db_repo_name,
+                pull_request_id=pull_request_id))
+
+        versions = pull_request_display_obj.versions()
+
+        c.at_version = at_version
+        c.at_version_num = (at_version
+                            if at_version and at_version != 'latest'
+                            else None)
+        c.at_version_pos = ChangesetComment.get_index_from_version(
+            c.at_version_num, versions)
+
+        (prev_pull_request_latest,
+         prev_pull_request_at_ver,
+         prev_pull_request_display_obj,
+         prev_at_version) = self._get_pr_version(
+            pull_request_id, version=from_version)
+
+        c.from_version = prev_at_version
+        c.from_version_num = (prev_at_version
+                              if prev_at_version and prev_at_version != 'latest'
+                              else None)
+        c.from_version_pos = ChangesetComment.get_index_from_version(
+            c.from_version_num, versions)
+
+        # define if we're in COMPARE mode or VIEW at version mode
+        compare = at_version != prev_at_version
+
+        # pull_requests repo_name we opened it against
+        # ie. target_repo must match
+        if self.db_repo_name != pull_request_at_ver.target_repo.repo_name:
+            raise HTTPNotFound()
+
+        c.shadow_clone_url = PullRequestModel().get_shadow_clone_url(
+            pull_request_at_ver)
+
+        c.pull_request = pull_request_display_obj
+        c.pull_request_latest = pull_request_latest
+
+        if compare or (at_version and not at_version == 'latest'):
+            c.allowed_to_change_status = False
+            c.allowed_to_update = False
+            c.allowed_to_merge = False
+            c.allowed_to_delete = False
+            c.allowed_to_comment = False
+            c.allowed_to_close = False
+        else:
+            can_change_status = PullRequestModel().check_user_change_status(
+                pull_request_at_ver, self._rhodecode_user)
+            c.allowed_to_change_status = can_change_status and not pr_closed
+
+            c.allowed_to_update = PullRequestModel().check_user_update(
+                pull_request_latest, self._rhodecode_user) and not pr_closed
+            c.allowed_to_merge = PullRequestModel().check_user_merge(
+                pull_request_latest, self._rhodecode_user) and not pr_closed
+            c.allowed_to_delete = PullRequestModel().check_user_delete(
+                pull_request_latest, self._rhodecode_user) and not pr_closed
+            c.allowed_to_comment = not pr_closed
+            c.allowed_to_close = c.allowed_to_merge and not pr_closed
+
+        c.forbid_adding_reviewers = False
+        c.forbid_author_to_review = False
+        c.forbid_commit_author_to_review = False
+
+        if pull_request_latest.reviewer_data and \
+                        'rules' in pull_request_latest.reviewer_data:
+            rules = pull_request_latest.reviewer_data['rules'] or {}
+            try:
+                c.forbid_adding_reviewers = rules.get(
+                    'forbid_adding_reviewers')
+                c.forbid_author_to_review = rules.get(
+                    'forbid_author_to_review')
+                c.forbid_commit_author_to_review = rules.get(
+                    'forbid_commit_author_to_review')
+            except Exception:
+                pass
+
+        # check merge capabilities
+        _merge_check = MergeCheck.validate(
+            pull_request_latest, user=self._rhodecode_user)
+        c.pr_merge_errors = _merge_check.error_details
+        c.pr_merge_possible = not _merge_check.failed
+        c.pr_merge_message = _merge_check.merge_msg
+
+        c.pull_request_review_status = _merge_check.review_status
+        if merge_checks:
+            self.request.override_renderer = \
+                'rhodecode:templates/pullrequests/pullrequest_merge_checks.mako'
+            return self._get_template_context(c)
+
+        comments_model = CommentsModel()
+
+        # reviewers and statuses
+        c.pull_request_reviewers = pull_request_at_ver.reviewers_statuses()
+        allowed_reviewers = [x[0].user_id for x in c.pull_request_reviewers]
+
+        # GENERAL COMMENTS with versions #
+        q = comments_model._all_general_comments_of_pull_request(pull_request_latest)
+        q = q.order_by(ChangesetComment.comment_id.asc())
+        general_comments = q
+
+        # pick comments we want to render at current version
+        c.comment_versions = comments_model.aggregate_comments(
+            general_comments, versions, c.at_version_num)
+        c.comments = c.comment_versions[c.at_version_num]['until']
+
+        # INLINE COMMENTS with versions  #
+        q = comments_model._all_inline_comments_of_pull_request(pull_request_latest)
+        q = q.order_by(ChangesetComment.comment_id.asc())
+        inline_comments = q
+
+        c.inline_versions = comments_model.aggregate_comments(
+            inline_comments, versions, c.at_version_num, inline=True)
+
+        # inject latest version
+        latest_ver = PullRequest.get_pr_display_object(
+            pull_request_latest, pull_request_latest)
+
+        c.versions = versions + [latest_ver]
+
+        # if we use version, then do not show later comments
+        # than current version
+        display_inline_comments = collections.defaultdict(
+            lambda: collections.defaultdict(list))
+        for co in inline_comments:
+            if c.at_version_num:
+                # pick comments that are at least UPTO given version, so we
+                # don't render comments for higher version
+                should_render = co.pull_request_version_id and \
+                                co.pull_request_version_id <= c.at_version_num
+            else:
+                # showing all, for 'latest'
+                should_render = True
+
+            if should_render:
+                display_inline_comments[co.f_path][co.line_no].append(co)
+
+        # load diff data into template context, if we use compare mode then
+        # diff is calculated based on changes between versions of PR
+
+        source_repo = pull_request_at_ver.source_repo
+        source_ref_id = pull_request_at_ver.source_ref_parts.commit_id
+
+        target_repo = pull_request_at_ver.target_repo
+        target_ref_id = pull_request_at_ver.target_ref_parts.commit_id
+
+        if compare:
+            # in compare switch the diff base to latest commit from prev version
+            target_ref_id = prev_pull_request_display_obj.revisions[0]
+
+        # despite opening commits for bookmarks/branches/tags, we always
+        # convert this to rev to prevent changes after bookmark or branch change
+        c.source_ref_type = 'rev'
+        c.source_ref = source_ref_id
+
+        c.target_ref_type = 'rev'
+        c.target_ref = target_ref_id
+
+        c.source_repo = source_repo
+        c.target_repo = target_repo
+
+        c.commit_ranges = []
+        source_commit = EmptyCommit()
+        target_commit = EmptyCommit()
+        c.missing_requirements = False
+
+        source_scm = source_repo.scm_instance()
+        target_scm = target_repo.scm_instance()
+
+        # try first shadow repo, fallback to regular repo
+        try:
+            commits_source_repo = pull_request_latest.get_shadow_repo()
+        except Exception:
+            log.debug('Failed to get shadow repo', exc_info=True)
+            commits_source_repo = source_scm
+
+        c.commits_source_repo = commits_source_repo
+        commit_cache = {}
+        try:
+            pre_load = ["author", "branch", "date", "message"]
+            show_revs = pull_request_at_ver.revisions
+            for rev in show_revs:
+                comm = commits_source_repo.get_commit(
+                    commit_id=rev, pre_load=pre_load)
+                c.commit_ranges.append(comm)
+                commit_cache[comm.raw_id] = comm
+
+            # Order here matters, we first need to get target, and then
+            # the source
+            target_commit = commits_source_repo.get_commit(
+                commit_id=safe_str(target_ref_id))
+
+            source_commit = commits_source_repo.get_commit(
+                commit_id=safe_str(source_ref_id))
+
+        except CommitDoesNotExistError:
+            log.warning(
+                'Failed to get commit from `{}` repo'.format(
+                    commits_source_repo), exc_info=True)
+        except RepositoryRequirementError:
+            log.warning(
+                'Failed to get all required data from repo', exc_info=True)
+            c.missing_requirements = True
+
+        c.ancestor = None  # set it to None, to hide it from PR view
+
+        try:
+            ancestor_id = source_scm.get_common_ancestor(
+                source_commit.raw_id, target_commit.raw_id, target_scm)
+            c.ancestor_commit = source_scm.get_commit(ancestor_id)
+        except Exception:
+            c.ancestor_commit = None
+
+        c.statuses = source_repo.statuses(
+            [x.raw_id for x in c.commit_ranges])
+
+        # auto collapse if we have more than limit
+        collapse_limit = diffs.DiffProcessor._collapse_commits_over
+        c.collapse_all_commits = len(c.commit_ranges) > collapse_limit
+        c.compare_mode = compare
+
+        # diff_limit is the old behavior, will cut off the whole diff
+        # if the limit is applied  otherwise will just hide the
+        # big files from the front-end
+        diff_limit = c.visual.cut_off_limit_diff
+        file_limit = c.visual.cut_off_limit_file
+
+        c.missing_commits = False
+        if (c.missing_requirements
+            or isinstance(source_commit, EmptyCommit)
+            or source_commit == target_commit):
+
+            c.missing_commits = True
+        else:
+
+            c.diffset = self._get_diffset(
+                c.source_repo.repo_name, commits_source_repo,
+                source_ref_id, target_ref_id,
+                target_commit, source_commit,
+                diff_limit, c.fulldiff, file_limit, display_inline_comments)
+
+            c.limited_diff = c.diffset.limited_diff
+
+            # calculate removed files that are bound to comments
+            comment_deleted_files = [
+                fname for fname in display_inline_comments
+                if fname not in c.diffset.file_stats]
+
+            c.deleted_files_comments = collections.defaultdict(dict)
+            for fname, per_line_comments in display_inline_comments.items():
+                if fname in comment_deleted_files:
+                    c.deleted_files_comments[fname]['stats'] = 0
+                    c.deleted_files_comments[fname]['comments'] = list()
+                    for lno, comments in per_line_comments.items():
+                        c.deleted_files_comments[fname]['comments'].extend(
+                            comments)
+
+        # this is a hack to properly display links, when creating PR, the
+        # compare view and others uses different notation, and
+        # compare_commits.mako renders links based on the target_repo.
+        # We need to swap that here to generate it properly on the html side
+        c.target_repo = c.source_repo
+
+        c.commit_statuses = ChangesetStatus.STATUSES
+
+        c.show_version_changes = not pr_closed
+        if c.show_version_changes:
+            cur_obj = pull_request_at_ver
+            prev_obj = prev_pull_request_at_ver
+
+            old_commit_ids = prev_obj.revisions
+            new_commit_ids = cur_obj.revisions
+            commit_changes = PullRequestModel()._calculate_commit_id_changes(
+                old_commit_ids, new_commit_ids)
+            c.commit_changes_summary = commit_changes
+
+            # calculate the diff for commits between versions
+            c.commit_changes = []
+            mark = lambda cs, fw: list(
+                h.itertools.izip_longest([], cs, fillvalue=fw))
+            for c_type, raw_id in mark(commit_changes.added, 'a') \
+                                + mark(commit_changes.removed, 'r') \
+                                + mark(commit_changes.common, 'c'):
+
+                if raw_id in commit_cache:
+                    commit = commit_cache[raw_id]
+                else:
+                    try:
+                        commit = commits_source_repo.get_commit(raw_id)
+                    except CommitDoesNotExistError:
+                        # in case we fail extracting still use "dummy" commit
+                        # for display in commit diff
+                        commit = h.AttributeDict(
+                            {'raw_id': raw_id,
+                             'message': 'EMPTY or MISSING COMMIT'})
+                c.commit_changes.append([c_type, commit])
+
+            # current user review statuses for each version
+            c.review_versions = {}
+            if self._rhodecode_user.user_id in allowed_reviewers:
+                for co in general_comments:
+                    if co.author.user_id == self._rhodecode_user.user_id:
+                        # each comment has a status change
+                        status = co.status_change
+                        if status:
+                            _ver_pr = status[0].comment.pull_request_version_id
+                            c.review_versions[_ver_pr] = status[0]
+
+        return self._get_template_context(c)

rhodecode/apps/repository/views/repo_review_rules.py

@@ -0,0 +1,64 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import logging
+
+from pyramid.view import view_config
+
+from rhodecode.apps._base import RepoAppView
+from rhodecode.apps.repository.utils import get_default_reviewers_data
+from rhodecode.lib.auth import LoginRequired, HasRepoPermissionAnyDecorator
+
+log = logging.getLogger(__name__)
+
+
+class RepoReviewRulesView(RepoAppView):
+    def load_default_context(self):
+        c = self._get_local_tmpl_context()
+
+        # TODO(marcink): remove repo_info and use c.rhodecode_db_repo instead
+        c.repo_info = self.db_repo
+
+        self._register_global_c(c)
+        return c
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator('repository.admin')
+    @view_config(
+        route_name='repo_reviewers', request_method='GET',
+        renderer='rhodecode:templates/admin/repos/repo_edit.mako')
+    def repo_review_rules(self):
+        c = self.load_default_context()
+        c.active = 'reviewers'
+
+        return self._get_template_context(c)
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator(
+        'repository.read', 'repository.write', 'repository.admin')
+    @view_config(
+        route_name='repo_default_reviewers_data', request_method='GET',
+        renderer='json_ext')
+    def repo_default_reviewers_data(self):
+        review_data = get_default_reviewers_data(
+            self.db_repo.user, None, None, None, None)
+        return review_data
+
+

rhodecode/apps/repository/views/repo_settings.py

@@ -0,0 +1,179 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2011-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import logging
+
+import deform
+from pyramid.httpexceptions import HTTPFound
+from pyramid.view import view_config
+
+from rhodecode.apps._base import RepoAppView
+from rhodecode.forms import RcForm
+from rhodecode.lib import helpers as h
+from rhodecode.lib import audit_logger
+from rhodecode.lib.auth import (
+    LoginRequired, HasRepoPermissionAnyDecorator,
+    HasRepoPermissionAllDecorator, CSRFRequired)
+from rhodecode.model.db import RepositoryField, RepoGroup
+from rhodecode.model.meta import Session
+from rhodecode.model.repo import RepoModel
+from rhodecode.model.scm import RepoGroupList, ScmModel
+from rhodecode.model.validation_schema.schemas import repo_schema
+
+log = logging.getLogger(__name__)
+
+
+class RepoSettingsView(RepoAppView):
+
+    def load_default_context(self):
+        c = self._get_local_tmpl_context()
+
+        # TODO(marcink): remove repo_info and use c.rhodecode_db_repo instead
+        c.repo_info = self.db_repo
+
+        acl_groups = RepoGroupList(
+            RepoGroup.query().all(),
+            perm_set=['group.write', 'group.admin'])
+        c.repo_groups = RepoGroup.groups_choices(groups=acl_groups)
+        c.repo_groups_choices = map(lambda k: k[0], c.repo_groups)
+
+        # in case someone no longer have a group.write access to a repository
+        # pre fill the list with this entry, we don't care if this is the same
+        # but it will allow saving repo data properly.
+        repo_group = self.db_repo.group
+        if repo_group and repo_group.group_id not in c.repo_groups_choices:
+            c.repo_groups_choices.append(repo_group.group_id)
+            c.repo_groups.append(RepoGroup._generate_choice(repo_group))
+
+        if c.repository_requirements_missing or self.rhodecode_vcs_repo is None:
+            # we might be in missing requirement state, so we load things
+            # without touching scm_instance()
+            c.landing_revs_choices, c.landing_revs = \
+                ScmModel().get_repo_landing_revs()
+        else:
+            c.landing_revs_choices, c.landing_revs = \
+                ScmModel().get_repo_landing_revs(self.db_repo)
+
+        c.personal_repo_group = c.auth_user.personal_repo_group
+        c.repo_fields = RepositoryField.query()\
+            .filter(RepositoryField.repository == self.db_repo).all()
+
+        self._register_global_c(c)
+        return c
+
+    def _get_schema(self, c, old_values=None):
+        return repo_schema.RepoSettingsSchema().bind(
+            repo_type=self.db_repo.repo_type,
+            repo_type_options=[self.db_repo.repo_type],
+            repo_ref_options=c.landing_revs_choices,
+            repo_ref_items=c.landing_revs,
+            repo_repo_group_options=c.repo_groups_choices,
+            repo_repo_group_items=c.repo_groups,
+            # user caller
+            user=self._rhodecode_user,
+            old_values=old_values
+        )
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator('repository.admin')
+    @view_config(
+        route_name='edit_repo', request_method='GET',
+        renderer='rhodecode:templates/admin/repos/repo_edit.mako')
+    def edit_settings(self):
+        c = self.load_default_context()
+        c.active = 'settings'
+
+        defaults = RepoModel()._get_defaults(self.db_repo_name)
+        defaults['repo_owner'] = defaults['user']
+        defaults['repo_landing_commit_ref'] = defaults['repo_landing_rev']
+
+        schema = self._get_schema(c)
+        c.form = RcForm(schema, appstruct=defaults)
+        return self._get_template_context(c)
+
+    @LoginRequired()
+    @HasRepoPermissionAllDecorator('repository.admin')
+    @CSRFRequired()
+    @view_config(
+        route_name='edit_repo', request_method='POST',
+        renderer='rhodecode:templates/admin/repos/repo_edit.mako')
+    def edit_settings_update(self):
+        _ = self.request.translate
+        c = self.load_default_context()
+        c.active = 'settings'
+        old_repo_name = self.db_repo_name
+
+        old_values = self.db_repo.get_api_data()
+        schema = self._get_schema(c, old_values=old_values)
+
+        c.form = RcForm(schema)
+        pstruct = self.request.POST.items()
+        pstruct.append(('repo_type', self.db_repo.repo_type))
+        try:
+            schema_data = c.form.validate(pstruct)
+        except deform.ValidationFailure as err_form:
+            return self._get_template_context(c)
+
+        # data is now VALID, proceed with updates
+        # save validated data back into the updates dict
+        validated_updates = dict(
+            repo_name=schema_data['repo_group']['repo_name_without_group'],
+            repo_group=schema_data['repo_group']['repo_group_id'],
+
+            user=schema_data['repo_owner'],
+            repo_description=schema_data['repo_description'],
+            repo_private=schema_data['repo_private'],
+            clone_uri=schema_data['repo_clone_uri'],
+            repo_landing_rev=schema_data['repo_landing_commit_ref'],
+            repo_enable_statistics=schema_data['repo_enable_statistics'],
+            repo_enable_locking=schema_data['repo_enable_locking'],
+            repo_enable_downloads=schema_data['repo_enable_downloads'],
+        )
+        # detect if CLONE URI changed, if we get OLD means we keep old values
+        if schema_data['repo_clone_uri_change'] == 'OLD':
+            validated_updates['clone_uri'] = self.db_repo.clone_uri
+
+        # use the new full name for redirect
+        new_repo_name = schema_data['repo_group']['repo_name_with_group']
+
+        # save extra fields into our validated data
+        for key, value in pstruct:
+            if key.startswith(RepositoryField.PREFIX):
+                validated_updates[key] = value
+
+        try:
+            RepoModel().update(self.db_repo, **validated_updates)
+            ScmModel().mark_for_invalidation(new_repo_name)
+
+            audit_logger.store_web(
+                'repo.edit', action_data={'old_data': old_values},
+                user=self._rhodecode_user, repo=self.db_repo)
+
+            Session().commit()
+
+            h.flash(_('Repository {} updated successfully').format(
+                old_repo_name), category='success')
+        except Exception:
+            log.exception("Exception during update of repository")
+            h.flash(_('Error occurred during update of repository {}').format(
+                old_repo_name), category='error')
+
+        raise HTTPFound(
+            self.request.route_path('edit_repo', repo_name=new_repo_name))

rhodecode/apps/repository/views/repo_settings_advanced.py

@@ -0,0 +1,226 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2011-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import logging
+
+from pyramid.view import view_config
+from pyramid.httpexceptions import HTTPFound
+
+from rhodecode.apps._base import RepoAppView
+from rhodecode.lib import helpers as h
+from rhodecode.lib import audit_logger
+from rhodecode.lib.auth import (
+    LoginRequired, HasRepoPermissionAnyDecorator, CSRFRequired)
+from rhodecode.lib.exceptions import AttachedForksError
+from rhodecode.lib.utils2 import safe_int
+from rhodecode.lib.vcs import RepositoryError
+from rhodecode.model.db import Session, UserFollowing, User, Repository
+from rhodecode.model.repo import RepoModel
+from rhodecode.model.scm import ScmModel
+
+log = logging.getLogger(__name__)
+
+
+class RepoSettingsView(RepoAppView):
+
+    def load_default_context(self):
+        c = self._get_local_tmpl_context()
+
+        # TODO(marcink): remove repo_info and use c.rhodecode_db_repo instead
+        c.repo_info = self.db_repo
+
+        self._register_global_c(c)
+        return c
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator('repository.admin')
+    @view_config(
+        route_name='edit_repo_advanced', request_method='GET',
+        renderer='rhodecode:templates/admin/repos/repo_edit.mako')
+    def edit_advanced(self):
+        c = self.load_default_context()
+        c.active = 'advanced'
+
+        c.default_user_id = User.get_default_user().user_id
+        c.in_public_journal = UserFollowing.query() \
+            .filter(UserFollowing.user_id == c.default_user_id) \
+            .filter(UserFollowing.follows_repository == c.repo_info).scalar()
+
+        c.has_origin_repo_read_perm = False
+        if self.db_repo.fork:
+            c.has_origin_repo_read_perm = h.HasRepoPermissionAny(
+                'repository.write', 'repository.read', 'repository.admin')(
+                self.db_repo.fork.repo_name, 'repo set as fork page')
+
+        return self._get_template_context(c)
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator('repository.admin')
+    @CSRFRequired()
+    @view_config(
+        route_name='edit_repo_advanced_delete', request_method='POST',
+        renderer='rhodecode:templates/admin/repos/repo_edit.mako')
+    def edit_advanced_delete(self):
+        """
+        Deletes the repository, or shows warnings if deletion is not possible
+        because of attached forks or other errors.
+        """
+        _ = self.request.translate
+        handle_forks = self.request.POST.get('forks', None)
+
+        try:
+            _forks = self.db_repo.forks.count()
+            if _forks and handle_forks:
+                if handle_forks == 'detach_forks':
+                    handle_forks = 'detach'
+                    h.flash(_('Detached %s forks') % _forks, category='success')
+                elif handle_forks == 'delete_forks':
+                    handle_forks = 'delete'
+                    h.flash(_('Deleted %s forks') % _forks, category='success')
+
+            old_data = self.db_repo.get_api_data()
+            RepoModel().delete(self.db_repo, forks=handle_forks)
+
+            repo = audit_logger.RepoWrap(repo_id=None,
+                                         repo_name=self.db_repo.repo_name)
+            audit_logger.store_web(
+                'repo.delete', action_data={'old_data': old_data},
+                user=self._rhodecode_user, repo=repo)
+
+            ScmModel().mark_for_invalidation(self.db_repo_name, delete=True)
+            h.flash(
+                _('Deleted repository `%s`') % self.db_repo_name,
+                category='success')
+            Session().commit()
+        except AttachedForksError:
+            repo_advanced_url = h.route_path(
+                'edit_repo_advanced', repo_name=self.db_repo_name,
+                _anchor='advanced-delete')
+            delete_anchor = h.link_to(_('detach or delete'), repo_advanced_url)
+            h.flash(_('Cannot delete `{repo}` it still contains attached forks. '
+                      'Try using {delete_or_detach} option.')
+                    .format(repo=self.db_repo_name, delete_or_detach=delete_anchor),
+                    category='warning')
+
+            # redirect to advanced for forks handle action ?
+            raise HTTPFound(repo_advanced_url)
+
+        except Exception:
+            log.exception("Exception during deletion of repository")
+            h.flash(_('An error occurred during deletion of `%s`')
+                    % self.db_repo_name, category='error')
+            # redirect to advanced for more deletion options
+            raise HTTPFound(
+                h.route_path('edit_repo_advanced', repo_name=self.db_repo_name),
+                _anchor='advanced-delete')
+
+        raise HTTPFound(h.route_path('home'))
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator('repository.admin')
+    @CSRFRequired()
+    @view_config(
+        route_name='edit_repo_advanced_journal', request_method='POST',
+        renderer='rhodecode:templates/admin/repos/repo_edit.mako')
+    def edit_advanced_journal(self):
+        """
+        Set's this repository to be visible in public journal,
+        in other words making default user to follow this repo
+        """
+        _ = self.request.translate
+
+        try:
+            user_id = User.get_default_user().user_id
+            ScmModel().toggle_following_repo(self.db_repo.repo_id, user_id)
+            h.flash(_('Updated repository visibility in public journal'),
+                    category='success')
+            Session().commit()
+        except Exception:
+            h.flash(_('An error occurred during setting this '
+                      'repository in public journal'),
+                    category='error')
+
+        raise HTTPFound(
+            h.route_path('edit_repo_advanced', repo_name=self.db_repo_name))
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator('repository.admin')
+    @CSRFRequired()
+    @view_config(
+        route_name='edit_repo_advanced_fork', request_method='POST',
+        renderer='rhodecode:templates/admin/repos/repo_edit.mako')
+    def edit_advanced_fork(self):
+        """
+        Mark given repository as a fork of another
+        """
+        _ = self.request.translate
+
+        new_fork_id = self.request.POST.get('id_fork_of')
+        try:
+
+            if new_fork_id and not new_fork_id.isdigit():
+                log.error('Given fork id %s is not an INT', new_fork_id)
+
+            fork_id = safe_int(new_fork_id)
+            repo = ScmModel().mark_as_fork(
+                self.db_repo_name, fork_id, self._rhodecode_user.user_id)
+            fork = repo.fork.repo_name if repo.fork else _('Nothing')
+            Session().commit()
+            h.flash(_('Marked repo %s as fork of %s') % (self.db_repo_name, fork),
+                    category='success')
+        except RepositoryError as e:
+            log.exception("Repository Error occurred")
+            h.flash(str(e), category='error')
+        except Exception as e:
+            log.exception("Exception while editing fork")
+            h.flash(_('An error occurred during this operation'),
+                    category='error')
+
+        raise HTTPFound(
+            h.route_path('edit_repo_advanced', repo_name=self.db_repo_name))
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator('repository.admin')
+    @CSRFRequired()
+    @view_config(
+        route_name='edit_repo_advanced_locking', request_method='POST',
+        renderer='rhodecode:templates/admin/repos/repo_edit.mako')
+    def edit_advanced_locking(self):
+        """
+        Toggle locking of repository
+        """
+        _ = self.request.translate
+        set_lock = self.request.POST.get('set_lock')
+        set_unlock = self.request.POST.get('set_unlock')
+
+        try:
+            if set_lock:
+                Repository.lock(self.db_repo, self._rhodecode_user.user_id,
+                                lock_reason=Repository.LOCK_WEB)
+                h.flash(_('Locked repository'), category='success')
+            elif set_unlock:
+                Repository.unlock(self.db_repo)
+                h.flash(_('Unlocked repository'), category='success')
+        except Exception as e:
+            log.exception("Exception during unlocking")
+            h.flash(_('An error occurred during unlocking'), category='error')
+
+        raise HTTPFound(
+            h.route_path('edit_repo_advanced', repo_name=self.db_repo_name))

rhodecode/apps/repository/views/repo_summary.py

@@ -0,0 +1,368 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2011-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import logging
+import string
+
+from pyramid.view import view_config
+
+from beaker.cache import cache_region
+
+
+from rhodecode.controllers import utils
+
+from rhodecode.apps._base import RepoAppView
+from rhodecode.config.conf import (LANGUAGES_EXTENSIONS_MAP)
+from rhodecode.lib import caches, helpers as h
+from rhodecode.lib.helpers import RepoPage
+from rhodecode.lib.utils2 import safe_str, safe_int
+from rhodecode.lib.auth import LoginRequired, HasRepoPermissionAnyDecorator
+from rhodecode.lib.markup_renderer import MarkupRenderer, relative_links
+from rhodecode.lib.ext_json import json
+from rhodecode.lib.vcs.backends.base import EmptyCommit
+from rhodecode.lib.vcs.exceptions import CommitError, EmptyRepositoryError
+from rhodecode.model.db import Statistics, CacheKey, User
+from rhodecode.model.meta import Session
+from rhodecode.model.repo import ReadmeFinder
+from rhodecode.model.scm import ScmModel
+
+log = logging.getLogger(__name__)
+
+
+class RepoSummaryView(RepoAppView):
+
+    def load_default_context(self):
+        c = self._get_local_tmpl_context(include_app_defaults=True)
+
+        # TODO(marcink): remove repo_info and use c.rhodecode_db_repo instead
+        c.repo_info = self.db_repo
+        c.rhodecode_repo = None
+        if not c.repository_requirements_missing:
+            c.rhodecode_repo = self.rhodecode_vcs_repo
+
+        self._register_global_c(c)
+        return c
+
+    def _get_readme_data(self, db_repo, default_renderer):
+        repo_name = db_repo.repo_name
+        log.debug('Looking for README file')
+
+        @cache_region('long_term')
+        def _generate_readme(cache_key):
+            readme_data = None
+            readme_node = None
+            readme_filename = None
+            commit = self._get_landing_commit_or_none(db_repo)
+            if commit:
+                log.debug("Searching for a README file.")
+                readme_node = ReadmeFinder(default_renderer).search(commit)
+            if readme_node:
+                relative_url = h.url('files_raw_home',
+                                     repo_name=repo_name,
+                                     revision=commit.raw_id,
+                                     f_path=readme_node.path)
+                readme_data = self._render_readme_or_none(
+                    commit, readme_node, relative_url)
+                readme_filename = readme_node.path
+            return readme_data, readme_filename
+
+        invalidator_context = CacheKey.repo_context_cache(
+            _generate_readme, repo_name, CacheKey.CACHE_TYPE_README)
+
+        with invalidator_context as context:
+            context.invalidate()
+            computed = context.compute()
+
+        return computed
+
+    def _get_landing_commit_or_none(self, db_repo):
+        log.debug("Getting the landing commit.")
+        try:
+            commit = db_repo.get_landing_commit()
+            if not isinstance(commit, EmptyCommit):
+                return commit
+            else:
+                log.debug("Repository is empty, no README to render.")
+        except CommitError:
+            log.exception(
+                "Problem getting commit when trying to render the README.")
+
+    def _render_readme_or_none(self, commit, readme_node, relative_url):
+        log.debug(
+            'Found README file `%s` rendering...', readme_node.path)
+        renderer = MarkupRenderer()
+        try:
+            html_source = renderer.render(
+                readme_node.content, filename=readme_node.path)
+            if relative_url:
+                return relative_links(html_source, relative_url)
+            return html_source
+        except Exception:
+            log.exception(
+                "Exception while trying to render the README")
+
+    def _load_commits_context(self, c):
+        p = safe_int(self.request.GET.get('page'), 1)
+        size = safe_int(self.request.GET.get('size'), 10)
+
+        def url_generator(**kw):
+            query_params = {
+                'size': size
+            }
+            query_params.update(kw)
+            return h.route_path(
+                'repo_summary_commits',
+                repo_name=c.rhodecode_db_repo.repo_name, _query=query_params)
+
+        pre_load = ['author', 'branch', 'date', 'message']
+        try:
+            collection = self.rhodecode_vcs_repo.get_commits(pre_load=pre_load)
+        except EmptyRepositoryError:
+            collection = self.rhodecode_vcs_repo
+
+        c.repo_commits = RepoPage(
+            collection, page=p, items_per_page=size, url=url_generator)
+        page_ids = [x.raw_id for x in c.repo_commits]
+        c.comments = self.db_repo.get_comments(page_ids)
+        c.statuses = self.db_repo.statuses(page_ids)
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator(
+        'repository.read', 'repository.write', 'repository.admin')
+    @view_config(
+        route_name='repo_summary_commits', request_method='GET',
+        renderer='rhodecode:templates/summary/summary_commits.mako')
+    def summary_commits(self):
+        c = self.load_default_context()
+        self._load_commits_context(c)
+        return self._get_template_context(c)
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator(
+        'repository.read', 'repository.write', 'repository.admin')
+    @view_config(
+        route_name='repo_summary', request_method='GET',
+        renderer='rhodecode:templates/summary/summary.mako')
+    @view_config(
+        route_name='repo_summary_slash', request_method='GET',
+        renderer='rhodecode:templates/summary/summary.mako')
+    def summary(self):
+        c = self.load_default_context()
+
+        # Prepare the clone URL
+        username = ''
+        if self._rhodecode_user.username != User.DEFAULT_USER:
+            username = safe_str(self._rhodecode_user.username)
+
+        _def_clone_uri = _def_clone_uri_by_id = c.clone_uri_tmpl
+        if '{repo}' in _def_clone_uri:
+            _def_clone_uri_by_id = _def_clone_uri.replace(
+                '{repo}', '_{repoid}')
+        elif '{repoid}' in _def_clone_uri:
+            _def_clone_uri_by_id = _def_clone_uri.replace(
+                '_{repoid}', '{repo}')
+
+        c.clone_repo_url = self.db_repo.clone_url(
+            user=username, uri_tmpl=_def_clone_uri)
+        c.clone_repo_url_id = self.db_repo.clone_url(
+            user=username, uri_tmpl=_def_clone_uri_by_id)
+
+        # If enabled, get statistics data
+
+        c.show_stats = bool(self.db_repo.enable_statistics)
+
+        stats = Session().query(Statistics) \
+            .filter(Statistics.repository == self.db_repo) \
+            .scalar()
+
+        c.stats_percentage = 0
+
+        if stats and stats.languages:
+            c.no_data = False is self.db_repo.enable_statistics
+            lang_stats_d = json.loads(stats.languages)
+
+            # Sort first by decreasing count and second by the file extension,
+            # so we have a consistent output.
+            lang_stats_items = sorted(lang_stats_d.iteritems(),
+                                      key=lambda k: (-k[1], k[0]))[:10]
+            lang_stats = [(x, {"count": y,
+                               "desc": LANGUAGES_EXTENSIONS_MAP.get(x)})
+                          for x, y in lang_stats_items]
+
+            c.trending_languages = json.dumps(lang_stats)
+        else:
+            c.no_data = True
+            c.trending_languages = json.dumps({})
+
+        scm_model = ScmModel()
+        c.enable_downloads = self.db_repo.enable_downloads
+        c.repository_followers = scm_model.get_followers(self.db_repo)
+        c.repository_forks = scm_model.get_forks(self.db_repo)
+        c.repository_is_user_following = scm_model.is_following_repo(
+            self.db_repo_name, self._rhodecode_user.user_id)
+
+        # first interaction with the VCS instance after here...
+        if c.repository_requirements_missing:
+            self.request.override_renderer = \
+                'rhodecode:templates/summary/missing_requirements.mako'
+            return self._get_template_context(c)
+
+        c.readme_data, c.readme_file = \
+            self._get_readme_data(self.db_repo, c.visual.default_renderer)
+
+        # loads the summary commits template context
+        self._load_commits_context(c)
+
+        return self._get_template_context(c)
+
+    def get_request_commit_id(self):
+        return self.request.matchdict['commit_id']
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator(
+        'repository.read', 'repository.write', 'repository.admin')
+    @view_config(
+        route_name='repo_stats', request_method='GET',
+        renderer='json_ext')
+    def repo_stats(self):
+        commit_id = self.get_request_commit_id()
+
+        _namespace = caches.get_repo_namespace_key(
+            caches.SUMMARY_STATS, self.db_repo_name)
+        show_stats = bool(self.db_repo.enable_statistics)
+        cache_manager = caches.get_cache_manager(
+            'repo_cache_long', _namespace)
+        _cache_key = caches.compute_key_from_params(
+            self.db_repo_name, commit_id, show_stats)
+
+        def compute_stats():
+            code_stats = {}
+            size = 0
+            try:
+                scm_instance = self.db_repo.scm_instance()
+                commit = scm_instance.get_commit(commit_id)
+
+                for node in commit.get_filenodes_generator():
+                    size += node.size
+                    if not show_stats:
+                        continue
+                    ext = string.lower(node.extension)
+                    ext_info = LANGUAGES_EXTENSIONS_MAP.get(ext)
+                    if ext_info:
+                        if ext in code_stats:
+                            code_stats[ext]['count'] += 1
+                        else:
+                            code_stats[ext] = {"count": 1, "desc": ext_info}
+            except EmptyRepositoryError:
+                pass
+            return {'size': h.format_byte_size_binary(size),
+                    'code_stats': code_stats}
+
+        stats = cache_manager.get(_cache_key, createfunc=compute_stats)
+        return stats
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator(
+        'repository.read', 'repository.write', 'repository.admin')
+    @view_config(
+        route_name='repo_refs_data', request_method='GET',
+        renderer='json_ext')
+    def repo_refs_data(self):
+        _ = self.request.translate
+        self.load_default_context()
+
+        repo = self.rhodecode_vcs_repo
+        refs_to_create = [
+            (_("Branch"), repo.branches, 'branch'),
+            (_("Tag"), repo.tags, 'tag'),
+            (_("Bookmark"), repo.bookmarks, 'book'),
+        ]
+        res = self._create_reference_data(
+            repo, self.db_repo_name, refs_to_create)
+        data = {
+            'more': False,
+            'results': res
+        }
+        return data
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator(
+        'repository.read', 'repository.write', 'repository.admin')
+    @view_config(
+        route_name='repo_refs_changelog_data', request_method='GET',
+        renderer='json_ext')
+    def repo_refs_changelog_data(self):
+        _ = self.request.translate
+        self.load_default_context()
+
+        repo = self.rhodecode_vcs_repo
+
+        refs_to_create = [
+            (_("Branches"), repo.branches, 'branch'),
+            (_("Closed branches"), repo.branches_closed, 'branch_closed'),
+            # TODO: enable when vcs can handle bookmarks filters
+            # (_("Bookmarks"), repo.bookmarks, "book"),
+        ]
+        res = self._create_reference_data(
+            repo, self.db_repo_name, refs_to_create)
+        data = {
+            'more': False,
+            'results': res
+        }
+        return data
+
+    def _create_reference_data(self, repo, full_repo_name, refs_to_create):
+        format_ref_id = utils.get_format_ref_id(repo)
+
+        result = []
+        for title, refs, ref_type in refs_to_create:
+            if refs:
+                result.append({
+                    'text': title,
+                    'children': self._create_reference_items(
+                        repo, full_repo_name, refs, ref_type,
+                        format_ref_id),
+                })
+        return result
+
+    def _create_reference_items(self, repo, full_repo_name, refs, ref_type,
+                                format_ref_id):
+        result = []
+        is_svn = h.is_svn(repo)
+        for ref_name, raw_id in refs.iteritems():
+            files_url = self._create_files_url(
+                repo, full_repo_name, ref_name, raw_id, is_svn)
+            result.append({
+                'text': ref_name,
+                'id': format_ref_id(ref_name, raw_id),
+                'raw_id': raw_id,
+                'type': ref_type,
+                'files_url': files_url,
+            })
+        return result
+
+    def _create_files_url(self, repo, full_repo_name, ref_name, raw_id, is_svn):
+        use_commit_id = '/' in ref_name or is_svn
+        return h.url(
+            'files_home',
+            repo_name=full_repo_name,
+            f_path=ref_name if is_svn else '',
+            revision=raw_id if use_commit_id else ref_name,
+            at=ref_name)

rhodecode/apps/repository/views/repo_tags.py

@@ -0,0 +1,45 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2011-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import logging
+from pyramid.view import view_config
+
+from rhodecode.apps._base import BaseReferencesView
+from rhodecode.lib.auth import (LoginRequired, HasRepoPermissionAnyDecorator)
+
+log = logging.getLogger(__name__)
+
+
+class RepoTagsView(BaseReferencesView):
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator(
+        'repository.read', 'repository.write', 'repository.admin')
+    @view_config(
+        route_name='tags_home', request_method='GET',
+        renderer='rhodecode:templates/tags/tags.mako')
+    def tags(self):
+        c = self.load_default_context()
+
+        ref_items = self.rhodecode_vcs_repo.tags.items()
+        self.load_refs_context(
+            ref_items=ref_items, partials_template='tags/tags_data.mako')
+
+        return self._get_template_context(c)

rhodecode/apps/search/__init__.py

@@ -0,0 +1,44 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+from rhodecode.apps._base import ADMIN_PREFIX
+
+
+def includeme(config):
+
+    config.add_route(
+        name='search',
+        pattern=ADMIN_PREFIX + '/search')
+
+    config.add_route(
+        name='search_repo',
+        pattern='/{repo_name:.*?[^/]}/search', repo_route=True)
+
+    # Scan module for configuration decorators.
+    config.scan()
+
+
+    # # FULL TEXT SEARCH
+    # rmap.connect('search', '%s/search' % (ADMIN_PREFIX,),
+    #              controller='search')
+    # rmap.connect('search_repo_home', '/{repo_name}/search',
+    #              controller='search',
+    #              action='index',
+    #              conditions={'function': check_repo},
+    #              requirements=URL_NAME_REQUIREMENTS)
  No newline at end of file

rhodecode/apps/search/tests/test_search.py

@@ -0,0 +1,202 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2010-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import os
+
+import mock
+import pytest
+from whoosh import query
+
+from rhodecode.tests import (
+    TestController, SkipTest, HG_REPO,
+    TEST_USER_REGULAR_LOGIN, TEST_USER_REGULAR_PASS)
+from rhodecode.tests.utils import AssertResponse
+
+
+def route_path(name, **kwargs):
+    from rhodecode.apps._base import ADMIN_PREFIX
+    return {
+        'search':
+            ADMIN_PREFIX + '/search',
+        'search_repo':
+            '/{repo_name}/search',
+
+    }[name].format(**kwargs)
+
+
+class TestSearchController(TestController):
+
+    def test_index(self):
+        self.log_user()
+        response = self.app.get(route_path('search'))
+        assert_response = AssertResponse(response)
+        assert_response.one_element_exists('input#q')
+
+    def test_search_files_empty_search(self):
+        if os.path.isdir(self.index_location):
+            raise SkipTest('skipped due to existing index')
+        else:
+            self.log_user()
+            response = self.app.get(route_path('search'),
+                                    {'q': HG_REPO})
+            response.mustcontain('There is no index to search in. '
+                                 'Please run whoosh indexer')
+
+    def test_search_validation(self):
+        self.log_user()
+        response = self.app.get(route_path('search'),
+            {'q': query, 'type': 'content', 'page_limit': 1000})
+
+        response.mustcontain(
+            'page_limit - 1000 is greater than maximum value 500')
+
+    @pytest.mark.parametrize("query, expected_hits, expected_paths", [
+        ('todo', 23, [
+            'vcs/backends/hg/inmemory.py',
+            'vcs/tests/test_git.py']),
+        ('extension:rst installation', 6, [
+            'docs/index.rst',
+            'docs/installation.rst']),
+        ('def repo', 87, [
+            'vcs/tests/test_git.py',
+            'vcs/tests/test_changesets.py']),
+        ('repository:%s def test' % HG_REPO, 18, [
+            'vcs/tests/test_git.py',
+            'vcs/tests/test_changesets.py']),
+        ('"def main"', 9, [
+            'vcs/__init__.py',
+            'vcs/tests/__init__.py',
+            'vcs/utils/progressbar.py']),
+        ('owner:test_admin', 358, [
+            'vcs/tests/base.py',
+            'MANIFEST.in',
+            'vcs/utils/termcolors.py',
+            'docs/theme/ADC/static/documentation.png']),
+        ('owner:test_admin def main', 72, [
+            'vcs/__init__.py',
+            'vcs/tests/test_utils_filesize.py',
+            'vcs/tests/test_cli.py']),
+        ('owner:michał test', 0, []),
+    ])
+    def test_search_files(self, query, expected_hits, expected_paths):
+        self.log_user()
+        response = self.app.get(route_path('search'),
+            {'q': query, 'type': 'content', 'page_limit': 500})
+
+        response.mustcontain('%s results' % expected_hits)
+        for path in expected_paths:
+            response.mustcontain(path)
+
+    @pytest.mark.parametrize("query, expected_hits, expected_commits", [
+        ('bother to ask where to fetch repo during tests', 3, [
+            ('hg', 'a00c1b6f5d7a6ae678fd553a8b81d92367f7ecf1'),
+            ('git', 'c6eb379775c578a95dad8ddab53f963b80894850'),
+            ('svn', '98')]),
+        ('michał', 0, []),
+        ('changed:tests/utils.py', 36, [
+            ('hg', 'a00c1b6f5d7a6ae678fd553a8b81d92367f7ecf1')]),
+        ('changed:vcs/utils/archivers.py', 11, [
+            ('hg', '25213a5fbb048dff8ba65d21e466a835536e5b70'),
+            ('hg', '47aedd538bf616eedcb0e7d630ea476df0e159c7'),
+            ('hg', 'f5d23247fad4856a1dabd5838afade1e0eed24fb'),
+            ('hg', '04ad456aefd6461aea24f90b63954b6b1ce07b3e'),
+            ('git', 'c994f0de03b2a0aa848a04fc2c0d7e737dba31fc'),
+            ('git', 'd1f898326327e20524fe22417c22d71064fe54a1'),
+            ('git', 'fe568b4081755c12abf6ba673ba777fc02a415f3'),
+            ('git', 'bafe786f0d8c2ff7da5c1dcfcfa577de0b5e92f1')]),
+        ('added:README.rst', 3, [
+            ('hg', '3803844fdbd3b711175fc3da9bdacfcd6d29a6fb'),
+            ('git', 'ff7ca51e58c505fec0dd2491de52c622bb7a806b'),
+            ('svn', '8')]),
+        ('changed:lazy.py', 15, [
+            ('hg', 'eaa291c5e6ae6126a203059de9854ccf7b5baa12'),
+            ('git', '17438a11f72b93f56d0e08e7d1fa79a378578a82'),
+            ('svn', '82'),
+            ('svn', '262'),
+            ('hg', 'f5d23247fad4856a1dabd5838afade1e0eed24fb'),
+            ('git', '33fa3223355104431402a888fa77a4e9956feb3e')
+            ]),
+        ('author:[e-mail] '
+         'commit_id:b986218ba1c9b0d6a259fac9b050b1724ed8e545', 1, [
+             ('hg', 'b986218ba1c9b0d6a259fac9b050b1724ed8e545')]),
+        ('b986218ba1c9b0d6a259fac9b050b1724ed8e545', 1, [
+             ('hg', 'b986218ba1c9b0d6a259fac9b050b1724ed8e545')]),
+        ('b986218b', 1, [
+             ('hg', 'b986218ba1c9b0d6a259fac9b050b1724ed8e545')]),
+    ])
+    def test_search_commit_messages(
+            self, query, expected_hits, expected_commits, enabled_backends):
+        self.log_user()
+        response = self.app.get(route_path('search'),
+            {'q': query, 'type': 'commit', 'page_limit': 500})
+
+        response.mustcontain('%s results' % expected_hits)
+        for backend, commit_id in expected_commits:
+            if backend in enabled_backends:
+                response.mustcontain(commit_id)
+
+    @pytest.mark.parametrize("query, expected_hits, expected_paths", [
+        ('readme.rst', 3, []),
+        ('test*', 75, []),
+        ('*model*', 1, []),
+        ('extension:rst', 48, []),
+        ('extension:rst api', 24, []),
+    ])
+    def test_search_file_paths(self, query, expected_hits, expected_paths):
+        self.log_user()
+        response = self.app.get(route_path('search'),
+            {'q': query, 'type': 'path', 'page_limit': 500})
+
+        response.mustcontain('%s results' % expected_hits)
+        for path in expected_paths:
+            response.mustcontain(path)
+
+    def test_search_commit_message_specific_repo(self, backend):
+        self.log_user()
+        response = self.app.get(
+            route_path('search_repo',repo_name=backend.repo_name),
+            {'q': 'bother to ask where to fetch repo during tests',
+             'type': 'commit'})
+
+        response.mustcontain('1 results')
+
+    def test_filters_are_not_applied_for_admin_user(self):
+        self.log_user()
+        with mock.patch('whoosh.searching.Searcher.search') as search_mock:
+            self.app.get(route_path('search'),
+                {'q': 'test query', 'type': 'commit'})
+        assert search_mock.call_count == 1
+        _, kwargs = search_mock.call_args
+        assert kwargs['filter'] is None
+
+    def test_filters_are_applied_for_normal_user(self, enabled_backends):
+        self.log_user(TEST_USER_REGULAR_LOGIN, TEST_USER_REGULAR_PASS)
+        with mock.patch('whoosh.searching.Searcher.search') as search_mock:
+            self.app.get(route_path('search'),
+                {'q': 'test query', 'type': 'commit'})
+        assert search_mock.call_count == 1
+        _, kwargs = search_mock.call_args
+        assert isinstance(kwargs['filter'], query.Or)
+        expected_repositories = [
+            'vcs_test_{}'.format(b) for b in enabled_backends]
+        queried_repositories = [
+            name for type_, name in kwargs['filter'].all_terms()]
+        for repository in expected_repositories:
+            assert repository in queried_repositories

rhodecode/apps/search/views.py

@@ -0,0 +1,133 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2011-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import logging
+import urllib
+from pyramid.view import view_config
+from webhelpers.util import update_params
+
+from rhodecode.apps._base import BaseAppView, RepoAppView
+from rhodecode.lib.auth import (LoginRequired, HasRepoPermissionAnyDecorator)
+from rhodecode.lib.helpers import Page
+from rhodecode.lib.utils2 import safe_str, safe_int
+from rhodecode.lib.index import searcher_from_config
+from rhodecode.model import validation_schema
+from rhodecode.model.validation_schema.schemas import search_schema
+
+log = logging.getLogger(__name__)
+
+
+def search(request, tmpl_context, repo_name):
+    searcher = searcher_from_config(request.registry.settings)
+    formatted_results = []
+    execution_time = ''
+
+    schema = search_schema.SearchParamsSchema()
+
+    search_params = {}
+    errors = []
+    try:
+        search_params = schema.deserialize(
+            dict(search_query=request.GET.get('q'),
+                 search_type=request.GET.get('type'),
+                 search_sort=request.GET.get('sort'),
+                 page_limit=request.GET.get('page_limit'),
+                 requested_page=request.GET.get('page'))
+        )
+    except validation_schema.Invalid as e:
+        errors = e.children
+
+    def url_generator(**kw):
+        q = urllib.quote(safe_str(search_query))
+        return update_params(
+            "?q=%s&type=%s" % (q, safe_str(search_type)), **kw)
+
+    c = tmpl_context
+    search_query = search_params.get('search_query')
+    search_type = search_params.get('search_type')
+    search_sort = search_params.get('search_sort')
+    if search_params.get('search_query'):
+        page_limit = search_params['page_limit']
+        requested_page = search_params['requested_page']
+
+        try:
+            search_result = searcher.search(
+                search_query, search_type, c.auth_user, repo_name,
+                requested_page, page_limit, search_sort)
+
+            formatted_results = Page(
+                search_result['results'], page=requested_page,
+                item_count=search_result['count'],
+                items_per_page=page_limit, url=url_generator)
+        finally:
+            searcher.cleanup()
+
+        if not search_result['error']:
+            execution_time = '%s results (%.3f seconds)' % (
+                search_result['count'],
+                search_result['runtime'])
+        elif not errors:
+            node = schema['search_query']
+            errors = [
+                validation_schema.Invalid(node, search_result['error'])]
+
+    c.perm_user = c.auth_user
+    c.repo_name = repo_name
+    c.sort = search_sort
+    c.url_generator = url_generator
+    c.errors = errors
+    c.formatted_results = formatted_results
+    c.runtime = execution_time
+    c.cur_query = search_query
+    c.search_type = search_type
+    c.searcher = searcher
+
+
+class SearchView(BaseAppView):
+    def load_default_context(self):
+        c = self._get_local_tmpl_context()
+        self._register_global_c(c)
+        return c
+
+    @LoginRequired()
+    @view_config(
+        route_name='search', request_method='GET',
+        renderer='rhodecode:templates/search/search.mako')
+    def search(self):
+        c = self.load_default_context()
+        search(self.request, c, repo_name=None)
+        return self._get_template_context(c)
+
+
+class SearchRepoView(RepoAppView):
+    def load_default_context(self):
+        c = self._get_local_tmpl_context()
+        self._register_global_c(c)
+        return c
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator('repository.admin')
+    @view_config(
+        route_name='search_repo', request_method='GET',
+        renderer='rhodecode:templates/search/search.mako')
+    def search_repo(self):
+        c = self.load_default_context()
+        search(self.request, c, repo_name=self.db_repo_name)
+        return self._get_template_context(c)

rhodecode/lib/audit_logger.py

@@ -0,0 +1,255 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2017-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import logging
+import datetime
+
+from rhodecode.model import meta
+from rhodecode.model.db import User, UserLog, Repository
+
+
+log = logging.getLogger(__name__)
+
+# action as key, and expected action_data as value
+ACTIONS_V1 = {
+    'user.login.success': {'user_agent': ''},
+    'user.login.failure': {'user_agent': ''},
+    'user.logout': {'user_agent': ''},
+    'user.password.reset_request': {},
+    'user.push': {'user_agent': '', 'commit_ids': []},
+    'user.pull': {'user_agent': ''},
+
+    'user.create': {'data': {}},
+    'user.delete': {'old_data': {}},
+    'user.edit': {'old_data': {}},
+    'user.edit.permissions': {},
+    'user.edit.ip.add': {'ip': {}, 'user': {}},
+    'user.edit.ip.delete': {'ip': {}, 'user': {}},
+    'user.edit.token.add': {'token': {}, 'user': {}},
+    'user.edit.token.delete': {'token': {}, 'user': {}},
+    'user.edit.email.add': {'email': ''},
+    'user.edit.email.delete': {'email': ''},
+    'user.edit.password_reset.enabled': {},
+    'user.edit.password_reset.disabled': {},
+
+    'user_group.create': {'data': {}},
+    'user_group.delete': {'old_data': {}},
+    'user_group.edit': {'old_data': {}},
+    'user_group.edit.permissions': {},
+    'user_group.edit.member.add': {'user': {}},
+    'user_group.edit.member.delete': {'user': {}},
+
+    'repo.create': {'data': {}},
+    'repo.fork': {'data': {}},
+    'repo.edit': {'old_data': {}},
+    'repo.edit.permissions': {},
+    'repo.delete': {'old_data': {}},
+    'repo.commit.strip': {'commit_id': ''},
+    'repo.archive.download': {'user_agent': '', 'archive_name': '',
+                              'archive_spec': '', 'archive_cached': ''},
+    'repo.pull_request.create': '',
+    'repo.pull_request.edit': '',
+    'repo.pull_request.delete': '',
+    'repo.pull_request.close': '',
+    'repo.pull_request.merge': '',
+    'repo.pull_request.vote': '',
+    'repo.pull_request.comment.create': '',
+    'repo.pull_request.comment.delete': '',
+
+    'repo.pull_request.reviewer.add': '',
+    'repo.pull_request.reviewer.delete': '',
+
+    'repo.commit.comment.create': {'data': {}},
+    'repo.commit.comment.delete': {'data': {}},
+    'repo.commit.vote': '',
+
+    'repo_group.create': {'data': {}},
+    'repo_group.edit': {'old_data': {}},
+    'repo_group.edit.permissions': {},
+    'repo_group.delete': {'old_data': {}},
+}
+ACTIONS = ACTIONS_V1
+
+SOURCE_WEB = 'source_web'
+SOURCE_API = 'source_api'
+
+
+class UserWrap(object):
+    """
+    Fake object used to imitate AuthUser
+    """
+
+    def __init__(self, user_id=None, username=None, ip_addr=None):
+        self.user_id = user_id
+        self.username = username
+        self.ip_addr = ip_addr
+
+
+class RepoWrap(object):
+    """
+    Fake object used to imitate RepoObject that audit logger requires
+    """
+
+    def __init__(self, repo_id=None, repo_name=None):
+        self.repo_id = repo_id
+        self.repo_name = repo_name
+
+
+def _store_log(action_name, action_data, user_id, username, user_data,
+               ip_address, repository_id, repository_name):
+    user_log = UserLog()
+    user_log.version = UserLog.VERSION_2
+
+    user_log.action = action_name
+    user_log.action_data = action_data
+
+    user_log.user_ip = ip_address
+
+    user_log.user_id = user_id
+    user_log.username = username
+    user_log.user_data = user_data
+
+    user_log.repository_id = repository_id
+    user_log.repository_name = repository_name
+
+    user_log.action_date = datetime.datetime.now()
+
+    log.info('AUDIT: Logging action: `%s` by user:id:%s[%s] ip:%s',
+             action_name, user_id, username, ip_address)
+
+    return user_log
+
+
+def store_web(*args, **kwargs):
+    if 'action_data' not in kwargs:
+        kwargs['action_data'] = {}
+    kwargs['action_data'].update({
+        'source': SOURCE_WEB
+    })
+    return store(*args, **kwargs)
+
+
+def store_api(*args, **kwargs):
+    if 'action_data' not in kwargs:
+        kwargs['action_data'] = {}
+    kwargs['action_data'].update({
+        'source': SOURCE_API
+    })
+    return store(*args, **kwargs)
+
+
+def store(action, user, action_data=None, user_data=None, ip_addr=None,
+          repo=None, sa_session=None, commit=False):
+    """
+    Audit logger for various actions made by users, typically this
+    results in a call such::
+
+        from rhodecode.lib import audit_logger
+
+        audit_logger.store(
+            'repo.edit', user=self._rhodecode_user)
+        audit_logger.store(
+            'repo.delete', action_data={'data': repo_data},
+            user=audit_logger.UserWrap(username='itried-login', ip_addr='8.8.8.8'))
+
+        # repo action
+        audit_logger.store(
+            'repo.delete',
+            user=audit_logger.UserWrap(username='itried-login', ip_addr='8.8.8.8'),
+            repo=audit_logger.RepoWrap(repo_name='some-repo'))
+
+        # repo action, when we know and have the repository object already
+        audit_logger.store(
+            'repo.delete', action_data={'source': audit_logger.SOURCE_WEB, },
+            user=self._rhodecode_user,
+            repo=repo_object)
+
+        # alternative wrapper to the above
+        audit_logger.store_web(
+            'repo.delete', action_data={},
+            user=self._rhodecode_user,
+            repo=repo_object)
+
+        # without an user ?
+        audit_logger.store(
+            'user.login.failure',
+            user=audit_logger.UserWrap(
+                    username=self.request.params.get('username'),
+                    ip_addr=self.request.remote_addr))
+
+    """
+    from rhodecode.lib.utils2 import safe_unicode
+    from rhodecode.lib.auth import AuthUser
+
+    action_spec = ACTIONS.get(action, None)
+    if action_spec is None:
+        raise ValueError('Action `{}` is not supported'.format(action))
+
+    if not sa_session:
+        sa_session = meta.Session()
+
+    try:
+        username = getattr(user, 'username', None)
+        if not username:
+            pass
+
+        user_id = getattr(user, 'user_id', None)
+        if not user_id:
+            # maybe we have username ? Try to figure user_id from username
+            if username:
+                user_id = getattr(
+                    User.get_by_username(username), 'user_id', None)
+
+        ip_addr = ip_addr or getattr(user, 'ip_addr', None)
+        if not ip_addr:
+            pass
+
+        if not user_data:
+            # try to get this from the auth user
+            if isinstance(user, AuthUser):
+                user_data = {
+                    'username': user.username,
+                    'email': user.email,
+                }
+
+        repository_name = getattr(repo, 'repo_name', None)
+        repository_id = getattr(repo, 'repo_id', None)
+        if not repository_id:
+            # maybe we have repo_name ? Try to figure repo_id from repo_name
+            if repository_name:
+                repository_id = getattr(
+                    Repository.get_by_repo_name(repository_name), 'repo_id', None)
+
+        user_log = _store_log(
+            action_name=safe_unicode(action),
+            action_data=action_data or {},
+            user_id=user_id,
+            username=username,
+            user_data=user_data or {},
+            ip_address=safe_unicode(ip_addr),
+            repository_id=repository_id,
+            repository_name=repository_name
+        )
+        sa_session.add(user_log)
+        if commit:
+            sa_session.commit()
+
+    except Exception:
+        log.exception('AUDIT: failed to store audit log')

rhodecode/lib/dbmigrate/versions/072_version_4_8_0.py

@@ -0,0 +1,61 b''
+import os
+import logging
+import datetime
+
+from sqlalchemy import *
+from sqlalchemy.exc import DatabaseError
+from sqlalchemy.orm import relation, backref, class_mapper, joinedload
+from sqlalchemy.orm.session import Session
+from sqlalchemy.ext.declarative import declarative_base
+
+from rhodecode.lib.dbmigrate.migrate import *
+from rhodecode.lib.dbmigrate.migrate.changeset import *
+from rhodecode.lib.utils2 import str2bool
+
+from rhodecode.model.meta import Base
+from rhodecode.model import meta
+from rhodecode.lib.dbmigrate.versions import _reset_base, notify
+
+log = logging.getLogger(__name__)
+
+
+def get_by_key(cls, key):
+    return cls.query().filter(cls.ui_key == key).scalar()
+
+
+def get_repos_location(cls):
+    return get_by_key(cls, '/').ui_value
+
+
+def upgrade(migrate_engine):
+    """
+    Upgrade operations go here.
+    Don't create your own engine; bind migrate_engine to your metadata
+    """
+    _reset_base(migrate_engine)
+    from rhodecode.lib.dbmigrate.schema import db_4_7_0_1 as db
+
+    # add last_activity
+    user_log_table = db.UserLog.__table__
+
+    user_data = Column('user_data_json', db.JsonType(dialect_map=dict(mysql=UnicodeText(16384))))
+    user_data.create(table=user_log_table)
+
+    version = Column("version", String(255), nullable=True, default='v2')
+    version.create(table=user_log_table)
+
+    action_data = Column('action_data_json', db.JsonType(dialect_map=dict(mysql=UnicodeText(16384))))
+    action_data.create(table=user_log_table)
+
+    # issue fixups
+    fixups(db, meta.Session)
+
+
+def downgrade(migrate_engine):
+    meta = MetaData()
+    meta.bind = migrate_engine
+
+
+def fixups(models, _SESSION):
+    pass
+

rhodecode/lib/dbmigrate/versions/073_version_4_8_0.py

@@ -0,0 +1,63 b''
+import logging
+
+from sqlalchemy import *
+from rhodecode.model import meta
+from rhodecode.lib.dbmigrate.versions import _reset_base, notify
+
+log = logging.getLogger(__name__)
+
+
+def get_by_key(cls, key):
+    return cls.query().filter(cls.ui_key == key).scalar()
+
+
+def create_or_update_hook(cls, key, val, SESSION):
+    new_ui = get_by_key(cls, key) or cls()
+    new_ui.ui_section = 'hooks'
+    new_ui.ui_active = True
+    new_ui.ui_key = key
+    new_ui.ui_value = val
+
+    SESSION().add(new_ui)
+
+
+def upgrade(migrate_engine):
+    """
+    Upgrade operations go here.
+    Don't create your own engine; bind migrate_engine to your metadata
+    """
+    _reset_base(migrate_engine)
+    from rhodecode.lib.dbmigrate.schema import db_4_7_0_0 as db
+
+    # issue fixups
+    fixups(db, meta.Session)
+
+
+def downgrade(migrate_engine):
+    meta = MetaData()
+    meta.bind = migrate_engine
+
+
+def fixups(models, _SESSION):
+
+    cleanup_if_present = (
+        'pushkey.key_push',
+    )
+
+    for hook in cleanup_if_present:
+        ui_cfg = models.RhodeCodeUi.query().filter(
+            models.RhodeCodeUi.ui_key == hook).scalar()
+        if ui_cfg is not None:
+            log.info('Removing RhodeCodeUI for hook "%s".', hook)
+            _SESSION().delete(ui_cfg)
+
+    to_add = [
+        ('pushkey.key_push',
+         'python:vcsserver.hooks.key_push'),
+    ]
+
+    for hook, value in to_add:
+        log.info('Adding RhodeCodeUI for hook "%s".', hook)
+        create_or_update_hook(models.RhodeCodeUi, hook, value, _SESSION)
+
+    _SESSION().commit()

rhodecode/lib/dbmigrate/versions/074_version_4_8_0.py

@@ -0,0 +1,37 b''
+import logging
+
+from sqlalchemy import *
+from rhodecode.model import meta
+from rhodecode.lib.dbmigrate.versions import _reset_base, notify
+
+log = logging.getLogger(__name__)
+
+
+def upgrade(migrate_engine):
+    """
+    Upgrade operations go here.
+    Don't create your own engine; bind migrate_engine to your metadata
+    """
+    _reset_base(migrate_engine)
+    from rhodecode.lib.dbmigrate.schema import db_4_7_0_1 as db
+
+    repo_review_rule_table = db.RepoReviewRule.__table__
+
+    forbid_author_to_review = Column(
+        "forbid_author_to_review", Boolean(), nullable=True, default=False)
+    forbid_author_to_review.create(table=repo_review_rule_table)
+
+    forbid_adding_reviewers = Column(
+        "forbid_adding_reviewers", Boolean(), nullable=True, default=False)
+    forbid_adding_reviewers.create(table=repo_review_rule_table)
+
+    fixups(db, meta.Session)
+
+
+def downgrade(migrate_engine):
+    meta = MetaData()
+    meta.bind = migrate_engine
+
+
+def fixups(models, _SESSION):
+    pass

rhodecode/lib/dbmigrate/versions/075_version_4_8_0.py

@@ -0,0 +1,38 b''
+import logging
+
+from sqlalchemy import *
+from rhodecode.model import meta
+from rhodecode.lib.dbmigrate.versions import _reset_base, notify
+
+log = logging.getLogger(__name__)
+
+
+def upgrade(migrate_engine):
+    """
+    Upgrade operations go here.
+    Don't create your own engine; bind migrate_engine to your metadata
+    """
+    _reset_base(migrate_engine)
+    from rhodecode.lib.dbmigrate.schema import db_4_7_0_1 as db
+
+    repo_review_rule_user_table = db.RepoReviewRuleUser.__table__
+    repo_review_rule_user_group_table = db.RepoReviewRuleUserGroup.__table__
+
+    mandatory_user = Column(
+        "mandatory", Boolean(), nullable=True, default=False)
+    mandatory_user.create(table=repo_review_rule_user_table)
+
+    mandatory_user_group = Column(
+        "mandatory", Boolean(), nullable=True, default=False)
+    mandatory_user_group.create(table=repo_review_rule_user_group_table)
+
+    fixups(db, meta.Session)
+
+
+def downgrade(migrate_engine):
+    meta = MetaData()
+    meta.bind = migrate_engine
+
+
+def fixups(models, _SESSION):
+    pass

rhodecode/lib/dbmigrate/versions/076_version_4_8_0.py

@@ -0,0 +1,33 b''
+import logging
+
+from sqlalchemy import *
+from rhodecode.model import meta
+from rhodecode.lib.dbmigrate.versions import _reset_base, notify
+
+log = logging.getLogger(__name__)
+
+
+def upgrade(migrate_engine):
+    """
+    Upgrade operations go here.
+    Don't create your own engine; bind migrate_engine to your metadata
+    """
+    _reset_base(migrate_engine)
+    from rhodecode.lib.dbmigrate.schema import db_4_7_0_1 as db
+
+    pull_request_reviewers = db.PullRequestReviewers.__table__
+
+    mandatory = Column(
+        "mandatory", Boolean(), nullable=True, default=False)
+    mandatory.create(table=pull_request_reviewers)
+
+    fixups(db, meta.Session)
+
+
+def downgrade(migrate_engine):
+    meta = MetaData()
+    meta.bind = migrate_engine
+
+
+def fixups(models, _SESSION):
+    pass

rhodecode/lib/dbmigrate/versions/077_version_4_8_0.py

@@ -0,0 +1,40 b''
+import logging
+
+from sqlalchemy import *
+from rhodecode.model import meta
+from rhodecode.lib.dbmigrate.versions import _reset_base, notify
+
+log = logging.getLogger(__name__)
+
+
+def upgrade(migrate_engine):
+    """
+    Upgrade operations go here.
+    Don't create your own engine; bind migrate_engine to your metadata
+    """
+    _reset_base(migrate_engine)
+    from rhodecode.lib.dbmigrate.schema import db_4_7_0_1 as db
+
+    pull_request = db.PullRequest.__table__
+    pull_request_version = db.PullRequestVersion.__table__
+
+    reviewer_data_1 = Column(
+        'reviewer_data_json',
+        db.JsonType(dialect_map=dict(mysql=UnicodeText(16384))))
+    reviewer_data_1.create(table=pull_request)
+
+    reviewer_data_2 = Column(
+        'reviewer_data_json',
+        db.JsonType(dialect_map=dict(mysql=UnicodeText(16384))))
+    reviewer_data_2.create(table=pull_request_version)
+
+    fixups(db, meta.Session)
+
+
+def downgrade(migrate_engine):
+    meta = MetaData()
+    meta.bind = migrate_engine
+
+
+def fixups(models, _SESSION):
+    pass

rhodecode/lib/dbmigrate/versions/078_version_4_8_0.py

@@ -0,0 +1,33 b''
+import logging
+
+from sqlalchemy import *
+from rhodecode.model import meta
+from rhodecode.lib.dbmigrate.versions import _reset_base, notify
+
+log = logging.getLogger(__name__)
+
+
+def upgrade(migrate_engine):
+    """
+    Upgrade operations go here.
+    Don't create your own engine; bind migrate_engine to your metadata
+    """
+    _reset_base(migrate_engine)
+    from rhodecode.lib.dbmigrate.schema import db_4_7_0_1 as db
+
+    repo_review_rule_table = db.RepoReviewRule.__table__
+
+    forbid_commit_author_to_review = Column(
+        "forbid_commit_author_to_review", Boolean(), nullable=True, default=False)
+    forbid_commit_author_to_review.create(table=repo_review_rule_table)
+
+    fixups(db, meta.Session)
+
+
+def downgrade(migrate_engine):
+    meta = MetaData()
+    meta.bind = migrate_engine
+
+
+def fixups(models, _SESSION):
+    pass

rhodecode/lib/ext_json_renderer.py

@@ -0,0 +1,37 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2010-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+from rhodecode.lib.ext_json import json
+
+
+def pyramid_ext_json(info):
+    """
+    Custom json renderer for pyramid to use our ext_json lib
+    """
+    def _render(value, system):
+        request = system.get('request')
+        if request is not None:
+            response = request.response
+            ct = response.content_type
+            if ct == response.default_content_type:
+                response.content_type = 'application/json'
+        return json.dumps(value)
+
+    return _render

rhodecode/model/validation_schema/schemas/reviewer_schema.py

@@ -0,0 +1,34 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import colander
+from rhodecode.model.validation_schema import validators, preparers, types
+
+
+class ReviewerSchema(colander.MappingSchema):
+    username = colander.SchemaNode(types.StrOrIntType())
+    reasons = colander.SchemaNode(colander.List(), missing=['no reason specified'])
+    mandatory = colander.SchemaNode(colander.Boolean(), missing=False)
+
+
+class ReviewerListSchema(colander.SequenceSchema):
+    reviewers = ReviewerSchema()
+
+

rhodecode/model/validation_schema/schemas/user_group_schema.py

@@ -0,0 +1,78 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+import re
+import colander
+
+from rhodecode.model.validation_schema import types, validators
+from rhodecode.translation import _
+
+
[e-mail]
+def deferred_user_group_name_validator(node, kw):
+
+    def name_validator(node, value):
+
+        msg = _('Allowed in name are letters, numbers, and `-`, `_`, `.` '
+                'Name must start with a letter or number. Got `{}`').format(value)
+
+        if not re.match(r'^[a-zA-Z0-9]{1}[a-zA-Z0-9\-\_\.]+$', value):
+            raise colander.Invalid(node, msg)
+
+    return name_validator
+
+
[e-mail]
+def deferred_user_group_owner_validator(node, kw):
+
+    def owner_validator(node, value):
+        from rhodecode.model.db import User
+        existing = User.get_by_username(value)
+        if not existing:
+            msg = _(u'User group owner with id `{}` does not exists').format(value)
+            raise colander.Invalid(node, msg)
+
+    return owner_validator
+
+
+class UserGroupSchema(colander.Schema):
+
+    user_group_name = colander.SchemaNode(
+        colander.String(),
+        validator=deferred_user_group_name_validator)
+
+    user_group_description = colander.SchemaNode(
+        colander.String(), missing='')
+
+    user_group_owner = colander.SchemaNode(
+        colander.String(),
+        validator=deferred_user_group_owner_validator)
+
+    user_group_active = colander.SchemaNode(
+        types.StringBooleanType(),
+        missing=False)
+
+    def deserialize(self, cstruct):
+        """
+        Custom deserialize that allows to chain validation, and verify
+        permissions, and as last step uniqueness
+        """
+
+        appstruct = super(UserGroupSchema, self).deserialize(cstruct)
+        return appstruct

rhodecode/model/validation_schema/utils.py

@@ -0,0 +1,49 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
+import deform.widget
+
+
+def convert_to_optgroup(items):
+    """
+    Convert such format::
+
+        [
+            ['rev:tip', u'latest tip'], 
+            ([(u'branch:default', u'default')], u'Branches'), 
+        ]
+
+    into one used by deform Select widget::
+
+        (
+            ('rev:tip', 'latest tip'),
+            OptGroup('Branches',
+                    ('branch:default', 'default'),
+        )
+    """
+    result = []
+    for value, label in items:
+        # option group
+        if isinstance(value, (tuple, list)):
+            result.append(deform.widget.OptGroup(label, *value))
+        else:
+            result.append((value, label))
+
+    return result

rhodecode/public/css/readme-box.less

@@ -0,0 +1,252 b''
+/** README styling **/
+div.readme_box {
+    clear: both;
+    overflow: hidden;
+    margin: 0;
+    padding: 3px 15px 3px;
+}
+
+div.readme_box h1,
+div.readme_box h2,
+div.readme_box h3,
+div.readme_box h4,
+div.readme_box h5,
+div.readme_box h6 {
+    border-bottom: none !important;
+    padding: 0 !important;
+    overflow: visible !important;
+}
+
+div.readme_box h1 {
+    font-size: 32px;
+    margin: 15px 0 15px 0 !important;
+    padding-bottom: 5px !important;
+}
+
+div.readme_box h2 {
+    font-size: 24px !important;
+    margin: 34px 0 10px 0 !important;
+    border-top: 3px #e6e5e5 solid !important;
+    padding-top: 15px !important;
+    padding-bottom: 8px !important;
+}
+
+div.readme_box h3 {
+    font-size: 18px !important;
+    margin: 30px 0 8px 0 !important;
+    padding-bottom: 2px !important;
+}
+
+div.readme_box h4 {
+    font-size: 13px !important;
+    margin: 18px 0 3px 0 !important;
+}
+
+div.readme_box h5 {
+    font-size: 12px !important;
+    margin: 15px 0 3px 0 !important;
+}
+
+div.readme_box h6 {
+    font-size: 12px;
+    color: #777777;
+    margin: 15px 0 3px 0 !important;
+}
+
+div.readme_box hr {
+    border: 0;
+    color: #e6e5e5;
+    background-color: #e6e5e5;
+    height: 3px;
+    margin-bottom: 13px;
+}
+
+div.readme_box ol,
+div.readme_box ul,
+div.readme_box p,
+div.readme_box blockquote,
+div.readme_box dl,
+div.readme_box li,
+div.readme_box table {
+    margin: 3px 0px 13px 0px !important;
+    color: #424242 !important;
+    font-size: 13px !important;
+    font-family: "Helvetica" !important;
+    font-weight: normal  !important;
+    overflow: visible !important;
+    line-height: 140% !important;
+}
+
+div.readme_box pre {
+  margin: 3px 0px 13px 0px !important;
+  padding: .5em;
+  color: #424242 !important;
+  font-size: 13px !important;
+  overflow: visible !important;
+  line-height: 140% !important;
+  background-color: @grey7;
+}
+
+div.readme_box img {
+  border-style: none;
+  background-color: #fff;
+}
+
+
+div.readme_box strong {
+  font-weight: 600;
+  margin: 0;
+}
+
+div.readme_box ul,
+div.readme_box ol {
+    padding-left: 30px !important;
+    margin-top: 0px !important;
+    margin-bottom: 18px !important;
+}
+
+div.readme_box ul li,
+div.readme_box ol li {
+    list-style: bullet !important;
+    margin: 6px !important;
+    padding: 0 !important;
+}
+
+div.readme_box ol li {
+    list-style: decimal !important;
+}
+
+/*
+div.readme_box a,
+div.readme_box a:visited {
+    color: #4183C4 !important;
+    background-color: inherit;
+    text-decoration: none;
+}
+*/
+
+
+div.readme_box button {
+    font-size: @basefontsize;
+    padding: 4px 6px;
+    .border-radius(@border-radius);
+    border: @border-thickness solid @grey5;
+    background-color: @grey6;
+}
+
+div.readme_box code,
+div.readme_box pre {
+    font-family: Monaco;
+    font-size: 11px;
+    .border-radius(@border-radius);
+    background-color: white;
+    color: @grey3;
+}
+
+
+div.readme_box code {
+    border: @border-thickness solid @grey6;
+    margin: 0 2px;
+    padding: 0 5px;
+}
+
+div.readme_box pre {
+    border: @border-thickness solid @grey5;
+    overflow: auto;
+    padding: .5em;
+    background-color: @grey7;
+}
+
+div.readme_box pre > code {
+    border: 0;
+    margin: 0;
+    padding: 0;
+}
+
+/** RST STYLE **/
+div.rst-block {
+    clear: both;
+    overflow: hidden;
+    margin: 0;
+    padding: 3px 15px 3px;
+}
+
+div.rst-block h2 {
+    font-weight: normal;
+}
+
+div.rst-block  h1,
+div.rst-block  h2,
+div.rst-block  h3,
+div.rst-block  h4,
+div.rst-block  h5,
+div.rst-block  h6 {
+    border-bottom: 0 !important;
+    margin: 0 !important;
+    padding: 0 !important;
+    line-height: 1.5em !important;
+}
+
+
+div.rst-block  h1:first-child {
+    padding-top: .25em !important;
+}
+
+div.rst-block  h2,
+div.rst-block  h3 {
+    margin: 1em 0 !important;
+}
+
+div.rst-block  h2 {
+    margin-top: 1.5em !important;
+    border-top: 4px solid #e0e0e0 !important;
+    padding-top: .5em !important;
+}
+
+div.rst-block  p {
+    color: black !important;
+    margin: 1em 0 !important;
+    line-height: 1.5em !important;
+}
+
+div.rst-block  ul {
+    list-style: disc !important;
+    margin: 1em 0 1em 2em !important;
+    clear: both;
+}
+
+div.rst-block  ol {
+    list-style: decimal;
+    margin: 1em 0 1em 2em !important;
+}
+
+div.rst-block pre,
+div.rst-block code {
+    font: 12px "Bitstream Vera Sans Mono","Courier",monospace;
+}
+
+div.rst-block code {
+    font-size: 12px !important;
+    background-color: ghostWhite !important;
+    color: #444 !important;
+    padding: 0 .2em !important;
+    border: 1px solid #dedede !important;
+}
+
+div.rst-block pre code {
+    padding: 0 !important;
+    font-size: 12px !important;
+    background-color: #eee !important;
+    border: none !important;
+}
+
+div.rst-block pre {
+    margin: 1em 0;
+    padding: @padding;
+    border: 1px solid @grey6;
+    .border-radius(@border-radius);
+    overflow: auto;
+    font-size: 12px;
+    color: #444;
+    background-color: @grey7;
+}
  No newline at end of file

rhodecode/templates/admin/admin_log_base.mako

@@ -0,0 +1,65 b''
+<%namespace name="base" file="/base/base.mako"/>
+
+%if c.audit_logs:
+<table class="rctable admin_log">
+    <tr>
+        <th>${_('Username')}</th>
+        <th>${_('Action')}</th>
+        <th>${_('Action Data')}</th>
+        <th>${_('Repository')}</th>
+        <th>${_('Date')}</th>
+        <th>${_('IP')}</th>
+    </tr>
+
+    %for cnt,l in enumerate(c.audit_logs):
+    <tr class="parity${cnt%2}">
+        <td class="td-user">
+            %if l.user is not None:
+              ${base.gravatar_with_user(l.user.email)}
+            %else:
+              ${l.username}
+            %endif
+        </td>
+        <td class="td-journalaction">
+            % if l.version == l.VERSION_1:
+                ${h.action_parser(l)[0]()}
+            % else:
+                ${h.literal(l.action)}
+            % endif
+
+            <div class="journal_action_params">
+                % if l.version == l.VERSION_1:
+                    ${h.literal(h.action_parser(l)[1]())}
+                % endif
+            </div>
+        </td>
+        <td>
+            % if l.version == l.VERSION_2:
+                <a href="#" onclick="$('#entry-'+${l.user_log_id}).toggle();return false">${_('toggle')}</a>
+                <div id="entry-${l.user_log_id}" style="display: none">
+                    <pre>${h.json.dumps(l.action_data, indent=4, sort_keys=True)}</pre>
+                </div>
+            % else:
+                <pre title="${_('data not available for v1 entries type')}">-</pre>
+            % endif
+        </td>
+        <td class="td-componentname">
+            %if l.repository is not None:
+              ${h.link_to(l.repository.repo_name, h.route_path('repo_summary',repo_name=l.repository.repo_name))}
+            %else:
+              ${l.repository_name}
+            %endif
+        </td>
+
+        <td class="td-time">${h.format_date(l.action_date)}</td>
+        <td class="td-ip">${l.user_ip}</td>
+    </tr>
+    %endfor
+</table>
+
+<div class="pagination-wh pagination-left">
+${c.audit_logs.pager('$link_previous ~2~ $link_next')}
+</div>
+%else:
+    ${_('No actions yet')}
+%endif
  No newline at end of file

rhodecode/templates/admin/repos/repo_edit_reviewers.mako

@@ -0,0 +1,9 b''
+<div class="panel panel-default">
+    <div class="panel-heading">
+        <h3 class="panel-title">${_('Default Reviewer Rules')}</h3>
+    </div>
+    <div class="panel-body">
+        <h4>${_('This feature is available in RhodeCode EE edition only. Contact {sales_email} to obtain a trial license.').format(sales_email='<a href="mailto:[e-mail]">[e-mail]</a>')|n}</h4>
+        <img style="width: 100%; height: 100%" src="${h.asset('images/ee_features/default_reviewers.png')}"/>
+    </div>
+</div>

rhodecode/templates/summary/summary_commits.mako

@@ -0,0 +1,136 b''
+## -*- coding: utf-8 -*-
+<%namespace name="base" file="/base/base.mako"/>
+%if c.repo_commits:
+<table class="rctable repo_summary table_disp">
+    <tr>
+
+        <th class="status" colspan="2"></th>
+        <th>${_('Commit')}</th>
+        <th>${_('Commit message')}</th>
+        <th>${_('Age')}</th>
+        <th>${_('Author')}</th>
+        <th>${_('Refs')}</th>
+    </tr>
+%for cnt,cs in enumerate(c.repo_commits):
+    <tr class="parity${cnt%2}">
+
+        <td class="td-status">
+            %if c.statuses.get(cs.raw_id):
+                <div class="changeset-status-ico shortlog">
+                    %if c.statuses.get(cs.raw_id)[2]:
+                    <a class="tooltip" title="${_('Commit status: %s\nClick to open associated pull request #%s') % (c.statuses.get(cs.raw_id)[0], c.statuses.get(cs.raw_id)[2])}" href="${h.route_path('pullrequest_show',repo_name=c.statuses.get(cs.raw_id)[3],pull_request_id=c.statuses.get(cs.raw_id)[2])}">
+                        <div class="${'flag_status %s' % c.statuses.get(cs.raw_id)[0]}"></div>
+                    </a>
+                    %else:
+                    <a class="tooltip" title="${_('Commit status: %s') % h.commit_status_lbl(c.statuses.get(cs.raw_id)[0])}" href="${h.url('changeset_home',repo_name=c.repo_name,revision=cs.raw_id,anchor='comment-%s' % c.comments[cs.raw_id][0].comment_id)}">
+                        <div class="${'flag_status %s' % c.statuses.get(cs.raw_id)[0]}"></div>
+                    </a>
+                    %endif
+                </div>
+            %else:
+                <div class="tooltip flag_status not_reviewed" title="${_('Commit status: Not Reviewed')}"></div>
+            %endif
+        </td>
+        <td class="td-comments">
+            %if c.comments.get(cs.raw_id,[]):
+            <a title="${_('Commit has comments')}" href="${h.url('changeset_home',repo_name=c.repo_name,revision=cs.raw_id,anchor='comment-%s' % c.comments[cs.raw_id][0].comment_id)}">
+                <i class="icon-comment"></i> ${len(c.comments[cs.raw_id])}
+            </a>
+            %endif
+        </td>
+        <td class="td-commit">
+            <pre><a href="${h.url('changeset_home', repo_name=c.repo_name, revision=cs.raw_id)}">${h.show_id(cs)}</a></pre>
+        </td>
+
+        <td class="td-description mid">
+          <div class="log-container truncate-wrap">
+              <div class="message truncate" id="c-${cs.raw_id}">${h.urlify_commit_message(cs.message, c.repo_name)}</div>
+          </div>
+        </td>
+
+        <td class="td-time">
+            ${h.age_component(cs.date)}
+        </td>
+        <td class="td-user author">
+            ${base.gravatar_with_user(cs.author)}
+        </td>
+
+        <td class="td-tags">
+          <div class="autoexpand">
+            %if h.is_hg(c.rhodecode_repo):
+                %for book in cs.bookmarks:
+                     <span class="booktag tag" title="${h.tooltip(_('Bookmark %s') % book)}">
+                     <a href="${h.url('files_home',repo_name=c.repo_name,revision=cs.raw_id)}"><i class="icon-bookmark"></i>${h.shorter(book)}</a>
+                     </span>
+                %endfor
+            %endif
+            ## tags
+            %for tag in cs.tags:
+             <span class="tagtag tag" title="${h.tooltip(_('Tag %s') % tag)}">
+             <a href="${h.url('files_home',repo_name=c.repo_name,revision=cs.raw_id)}"><i class="icon-tag"></i>${h.shorter(tag)}</a>
+             </span>
+            %endfor
+
+            ## branch
+            %if cs.branch:
+             <span class="branchtag tag" title="${h.tooltip(_('Branch %s') % cs.branch)}">
+              <a href="${h.url('changelog_home',repo_name=c.repo_name,branch=cs.branch)}"><i class="icon-code-fork"></i>${h.shorter(cs.branch)}</a>
+             </span>
+            %endif
+          </div>
+        </td>
+    </tr>
+%endfor
+
+</table>
+
+<script type="text/javascript">
+  $(document).pjax('#shortlog_data .pager_link','#shortlog_data', {timeout: 2000, scrollTo: false });
+  $(document).on('pjax:success', function(){ timeagoActivate(); });
+</script>
+
+<div class="pagination-wh pagination-left">
+${c.repo_commits.pager('$link_previous ~2~ $link_next')}
+</div>
+%else:
+
+%if h.HasRepoPermissionAny('repository.write','repository.admin')(c.repo_name):
+<div class="quick_start">
+  <div class="fieldset">
+    <div class="left-label">${_('Add or upload files directly via RhodeCode:')}</div>
+    <div class="right-content">
+      <div id="add_node_id" class="add_node">
+          <a href="${h.url('files_add_home',repo_name=c.repo_name,revision=0,f_path='', anchor='edit')}" class="btn btn-default">${_('Add New File')}</a>
+      </div>
+    </div>
+    %endif
+  </div>
+
+  %if not h.is_svn(c.rhodecode_repo):
+  <div class="fieldset">
+    <div class="left-label">${_('Push new repo:')}</div>
+    <div class="right-content">
+      <pre>
+${c.rhodecode_repo.alias} clone ${c.clone_repo_url}
+${c.rhodecode_repo.alias} add README # add first file
+${c.rhodecode_repo.alias} commit -m "Initial" # commit with message
+${c.rhodecode_repo.alias} push ${'origin master' if h.is_git(c.rhodecode_repo) else ''} # push changes back
+      </pre>
+    </div>
+  </div>
+  <div class="fieldset">
+    <div class="left-label">${_('Existing repository?')}</div>
+    <div class="right-content">
+      <pre>
+      %if h.is_git(c.rhodecode_repo):
+git remote add origin ${c.clone_repo_url}
+git push -u origin master
+      %else:
+hg push ${c.clone_repo_url}
+      %endif
+      </pre>
+    </div>
+  </div>
+  %endif
+</div>
+%endif

.bumpversion.cfg

@@ -1,5 +1,5 b''
 [bumpversion]
-current_version = 4.7.2
+current_version = 4.8.0
 message = release: Bump version {current_version} to {new_version}
 
 [bumpversion:file:rhodecode/VERSION]

.release.cfg

@@ -5,25 +5,20 b' done = false'
 done = true
 
 [task:rc_tools_pinned]
-done = true
 
 [task:fixes_on_stable]
-done = true
 
 [task:pip2nix_generated]
-done = true
 
 [task:changelog_updated]
-done = true
 
 [task:generate_api_docs]
-done = true
+
+[task:updated_translation]
 
 [release]
-state = prepared
-version = 4.7.2
-
-[task:updated_translation]
+state = in_progress
+version = 4.8.0
 
 [task:generate_js_routes]
 

MANIFEST.in

@@ -33,6 +33,7 b' include rhodecode/public/502.html'
 # images, css
 include rhodecode/public/css/*.css
 include rhodecode/public/images/*.*
+include rhodecode/public/images/ee_features/*.*
 
 # sound files
 include rhodecode/public/sounds/*.mp3

default.nix

@@ -174,32 +174,33 b' let'
       '';
 
       postInstall = ''
+        echo "Writing meta information for rccontrol to nix-support/rccontrol"
+        mkdir -p $out/nix-support/rccontrol
+        cp -v rhodecode/VERSION $out/nix-support/rccontrol/version
+        echo "DONE: Meta information for rccontrol written"
+
         # python based programs need to be wrapped
+        ln -s ${self.pyramid}/bin/* $out/bin/
+        ln -s ${self.gunicorn}/bin/gunicorn $out/bin/
         ln -s ${self.supervisor}/bin/supervisor* $out/bin/
-        ln -s ${self.gunicorn}/bin/gunicorn $out/bin/
         ln -s ${self.PasteScript}/bin/paster $out/bin/
         ln -s ${self.channelstream}/bin/channelstream $out/bin/
-        ln -s ${self.pyramid}/bin/* $out/bin/  #*/
 
         # rhodecode-tools
-        # TODO: johbo: re-think this. Do the tools import anything from enterprise?
         ln -s ${self.rhodecode-tools}/bin/rhodecode-* $out/bin/
 
         # note that condition should be restricted when adding further tools
-        for file in $out/bin/*; do  #*/
+        for file in $out/bin/*;
+        do
           wrapProgram $file \
+              --prefix PATH : $PATH \
               --prefix PYTHONPATH : $PYTHONPATH \
-              --prefix PATH : $PATH \
               --set PYTHONHASHSEED random
         done
 
         mkdir $out/etc
         cp configs/production.ini $out/etc
 
-        echo "Writing meta information for rccontrol to nix-support/rccontrol"
-        mkdir -p $out/nix-support/rccontrol
-        cp -v rhodecode/VERSION $out/nix-support/rccontrol/version
-        echo "DONE: Meta information for rccontrol written"
 
         # TODO: johbo: Make part of ac-tests
         if [ ! -f rhodecode/public/js/scripts.js ]; then

docs/admin/apache-conf-example.rst

@@ -62,6 +62,9 b' Below config if for an Apache Reverse Pr'
         ProxyPass / http://127.0.0.1:10002/ timeout=7200 Keepalive=On
         ProxyPassReverse / http://127.0.0.1:10002/
 
+        # Increase headers for large Mercurial headers
+        LimitRequestLine 16380
+
         # strict http prevents from https -> http downgrade
         Header always set Strict-Transport-Security "max-age=63072000; includeSubdomains; preload"
 

docs/admin/nginx-config-example.rst

@@ -5,7 +5,10 b' Use the following example to configure N'
 
 
 .. code-block:: nginx
+    ## rate limiter for certain pages to prevent brute force attacks
+    limit_req_zone  $binary_remote_addr  zone=dl_limit:10m   rate=1r/s;
 
+    ## custom log format
     log_format log_custom '$remote_addr - $remote_user [$time_local] '
                           '"$request" $status $body_bytes_sent '
                           '"$http_referer" "$http_user_agent" '
@@ -109,6 +112,12 b' Use the following example to configure N'
             proxy_set_header Connection  "upgrade";
         }
 
+        location /_admin/login {
+            ## rate limit this endpoint
+            limit_req  zone=dl_limit  burst=10  nodelay;
+            try_files $uri @rhode;
+        }
+
         location / {
             try_files $uri @rhode;
         }

docs/admin/repo-extra-fields.rst

@@ -3,8 +3,12 b''
 Repository Extra Fields
 =======================
 
-Extra fields attached to a |repo| allow you to configure additional actions for
-|RCX|. To install and read more about |RCX|, see the :ref:`install-rcx` section.
+Extra fields attached to a |repo| allow you to configure additional fields for
+each repository. This allows storing custom data per-repository.
+
+It can be used in :ref:`integrations-webhook` or in |RCX|.
+To install and read more about |RCX|, see the :ref:`install-rcx` section.
+
 
 Enabling Extra Fields
 ---------------------
@@ -27,9 +31,14 b' 2. On the |repo| settings page, select t'
 
 .. image:: ../images/extra-repo-fields.png
 
+The most important is the `New field key` variable which under the value will
+be stored. It needs to be unique for each repository. The label and description
+will be generated in repository settings where users can actually save some
+values inside generated extra fields.
 
-Example Usage
--------------
+
+Example Usage in extensions
+---------------------------
 
 To use the extra fields in an extension, see the example below. For more
 information and examples, see the :ref:`extensions-hooks-ref` section.

docs/admin/vcs-server.rst

@@ -7,7 +7,7 b' The VCS Server handles |RCM| backend fun'
 a VCS Server to run with a |RCM| instance. If you do not, you will be missing
 the connection between |RCM| and its |repos|. This will cause error messages
 on the web interface. You can run your setup in the following configurations,
-currently the best performance is one VCS Server per |RCM| instance:
+currently the best performance is one of following:
 
 * One VCS Server per |RCM| instance.
 * One VCS Server handling multiple instances.
@@ -59,7 +59,8 b' instance in the'
     \vcs.backends <available-vcs-systems>
         Set a comma-separated list of the |repo| options available from the
         web interface. The default is ``hg, git, svn``,
-        which is all |repo| types available.
+        which is all |repo| types available. The order of backends is also the
+        order backend will try to detect requests type.
 
     \vcs.connection_timeout <seconds>
         Set the length of time in seconds that the VCS Server waits for
@@ -159,9 +160,10 b' for full details see the :ref:`RhodeCode'
 
     - NAME: vcsserver-1
     - STATUS: RUNNING
-    - TYPE: VCSServer
-    - VERSION: 1.0.0
-    - URL: http://127.0.0.1:10001
+      logs:/home/ubuntu/.rccontrol/vcsserver-1/vcsserver.log
+    - VERSION: 4.7.2 VCSServer
+    - URL: http://127.0.0.1:10008
+    - CONFIG: /home/ubuntu/.rccontrol/vcsserver-1/vcsserver.ini
 
     $ rccontrol restart vcsserver-1
     Instance "vcsserver-1" successfully stopped.
@@ -181,7 +183,9 b' For a more detailed explanation of the l'
 .. rst-class:: dl-horizontal
 
     \host <ip-address>
-        Set the host on which the VCS Server will run.
+        Set the host on which the VCS Server will run. VCSServer is not
+        protected by any authentication, so we *highly* recommend running it
+        under localhost ip that is `127.0.0.1`
 
     \port <int>
         Set the port number on which the VCS Server will be available.
@@ -189,13 +193,22 b' For a more detailed explanation of the l'
     \locale <locale_utf>
         Set the locale the VCS Server expects.
 
-    \threadpool_size <int>
-        Set the size of the threadpool used to communicate
-        with the WSGI workers. This should be at least 6 times the number of
-        WSGI worker processes.
+    \workers <int>
+        Set the number of process workers.Recommended
+        value is (2 * NUMBER_OF_CPUS + 1), eg 2CPU = 5 workers
 
-    \timeout <seconds>
-        Set the timeout for RPC communication in seconds.
+    \max_requests <int>
+        The maximum number of requests a worker will process before restarting.
+        Any value greater than zero will limit the number of requests a work
+        will process before automatically restarting. This is a simple method
+        to help limit the damage of memory leaks.
+
+    \max_requests_jitter <int>
+        The maximum jitter to add to the max_requests setting.
+        The jitter causes the restart per worker to be randomized by
+        randint(0, max_requests_jitter). This is intended to stagger worker
+        restarts to avoid all workers restarting at the same time.
+
 
 .. note::
 
@@ -204,27 +217,54 b' For a more detailed explanation of the l'
 .. code-block:: ini
 
     ################################################################################
-    # RhodeCode VCSServer - configuration                                          #
+    # RhodeCode VCSServer with HTTP Backend - configuration                        #
     #                                                                              #
     ################################################################################
 
-    [DEFAULT]
+
+    [server:main]
+    ## COMMON ##
     host = 127.0.0.1
-    port = 9900
+    port = 10002
+
+    ##########################
+    ## GUNICORN WSGI SERVER ##
+    ##########################
+    ## run with gunicorn --log-config vcsserver.ini --paste vcsserver.ini
+    use = egg:gunicorn#main
+    ## Sets the number of process workers. Recommended
+    ## value is (2 * NUMBER_OF_CPUS + 1), eg 2CPU = 5 workers
+    workers = 3
+    ## process name
+    proc_name = rhodecode_vcsserver
+    ## type of worker class, one of sync, gevent
+    ## recommended for bigger setup is using of of other than sync one
+    worker_class = sync
+    ## The maximum number of simultaneous clients. Valid only for Gevent
+    #worker_connections = 10
+    ## max number of requests that worker will handle before being gracefully
+    ## restarted, could prevent memory leaks
+    max_requests = 1000
+    max_requests_jitter = 30
+    ## amount of time a worker can spend with handling a request before it
+    ## gets killed and restarted. Set to 6hrs
+    timeout = 21600
+
+    [app:main]
+    use = egg:rhodecode-vcsserver
+
+    pyramid.default_locale_name = en
+    pyramid.includes =
+
+    ## default locale used by VCS systems
     locale = en_US.UTF-8
-    # number of worker threads, this should be set based on a formula threadpool=N*6
-    # where N is number of RhodeCode Enterprise workers, eg. running 2 instances
-    # 8 gunicorn workers each would be 2 * 8 * 6 = 96, threadpool_size = 96
-    threadpool_size = 16
-    timeout = 0
 
     # cache regions, please don't change
     beaker.cache.regions = repo_object
     beaker.cache.repo_object.type = memorylru
-    beaker.cache.repo_object.max_items = 1000
-
+    beaker.cache.repo_object.max_items = 100
     # cache auto-expires after N seconds
-    beaker.cache.repo_object.expire = 10
+    beaker.cache.repo_object.expire = 300
     beaker.cache.repo_object.enabled = true
 
 
@@ -270,20 +310,6 b' For a more detailed explanation of the l'
     level = DEBUG
     formatter = generic
 
-    [handler_file]
-    class = FileHandler
-    args = ('vcsserver.log', 'a',)
-    level = DEBUG
-    formatter = generic
-
-    [handler_file_rotating]
-    class = logging.handlers.TimedRotatingFileHandler
-    # 'D', 5 - rotate every 5days
-    # you can set 'h', 'midnight'
-    args = ('vcsserver.log', 'D', 5, 10,)
-    level = DEBUG
-    formatter = generic
-
     ################
     ## FORMATTERS ##
     ################

docs/api/methods/pull-request-methods.rst

@@ -6,7 +6,7 b' pull_request methods'
 close_pull_request 
 ------------------
 
-.. py:function:: close_pull_request(apiuser, repoid, pullrequestid, userid=<Optional:<OptionalAttr:apiuser>>)
+.. py:function:: close_pull_request(apiuser, repoid, pullrequestid, userid=<Optional:<OptionalAttr:apiuser>>, message=<Optional:''>)
 
    Close the pull request specified by `pullrequestid`.
 
@@ -19,6 +19,9 b' close_pull_request'
    :type pullrequestid: int
    :param userid: Close the pull request as this user.
    :type userid: Optional(str or int)
+   :param message: Optional message to close the Pull Request with. If not
+       specified it will be generated automatically.
+   :type message: Optional(str)
 
    Example output:
 
@@ -27,6 +30,7 b' close_pull_request'
        "id": <id_given_in_input>,
        "result": {
            "pull_request_id":  "<int>",
+           "close_status":     "<str:status_lbl>,
            "closed":           "<bool>"
        },
        "error": null
@@ -105,10 +109,12 b' create_pull_request'
    :param description: Set the pull request description.
    :type description: Optional(str)
    :param reviewers: Set the new pull request reviewers list.
+       Reviewer defined by review rules will be added automatically to the
+       defined list.
    :type reviewers: Optional(list)
        Accepts username strings or objects of the format:
 
-           {'username': 'nick', 'reasons': ['original author']}
+           [{'username': 'nick', 'reasons': ['original author'], 'mandatory': <bool>}]
 
 
 get_pull_request 
@@ -320,7 +326,7 b' merge_pull_request'
 update_pull_request 
 -------------------
 
-.. py:function:: update_pull_request(apiuser, repoid, pullrequestid, title=<Optional:''>, description=<Optional:''>, reviewers=<Optional:None>, update_commits=<Optional:None>, close_pull_request=<Optional:None>)
+.. py:function:: update_pull_request(apiuser, repoid, pullrequestid, title=<Optional:''>, description=<Optional:''>, reviewers=<Optional:None>, update_commits=<Optional:None>)
 
    Updates a pull request.
 
@@ -336,10 +342,12 b' update_pull_request'
    :type description: Optional(str)
    :param reviewers: Update pull request reviewers list with new value.
    :type reviewers: Optional(list)
+       Accepts username strings or objects of the format:
+
+           [{'username': 'nick', 'reasons': ['original author'], 'mandatory': <bool>}]
+
    :param update_commits: Trigger update of commits for this pull request
    :type: update_commits: Optional(bool)
-   :param close_pull_request: Close this pull request with rejected state
-   :type: close_pull_request: Optional(bool)
 
    Example output:
 

docs/api/methods/repo-methods.rst

@@ -527,6 +527,7 b' get_repo_settings'
            "id": 237,
            "result": {
                "extensions_largefiles": true,
+               "extensions_evolve": true,
                "hooks_changegroup_push_logger": true,
                "hooks_changegroup_repo_size": false,
                "hooks_outgoing_pull_logger": true,
@@ -762,6 +763,49 b' lock'
      }
 
 
+maintenance 
+-----------
+
+.. py:function:: maintenance(apiuser, repoid)
+
+   Triggers a maintenance on the given repository.
+
+   This command can only be run using an |authtoken| with admin
+   rights to the specified repository. For more information,
+   see :ref:`config-token-ref`.
+
+   This command takes the following options:
+
+   :param apiuser: This is filled automatically from the |authtoken|.
+   :type apiuser: AuthUser
+   :param repoid: The repository name or repository ID.
+   :type repoid: str or int
+
+   Example output:
+
+   .. code-block:: bash
+
+     id : <id_given_in_input>
+     result : {
+       "msg": "executed maintenance command",
+       "executed_actions": [
+          <action_message>, <action_message2>...
+       ],
+       "repository": "<repository name>"
+     }
+     error :  null
+
+   Example error output:
+
+   .. code-block:: bash
+
+     id : <id_given_in_input>
+     result : null
+     error :  {
+       "Unable to execute maintenance on `<reponame>`"
+     }
+
+
 pull 
 ----
 

docs/contributing/dev-setup.rst

@@ -66,7 +66,7 b' RhodeCode VCSServer repositories into th'
 RhodeCode currently is using Mercurial Version Control System, please make sure
 you have it installed before continuing.
 
-To obtain the required sources, use the following commands:
+To obtain the required sources, use the following commands::
 
     mkdir rhodecode-develop && cd rhodecode-develop
     hg clone https://code.rhodecode.com/rhodecode-enterprise-ce
@@ -80,9 +80,9 b' To obtain the required sources, use the '
 Install some required libraries
 -------------------------------
 
-There are some required drivers that we need to install to test RhodeCode
-under different types of databases. For example in Ubuntu we need to install
-the following.
+There are some required drivers and dev libraries that we need to install to
+test RhodeCode under different types of databases. For example in Ubuntu we
+need to install the following.
 
 required libraries::
 

docs/index.rst

@@ -20,7 +20,7 b' and commit files and |repos| while manag'
 * Migration from existing databases.
 * |RCM| SDK.
 * Built-in analytics
-* Built in integrations including: Slack, Jenkins, Webhooks, Jira, Redmine, Hipchat
+* Built in integrations including: Slack, Webhooks (used for Jenkins/TeamCity and other CIs), Jira, Redmine, Hipchat
 * Pluggable authentication system.
 * Support for AD, |LDAP|, Crowd, CAS, PAM.
 * Support for external authentication via Oauth Google, Github, Bitbucket, Twitter.

docs/integrations/integrations.rst

@@ -17,7 +17,8 b' Type/Name |RC| Edi'
 :ref:`integrations-slack`       |RCCEshort|     https://slack.com/
 :ref:`integrations-hipchat`     |RCCEshort|     https://www.hipchat.com/
 :ref:`integrations-webhook`     |RCCEshort|     POST events as `json` to a custom url
-:ref:`integrations-email`       |RCEEshort|     Send repo push commits by email
+:ref:`integrations-ci`          |RCCEshort|     Trigger Builds for Common CI Systems
+:ref:`integrations-email`       |RCCEshort|     Send repo push commits by email
 :ref:`integrations-redmine`     |RCEEshort|     Close/Resolve/Reference redmine issues
 :ref:`integrations-jira`        |RCEEshort|     Close/Resolve/Reference JIRA issues
 ============================    ============    =====================================

docs/integrations/webhook.rst

@@ -3,9 +3,9 b''
 Webhook integration
 ===================
 
-The Webhook integration allows you to POST events such as repository pushes
-or pull requests to a custom http endpoint as a json dict with details of the
-event.
+The :ref:`creating-integrations` integration allows you to POST events such as
+repository pushes or pull requests to a custom http endpoint as a JSON dict
+with details of the event.
 
 Starting from 4.5.0 release, webhook integration allows to use variables
 inside the URL. For example in URL `https://server-example.com/${repo_name}`
@@ -14,8 +14,10 b' triggered from. Some of the variables li'
 `${branch}` will result in webhook be called multiple times when multiple
 branches are pushed.
 
-Some of the variables like `${pull_request_id}` will be replaced only in
-the pull request related events.
+Starting from 4.8.0 also repository extra fields can be used. A format to use
+them is `${extra:field_key}`. It's usefull to use them to specify custom
+repo only parameters. Some of the variables like `${pull_request_id}`
+will be replaced only in the pull request related events.
 
 To create a webhook integration, select "webhook" in the integration settings
 and use the URL and key from your any previous custom webhook created. See

docs/release-notes/release-notes.rst

@@ -9,6 +9,7 b' Release Notes'
 .. toctree::
    :maxdepth: 1
 
+   release-notes-4.8.0.rst
    release-notes-4.7.2.rst
    release-notes-4.7.1.rst
    release-notes-4.7.0.rst

docs/usage/basic-vcs-commands.rst

@@ -3,8 +3,13 b''
 Getting Started with VCS
 ------------------------
 
-When using |RCM|, you will be working with |git| or |hg| |repos| from the
-command line.
+When using |RCM|, you will be working with |git|, |svn| or |hg| |repos| from the
+command line or using a GUI client such as Tortoise, Tower or SourceTree.
+
+|RCM| uses a standard |git|, |svn| and |hg| protocols. So all tools that
+can interact with there protocols are supported, including Eclipse or PyCharm
+plugins.
+
 
 If you have never used either before, the following information should
 help you set up your local machine so that you can sync changes with the

pkgs/bower-packages.nix

@@ -7,7 +7,7 b' buildEnv { name = "bower-env"; ignoreCol'
   (fetchbower "paper-tooltip" "PolymerElements/paper-tooltip#1.1.3" "PolymerElements/paper-tooltip#^1.1.2" "0vmrm1n8k9sk9nvqy03q177axy22pia6i3j1gxbk72j3pqiqvg6k")
   (fetchbower "paper-toast" "PolymerElements/paper-toast#1.3.0" "PolymerElements/paper-toast#^1.3.0" "0x9rqxsks5455s8pk4aikpp99ijdn6kxr9gvhwh99nbcqdzcxq1m")
   (fetchbower "paper-toggle-button" "PolymerElements/paper-toggle-button#1.2.0" "PolymerElements/paper-toggle-button#^1.2.0" "0mphcng3ngspbpg4jjn0mb91nvr4xc1phq3qswib15h6sfww1b2w")
-  (fetchbower "iron-ajax" "PolymerElements/iron-ajax#1.4.3" "PolymerElements/iron-ajax#^1.4.3" "0m3dx27arwmlcp00b7n516sc5a51f40p9vapr1nvd57l3i3z0pzm")
+  (fetchbower "iron-ajax" "PolymerElements/iron-ajax#1.4.3" "PolymerElements/iron-ajax#^1.4.3" "1b1z3112ggjdflgrwbpmnbsh3kgcm4hn255wshvrlzds4w069gja")
   (fetchbower "iron-autogrow-textarea" "PolymerElements/iron-autogrow-textarea#1.0.13" "PolymerElements/iron-autogrow-textarea#^1.0.13" "0zwhpl97vii1s8k0lgain8i9dnw29b0mxc5ixdscx9las13n2lqq")
   (fetchbower "iron-a11y-keys" "PolymerElements/iron-a11y-keys#1.0.6" "PolymerElements/iron-a11y-keys#^1.0.6" "1xz3mgghfcxixq28sdb654iaxj4nyi1bzcwf77ydkms6fviqs9mv")
   (fetchbower "iron-flex-layout" "PolymerElements/iron-flex-layout#1.3.1" "PolymerElements/iron-flex-layout#^1.0.0" "0nswv3ih3bhflgcd2wjfmddqswzgqxb2xbq65jk9w3rkj26hplbl")

pkgs/python-packages.nix

@@ -601,13 +601,13 b''
     };
   };
   deform = super.buildPythonPackage {
-    name = "deform-2.0a2";
+    name = "deform-2.0.4";
     buildInputs = with self; [];
     doCheck = false;
-    propagatedBuildInputs = with self; [Chameleon colander peppercorn translationstring zope.deprecation];
+    propagatedBuildInputs = with self; [Chameleon colander iso8601 peppercorn translationstring zope.deprecation];
     src = fetchurl {
-      url = "https://pypi.python.org/packages/8d/b3/aab57e81da974a806dc9c5fa024a6404720f890a6dcf2e80885e3cb4609a/deform-2.0a2.tar.gz";
-      md5 = "7a90d41f7fbc18002ce74f39bd90a5e4";
+      url = "https://pypi.python.org/packages/66/3b/eefcb07abcab7a97f6665aa2d0cf1af741d9d6e78a2e4657fd2b89f89880/deform-2.0.4.tar.gz";
+      md5 = "34756e42cf50dd4b4430809116c4ec0a";
     };
     meta = {
       license = [ { fullName = "BSD-derived (http://www.repoze.org/LICENSE.txt)"; } ];
@@ -887,13 +887,13 b''
     };
   };
   ipython-genutils = super.buildPythonPackage {
-    name = "ipython-genutils-0.1.0";
+    name = "ipython-genutils-0.2.0";
     buildInputs = with self; [];
     doCheck = false;
     propagatedBuildInputs = with self; [];
     src = fetchurl {
-      url = "https://pypi.python.org/packages/71/b7/a64c71578521606edbbce15151358598f3dfb72a3431763edc2baf19e71f/ipython_genutils-0.1.0.tar.gz";
-      md5 = "9a8afbe0978adbcbfcb3b35b2d015a56";
+      url = "https://pypi.python.org/packages/e8/69/fbeffffc05236398ebfcfb512b6d2511c622871dca1746361006da310399/ipython_genutils-0.2.0.tar.gz";
+      md5 = "5a4f9781f78466da0ea1a648f3e1f79f";
     };
     meta = {
       license = [ pkgs.lib.licenses.bsdOriginal ];
@@ -1004,13 +1004,13 b''
     };
   };
   mistune = super.buildPythonPackage {
-    name = "mistune-0.7.3";
+    name = "mistune-0.7.4";
     buildInputs = with self; [];
     doCheck = false;
     propagatedBuildInputs = with self; [];
     src = fetchurl {
-      url = "https://pypi.python.org/packages/88/1e/be99791262b3a794332fda598a07c2749a433b9378586361ba9d8e824607/mistune-0.7.3.tar.gz";
-      md5 = "4eba50bd121b83716fa4be6a4049004b";
+      url = "https://pypi.python.org/packages/25/a4/12a584c0c59c9fed529f8b3c47ca8217c0cf8bcc5e1089d3256410cfbdbc/mistune-0.7.4.tar.gz";
+      md5 = "92d01cb717e9e74429e9bde9d29ac43b";
     };
     meta = {
       license = [ pkgs.lib.licenses.bsdOriginal ];
@@ -1082,13 +1082,13 b''
     };
   };
   objgraph = super.buildPythonPackage {
-    name = "objgraph-2.0.0";
+    name = "objgraph-3.1.0";
     buildInputs = with self; [];
     doCheck = false;
     propagatedBuildInputs = with self; [];
     src = fetchurl {
-      url = "https://pypi.python.org/packages/d7/33/ace750b59247496ed769b170586c5def7202683f3d98e737b75b767ff29e/objgraph-2.0.0.tar.gz";
-      md5 = "25b0d5e5adc74aa63ead15699614159c";
+      url = "https://pypi.python.org/packages/f4/b3/082e54e62094cb2ec84f8d5a49e0142cef99016491cecba83309cff920ae/objgraph-3.1.0.tar.gz";
+      md5 = "eddbd96039796bfbd13eee403701e64a";
     };
     meta = {
       license = [ pkgs.lib.licenses.mit ];
@@ -1186,13 +1186,13 b''
     };
   };
   prompt-toolkit = super.buildPythonPackage {
-    name = "prompt-toolkit-1.0.13";
+    name = "prompt-toolkit-1.0.14";
     buildInputs = with self; [];
     doCheck = false;
     propagatedBuildInputs = with self; [six wcwidth];
     src = fetchurl {
-      url = "https://pypi.python.org/packages/23/be/4876b52d5cc159cbd4b0ff6e7aa419a26470849a43a8f647857a4a24467b/prompt_toolkit-1.0.13.tar.gz";
-      md5 = "427b496d2c147bd3819bc3a7f6e0d493";
+      url = "https://pypi.python.org/packages/55/56/8c39509b614bda53e638b7500f12577d663ac1b868aef53426fc6a26c3f5/prompt_toolkit-1.0.14.tar.gz";
+      md5 = "f24061ae133ed32c6b764e92bd48c496";
     };
     meta = {
       license = [ pkgs.lib.licenses.bsdOriginal ];
@@ -1641,7 +1641,7 b''
     };
   };
   rhodecode-enterprise-ce = super.buildPythonPackage {
-    name = "rhodecode-enterprise-ce-4.7.2";
+    name = "rhodecode-enterprise-ce-4.8.0";
     buildInputs = with self; [pytest py pytest-cov pytest-sugar pytest-runner pytest-catchlog pytest-profiling gprof2dot pytest-timeout mock WebTest cov-core coverage configobj];
     doCheck = true;
     propagatedBuildInputs = with self; [Babel Beaker FormEncode Mako Markdown MarkupSafe MySQL-python Paste PasteDeploy PasteScript Pygments pygments-markdown-lexer Pylons Routes SQLAlchemy Tempita URLObject WebError WebHelpers WebHelpers2 WebOb WebTest Whoosh alembic amqplib anyjson appenlight-client authomatic backport-ipaddress cssselect celery channelstream colander decorator deform docutils gevent gunicorn infrae.cache ipython iso8601 kombu lxml msgpack-python nbconvert packaging psycopg2 py-gfm pycrypto pycurl pyparsing pyramid pyramid-debugtoolbar pyramid-mako pyramid-beaker pysqlite python-dateutil python-ldap python-memcached python-pam recaptcha-client repoze.lru requests simplejson subprocess32 waitress zope.cachedescriptors dogpile.cache dogpile.core psutil py-bcrypt];

requirements.txt

@@ -16,7 +16,7 b' colander==1.2'
 configobj==5.0.6
 cssselect==1.0.1
 decorator==4.0.11
-deform==2.0a2
+deform==2.0.4
 docutils==0.12
 dogpile.cache==0.6.1
 dogpile.core==0.4.1
@@ -38,7 +38,7 b' meld3==1.0.2'
 msgpack-python==0.4.8
 MySQL-python==1.2.5
 nose==1.3.6
-objgraph==2.0.0
+objgraph==3.1.0
 packaging==15.2
 paramiko==1.15.1
 Paste==2.0.3

rhodecode/VERSION

@@ -1,1 +1,1 b''
-4.7.2
  No newline at end of file
+4.8.0
  No newline at end of file

rhodecode/__init__.py

@@ -51,7 +51,7 b' PYRAMID_SETTINGS = {}'
 EXTENSIONS = {}
 
 __version__ = ('.'.join((str(each) for each in VERSION[:3])))
-__dbversion__ = 71  # defines current db version for migrations
+__dbversion__ = 78  # defines current db version for migrations
 __platform__ = platform.system()
 __license__ = 'AGPLv3, and Commercial License'
 __author__ = 'RhodeCode GmbH'

rhodecode/api/__init__.py

@@ -35,8 +35,9 b' from pyramid.httpexceptions import HTTPN'
 
 from rhodecode.api.exc import (
     JSONRPCBaseError, JSONRPCError, JSONRPCForbidden, JSONRPCValidationError)
+from rhodecode.apps._base import TemplateArgs
 from rhodecode.lib.auth import AuthUser
-from rhodecode.lib.base import get_ip_addr
+from rhodecode.lib.base import get_ip_addr, attach_context_attributes
 from rhodecode.lib.ext_json import json
 from rhodecode.lib.utils2 import safe_str
 from rhodecode.lib.plugins.utils import get_plugin_settings
@@ -278,6 +279,11 b' def request_view(request):'
         'request': request,
         'apiuser': auth_u
     })
+
+    # register some common functions for usage
+    attach_context_attributes(TemplateArgs(), request, request.rpc_user.user_id,
+                              attach_to_request=True)
+
     try:
         ret_value = func(**call_params)
         return jsonrpc_response(request, ret_value)

rhodecode/api/tests/test_close_pull_request.py

@@ -43,16 +43,16 b' class TestClosePullRequest(object):'
         response = api_call(self.app, params)
         expected = {
             'pull_request_id': pull_request_id,
+            'close_status': 'Rejected',
             'closed': True,
         }
         assert_ok(id_, expected, response.body)
-        action = 'user_closed_pull_request:%d' % pull_request_id
         journal = UserLog.query()\
-            .filter(UserLog.user_id == author)\
+            .filter(UserLog.user_id == author) \
+            .order_by('user_log_id') \
             .filter(UserLog.repository_id == repo)\
-            .filter(UserLog.action == action)\
             .all()
-        assert len(journal) == 1
+        assert journal[-1].action == 'repo.pull_request.close'
 
     @pytest.mark.backends("git", "hg")
     def test_api_close_pull_request_already_closed_error(self, pr_util):

rhodecode/api/tests/test_comment_pull_request.py

@@ -62,13 +62,12 b' class TestCommentPullRequest(object):'
         }
         assert_ok(id_, expected, response.body)
 
-        action = 'user_commented_pull_request:%d' % pull_request_id
         journal = UserLog.query()\
             .filter(UserLog.user_id == author)\
-            .filter(UserLog.repository_id == repo)\
-            .filter(UserLog.action == action)\
+            .filter(UserLog.repository_id == repo) \
+            .order_by('user_log_id') \
             .all()
-        assert len(journal) == 2
+        assert journal[-1].action == 'repo.pull_request.comment.create'
 
     @pytest.mark.backends("git", "hg")
     def test_api_comment_pull_request_change_status(

rhodecode/api/tests/test_create_pull_request.py

@@ -77,7 +77,7 b' class TestCreatePullRequestApi(object):'
         assert pull_request.source_repo.repo_name == data['source_repo']
         assert pull_request.target_repo.repo_name == data['target_repo']
         assert pull_request.revisions == [self.commit_ids['change']]
-        assert pull_request.reviewers == []
+        assert len(pull_request.reviewers) == 1
 
     @pytest.mark.backends("git", "hg")
     def test_create_with_empty_description(self, backend):
@@ -98,7 +98,12 b' class TestCreatePullRequestApi(object):'
     def test_create_with_reviewers_specified_by_names(
             self, backend, no_notifications):
         data = self._prepare_data(backend)
-        reviewers = [TEST_USER_REGULAR_LOGIN, TEST_USER_ADMIN_LOGIN]
+        reviewers = [
+            {'username': TEST_USER_REGULAR_LOGIN,
+             'reasons': ['added manually']},
+            {'username': TEST_USER_ADMIN_LOGIN,
+             'reasons': ['added manually']},
+        ]
         data['reviewers'] = reviewers
         id_, params = build_data(
             self.apikey_regular, 'create_pull_request', **data)
@@ -110,16 +115,26 b' class TestCreatePullRequestApi(object):'
         assert result['result']['msg'] == expected_message
         pull_request_id = result['result']['pull_request_id']
         pull_request = PullRequestModel().get(pull_request_id)
-        actual_reviewers = [r.user.username for r in pull_request.reviewers]
+        actual_reviewers = [
+            {'username': r.user.username,
+             'reasons': ['added manually'],
+             } for r in pull_request.reviewers
+        ]
         assert sorted(actual_reviewers) == sorted(reviewers)
 
     @pytest.mark.backends("git", "hg")
     def test_create_with_reviewers_specified_by_ids(
             self, backend, no_notifications):
         data = self._prepare_data(backend)
-        reviewer_names = [TEST_USER_REGULAR_LOGIN, TEST_USER_ADMIN_LOGIN]
         reviewers = [
-            UserModel().get_by_username(n).user_id for n in reviewer_names]
+            {'username': UserModel().get_by_username(
+                TEST_USER_REGULAR_LOGIN).user_id,
+             'reasons': ['added manually']},
+            {'username': UserModel().get_by_username(
+                TEST_USER_ADMIN_LOGIN).user_id,
+             'reasons': ['added manually']},
+        ]
+
         data['reviewers'] = reviewers
         id_, params = build_data(
             self.apikey_regular, 'create_pull_request', **data)
@@ -131,14 +146,17 b' class TestCreatePullRequestApi(object):'
         assert result['result']['msg'] == expected_message
         pull_request_id = result['result']['pull_request_id']
         pull_request = PullRequestModel().get(pull_request_id)
-        actual_reviewers = [r.user.username for r in pull_request.reviewers]
-        assert sorted(actual_reviewers) == sorted(reviewer_names)
+        actual_reviewers = [
+            {'username': r.user.user_id,
+             'reasons': ['added manually'],
+             } for r in pull_request.reviewers
+        ]
+        assert sorted(actual_reviewers) == sorted(reviewers)
 
     @pytest.mark.backends("git", "hg")
     def test_create_fails_when_the_reviewer_is_not_found(self, backend):
         data = self._prepare_data(backend)
-        reviewers = ['somebody']
-        data['reviewers'] = reviewers
+        data['reviewers'] = [{'username': 'somebody'}]
         id_, params = build_data(
             self.apikey_regular, 'create_pull_request', **data)
         response = api_call(self.app, params)
@@ -153,7 +171,7 b' class TestCreatePullRequestApi(object):'
         id_, params = build_data(
             self.apikey_regular, 'create_pull_request', **data)
         response = api_call(self.app, params)
-        expected_message = 'reviewers should be specified as a list'
+        expected_message = {u'': '"test_regular,test_admin" is not iterable'}
         assert_error(id_, expected_message, given=response.body)
 
     @pytest.mark.backends("git", "hg")

rhodecode/api/tests/test_create_user.py

@@ -59,6 +59,21 b' class TestCreateUser(object):'
         expected = "email `%s` already exist" % (TEST_USER_REGULAR_EMAIL,)
         assert_error(id_, expected, given=response.body)
 
+    def test_api_create_user_with_wrong_username(self):
+        bad_username = '<> HELLO WORLD <>'
+        id_, params = build_data(
+            self.apikey, 'create_user',
+            username=bad_username,
+            email='[e-mail]',
+            password='trololo')
+        response = api_call(self.app, params)
+
+        expected = {'username':
+                        "Username may only contain alphanumeric characters "
+                        "underscores, periods or dashes and must begin with "
+                        "alphanumeric character or underscore"}
+        assert_error(id_, expected, given=response.body)
+
     def test_api_create_user(self):
         username = 'test_new_api_user'
         email = username + "@foo.com"
@@ -175,7 +190,6 b' class TestCreateUser(object):'
             fixture.destroy_repo_group(username)
             fixture.destroy_user(usr.user_id)
 
-
     @mock.patch.object(UserModel, 'create_or_update', crash)
     def test_api_create_user_when_exception_happened(self):
 

rhodecode/api/tests/test_create_user_group.py

@@ -112,3 +112,16 b' class TestCreateUserGroup(object):'
 
         expected = 'failed to create group `%s`' % (group_name,)
         assert_error(id_, expected, given=response.body)
+
+    def test_api_create_user_group_with_wrong_name(self, user_util):
+
+        group_name = 'wrong NAME <>'
+        id_, params = build_data(
+            self.apikey, 'create_user_group', group_name=group_name)
+        response = api_call(self.app, params)
+
+        expected = {"user_group_name":
+                        "Allowed in name are letters, numbers, and `-`, `_`, "
+                        "`.` Name must start with a letter or number. "
+                        "Got `{}`".format(group_name)}
+        assert_error(id_, expected, given=response.body)

rhodecode/api/tests/test_delete_repo.py

@@ -30,43 +30,45 b' from rhodecode.api.tests.utils import ('
 class TestApiDeleteRepo(object):
     def test_api_delete_repo(self, backend):
         repo = backend.create_repo()
-
+        repo_name = repo.repo_name
         id_, params = build_data(
             self.apikey, 'delete_repo', repoid=repo.repo_name, )
         response = api_call(self.app, params)
 
         expected = {
-            'msg': 'Deleted repository `%s`' % (repo.repo_name,),
+            'msg': 'Deleted repository `%s`' % (repo_name,),
             'success': True
         }
         assert_ok(id_, expected, given=response.body)
 
     def test_api_delete_repo_by_non_admin(self, backend, user_regular):
         repo = backend.create_repo(cur_user=user_regular.username)
+        repo_name = repo.repo_name
         id_, params = build_data(
             user_regular.api_key, 'delete_repo', repoid=repo.repo_name, )
         response = api_call(self.app, params)
 
         expected = {
-            'msg': 'Deleted repository `%s`' % (repo.repo_name,),
+            'msg': 'Deleted repository `%s`' % (repo_name,),
             'success': True
         }
         assert_ok(id_, expected, given=response.body)
 
     def test_api_delete_repo_by_non_admin_no_permission(self, backend):
         repo = backend.create_repo()
+        repo_name = repo.repo_name
         id_, params = build_data(
             self.apikey_regular, 'delete_repo', repoid=repo.repo_name, )
         response = api_call(self.app, params)
-        expected = 'repository `%s` does not exist' % (repo.repo_name)
+        expected = 'repository `%s` does not exist' % (repo_name)
         assert_error(id_, expected, given=response.body)
 
     def test_api_delete_repo_exception_occurred(self, backend):
         repo = backend.create_repo()
+        repo_name = repo.repo_name
         id_, params = build_data(
             self.apikey, 'delete_repo', repoid=repo.repo_name, )
         with mock.patch.object(RepoModel, 'delete', crash):
             response = api_call(self.app, params)
-        expected = 'failed to delete repository `%s`' % (
-            repo.repo_name,)
+        expected = 'failed to delete repository `%s`' % (repo_name,)
         assert_error(id_, expected, given=response.body)

rhodecode/api/tests/test_get_gist.py

@@ -28,7 +28,7 b' from rhodecode.api.tests.utils import ('
 
 @pytest.mark.usefixtures("testuser_api", "app")
 class TestApiGetGist(object):
-    def test_api_get_gist(self, gist_util):
+    def test_api_get_gist(self, gist_util, http_host_stub):
         gist = gist_util.create_gist()
         gist_id = gist.gist_access_id
         gist_created_on = gist.created_on
@@ -45,14 +45,14 b' class TestApiGetGist(object):'
             'expires': -1.0,
             'gist_id': int(gist_id),
             'type': 'public',
-            'url': 'http://test.example.com:80/_admin/gists/%s' % (gist_id,),
+            'url': 'http://%s/_admin/gists/%s' % (http_host_stub, gist_id,),
             'acl_level': Gist.ACL_LEVEL_PUBLIC,
             'content': None,
         }
 
         assert_ok(id_, expected, given=response.body)
 
-    def test_api_get_gist_with_content(self, gist_util):
+    def test_api_get_gist_with_content(self, gist_util, http_host_stub):
         mapping = {
             u'filename1.txt': {'content': u'hello world'},
             u'filename1ą.txt': {'content': u'hello worldę'}
@@ -73,7 +73,7 b' class TestApiGetGist(object):'
             'expires': -1.0,
             'gist_id': int(gist_id),
             'type': 'public',
-            'url': 'http://test.example.com:80/_admin/gists/%s' % (gist_id,),
+            'url': 'http://%s/_admin/gists/%s' % (http_host_stub, gist_id,),
             'acl_level': Gist.ACL_LEVEL_PUBLIC,
             'content': {
                 u'filename1.txt': u'hello world',

rhodecode/api/tests/test_get_pull_request.py

@@ -19,13 +19,13 b''
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
 
-import mock
 import pytest
 import urlobject
 from pylons import url
 
 from rhodecode.api.tests.utils import (
     build_data, api_call, assert_error, assert_ok)
+from rhodecode.lib.utils2 import safe_unicode
 
 pytestmark = pytest.mark.backends("git", "hg")
 
@@ -33,7 +33,7 b' pytestmark = pytest.mark.backends("git",'
 @pytest.mark.usefixtures("testuser_api", "app")
 class TestGetPullRequest(object):
 
-    def test_api_get_pull_request(self, pr_util):
+    def test_api_get_pull_request(self, pr_util, http_host_only_stub):
         from rhodecode.model.pull_request import PullRequestModel
         pull_request = pr_util.create_pull_request(mergeable=True)
         id_, params = build_data(
@@ -50,16 +50,16 b' class TestGetPullRequest(object):'
                 'pullrequest_show',
                 repo_name=pull_request.target_repo.repo_name,
                 pull_request_id=pull_request.pull_request_id, qualified=True))
-        pr_url = unicode(
-            url_obj.with_netloc('test.example.com:80'))
-        source_url = unicode(
-            pull_request.source_repo.clone_url()
-                .with_netloc('test.example.com:80'))
-        target_url = unicode(
-            pull_request.target_repo.clone_url()
-                .with_netloc('test.example.com:80'))
-        shadow_url = unicode(
+
+        pr_url = safe_unicode(
+            url_obj.with_netloc(http_host_only_stub))
+        source_url = safe_unicode(
+            pull_request.source_repo.clone_url().with_netloc(http_host_only_stub))
+        target_url = safe_unicode(
+            pull_request.target_repo.clone_url().with_netloc(http_host_only_stub))
+        shadow_url = safe_unicode(
             PullRequestModel().get_shadow_clone_url(pull_request))
+
         expected = {
             'pull_request_id': pull_request.pull_request_id,
             'url': pr_url,
@@ -109,7 +109,8 b' class TestGetPullRequest(object):'
                     'reasons': reasons,
                     'review_status': st[0][1].status if st else 'not_reviewed',
                 }
-                for reviewer, reasons, st in pull_request.reviewers_statuses()
+                for reviewer, reasons, mandatory, st in
+                pull_request.reviewers_statuses()
             ]
         }
         assert_ok(id_, expected, response.body)

rhodecode/api/tests/test_merge_pull_request.py

@@ -95,13 +95,13 b' class TestMergePullRequest(object):'
 
         assert_ok(id_, expected, response.body)
 
-        action = 'user_merged_pull_request:%d' % (pull_request_id, )
         journal = UserLog.query()\
             .filter(UserLog.user_id == author)\
-            .filter(UserLog.repository_id == repo)\
-            .filter(UserLog.action == action)\
+            .filter(UserLog.repository_id == repo) \
+            .order_by('user_log_id') \
             .all()
-        assert len(journal) == 1
+        assert journal[-2].action == 'repo.pull_request.merge'
+        assert journal[-1].action == 'repo.pull_request.close'
 
         id_, params = build_data(
             self.apikey, 'merge_pull_request',

rhodecode/api/tests/test_update_pull_request.py

@@ -33,7 +33,7 b' class TestUpdatePullRequest(object):'
 
     @pytest.mark.backends("git", "hg")
     def test_api_update_pull_request_title_or_description(
-            self, pr_util, silence_action_logger, no_notifications):
+            self, pr_util, no_notifications):
         pull_request = pr_util.create_pull_request()
 
         id_, params = build_data(
@@ -61,7 +61,7 b' class TestUpdatePullRequest(object):'
 
     @pytest.mark.backends("git", "hg")
     def test_api_try_update_closed_pull_request(
-            self, pr_util, silence_action_logger, no_notifications):
+            self, pr_util, no_notifications):
         pull_request = pr_util.create_pull_request()
         PullRequestModel().close_pull_request(
             pull_request, TEST_USER_ADMIN_LOGIN)
@@ -78,8 +78,7 b' class TestUpdatePullRequest(object):'
         assert_error(id_, expected, response.body)
 
     @pytest.mark.backends("git", "hg")
-    def test_api_update_update_commits(
-            self, pr_util, silence_action_logger, no_notifications):
+    def test_api_update_update_commits(self, pr_util, no_notifications):
         commits = [
             {'message': 'a'},
             {'message': 'b', 'added': [FileNode('file_b', 'test_content\n')]},
@@ -119,20 +118,28 b' class TestUpdatePullRequest(object):'
 
     @pytest.mark.backends("git", "hg")
     def test_api_update_change_reviewers(
-            self, pr_util, silence_action_logger, no_notifications):
+            self, user_util, pr_util, no_notifications):
+        a = user_util.create_user()
+        b = user_util.create_user()
+        c = user_util.create_user()
+        new_reviewers = [
+            {'username': b.username,'reasons': ['updated via API'],
+             'mandatory':False},
+            {'username': c.username, 'reasons': ['updated via API'],
+             'mandatory':False},
+        ]
 
-        users = [x.username for x in User.get_all()]
-        new = [users.pop(0)]
-        removed = sorted(new)
-        added = sorted(users)
+        added = [b.username, c.username]
+        removed = [a.username]
 
-        pull_request = pr_util.create_pull_request(reviewers=new)
+        pull_request = pr_util.create_pull_request(
+            reviewers=[(a.username, ['added via API'], False)])
 
         id_, params = build_data(
             self.apikey, 'update_pull_request',
             repoid=pull_request.target_repo.repo_name,
             pullrequestid=pull_request.pull_request_id,
-            reviewers=added)
+            reviewers=new_reviewers)
         response = api_call(self.app, params)
         expected = {
             "msg": "Updated pull request `{}`".format(
@@ -152,7 +159,7 b' class TestUpdatePullRequest(object):'
             self.apikey, 'update_pull_request',
             repoid=pull_request.target_repo.repo_name,
             pullrequestid=pull_request.pull_request_id,
-            reviewers=['bad_name'])
+            reviewers=[{'username': 'bad_name'}])
         response = api_call(self.app, params)
 
         expected = 'user `bad_name` does not exist'
@@ -165,7 +172,7 b' class TestUpdatePullRequest(object):'
             self.apikey, 'update_pull_request',
             repoid='fake',
             pullrequestid='fake',
-            reviewers=['bad_name'])
+            reviewers=[{'username': 'bad_name'}])
         response = api_call(self.app, params)
 
         expected = 'repository `fake` does not exist'
@@ -181,7 +188,7 b' class TestUpdatePullRequest(object):'
             self.apikey, 'update_pull_request',
             repoid=pull_request.target_repo.repo_name,
             pullrequestid=999999,
-            reviewers=['bad_name'])
+            reviewers=[{'username': 'bad_name'}])
         response = api_call(self.app, params)
 
         expected = 'pull request `999999` does not exist'

rhodecode/api/tests/test_update_repo.py

@@ -26,7 +26,7 b' from rhodecode.tests import TEST_USER_AD'
 from rhodecode.api.tests.utils import (
     build_data, api_call, assert_error, assert_ok, crash, jsonify)
 from rhodecode.tests.fixture import Fixture
-
+from rhodecode.tests.plugin import http_host_stub, http_host_only_stub
 
 fixture = Fixture()
 
@@ -71,14 +71,15 b' class TestApiUpdateRepo(object):'
         ({'repo_name': 'new_repo_name'},
          {
             'repo_name': 'new_repo_name',
-            'url': 'http://test.example.com:80/new_repo_name'
+            'url': 'http://{}/new_repo_name'.format(http_host_only_stub())
          }),
 
         ({'repo_name': 'test_group_for_update/{}'.format(UPDATE_REPO_NAME),
           '_group': 'test_group_for_update'},
          {
             'repo_name': 'test_group_for_update/{}'.format(UPDATE_REPO_NAME),
-            'url': 'http://test.example.com:80/test_group_for_update/{}'.format(UPDATE_REPO_NAME)
+            'url': 'http://{}/test_group_for_update/{}'.format(
+                http_host_only_stub(), UPDATE_REPO_NAME)
          }),
     ])
     def test_api_update_repo(self, updates, expected, backend):
@@ -115,7 +116,8 b' class TestApiUpdateRepo(object):'
         master_repo = backend.create_repo()
         repo = backend.create_repo()
         updates = {
-            'fork_of': master_repo.repo_name
+            'fork_of': master_repo.repo_name,
+            'fork_of_id': master_repo.repo_id
         }
         expected_api_data = repo.get_api_data(include_secrets=True)
         expected_api_data.update(updates)
@@ -130,6 +132,7 b' class TestApiUpdateRepo(object):'
         assert_ok(id_, expected, given=response.body)
         result = response.json['result']['repository']
         assert result['fork_of'] == master_repo.repo_name
+        assert result['fork_of_id'] == master_repo.repo_id
 
     def test_api_update_repo_fork_of_not_found(self, backend):
         master_repo_name = 'fake-parent-repo'

rhodecode/api/views/pull_request_api.py

@@ -21,7 +21,8 b''
 
 import logging
 
-from rhodecode.api import jsonrpc_method, JSONRPCError
+from rhodecode import events
+from rhodecode.api import jsonrpc_method, JSONRPCError, JSONRPCValidationError
 from rhodecode.api.utils import (
     has_superadmin_permission, Optional, OAttr, get_repo_or_error,
     get_pull_request_or_error, get_commit_or_error, get_user_or_error,
@@ -34,6 +35,9 b' from rhodecode.model.comment import Comm'
 from rhodecode.model.db import Session, ChangesetStatus, ChangesetComment
 from rhodecode.model.pull_request import PullRequestModel, MergeCheck
 from rhodecode.model.settings import SettingsModel
+from rhodecode.model.validation_schema import Invalid
+from rhodecode.model.validation_schema.schemas.reviewer_schema import(
+    ReviewerListSchema)
 
 log = logging.getLogger(__name__)
 
@@ -224,8 +228,9 b' def get_pull_requests(request, apiuser, '
 
 
 @jsonrpc_method()
-def merge_pull_request(request, apiuser, repoid, pullrequestid,
-                       userid=Optional(OAttr('apiuser'))):
+def merge_pull_request(
+        request, apiuser, repoid, pullrequestid,
+        userid=Optional(OAttr('apiuser'))):
     """
     Merge the pull request specified by `pullrequestid` into its target
     repository.
@@ -273,7 +278,12 b' def merge_pull_request(request, apiuser,'
     merge_possible = not check.failed
 
     if not merge_possible:
-        reasons = ','.join([msg for _e, msg in check.errors])
+        error_messages = []
+        for err_type, error_msg in check.errors:
+            error_msg = request.translate(error_msg)
+            error_messages.append(error_msg)
+
+        reasons = ','.join(error_messages)
         raise JSONRPCError(
             'merge not possible for following reasons: {}'.format(reasons))
 
@@ -300,63 +310,6 b' def merge_pull_request(request, apiuser,'
 
 
 @jsonrpc_method()
-def close_pull_request(request, apiuser, repoid, pullrequestid,
-                       userid=Optional(OAttr('apiuser'))):
-    """
-    Close the pull request specified by `pullrequestid`.
-
-    :param apiuser: This is filled automatically from the |authtoken|.
-    :type apiuser: AuthUser
-    :param repoid: Repository name or repository ID to which the pull
-        request belongs.
-    :type repoid: str or int
-    :param pullrequestid: ID of the pull request to be closed.
-    :type pullrequestid: int
-    :param userid: Close the pull request as this user.
-    :type userid: Optional(str or int)
-
-    Example output:
-
-    .. code-block:: bash
-
-        "id": <id_given_in_input>,
-        "result": {
-            "pull_request_id":  "<int>",
-            "closed":           "<bool>"
-        },
-        "error": null
-
-    """
-    repo = get_repo_or_error(repoid)
-    if not isinstance(userid, Optional):
-        if (has_superadmin_permission(apiuser) or
-                HasRepoPermissionAnyApi('repository.admin')(
-                    user=apiuser, repo_name=repo.repo_name)):
-            apiuser = get_user_or_error(userid)
-        else:
-            raise JSONRPCError('userid is not the same as your user')
-
-    pull_request = get_pull_request_or_error(pullrequestid)
-    if not PullRequestModel().check_user_update(
-            pull_request, apiuser, api=True):
-        raise JSONRPCError(
-            'pull request `%s` close failed, no permission to close.' % (
-                pullrequestid,))
-    if pull_request.is_closed():
-        raise JSONRPCError(
-            'pull request `%s` is already closed' % (pullrequestid,))
-
-    PullRequestModel().close_pull_request(
-        pull_request.pull_request_id, apiuser)
-    Session().commit()
-    data = {
-        'pull_request_id': pull_request.pull_request_id,
-        'closed': True,
-    }
-    return data
-
-
-@jsonrpc_method()
 def comment_pull_request(
         request, apiuser, repoid, pullrequestid, message=Optional(None),
         commit_id=Optional(None), status=Optional(None),
@@ -529,24 +482,26 b' def create_pull_request('
     :param description: Set the pull request description.
     :type description: Optional(str)
     :param reviewers: Set the new pull request reviewers list.
+        Reviewer defined by review rules will be added automatically to the
+        defined list.
     :type reviewers: Optional(list)
         Accepts username strings or objects of the format:
 
-            {'username': 'nick', 'reasons': ['original author']}
+            [{'username': 'nick', 'reasons': ['original author'], 'mandatory': <bool>}]
     """
 
-    source = get_repo_or_error(source_repo)
-    target = get_repo_or_error(target_repo)
+    source_db_repo =  get_repo_or_error(source_repo)
+    target_db_repo = get_repo_or_error(target_repo)
     if not has_superadmin_permission(apiuser):
         _perms = ('repository.admin', 'repository.write', 'repository.read',)
-        validate_repo_permissions(apiuser, source_repo, source, _perms)
+        validate_repo_permissions(apiuser, source_repo, source_db_repo, _perms)
 
-    full_source_ref = resolve_ref_or_error(source_ref, source)
-    full_target_ref = resolve_ref_or_error(target_ref, target)
-    source_commit = get_commit_or_error(full_source_ref, source)
-    target_commit = get_commit_or_error(full_target_ref, target)
-    source_scm = source.scm_instance()
-    target_scm = target.scm_instance()
+    full_source_ref = resolve_ref_or_error(source_ref, source_db_repo)
+    full_target_ref = resolve_ref_or_error(target_ref, target_db_repo)
+    source_commit = get_commit_or_error(full_source_ref, source_db_repo)
+    target_commit = get_commit_or_error(full_target_ref, target_db_repo)
+    source_scm = source_db_repo.scm_instance()
+    target_scm = target_db_repo.scm_instance()
 
     commit_ranges = target_scm.compare(
         target_commit.raw_id, source_commit.raw_id, source_scm,
@@ -562,20 +517,36 b' def create_pull_request('
         raise JSONRPCError('no common ancestor found')
 
     reviewer_objects = Optional.extract(reviewers) or []
-    if not isinstance(reviewer_objects, list):
-        raise JSONRPCError('reviewers should be specified as a list')
+
+    if reviewer_objects:
+        schema = ReviewerListSchema()
+        try:
+            reviewer_objects = schema.deserialize(reviewer_objects)
+        except Invalid as err:
+            raise JSONRPCValidationError(colander_exc=err)
+
+        # validate users
+        for reviewer_object in reviewer_objects:
+            user = get_user_or_error(reviewer_object['username'])
+            reviewer_object['user_id'] = user.user_id
 
-    reviewers_reasons = []
-    for reviewer_object in reviewer_objects:
-        reviewer_reasons = []
-        if isinstance(reviewer_object, (basestring, int)):
-            reviewer_username = reviewer_object
-        else:
-            reviewer_username = reviewer_object['username']
-            reviewer_reasons = reviewer_object.get('reasons', [])
+    get_default_reviewers_data, get_validated_reviewers = \
+        PullRequestModel().get_reviewer_functions()
+
+    reviewer_rules = get_default_reviewers_data(
+        apiuser.get_instance(), source_db_repo,
+        source_commit, target_db_repo, target_commit)
 
-        user = get_user_or_error(reviewer_username)
-        reviewers_reasons.append((user.user_id, reviewer_reasons))
+    # specified rules are later re-validated, thus we can assume users will
+    # eventually provide those that meet the reviewer criteria.
+    if not reviewer_objects:
+        reviewer_objects = reviewer_rules['reviewers']
+
+    try:
+        reviewers = get_validated_reviewers(
+            reviewer_objects, reviewer_rules)
+    except ValueError as e:
+        raise JSONRPCError('Reviewers Validation: {}'.format(e))
 
     pull_request_model = PullRequestModel()
     pull_request = pull_request_model.create(
@@ -586,7 +557,7 b' def create_pull_request('
         target_ref=full_target_ref,
         revisions=reversed(
             [commit.raw_id for commit in reversed(commit_ranges)]),
-        reviewers=reviewers_reasons,
+        reviewers=reviewers,
         title=title,
         description=Optional.extract(description)
     )
@@ -603,7 +574,7 b' def create_pull_request('
 def update_pull_request(
         request, apiuser, repoid, pullrequestid, title=Optional(''),
         description=Optional(''), reviewers=Optional(None),
-        update_commits=Optional(None), close_pull_request=Optional(None)):
+        update_commits=Optional(None)):
     """
     Updates a pull request.
 
@@ -619,10 +590,12 b' def update_pull_request('
     :type description: Optional(str)
     :param reviewers: Update pull request reviewers list with new value.
     :type reviewers: Optional(list)
+        Accepts username strings or objects of the format:
+
+            [{'username': 'nick', 'reasons': ['original author'], 'mandatory': <bool>}]
+
     :param update_commits: Trigger update of commits for this pull request
     :type: update_commits: Optional(bool)
-    :param close_pull_request: Close this pull request with rejected state
-    :type: close_pull_request: Optional(bool)
 
     Example output:
 
@@ -665,29 +638,38 b' def update_pull_request('
                 pullrequestid,))
 
     reviewer_objects = Optional.extract(reviewers) or []
-    if not isinstance(reviewer_objects, list):
-        raise JSONRPCError('reviewers should be specified as a list')
+
+    if reviewer_objects:
+        schema = ReviewerListSchema()
+        try:
+            reviewer_objects = schema.deserialize(reviewer_objects)
+        except Invalid as err:
+            raise JSONRPCValidationError(colander_exc=err)
+
+        # validate users
+        for reviewer_object in reviewer_objects:
+            user = get_user_or_error(reviewer_object['username'])
+            reviewer_object['user_id'] = user.user_id
 
-    reviewers_reasons = []
-    reviewer_ids = set()
-    for reviewer_object in reviewer_objects:
-        reviewer_reasons = []
-        if isinstance(reviewer_object, (int, basestring)):
-            reviewer_username = reviewer_object
-        else:
-            reviewer_username = reviewer_object['username']
-            reviewer_reasons = reviewer_object.get('reasons', [])
+        get_default_reviewers_data, get_validated_reviewers = \
+            PullRequestModel().get_reviewer_functions()
 
-        user = get_user_or_error(reviewer_username)
-        reviewer_ids.add(user.user_id)
-        reviewers_reasons.append((user.user_id, reviewer_reasons))
+        # re-use stored rules
+        reviewer_rules = pull_request.reviewer_data
+        try:
+            reviewers = get_validated_reviewers(
+                reviewer_objects, reviewer_rules)
+        except ValueError as e:
+            raise JSONRPCError('Reviewers Validation: {}'.format(e))
+    else:
+        reviewers = []
 
     title = Optional.extract(title)
     description = Optional.extract(description)
     if title or description:
         PullRequestModel().edit(
             pull_request, title or pull_request.title,
-            description or pull_request.description)
+            description or pull_request.description, apiuser)
         Session().commit()
 
     commit_changes = {"added": [], "common": [], "removed": []}
@@ -699,9 +681,9 b' def update_pull_request('
         Session().commit()
 
     reviewers_changes = {"added": [], "removed": []}
-    if reviewer_ids:
+    if reviewers:
         added_reviewers, removed_reviewers = \
-            PullRequestModel().update_reviewers(pull_request, reviewers_reasons)
+            PullRequestModel().update_reviewers(pull_request, reviewers, apiuser)
 
         reviewers_changes['added'] = sorted(
             [get_user_or_error(n).username for n in added_reviewers])
@@ -709,11 +691,6 b' def update_pull_request('
             [get_user_or_error(n).username for n in removed_reviewers])
         Session().commit()
 
-    if str2bool(Optional.extract(close_pull_request)):
-        PullRequestModel().close_pull_request_with_comment(
-            pull_request, apiuser, repo)
-        Session().commit()
-
     data = {
         'msg': 'Updated pull request `{}`'.format(
             pull_request.pull_request_id),
@@ -723,3 +700,80 b' def update_pull_request('
     }
 
     return data
+
+
+@jsonrpc_method()
+def close_pull_request(
+        request, apiuser, repoid, pullrequestid,
+        userid=Optional(OAttr('apiuser')), message=Optional('')):
+    """
+    Close the pull request specified by `pullrequestid`.
+
+    :param apiuser: This is filled automatically from the |authtoken|.
+    :type apiuser: AuthUser
+    :param repoid: Repository name or repository ID to which the pull
+        request belongs.
+    :type repoid: str or int
+    :param pullrequestid: ID of the pull request to be closed.
+    :type pullrequestid: int
+    :param userid: Close the pull request as this user.
+    :type userid: Optional(str or int)
+    :param message: Optional message to close the Pull Request with. If not
+        specified it will be generated automatically.
+    :type message: Optional(str)
+
+    Example output:
+
+    .. code-block:: bash
+
+        "id": <id_given_in_input>,
+        "result": {
+            "pull_request_id":  "<int>",
+            "close_status":     "<str:status_lbl>,
+            "closed":           "<bool>"
+        },
+        "error": null
+
+    """
+    _ = request.translate
+
+    repo = get_repo_or_error(repoid)
+    if not isinstance(userid, Optional):
+        if (has_superadmin_permission(apiuser) or
+                HasRepoPermissionAnyApi('repository.admin')(
+                    user=apiuser, repo_name=repo.repo_name)):
+            apiuser = get_user_or_error(userid)
+        else:
+            raise JSONRPCError('userid is not the same as your user')
+
+    pull_request = get_pull_request_or_error(pullrequestid)
+
+    if pull_request.is_closed():
+        raise JSONRPCError(
+            'pull request `%s` is already closed' % (pullrequestid,))
+
+    # only owner or admin or person with write permissions
+    allowed_to_close = PullRequestModel().check_user_update(
+            pull_request, apiuser, api=True)
+
+    if not allowed_to_close:
+        raise JSONRPCError(
+            'pull request `%s` close failed, no permission to close.' % (
+                pullrequestid,))
+
+    # message we're using to close the PR, else it's automatically generated
+    message = Optional.extract(message)
+
+    # finally close the PR, with proper message comment
+    comment, status = PullRequestModel().close_pull_request_with_comment(
+        pull_request, apiuser, repo, message=message)
+    status_lbl = ChangesetStatus.get_status_lbl(status)
+
+    Session().commit()
+
+    data = {
+        'pull_request_id': pull_request.pull_request_id,
+        'close_status': status_lbl,
+        'closed': True,
+    }
+    return data

rhodecode/api/views/repo_api.py

@@ -29,6 +29,8 b' from rhodecode.api.utils import ('
     get_user_group_or_error, get_user_or_error, validate_repo_permissions,
     get_perm_or_error, parse_args, get_origin, build_commit_data,
     validate_set_owner_permissions)
+from rhodecode.lib import audit_logger
+from rhodecode.lib import repo_maintenance
 from rhodecode.lib.auth import HasPermissionAnyApi, HasUserGroupPermissionAnyApi
 from rhodecode.lib.utils2 import str2bool, time_to_datetime
 from rhodecode.lib.ext_json import json
@@ -915,12 +917,13 b' def update_repo('
 
     ref_choices, _labels = ScmModel().get_repo_landing_revs(repo=repo)
 
+    old_values = repo.get_api_data()
     schema = repo_schema.RepoSchema().bind(
         repo_type_options=rhodecode.BACKENDS.keys(),
         repo_ref_options=ref_choices,
         # user caller
         user=apiuser,
-        old_values=repo.get_api_data())
+        old_values=old_values)
     try:
         schema_data = schema.deserialize(dict(
             # we save old value, users cannot change type
@@ -965,6 +968,9 b' def update_repo('
 
     try:
         RepoModel().update(repo, **validated_updates)
+        audit_logger.store_api(
+            'repo.edit', action_data={'old_data': old_values},
+            user=apiuser, repo=repo)
         Session().commit()
         return {
             'msg': 'updated repo ID:%s %s' % (repo.repo_id, repo.repo_name),
@@ -1153,6 +1159,7 b' def delete_repo(request, apiuser, repoid'
     """
 
     repo = get_repo_or_error(repoid)
+    repo_name = repo.repo_name
     if not has_superadmin_permission(apiuser):
         _perms = ('repository.admin',)
         validate_repo_permissions(apiuser, repoid, repo, _perms)
@@ -1170,18 +1177,26 b' def delete_repo(request, apiuser, repoid'
                 'Cannot delete `%s` it still contains attached forks' %
                 (repo.repo_name,)
             )
+        old_data = repo.get_api_data()
+        RepoModel().delete(repo, forks=forks)
 
-        RepoModel().delete(repo, forks=forks)
+        repo = audit_logger.RepoWrap(repo_id=None,
+                                     repo_name=repo.repo_name)
+
+        audit_logger.store_api(
+            'repo.delete', action_data={'old_data': old_data},
+            user=apiuser, repo=repo)
+
+        ScmModel().mark_for_invalidation(repo_name, delete=True)
         Session().commit()
         return {
-            'msg': 'Deleted repository `%s`%s' % (
-                repo.repo_name, _forks_msg),
+            'msg': 'Deleted repository `%s`%s' % (repo_name, _forks_msg),
             'success': True
         }
     except Exception:
         log.exception("Exception occurred while trying to delete repo")
         raise JSONRPCError(
-            'failed to delete repository `%s`' % (repo.repo_name,)
+            'failed to delete repository `%s`' % (repo_name,)
         )
 
 
@@ -1460,7 +1475,7 b' def comment_commit('
         rc_config = SettingsModel().get_all_settings()
         renderer = rc_config.get('rhodecode_markup_renderer', 'rst')
         status_change_label = ChangesetStatus.get_status_lbl(status)
-        comm = CommentsModel().create(
+        comment = CommentsModel().create(
             message, repo, user, commit_id=commit_id,
             status_change=status_change_label,
             status_change_type=status,
@@ -1472,7 +1487,7 b' def comment_commit('
             # also do a status change
             try:
                 ChangesetStatusModel().set_status(
-                    repo, status, user, comm, revision=commit_id,
+                    repo, status, user, comment, revision=commit_id,
                     dont_allow_on_closed_pull_request=True
                 )
             except StatusChangeOnClosedPullRequestError:
@@ -1486,7 +1501,7 b' def comment_commit('
         return {
             'msg': (
                 'Commented on commit `%s` for repository `%s`' % (
-                    comm.revision, repo.repo_name)),
+                    comment.revision, repo.repo_name)),
             'status_change': status,
             'success': True,
         }
@@ -1867,6 +1882,11 b' def strip(request, apiuser, repoid, revi'
 
     try:
         ScmModel().strip(repo, revision, branch)
+        audit_logger.store_api(
+            'repo.commit.strip', action_data={'commit_id': revision},
+            repo=repo,
+            user=apiuser, commit=True)
+
         return {
             'msg': 'Stripped commit %s from repo `%s`' % (
                 revision, repo.repo_name),
@@ -1902,6 +1922,7 b' def get_repo_settings(request, apiuser, '
             "id": 237,
             "result": {
                 "extensions_largefiles": true,
+                "extensions_evolve": true,
                 "hooks_changegroup_push_logger": true,
                 "hooks_changegroup_repo_size": false,
                 "hooks_outgoing_pull_logger": true,
@@ -1985,3 +2006,65 b' def set_repo_settings(request, apiuser, '
 
     # Indicate success.
     return True
+
+
+@jsonrpc_method()
+def maintenance(request, apiuser, repoid):
+    """
+    Triggers a maintenance on the given repository.
+
+    This command can only be run using an |authtoken| with admin
+    rights to the specified repository. For more information,
+    see :ref:`config-token-ref`.
+
+    This command takes the following options:
+
+    :param apiuser: This is filled automatically from the |authtoken|.
+    :type apiuser: AuthUser
+    :param repoid: The repository name or repository ID.
+    :type repoid: str or int
+
+    Example output:
+
+    .. code-block:: bash
+
+      id : <id_given_in_input>
+      result : {
+        "msg": "executed maintenance command",
+        "executed_actions": [
+           <action_message>, <action_message2>...
+        ],
+        "repository": "<repository name>"
+      }
+      error :  null
+
+    Example error output:
+
+    .. code-block:: bash
+
+      id : <id_given_in_input>
+      result : null
+      error :  {
+        "Unable to execute maintenance on `<reponame>`"
+      }
+
+    """
+
+    repo = get_repo_or_error(repoid)
+    if not has_superadmin_permission(apiuser):
+        _perms = ('repository.admin',)
+        validate_repo_permissions(apiuser, repoid, repo, _perms)
+
+    try:
+        maintenance = repo_maintenance.RepoMaintenance()
+        executed_actions = maintenance.execute(repo)
+
+        return {
+            'msg': 'executed maintenance command',
+            'executed_actions': executed_actions,
+            'repository': repo.repo_name
+        }
+    except Exception:
+        log.exception("Exception occurred while trying to run maintenance")
+        raise JSONRPCError(
+            'Unable to execute maintenance on `%s`' % repo.repo_name)

rhodecode/api/views/repo_group_api.py

@@ -27,6 +27,7 b' from rhodecode.api.utils import ('
     has_superadmin_permission, Optional, OAttr, get_user_or_error,
     get_repo_group_or_error, get_perm_or_error, get_user_group_or_error,
     get_origin, validate_repo_group_permissions, validate_set_owner_permissions)
+from rhodecode.lib import audit_logger
 from rhodecode.lib.auth import (
     HasRepoGroupPermissionAnyApi, HasUserGroupPermissionAnyApi)
 from rhodecode.model.db import Session
@@ -222,6 +223,13 b' def create_repo_group('
             group_name=validated_group_name,
             group_description=schema_data['repo_group_name'],
             copy_permissions=schema_data['repo_group_copy_permissions'])
+        Session().flush()
+
+        repo_group_data = repo_group.get_api_data()
+        audit_logger.store_api(
+            'repo_group.create', action_data={'data': repo_group_data},
+            user=apiuser)
+
         Session().commit()
         return {
             'msg': 'Created new repo group `%s`' % validated_group_name,
@@ -310,8 +318,13 b' def update_repo_group('
         enable_locking=schema_data['repo_group_enable_locking'],
     )
 
+    old_data = repo_group.get_api_data()
     try:
         RepoGroupModel().update(repo_group, validated_updates)
+        audit_logger.store_api(
+            'repo_group.edit', action_data={'old_data': old_data},
+            user=apiuser)
+
         Session().commit()
         return {
             'msg': 'updated repository group ID:%s %s' % (
@@ -365,8 +378,12 b' def delete_repo_group(request, apiuser, '
         validate_repo_group_permissions(
             apiuser, repogroupid, repo_group, ('group.admin',))
 
+    old_data = repo_group.get_api_data()
     try:
         RepoGroupModel().delete(repo_group)
+        audit_logger.store_api(
+            'repo_group.delete', action_data={'old_data': old_data},
+            user=apiuser)
         Session().commit()
         return {
             'msg': 'deleted repo group ID:%s %s' %

rhodecode/api/views/user_api.py

@@ -20,14 +20,18 b''
 
 import logging
 
-from rhodecode.api import jsonrpc_method, JSONRPCError, JSONRPCForbidden
+from rhodecode.api import (
+    jsonrpc_method, JSONRPCError, JSONRPCForbidden, JSONRPCValidationError)
 from rhodecode.api.utils import (
     Optional, OAttr, has_superadmin_permission, get_user_or_error, store_update)
+from rhodecode.lib import audit_logger
 from rhodecode.lib.auth import AuthUser, PasswordGenerator
 from rhodecode.lib.exceptions import DefaultUserException
 from rhodecode.lib.utils2 import safe_int, str2bool
 from rhodecode.model.db import Session, User, Repository
 from rhodecode.model.user import UserModel
+from rhodecode.model import validation_schema
+from rhodecode.model.validation_schema.schemas import user_schema
 
 log = logging.getLogger(__name__)
 
@@ -237,20 +241,54 b' def create_user(request, apiuser, userna'
     if isinstance(create_repo_group, basestring):
         create_repo_group = str2bool(create_repo_group)
 
+    username = Optional.extract(username)
+    password = Optional.extract(password)
+    email = Optional.extract(email)
+    first_name = Optional.extract(firstname)
+    last_name = Optional.extract(lastname)
+    active = Optional.extract(active)
+    admin = Optional.extract(admin)
+    extern_type = Optional.extract(extern_type)
+    extern_name = Optional.extract(extern_name)
+
+    schema = user_schema.UserSchema().bind(
+        # user caller
+        user=apiuser)
+    try:
+        schema_data = schema.deserialize(dict(
+            username=username,
+            email=email,
+            password=password,
+            first_name=first_name,
+            last_name=last_name,
+            active=active,
+            admin=admin,
+            extern_type=extern_type,
+            extern_name=extern_name,
+            ))
+    except validation_schema.Invalid as err:
+        raise JSONRPCValidationError(colander_exc=err)
+
     try:
         user = UserModel().create_or_update(
-            username=Optional.extract(username),
-            password=Optional.extract(password),
-            email=Optional.extract(email),
-            firstname=Optional.extract(firstname),
-            lastname=Optional.extract(lastname),
-            active=Optional.extract(active),
-            admin=Optional.extract(admin),
-            extern_type=Optional.extract(extern_type),
-            extern_name=Optional.extract(extern_name),
+            username=schema_data['username'],
+            password=schema_data['password'],
+            email=schema_data['email'],
+            firstname=schema_data['first_name'],
+            lastname=schema_data['last_name'],
+            active=schema_data['active'],
+            admin=schema_data['admin'],
+            extern_type=schema_data['extern_type'],
+            extern_name=schema_data['extern_name'],
             force_password_change=Optional.extract(force_password_change),
             create_repo_group=create_repo_group
         )
+        Session().flush()
+        creation_data = user.get_api_data()
+        audit_logger.store_api(
+            'user.create', action_data={'data': creation_data},
+            user=apiuser)
+
         Session().commit()
         return {
             'msg': 'created new user `%s`' % username,
@@ -326,7 +364,7 b' def update_user(request, apiuser, userid'
         raise JSONRPCForbidden()
 
     user = get_user_or_error(userid)
-
+    old_data = user.get_api_data()
     # only non optional arguments will be stored in updates
     updates = {}
 
@@ -343,6 +381,9 b' def update_user(request, apiuser, userid'
         store_update(updates, extern_type, 'extern_type')
 
         user = UserModel().update_user(user, **updates)
+        audit_logger.store_api(
+            'user.edit', action_data={'old_data': old_data},
+            user=apiuser)
         Session().commit()
         return {
             'msg': 'updated user ID:%s %s' % (user.user_id, user.username),
@@ -405,9 +446,13 b' def delete_user(request, apiuser, userid'
         raise JSONRPCForbidden()
 
     user = get_user_or_error(userid)
-
+    old_data = user.get_api_data()
     try:
         UserModel().delete(userid)
+        audit_logger.store_api(
+            'user.delete', action_data={'old_data': old_data},
+            user=apiuser)
+
         Session().commit()
         return {
             'msg': 'deleted user ID:%s %s' % (user.user_id, user.username),

rhodecode/api/views/user_group_api.py

@@ -20,15 +20,19 b''
 
 import logging
 
-from rhodecode.api import jsonrpc_method, JSONRPCError, JSONRPCForbidden
+from rhodecode.api import (
+    jsonrpc_method, JSONRPCError, JSONRPCForbidden, JSONRPCValidationError)
 from rhodecode.api.utils import (
     Optional, OAttr, store_update, has_superadmin_permission, get_origin,
     get_user_or_error, get_user_group_or_error, get_perm_or_error)
+from rhodecode.lib import audit_logger
 from rhodecode.lib.auth import HasUserGroupPermissionAnyApi, HasPermissionAnyApi
 from rhodecode.lib.exceptions import UserGroupAssignedException
 from rhodecode.model.db import Session
 from rhodecode.model.scm import UserGroupList
 from rhodecode.model.user_group import UserGroupModel
+from rhodecode.model import validation_schema
+from rhodecode.model.validation_schema.schemas import user_group_schema
 
 log = logging.getLogger(__name__)
 
@@ -210,20 +214,41 b' def create_user_group('
     if UserGroupModel().get_by_name(group_name):
         raise JSONRPCError("user group `%s` already exist" % (group_name,))
 
-    try:
-        if isinstance(owner, Optional):
-            owner = apiuser.user_id
+    if isinstance(owner, Optional):
+        owner = apiuser.user_id
+
+    owner = get_user_or_error(owner)
+    active = Optional.extract(active)
+    description = Optional.extract(description)
 
-        owner = get_user_or_error(owner)
-        active = Optional.extract(active)
-        description = Optional.extract(description)
-        ug = UserGroupModel().create(
-            name=group_name, description=description, owner=owner,
-            active=active)
+    schema = user_group_schema.UserGroupSchema().bind(
+        # user caller
+        user=apiuser)
+    try:
+        schema_data = schema.deserialize(dict(
+            user_group_name=group_name,
+            user_group_description=description,
+            user_group_owner=owner.username,
+            user_group_active=active,
+            ))
+    except validation_schema.Invalid as err:
+        raise JSONRPCValidationError(colander_exc=err)
+
+    try:
+        user_group = UserGroupModel().create(
+            name=schema_data['user_group_name'],
+            description=schema_data['user_group_description'],
+            owner=owner,
+            active=schema_data['user_group_active'])
+        Session().flush()
+        creation_data = user_group.get_api_data()
+        audit_logger.store_api(
+            'user_group.create', action_data={'data': creation_data},
+            user=apiuser)
         Session().commit()
         return {
             'msg': 'created new user group `%s`' % group_name,
-            'user_group': ug.get_api_data()
+            'user_group': creation_data
         }
     except Exception:
         log.exception("Error occurred during creation of user group")
@@ -291,6 +316,7 b' def update_user_group(request, apiuser, '
     if not isinstance(owner, Optional):
         owner = get_user_or_error(owner)
 
+    old_data = user_group.get_api_data()
     updates = {}
     store_update(updates, group_name, 'users_group_name')
     store_update(updates, description, 'user_group_description')
@@ -298,6 +324,9 b' def update_user_group(request, apiuser, '
     store_update(updates, active, 'users_group_active')
     try:
         UserGroupModel().update(user_group, updates)
+        audit_logger.store_api(
+            'user_group.edit', action_data={'old_data': old_data},
+            user=apiuser)
         Session().commit()
         return {
             'msg': 'updated user group ID:%s %s' % (
@@ -359,8 +388,12 b' def delete_user_group(request, apiuser, '
             raise JSONRPCError(
                 'user group `%s` does not exist' % (usergroupid,))
 
+    old_data = user_group.get_api_data()
     try:
         UserGroupModel().delete(user_group)
+        audit_logger.store_api(
+            'user_group.delete', action_data={'old_data': old_data},
+            user=apiuser)
         Session().commit()
         return {
             'msg': 'deleted user group ID:%s %s' % (
@@ -438,6 +471,12 b' def add_user_to_user_group(request, apiu'
             user.username, user_group.users_group_name
         )
         msg = msg if success else 'User is already in that group'
+        if success:
+            user_data = user.get_api_data()
+            audit_logger.store_api(
+                'user_group.edit.member.add', action_data={'user': user_data},
+                user=apiuser)
+
         Session().commit()
 
         return {
@@ -501,6 +540,12 b' def remove_user_from_user_group(request,'
             user.username, user_group.users_group_name
         )
         msg = msg if success else "User wasn't in group"
+        if success:
+            user_data = user.get_api_data()
+            audit_logger.store_api(
+                'user_group.edit.member.delete', action_data={'user': user_data},
+                user=apiuser)
+
         Session().commit()
         return {'success': success, 'msg': msg}
     except Exception:

rhodecode/apps/__init__.py

@@ -0,0 +1,19 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2016-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/

rhodecode/apps/_base/__init__.py

@@ -24,8 +24,12 b' from pylons import tmpl_context as c'
 from pyramid.httpexceptions import HTTPFound
 
 from rhodecode.lib import helpers as h
-from rhodecode.lib.utils2 import StrictAttributeDict, safe_int
+from rhodecode.lib.utils import PartialRenderer
+from rhodecode.lib.utils2 import StrictAttributeDict, safe_int, datetime_to_time
+from rhodecode.lib.vcs.exceptions import RepositoryRequirementError
+from rhodecode.lib.ext_json import json
 from rhodecode.model import repo
+from rhodecode.model import repo_group
 from rhodecode.model.db import User
 from rhodecode.model.scm import ScmModel
 
@@ -36,6 +40,30 b" ADMIN_PREFIX = '/_admin'"
 STATIC_FILE_PREFIX = '/_static'
 
 
+def add_route_with_slash(config,name, pattern, **kw):
+    config.add_route(name, pattern, **kw)
+    if not pattern.endswith('/'):
+        config.add_route(name + '_slash', pattern + '/', **kw)
+
+
+def get_format_ref_id(repo):
+    """Returns a `repo` specific reference formatter function"""
+    if h.is_svn(repo):
+        return _format_ref_id_svn
+    else:
+        return _format_ref_id
+
+
+def _format_ref_id(name, raw_id):
+    """Default formatting of a given reference `name`"""
+    return name
+
+
+def _format_ref_id_svn(name, raw_id):
+    """Special way of formatting a reference for Subversion including path"""
+    return '%s@%s' % (name, raw_id)
+
+
 class TemplateArgs(StrictAttributeDict):
     pass
 
@@ -77,9 +105,14 b' class BaseAppView(object):'
                 raise HTTPFound(
                     self.request.route_path('my_account_password'))
 
-    def _get_local_tmpl_context(self):
+    def _get_local_tmpl_context(self, include_app_defaults=False):
         c = TemplateArgs()
         c.auth_user = self.request.user
+        if include_app_defaults:
+            # NOTE(marcink): after full pyramid migration include_app_defaults
+            # should be turned on by default
+            from rhodecode.lib.base import attach_context_attributes
+            attach_context_attributes(c, self.request, self.request.user.user_id)
         return c
 
     def _register_global_c(self, tmpl_args):
@@ -121,15 +154,106 b' class RepoAppView(BaseAppView):'
         self.db_repo_name = self.db_repo.repo_name
         self.db_repo_pull_requests = ScmModel().get_pull_requests(self.db_repo)
 
-    def _get_local_tmpl_context(self):
-        c = super(RepoAppView, self)._get_local_tmpl_context()
+    def _handle_missing_requirements(self, error):
+        log.error(
+            'Requirements are missing for repository %s: %s',
+            self.db_repo_name, error.message)
+
+    def _get_local_tmpl_context(self, include_app_defaults=False):
+        c = super(RepoAppView, self)._get_local_tmpl_context(
+            include_app_defaults=include_app_defaults)
+
         # register common vars for this type of view
         c.rhodecode_db_repo = self.db_repo
         c.repo_name = self.db_repo_name
         c.repository_pull_requests = self.db_repo_pull_requests
+
+        c.repository_requirements_missing = False
+        try:
+            self.rhodecode_vcs_repo = self.db_repo.scm_instance()
+        except RepositoryRequirementError as e:
+            c.repository_requirements_missing = True
+            self._handle_missing_requirements(e)
+
         return c
 
 
+class DataGridAppView(object):
+    """
+    Common class to have re-usable grid rendering components
+    """
+
+    def _extract_ordering(self, request, column_map=None):
+        column_map = column_map or {}
+        column_index = safe_int(request.GET.get('order[0][column]'))
+        order_dir = request.GET.get(
+            'order[0][dir]', 'desc')
+        order_by = request.GET.get(
+            'columns[%s][data][sort]' % column_index, 'name_raw')
+
+        # translate datatable to DB columns
+        order_by = column_map.get(order_by) or order_by
+
+        search_q = request.GET.get('search[value]')
+        return search_q, order_by, order_dir
+
+    def _extract_chunk(self, request):
+        start = safe_int(request.GET.get('start'), 0)
+        length = safe_int(request.GET.get('length'), 25)
+        draw = safe_int(request.GET.get('draw'))
+        return draw, start, length
+
+
+class BaseReferencesView(RepoAppView):
+    """
+    Base for reference view for branches, tags and bookmarks.
+    """
+    def load_default_context(self):
+        c = self._get_local_tmpl_context()
+
+        # TODO(marcink): remove repo_info and use c.rhodecode_db_repo instead
+        c.repo_info = self.db_repo
+
+        self._register_global_c(c)
+        return c
+
+    def load_refs_context(self, ref_items, partials_template):
+        _render = PartialRenderer(partials_template)
+        _data = []
+        pre_load = ["author", "date", "message"]
+
+        is_svn = h.is_svn(self.rhodecode_vcs_repo)
+        format_ref_id = get_format_ref_id(self.rhodecode_vcs_repo)
+
+        for ref_name, commit_id in ref_items:
+            commit = self.rhodecode_vcs_repo.get_commit(
+                commit_id=commit_id, pre_load=pre_load)
+
+            # TODO: johbo: Unify generation of reference links
+            use_commit_id = '/' in ref_name or is_svn
+            files_url = h.url(
+                'files_home',
+                repo_name=c.repo_name,
+                f_path=ref_name if is_svn else '',
+                revision=commit_id if use_commit_id else ref_name,
+                at=ref_name)
+
+            _data.append({
+                "name": _render('name', ref_name, files_url),
+                "name_raw": ref_name,
+                "date": _render('date', commit.date),
+                "date_raw": datetime_to_time(commit.date),
+                "author": _render('author', commit.author),
+                "commit": _render(
+                    'commit', commit.message, commit.raw_id, commit.idx),
+                "commit_raw": commit.idx,
+                "compare": _render(
+                    'compare', format_ref_id(ref_name, commit.raw_id)),
+            })
+        c.has_references = bool(_data)
+        c.data = json.dumps(_data)
+
+
 class RepoRoutePredicate(object):
     def __init__(self, val, config):
         self.val = val
@@ -140,11 +264,15 b' class RepoRoutePredicate(object):'
     phash = text
 
     def __call__(self, info, request):
+
+        if hasattr(request, 'vcs_call'):
+            # skip vcs calls
+            return
+
         repo_name = info['match']['repo_name']
         repo_model = repo.RepoModel()
         by_name_match = repo_model.get_by_repo_name(repo_name, cache=True)
-        # if we match quickly from database, short circuit the operation,
-        # and validate repo based on the type.
+
         if by_name_match:
             # register this as request object we can re-use later
             request.db_repo = by_name_match
@@ -158,6 +286,72 b' class RepoRoutePredicate(object):'
         return False
 
 
+class RepoTypeRoutePredicate(object):
+    def __init__(self, val, config):
+        self.val = val or ['hg', 'git', 'svn']
+
+    def text(self):
+        return 'repo_accepted_type = %s' % self.val
+
+    phash = text
+
+    def __call__(self, info, request):
+        if hasattr(request, 'vcs_call'):
+            # skip vcs calls
+            return
+
+        rhodecode_db_repo = request.db_repo
+
+        log.debug(
+            '%s checking repo type for %s in %s',
+            self.__class__.__name__, rhodecode_db_repo.repo_type, self.val)
+
+        if rhodecode_db_repo.repo_type in self.val:
+            return True
+        else:
+            log.warning('Current view is not supported for repo type:%s',
+                        rhodecode_db_repo.repo_type)
+            #
+            # h.flash(h.literal(
+            #     _('Action not supported for %s.' % rhodecode_repo.alias)),
+            #     category='warning')
+            # return redirect(
+            #     route_path('repo_summary', repo_name=cls.rhodecode_db_repo.repo_name))
+
+            return False
+
+
+class RepoGroupRoutePredicate(object):
+    def __init__(self, val, config):
+        self.val = val
+
+    def text(self):
+        return 'repo_group_route = %s' % self.val
+
+    phash = text
+
+    def __call__(self, info, request):
+        if hasattr(request, 'vcs_call'):
+            # skip vcs calls
+            return
+
+        repo_group_name = info['match']['repo_group_name']
+        repo_group_model = repo_group.RepoGroupModel()
+        by_name_match = repo_group_model.get_by_group_name(
+            repo_group_name, cache=True)
+
+        if by_name_match:
+            # register this as request object we can re-use later
+            request.db_repo_group = by_name_match
+            return True
+
+        return False
+
+
 def includeme(config):
     config.add_route_predicate(
         'repo_route', RepoRoutePredicate)
+    config.add_route_predicate(
+        'repo_accepted_types', RepoTypeRoutePredicate)
+    config.add_route_predicate(
+        'repo_group_route', RepoGroupRoutePredicate)

rhodecode/apps/admin/__init__.py

@@ -30,6 +30,20 b' def admin_routes(config):'
     """
 
     config.add_route(
+        name='admin_audit_logs',
+        pattern='/audit_logs')
+
+    config.add_route(
+        name='pull_requests_global_0',  # backward compat
+        pattern='/pull_requests/{pull_request_id:[0-9]+}')
+    config.add_route(
+        name='pull_requests_global_1',  # backward compat
+        pattern='/pull-requests/{pull_request_id:[0-9]+}')
+    config.add_route(
+        name='pull_requests_global',
+        pattern='/pull-request/{pull_request_id:[0-9]+}')
+
+    config.add_route(
         name='admin_settings_open_source',
         pattern='/settings/open_source')
     config.add_route(
@@ -50,6 +64,11 b' def admin_routes(config):'
         name='admin_settings_sessions_cleanup',
         pattern='/settings/sessions/cleanup')
 
+    # global permissions
+    config.add_route(
+        name='admin_permissions_ips',
+        pattern='/permissions/ips')
+
     # users admin
     config.add_route(
         name='users',
@@ -70,6 +89,28 b' def admin_routes(config):'
         name='edit_user_auth_tokens_delete',
         pattern='/users/{user_id:\d+}/edit/auth_tokens/delete')
 
+    # user emails
+    config.add_route(
+        name='edit_user_emails',
+        pattern='/users/{user_id:\d+}/edit/emails')
+    config.add_route(
+        name='edit_user_emails_add',
+        pattern='/users/{user_id:\d+}/edit/emails/new')
+    config.add_route(
+        name='edit_user_emails_delete',
+        pattern='/users/{user_id:\d+}/edit/emails/delete')
+
+    # user IPs
+    config.add_route(
+        name='edit_user_ips',
+        pattern='/users/{user_id:\d+}/edit/ips')
+    config.add_route(
+        name='edit_user_ips_add',
+        pattern='/users/{user_id:\d+}/edit/ips/new')
+    config.add_route(
+        name='edit_user_ips_delete',
+        pattern='/users/{user_id:\d+}/edit/ips/delete')
+
     # user groups management
     config.add_route(
         name='edit_user_groups_management',
@@ -93,6 +134,8 b' def includeme(config):'
     navigation_registry = NavigationRegistry(labs_active=labs_active)
     config.registry.registerUtility(navigation_registry)
 
+    # main admin routes
+    config.add_route(name='admin_home', pattern=ADMIN_PREFIX)
     config.include(admin_routes, route_prefix=ADMIN_PREFIX)
 
     # Scan module for configuration decorators.

rhodecode/apps/admin/tests/test_admin_users.py

@@ -20,7 +20,9 b''
 
 import pytest
 
-from rhodecode.model.db import User, UserApiKeys
+from rhodecode.model.db import User, UserApiKeys, UserEmailMap
+from rhodecode.model.meta import Session
+from rhodecode.model.user import UserModel
 
 from rhodecode.tests import (
     TestController, TEST_USER_REGULAR_LOGIN, assert_session_flash)
@@ -44,6 +46,20 b' def route_path(name, params=None, **kwar'
             ADMIN_PREFIX + '/users/{user_id}/edit/auth_tokens/new',
         'edit_user_auth_tokens_delete':
             ADMIN_PREFIX + '/users/{user_id}/edit/auth_tokens/delete',
+
+        'edit_user_emails':
+            ADMIN_PREFIX + '/users/{user_id}/edit/emails',
+        'edit_user_emails_add':
+            ADMIN_PREFIX + '/users/{user_id}/edit/emails/new',
+        'edit_user_emails_delete':
+            ADMIN_PREFIX + '/users/{user_id}/edit/emails/delete',
+
+        'edit_user_ips':
+            ADMIN_PREFIX + '/users/{user_id}/edit/ips',
+        'edit_user_ips_add':
+            ADMIN_PREFIX + '/users/{user_id}/edit/ips/new',
+        'edit_user_ips_delete':
+            ADMIN_PREFIX + '/users/{user_id}/edit/ips/delete',
     }[name].format(**kwargs)
 
     if params:
@@ -135,8 +151,131 b' class TestAdminUsersView(TestController)'
 
         response = self.app.post(
             route_path('edit_user_auth_tokens_delete', user_id=user_id),
-            {'del_auth_token': keys[0].api_key, 'csrf_token': self.csrf_token})
+            {'del_auth_token': keys[0].user_api_key_id,
+             'csrf_token': self.csrf_token})
 
         assert_session_flash(response, 'Auth token successfully deleted')
         keys = UserApiKeys.query().filter(UserApiKeys.user_id == user_id).all()
         assert 2 == len(keys)
+
+    def test_ips(self):
+        self.log_user()
+        user = User.get_by_username(TEST_USER_REGULAR_LOGIN)
+        response = self.app.get(route_path('edit_user_ips', user_id=user.user_id))
+        response.mustcontain('All IP addresses are allowed')
+
+    @pytest.mark.parametrize("test_name, ip, ip_range, failure", [
+        ('127/24', '127.0.0.1/24', '127.0.0.0 - 127.0.0.255', False),
+        ('10/32', '10.0.0.10/32', '10.0.0.10 - 10.0.0.10', False),
+        ('0/16', '0.0.0.0/16', '0.0.0.0 - 0.0.255.255', False),
+        ('0/8', '0.0.0.0/8', '0.0.0.0 - 0.255.255.255', False),
+        ('127_bad_mask', '127.0.0.1/99', '127.0.0.1 - 127.0.0.1', True),
+        ('127_bad_ip', 'foobar', 'foobar', True),
+    ])
+    def test_ips_add(self, user_util, test_name, ip, ip_range, failure):
+        self.log_user()
+        user = user_util.create_user(username=test_name)
+        user_id = user.user_id
+
+        response = self.app.post(
+            route_path('edit_user_ips_add', user_id=user_id),
+            params={'new_ip': ip, 'csrf_token': self.csrf_token})
+
+        if failure:
+            assert_session_flash(
+                response, 'Please enter a valid IPv4 or IpV6 address')
+            response = self.app.get(route_path('edit_user_ips', user_id=user_id))
+
+            response.mustcontain(no=[ip])
+            response.mustcontain(no=[ip_range])
+
+        else:
+            response = self.app.get(route_path('edit_user_ips', user_id=user_id))
+            response.mustcontain(ip)
+            response.mustcontain(ip_range)
+
+    def test_ips_delete(self, user_util):
+        self.log_user()
+        user = user_util.create_user()
+        user_id = user.user_id
+        ip = '127.0.0.1/32'
+        ip_range = '127.0.0.1 - 127.0.0.1'
+        new_ip = UserModel().add_extra_ip(user_id, ip)
+        Session().commit()
+        new_ip_id = new_ip.ip_id
+
+        response = self.app.get(route_path('edit_user_ips', user_id=user_id))
+        response.mustcontain(ip)
+        response.mustcontain(ip_range)
+
+        self.app.post(
+            route_path('edit_user_ips_delete', user_id=user_id),
+            params={'del_ip_id': new_ip_id, 'csrf_token': self.csrf_token})
+
+        response = self.app.get(route_path('edit_user_ips', user_id=user_id))
+        response.mustcontain('All IP addresses are allowed')
+        response.mustcontain(no=[ip])
+        response.mustcontain(no=[ip_range])
+
+    def test_emails(self):
+        self.log_user()
+        user = User.get_by_username(TEST_USER_REGULAR_LOGIN)
+        response = self.app.get(route_path('edit_user_emails', user_id=user.user_id))
+        response.mustcontain('No additional emails specified')
+
+    def test_emails_add(self, user_util):
+        self.log_user()
+        user = user_util.create_user()
+        user_id = user.user_id
+
+        self.app.post(
+            route_path('edit_user_emails_add', user_id=user_id),
+            params={'new_email': '[e-mail]',
+                    'csrf_token': self.csrf_token})
+
+        response = self.app.get(route_path('edit_user_emails', user_id=user_id))
+        response.mustcontain('[e-mail]')
+
+    def test_emails_add_existing_email(self, user_util, user_regular):
+        existing_email = user_regular.email
+
+        self.log_user()
+        user = user_util.create_user()
+        user_id = user.user_id
+
+        response = self.app.post(
+            route_path('edit_user_emails_add', user_id=user_id),
+            params={'new_email': existing_email,
+                    'csrf_token': self.csrf_token})
+        assert_session_flash(
+            response, 'This e-mail address is already taken')
+
+        response = self.app.get(route_path('edit_user_emails', user_id=user_id))
+        response.mustcontain(no=[existing_email])
+
+    def test_emails_delete(self, user_util):
+        self.log_user()
+        user = user_util.create_user()
+        user_id = user.user_id
+
+        self.app.post(
+            route_path('edit_user_emails_add', user_id=user_id),
+            params={'new_email': '[e-mail]',
+                    'csrf_token': self.csrf_token})
+
+        response = self.app.get(route_path('edit_user_emails', user_id=user_id))
+        response.mustcontain('[e-mail]')
+
+        user_email = UserEmailMap.query()\
+            .filter(UserEmailMap.email == '[e-mail]') \
+            .filter(UserEmailMap.user_id == user_id)\
+            .one()
+
+        del_email_id = user_email.email_id
+        self.app.post(
+            route_path('edit_user_emails_delete', user_id=user_id),
+            params={'del_email_id': del_email_id,
+                    'csrf_token': self.csrf_token})
+
+        response = self.app.get(route_path('edit_user_emails', user_id=user_id))
+        response.mustcontain(no=['[e-mail]'])
  No newline at end of file

rhodecode/apps/admin/views/open_source_licenses.py

@@ -21,7 +21,7 b''
 import collections
 import logging
 
-from pylons import tmpl_context as c
+
 from pyramid.view import view_config
 
 from rhodecode.apps._base import BaseAppView
@@ -34,15 +34,21 b' log = logging.getLogger(__name__)'
 
 class OpenSourceLicensesAdminSettingsView(BaseAppView):
 
+    def load_default_context(self):
+        c = self._get_local_tmpl_context()
+        self._register_global_c(c)
+        return c
+
     @LoginRequired()
     @HasPermissionAllDecorator('hg.admin')
     @view_config(
         route_name='admin_settings_open_source', request_method='GET',
         renderer='rhodecode:templates/admin/settings/settings.mako')
     def open_source_licenses(self):
+        c = self.load_default_context()
         c.active = 'open_source'
         c.navlist = navigation_list(self.request)
         c.opensource_licenses = collections.OrderedDict(
             sorted(read_opensource_licenses().items(), key=lambda t: t[0]))
 
-        return {}
+        return self._get_template_context(c)

rhodecode/apps/admin/views/sessions.py

@@ -20,7 +20,6 b''
 
 import logging
 
-from pylons import tmpl_context as c
 from pyramid.view import view_config
 from pyramid.httpexceptions import HTTPFound
 
@@ -37,6 +36,11 b' log = logging.getLogger(__name__)'
 
 
 class AdminSessionSettingsView(BaseAppView):
+    def load_default_context(self):
+        c = self._get_local_tmpl_context()
+
+        self._register_global_c(c)
+        return c
 
     @LoginRequired()
     @HasPermissionAllDecorator('hg.admin')
@@ -44,6 +48,8 b' class AdminSessionSettingsView(BaseAppVi'
         route_name='admin_settings_sessions', request_method='GET',
         renderer='rhodecode:templates/admin/settings/settings.mako')
     def settings_sessions(self):
+        c = self.load_default_context()
+
         c.active = 'sessions'
         c.navlist = navigation_list(self.request)
 
@@ -59,11 +65,11 b' class AdminSessionSettingsView(BaseAppVi'
         c.session_expired_count = c.session_model.get_expired_count(
             older_than_seconds)
 
-        return {}
+        return self._get_template_context(c)
 
     @LoginRequired()
+    @HasPermissionAllDecorator('hg.admin')
     @CSRFRequired()
-    @HasPermissionAllDecorator('hg.admin')
     @view_config(
         route_name='admin_settings_sessions_cleanup', request_method='POST')
     def settings_sessions_cleanup(self):

rhodecode/apps/admin/views/svn_config.py

@@ -33,8 +33,8 b' log = logging.getLogger(__name__)'
 class SvnConfigAdminSettingsView(BaseAppView):
 
     @LoginRequired()
+    @HasPermissionAllDecorator('hg.admin')
     @CSRFRequired()
-    @HasPermissionAllDecorator('hg.admin')
     @view_config(
         route_name='admin_settings_vcs_svn_generate_cfg',
         request_method='POST', renderer='json')

rhodecode/apps/admin/views/system_info.py

@@ -22,7 +22,6 b' import logging'
 import urllib2
 import packaging.version
 
-from pylons import tmpl_context as c
 from pyramid.view import view_config
 
 import rhodecode
@@ -39,6 +38,10 b' log = logging.getLogger(__name__)'
 
 
 class AdminSystemInfoSettingsView(BaseAppView):
+    def load_default_context(self):
+        c = self._get_local_tmpl_context()
+        self._register_global_c(c)
+        return c
 
     @staticmethod
     def get_update_data(update_url):
@@ -64,6 +67,7 b' class AdminSystemInfoSettingsView(BaseAp'
         renderer='rhodecode:templates/admin/settings/settings.mako')
     def settings_system_info(self):
         _ = self.request.translate
+        c = self.load_default_context()
 
         c.active = 'system'
         c.navlist = navigation_list(self.request)
@@ -106,6 +110,7 b' class AdminSystemInfoSettingsView(BaseAp'
             (_('RhodeCode Server IP'), val('server')['server_ip'], state('server')),
             (_('RhodeCode Server ID'), val('server')['server_id'], state('server')),
             (_('RhodeCode Configuration'), val('rhodecode_config')['path'], state('rhodecode_config')),
+            (_('RhodeCode Certificate'), val('rhodecode_config')['cert_path'], state('rhodecode_config')),
             (_('Workers'), val('rhodecode_config')['config']['server:main'].get('workers', '?'), state('rhodecode_config')),
             (_('Worker Type'), val('rhodecode_config')['config']['server:main'].get('worker_class', 'sync'), state('rhodecode_config')),
             ('', '', ''),  # spacer
@@ -163,7 +168,7 b' class AdminSystemInfoSettingsView(BaseAp'
             else:
                 self.request.session.flash(
                     'You are not allowed to do this', queue='warning')
-        return {}
+        return self._get_template_context(c)
 
     @LoginRequired()
     @HasPermissionAllDecorator('hg.admin')
@@ -172,6 +177,7 b' class AdminSystemInfoSettingsView(BaseAp'
         renderer='rhodecode:templates/admin/settings/settings_system_update.mako')
     def settings_system_info_check_update(self):
         _ = self.request.translate
+        c = self.load_default_context()
 
         update_url = self.get_update_url()
 
@@ -200,4 +206,4 b' class AdminSystemInfoSettingsView(BaseAp'
             c.should_upgrade = True
         c.important_notices = latest['general']
 
-        return {}
+        return self._get_template_context(c)

rhodecode/apps/admin/views/users.py

@@ -20,15 +20,16 b''
 
 import logging
 import datetime
+import formencode
 
 from pyramid.httpexceptions import HTTPFound
 from pyramid.view import view_config
 from sqlalchemy.sql.functions import coalesce
 
-from rhodecode.lib.helpers import Page
-from rhodecode_tools.lib.ext_json import json
+from rhodecode.apps._base import BaseAppView, DataGridAppView
 
-from rhodecode.apps._base import BaseAppView
+from rhodecode.lib import audit_logger
+from rhodecode.lib.ext_json import json
 from rhodecode.lib.auth import (
     LoginRequired, HasPermissionAllDecorator, CSRFRequired)
 from rhodecode.lib import helpers as h
@@ -37,13 +38,13 b' from rhodecode.lib.utils2 import safe_in'
 from rhodecode.model.auth_token import AuthTokenModel
 from rhodecode.model.user import UserModel
 from rhodecode.model.user_group import UserGroupModel
-from rhodecode.model.db import User, or_
+from rhodecode.model.db import User, or_, UserIpMap, UserEmailMap, UserApiKeys
 from rhodecode.model.meta import Session
 
 log = logging.getLogger(__name__)
 
 
-class AdminUsersView(BaseAppView):
+class AdminUsersView(BaseAppView, DataGridAppView):
     ALLOW_SCOPED_TOKENS = False
     """
     This view has alternative version inside EE, if modified please take a look
@@ -64,28 +65,6 b' class AdminUsersView(BaseAppView):'
             # is a pyramid view
             raise HTTPFound('/')
 
-    def _extract_ordering(self, request):
-        column_index = safe_int(request.GET.get('order[0][column]'))
-        order_dir = request.GET.get(
-            'order[0][dir]', 'desc')
-        order_by = request.GET.get(
-            'columns[%s][data][sort]' % column_index, 'name_raw')
-
-        # translate datatable to DB columns
-        order_by = {
-            'first_name': 'name',
-            'last_name': 'lastname',
-        }.get(order_by) or order_by
-
-        search_q = request.GET.get('search[value]')
-        return search_q, order_by, order_dir
-
-    def _extract_chunk(self, request):
-        start = safe_int(request.GET.get('start'), 0)
-        length = safe_int(request.GET.get('length'), 25)
-        draw = safe_int(request.GET.get('draw'))
-        return draw, start, length
-
     @HasPermissionAllDecorator('hg.admin')
     @view_config(
         route_name='users', request_method='GET',
@@ -97,8 +76,8 b' class AdminUsersView(BaseAppView):'
     @HasPermissionAllDecorator('hg.admin')
     @view_config(
         # renderer defined below
-        route_name='users_data', request_method='GET', renderer='json',
-        xhr=True)
+        route_name='users_data', request_method='GET',
+        renderer='json_ext', xhr=True)
     def users_list_data(self):
         draw, start, limit = self._extract_chunk(self.request)
         search_q, order_by, order_dir = self._extract_ordering(self.request)
@@ -149,8 +128,8 b' class AdminUsersView(BaseAppView):'
             users_data.append({
                 "username": h.gravatar_with_user(user.username),
                 "email": user.email,
-                "first_name": h.escape(user.name),
-                "last_name": h.escape(user.lastname),
+                "first_name": user.first_name,
+                "last_name": user.last_name,
                 "last_login": h.format_date(user.last_login),
                 "last_activity": h.format_date(user.last_activity),
                 "active": h.bool2icon(user.active),
@@ -216,15 +195,23 b' class AdminUsersView(BaseAppView):'
 
         user_id = self.request.matchdict.get('user_id')
         c.user = User.get_or_404(user_id, pyramid_exc=True)
+
         self._redirect_for_default_user(c.user.username)
 
+        user_data = c.user.get_api_data()
         lifetime = safe_int(self.request.POST.get('lifetime'), -1)
         description = self.request.POST.get('description')
         role = self.request.POST.get('role')
 
         token = AuthTokenModel().create(
             c.user.user_id, description, lifetime, role)
+        token_data = token.get_api_data()
+
         self.maybe_attach_token_scope(token)
+        audit_logger.store_web(
+            'user.edit.token.add', action_data={
+                'data': {'token': token_data, 'user': user_data}},
+            user=self._rhodecode_user, )
         Session().commit()
 
         h.flash(_("Auth token successfully created"), category='success')
@@ -242,11 +229,19 b' class AdminUsersView(BaseAppView):'
         user_id = self.request.matchdict.get('user_id')
         c.user = User.get_or_404(user_id, pyramid_exc=True)
         self._redirect_for_default_user(c.user.username)
+        user_data = c.user.get_api_data()
 
         del_auth_token = self.request.POST.get('del_auth_token')
 
         if del_auth_token:
+            token = UserApiKeys.get_or_404(del_auth_token, pyramid_exc=True)
+            token_data = token.get_api_data()
+
             AuthTokenModel().delete(del_auth_token, c.user.user_id)
+            audit_logger.store_web(
+                'user.edit.token.delete', action_data={
+                    'data': {'token': token_data, 'user': user_data}},
+                user=self._rhodecode_user,)
             Session().commit()
             h.flash(_("Auth token successfully deleted"), category='success')
 
@@ -255,6 +250,186 b' class AdminUsersView(BaseAppView):'
     @LoginRequired()
     @HasPermissionAllDecorator('hg.admin')
     @view_config(
+        route_name='edit_user_emails', request_method='GET',
+        renderer='rhodecode:templates/admin/users/user_edit.mako')
+    def emails(self):
+        _ = self.request.translate
+        c = self.load_default_context()
+
+        user_id = self.request.matchdict.get('user_id')
+        c.user = User.get_or_404(user_id, pyramid_exc=True)
+        self._redirect_for_default_user(c.user.username)
+
+        c.active = 'emails'
+        c.user_email_map = UserEmailMap.query() \
+            .filter(UserEmailMap.user == c.user).all()
+
+        return self._get_template_context(c)
+
+    @LoginRequired()
+    @HasPermissionAllDecorator('hg.admin')
+    @CSRFRequired()
+    @view_config(
+        route_name='edit_user_emails_add', request_method='POST')
+    def emails_add(self):
+        _ = self.request.translate
+        c = self.load_default_context()
+
+        user_id = self.request.matchdict.get('user_id')
+        c.user = User.get_or_404(user_id, pyramid_exc=True)
+        self._redirect_for_default_user(c.user.username)
+
+        email = self.request.POST.get('new_email')
+        user_data = c.user.get_api_data()
+        try:
+            UserModel().add_extra_email(c.user.user_id, email)
+            audit_logger.store_web(
+                'user.edit.email.add', action_data={'email': email, 'user': user_data},
+                user=self._rhodecode_user)
+            Session().commit()
+            h.flash(_("Added new email address `%s` for user account") % email,
+                    category='success')
+        except formencode.Invalid as error:
+            h.flash(h.escape(error.error_dict['email']), category='error')
+        except Exception:
+            log.exception("Exception during email saving")
+            h.flash(_('An error occurred during email saving'),
+                    category='error')
+        raise HTTPFound(h.route_path('edit_user_emails', user_id=user_id))
+
+    @LoginRequired()
+    @HasPermissionAllDecorator('hg.admin')
+    @CSRFRequired()
+    @view_config(
+        route_name='edit_user_emails_delete', request_method='POST')
+    def emails_delete(self):
+        _ = self.request.translate
+        c = self.load_default_context()
+
+        user_id = self.request.matchdict.get('user_id')
+        c.user = User.get_or_404(user_id, pyramid_exc=True)
+        self._redirect_for_default_user(c.user.username)
+
+        email_id = self.request.POST.get('del_email_id')
+        user_model = UserModel()
+
+        email = UserEmailMap.query().get(email_id).email
+        user_data = c.user.get_api_data()
+        user_model.delete_extra_email(c.user.user_id, email_id)
+        audit_logger.store_web(
+            'user.edit.email.delete', action_data={'email': email, 'user': user_data},
+            user=self._rhodecode_user)
+        Session().commit()
+        h.flash(_("Removed email address from user account"),
+                category='success')
+        raise HTTPFound(h.route_path('edit_user_emails', user_id=user_id))
+
+    @LoginRequired()
+    @HasPermissionAllDecorator('hg.admin')
+    @view_config(
+        route_name='edit_user_ips', request_method='GET',
+        renderer='rhodecode:templates/admin/users/user_edit.mako')
+    def ips(self):
+        _ = self.request.translate
+        c = self.load_default_context()
+
+        user_id = self.request.matchdict.get('user_id')
+        c.user = User.get_or_404(user_id, pyramid_exc=True)
+        self._redirect_for_default_user(c.user.username)
+
+        c.active = 'ips'
+        c.user_ip_map = UserIpMap.query() \
+            .filter(UserIpMap.user == c.user).all()
+
+        c.inherit_default_ips = c.user.inherit_default_permissions
+        c.default_user_ip_map = UserIpMap.query() \
+            .filter(UserIpMap.user == User.get_default_user()).all()
+
+        return self._get_template_context(c)
+
+    @LoginRequired()
+    @HasPermissionAllDecorator('hg.admin')
+    @CSRFRequired()
+    @view_config(
+        route_name='edit_user_ips_add', request_method='POST')
+    def ips_add(self):
+        _ = self.request.translate
+        c = self.load_default_context()
+
+        user_id = self.request.matchdict.get('user_id')
+        c.user = User.get_or_404(user_id, pyramid_exc=True)
+        # NOTE(marcink): this view is allowed for default users, as we can
+        # edit their IP white list
+
+        user_model = UserModel()
+        desc = self.request.POST.get('description')
+        try:
+            ip_list = user_model.parse_ip_range(
+                self.request.POST.get('new_ip'))
+        except Exception as e:
+            ip_list = []
+            log.exception("Exception during ip saving")
+            h.flash(_('An error occurred during ip saving:%s' % (e,)),
+                    category='error')
+        added = []
+        user_data = c.user.get_api_data()
+        for ip in ip_list:
+            try:
+                user_model.add_extra_ip(c.user.user_id, ip, desc)
+                audit_logger.store_web(
+                    'user.edit.ip.add', action_data={'ip': ip, 'user': user_data},
+                    user=self._rhodecode_user)
+                Session().commit()
+                added.append(ip)
+            except formencode.Invalid as error:
+                msg = error.error_dict['ip']
+                h.flash(msg, category='error')
+            except Exception:
+                log.exception("Exception during ip saving")
+                h.flash(_('An error occurred during ip saving'),
+                        category='error')
+        if added:
+            h.flash(
+                _("Added ips %s to user whitelist") % (', '.join(ip_list), ),
+                category='success')
+        if 'default_user' in self.request.POST:
+            # case for editing global IP list we do it for 'DEFAULT' user
+            raise HTTPFound(h.route_path('admin_permissions_ips'))
+        raise HTTPFound(h.route_path('edit_user_ips', user_id=user_id))
+
+    @LoginRequired()
+    @HasPermissionAllDecorator('hg.admin')
+    @CSRFRequired()
+    @view_config(
+        route_name='edit_user_ips_delete', request_method='POST')
+    def ips_delete(self):
+        _ = self.request.translate
+        c = self.load_default_context()
+
+        user_id = self.request.matchdict.get('user_id')
+        c.user = User.get_or_404(user_id, pyramid_exc=True)
+        # NOTE(marcink): this view is allowed for default users, as we can
+        # edit their IP white list
+
+        ip_id = self.request.POST.get('del_ip_id')
+        user_model = UserModel()
+        user_data = c.user.get_api_data()
+        ip = UserIpMap.query().get(ip_id).ip_addr
+        user_model.delete_extra_ip(c.user.user_id, ip_id)
+        audit_logger.store_web(
+            'user.edit.ip.delete', action_data={'ip': ip, 'user': user_data},
+            user=self._rhodecode_user)
+        Session().commit()
+        h.flash(_("Removed ip address from user whitelist"), category='success')
+
+        if 'default_user' in self.request.POST:
+            # case for editing global IP list we do it for 'DEFAULT' user
+            raise HTTPFound(h.route_path('admin_permissions_ips'))
+        raise HTTPFound(h.route_path('edit_user_ips', user_id=user_id))
+
+    @LoginRequired()
+    @HasPermissionAllDecorator('hg.admin')
+    @view_config(
         route_name='edit_user_groups_management', request_method='GET',
         renderer='rhodecode:templates/admin/users/user_edit.mako')
     def groups_management(self):
@@ -264,7 +439,8 b' class AdminUsersView(BaseAppView):'
         c.user = User.get_or_404(user_id, pyramid_exc=True)
         c.data = c.user.group_member
         self._redirect_for_default_user(c.user.username)
-        groups = [UserGroupModel.get_user_groups_as_dict(group.users_group) for group in c.user.group_member]
+        groups = [UserGroupModel.get_user_groups_as_dict(group.users_group)
+                  for group in c.user.group_member]
         c.groups = json.dumps(groups)
         c.active = 'groups'
 
@@ -272,6 +448,7 b' class AdminUsersView(BaseAppView):'
 
     @LoginRequired()
     @HasPermissionAllDecorator('hg.admin')
+    @CSRFRequired()
     @view_config(
         route_name='edit_user_groups_management_updates', request_method='POST')
     def groups_management_updates(self):
@@ -314,15 +491,15 b' class AdminUsersView(BaseAppView):'
         p = safe_int(self.request.GET.get('page', 1), 1)
 
         filter_term = self.request.GET.get('filter')
-        c.user_log = UserModel().get_user_log(c.user, filter_term)
+        user_log = UserModel().get_user_log(c.user, filter_term)
 
         def url_generator(**kw):
             if filter_term:
                 kw['filter'] = filter_term
             return self.request.current_route_path(_query=kw)
 
-        c.user_log = Page(c.user_log, page=p, items_per_page=10,
-                          url=url_generator)
+        c.audit_logs = h.Page(
+            user_log, page=p, items_per_page=10, url=url_generator)
         c.filter_term = filter_term
         return self._get_template_context(c)
 

rhodecode/apps/channelstream/views.py

@@ -30,8 +30,6 b' Channel Stream controller for rhodecode'
 import logging
 import uuid
 
-from pylons import tmpl_context as c
-from pyramid.settings import asbool
 from pyramid.view import view_config
 from webob.exc import HTTPBadRequest, HTTPForbidden, HTTPBadGateway
 
@@ -46,7 +44,6 b' from rhodecode.lib.channelstream import '
     update_history_from_logs,
     STATE_PUBLIC_KEYS)
 from rhodecode.lib.auth import NotAnonymous
-from rhodecode.lib.utils2 import str2bool
 
 log = logging.getLogger(__name__)
 
@@ -82,7 +79,7 b' class ChannelstreamView(object):'
             log.error('Incorrect permissions for requested channels')
             raise HTTPForbidden()
 
-        user = c.rhodecode_user
+        user = self._rhodecode_user
         if user.user_id:
             user_data = get_user_data(user.user_id)
         else:
@@ -95,7 +92,7 b' class ChannelstreamView(object):'
                 'display_name': None,
                 'display_link': None,
             }
-        user_data['permissions'] = c.rhodecode_user.permissions
+        user_data['permissions'] = self._rhodecode_user.permissions
         payload = {
             'username': user.username,
             'user_state': user_data,

rhodecode/apps/home/tests/test_home.py

@@ -18,31 +18,34 b''
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
-import json
 
-from mock import patch
 import pytest
-from pylons import tmpl_context as c
 
 import rhodecode
-from rhodecode.lib.utils import map_groups
-from rhodecode.model.db import Repository, User, RepoGroup
+from rhodecode.model.db import Repository
 from rhodecode.model.meta import Session
 from rhodecode.model.repo import RepoModel
 from rhodecode.model.repo_group import RepoGroupModel
 from rhodecode.model.settings import SettingsModel
-from rhodecode.tests import TestController, url, TEST_USER_ADMIN_LOGIN
+from rhodecode.tests import TestController
 from rhodecode.tests.fixture import Fixture
+from rhodecode.lib import helpers as h
+
+fixture = Fixture()
 
 
-fixture = Fixture()
+def route_path(name, **kwargs):
+    return {
+        'home': '/',
+        'repo_group_home': '/{repo_group_name}'
+    }[name].format(**kwargs)
 
 
 class TestHomeController(TestController):
 
     def test_index(self):
         self.log_user()
-        response = self.app.get(url(controller='home', action='index'))
+        response = self.app.get(route_path('home'))
         # if global permission is set
         response.mustcontain('Add Repository')
 
@@ -51,8 +54,10 b' class TestHomeController(TestController)'
             response.mustcontain('"name_raw": "%s"' % repo.repo_name)
 
     def test_index_contains_statics_with_ver(self):
+        from pylons import tmpl_context as c
+
         self.log_user()
-        response = self.app.get(url(controller='home', action='index'))
+        response = self.app.get(route_path('home'))
 
         rhodecode_version_hash = c.rhodecode_version_hash
         response.mustcontain('style.css?ver={0}'.format(rhodecode_version_hash))
@@ -60,7 +65,7 b' class TestHomeController(TestController)'
 
     def test_index_contains_backend_specific_details(self, backend):
         self.log_user()
-        response = self.app.get(url(controller='home', action='index'))
+        response = self.app.get(route_path('home'))
         tip = backend.repo.get_commit().raw_id
 
         # html in javascript variable:
@@ -72,17 +77,16 b' class TestHomeController(TestController)'
 
     def test_index_with_anonymous_access_disabled(self):
         with fixture.anon_access(False):
-            response = self.app.get(url(controller='home', action='index'),
-                                    status=302)
+            response = self.app.get(route_path('home'), status=302)
             assert 'login' in response.location
 
     def test_index_page_on_groups(self, autologin_user, repo_group):
-        response = self.app.get(url('repo_group_home', group_name='gr1'))
+        response = self.app.get(route_path('repo_group_home', repo_group_name='gr1'))
         response.mustcontain("gr1/repo_in_group")
 
     def test_index_page_on_group_with_trailing_slash(
             self, autologin_user, repo_group):
-        response = self.app.get(url('repo_group_home', group_name='gr1') + '/')
+        response = self.app.get(route_path('repo_group_home', repo_group_name='gr1') + '/')
         response.mustcontain("gr1/repo_in_group")
 
     @pytest.fixture(scope='class')
@@ -96,21 +100,19 b' class TestHomeController(TestController)'
             RepoGroupModel().delete(repo_group='gr1', force_delete=True)
             Session().commit()
 
-    def test_index_with_name_with_tags(self, autologin_user):
-        user = User.get_by_username('test_admin')
+    def test_index_with_name_with_tags(self, user_util, autologin_user):
+        user = user_util.create_user()
+        username = user.username
         user.name = '<img src="/image1" onload="alert(\'Hello, World!\');">'
-        user.lastname = (
-            '<img src="/image2" onload="alert(\'Hello, World!\');">')
+        user.lastname = '#"><img src=x onerror=prompt(document.cookie);>'
+
         Session().add(user)
         Session().commit()
+        user_util.create_repo(owner=username)
 
-        response = self.app.get(url(controller='home', action='index'))
-        response.mustcontain(
-            '&lt;img src=&#34;/image1&#34; onload=&#34;'
-            'alert(&#39;Hello, World!&#39;);&#34;&gt;')
-        response.mustcontain(
-            '&lt;img src=&#34;/image2&#34; onload=&#34;'
-            'alert(&#39;Hello, World!&#39;);&#34;&gt;')
+        response = self.app.get(route_path('home'))
+        response.mustcontain(h.html_escape(user.first_name))
+        response.mustcontain(h.html_escape(user.last_name))
 
     @pytest.mark.parametrize("name, state", [
         ('Disabled', False),
@@ -125,266 +127,8 b' class TestHomeController(TestController)'
         Session().commit()
         SettingsModel().invalidate_settings_cache()
 
-        response = self.app.get(url(controller='home', action='index'))
+        response = self.app.get(route_path('home'))
         if state is True:
             response.mustcontain(version_string)
         if state is False:
             response.mustcontain(no=[version_string])
-
-
-class TestUserAutocompleteData(TestController):
-    def test_returns_list_of_users(self, user_util):
-        self.log_user()
-        user = user_util.create_user(is_active=True)
-        user_name = user.username
-        response = self.app.get(
-            url(controller='home', action='user_autocomplete_data'),
-            headers={'X-REQUESTED-WITH': 'XMLHttpRequest', }, status=200)
-        result = json.loads(response.body)
-        values = [suggestion['value'] for suggestion in result['suggestions']]
-        assert user_name in values
-
-    def test_returns_inactive_users_when_active_flag_sent(self, user_util):
-        self.log_user()
-        user = user_util.create_user(is_active=False)
-        user_name = user.username
-        response = self.app.get(
-            url(controller='home', action='user_autocomplete_data',
-                user_groups='true', active='0'),
-            headers={'X-REQUESTED-WITH': 'XMLHttpRequest', }, status=200)
-        result = json.loads(response.body)
-        values = [suggestion['value'] for suggestion in result['suggestions']]
-        assert user_name in values
-
-    def test_returns_groups_when_user_groups_sent(self, user_util):
-        self.log_user()
-        group = user_util.create_user_group(user_groups_active=True)
-        group_name = group.users_group_name
-        response = self.app.get(
-            url(controller='home', action='user_autocomplete_data',
-                user_groups='true'),
-            headers={'X-REQUESTED-WITH': 'XMLHttpRequest', }, status=200)
-        result = json.loads(response.body)
-        values = [suggestion['value'] for suggestion in result['suggestions']]
-        assert group_name in values
-
-    def test_result_is_limited_when_query_is_sent(self):
-        self.log_user()
-        fake_result = [
-            {
-                'first_name': 'John',
-                'value_display': 'hello{} (John Smith)'.format(i),
-                'icon_link': '/images/user14.png',
-                'value': 'hello{}'.format(i),
-                'last_name': 'Smith',
-                'username': 'hello{}'.format(i),
-                'id': i,
-                'value_type': u'user'
-            }
-            for i in range(10)
-        ]
-        users_patcher = patch.object(
-            RepoModel, 'get_users', return_value=fake_result)
-        groups_patcher = patch.object(
-            RepoModel, 'get_user_groups', return_value=fake_result)
-
-        query = 'hello'
-        with users_patcher as users_mock, groups_patcher as groups_mock:
-            response = self.app.get(
-                url(controller='home', action='user_autocomplete_data',
-                    user_groups='true', query=query),
-                headers={'X-REQUESTED-WITH': 'XMLHttpRequest', }, status=200)
-
-        result = json.loads(response.body)
-        users_mock.assert_called_once_with(
-            name_contains=query, only_active=True)
-        groups_mock.assert_called_once_with(
-            name_contains=query, only_active=True)
-        assert len(result['suggestions']) == 20
-
-
-def assert_and_get_content(result):
-    repos = []
-    groups = []
-    commits = []
-    for data in result:
-        for data_item in data['children']:
-            assert data_item['id']
-            assert data_item['text']
-            assert data_item['url']
-            if data_item['type'] == 'repo':
-                repos.append(data_item)
-            elif data_item['type'] == 'group':
-                groups.append(data_item)
-            elif data_item['type'] == 'commit':
-                commits.append(data_item)
-            else:
-                raise Exception('invalid type %s' % data_item['type'])
-
-    return repos, groups, commits
-
-
-class TestGotoSwitcherData(TestController):
-    required_repos_with_groups = [
-        'abc',
-        'abc-fork',
-        'forks/abcd',
-        'abcd',
-        'abcde',
-        'a/abc',
-        'aa/abc',
-        'aaa/abc',
-        'aaaa/abc',
-        'repos_abc/aaa/abc',
-        'abc_repos/abc',
-        'abc_repos/abcd',
-        'xxx/xyz',
-        'forked-abc/a/abc'
-    ]
-
-    @pytest.fixture(autouse=True, scope='class')
-    def prepare(self, request, pylonsapp):
-        for repo_and_group in self.required_repos_with_groups:
-            # create structure of groups and return the last group
-
-            repo_group = map_groups(repo_and_group)
-
-            RepoModel()._create_repo(
-                repo_and_group, 'hg', 'test-ac', TEST_USER_ADMIN_LOGIN,
-                repo_group=getattr(repo_group, 'group_id', None))
-
-            Session().commit()
-
-        request.addfinalizer(self.cleanup)
-
-    def cleanup(self):
-        # first delete all repos
-        for repo_and_groups in self.required_repos_with_groups:
-            repo = Repository.get_by_repo_name(repo_and_groups)
-            if repo:
-                RepoModel().delete(repo)
-                Session().commit()
-
-        # then delete all empty groups
-        for repo_and_groups in self.required_repos_with_groups:
-            if '/' in repo_and_groups:
-                r_group = repo_and_groups.rsplit('/', 1)[0]
-                repo_group = RepoGroup.get_by_group_name(r_group)
-                if not repo_group:
-                    continue
-                parents = repo_group.parents
-                RepoGroupModel().delete(repo_group, force_delete=True)
-                Session().commit()
-
-                for el in reversed(parents):
-                    RepoGroupModel().delete(el, force_delete=True)
-                    Session().commit()
-
-    def test_returns_list_of_repos_and_groups(self):
-        self.log_user()
-
-        response = self.app.get(
-            url(controller='home', action='goto_switcher_data'),
-            headers={'X-REQUESTED-WITH': 'XMLHttpRequest', }, status=200)
-        result = json.loads(response.body)['results']
-
-        repos, groups, commits = assert_and_get_content(result)
-
-        assert len(repos) == len(Repository.get_all())
-        assert len(groups) == len(RepoGroup.get_all())
-        assert len(commits) == 0
-
-    def test_returns_list_of_repos_and_groups_filtered(self):
-        self.log_user()
-
-        response = self.app.get(
-            url(controller='home', action='goto_switcher_data'),
-            headers={'X-REQUESTED-WITH': 'XMLHttpRequest', },
-            params={'query': 'abc'}, status=200)
-        result = json.loads(response.body)['results']
-
-        repos, groups, commits = assert_and_get_content(result)
-
-        assert len(repos) == 13
-        assert len(groups) == 5
-        assert len(commits) == 0
-
-    def test_returns_list_of_properly_sorted_and_filtered(self):
-        self.log_user()
-
-        response = self.app.get(
-            url(controller='home', action='goto_switcher_data'),
-            headers={'X-REQUESTED-WITH': 'XMLHttpRequest', },
-            params={'query': 'abc'}, status=200)
-        result = json.loads(response.body)['results']
-
-        repos, groups, commits = assert_and_get_content(result)
-
-        test_repos = [x['text'] for x in repos[:4]]
-        assert ['abc', 'abcd', 'a/abc', 'abcde'] == test_repos
-
-        test_groups = [x['text'] for x in groups[:4]]
-        assert ['abc_repos', 'repos_abc',
-                'forked-abc', 'forked-abc/a'] == test_groups
-
-
-class TestRepoListData(TestController):
-    def test_returns_list_of_repos_and_groups(self, user_util):
-        self.log_user()
-
-        response = self.app.get(
-            url(controller='home', action='repo_list_data'),
-            headers={'X-REQUESTED-WITH': 'XMLHttpRequest', }, status=200)
-        result = json.loads(response.body)['results']
-
-        repos, groups, commits = assert_and_get_content(result)
-
-        assert len(repos) == len(Repository.get_all())
-        assert len(groups) == 0
-        assert len(commits) == 0
-
-    def test_returns_list_of_repos_and_groups_filtered(self):
-        self.log_user()
-
-        response = self.app.get(
-            url(controller='home', action='repo_list_data'),
-            headers={'X-REQUESTED-WITH': 'XMLHttpRequest', },
-            params={'query': 'vcs_test_git'}, status=200)
-        result = json.loads(response.body)['results']
-
-        repos, groups, commits = assert_and_get_content(result)
-
-        assert len(repos) == len(Repository.query().filter(
-            Repository.repo_name.ilike('%vcs_test_git%')).all())
-        assert len(groups) == 0
-        assert len(commits) == 0
-
-    def test_returns_list_of_repos_and_groups_filtered_with_type(self):
-        self.log_user()
-
-        response = self.app.get(
-            url(controller='home', action='repo_list_data'),
-            headers={'X-REQUESTED-WITH': 'XMLHttpRequest', },
-            params={'query': 'vcs_test_git', 'repo_type': 'git'}, status=200)
-        result = json.loads(response.body)['results']
-
-        repos, groups, commits = assert_and_get_content(result)
-
-        assert len(repos) == len(Repository.query().filter(
-            Repository.repo_name.ilike('%vcs_test_git%')).all())
-        assert len(groups) == 0
-        assert len(commits) == 0
-
-    def test_returns_list_of_repos_non_ascii_query(self):
-        self.log_user()
-        response = self.app.get(
-            url(controller='home', action='repo_list_data'),
-            headers={'X-REQUESTED-WITH': 'XMLHttpRequest', },
-            params={'query': 'ć_vcs_test_ą', 'repo_type': 'git'}, status=200)
-        result = json.loads(response.body)['results']
-
-        repos, groups, commits = assert_and_get_content(result)
-
-        assert len(repos) == 0
-        assert len(groups) == 0
-        assert len(commits) == 0

rhodecode/apps/login/views.py

@@ -25,7 +25,6 b' import formencode'
 import logging
 import urlparse
 
-from pylons import url
 from pyramid.httpexceptions import HTTPFound
 from pyramid.view import view_config
 from recaptcha.client.captcha import submit
@@ -34,6 +33,7 b' from rhodecode.apps._base import BaseApp'
 from rhodecode.authentication.base import authenticate, HTTP_TYPE
 from rhodecode.events import UserRegistered
 from rhodecode.lib import helpers as h
+from rhodecode.lib import audit_logger
 from rhodecode.lib.auth import (
     AuthUser, HasPermissionAnyDecorator, CSRFRequired)
 from rhodecode.lib.base import get_ip_addr
@@ -90,20 +90,21 b' def get_came_from(request):'
     came_from = safe_str(request.GET.get('came_from', ''))
     parsed = urlparse.urlparse(came_from)
     allowed_schemes = ['http', 'https']
+    default_came_from = h.route_path('home')
     if parsed.scheme and parsed.scheme not in allowed_schemes:
         log.error('Suspicious URL scheme detected %s for url %s' %
                   (parsed.scheme, parsed))
-        came_from = url('home')
+        came_from = default_came_from
     elif parsed.netloc and request.host != parsed.netloc:
         log.error('Suspicious NETLOC detected %s for url %s server url '
                   'is: %s' % (parsed.netloc, parsed, request.host))
-        came_from = url('home')
+        came_from = default_came_from
     elif any(bad_str in parsed.path for bad_str in ('\r', '\n')):
         log.error('Header injection detected `%s` for url %s server url ' %
                   (parsed.path, parsed))
-        came_from = url('home')
+        came_from = default_came_from
 
-    return came_from or url('home')
+    return came_from or default_came_from
 
 
 class LoginView(BaseAppView):
@@ -166,6 +167,15 b' class LoginView(BaseAppView):'
                 username=form_result['username'],
                 remember=form_result['remember'])
             log.debug('Redirecting to "%s" after login.', c.came_from)
+
+            audit_user = audit_logger.UserWrap(
+                username=self.request.params.get('username'),
+                ip_addr=self.request.remote_addr)
+            action_data = {'user_agent': self.request.user_agent}
+            audit_logger.store_web(
+                'user.login.success', action_data=action_data,
+                user=audit_user, commit=True)
+
             raise HTTPFound(c.came_from, headers=headers)
         except formencode.Invalid as errors:
             defaults = errors.value
@@ -176,6 +186,14 b' class LoginView(BaseAppView):'
                 'errors': errors.error_dict,
                 'defaults': defaults,
             })
+
+            audit_user = audit_logger.UserWrap(
+                username=self.request.params.get('username'),
+                ip_addr=self.request.remote_addr)
+            action_data = {'user_agent': self.request.user_agent}
+            audit_logger.store_web(
+                'user.login.failure', action_data=action_data,
+                user=audit_user, commit=True)
             return render_ctx
 
         except UserCreationError as e:
@@ -191,8 +209,13 b' class LoginView(BaseAppView):'
     def logout(self):
         auth_user = self._rhodecode_user
         log.info('Deleting session for user: `%s`', auth_user)
+
+        action_data = {'user_agent': self.request.user_agent}
+        audit_logger.store_web(
+            'user.logout', action_data=action_data,
+            user=auth_user, commit=True)
         self.session.delete()
-        return HTTPFound(url('home'))
+        return HTTPFound(h.route_path('home'))
 
     @HasPermissionAnyDecorator(
         'hg.admin', 'hg.register.auto_activate', 'hg.register.manual_activate')
@@ -338,6 +361,12 b' class LoginView(BaseAppView):'
                     form_result, password_reset_url)
                 # Display success message and redirect.
                 self.session.flash(msg, queue='success')
+
+                action_data = {'email': user_email,
+                               'user_agent': self.request.user_agent}
+                audit_logger.store_web(
+                    'user.password.reset_request', action_data=action_data,
+                    user=self._rhodecode_user, commit=True)
                 return HTTPFound(self.request.route_path('reset_password'))
 
             except formencode.Invalid as errors:

rhodecode/apps/my_account/__init__.py

@@ -41,12 +41,45 b' def includeme(config):'
         pattern=ADMIN_PREFIX + '/my_account/auth_tokens')
     config.add_route(
         name='my_account_auth_tokens_add',
-        pattern=ADMIN_PREFIX + '/my_account/auth_tokens/new',
-        )
+        pattern=ADMIN_PREFIX + '/my_account/auth_tokens/new')
     config.add_route(
         name='my_account_auth_tokens_delete',
-        pattern=ADMIN_PREFIX + '/my_account/auth_tokens/delete',
-        )
+        pattern=ADMIN_PREFIX + '/my_account/auth_tokens/delete')
+
+    config.add_route(
+        name='my_account_emails',
+        pattern=ADMIN_PREFIX + '/my_account/emails')
+    config.add_route(
+        name='my_account_emails_add',
+        pattern=ADMIN_PREFIX + '/my_account/emails/new')
+    config.add_route(
+        name='my_account_emails_delete',
+        pattern=ADMIN_PREFIX + '/my_account/emails/delete')
+
+    config.add_route(
+        name='my_account_repos',
+        pattern=ADMIN_PREFIX + '/my_account/repos')
+
+    config.add_route(
+        name='my_account_watched',
+        pattern=ADMIN_PREFIX + '/my_account/watched')
+
+    config.add_route(
+        name='my_account_perms',
+        pattern=ADMIN_PREFIX + '/my_account/perms')
+
+    config.add_route(
+        name='my_account_notifications',
+        pattern=ADMIN_PREFIX + '/my_account/notifications')
+
+    config.add_route(
+        name='my_account_notifications_toggle_visibility',
+        pattern=ADMIN_PREFIX + '/my_account/toggle_visibility')
+
+    # channelstream test
+    config.add_route(
+        name='my_account_notifications_test_channelstream',
+        pattern=ADMIN_PREFIX + '/my_account/test_channelstream')
 
     # Scan module for configuration decorators.
     config.scan()

rhodecode/apps/my_account/tests/test_my_account_auth_tokens.py

@@ -103,7 +103,7 b' class TestMyAccountAuthTokens(TestContro'
 
         response = self.app.post(
             route_path('my_account_auth_tokens_delete'),
-            {'del_auth_token': keys[0].api_key, 'csrf_token': self.csrf_token})
+            {'del_auth_token': keys[0].user_api_key_id, 'csrf_token': self.csrf_token})
         assert_session_flash(response, 'Auth token successfully deleted')
 
         user = User.get(user_id)

rhodecode/apps/my_account/tests/test_my_account_password.py

@@ -132,6 +132,7 b' class TestMyAccountPassword(TestControll'
         self.app.post(route_path('my_account_password'), form_data)
 
         response = self.app.get(route_path('home'))
-        new_password_hash = response.session['rhodecode_user']['password']
+        session = response.get_session_from_response()
+        new_password_hash = session['rhodecode_user']['password']
 
         assert old_password_hash != new_password_hash
  No newline at end of file

rhodecode/apps/my_account/views.py

@@ -19,18 +19,28 b''
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
 import logging
+import datetime
 
+import formencode
 from pyramid.httpexceptions import HTTPFound
 from pyramid.view import view_config
 
 from rhodecode.apps._base import BaseAppView
 from rhodecode import forms
+from rhodecode.lib import helpers as h
+from rhodecode.lib import audit_logger
+from rhodecode.lib.ext_json import json
 from rhodecode.lib.auth import LoginRequired, NotAnonymous, CSRFRequired
-from rhodecode.lib import helpers as h
+from rhodecode.lib.channelstream import channelstream_request, \
+    ChannelstreamException
 from rhodecode.lib.utils2 import safe_int, md5
 from rhodecode.model.auth_token import AuthTokenModel
+from rhodecode.model.db import (
+    Repository, UserEmailMap, UserApiKeys, UserFollowing, joinedload)
 from rhodecode.model.meta import Session
+from rhodecode.model.scm import RepoList
 from rhodecode.model.user import UserModel
+from rhodecode.model.repo import RepoModel
 from rhodecode.model.validation_schema.schemas import user_schema
 
 log = logging.getLogger(__name__)
@@ -158,7 +168,7 b' class MyAccountView(BaseAppView):'
     @NotAnonymous()
     @CSRFRequired()
     @view_config(
-        route_name='my_account_auth_tokens_add', request_method='POST')
+        route_name='my_account_auth_tokens_add', request_method='POST',)
     def my_account_auth_tokens_add(self):
         _ = self.request.translate
         c = self.load_default_context()
@@ -169,7 +179,13 b' class MyAccountView(BaseAppView):'
 
         token = AuthTokenModel().create(
             c.user.user_id, description, lifetime, role)
+        token_data = token.get_api_data()
+
         self.maybe_attach_token_scope(token)
+        audit_logger.store_web(
+            'user.edit.token.add', action_data={
+                'data': {'token': token_data, 'user': 'self'}},
+            user=self._rhodecode_user, )
         Session().commit()
 
         h.flash(_("Auth token successfully created"), category='success')
@@ -187,8 +203,197 b' class MyAccountView(BaseAppView):'
         del_auth_token = self.request.POST.get('del_auth_token')
 
         if del_auth_token:
+            token = UserApiKeys.get_or_404(del_auth_token, pyramid_exc=True)
+            token_data = token.get_api_data()
+
             AuthTokenModel().delete(del_auth_token, c.user.user_id)
+            audit_logger.store_web(
+                'user.edit.token.delete', action_data={
+                    'data': {'token': token_data, 'user': 'self'}},
+                user=self._rhodecode_user,)
             Session().commit()
             h.flash(_("Auth token successfully deleted"), category='success')
 
         return HTTPFound(h.route_path('my_account_auth_tokens'))
+
+    @LoginRequired()
+    @NotAnonymous()
+    @view_config(
+        route_name='my_account_emails', request_method='GET',
+        renderer='rhodecode:templates/admin/my_account/my_account.mako')
+    def my_account_emails(self):
+        _ = self.request.translate
+
+        c = self.load_default_context()
+        c.active = 'emails'
+
+        c.user_email_map = UserEmailMap.query()\
+            .filter(UserEmailMap.user == c.user).all()
+        return self._get_template_context(c)
+
+    @LoginRequired()
+    @NotAnonymous()
+    @CSRFRequired()
+    @view_config(
+        route_name='my_account_emails_add', request_method='POST')
+    def my_account_emails_add(self):
+        _ = self.request.translate
+        c = self.load_default_context()
+
+        email = self.request.POST.get('new_email')
+
+        try:
+            UserModel().add_extra_email(c.user.user_id, email)
+            audit_logger.store_web(
+                'user.edit.email.add', action_data={
+                    'data': {'email': email, 'user': 'self'}},
+                user=self._rhodecode_user,)
+
+            Session().commit()
+            h.flash(_("Added new email address `%s` for user account") % email,
+                    category='success')
+        except formencode.Invalid as error:
+            h.flash(h.escape(error.error_dict['email']), category='error')
+        except Exception:
+            log.exception("Exception in my_account_emails")
+            h.flash(_('An error occurred during email saving'),
+                    category='error')
+        return HTTPFound(h.route_path('my_account_emails'))
+
+    @LoginRequired()
+    @NotAnonymous()
+    @CSRFRequired()
+    @view_config(
+        route_name='my_account_emails_delete', request_method='POST')
+    def my_account_emails_delete(self):
+        _ = self.request.translate
+        c = self.load_default_context()
+
+        del_email_id = self.request.POST.get('del_email_id')
+        if del_email_id:
+            email = UserEmailMap.get_or_404(del_email_id, pyramid_exc=True).email
+            UserModel().delete_extra_email(c.user.user_id, del_email_id)
+            audit_logger.store_web(
+                'user.edit.email.delete', action_data={
+                    'data': {'email': email, 'user': 'self'}},
+                user=self._rhodecode_user,)
+            Session().commit()
+            h.flash(_("Email successfully deleted"),
+                    category='success')
+        return HTTPFound(h.route_path('my_account_emails'))
+
+    @LoginRequired()
+    @NotAnonymous()
+    @CSRFRequired()
+    @view_config(
+        route_name='my_account_notifications_test_channelstream',
+        request_method='POST', renderer='json_ext')
+    def my_account_notifications_test_channelstream(self):
+        message = 'Test message sent via Channelstream by user: {}, on {}'.format(
+            self._rhodecode_user.username, datetime.datetime.now())
+        payload = {
+            # 'channel': 'broadcast',
+            'type': 'message',
+            'timestamp': datetime.datetime.utcnow(),
+            'user': 'system',
+            'pm_users': [self._rhodecode_user.username],
+            'message': {
+                'message': message,
+                'level': 'info',
+                'topic': '/notifications'
+            }
+        }
+
+        registry = self.request.registry
+        rhodecode_plugins = getattr(registry, 'rhodecode_plugins', {})
+        channelstream_config = rhodecode_plugins.get('channelstream', {})
+
+        try:
+            channelstream_request(channelstream_config, [payload], '/message')
+        except ChannelstreamException as e:
+            log.exception('Failed to send channelstream data')
+            return {"response": 'ERROR: {}'.format(e.__class__.__name__)}
+        return {"response": 'Channelstream data sent. '
+                            'You should see a new live message now.'}
+
+    def _load_my_repos_data(self, watched=False):
+        if watched:
+            admin = False
+            follows_repos = Session().query(UserFollowing)\
+                .filter(UserFollowing.user_id == self._rhodecode_user.user_id)\
+                .options(joinedload(UserFollowing.follows_repository))\
+                .all()
+            repo_list = [x.follows_repository for x in follows_repos]
+        else:
+            admin = True
+            repo_list = Repository.get_all_repos(
+                user_id=self._rhodecode_user.user_id)
+            repo_list = RepoList(repo_list, perm_set=[
+                'repository.read', 'repository.write', 'repository.admin'])
+
+        repos_data = RepoModel().get_repos_as_dict(
+            repo_list=repo_list, admin=admin)
+        # json used to render the grid
+        return json.dumps(repos_data)
+
+    @LoginRequired()
+    @NotAnonymous()
+    @view_config(
+        route_name='my_account_repos', request_method='GET',
+        renderer='rhodecode:templates/admin/my_account/my_account.mako')
+    def my_account_repos(self):
+        c = self.load_default_context()
+        c.active = 'repos'
+
+        # json used to render the grid
+        c.data = self._load_my_repos_data()
+        return self._get_template_context(c)
+
+    @LoginRequired()
+    @NotAnonymous()
+    @view_config(
+        route_name='my_account_watched', request_method='GET',
+        renderer='rhodecode:templates/admin/my_account/my_account.mako')
+    def my_account_watched(self):
+        c = self.load_default_context()
+        c.active = 'watched'
+
+        # json used to render the grid
+        c.data = self._load_my_repos_data(watched=True)
+        return self._get_template_context(c)
+
+    @LoginRequired()
+    @NotAnonymous()
+    @view_config(
+        route_name='my_account_perms', request_method='GET',
+        renderer='rhodecode:templates/admin/my_account/my_account.mako')
+    def my_account_perms(self):
+        c = self.load_default_context()
+        c.active = 'perms'
+
+        c.perm_user = c.auth_user
+        return self._get_template_context(c)
+
+    @LoginRequired()
+    @NotAnonymous()
+    @view_config(
+        route_name='my_account_notifications', request_method='GET',
+        renderer='rhodecode:templates/admin/my_account/my_account.mako')
+    def my_notifications(self):
+        c = self.load_default_context()
+        c.active = 'notifications'
+
+        return self._get_template_context(c)
+
+    @LoginRequired()
+    @NotAnonymous()
+    @CSRFRequired()
+    @view_config(
+        route_name='my_account_notifications_toggle_visibility',
+        request_method='POST', renderer='json_ext')
+    def my_notifications_toggle_visibility(self):
+        user = self._rhodecode_db_user
+        new_status = not user.user_data.get('notification_status', True)
+        user.update_userdata(notification_status=new_status)
+        Session().commit()
+        return user.user_data['notification_status']
  No newline at end of file

rhodecode/apps/repository/__init__.py

@@ -17,30 +17,137 b''
 # This program is dual-licensed. If you wish to learn more about the
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
+from rhodecode.apps._base import add_route_with_slash
 
 
 def includeme(config):
 
+    # Summary
+    # NOTE(marcink): one additional route is defined in very bottom, catch
+    # all pattern
+    config.add_route(
+        name='repo_summary_explicit',
+        pattern='/{repo_name:.*?[^/]}/summary', repo_route=True)
+    config.add_route(
+        name='repo_summary_commits',
+        pattern='/{repo_name:.*?[^/]}/summary-commits', repo_route=True)
+
+    # repo commits
+    config.add_route(
+        name='repo_commit',
+        pattern='/{repo_name:.*?[^/]}/changeset/{commit_id}', repo_route=True)
+
+    # refs data
+    config.add_route(
+        name='repo_refs_data',
+        pattern='/{repo_name:.*?[^/]}/refs-data', repo_route=True)
+
+    config.add_route(
+        name='repo_refs_changelog_data',
+        pattern='/{repo_name:.*?[^/]}/refs-data-changelog', repo_route=True)
+
+    config.add_route(
+        name='repo_stats',
+        pattern='/{repo_name:.*?[^/]}/repo_stats/{commit_id}', repo_route=True)
+
+    # Tags
+    config.add_route(
+        name='tags_home',
+        pattern='/{repo_name:.*?[^/]}/tags', repo_route=True)
+
+    # Branches
+    config.add_route(
+        name='branches_home',
+        pattern='/{repo_name:.*?[^/]}/branches', repo_route=True)
+
+    config.add_route(
+        name='bookmarks_home',
+        pattern='/{repo_name:.*?[^/]}/bookmarks', repo_route=True)
+
+    # Pull Requests
+    config.add_route(
+        name='pullrequest_show',
+        pattern='/{repo_name:.*?[^/]}/pull-request/{pull_request_id}',
+        repo_route=True)
+
+    config.add_route(
+        name='pullrequest_show_all',
+        pattern='/{repo_name:.*?[^/]}/pull-request',
+        repo_route=True, repo_accepted_types=['hg', 'git'])
+
+    config.add_route(
+        name='pullrequest_show_all_data',
+        pattern='/{repo_name:.*?[^/]}/pull-request-data',
+        repo_route=True, repo_accepted_types=['hg', 'git'])
+
+    # Settings
+    config.add_route(
+        name='edit_repo',
+        pattern='/{repo_name:.*?[^/]}/settings', repo_route=True)
+
+    # Settings advanced
+    config.add_route(
+        name='edit_repo_advanced',
+        pattern='/{repo_name:.*?[^/]}/settings/advanced', repo_route=True)
+    config.add_route(
+        name='edit_repo_advanced_delete',
+        pattern='/{repo_name:.*?[^/]}/settings/advanced/delete', repo_route=True)
+    config.add_route(
+        name='edit_repo_advanced_locking',
+        pattern='/{repo_name:.*?[^/]}/settings/advanced/locking', repo_route=True)
+    config.add_route(
+        name='edit_repo_advanced_journal',
+        pattern='/{repo_name:.*?[^/]}/settings/advanced/journal', repo_route=True)
+    config.add_route(
+        name='edit_repo_advanced_fork',
+        pattern='/{repo_name:.*?[^/]}/settings/advanced/fork', repo_route=True)
+
+    # Caches
+    config.add_route(
+        name='edit_repo_caches',
+        pattern='/{repo_name:.*?[^/]}/settings/caches', repo_route=True)
+
+    # Permissions
+    config.add_route(
+        name='edit_repo_perms',
+        pattern='/{repo_name:.*?[^/]}/settings/permissions', repo_route=True)
+
+    # Repo Review Rules
+    config.add_route(
+        name='repo_reviewers',
+        pattern='/{repo_name:.*?[^/]}/settings/review/rules', repo_route=True)
+
+    config.add_route(
+        name='repo_default_reviewers_data',
+        pattern='/{repo_name:.*?[^/]}/settings/review/default-reviewers', repo_route=True)
+
+    # Maintenance
     config.add_route(
         name='repo_maintenance',
-        pattern='/{repo_name:.*?[^/]}/maintenance', repo_route=True)
+        pattern='/{repo_name:.*?[^/]}/settings/maintenance', repo_route=True)
 
     config.add_route(
         name='repo_maintenance_execute',
-        pattern='/{repo_name:.*?[^/]}/maintenance/execute', repo_route=True)
-
+        pattern='/{repo_name:.*?[^/]}/settings/maintenance/execute', repo_route=True)
 
     # Strip
     config.add_route(
         name='strip',
-        pattern='/{repo_name:.*?[^/]}/strip', repo_route=True)
+        pattern='/{repo_name:.*?[^/]}/settings/strip', repo_route=True)
 
     config.add_route(
         name='strip_check',
-        pattern='/{repo_name:.*?[^/]}/strip_check', repo_route=True)
+        pattern='/{repo_name:.*?[^/]}/settings/strip_check', repo_route=True)
 
     config.add_route(
         name='strip_execute',
-        pattern='/{repo_name:.*?[^/]}/strip_execute', repo_route=True)
+        pattern='/{repo_name:.*?[^/]}/settings/strip_execute', repo_route=True)
+
+    # NOTE(marcink): needs to be at the end for catch-all
+    add_route_with_slash(
+        config,
+        name='repo_summary',
+        pattern='/{repo_name:.*?[^/]}', repo_route=True)
+
     # Scan module for configuration decorators.
     config.scan()

rhodecode/apps/repository/tests/test_repo_bookmarks.py

@@ -18,24 +18,35 b''
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
+import pytest
 from rhodecode.model.db import Repository
-from rhodecode.tests import *
 
 
-class TestBookmarksController(TestController):
+def route_path(name, params=None, **kwargs):
+    import urllib
+
+    base_url = {
+        'bookmarks_home': '/{repo_name}/bookmarks',
+    }[name].format(**kwargs)
+
+    if params:
+        base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
+    return base_url
+
+
[e-mail]('autologin_user', 'app')
+class TestBookmarks(object):
 
     def test_index(self, backend):
-        self.log_user()
         if backend.alias == 'hg':
-            response = self.app.get(url(controller='bookmarks',
-                                        action='index',
-                                        repo_name=backend.repo_name))
+            response = self.app.get(
+                route_path('bookmarks_home', repo_name=backend.repo_name))
 
             repo = Repository.get_by_repo_name(backend.repo_name)
             for commit_id, obj_name in repo.scm_instance().bookmarks.items():
                 assert commit_id in response
                 assert obj_name in response
         else:
-            self.app.get(url(controller='bookmarks',
-                             action='index',
-                             repo_name=backend.repo_name), status=404)
  No newline at end of file
+            self.app.get(
+                route_path('bookmarks_home', repo_name=backend.repo_name),
+                status=404)

rhodecode/apps/repository/tests/test_repo_branches.py

@@ -18,17 +18,28 b''
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
+import pytest
 from rhodecode.model.db import Repository
-from rhodecode.tests import *
 
 
-class TestBranchesController(TestController):
+def route_path(name, params=None, **kwargs):
+    import urllib
+
+    base_url = {
+        'branches_home': '/{repo_name}/branches',
+    }[name].format(**kwargs)
+
+    if params:
+        base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
+    return base_url
+
+
[e-mail]('autologin_user', 'app')
+class TestBranchesController(object):
 
     def test_index(self, backend):
-        self.log_user()
-        response = self.app.get(url(controller='branches',
-                                    action='index',
-                                    repo_name=backend.repo_name))
+        response = self.app.get(
+            route_path('branches_home', repo_name=backend.repo_name))
 
         repo = Repository.get_by_repo_name(backend.repo_name)
 

rhodecode/apps/repository/tests/test_repo_summary.py

@@ -23,16 +23,16 b' import re'
 import mock
 import pytest
 
-from rhodecode.controllers import summary
+from rhodecode.apps.repository.views.repo_summary import RepoSummaryView
 from rhodecode.lib import helpers as h
 from rhodecode.lib.compat import OrderedDict
+from rhodecode.lib.utils2 import AttributeDict
 from rhodecode.lib.vcs.exceptions import RepositoryRequirementError
 from rhodecode.model.db import Repository
 from rhodecode.model.meta import Session
 from rhodecode.model.repo import RepoModel
 from rhodecode.model.scm import ScmModel
-from rhodecode.tests import (
-    TestController, url, HG_REPO, assert_session_flash)
+from rhodecode.tests import assert_session_flash
 from rhodecode.tests.fixture import Fixture
 from rhodecode.tests.utils import AssertResponse, repo_on_filesystem
 
@@ -40,14 +40,31 b' from rhodecode.tests.utils import Assert'
 fixture = Fixture()
 
 
-class TestSummaryController(TestController):
-    def test_index(self, backend):
-        self.log_user()
+def route_path(name, params=None, **kwargs):
+    import urllib
+
+    base_url = {
+        'repo_summary': '/{repo_name}',
+        'repo_stats': '/{repo_name}/repo_stats/{commit_id}',
+        'repo_refs_data': '/{repo_name}/refs-data',
+        'repo_refs_changelog_data': '/{repo_name}/refs-data-changelog'
+
+    }[name].format(**kwargs)
+
+    if params:
+        base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
+    return base_url
+
+
[e-mail]('app')
+class TestSummaryView(object):
+    def test_index(self, autologin_user, backend, http_host_only_stub):
         repo_id = backend.repo.repo_id
         repo_name = backend.repo_name
         with mock.patch('rhodecode.lib.helpers.is_svn_without_proxy',
                         return_value=False):
-            response = self.app.get(url('summary_home', repo_name=repo_name))
+            response = self.app.get(
+                route_path('repo_summary', repo_name=repo_name))
 
         # repo type
         response.mustcontain(
@@ -61,46 +78,47 b' class TestSummaryController(TestControll'
         # clone url...
         response.mustcontain(
             'id="clone_url" readonly="readonly"'
-            ' value="http://[e-mail]:80/%s"' % (repo_name, ))
+            ' value="http://test_admin@%s/%s"' % (http_host_only_stub, repo_name, ))
         response.mustcontain(
             'id="clone_url_id" readonly="readonly"'
-            ' value="http://[e-mail]:80/_%s"' % (repo_id, ))
+            ' value="http://test_admin@%s/_%s"' % (http_host_only_stub, repo_id, ))
 
-    def test_index_svn_without_proxy(self, backend_svn):
-        self.log_user()
+    def test_index_svn_without_proxy(
+            self, autologin_user, backend_svn, http_host_only_stub):
         repo_id = backend_svn.repo.repo_id
         repo_name = backend_svn.repo_name
-        response = self.app.get(url('summary_home', repo_name=repo_name))
+        response = self.app.get(route_path('repo_summary', repo_name=repo_name))
         # clone url...
         response.mustcontain(
             'id="clone_url" disabled'
-            ' value="http://[e-mail]:80/%s"' % (repo_name, ))
+            ' value="http://test_admin@%s/%s"' % (http_host_only_stub, repo_name, ))
         response.mustcontain(
             'id="clone_url_id" disabled'
-            ' value="http://[e-mail]:80/_%s"' % (repo_id, ))
+            ' value="http://test_admin@%s/_%s"' % (http_host_only_stub, repo_id, ))
 
-    def test_index_with_trailing_slash(self, autologin_user, backend):
+    def test_index_with_trailing_slash(
+            self, autologin_user, backend, http_host_only_stub):
+
         repo_id = backend.repo.repo_id
         repo_name = backend.repo_name
         with mock.patch('rhodecode.lib.helpers.is_svn_without_proxy',
                         return_value=False):
             response = self.app.get(
-                url('summary_home', repo_name=repo_name) + '/',
+                route_path('repo_summary', repo_name=repo_name) + '/',
                 status=200)
 
         # clone url...
         response.mustcontain(
             'id="clone_url" readonly="readonly"'
-            ' value="http://[e-mail]:80/%s"' % (repo_name, ))
+            ' value="http://test_admin@%s/%s"' % (http_host_only_stub, repo_name, ))
         response.mustcontain(
             'id="clone_url_id" readonly="readonly"'
-            ' value="http://[e-mail]:80/_%s"' % (repo_id, ))
+            ' value="http://test_admin@%s/_%s"' % (http_host_only_stub, repo_id, ))
 
-    def test_index_by_id(self, backend):
-        self.log_user()
+    def test_index_by_id(self, autologin_user, backend):
         repo_id = backend.repo.repo_id
-        response = self.app.get(url(
-            'summary_home', repo_name='_%s' % (repo_id,)))
+        response = self.app.get(
+            route_path('repo_summary', repo_name='_%s' % (repo_id,)))
 
         # repo type
         response.mustcontain(
@@ -111,10 +129,9 b' class TestSummaryController(TestControll'
             """<i class="icon-unlock-alt">"""
         )
 
-    def test_index_by_repo_having_id_path_in_name_hg(self):
-        self.log_user()
+    def test_index_by_repo_having_id_path_in_name_hg(self, autologin_user):
         fixture.create_repo(name='repo_1')
-        response = self.app.get(url('summary_home', repo_name='repo_1'))
+        response = self.app.get(route_path('repo_summary', repo_name='repo_1'))
 
         try:
             response.mustcontain("repo_1")
@@ -122,11 +139,11 b' class TestSummaryController(TestControll'
             RepoModel().delete(Repository.get_by_repo_name('repo_1'))
             Session().commit()
 
-    def test_index_with_anonymous_access_disabled(self):
-        with fixture.anon_access(False):
-            response = self.app.get(url('summary_home', repo_name=HG_REPO),
-                                    status=302)
-            assert 'login' in response.location
+    def test_index_with_anonymous_access_disabled(
+            self, backend, disable_anonymous_user):
+        response = self.app.get(
+            route_path('repo_summary', repo_name=backend.repo_name), status=302)
+        assert 'login' in response.location
 
     def _enable_stats(self, repo):
         r = Repository.get_by_repo_name(repo)
@@ -173,17 +190,15 b' class TestSummaryController(TestControll'
         },
     }
 
-    def test_repo_stats(self, backend, xhr_header):
-        self.log_user()
+    def test_repo_stats(self, autologin_user, backend, xhr_header):
         response = self.app.get(
-            url('repo_stats',
-                repo_name=backend.repo_name, commit_id='tip'),
+            route_path(
+                'repo_stats', repo_name=backend.repo_name, commit_id='tip'),
             extra_environ=xhr_header,
             status=200)
         assert re.match(r'6[\d\.]+ KiB', response.json['size'])
 
-    def test_repo_stats_code_stats_enabled(self, backend, xhr_header):
-        self.log_user()
+    def test_repo_stats_code_stats_enabled(self, autologin_user, backend, xhr_header):
         repo_name = backend.repo_name
 
         # codes stats
@@ -191,8 +206,8 b' class TestSummaryController(TestControll'
         ScmModel().mark_for_invalidation(repo_name)
 
         response = self.app.get(
-            url('repo_stats',
-                repo_name=backend.repo_name, commit_id='tip'),
+            route_path(
+                'repo_stats', repo_name=backend.repo_name, commit_id='tip'),
             extra_environ=xhr_header,
             status=200)
 
@@ -203,7 +218,7 b' class TestSummaryController(TestControll'
 
     def test_repo_refs_data(self, backend):
         response = self.app.get(
-            url('repo_refs_data', repo_name=backend.repo_name),
+            route_path('repo_refs_data', repo_name=backend.repo_name),
             status=200)
 
         # Ensure that there is the correct amount of items in the result
@@ -220,72 +235,68 b' class TestSummaryController(TestControll'
             Repository, 'scm_instance', side_effect=RepositoryRequirementError)
 
         with scm_patcher:
-            response = self.app.get(url('summary_home', repo_name=repo_name))
+            response = self.app.get(route_path('repo_summary', repo_name=repo_name))
         assert_response = AssertResponse(response)
         assert_response.element_contains(
             '.main .alert-warning strong', 'Missing requirements')
         assert_response.element_contains(
             '.main .alert-warning',
-            'These commits cannot be displayed, because this repository'
-            ' uses the Mercurial largefiles extension, which was not enabled.')
+            'Commits cannot be displayed, because this repository '
+            'uses one or more extensions, which was not enabled.')
 
     def test_missing_requirements_page_does_not_contains_switch_to(
-            self, backend):
-        self.log_user()
+            self, autologin_user, backend):
         repo_name = backend.repo_name
         scm_patcher = mock.patch.object(
             Repository, 'scm_instance', side_effect=RepositoryRequirementError)
 
         with scm_patcher:
-            response = self.app.get(url('summary_home', repo_name=repo_name))
+            response = self.app.get(route_path('repo_summary', repo_name=repo_name))
         response.mustcontain(no='Switch To')
 
 
[e-mail]('pylonsapp')
-class TestSwitcherReferenceData:
[e-mail]('app')
+class TestRepoLocation(object):
 
-    def test_creates_reference_urls_based_on_name(self):
-        references = {
-            'name': 'commit_id',
-        }
-        controller = summary.SummaryController()
-        is_svn = False
-        result = controller._switcher_reference_data(
-            'repo_name', references, is_svn)
-        expected_url = h.url(
-            'files_home', repo_name='repo_name', revision='name',
-            at='name')
-        assert result[0]['files_url'] == expected_url
+    @pytest.mark.parametrize("suffix", [u'', u'ąęł'], ids=['', 'non-ascii'])
+    def test_manual_delete(self, autologin_user, backend, suffix, csrf_token):
+        repo = backend.create_repo(name_suffix=suffix)
+        repo_name = repo.repo_name
+
+        # delete from file system
+        RepoModel()._delete_filesystem_repo(repo)
 
-    def test_urls_contain_commit_id_if_slash_in_name(self):
-        references = {
-            'name/with/slash': 'commit_id',
-        }
-        controller = summary.SummaryController()
-        is_svn = False
-        result = controller._switcher_reference_data(
-            'repo_name', references, is_svn)
-        expected_url = h.url(
-            'files_home', repo_name='repo_name', revision='commit_id',
-            at='name/with/slash')
-        assert result[0]['files_url'] == expected_url
+        # test if the repo is still in the database
+        new_repo = RepoModel().get_by_repo_name(repo_name)
+        assert new_repo.repo_name == repo_name
 
-    def test_adds_reference_to_path_for_svn(self):
-        references = {
-            'name/with/slash': 'commit_id',
-        }
-        controller = summary.SummaryController()
-        is_svn = True
-        result = controller._switcher_reference_data(
-            'repo_name', references, is_svn)
-        expected_url = h.url(
-            'files_home', repo_name='repo_name', f_path='name/with/slash',
-            revision='commit_id', at='name/with/slash')
-        assert result[0]['files_url'] == expected_url
+        # check if repo is not in the filesystem
+        assert not repo_on_filesystem(repo_name)
+        self.assert_repo_not_found_redirect(repo_name)
+
+    def assert_repo_not_found_redirect(self, repo_name):
+        # run the check page that triggers the other flash message
+        response = self.app.get(h.url('repo_check_home', repo_name=repo_name))
+        assert_session_flash(
+            response, 'The repository at %s cannot be located.' % repo_name)
 
 
[e-mail]('pylonsapp')
-class TestCreateReferenceData:
[e-mail]()
+def summary_view(context_stub, request_stub, user_util):
+    """
+    Bootstrap view to test the view functions
+    """
+    request_stub.matched_route = AttributeDict(name='test_view')
+
+    request_stub.user = user_util.create_user().AuthUser
+    request_stub.db_repo = user_util.create_repo()
+
+    view = RepoSummaryView(context=context_stub, request=request_stub)
+    return view
+
+
[e-mail]('app')
+class TestCreateReferenceData(object):
 
     @pytest.fixture
     def example_refs(self):
@@ -296,14 +307,13 b' class TestCreateReferenceData:'
         ]
         return example_refs
 
-    def test_generates_refs_based_on_commit_ids(self, example_refs):
+    def test_generates_refs_based_on_commit_ids(self, example_refs, summary_view):
         repo = mock.Mock()
         repo.name = 'test-repo'
         repo.alias = 'git'
         full_repo_name = 'pytest-repo-group/' + repo.name
-        controller = summary.SummaryController()
 
-        result = controller._create_reference_data(
+        result = summary_view._create_reference_data(
             repo, full_repo_name, example_refs)
 
         expected_files_url = '/{}/files/'.format(full_repo_name)
@@ -332,13 +342,13 b' class TestCreateReferenceData:'
             }]
         assert result == expected_result
 
-    def test_generates_refs_with_path_for_svn(self, example_refs):
+    def test_generates_refs_with_path_for_svn(self, example_refs, summary_view):
         repo = mock.Mock()
         repo.name = 'test-repo'
         repo.alias = 'svn'
         full_repo_name = 'pytest-repo-group/' + repo.name
-        controller = summary.SummaryController()
-        result = controller._create_reference_data(
+
+        result = summary_view._create_reference_data(
             repo, full_repo_name, example_refs)
 
         expected_files_url = '/{}/files/'.format(full_repo_name)
@@ -372,35 +382,9 b' class TestCreateReferenceData:'
         assert result == expected_result
 
 
[e-mail]("app")
-class TestRepoLocation:
-
-    @pytest.mark.parametrize("suffix", [u'', u'ąęł'], ids=['', 'non-ascii'])
-    def test_manual_delete(self, autologin_user, backend, suffix, csrf_token):
-        repo = backend.create_repo(name_suffix=suffix)
-        repo_name = repo.repo_name
-
-        # delete from file system
-        RepoModel()._delete_filesystem_repo(repo)
-
-        # test if the repo is still in the database
-        new_repo = RepoModel().get_by_repo_name(repo_name)
-        assert new_repo.repo_name == repo_name
+class TestCreateFilesUrl(object):
 
-        # check if repo is not in the filesystem
-        assert not repo_on_filesystem(repo_name)
-        self.assert_repo_not_found_redirect(repo_name)
-
-    def assert_repo_not_found_redirect(self, repo_name):
-        # run the check page that triggers the other flash message
-        response = self.app.get(url('repo_check_home', repo_name=repo_name))
-        assert_session_flash(
-            response, 'The repository at %s cannot be located.' % repo_name)
-
-
-class TestCreateFilesUrl(object):
-    def test_creates_non_svn_url(self):
-        controller = summary.SummaryController()
+    def test_creates_non_svn_url(self, summary_view):
         repo = mock.Mock()
         repo.name = 'abcde'
         full_repo_name = 'test-repo-group/' + repo.name
@@ -408,16 +392,15 b' class TestCreateFilesUrl(object):'
         raw_id = 'deadbeef0123456789'
         is_svn = False
 
-        with mock.patch.object(summary.h, 'url') as url_mock:
-            result = controller._create_files_url(
+        with mock.patch('rhodecode.lib.helpers.url') as url_mock:
+            result = summary_view._create_files_url(
                 repo, full_repo_name, ref_name, raw_id, is_svn)
         url_mock.assert_called_once_with(
             'files_home', repo_name=full_repo_name, f_path='',
             revision=ref_name, at=ref_name)
         assert result == url_mock.return_value
 
-    def test_creates_svn_url(self):
-        controller = summary.SummaryController()
+    def test_creates_svn_url(self, summary_view):
         repo = mock.Mock()
         repo.name = 'abcde'
         full_repo_name = 'test-repo-group/' + repo.name
@@ -425,16 +408,15 b' class TestCreateFilesUrl(object):'
         raw_id = 'deadbeef0123456789'
         is_svn = True
 
-        with mock.patch.object(summary.h, 'url') as url_mock:
-            result = controller._create_files_url(
+        with mock.patch('rhodecode.lib.helpers.url') as url_mock:
+            result = summary_view._create_files_url(
                 repo, full_repo_name, ref_name, raw_id, is_svn)
         url_mock.assert_called_once_with(
             'files_home', repo_name=full_repo_name, f_path=ref_name,
             revision=raw_id, at=ref_name)
         assert result == url_mock.return_value
 
-    def test_name_has_slashes(self):
-        controller = summary.SummaryController()
+    def test_name_has_slashes(self, summary_view):
         repo = mock.Mock()
         repo.name = 'abcde'
         full_repo_name = 'test-repo-group/' + repo.name
@@ -442,8 +424,8 b' class TestCreateFilesUrl(object):'
         raw_id = 'deadbeef0123456789'
         is_svn = False
 
-        with mock.patch.object(summary.h, 'url') as url_mock:
-            result = controller._create_files_url(
+        with mock.patch('rhodecode.lib.helpers.url') as url_mock:
+            result = summary_view._create_files_url(
                 repo, full_repo_name, ref_name, raw_id, is_svn)
         url_mock.assert_called_once_with(
             'files_home', repo_name=full_repo_name, f_path='', revision=raw_id,
@@ -462,42 +444,39 b' class TestReferenceItems(object):'
     def _format_function(name, id_):
         return 'format_function_{}_{}'.format(name, id_)
 
-    def test_creates_required_amount_of_items(self):
+    def test_creates_required_amount_of_items(self, summary_view):
         amount = 100
         refs = {
             'ref{}'.format(i): '{0:040d}'.format(i)
             for i in range(amount)
         }
 
-        controller = summary.SummaryController()
-
-        url_patcher = mock.patch.object(
-            controller, '_create_files_url')
-        svn_patcher = mock.patch.object(
-            summary.h, 'is_svn', return_value=False)
+        url_patcher = mock.patch.object(summary_view, '_create_files_url')
+        svn_patcher = mock.patch('rhodecode.lib.helpers.is_svn',
+                                 return_value=False)
 
         with url_patcher as url_mock, svn_patcher:
-            result = controller._create_reference_items(
+            result = summary_view._create_reference_items(
                 self.repo, self.repo_full_name, refs, self.ref_type,
                 self._format_function)
         assert len(result) == amount
         assert url_mock.call_count == amount
 
-    def test_single_item_details(self):
+    def test_single_item_details(self, summary_view):
         ref_name = 'ref1'
         ref_id = 'deadbeef'
         refs = {
             ref_name: ref_id
         }
 
-        controller = summary.SummaryController()
+        svn_patcher = mock.patch('rhodecode.lib.helpers.is_svn',
+                                 return_value=False)
+
         url_patcher = mock.patch.object(
-            controller, '_create_files_url', return_value=self.fake_url)
-        svn_patcher = mock.patch.object(
-            summary.h, 'is_svn', return_value=False)
+            summary_view, '_create_files_url', return_value=self.fake_url)
 
         with url_patcher as url_mock, svn_patcher:
-            result = controller._create_reference_items(
+            result = summary_view._create_reference_items(
                 self.repo, self.repo_full_name, refs, self.ref_type,
                 self._format_function)
 

rhodecode/apps/repository/tests/test_repo_tags.py

@@ -18,16 +18,27 b''
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
+import pytest
 from rhodecode.model.db import Repository
-from rhodecode.tests import *
 
 
-class TestTagsController(TestController):
+def route_path(name, params=None, **kwargs):
+    import urllib
+
+    base_url = {
+        'tags_home': '/{repo_name}/tags',
+    }[name].format(**kwargs)
+
+    if params:
+        base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
+    return base_url
+
+
[e-mail]('autologin_user', 'app')
+class TestTagsController(object):
     def test_index(self, backend):
-        self.log_user()
-        response = self.app.get(url(controller='tags',
-                                    action='index',
-                                    repo_name=backend.repo_name))
+        response = self.app.get(
+            route_path('tags_home', repo_name=backend.repo_name))
 
         repo = Repository.get_by_repo_name(backend.repo_name)
 

rhodecode/apps/repository/views/repo_maintainance.py

@@ -41,7 +41,6 b' class RepoMaintenanceView(RepoAppView):'
         return c
 
     @LoginRequired()
-    @NotAnonymous()
     @HasRepoPermissionAnyDecorator('repository.admin')
     @view_config(
         route_name='repo_maintenance', request_method='GET',
@@ -54,7 +53,6 b' class RepoMaintenanceView(RepoAppView):'
         return self._get_template_context(c)
 
     @LoginRequired()
-    @NotAnonymous()
     @HasRepoPermissionAnyDecorator('repository.admin')
     @view_config(
         route_name='repo_maintenance_execute', request_method='GET',

rhodecode/apps/repository/views/repo_strip.py

@@ -1,6 +1,6 b''
 # -*- coding: utf-8 -*-
 
-# Copyright (C) 2011-2017 RhodeCode GmbH
+# Copyright (C) 2017-2017 RhodeCode GmbH
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU Affero General Public License, version 3
@@ -22,9 +22,11 b' import logging'
 from pyramid.view import view_config
 
 from rhodecode.apps._base import RepoAppView
+from rhodecode.lib import audit_logger
+from rhodecode.lib import helpers as h
 from rhodecode.lib.auth import (LoginRequired, HasRepoPermissionAnyDecorator,
-    NotAnonymous)
-
+                                NotAnonymous, CSRFRequired)
+from rhodecode.lib.ext_json import json
 
 log = logging.getLogger(__name__)
 
@@ -40,7 +42,6 b' class StripView(RepoAppView):'
         return c
 
     @LoginRequired()
-    @NotAnonymous()
     @HasRepoPermissionAnyDecorator('repository.admin')
     @view_config(
         route_name='strip', request_method='GET',
@@ -53,41 +54,39 b' class StripView(RepoAppView):'
         return self._get_template_context(c)
 
     @LoginRequired()
-    @NotAnonymous()
     @HasRepoPermissionAnyDecorator('repository.admin')
+    @CSRFRequired()
     @view_config(
         route_name='strip_check', request_method='POST',
-        renderer='json', xhr=True
-    )
+        renderer='json', xhr=True)
     def strip_check(self):
         from rhodecode.lib.vcs.backends.base import EmptyCommit
         data = {}
         rp = self.request.POST
         for i in range(1, 11):
-            chset = 'changeset_id-%d'%(i,)
+            chset = 'changeset_id-%d' % (i,)
             check = rp.get(chset)
+
             if check:
                 data[i] = self.db_repo.get_changeset(rp[chset])
                 if isinstance(data[i], EmptyCommit):
-                    data[i] = {'rev': None, 'commit': rp[chset]}
+                    data[i] = {'rev': None, 'commit': h.escape(rp[chset])}
                 else:
-                    data[i] = {'rev': data[i].raw_id, 'branch': data[i].branch, 'author': data[i].author,
+                    data[i] = {'rev': data[i].raw_id, 'branch': data[i].branch,
+                               'author': data[i].author,
                                'comment': data[i].message}
             else:
                 break
         return data
 
     @LoginRequired()
-    @NotAnonymous()
     @HasRepoPermissionAnyDecorator('repository.admin')
+    @CSRFRequired()
     @view_config(
         route_name='strip_execute', request_method='POST',
-        renderer='json', xhr=True
-    )
+        renderer='json', xhr=True)
     def strip_execute(self):
-
         from rhodecode.model.scm import ScmModel
-        from rhodecode.lib.ext_json import json
 
         c = self.load_default_context()
         user = self._rhodecode_user
@@ -95,16 +94,23 b' class StripView(RepoAppView):'
         data = {}
         for idx in rp:
             commit = json.loads(rp[idx])
-            #If someone put two times the same branch
+            # If someone put two times the same branch
             if commit['branch'] in data.keys():
                 continue
             try:
-                ScmModel().strip(repo=c.repo_info,
-                          commit_id=commit['rev'], branch=commit['branch'])
-                log.info('Stripped commit %s from repo `%s` by %s' % (commit['rev'], c.repo_info.repo_name, user))
+                ScmModel().strip(
+                    repo=c.repo_info,
+                    commit_id=commit['rev'], branch=commit['branch'])
+                log.info('Stripped commit %s from repo `%s` by %s' % (
+                    commit['rev'], c.repo_info.repo_name, user))
                 data[commit['rev']] = True
-            except Exception, e:
+
+                audit_logger.store_web(
+                    'repo.commit.strip', action_data={'commit_id': commit['rev']},
+                    repo=self.db_repo, user=self._rhodecode_user, commit=True)
+
+            except Exception as e:
                 data[commit['rev']] = False
-                log.debug('Stripped commit %s from repo `%s` failed by %s, exeption %s' % (commit['rev'],
-                                                                            c.repo_info.repo_name, user, e.message))
+                log.debug('Stripped commit %s from repo `%s` failed by %s, exeption %s' % (
+                    commit['rev'], self.db_repo_name, user, e.message))
         return data

rhodecode/authentication/base.py

@@ -564,8 +564,6 b' def authenticate(username, password, env'
     for plugin in authn_registry.get_plugins_for_authentication():
         plugin.set_auth_type(auth_type)
         plugin.set_calling_scope_repo(acl_repo_name)
-        user = plugin.get_user(username)
-        display_user = user.username if user else username
 
         if headers_only and not plugin.is_headers_auth:
             log.debug('Auth type is for headers only and plugin `%s` is not '

rhodecode/authentication/plugins/auth_ldap.py

@@ -71,15 +71,17 b' class LdapSettingsSchema(AuthnPluginSett'
     host = colander.SchemaNode(
         colander.String(),
         default='',
-        description=_('Host of the LDAP Server \n'
-                      '(e.g., 192.168.2.154, or ldap-server.domain.com'),
+        description=_('Host[s] of the LDAP Server \n'
+                      '(e.g., 192.168.2.154, or ldap-server.domain.com.\n '
+                      'Multiple servers can be specified using commas'),
         preparer=strip_whitespace,
         title=_('LDAP Host'),
         widget='string')
     port = colander.SchemaNode(
         colander.Int(),
         default=389,
-        description=_('Custom port that the LDAP server is listening on. Default: 389'),
+        description=_('Custom port that the LDAP server is listening on. '
+                      'Default value is: 389'),
         preparer=strip_whitespace,
         title=_('Port'),
         validator=colander.Range(min=0, max=65536),
@@ -112,7 +114,9 b' class LdapSettingsSchema(AuthnPluginSett'
     tls_reqcert = colander.SchemaNode(
         colander.String(),
         default=tls_reqcert_choices[0],
-        description=_('Require Cert over TLS?'),
+        description=_('Require Cert over TLS?. Self-signed and custom '
+                      'certificates can be used when\n `RhodeCode Certificate` '
+                      'found in admin > settings > system info page is extended.'),
         title=_('Certificate Checks'),
         validator=colander.OneOf(tls_reqcert_choices),
         widget='select')

rhodecode/config/licenses.json

@@ -1,11 +1,11 b''
 {
-  "nodejs-4.3.1": {
+  "libnghttp2-1.7.1": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
-  "postgresql-9.5.1": {
-    "PostgreSQL License": "http://spdx.org/licenses/PostgreSQL"
-  }, 
-  "python-2.7.11": {
+  "nodejs-4.3.1": {
+    "MIT License": "http://spdx.org/licenses/MIT"
+  },
+  "python-2.7.12": {
     "Python Software Foundation License version 2": "http://spdx.org/licenses/Python-2.0"
   }, 
   "python2.7-Babel-1.3": {
@@ -14,19 +14,25 b''
   "python2.7-Beaker-1.7.0": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
+  "python2.7-Chameleon-2.24": {
+    "BSD-like": "http://repoze.org/license.html"
+  },
   "python2.7-FormEncode-1.2.4": {
     "Python Software Foundation License version 2": "http://spdx.org/licenses/Python-2.0"
   }, 
-  "python2.7-Mako-1.0.1": {
+  "python2.7-Jinja2-2.7.3": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
+  "python2.7-Mako-1.0.6": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
-  "python2.7-Markdown-2.6.2": {
+  "python2.7-Markdown-2.6.7": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
   "python2.7-MarkupSafe-0.23": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
-  "python2.7-Paste-2.0.2": {
+  "python2.7-Paste-2.0.3": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
   "python2.7-PasteDeploy-1.5.2": {
@@ -35,12 +41,12 b''
   "python2.7-PasteScript-1.7.5": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
-  "python2.7-Pygments-2.0.2": {
+  "python2.7-Pygments-2.2.0": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
-  "python2.7-Pylons-1.0.1-patch1": {
+  "python2.7-Pylons-1.0.2.rhodecode-patch1": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
-  },
+  }, 
   "python2.7-Routes-1.13": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
@@ -65,7 +71,7 b''
   "python2.7-WebOb-1.3.1": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
-  "python2.7-Whoosh-2.7.0": {
+  "python2.7-Whoosh-2.7.4": {
     "BSD 2-clause \"Simplified\" License": "http://spdx.org/licenses/BSD-2-Clause", 
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
@@ -87,9 +93,18 b''
   "python2.7-backport-ipaddress-0.1": {
     "Python Software Foundation License version 2": "http://spdx.org/licenses/Python-2.0"
   }, 
+  "python2.7-backports.shutil-get-terminal-size-1.0.0": {
+    "MIT License": "http://spdx.org/licenses/MIT"
+  }, 
+  "python2.7-bleach-1.5.0": {
+    "Apache License 2.0": "http://spdx.org/licenses/Apache-2.0"
+  }, 
   "python2.7-celery-2.2.10": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
+  "python2.7-channelstream-0.5.2": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
   "python2.7-click-5.1": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
@@ -99,82 +114,169 b''
   "python2.7-configobj-5.0.6": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
-  "python2.7-cssselect-0.9.1": {
+  "python2.7-configparser-3.5.0": {
+    "MIT License": "http://spdx.org/licenses/MIT"
+  }, 
+  "python2.7-cssselect-1.0.1": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
-  "python2.7-decorator-3.4.2": {
+  "python2.7-decorator-4.0.11": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
+  "python2.7-deform-2.0a2": {
+    "BSD-derived": "http://www.repoze.org/LICENSE.txt"
+  }, 
   "python2.7-docutils-0.12": {
     "BSD 2-clause \"Simplified\" License": "http://spdx.org/licenses/BSD-2-Clause"
   }, 
+  "python2.7-dogpile.cache-0.6.1": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
+  "python2.7-dogpile.core-0.4.1": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
   "python2.7-elasticsearch-2.3.0": {
     "Apache License 2.0": "http://spdx.org/licenses/Apache-2.0"
   }, 
-  "python2.7-elasticsearch-dsl-2.0.0": {
+  "python2.7-elasticsearch-dsl-2.2.0": {
     "Apache License 2.0": "http://spdx.org/licenses/Apache-2.0"
   }, 
+  "python2.7-entrypoints-0.2.2": {
+    "MIT License": "http://spdx.org/licenses/MIT"
+  }, 
+  "python2.7-enum34-1.1.6": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
+  "python2.7-functools32-3.2.3.post2": {
+    "Python Software Foundation License version 2": "http://spdx.org/licenses/Python-2.0"
+  }, 
   "python2.7-future-0.14.3": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
   "python2.7-futures-3.0.2": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
+  "python2.7-gevent-1.1.2": {
+    "MIT License": "http://spdx.org/licenses/MIT"
+  }, 
   "python2.7-gnureadline-6.3.3": {
     "GNU General Public License v1.0 only": "http://spdx.org/licenses/GPL-1.0"
   }, 
+  "python2.7-gprof2dot-2016.10.13": {
+    "GNU Lesser General Public License v3.0 or later": "http://spdx.org/licenses/LGPL-3.0+"
+  }, 
+  "python2.7-greenlet-0.4.10": {
+    "MIT License": "http://spdx.org/licenses/MIT"
+  }, 
   "python2.7-gunicorn-19.6.0": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
+  "python2.7-html5lib-0.9999999": {
+    "MIT License": "http://spdx.org/licenses/MIT"
+  }, 
   "python2.7-infrae.cache-1.0.1": {
     "Zope Public License 2.1": "http://spdx.org/licenses/ZPL-2.1"
   }, 
-  "python2.7-ipython-3.1.0": {
+  "python2.7-ipython-5.1.0": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
+  "python2.7-ipython-genutils-0.2.0": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
   "python2.7-iso8601-0.1.11": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
+  "python2.7-itsdangerous-0.24": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
+  "python2.7-jsonschema-2.6.0": {
+    "MIT License": "http://spdx.org/licenses/MIT"
+  }, 
+  "python2.7-jupyter-client-5.0.0": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
+  "python2.7-jupyter-core-4.3.0": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
   "python2.7-kombu-1.5.1": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
-  "python2.7-msgpack-python-0.4.6": {
+  "python2.7-mistune-0.7.4": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
+  "python2.7-msgpack-python-0.4.8": {
     "Apache License 2.0": "http://spdx.org/licenses/Apache-2.0"
   }, 
+  "python2.7-nbconvert-5.1.1": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
+  "python2.7-nbformat-4.3.0": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
   "python2.7-packaging-15.2": {
     "Apache License 2.0": "http://spdx.org/licenses/Apache-2.0"
   }, 
-  "python2.7-psutil-2.2.1": {
+  "python2.7-pandocfilters-1.4.1": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
-  "python2.7-psycopg2-2.6": {
+  "python2.7-pathlib2-2.1.0": {
+    "MIT License": "http://spdx.org/licenses/MIT"
+  }, 
+  "python2.7-peppercorn-0.5": {
+    "BSD-derived": "http://www.repoze.org/LICENSE.txt"
+  }, 
+  "python2.7-pexpect-4.2.1": {
+    "ISC License": "http://spdx.org/licenses/ISC"
+  }, 
+  "python2.7-pickleshare-0.7.4": {
+    "MIT License": "http://spdx.org/licenses/MIT"
+  }, 
+  "python2.7-prompt-toolkit-1.0.14": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
+  "python2.7-psutil-4.3.1": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
+  "python2.7-psycopg2-2.6.1": {
     "GNU Lesser General Public License v3.0 or later": "http://spdx.org/licenses/LGPL-3.0+"
   }, 
-  "python2.7-py-1.4.29": {
+  "python2.7-ptyprocess-0.5.1": {
+    "ISC License": "http://opensource.org/licenses/ISC"
+  },
+  "python2.7-py-1.4.31": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
   "python2.7-py-bcrypt-0.4": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
   }, 
+  "python2.7-py-gfm-0.1.3.rhodecode-upstream1": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
   "python2.7-pycrypto-2.6.1": {
     "Public Domain": null
   }, 
   "python2.7-pycurl-7.19.5": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
+  "python2.7-pygments-markdown-lexer-0.1.0.dev39": {
+    "Apache License 2.0": "http://spdx.org/licenses/Apache-2.0"
+  }, 
   "python2.7-pyparsing-1.5.7": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
-  "python2.7-pyramid-1.6.1": {
+  "python2.7-pyramid-1.7.4": {
     "Repoze License": "http://www.repoze.org/LICENSE.txt"
   }, 
   "python2.7-pyramid-beaker-0.8": {
     "Repoze License": "http://www.repoze.org/LICENSE.txt"
   }, 
-  "python2.7-pyramid-debugtoolbar-2.4.2": {
+  "python2.7-pyramid-debugtoolbar-3.0.5": {
     "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause", 
     "Repoze License": "http://www.repoze.org/LICENSE.txt"
   }, 
+  "python2.7-pyramid-jinja2-2.5": {
+    "BSD-derived": "http://www.repoze.org/LICENSE.txt"
+  }, 
   "python2.7-pyramid-mako-1.0.2": {
     "Repoze License": "http://www.repoze.org/LICENSE.txt"
   }, 
@@ -182,16 +284,25 b''
     "libpng License": "http://spdx.org/licenses/Libpng", 
     "zlib License": "http://spdx.org/licenses/Zlib"
   }, 
-  "python2.7-pytest-2.8.5": {
+  "python2.7-pytest-3.0.5": {
+    "MIT License": "http://spdx.org/licenses/MIT"
+  }, 
+  "python2.7-pytest-profiling-1.2.2": {
+    "MIT License": "http://spdx.org/licenses/MIT"
+  }, 
+  "python2.7-pytest-runner-2.9": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
-  "python2.7-pytest-runner-2.7.1": {
+  "python2.7-pytest-sugar-0.7.1": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
+  "python2.7-pytest-timeout-1.2.0": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
-  "python2.7-python-dateutil-1.5": {
-    "Python Software Foundation License version 2": "http://spdx.org/licenses/Python-2.0"
+  "python2.7-python-dateutil-2.1": {
+    "Simplified BSD": null
   }, 
-  "python2.7-python-editor-1.0.1": {
+  "python2.7-python-editor-1.0.3": {
     "Apache License 2.0": "http://spdx.org/licenses/Apache-2.0"
   }, 
   "python2.7-python-ldap-2.4.19": {
@@ -203,6 +314,9 b''
   "python2.7-pytz-2015.4": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
+  "python2.7-pyzmq-14.6.0": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  },
   "python2.7-recaptcha-client-1.0.6": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
@@ -211,21 +325,35 b''
   }, 
   "python2.7-requests-2.9.1": {
     "Apache License 2.0": "http://spdx.org/licenses/Apache-2.0"
-  },
+  }, 
   "python2.7-setuptools-19.4": {
     "Python Software Foundation License version 2": "http://spdx.org/licenses/Python-2.0", 
     "Zope Public License 2.0": "http://spdx.org/licenses/ZPL-2.0"
   }, 
-  "python2.7-setuptools-scm-1.11.0": {
+  "python2.7-setuptools-scm-1.15.0": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
+  "python2.7-simplegeneric-0.8.1": {
+    "Zope Public License 2.1": "http://spdx.org/licenses/ZPL-2.1"
+  }, 
   "python2.7-simplejson-3.7.2": {
-    "Academic Free License": "http://spdx.org/licenses/AFL-2.1", 
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
   "python2.7-six-1.9.0": {
     "MIT License": "http://spdx.org/licenses/MIT"
   }, 
+  "python2.7-subprocess32-3.2.6": {
+    "Python Software Foundation License version 2": "http://spdx.org/licenses/Python-2.0"
+  }, 
+  "python2.7-termcolor-1.1.0": {
+    "MIT License": "http://spdx.org/licenses/MIT"
+  }, 
+  "python2.7-testpath-0.1": {
+    "MIT License": "http://spdx.org/licenses/MIT"
+  }, 
+  "python2.7-traitlets-4.3.2": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
   "python2.7-translationstring-1.3": {
     "Repoze License": "http://www.repoze.org/LICENSE.txt"
   }, 
@@ -235,9 +363,15 b''
   "python2.7-venusian-1.0": {
     "Repoze License": "http://www.repoze.org/LICENSE.txt"
   }, 
-  "python2.7-waitress-0.8.9": {
+  "python2.7-waitress-1.0.1": {
     "Zope Public License 2.1": "http://spdx.org/licenses/ZPL-2.1"
   }, 
+  "python2.7-wcwidth-0.1.7": {
+    "MIT License": "http://spdx.org/licenses/MIT"
+  }, 
+  "python2.7-ws4py-0.3.5": {
+    "BSD 4-clause \"Original\" or \"Old\" License": "http://spdx.org/licenses/BSD-4-Clause"
+  }, 
   "python2.7-zope.cachedescriptors-4.0.0": {
     "Zope Public License 2.1": "http://spdx.org/licenses/ZPL-2.1"
   }, 
@@ -246,5 +380,9 b''
   }, 
   "python2.7-zope.interface-4.1.3": {
     "Zope Public License 2.1": "http://spdx.org/licenses/ZPL-2.1"
+  }, 
+  "xz-5.2.2": {
+    "GNU General Public License v2.0 or later": "http://spdx.org/licenses/GPL-2.0+", 
+    "GNU Library General Public License v2.1 or later": "http://spdx.org/licenses/LGPL-2.1+"
   }
 }
  No newline at end of file

rhodecode/config/middleware.py

@@ -39,11 +39,15 b' from routes.middleware import RoutesMidd'
 import routes.util
 
 import rhodecode
+
 from rhodecode.model import meta
 from rhodecode.config import patches
 from rhodecode.config.routing import STATIC_FILE_PREFIX
 from rhodecode.config.environment import (
     load_environment, load_pyramid_environment)
+
+from rhodecode.lib.vcs import VCSCommunicationError
+from rhodecode.lib.exceptions import VCSServerUnavailable
 from rhodecode.lib.middleware import csrf
 from rhodecode.lib.middleware.appenlight import wrap_in_appenlight_if_enabled
 from rhodecode.lib.middleware.error_handling import (
@@ -51,10 +55,10 b' from rhodecode.lib.middleware.error_hand'
 from rhodecode.lib.middleware.https_fixup import HttpsFixup
 from rhodecode.lib.middleware.vcs import VCSMiddleware
 from rhodecode.lib.plugins.utils import register_rhodecode_plugin
-from rhodecode.lib.utils2 import aslist as rhodecode_aslist
+from rhodecode.lib.utils2 import aslist as rhodecode_aslist, AttributeDict
 from rhodecode.subscribers import (
-    scan_repositories_if_enabled, write_metadata_if_needed,
-    write_js_routes_if_enabled)
+    scan_repositories_if_enabled, write_js_routes_if_enabled,
+    write_metadata_if_needed)
 
 
 log = logging.getLogger(__name__)
@@ -221,7 +225,7 b' def add_pylons_compat_data(registry, glo'
 
 def error_handler(exception, request):
     import rhodecode
-    from rhodecode.lib.utils2 import AttributeDict
+    from rhodecode.lib import helpers
 
     rhodecode_title = rhodecode.CONFIG.get('rhodecode_title') or 'RhodeCode'
 
@@ -229,6 +233,8 b' def error_handler(exception, request):'
     # prefer original exception for the response since it may have headers set
     if isinstance(exception, HTTPException):
         base_response = exception
+    elif isinstance(exception, VCSCommunicationError):
+        base_response = VCSServerUnavailable()
 
     def is_http_error(response):
         # error which should have traceback
@@ -255,9 +261,10 b' def error_handler(exception, request):'
     c.causes = []
     if hasattr(base_response, 'causes'):
         c.causes = base_response.causes
+    c.messages = helpers.flash.pop_messages()
 
     response = render_to_response(
-        '/errors/error_document.mako', {'c': c}, request=request,
+        '/errors/error_document.mako', {'c': c, 'h': helpers}, request=request,
         response=base_response)
 
     return response
@@ -284,11 +291,15 b' def includeme(config):'
 
     # apps
     config.include('rhodecode.apps._base')
+    config.include('rhodecode.apps.ops')
 
     config.include('rhodecode.apps.admin')
     config.include('rhodecode.apps.channelstream')
     config.include('rhodecode.apps.login')
+    config.include('rhodecode.apps.home')
     config.include('rhodecode.apps.repository')
+    config.include('rhodecode.apps.repo_group')
+    config.include('rhodecode.apps.search')
     config.include('rhodecode.apps.user_profile')
     config.include('rhodecode.apps.my_account')
     config.include('rhodecode.apps.svn_support')
@@ -307,6 +318,12 b' def includeme(config):'
     config.add_subscriber(write_metadata_if_needed, ApplicationCreated)
     config.add_subscriber(write_js_routes_if_enabled, ApplicationCreated)
 
+    # events
+    # TODO(marcink): this should be done when pyramid migration is finished
+    # config.add_subscriber(
+    #     'rhodecode.integrations.integrations_event_handler',
+    #     'rhodecode.events.RhodecodeEvent')
+
     # Set the authorization policy.
     authz_policy = ACLAuthorizationPolicy()
     config.set_authorization_policy(authz_policy)
@@ -314,6 +331,10 b' def includeme(config):'
     # Set the default renderer for HTML templates to mako.
     config.add_mako_renderer('.html')
 
+    config.add_renderer(
+        name='json_ext',
+        factory='rhodecode.lib.ext_json_renderer.pyramid_ext_json')
+
     # include RhodeCode plugins
     includes = aslist(settings.get('rhodecode.includes', []))
     for inc in includes:
@@ -395,7 +416,6 b' def wrap_app_in_wsgi_middlewares(pyramid'
             pool = meta.Base.metadata.bind.engine.pool
             log.debug('sa pool status: %s', pool.status())
 
-
     return pyramid_app_with_cleanup
 
 

rhodecode/config/routing.py

@@ -32,8 +32,6 b' import os'
 import re
 from routes import Mapper
 
-from rhodecode.config import routing_links
-
 # prefix for non repository related links needs to be prefixed with `/`
 ADMIN_PREFIX = '/_admin'
 STATIC_FILE_PREFIX = '/_static'
@@ -119,8 +117,9 b' class JSRoutesMapper(Mapper):'
 
 def make_map(config):
     """Create, configure and return the routes Mapper"""
-    rmap = JSRoutesMapper(directory=config['pylons.paths']['controllers'],
-                  always_scan=config['debug'])
+    rmap = JSRoutesMapper(
+        directory=config['pylons.paths']['controllers'],
+        always_scan=config['debug'])
     rmap.minimization = False
     rmap.explicit = False
 
@@ -186,36 +185,7 b' def make_map(config):'
     # CUSTOM ROUTES HERE
     #==========================================================================
 
-    # MAIN PAGE
-    rmap.connect('home', '/', controller='home', action='index', jsroute=True)
-    rmap.connect('goto_switcher_data', '/_goto_data', controller='home',
-                 action='goto_switcher_data')
-    rmap.connect('repo_list_data', '/_repos', controller='home',
-                 action='repo_list_data')
-
-    rmap.connect('user_autocomplete_data', '/_users', controller='home',
-                 action='user_autocomplete_data', jsroute=True)
-    rmap.connect('user_group_autocomplete_data', '/_user_groups', controller='home',
-                 action='user_group_autocomplete_data', jsroute=True)
-
-    # TODO: johbo: Static links, to be replaced by our redirection mechanism
-    rmap.connect('rst_help',
-                 'http://docutils.sourceforge.net/docs/user/rst/quickref.html',
-                 _static=True)
-    rmap.connect('markdown_help',
-                 'http://daringfireball.net/projects/markdown/syntax',
-                 _static=True)
-    rmap.connect('rhodecode_official', 'https://rhodecode.com', _static=True)
-    rmap.connect('rhodecode_support', 'https://rhodecode.com/help/', _static=True)
-    rmap.connect('rhodecode_translations', 'https://rhodecode.com/translate/enterprise', _static=True)
-    # TODO: anderson - making this a static link since redirect won't play
-    # nice with POST requests
-    rmap.connect('enterprise_license_convert_from_old',
-                 'https://rhodecode.com/u/license-upgrade',
-                 _static=True)
-
-    routing_links.connect_redirection_links(rmap)
-
+    # ping and pylons error test
     rmap.connect('ping', '%s/ping' % (ADMIN_PREFIX,), controller='home', action='ping')
     rmap.connect('error_test', '%s/error_test' % (ADMIN_PREFIX,), controller='home', action='error_test')
 
@@ -228,10 +198,6 b' def make_map(config):'
                   action='index', conditions={'method': ['GET']})
         m.connect('new_repo', '/create_repository', jsroute=True,
                   action='create_repository', conditions={'method': ['GET']})
-        m.connect('/repos/{repo_name}',
-                  action='update', conditions={'method': ['PUT'],
-                                               'function': check_repo},
-                  requirements=URL_NAME_REQUIREMENTS)
         m.connect('delete_repo', '/repos/{repo_name}',
                   action='delete', conditions={'method': ['DELETE']},
                   requirements=URL_NAME_REQUIREMENTS)
@@ -321,19 +287,6 b' def make_map(config):'
         m.connect('edit_user_perms_summary', '/users/{user_id}/edit/permissions_summary',
                   action='edit_perms_summary', conditions={'method': ['GET']})
 
-        m.connect('edit_user_emails', '/users/{user_id}/edit/emails',
-                  action='edit_emails', conditions={'method': ['GET']})
-        m.connect('edit_user_emails', '/users/{user_id}/edit/emails',
-                  action='add_email', conditions={'method': ['PUT']})
-        m.connect('edit_user_emails', '/users/{user_id}/edit/emails',
-                  action='delete_email', conditions={'method': ['DELETE']})
-
-        m.connect('edit_user_ips', '/users/{user_id}/edit/ips',
-                  action='edit_ips', conditions={'method': ['GET']})
-        m.connect('edit_user_ips', '/users/{user_id}/edit/ips',
-                  action='add_ip', conditions={'method': ['PUT']})
-        m.connect('edit_user_ips', '/users/{user_id}/edit/ips',
-                  action='delete_ip', conditions={'method': ['DELETE']})
 
     # ADMIN USER GROUPS REST ROUTES
     with rmap.submapper(path_prefix=ADMIN_PREFIX,
@@ -519,37 +472,9 b' def make_map(config):'
         m.connect('my_account_password', '/my_account/password',
                   action='my_account_password', conditions={'method': ['GET']})
 
-        m.connect('my_account_repos', '/my_account/repos',
-                  action='my_account_repos', conditions={'method': ['GET']})
-
-        m.connect('my_account_watched', '/my_account/watched',
-                  action='my_account_watched', conditions={'method': ['GET']})
-
         m.connect('my_account_pullrequests', '/my_account/pull_requests',
                   action='my_account_pullrequests', conditions={'method': ['GET']})
 
-        m.connect('my_account_perms', '/my_account/perms',
-                  action='my_account_perms', conditions={'method': ['GET']})
-
-        m.connect('my_account_emails', '/my_account/emails',
-                  action='my_account_emails', conditions={'method': ['GET']})
-        m.connect('my_account_emails', '/my_account/emails',
-                  action='my_account_emails_add', conditions={'method': ['POST']})
-        m.connect('my_account_emails', '/my_account/emails',
-                  action='my_account_emails_delete', conditions={'method': ['DELETE']})
-
-        m.connect('my_account_notifications', '/my_account/notifications',
-                  action='my_notifications',
-                  conditions={'method': ['GET']})
-        m.connect('my_account_notifications_toggle_visibility',
-                  '/my_account/toggle_visibility',
-                  action='my_notifications_toggle_visibility',
-                  conditions={'method': ['POST']})
-    m.connect('my_account_notifications_test_channelstream',
-              '/my_account/test_channelstream',
-              action='my_account_notifications_test_channelstream',
-              conditions={'method': ['POST']})
-
     # NOTIFICATION REST ROUTES
     with rmap.submapper(path_prefix=ADMIN_PREFIX,
                         controller='admin/notifications') as m:
@@ -597,22 +522,6 b' def make_map(config):'
                   action='show', conditions={'method': ['GET']},
                   requirements=URL_NAME_REQUIREMENTS)
 
-    # ADMIN MAIN PAGES
-    with rmap.submapper(path_prefix=ADMIN_PREFIX,
-                        controller='admin/admin') as m:
-        m.connect('admin_home', '', action='index')
-        m.connect('admin_add_repo', '/add_repo/{new_repo:[a-z0-9\. _-]*}',
-                  action='add_repo')
-        m.connect(
-            'pull_requests_global_0', '/pull_requests/{pull_request_id:[0-9]+}',
-            action='pull_requests')
-        m.connect(
-            'pull_requests_global_1', '/pull-requests/{pull_request_id:[0-9]+}',
-            action='pull_requests')
-        m.connect(
-            'pull_requests_global', '/pull-request/{pull_request_id:[0-9]+}',
-            action='pull_requests')
-
     # USER JOURNAL
     rmap.connect('journal', '%s/journal' % (ADMIN_PREFIX,),
                  controller='journal', action='index')
@@ -642,15 +551,6 b' def make_map(config):'
                  controller='journal', action='toggle_following', jsroute=True,
                  conditions={'method': ['POST']})
 
-    # FULL TEXT SEARCH
-    rmap.connect('search', '%s/search' % (ADMIN_PREFIX,),
-                 controller='search')
-    rmap.connect('search_repo_home', '/{repo_name}/search',
-                 controller='search',
-                 action='index',
-                 conditions={'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS)
-
     # FEEDS
     rmap.connect('rss_feed_home', '/{repo_name}/feed/rss',
                  controller='feed', action='rss',
@@ -673,21 +573,6 b' def make_map(config):'
                  controller='admin/repos', action='repo_check',
                  requirements=URL_NAME_REQUIREMENTS)
 
-    rmap.connect('repo_stats', '/{repo_name}/repo_stats/{commit_id}',
-                 controller='summary', action='repo_stats',
-                 conditions={'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS, jsroute=True)
-
-    rmap.connect('repo_refs_data', '/{repo_name}/refs-data',
-                 controller='summary', action='repo_refs_data',
-                 requirements=URL_NAME_REQUIREMENTS, jsroute=True)
-    rmap.connect('repo_refs_changelog_data', '/{repo_name}/refs-data-changelog',
-                 controller='summary', action='repo_refs_changelog_data',
-                 requirements=URL_NAME_REQUIREMENTS, jsroute=True)
-    rmap.connect('repo_default_reviewers_data', '/{repo_name}/default-reviewers',
-                 controller='summary', action='repo_default_reviewers_data',
-                 jsroute=True, requirements=URL_NAME_REQUIREMENTS)
-
     rmap.connect('changeset_home', '/{repo_name}/changeset/{revision}',
                  controller='changeset', revision='tip',
                  conditions={'function': check_repo},
@@ -702,21 +587,6 b' def make_map(config):'
                  requirements=URL_NAME_REQUIREMENTS)
 
     # repo edit options
-    rmap.connect('edit_repo', '/{repo_name}/settings', jsroute=True,
-                 controller='admin/repos', action='edit',
-                 conditions={'method': ['GET'], 'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS)
-
-    rmap.connect('edit_repo_perms', '/{repo_name}/settings/permissions',
-                 jsroute=True,
-                 controller='admin/repos', action='edit_permissions',
-                 conditions={'method': ['GET'], 'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS)
-    rmap.connect('edit_repo_perms_update', '/{repo_name}/settings/permissions',
-                 controller='admin/repos', action='edit_permissions_update',
-                 conditions={'method': ['PUT'], 'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS)
-
     rmap.connect('edit_repo_fields', '/{repo_name}/settings/fields',
                  controller='admin/repos', action='edit_fields',
                  conditions={'method': ['GET'], 'function': check_repo},
@@ -730,39 +600,11 b' def make_map(config):'
                  conditions={'method': ['DELETE'], 'function': check_repo},
                  requirements=URL_NAME_REQUIREMENTS)
 
-    rmap.connect('edit_repo_advanced', '/{repo_name}/settings/advanced',
-                 controller='admin/repos', action='edit_advanced',
-                 conditions={'method': ['GET'], 'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS)
-
-    rmap.connect('edit_repo_advanced_locking', '/{repo_name}/settings/advanced/locking',
-                 controller='admin/repos', action='edit_advanced_locking',
-                 conditions={'method': ['PUT'], 'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS)
     rmap.connect('toggle_locking', '/{repo_name}/settings/advanced/locking_toggle',
                  controller='admin/repos', action='toggle_locking',
                  conditions={'method': ['GET'], 'function': check_repo},
                  requirements=URL_NAME_REQUIREMENTS)
 
-    rmap.connect('edit_repo_advanced_journal', '/{repo_name}/settings/advanced/journal',
-                 controller='admin/repos', action='edit_advanced_journal',
-                 conditions={'method': ['PUT'], 'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS)
-
-    rmap.connect('edit_repo_advanced_fork', '/{repo_name}/settings/advanced/fork',
-                 controller='admin/repos', action='edit_advanced_fork',
-                 conditions={'method': ['PUT'], 'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS)
-
-    rmap.connect('edit_repo_caches', '/{repo_name}/settings/caches',
-                 controller='admin/repos', action='edit_caches_form',
-                 conditions={'method': ['GET'], 'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS)
-    rmap.connect('edit_repo_caches', '/{repo_name}/settings/caches',
-                 controller='admin/repos', action='edit_caches',
-                 conditions={'method': ['PUT'], 'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS)
-
     rmap.connect('edit_repo_remote', '/{repo_name}/settings/remote',
                  controller='admin/repos', action='edit_remote_form',
                  conditions={'method': ['GET'], 'function': check_repo},
@@ -931,13 +773,6 b' def make_map(config):'
                                               'method': ['DELETE']},
                  requirements=URL_NAME_REQUIREMENTS)
 
-    rmap.connect('pullrequest_show_all',
-                 '/{repo_name}/pull-request',
-                 controller='pullrequests',
-                 action='show_all', conditions={'function': check_repo,
-                                                'method': ['GET']},
-                 requirements=URL_NAME_REQUIREMENTS, jsroute=True)
-
     rmap.connect('pullrequest_comment',
                  '/{repo_name}/pull-request-comment/{pull_request_id}',
                  controller='pullrequests',
@@ -951,31 +786,10 b' def make_map(config):'
                  conditions={'function': check_repo, 'method': ['DELETE']},
                  requirements=URL_NAME_REQUIREMENTS, jsroute=True)
 
-    rmap.connect('summary_home_explicit', '/{repo_name}/summary',
-                 controller='summary', conditions={'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS)
-
-    rmap.connect('branches_home', '/{repo_name}/branches',
-                 controller='branches', conditions={'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS)
-
-    rmap.connect('tags_home', '/{repo_name}/tags',
-                 controller='tags', conditions={'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS)
-
-    rmap.connect('bookmarks_home', '/{repo_name}/bookmarks',
-                 controller='bookmarks', conditions={'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS)
-
     rmap.connect('changelog_home', '/{repo_name}/changelog', jsroute=True,
                  controller='changelog', conditions={'function': check_repo},
                  requirements=URL_NAME_REQUIREMENTS)
 
-    rmap.connect('changelog_summary_home', '/{repo_name}/changelog_summary',
-                 controller='changelog', action='changelog_summary',
-                 conditions={'function': check_repo},
-                 requirements=URL_NAME_REQUIREMENTS)
-
     rmap.connect('changelog_file_home',
                  '/{repo_name}/changelog/{revision}/{f_path}',
                  controller='changelog', f_path=None,
@@ -1128,26 +942,4 b' def make_map(config):'
                  conditions={'function': check_repo},
                  requirements=URL_NAME_REQUIREMENTS)
 
-    # must be here for proper group/repo catching pattern
-    _connect_with_slash(
-        rmap, 'repo_group_home', '/{group_name}',
-        controller='home', action='index_repo_group',
-        conditions={'function': check_group},
-        requirements=URL_NAME_REQUIREMENTS)
-
-    # catch all, at the end
-    _connect_with_slash(
-        rmap, 'summary_home', '/{repo_name}', jsroute=True,
-        controller='summary', action='index',
-        conditions={'function': check_repo},
-        requirements=URL_NAME_REQUIREMENTS)
-
     return rmap
-
-
-def _connect_with_slash(mapper, name, path, *args, **kwargs):
-    """
-    Connect a route with an optional trailing slash in `path`.
-    """
-    mapper.connect(name + '_slash', path + '/', *args, **kwargs)
-    mapper.connect(name, path, *args, **kwargs)

rhodecode/config/routing_links.py

@@ -46,27 +46,56 b' you can see it working.'
 # flake8: noqa
 from __future__ import unicode_literals
 
+link_config = [
+    {
+        "name": "enterprise_docs",
+        "target": "https://rhodecode.com/r1/enterprise/docs/",
+        "external_target": "https://docs.rhodecode.com/RhodeCode-Enterprise/",
+    },
+    {
+        "name": "enterprise_log_file_locations",
+        "target": "https://rhodecode.com/r1/enterprise/docs/admin-system-overview/",
+        "external_target": "https://docs.rhodecode.com/RhodeCode-Enterprise/admin/system-overview.html#log-files",
+    },
+    {
+        "name": "enterprise_issue_tracker_settings",
+        "target": "https://rhodecode.com/r1/enterprise/docs/issue-trackers-overview/",
+        "external_target": "https://docs.rhodecode.com/RhodeCode-Enterprise/issue-trackers/issue-trackers.html",
+    },
+    {
+        "name": "enterprise_svn_setup",
+        "target": "https://rhodecode.com/r1/enterprise/docs/svn-setup/",
+        "external_target": "https://docs.rhodecode.com/RhodeCode-Enterprise/admin/svn-http.html",
+    },
+    {
+        "name": "rst_help",
+        "target": "http://docutils.sourceforge.net/docs/user/rst/quickref.html",
+        "external_target": "http://docutils.sourceforge.net/docs/user/rst/quickref.html",
+    },
+    {
+        "name": "markdown_help",
+        "target": "https://daringfireball.net/projects/markdown/syntax",
+        "external_target": "https://daringfireball.net/projects/markdown/syntax",
+    },
+    {
+        "name": "rhodecode_official",
+        "target": "https://rhodecode.com",
+        "external_target": "https://rhodecode.com/",
+    },
+    {
+        "name": "rhodecode_support",
+        "target": "https://rhodecode.com/help/",
+        "external_target": "https://rhodecode.com/support",
+    },
+    {
+        "name": "rhodecode_translations",
+        "target": "https://rhodecode.com/translate/enterprise",
+        "external_target": "https://www.transifex.com/rhodecode/RhodeCode/",
+    },
 
-link_config = [
-    {"name": "enterprise_docs",
-     "target": "https://rhodecode.com/r1/enterprise/docs/",
-     "external_target": "https://docs.rhodecode.com/RhodeCode-Enterprise/",
-     },
-    {"name": "enterprise_log_file_locations",
-     "target": "https://rhodecode.com/r1/enterprise/docs/admin-system-overview/",
-     "external_target": "https://docs.rhodecode.com/RhodeCode-Enterprise/admin/system-overview.html#log-files",
-     },
-    {"name": "enterprise_issue_tracker_settings",
-     "target": "https://rhodecode.com/r1/enterprise/docs/issue-trackers-overview/",
-     "external_target": "https://docs.rhodecode.com/RhodeCode-Enterprise/issue-trackers/issue-trackers.html",
-     },
-    {"name": "enterprise_svn_setup",
-     "target": "https://rhodecode.com/r1/enterprise/docs/svn-setup/",
-     "external_target": "https://docs.rhodecode.com/RhodeCode-Enterprise/admin/svn-http.html",
-     },
 ]
 
 
-def connect_redirection_links(rmap):
+def connect_redirection_links(config):
     for link in link_config:
-        rmap.connect(link['name'], link['target'], _static=True)
+        config.add_route(link['name'], link['target'], static=True)

rhodecode/controllers/admin/my_account.py

@@ -24,35 +24,27 b' my account controller for RhodeCode admi'
 """
 
 import logging
-import datetime
 
 import formencode
 from formencode import htmlfill
-from pyramid.threadlocal import get_current_registry
 from pyramid.httpexceptions import HTTPFound
 
-from pylons import request, tmpl_context as c, url
+from pylons import request, tmpl_context as c
 from pylons.controllers.util import redirect
 from pylons.i18n.translation import _
-from sqlalchemy.orm import joinedload
 
 from rhodecode.lib import helpers as h
 from rhodecode.lib import auth
 from rhodecode.lib.auth import (
     LoginRequired, NotAnonymous, AuthUser)
 from rhodecode.lib.base import BaseController, render
-from rhodecode.lib.utils import jsonify
 from rhodecode.lib.utils2 import safe_int, str2bool
 from rhodecode.lib.ext_json import json
-from rhodecode.lib.channelstream import channelstream_request, \
-    ChannelstreamException
 
 from rhodecode.model.db import (
     Repository, PullRequest, UserEmailMap, User, UserFollowing)
 from rhodecode.model.forms import UserForm
-from rhodecode.model.scm import RepoList
 from rhodecode.model.user import UserModel
-from rhodecode.model.repo import RepoModel
 from rhodecode.model.meta import Session
 from rhodecode.model.pull_request import PullRequestModel
 from rhodecode.model.comment import CommentsModel
@@ -82,26 +74,6 b' class MyAccountController(BaseController'
         c.auth_user = AuthUser(
             user_id=c.rhodecode_user.user_id, ip_addr=self.ip_addr)
 
-    def _load_my_repos_data(self, watched=False):
-        if watched:
-            admin = False
-            follows_repos = Session().query(UserFollowing)\
-                .filter(UserFollowing.user_id == c.rhodecode_user.user_id)\
-                .options(joinedload(UserFollowing.follows_repository))\
-                .all()
-            repo_list = [x.follows_repository for x in follows_repos]
-        else:
-            admin = True
-            repo_list = Repository.get_all_repos(
-                user_id=c.rhodecode_user.user_id)
-            repo_list = RepoList(repo_list, perm_set=[
-                'repository.read', 'repository.write', 'repository.admin'])
-
-        repos_data = RepoModel().get_repos_as_dict(
-            repo_list=repo_list, admin=admin)
-        # json used to render the grid
-        return json.dumps(repos_data)
-
     @auth.CSRFRequired()
     def my_account_update(self):
         """
@@ -181,65 +153,6 b' class MyAccountController(BaseController'
             force_defaults=False
         )
 
-    def my_account_repos(self):
-        c.active = 'repos'
-        self.__load_data()
-
-        # json used to render the grid
-        c.data = self._load_my_repos_data()
-        return render('admin/my_account/my_account.mako')
-
-    def my_account_watched(self):
-        c.active = 'watched'
-        self.__load_data()
-
-        # json used to render the grid
-        c.data = self._load_my_repos_data(watched=True)
-        return render('admin/my_account/my_account.mako')
-
-    def my_account_perms(self):
-        c.active = 'perms'
-        self.__load_data()
-        c.perm_user = c.auth_user
-
-        return render('admin/my_account/my_account.mako')
-
-    def my_account_emails(self):
-        c.active = 'emails'
-        self.__load_data()
-
-        c.user_email_map = UserEmailMap.query()\
-            .filter(UserEmailMap.user == c.user).all()
-        return render('admin/my_account/my_account.mako')
-
-    @auth.CSRFRequired()
-    def my_account_emails_add(self):
-        email = request.POST.get('new_email')
-
-        try:
-            UserModel().add_extra_email(c.rhodecode_user.user_id, email)
-            Session().commit()
-            h.flash(_("Added new email address `%s` for user account") % email,
-                    category='success')
-        except formencode.Invalid as error:
-            msg = error.error_dict['email']
-            h.flash(msg, category='error')
-        except Exception:
-            log.exception("Exception in my_account_emails")
-            h.flash(_('An error occurred during email saving'),
-                    category='error')
-        return redirect(url('my_account_emails'))
-
-    @auth.CSRFRequired()
-    def my_account_emails_delete(self):
-        email_id = request.POST.get('del_email_id')
-        user_model = UserModel()
-        user_model.delete_extra_email(c.rhodecode_user.user_id, email_id)
-        Session().commit()
-        h.flash(_("Removed email address from user account"),
-                category='success')
-        return redirect(url('my_account_emails'))
-
     def _extract_ordering(self, request):
         column_index = safe_int(request.GET.get('order[0][column]'))
         order_dir = request.GET.get('order[0][dir]', 'desc')
@@ -320,45 +233,4 b' class MyAccountController(BaseController'
         else:
             return json.dumps(data)
 
-    def my_notifications(self):
-        c.active = 'notifications'
-        return render('admin/my_account/my_account.mako')
 
-    @auth.CSRFRequired()
-    @jsonify
-    def my_notifications_toggle_visibility(self):
-        user = c.rhodecode_user.get_instance()
-        new_status = not user.user_data.get('notification_status', True)
-        user.update_userdata(notification_status=new_status)
-        Session().commit()
-        return user.user_data['notification_status']
-
-    @auth.CSRFRequired()
-    @jsonify
-    def my_account_notifications_test_channelstream(self):
-        message = 'Test message sent via Channelstream by user: {}, on {}'.format(
-            c.rhodecode_user.username, datetime.datetime.now())
-        payload = {
-            'type': 'message',
-            'timestamp': datetime.datetime.utcnow(),
-            'user': 'system',
-            #'channel': 'broadcast',
-            'pm_users': [c.rhodecode_user.username],
-            'message': {
-                'message': message,
-                'level': 'info',
-                'topic': '/notifications'
-            }
-        }
-
-        registry = get_current_registry()
-        rhodecode_plugins = getattr(registry, 'rhodecode_plugins', {})
-        channelstream_config = rhodecode_plugins.get('channelstream', {})
-
-        try:
-            channelstream_request(channelstream_config, [payload], '/message')
-        except ChannelstreamException as e:
-            log.exception('Failed to send channelstream data')
-            return {"response": 'ERROR: {}'.format(e.__class__.__name__)}
-        return {"response": 'Channelstream data sent. '
-                            'You should see a new live message now.'}

rhodecode/controllers/admin/notifications.py

@@ -48,10 +48,6 b' log = logging.getLogger(__name__)'
 
 class NotificationsController(BaseController):
     """REST Controller styled on the Atom Publishing Protocol"""
-    # To properly map this controller, ensure your config/routing.py
-    # file has a resource setup:
-    #     map.resource('notification', 'notifications', controller='_admin/notifications',
-    #         path_prefix='/_admin', name_prefix='_admin_')
 
     @LoginRequired()
     @NotAnonymous()
@@ -62,8 +58,8 b' class NotificationsController(BaseContro'
         """GET /_admin/notifications: All items in the collection"""
         # url('notifications')
         c.user = c.rhodecode_user
-        notif = NotificationModel().get_for_user(c.rhodecode_user.user_id,
-                                            filter_=request.GET.getall('type'))
+        notif = NotificationModel().get_for_user(
+            c.rhodecode_user.user_id, filter_=request.GET.getall('type'))
 
         p = safe_int(request.GET.get('page', 1), 1)
         notifications_url = webhelpers.paginate.PageURL(
@@ -86,7 +82,6 b' class NotificationsController(BaseContro'
 
         return render('admin/notifications/notifications.mako')
 
-
     @auth.CSRFRequired()
     def mark_all_read(self):
         if request.is_xhr:
@@ -115,15 +110,8 b' class NotificationsController(BaseContro'
 
     @auth.CSRFRequired()
     def update(self, notification_id):
-        """PUT /_admin/notifications/id: Update an existing item"""
-        # Forms posted to this method should contain a hidden field:
-        #    <input type="hidden" name="_method" value="PUT" />
-        # Or using helpers:
-        #    h.form(url('notification', notification_id=ID),
-        #           method='put')
-        # url('notification', notification_id=ID)
+        no = Notification.get_or_404(notification_id)
         try:
-            no = Notification.get(notification_id)
             if self._has_permissions(no):
                 # deletes only notification2user
                 NotificationModel().mark_read(c.rhodecode_user.user_id, no)
@@ -136,15 +124,8 b' class NotificationsController(BaseContro'
 
     @auth.CSRFRequired()
     def delete(self, notification_id):
-        """DELETE /_admin/notifications/id: Delete an existing item"""
-        # Forms posted to this method should contain a hidden field:
-        #    <input type="hidden" name="_method" value="DELETE" />
-        # Or using helpers:
-        #    h.form(url('notification', notification_id=ID),
-        #           method='delete')
-        # url('notification', notification_id=ID)
+        no = Notification.get_or_404(notification_id)
         try:
-            no = Notification.get(notification_id)
             if self._has_permissions(no):
                 # deletes only notification2user
                 NotificationModel().delete(c.rhodecode_user.user_id, no)
@@ -156,10 +137,8 b' class NotificationsController(BaseContro'
         raise HTTPBadRequest()
 
     def show(self, notification_id):
-        """GET /_admin/notifications/id: Show a specific item"""
-        # url('notification', notification_id=ID)
         c.user = c.rhodecode_user
-        no = Notification.get(notification_id)
+        no = Notification.get_or_404(notification_id)
 
         if no and self._has_permissions(no):
             unotification = NotificationModel()\

rhodecode/controllers/admin/permissions.py

@@ -64,12 +64,7 b' class PermissionsController(BaseControll'
         c.active = 'application'
         self.__load_data()
 
-        c.user = User.get_default_user()
-
-        # TODO: johbo: The default user might be based on outdated state which
-        # has been loaded from the cache. A call to refresh() ensures that the
-        # latest state from the database is used.
-        Session().refresh(c.user)
+        c.user = User.get_default_user(refresh=True)
 
         app_settings = SettingsModel().get_all_settings()
         defaults = {

rhodecode/controllers/admin/repo_groups.py

@@ -34,17 +34,18 b' from pylons.i18n.translation import _, u'
 
 from rhodecode.lib import auth
 from rhodecode.lib import helpers as h
+from rhodecode.lib import audit_logger
 from rhodecode.lib.ext_json import json
 from rhodecode.lib.auth import (
     LoginRequired, NotAnonymous, HasPermissionAll,
     HasRepoGroupPermissionAll, HasRepoGroupPermissionAnyDecorator)
 from rhodecode.lib.base import BaseController, render
+from rhodecode.lib.utils2 import safe_int
 from rhodecode.model.db import RepoGroup, User
 from rhodecode.model.scm import RepoGroupList
 from rhodecode.model.repo_group import RepoGroupModel
 from rhodecode.model.forms import RepoGroupForm, RepoGroupPermsForm
 from rhodecode.model.meta import Session
-from rhodecode.lib.utils2 import safe_int
 
 
 log = logging.getLogger(__name__)
@@ -153,9 +154,6 b' class RepoGroupsController(BaseControlle'
 
     @NotAnonymous()
     def index(self):
-        """GET /repo_groups: All items in the collection"""
-        # url('repo_groups')
-
         repo_group_list = RepoGroup.get_all_repo_groups()
         _perms = ['group.admin']
         repo_group_list_acl = RepoGroupList(repo_group_list, perm_set=_perms)
@@ -168,8 +166,6 b' class RepoGroupsController(BaseControlle'
     @NotAnonymous()
     @auth.CSRFRequired()
     def create(self):
-        """POST /repo_groups: Create a new item"""
-        # url('repo_groups')
 
         parent_group_id = safe_int(request.POST.get('group_parent_id'))
         can_create = self._can_create_repo_group(parent_group_id)
@@ -183,20 +179,29 b' class RepoGroupsController(BaseControlle'
         try:
             owner = c.rhodecode_user
             form_result = repo_group_form.to_python(dict(request.POST))
-            RepoGroupModel().create(
+            repo_group = RepoGroupModel().create(
                 group_name=form_result['group_name_full'],
                 group_description=form_result['group_description'],
                 owner=owner.user_id,
                 copy_permissions=form_result['group_copy_permissions']
             )
+            Session().flush()
+
+            repo_group_data = repo_group.get_api_data()
+            audit_logger.store_web(
+                'repo_group.create', action_data={'data': repo_group_data},
+                user=c.rhodecode_user)
+
             Session().commit()
+
             _new_group_name = form_result['group_name_full']
+
             repo_group_url = h.link_to(
                 _new_group_name,
-                h.url('repo_group_home', group_name=_new_group_name))
+                h.route_path('repo_group_home', repo_group_name=_new_group_name))
             h.flash(h.literal(_('Created repository group %s')
                     % repo_group_url), category='success')
-            # TODO: in futureaction_logger(, '', '', '', self.sa)
+
         except formencode.Invalid as errors:
             return htmlfill.render(
                 render('admin/repo_groups/repo_group_add.mako'),
@@ -216,8 +221,6 b' class RepoGroupsController(BaseControlle'
     # perm checks inside
     @NotAnonymous()
     def new(self):
-        """GET /repo_groups/new: Form to create a new item"""
-        # url('new_repo_group')
         # perm check for admin, create_group perm or admin of parent_group
         parent_group_id = safe_int(request.GET.get('parent_group'))
         if not self._can_create_repo_group(parent_group_id):
@@ -229,12 +232,6 b' class RepoGroupsController(BaseControlle'
     @HasRepoGroupPermissionAnyDecorator('group.admin')
     @auth.CSRFRequired()
     def update(self, group_name):
-        """PUT /repo_groups/group_name: Update an existing item"""
-        # Forms posted to this method should contain a hidden field:
-        #    <input type="hidden" name="_method" value="PUT" />
-        # Or using helpers:
-        #    h.form(url('repos_group', group_name=GROUP_NAME), method='put')
-        # url('repo_group_home', group_name=GROUP_NAME)
 
         c.repo_group = RepoGroupModel()._get_repo_group(group_name)
         can_create_in_root = self._can_create_repo_group()
@@ -250,16 +247,21 b' class RepoGroupsController(BaseControlle'
             available_groups=c.repo_groups_choices,
             can_create_in_root=can_create_in_root, allow_disabled=True)()
 
+        old_values = c.repo_group.get_api_data()
         try:
             form_result = repo_group_form.to_python(dict(request.POST))
             gr_name = form_result['group_name']
             new_gr = RepoGroupModel().update(group_name, form_result)
+
+            audit_logger.store_web(
+                'repo_group.edit', action_data={'old_data': old_values},
+                user=c.rhodecode_user)
+
             Session().commit()
             h.flash(_('Updated repository group %s') % (gr_name,),
                     category='success')
             # we now have new name !
             group_name = new_gr.group_name
-            # TODO: in future action_logger(, '', '', '', self.sa)
         except formencode.Invalid as errors:
             c.active = 'settings'
             return htmlfill.render(
@@ -279,13 +281,6 b' class RepoGroupsController(BaseControlle'
     @HasRepoGroupPermissionAnyDecorator('group.admin')
     @auth.CSRFRequired()
     def delete(self, group_name):
-        """DELETE /repo_groups/group_name: Delete an existing item"""
-        # Forms posted to this method should contain a hidden field:
-        #    <input type="hidden" name="_method" value="DELETE" />
-        # Or using helpers:
-        #    h.form(url('repos_group', group_name=GROUP_NAME), method='delete')
-        # url('repo_group_home', group_name=GROUP_NAME)
-
         gr = c.repo_group = RepoGroupModel()._get_repo_group(group_name)
         repos = gr.repositories.all()
         if repos:
@@ -307,11 +302,16 b' class RepoGroupsController(BaseControlle'
             return redirect(url('repo_groups'))
 
         try:
+            old_values = gr.get_api_data()
             RepoGroupModel().delete(group_name)
+
+            audit_logger.store_web(
+                'repo_group.delete', action_data={'old_data': old_values},
+                user=c.rhodecode_user)
+
             Session().commit()
             h.flash(_('Removed repository group %s') % group_name,
                     category='success')
-            # TODO: in future action_logger(, '', '', '', self.sa)
         except Exception:
             log.exception("Exception during deletion of repository group")
             h.flash(_('Error occurred during deletion of repository group %s')
@@ -321,8 +321,7 b' class RepoGroupsController(BaseControlle'
 
     @HasRepoGroupPermissionAnyDecorator('group.admin')
     def edit(self, group_name):
-        """GET /repo_groups/group_name/edit: Form to edit an existing item"""
-        # url('edit_repo_group', group_name=GROUP_NAME)
+
         c.active = 'settings'
 
         c.repo_group = RepoGroupModel()._get_repo_group(group_name)
@@ -346,8 +345,6 b' class RepoGroupsController(BaseControlle'
 
     @HasRepoGroupPermissionAnyDecorator('group.admin')
     def edit_repo_group_advanced(self, group_name):
-        """GET /repo_groups/group_name/edit: Form to edit an existing item"""
-        # url('edit_repo_group', group_name=GROUP_NAME)
         c.active = 'advanced'
         c.repo_group = RepoGroupModel()._get_repo_group(group_name)
 
@@ -355,8 +352,6 b' class RepoGroupsController(BaseControlle'
 
     @HasRepoGroupPermissionAnyDecorator('group.admin')
     def edit_repo_group_perms(self, group_name):
-        """GET /repo_groups/group_name/edit: Form to edit an existing item"""
-        # url('edit_repo_group', group_name=GROUP_NAME)
         c.active = 'perms'
         c.repo_group = RepoGroupModel()._get_repo_group(group_name)
         self.__load_defaults()
@@ -374,8 +369,6 b' class RepoGroupsController(BaseControlle'
     def update_perms(self, group_name):
         """
         Update permissions for given repository group
-
-        :param group_name:
         """
 
         c.repo_group = RepoGroupModel()._get_repo_group(group_name)
@@ -393,14 +386,20 b' class RepoGroupsController(BaseControlle'
         # iterate over all members(if in recursive mode) of this groups and
         # set the permissions !
         # this can be potentially heavy operation
-        RepoGroupModel().update_permissions(
+        changes = RepoGroupModel().update_permissions(
             c.repo_group,
-            form['perm_additions'], form['perm_updates'],
-            form['perm_deletions'], form['recursive'])
+            form['perm_additions'], form['perm_updates'], form['perm_deletions'],
+            form['recursive'])
 
-        # TODO: implement this
-        # action_logger(c.rhodecode_user, 'admin_changed_repo_permissions',
-        #               repo_name, self.ip_addr, self.sa)
+        action_data = {
+            'added': changes['added'],
+            'updated': changes['updated'],
+            'deleted': changes['deleted'],
+        }
+        audit_logger.store_web(
+            'repo_group.edit.permissions', action_data=action_data,
+            user=c.rhodecode_user)
+
         Session().commit()
         h.flash(_('Repository Group permissions updated'), category='success')
         return redirect(url('edit_repo_group_perms', group_name=group_name))

rhodecode/controllers/admin/repos.py

@@ -41,15 +41,11 b' from rhodecode.lib.auth import ('
     HasRepoGroupPermissionAny, HasRepoPermissionAnyDecorator)
 from rhodecode.lib.base import BaseRepoController, render
 from rhodecode.lib.ext_json import json
-from rhodecode.lib.exceptions import AttachedForksError
-from rhodecode.lib.utils import action_logger, repo_name_slug, jsonify
+from rhodecode.lib.utils import repo_name_slug, jsonify
 from rhodecode.lib.utils2 import safe_int, str2bool
-from rhodecode.lib.vcs import RepositoryError
-from rhodecode.model.db import (
-    User, Repository, UserFollowing, RepoGroup, RepositoryField)
+from rhodecode.model.db import (Repository, RepoGroup, RepositoryField)
 from rhodecode.model.forms import (
-    RepoForm, RepoFieldForm, RepoPermsForm, RepoVcsSettingsForm,
-    IssueTrackerPatternsForm)
+    RepoForm, RepoFieldForm, RepoVcsSettingsForm, IssueTrackerPatternsForm)
 from rhodecode.model.meta import Session
 from rhodecode.model.repo import RepoModel
 from rhodecode.model.scm import ScmModel, RepoGroupList, RepoList
@@ -185,7 +181,7 b' class ReposController(BaseRepoController'
         except Exception as e:
             msg = self._log_creation_exception(e, form_result.get('repo_name'))
             h.flash(msg, category='error')
-            return redirect(url('home'))
+            return redirect(h.route_path('home'))
 
         return redirect(h.url('repo_creating_home',
                               repo_name=form_result['repo_name_full'],
@@ -265,7 +261,7 b' class ReposController(BaseRepoController'
                 if task.failed():
                     msg = self._log_creation_exception(task.result, c.repo)
                     h.flash(msg, category='error')
-                    return redirect(url('home'), code=501)
+                    return redirect(h.route_path('home'), code=501)
 
         repo = Repository.get_by_repo_name(repo_name)
         if repo and repo.repo_state == Repository.STATE_CREATED:
@@ -274,9 +270,9 b' class ReposController(BaseRepoController'
                 h.flash(_('Created repository %s from %s')
                         % (repo.repo_name, clone_uri), category='success')
             else:
-                repo_url = h.link_to(repo.repo_name,
-                                     h.url('summary_home',
-                                           repo_name=repo.repo_name))
+                repo_url = h.link_to(
+                    repo.repo_name,
+                    h.route_path('repo_summary',repo_name=repo.repo_name))
                 fork = repo.fork
                 if fork:
                     fork_name = fork.repo_name
@@ -288,165 +284,14 b' class ReposController(BaseRepoController'
             return {'result': True}
         return {'result': False}
 
-    @HasRepoPermissionAllDecorator('repository.admin')
-    @auth.CSRFRequired()
-    def update(self, repo_name):
-        """
-        PUT /repos/repo_name: Update an existing item"""
-        # Forms posted to this method should contain a hidden field:
-        #    <input type="hidden" name="_method" value="PUT" />
-        # Or using helpers:
-        #    h.form(url('repo', repo_name=ID),
-        #           method='put')
-        # url('repo', repo_name=ID)
-
-        self.__load_data(repo_name)
-        c.active = 'settings'
-        c.repo_fields = RepositoryField.query()\
-            .filter(RepositoryField.repository == c.repo_info).all()
-
-        repo_model = RepoModel()
-        changed_name = repo_name
-
-        c.personal_repo_group = c.rhodecode_user.personal_repo_group
-        # override the choices with extracted revisions !
-        repo = Repository.get_by_repo_name(repo_name)
-        old_data = {
-            'repo_name': repo_name,
-            'repo_group': repo.group.get_dict() if repo.group else {},
-            'repo_type': repo.repo_type,
-        }
-        _form = RepoForm(
-            edit=True, old_data=old_data, repo_groups=c.repo_groups_choices,
-            landing_revs=c.landing_revs_choices, allow_disabled=True)()
-
-        try:
-            form_result = _form.to_python(dict(request.POST))
-            repo = repo_model.update(repo_name, **form_result)
-            ScmModel().mark_for_invalidation(repo_name)
-            h.flash(_('Repository %s updated successfully') % repo_name,
-                    category='success')
-            changed_name = repo.repo_name
-            action_logger(c.rhodecode_user, 'admin_updated_repo',
-                              changed_name, self.ip_addr, self.sa)
-            Session().commit()
-        except formencode.Invalid as errors:
-            defaults = self.__load_data(repo_name)
-            defaults.update(errors.value)
-            return htmlfill.render(
-                render('admin/repos/repo_edit.mako'),
-                defaults=defaults,
-                errors=errors.error_dict or {},
-                prefix_error=False,
-                encoding="UTF-8",
-                force_defaults=False)
-
-        except Exception:
-            log.exception("Exception during update of repository")
-            h.flash(_('Error occurred during update of repository %s') \
-                    % repo_name, category='error')
-        return redirect(url('edit_repo', repo_name=changed_name))
-
-    @HasRepoPermissionAllDecorator('repository.admin')
-    @auth.CSRFRequired()
-    def delete(self, repo_name):
-        """
-        DELETE /repos/repo_name: Delete an existing item"""
-        # Forms posted to this method should contain a hidden field:
-        #    <input type="hidden" name="_method" value="DELETE" />
-        # Or using helpers:
-        #    h.form(url('repo', repo_name=ID),
-        #           method='delete')
-        # url('repo', repo_name=ID)
-
-        repo_model = RepoModel()
-        repo = repo_model.get_by_repo_name(repo_name)
-        if not repo:
-            h.not_mapped_error(repo_name)
-            return redirect(url('repos'))
-        try:
-            _forks = repo.forks.count()
-            handle_forks = None
-            if _forks and request.POST.get('forks'):
-                do = request.POST['forks']
-                if do == 'detach_forks':
-                    handle_forks = 'detach'
-                    h.flash(_('Detached %s forks') % _forks, category='success')
-                elif do == 'delete_forks':
-                    handle_forks = 'delete'
-                    h.flash(_('Deleted %s forks') % _forks, category='success')
-            repo_model.delete(repo, forks=handle_forks)
-            action_logger(c.rhodecode_user, 'admin_deleted_repo',
-                  repo_name, self.ip_addr, self.sa)
-            ScmModel().mark_for_invalidation(repo_name)
-            h.flash(_('Deleted repository %s') % repo_name, category='success')
-            Session().commit()
-        except AttachedForksError:
-            h.flash(_('Cannot delete %s it still contains attached forks')
-                        % repo_name, category='warning')
-
-        except Exception:
-            log.exception("Exception during deletion of repository")
-            h.flash(_('An error occurred during deletion of %s') % repo_name,
-                    category='error')
-
-        return redirect(url('repos'))
-
     @HasPermissionAllDecorator('hg.admin')
     def show(self, repo_name, format='html'):
         """GET /repos/repo_name: Show a specific item"""
         # url('repo', repo_name=ID)
 
     @HasRepoPermissionAllDecorator('repository.admin')
-    def edit(self, repo_name):
-        """GET /repo_name/settings: Form to edit an existing item"""
-        # url('edit_repo', repo_name=ID)
-        defaults = self.__load_data(repo_name)
-        if 'clone_uri' in defaults:
-            del defaults['clone_uri']
-
-        c.repo_fields = RepositoryField.query()\
-            .filter(RepositoryField.repository == c.repo_info).all()
-        c.personal_repo_group = c.rhodecode_user.personal_repo_group
-        c.active = 'settings'
-        return htmlfill.render(
-            render('admin/repos/repo_edit.mako'),
-            defaults=defaults,
-            encoding="UTF-8",
-            force_defaults=False)
-
-    @HasRepoPermissionAllDecorator('repository.admin')
-    def edit_permissions(self, repo_name):
-        """GET /repo_name/settings: Form to edit an existing item"""
-        # url('edit_repo', repo_name=ID)
-        c.repo_info = self._load_repo(repo_name)
-        c.active = 'permissions'
-        defaults = RepoModel()._get_defaults(repo_name)
-
-        return htmlfill.render(
-            render('admin/repos/repo_edit.mako'),
-            defaults=defaults,
-            encoding="UTF-8",
-            force_defaults=False)
-
-    @HasRepoPermissionAllDecorator('repository.admin')
-    @auth.CSRFRequired()
-    def edit_permissions_update(self, repo_name):
-        form = RepoPermsForm()().to_python(request.POST)
-        RepoModel().update_permissions(repo_name,
-            form['perm_additions'], form['perm_updates'], form['perm_deletions'])
-
-        #TODO: implement this
-        #action_logger(c.rhodecode_user, 'admin_changed_repo_permissions',
-        #              repo_name, self.ip_addr, self.sa)
-        Session().commit()
-        h.flash(_('Repository permissions updated'), category='success')
-        return redirect(url('edit_repo_perms', repo_name=repo_name))
-
-    @HasRepoPermissionAllDecorator('repository.admin')
     def edit_fields(self, repo_name):
         """GET /repo_name/settings: Form to edit an existing item"""
-        # url('edit_repo', repo_name=ID)
         c.repo_info = self._load_repo(repo_name)
         c.repo_fields = RepositoryField.query()\
             .filter(RepositoryField.repository == c.repo_info).all()
@@ -490,106 +335,6 b' class ReposController(BaseRepoController'
             h.flash(msg, category='error')
         return redirect(url('edit_repo_fields', repo_name=repo_name))
 
-    @HasRepoPermissionAllDecorator('repository.admin')
-    def edit_advanced(self, repo_name):
-        """GET /repo_name/settings: Form to edit an existing item"""
-        # url('edit_repo', repo_name=ID)
-        c.repo_info = self._load_repo(repo_name)
-        c.default_user_id = User.get_default_user().user_id
-        c.in_public_journal = UserFollowing.query()\
-            .filter(UserFollowing.user_id == c.default_user_id)\
-            .filter(UserFollowing.follows_repository == c.repo_info).scalar()
-
-        c.active = 'advanced'
-        c.has_origin_repo_read_perm = False
-        if c.repo_info.fork:
-            c.has_origin_repo_read_perm = h.HasRepoPermissionAny(
-                'repository.write', 'repository.read', 'repository.admin')(
-                c.repo_info.fork.repo_name, 'repo set as fork page')
-
-        if request.POST:
-            return redirect(url('repo_edit_advanced'))
-        return render('admin/repos/repo_edit.mako')
-
-    @HasRepoPermissionAllDecorator('repository.admin')
-    @auth.CSRFRequired()
-    def edit_advanced_journal(self, repo_name):
-        """
-        Set's this repository to be visible in public journal,
-        in other words assing default user to follow this repo
-
-        :param repo_name:
-        """
-
-        try:
-            repo_id = Repository.get_by_repo_name(repo_name).repo_id
-            user_id = User.get_default_user().user_id
-            self.scm_model.toggle_following_repo(repo_id, user_id)
-            h.flash(_('Updated repository visibility in public journal'),
-                    category='success')
-            Session().commit()
-        except Exception:
-            h.flash(_('An error occurred during setting this'
-                      ' repository in public journal'),
-                    category='error')
-
-        return redirect(url('edit_repo_advanced', repo_name=repo_name))
-
-    @HasRepoPermissionAllDecorator('repository.admin')
-    @auth.CSRFRequired()
-    def edit_advanced_fork(self, repo_name):
-        """
-        Mark given repository as a fork of another
-
-        :param repo_name:
-        """
-
-        new_fork_id = request.POST.get('id_fork_of')
-        try:
-
-            if new_fork_id and not new_fork_id.isdigit():
-                log.error('Given fork id %s is not an INT', new_fork_id)
-
-            fork_id = safe_int(new_fork_id)
-            repo = ScmModel().mark_as_fork(repo_name, fork_id,
-                                           c.rhodecode_user.username)
-            fork = repo.fork.repo_name if repo.fork else _('Nothing')
-            Session().commit()
-            h.flash(_('Marked repo %s as fork of %s') % (repo_name, fork),
-                    category='success')
-        except RepositoryError as e:
-            log.exception("Repository Error occurred")
-            h.flash(str(e), category='error')
-        except Exception as e:
-            log.exception("Exception while editing fork")
-            h.flash(_('An error occurred during this operation'),
-                    category='error')
-
-        return redirect(url('edit_repo_advanced', repo_name=repo_name))
-
-    @HasRepoPermissionAllDecorator('repository.admin')
-    @auth.CSRFRequired()
-    def edit_advanced_locking(self, repo_name):
-        """
-        Unlock repository when it is locked !
-
-        :param repo_name:
-        """
-        try:
-            repo = Repository.get_by_repo_name(repo_name)
-            if request.POST.get('set_lock'):
-                Repository.lock(repo, c.rhodecode_user.user_id,
-                                lock_reason=Repository.LOCK_WEB)
-                h.flash(_('Locked repository'), category='success')
-            elif request.POST.get('set_unlock'):
-                Repository.unlock(repo)
-                h.flash(_('Unlocked repository'), category='success')
-        except Exception as e:
-            log.exception("Exception during unlocking")
-            h.flash(_('An error occurred during unlocking'),
-                    category='error')
-        return redirect(url('edit_repo_advanced', repo_name=repo_name))
-
     @HasRepoPermissionAnyDecorator('repository.write', 'repository.admin')
     @auth.CSRFRequired()
     def toggle_locking(self, repo_name):
@@ -617,32 +362,7 b' class ReposController(BaseRepoController'
             log.exception("Exception during unlocking")
             h.flash(_('An error occurred during unlocking'),
                     category='error')
-        return redirect(url('summary_home', repo_name=repo_name))
-
-    @HasRepoPermissionAllDecorator('repository.admin')
-    @auth.CSRFRequired()
-    def edit_caches(self, repo_name):
-        """PUT /{repo_name}/settings/caches: invalidate the repo caches."""
-        try:
-            ScmModel().mark_for_invalidation(repo_name, delete=True)
-            Session().commit()
-            h.flash(_('Cache invalidation successful'),
-                    category='success')
-        except Exception:
-            log.exception("Exception during cache invalidation")
-            h.flash(_('An error occurred during cache invalidation'),
-                    category='error')
-
-        return redirect(url('edit_repo_caches', repo_name=c.repo_name))
-
-    @HasRepoPermissionAllDecorator('repository.admin')
-    def edit_caches_form(self, repo_name):
-        """GET /repo_name/settings: Form to edit an existing item"""
-        # url('edit_repo', repo_name=ID)
-        c.repo_info = self._load_repo(repo_name)
-        c.active = 'caches'
-
-        return render('admin/repos/repo_edit.mako')
+        return redirect(h.route_path('repo_summary', repo_name=repo_name))
 
     @HasRepoPermissionAllDecorator('repository.admin')
     @auth.CSRFRequired()
@@ -660,7 +380,6 b' class ReposController(BaseRepoController'
     @HasRepoPermissionAllDecorator('repository.admin')
     def edit_remote_form(self, repo_name):
         """GET /repo_name/settings: Form to edit an existing item"""
-        # url('edit_repo', repo_name=ID)
         c.repo_info = self._load_repo(repo_name)
         c.active = 'remote'
 
@@ -682,7 +401,6 b' class ReposController(BaseRepoController'
     @HasRepoPermissionAllDecorator('repository.admin')
     def edit_statistics_form(self, repo_name):
         """GET /repo_name/settings: Form to edit an existing item"""
-        # url('edit_repo', repo_name=ID)
         c.repo_info = self._load_repo(repo_name)
         repo = c.repo_info.scm_instance()
 

rhodecode/controllers/admin/settings.py

@@ -195,9 +195,12 b' class SettingsController(BaseController)'
         pyramid_settings = get_current_registry().settings
         c.svn_proxy_generate_config = pyramid_settings[generate_config]
 
+        defaults = self._form_defaults()
+
+        model.create_largeobjects_dirs_if_needed(defaults['paths_root_path'])
         return htmlfill.render(
             render('admin/settings/settings.mako'),
-            defaults=self._form_defaults(),
+            defaults=defaults,
             encoding="UTF-8",
             force_defaults=False)
 

rhodecode/controllers/admin/user_groups.py

@@ -35,9 +35,11 b' from sqlalchemy.orm import joinedload'
 
 from rhodecode.lib import auth
 from rhodecode.lib import helpers as h
+from rhodecode.lib import audit_logger
+from rhodecode.lib.ext_json import json
 from rhodecode.lib.exceptions import UserGroupAssignedException,\
     RepoGroupAssignmentError
-from rhodecode.lib.utils import jsonify, action_logger
+from rhodecode.lib.utils import jsonify
 from rhodecode.lib.utils2 import safe_unicode, str2bool, safe_int
 from rhodecode.lib.auth import (
     LoginRequired, NotAnonymous, HasUserGroupPermissionAnyDecorator,
@@ -52,8 +54,7 b' from rhodecode.model.forms import ('
     UserGroupForm, UserGroupPermsForm, UserIndividualPermissionsForm,
     UserPermissionsForm)
 from rhodecode.model.meta import Session
-from rhodecode.lib.utils import action_logger
-from rhodecode.lib.ext_json import json
+
 
 log = logging.getLogger(__name__)
 
@@ -105,8 +106,6 b' class UserGroupsController(BaseControlle'
     # permission check inside
     @NotAnonymous()
     def index(self):
-        """GET /users_groups: All items in the collection"""
-        # url('users_groups')
 
         from rhodecode.lib.utils import PartialRenderer
         _render = PartialRenderer('data_table/_dt_elements.mako')
@@ -142,8 +141,6 b' class UserGroupsController(BaseControlle'
     @HasPermissionAnyDecorator('hg.admin', 'hg.usergroup.create.true')
     @auth.CSRFRequired()
     def create(self):
-        """POST /users_groups: Create a new item"""
-        # url('users_groups')
 
         users_group_form = UserGroupForm()()
         try:
@@ -154,14 +151,16 b' class UserGroupsController(BaseControlle'
                 owner=c.rhodecode_user.user_id,
                 active=form_result['users_group_active'])
             Session().flush()
-
+            creation_data = user_group.get_api_data()
             user_group_name = form_result['users_group_name']
-            action_logger(c.rhodecode_user,
-                          'admin_created_users_group:%s' % user_group_name,
-                          None, self.ip_addr, self.sa)
-            user_group_link = h.link_to(h.escape(user_group_name),
-                                        url('edit_users_group',
-                                            user_group_id=user_group.users_group_id))
+
+            audit_logger.store_web(
+                'user_group.create', action_data={'data': creation_data},
+                user=c.rhodecode_user)
+
+            user_group_link = h.link_to(
+                h.escape(user_group_name),
+                url('edit_users_group', user_group_id=user_group.users_group_id))
             h.flash(h.literal(_('Created user group %(user_group_link)s')
                               % {'user_group_link': user_group_link}),
                     category='success')
@@ -191,13 +190,6 b' class UserGroupsController(BaseControlle'
     @HasUserGroupPermissionAnyDecorator('usergroup.admin')
     @auth.CSRFRequired()
     def update(self, user_group_id):
-        """PUT /user_groups/user_group_id: Update an existing item"""
-        # Forms posted to this method should contain a hidden field:
-        #    <input type="hidden" name="_method" value="PUT" />
-        # Or using helpers:
-        #    h.form(url('users_group', user_group_id=ID),
-        #           method='put')
-        # url('users_group', user_group_id=ID)
 
         user_group_id = safe_int(user_group_id)
         c.user_group = UserGroup.get_or_404(user_group_id)
@@ -207,16 +199,22 b' class UserGroupsController(BaseControlle'
         users_group_form = UserGroupForm(
             edit=True, old_data=c.user_group.get_dict(), allow_disabled=True)()
 
+        old_values = c.user_group.get_api_data()
         try:
             form_result = users_group_form.to_python(request.POST)
             pstruct = peppercorn.parse(request.POST.items())
             form_result['users_group_members'] = pstruct['user_group_members']
 
-            UserGroupModel().update(c.user_group, form_result)
+            user_group, added_members, removed_members = \
+                UserGroupModel().update(c.user_group, form_result)
             updated_user_group = form_result['users_group_name']
-            action_logger(c.rhodecode_user,
-                          'admin_updated_users_group:%s' % updated_user_group,
-                          None, self.ip_addr, self.sa)
+
+            audit_logger.store_web(
+                'user_group.edit', action_data={'old_data': old_values},
+                user=c.rhodecode_user)
+
+            # TODO(marcink): use added/removed to set user_group.edit.member.add
+
             h.flash(_('Updated user group %s') % updated_user_group,
                     category='success')
             Session().commit()
@@ -241,19 +239,16 b' class UserGroupsController(BaseControlle'
     @HasUserGroupPermissionAnyDecorator('usergroup.admin')
     @auth.CSRFRequired()
     def delete(self, user_group_id):
-        """DELETE /user_groups/user_group_id: Delete an existing item"""
-        # Forms posted to this method should contain a hidden field:
-        #    <input type="hidden" name="_method" value="DELETE" />
-        # Or using helpers:
-        #    h.form(url('users_group', user_group_id=ID),
-        #           method='delete')
-        # url('users_group', user_group_id=ID)
         user_group_id = safe_int(user_group_id)
         c.user_group = UserGroup.get_or_404(user_group_id)
         force = str2bool(request.POST.get('force'))
 
+        old_values = c.user_group.get_api_data()
         try:
             UserGroupModel().delete(c.user_group, force=force)
+            audit_logger.store_web(
+                'user.delete', action_data={'old_data': old_values},
+                user=c.rhodecode_user)
             Session().commit()
             h.flash(_('Successfully deleted user group'), category='success')
         except UserGroupAssignedException as e:
@@ -330,9 +325,9 b' class UserGroupsController(BaseControlle'
         except RepoGroupAssignmentError:
             h.flash(_('Target group cannot be the same'), category='error')
             return redirect(url('edit_user_group_perms', user_group_id=user_group_id))
-        #TODO: implement this
-        #action_logger(c.rhodecode_user, 'admin_changed_repo_permissions',
-        #              repo_name, self.ip_addr, self.sa)
+
+        # TODO(marcink): implement global permissions
+        # audit_log.store_web('user_group.edit.permissions')
         Session().commit()
         h.flash(_('User Group permissions updated'), category='success')
         return redirect(url('edit_user_group_perms', user_group_id=user_group_id))
@@ -389,8 +384,6 b' class UserGroupsController(BaseControlle'
     @HasUserGroupPermissionAnyDecorator('usergroup.admin')
     @auth.CSRFRequired()
     def update_global_perms(self, user_group_id):
-        """PUT /users_perm/user_group_id: Update an existing item"""
-        # url('users_group_perm', user_group_id=ID, method='put')
         user_group_id = safe_int(user_group_id)
         user_group = UserGroup.get_or_404(user_group_id)
         c.active = 'global_perms'
@@ -492,6 +485,9 b' class UserGroupsController(BaseControlle'
     @XHRRequired()
     @jsonify
     def user_group_members(self, user_group_id):
+        """
+        Return members of given user group
+        """
         user_group_id = safe_int(user_group_id)
         user_group = UserGroup.get_or_404(user_group_id)
         group_members_obj = sorted((x.user for x in user_group.members),
@@ -500,8 +496,8 b' class UserGroupsController(BaseControlle'
         group_members = [
             {
                 'id': user.user_id,
-                'first_name': user.name,
-                'last_name': user.lastname,
+                'first_name': user.first_name,
+                'last_name': user.last_name,
                 'username': user.username,
                 'icon_link': h.gravatar_url(user.email, 30),
                 'value_display': h.person(user.email),

rhodecode/controllers/admin/users.py

@@ -31,15 +31,17 b' from pylons.controllers.util import redi'
 from pylons.i18n.translation import _
 
 from rhodecode.authentication.plugins import auth_rhodecode
+
+from rhodecode.lib import helpers as h
+from rhodecode.lib import auth
+from rhodecode.lib import audit_logger
+from rhodecode.lib.auth import (
+    LoginRequired, HasPermissionAllDecorator, AuthUser)
+from rhodecode.lib.base import BaseController, render
 from rhodecode.lib.exceptions import (
     DefaultUserException, UserOwnsReposException, UserOwnsRepoGroupsException,
     UserOwnsUserGroupsException, UserCreationError)
-from rhodecode.lib import helpers as h
-from rhodecode.lib import auth
-from rhodecode.lib.auth import (
-    LoginRequired, HasPermissionAllDecorator, AuthUser, generate_auth_token)
-from rhodecode.lib.base import BaseController, render
-from rhodecode.model.auth_token import AuthTokenModel
+from rhodecode.lib.utils2 import safe_int, AttributeDict
 
 from rhodecode.model.db import (
     PullRequestReviewers, User, UserEmailMap, UserIpMap, RepoGroup)
@@ -49,8 +51,6 b' from rhodecode.model.repo_group import R'
 from rhodecode.model.user import UserModel
 from rhodecode.model.meta import Session
 from rhodecode.model.permission import PermissionModel
-from rhodecode.lib.utils import action_logger
-from rhodecode.lib.utils2 import datetime_to_time, safe_int, AttributeDict
 
 log = logging.getLogger(__name__)
 
@@ -88,7 +88,6 b' class UsersController(BaseController):'
     @HasPermissionAllDecorator('hg.admin')
     @auth.CSRFRequired()
     def create(self):
-        """POST /users: Create a new item"""
         c.default_extern_type = auth_rhodecode.RhodeCodeAuthPlugin.name
         user_model = UserModel()
         user_form = UserForm()()
@@ -96,9 +95,12 b' class UsersController(BaseController):'
             form_result = user_form.to_python(dict(request.POST))
             user = user_model.create(form_result)
             Session().flush()
+            creation_data = user.get_api_data()
             username = form_result['username']
-            action_logger(c.rhodecode_user, 'admin_created_user:%s' % username,
-                          None, self.ip_addr, self.sa)
+
+            audit_logger.store_web(
+                'user.create', action_data={'data': creation_data},
+                user=c.rhodecode_user)
 
             user_link = h.link_to(h.escape(username),
                                   url('edit_user',
@@ -125,8 +127,6 b' class UsersController(BaseController):'
 
     @HasPermissionAllDecorator('hg.admin')
     def new(self):
-        """GET /users/new: Form to create a new item"""
-        # url('new_user')
         c.default_extern_type = auth_rhodecode.RhodeCodeAuthPlugin.name
         self._get_personal_repo_group_template_vars()
         return render('admin/users/user_add.mako')
@@ -134,13 +134,7 b' class UsersController(BaseController):'
     @HasPermissionAllDecorator('hg.admin')
     @auth.CSRFRequired()
     def update(self, user_id):
-        """PUT /users/user_id: Update an existing item"""
-        # Forms posted to this method should contain a hidden field:
-        # <input type="hidden" name="_method" value="PUT" />
-        # Or using helpers:
-        #    h.form(url('update_user', user_id=ID),
-        #           method='put')
-        # url('user', user_id=ID)
+
         user_id = safe_int(user_id)
         c.user = User.get_or_404(user_id)
         c.active = 'profile'
@@ -152,6 +146,7 b' class UsersController(BaseController):'
                          old_data={'user_id': user_id,
                                    'email': c.user.email})()
         form_result = {}
+        old_values = c.user.get_api_data()
         try:
             form_result = _form.to_python(dict(request.POST))
             skip_attrs = ['extern_type', 'extern_name']
@@ -160,12 +155,15 b' class UsersController(BaseController):'
                 # forbid updating username for external accounts
                 skip_attrs.append('username')
 
-            UserModel().update_user(user_id, skip_attrs=skip_attrs, **form_result)
-            usr = form_result['username']
-            action_logger(c.rhodecode_user, 'admin_updated_user:%s' % usr,
-                          None, self.ip_addr, self.sa)
+            UserModel().update_user(
+                user_id, skip_attrs=skip_attrs, **form_result)
+
+            audit_logger.store_web(
+                'user.edit', action_data={'old_data': old_values},
+                user=c.rhodecode_user)
+
+            Session().commit()
             h.flash(_('User updated successfully'), category='success')
-            Session().commit()
         except formencode.Invalid as errors:
             defaults = errors.value
             e = errors.error_dict or {}
@@ -188,13 +186,6 b' class UsersController(BaseController):'
     @HasPermissionAllDecorator('hg.admin')
     @auth.CSRFRequired()
     def delete(self, user_id):
-        """DELETE /users/user_id: Delete an existing item"""
-        # Forms posted to this method should contain a hidden field:
-        # <input type="hidden" name="_method" value="DELETE" />
-        # Or using helpers:
-        #    h.form(url('delete_user', user_id=ID),
-        #           method='delete')
-        # url('user', user_id=ID)
         user_id = safe_int(user_id)
         c.user = User.get_or_404(user_id)
 
@@ -249,10 +240,16 b' class UsersController(BaseController):'
                     _('Deleted %s user groups') % len(_user_groups),
                     category='success')
 
+        old_values = c.user.get_api_data()
         try:
             UserModel().delete(c.user, handle_repos=handle_repos,
                                handle_repo_groups=handle_repo_groups,
                                handle_user_groups=handle_user_groups)
+
+            audit_logger.store_web(
+                'user.delete', action_data={'old_data': old_values},
+                user=c.rhodecode_user)
+
             Session().commit()
             set_handle_flash_repos()
             set_handle_flash_repo_groups()
@@ -272,19 +269,25 b' class UsersController(BaseController):'
     def reset_password(self, user_id):
         """
         toggle reset password flag for this user
-
-        :param user_id:
         """
         user_id = safe_int(user_id)
         c.user = User.get_or_404(user_id)
         try:
             old_value = c.user.user_data.get('force_password_change')
             c.user.update_userdata(force_password_change=not old_value)
-            Session().commit()
+
             if old_value:
                 msg = _('Force password change disabled for user')
+                audit_logger.store_web(
+                    'user.edit.password_reset.disabled',
+                    user=c.rhodecode_user)
             else:
                 msg = _('Force password change enabled for user')
+                audit_logger.store_web(
+                    'user.edit.password_reset.enabled',
+                    user=c.rhodecode_user)
+
+            Session().commit()
             h.flash(msg, category='success')
         except Exception:
             log.exception("Exception during password reset for user")
@@ -298,8 +301,6 b' class UsersController(BaseController):'
     def create_personal_repo_group(self, user_id):
         """
         Create personal repository group for this user
-
-        :param user_id:
         """
         from rhodecode.model.repo_group import RepoGroupModel
 
@@ -381,8 +382,7 b' class UsersController(BaseController):'
             return redirect(h.route_path('users'))
 
         c.active = 'advanced'
-        c.perm_user = AuthUser(user_id=user_id, ip_addr=self.ip_addr)
-        c.personal_repo_group = c.perm_user.personal_repo_group
+        c.personal_repo_group = RepoGroup.get_user_personal_repo_group(user_id)
         c.personal_repo_group_name = RepoGroupModel()\
             .get_personal_group_name(user)
         c.first_admin = User.get_first_super_admin()
@@ -429,8 +429,6 b' class UsersController(BaseController):'
     @HasPermissionAllDecorator('hg.admin')
     @auth.CSRFRequired()
     def update_global_perms(self, user_id):
-        """PUT /users_perm/user_id: Update an existing item"""
-        # url('user_perm', user_id=ID, method='put')
         user_id = safe_int(user_id)
         user = User.get_or_404(user_id)
         c.active = 'global_perms'
@@ -457,11 +455,13 b' class UsersController(BaseController):'
 
                 PermissionModel().update_user_permissions(form_result)
 
+            # TODO(marcink): implement global permissions
+            # audit_log.store_web('user.edit.permissions')
+
             Session().commit()
             h.flash(_('User global permissions updated successfully'),
                     category='success')
 
-            Session().commit()
         except formencode.Invalid as errors:
             defaults = errors.value
             c.user = user
@@ -491,140 +491,3 b' class UsersController(BaseController):'
 
         return render('admin/users/user_edit.mako')
 
-    @HasPermissionAllDecorator('hg.admin')
-    def edit_emails(self, user_id):
-        user_id = safe_int(user_id)
-        c.user = User.get_or_404(user_id)
-        if c.user.username == User.DEFAULT_USER:
-            h.flash(_("You can't edit this user"), category='warning')
-            return redirect(h.route_path('users'))
-
-        c.active = 'emails'
-        c.user_email_map = UserEmailMap.query() \
-            .filter(UserEmailMap.user == c.user).all()
-
-        defaults = c.user.get_dict()
-        return htmlfill.render(
-            render('admin/users/user_edit.mako'),
-            defaults=defaults,
-            encoding="UTF-8",
-            force_defaults=False)
-
-    @HasPermissionAllDecorator('hg.admin')
-    @auth.CSRFRequired()
-    def add_email(self, user_id):
-        """POST /user_emails:Add an existing item"""
-        # url('user_emails', user_id=ID, method='put')
-        user_id = safe_int(user_id)
-        c.user = User.get_or_404(user_id)
-
-        email = request.POST.get('new_email')
-        user_model = UserModel()
-
-        try:
-            user_model.add_extra_email(user_id, email)
-            Session().commit()
-            h.flash(_("Added new email address `%s` for user account") % email,
-                    category='success')
-        except formencode.Invalid as error:
-            msg = error.error_dict['email']
-            h.flash(msg, category='error')
-        except Exception:
-            log.exception("Exception during email saving")
-            h.flash(_('An error occurred during email saving'),
-                    category='error')
-        return redirect(url('edit_user_emails', user_id=user_id))
-
-    @HasPermissionAllDecorator('hg.admin')
-    @auth.CSRFRequired()
-    def delete_email(self, user_id):
-        """DELETE /user_emails_delete/user_id: Delete an existing item"""
-        # url('user_emails_delete', user_id=ID, method='delete')
-        user_id = safe_int(user_id)
-        c.user = User.get_or_404(user_id)
-        email_id = request.POST.get('del_email_id')
-        user_model = UserModel()
-        user_model.delete_extra_email(user_id, email_id)
-        Session().commit()
-        h.flash(_("Removed email address from user account"), category='success')
-        return redirect(url('edit_user_emails', user_id=user_id))
-
-    @HasPermissionAllDecorator('hg.admin')
-    def edit_ips(self, user_id):
-        user_id = safe_int(user_id)
-        c.user = User.get_or_404(user_id)
-        if c.user.username == User.DEFAULT_USER:
-            h.flash(_("You can't edit this user"), category='warning')
-            return redirect(h.route_path('users'))
-
-        c.active = 'ips'
-        c.user_ip_map = UserIpMap.query() \
-            .filter(UserIpMap.user == c.user).all()
-
-        c.inherit_default_ips = c.user.inherit_default_permissions
-        c.default_user_ip_map = UserIpMap.query() \
-            .filter(UserIpMap.user == User.get_default_user()).all()
-
-        defaults = c.user.get_dict()
-        return htmlfill.render(
-            render('admin/users/user_edit.mako'),
-            defaults=defaults,
-            encoding="UTF-8",
-            force_defaults=False)
-
-    @HasPermissionAllDecorator('hg.admin')
-    @auth.CSRFRequired()
-    def add_ip(self, user_id):
-        """POST /user_ips:Add an existing item"""
-        # url('user_ips', user_id=ID, method='put')
-
-        user_id = safe_int(user_id)
-        c.user = User.get_or_404(user_id)
-        user_model = UserModel()
-        try:
-            ip_list = user_model.parse_ip_range(request.POST.get('new_ip'))
-        except Exception as e:
-            ip_list = []
-            log.exception("Exception during ip saving")
-            h.flash(_('An error occurred during ip saving:%s' % (e,)),
-                    category='error')
-
-        desc = request.POST.get('description')
-        added = []
-        for ip in ip_list:
-            try:
-                user_model.add_extra_ip(user_id, ip, desc)
-                Session().commit()
-                added.append(ip)
-            except formencode.Invalid as error:
-                msg = error.error_dict['ip']
-                h.flash(msg, category='error')
-            except Exception:
-                log.exception("Exception during ip saving")
-                h.flash(_('An error occurred during ip saving'),
-                        category='error')
-        if added:
-            h.flash(
-                _("Added ips %s to user whitelist") % (', '.join(ip_list), ),
-                category='success')
-        if 'default_user' in request.POST:
-            return redirect(url('admin_permissions_ips'))
-        return redirect(url('edit_user_ips', user_id=user_id))
-
-    @HasPermissionAllDecorator('hg.admin')
-    @auth.CSRFRequired()
-    def delete_ip(self, user_id):
-        """DELETE /user_ips_delete/user_id: Delete an existing item"""
-        # url('user_ips_delete', user_id=ID, method='delete')
-        user_id = safe_int(user_id)
-        c.user = User.get_or_404(user_id)
-
-        ip_id = request.POST.get('del_ip_id')
-        user_model = UserModel()
-        user_model.delete_extra_ip(user_id, ip_id)
-        Session().commit()
-        h.flash(_("Removed ip address from user whitelist"), category='success')
-
-        if 'default_user' in request.POST:
-            return redirect(url('admin_permissions_ips'))
-        return redirect(url('edit_user_ips', user_id=user_id))

rhodecode/controllers/changelog.py

@@ -46,27 +46,6 b' log = logging.getLogger(__name__)'
 DEFAULT_CHANGELOG_SIZE = 20
 
 
-def _load_changelog_summary():
-    p = safe_int(request.GET.get('page'), 1)
-    size = safe_int(request.GET.get('size'), 10)
-
-    def url_generator(**kw):
-        return url('summary_home',
-                   repo_name=c.rhodecode_db_repo.repo_name, size=size, **kw)
-
-    pre_load = ['author', 'branch', 'date', 'message']
-    try:
-        collection = c.rhodecode_repo.get_commits(pre_load=pre_load)
-    except EmptyRepositoryError:
-        collection = c.rhodecode_repo
-
-    c.repo_commits = RepoPage(
-        collection, page=p, items_per_page=size, url=url_generator)
-    page_ids = [x.raw_id for x in c.repo_commits]
-    c.comments = c.rhodecode_db_repo.get_comments(page_ids)
-    c.statuses = c.rhodecode_db_repo.statuses(page_ids)
-
-
 class ChangelogController(BaseRepoController):
 
     def __before__(self):
@@ -88,13 +67,11 b' class ChangelogController(BaseRepoContro'
         except EmptyRepositoryError:
             if not redirect_after:
                 return None
-            h.flash(h.literal(_('There are no commits yet')),
-                    category='warning')
+            h.flash(_('There are no commits yet'), category='warning')
             redirect(url('changelog_home', repo_name=repo.repo_name))
         except RepositoryError as e:
-            msg = safe_str(e)
-            log.exception(msg)
-            h.flash(msg, category='warning')
+            log.exception(safe_str(e))
+            h.flash(safe_str(h.escape(e)), category='warning')
             if not partial:
                 redirect(h.url('changelog_home', repo_name=repo.repo_name))
             raise HTTPBadRequest()
@@ -134,7 +111,7 b' class ChangelogController(BaseRepoContro'
 
     def _check_if_valid_branch(self, branch_name, repo_name, f_path):
         if branch_name not in c.rhodecode_repo.branches_all:
-            h.flash('Branch {} is not found.'.format(branch_name),
+            h.flash('Branch {} is not found.'.format(h.escape(branch_name)),
                     category='warning')
             redirect(url('changelog_file_home', repo_name=repo_name,
                          revision=branch_name, f_path=f_path or ''))
@@ -210,12 +187,11 b' class ChangelogController(BaseRepoContro'
                 collection, p, chunk_size, c.branch_name, dynamic=f_path)
 
         except EmptyRepositoryError as e:
-            h.flash(safe_str(e), category='warning')
-            return redirect(url('summary_home', repo_name=repo_name))
+            h.flash(safe_str(h.escape(e)), category='warning')
+            return redirect(h.route_path('repo_summary', repo_name=repo_name))
         except (RepositoryError, CommitDoesNotExistError, Exception) as e:
-            msg = safe_str(e)
-            log.exception(msg)
-            h.flash(msg, category='error')
+            log.exception(safe_str(e))
+            h.flash(safe_str(h.escape(e)), category='error')
             return redirect(url('changelog_home', repo_name=repo_name))
 
         if (request.environ.get('HTTP_X_PARTIAL_XHR')
@@ -279,12 +255,3 b' class ChangelogController(BaseRepoContro'
             c.rhodecode_repo, c.pagination,
             prev_data=prev_data, next_data=next_data)
         return render('changelog/changelog_elements.mako')
-
-    @LoginRequired()
-    @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
-                                   'repository.admin')
-    def changelog_summary(self, repo_name):
-        if request.environ.get('HTTP_X_PJAX'):
-            _load_changelog_summary()
-            return render('changelog/changelog_summary_data.mako')
-        raise HTTPNotFound()

rhodecode/controllers/changeset.py

@@ -39,8 +39,8 b' from rhodecode.lib.base import BaseRepoC'
 from rhodecode.lib.compat import OrderedDict
 from rhodecode.lib.exceptions import StatusChangeOnClosedPullRequestError
 import rhodecode.lib.helpers as h
-from rhodecode.lib.utils import action_logger, jsonify
-from rhodecode.lib.utils2 import safe_unicode
+from rhodecode.lib.utils import jsonify
+from rhodecode.lib.utils2 import safe_unicode, safe_int
 from rhodecode.lib.vcs.backends.base import EmptyCommit
 from rhodecode.lib.vcs.exceptions import (
     RepositoryError, CommitDoesNotExistError, NodeDoesNotExistError)
@@ -48,7 +48,6 b' from rhodecode.model.db import Changeset'
 from rhodecode.model.changeset_status import ChangesetStatusModel
 from rhodecode.model.comment import CommentsModel
 from rhodecode.model.meta import Session
-from rhodecode.model.repo import RepoModel
 
 
 log = logging.getLogger(__name__)
@@ -268,8 +267,10 b' class ChangesetController(BaseRepoContro'
                     repo_name=c.repo_name,
                     source_node_getter=_node_getter(commit1),
                     target_node_getter=_node_getter(commit2),
-                    comments=inline_comments
-                ).render_patchset(_parsed, commit1.raw_id, commit2.raw_id)
+                    comments=inline_comments)
+                diffset = diffset.render_patchset(
+                    _parsed, commit1.raw_id, commit2.raw_id)
+
                 c.changes[commit.raw_id] = diffset
             else:
                 # downloads/raw we only need RAW diff nothing else
@@ -368,7 +369,6 b' class ChangesetController(BaseRepoContro'
                 comment_type=comment_type,
                 resolves_comment_id=resolves_comment_id
             )
-            c.inline_comment = True if comment.line_no else False
 
             # get status if set !
             if status:
@@ -433,20 +433,26 b' class ChangesetController(BaseRepoContro'
     @auth.CSRFRequired()
     @jsonify
     def delete_comment(self, repo_name, comment_id):
-        comment = ChangesetComment.get(comment_id)
+        comment = ChangesetComment.get_or_404(safe_int(comment_id))
         if not comment:
             log.debug('Comment with id:%s not found, skipping', comment_id)
             # comment already deleted in another call probably
             return True
 
-        owner = (comment.author.user_id == c.rhodecode_user.user_id)
         is_repo_admin = h.HasRepoPermissionAny('repository.admin')(c.repo_name)
-        if h.HasPermissionAny('hg.admin')() or is_repo_admin or owner:
-            CommentsModel().delete(comment=comment)
+        super_admin = h.HasPermissionAny('hg.admin')()
+        comment_owner = (comment.author.user_id == c.rhodecode_user.user_id)
+        is_repo_comment = comment.repo.repo_name == c.repo_name
+        comment_repo_admin = is_repo_admin and is_repo_comment
+
+        if super_admin or comment_owner or comment_repo_admin:
+            CommentsModel().delete(comment=comment, user=c.rhodecode_user)
             Session().commit()
             return True
         else:
-            raise HTTPForbidden()
+            log.warning('No permissions for user %s to delete comment_id: %s',
+                        c.rhodecode_user, comment_id)
+            raise HTTPNotFound()
 
     @LoginRequired()
     @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',

rhodecode/controllers/compare.py

@@ -24,7 +24,7 b' Compare controller for showing differenc'
 
 import logging
 
-from webob.exc import HTTPBadRequest
+from webob.exc import HTTPBadRequest, HTTPNotFound
 from pylons import request, tmpl_context as c, url
 from pylons.controllers.util import redirect
 from pylons.i18n.translation import _
@@ -63,14 +63,13 b' class CompareController(BaseRepoControll'
                 return repo.scm_instance().EMPTY_COMMIT
             h.flash(h.literal(_('There are no commits yet')),
                     category='warning')
-            redirect(url('summary_home', repo_name=repo.repo_name))
+            redirect(h.route_path('repo_summary', repo_name=repo.repo_name))
 
         except RepositoryError as e:
-            msg = safe_str(e)
-            log.exception(msg)
-            h.flash(msg, category='warning')
+            log.exception(safe_str(e))
+            h.flash(safe_str(h.escape(e)), category='warning')
             if not partial:
-                redirect(h.url('summary_home', repo_name=repo.repo_name))
+                redirect(h.route_path('repo_summary', repo_name=repo.repo_name))
             raise HTTPBadRequest()
 
     @LoginRequired()
@@ -86,6 +85,10 b' class CompareController(BaseRepoControll'
         target_repo = request.GET.get('target_repo', source_repo)
         c.source_repo = Repository.get_by_repo_name(source_repo)
         c.target_repo = Repository.get_by_repo_name(target_repo)
+
+        if c.source_repo is None or c.target_repo is None:
+            raise HTTPNotFound()
+
         c.source_ref = c.target_ref = _('Select commit')
         c.source_ref_type = ""
         c.target_ref_type = ""
@@ -141,18 +144,17 b' class CompareController(BaseRepoControll'
         target_repo = Repository.get_by_repo_name(target_repo_name)
 
         if source_repo is None:
-            msg = _('Could not find the original repo: %(repo)s') % {
-                'repo': source_repo}
-
-            log.error(msg)
-            h.flash(msg, category='error')
+            log.error('Could not find the source repo: {}'
+                      .format(source_repo_name))
+            h.flash(_('Could not find the source repo: `{}`')
+                    .format(h.escape(source_repo_name)), category='error')
             return redirect(url('compare_home', repo_name=c.repo_name))
 
         if target_repo is None:
-            msg = _('Could not find the other repo: %(repo)s') % {
-                'repo': target_repo_name}
-            log.error(msg)
-            h.flash(msg, category='error')
+            log.error('Could not find the target repo: {}'
+                      .format(source_repo_name))
+            h.flash(_('Could not find the target repo: `{}`')
+                    .format(h.escape(target_repo_name)), category='error')
             return redirect(url('compare_home', repo_name=c.repo_name))
 
         source_scm = source_repo.scm_instance()
@@ -269,11 +271,13 b' class CompareController(BaseRepoControll'
                     return None
             return get_node
 
-        c.diffset = codeblocks.DiffSet(
+        diffset = codeblocks.DiffSet(
             repo_name=source_repo.repo_name,
             source_node_getter=_node_getter(source_commit),
             target_node_getter=_node_getter(target_commit),
-        ).render_patchset(_parsed, source_ref, target_ref)
+        )
+        c.diffset = diffset.render_patchset(
+            _parsed, source_ref, target_ref)
 
         c.preview_mode = merge
         c.source_commit = source_commit

rhodecode/controllers/feed.py

@@ -113,7 +113,7 b' class FeedController(BaseRepoController)'
         def _generate_feed(cache_key):
             feed = Atom1Feed(
                 title=self.title % repo_name,
-                link=url('summary_home', repo_name=repo_name, qualified=True),
+                link=h.route_url('repo_summary', repo_name=repo_name),
                 description=self.description % repo_name,
                 language=self.language,
                 ttl=self.ttl
@@ -150,8 +150,7 b' class FeedController(BaseRepoController)'
         def _generate_feed(cache_key):
             feed = Rss201rev2Feed(
                 title=self.title % repo_name,
-                link=url('summary_home', repo_name=repo_name,
-                         qualified=True),
+                link=h.route_url('repo_summary', repo_name=repo_name),
                 description=self.description % repo_name,
                 language=self.language,
                 ttl=self.ttl

rhodecode/controllers/files.py

@@ -35,10 +35,10 b' from webob.exc import HTTPNotFound, HTTP'
 
 from rhodecode.controllers.utils import parse_path_ref
 from rhodecode.lib import diffs, helpers as h, caches
-from rhodecode.lib.compat import OrderedDict
+from rhodecode.lib import audit_logger
 from rhodecode.lib.codeblocks import (
     filenode_as_lines_tokens, filenode_as_annotated_lines_tokens)
-from rhodecode.lib.utils import jsonify, action_logger
+from rhodecode.lib.utils import jsonify
 from rhodecode.lib.utils2 import (
     convert_line_endings, detect_mode, safe_str, str2bool)
 from rhodecode.lib.auth import (
@@ -101,13 +101,13 b' class FilesController(BaseRepoController'
                 add_new = ""
             h.flash(h.literal(
                 _('There are no files yet. %s') % add_new), category='warning')
-            redirect(h.url('summary_home', repo_name=repo_name))
+            redirect(h.route_path('repo_summary', repo_name=repo_name))
         except (CommitDoesNotExistError, LookupError):
             msg = _('No such commit exists for this repository')
             h.flash(msg, category='error')
             raise HTTPNotFound()
         except RepositoryError as e:
-            h.flash(safe_str(e), category='error')
+            h.flash(safe_str(h.escape(e)), category='error')
             raise HTTPNotFound()
 
     def __get_filenode_or_redirect(self, repo_name, commit, path):
@@ -124,12 +124,11 b' class FilesController(BaseRepoController'
             if file_node.is_dir():
                 raise RepositoryError('The given path is a directory')
         except CommitDoesNotExistError:
-            msg = _('No such commit exists for this repository')
-            log.exception(msg)
-            h.flash(msg, category='error')
+            log.exception('No such commit exists for this repository')
+            h.flash(_('No such commit exists for this repository'), category='error')
             raise HTTPNotFound()
         except RepositoryError as e:
-            h.flash(safe_str(e), category='error')
+            h.flash(safe_str(h.escape(e)), category='error')
             raise HTTPNotFound()
 
         return file_node
@@ -257,7 +256,7 b' class FilesController(BaseRepoController'
                     repo_name, c.commit.raw_id, f_path)
 
         except RepositoryError as e:
-            h.flash(safe_str(e), category='error')
+            h.flash(safe_str(h.escape(e)), category='error')
             raise HTTPNotFound()
 
         if request.environ.get('HTTP_X_PJAX'):
@@ -450,7 +449,7 b' class FilesController(BaseRepoController'
         c.file = self.__get_filenode_or_redirect(repo_name, c.commit, f_path)
 
         c.default_message = _(
-            'Deleted file %s via RhodeCode Enterprise') % (f_path)
+            'Deleted file {} via RhodeCode Enterprise').format(f_path)
         c.f_path = f_path
         node_path = f_path
         author = c.rhodecode_user.full_contact
@@ -469,12 +468,12 b' class FilesController(BaseRepoController'
                 author=author,
             )
 
-            h.flash(_('Successfully deleted file %s') % f_path,
-                    category='success')
+            h.flash(
+                _('Successfully deleted file `{}`').format(
+                    h.escape(f_path)), category='success')
         except Exception:
-            msg = _('Error occurred during commit')
-            log.exception(msg)
-            h.flash(msg, category='error')
+            log.exception('Error during commit operation')
+            h.flash(_('Error occurred during commit'), category='error')
         return redirect(url('changeset_home',
                             repo_name=c.repo_name, revision='tip'))
 
@@ -503,7 +502,7 b' class FilesController(BaseRepoController'
         c.file = self.__get_filenode_or_redirect(repo_name, c.commit, f_path)
 
         c.default_message = _(
-            'Deleted file %s via RhodeCode Enterprise') % (f_path)
+            'Deleted file {} via RhodeCode Enterprise').format(f_path)
         c.f_path = f_path
 
         return render('files/files_delete.mako')
@@ -537,7 +536,7 b' class FilesController(BaseRepoController'
             return redirect(url('files_home', repo_name=c.repo_name,
                             revision=c.commit.raw_id, f_path=f_path))
         c.default_message = _(
-            'Edited file %s via RhodeCode Enterprise') % (f_path)
+            'Edited file {} via RhodeCode Enterprise').format(f_path)
         c.f_path = f_path
         old_content = c.file.content
         sl = old_content.splitlines(1)
@@ -575,12 +574,12 b' class FilesController(BaseRepoController'
                 parent_commit=c.commit,
             )
 
-            h.flash(_('Successfully committed to %s') % f_path,
-                    category='success')
+            h.flash(
+                _('Successfully committed changes to file `{}`').format(
+                    h.escape(f_path)), category='success')
         except Exception:
-            msg = _('Error occurred during commit')
-            log.exception(msg)
-            h.flash(msg, category='error')
+            log.exception('Error occurred during commit')
+            h.flash(_('Error occurred during commit'), category='error')
         return redirect(url('changeset_home',
                             repo_name=c.repo_name, revision='tip'))
 
@@ -612,7 +611,7 b' class FilesController(BaseRepoController'
             return redirect(url('files_home', repo_name=c.repo_name,
                             revision=c.commit.raw_id, f_path=f_path))
         c.default_message = _(
-            'Edited file %s via RhodeCode Enterprise') % (f_path)
+            'Edited file {} via RhodeCode Enterprise').format(f_path)
         c.f_path = f_path
 
         return render('files/files_edit.mako')
@@ -660,7 +659,7 b' class FilesController(BaseRepoController'
         file_obj = r_post.get('upload_file', None)
 
         if file_obj is not None and hasattr(file_obj, 'filename'):
-            filename = file_obj.filename
+            filename = r_post.get('filename_upload')
             content = file_obj.file
 
             if hasattr(content, 'file'):
@@ -669,14 +668,14 b' class FilesController(BaseRepoController'
 
         # If there's no commit, redirect to repo summary
         if type(c.commit) is EmptyCommit:
-            redirect_url = "summary_home"
+            redirect_url = h.route_path('repo_summary', repo_name=c.repo_name)
         else:
-            redirect_url = "changeset_home"
+            redirect_url = url("changeset_home", repo_name=c.repo_name,
+                               revision='tip')
 
         if not filename:
             h.flash(_('No filename'), category='warning')
-            return redirect(url(redirect_url, repo_name=c.repo_name,
-                                revision='tip'))
+            return redirect(redirect_url)
 
         # extract the location from filename,
         # allows using foo/bar.txt syntax to create subdirectories
@@ -704,8 +703,9 b' class FilesController(BaseRepoController'
                 author=author,
             )
 
-            h.flash(_('Successfully committed to %s') % node_path,
-                    category='success')
+            h.flash(
+                _('Successfully committed new file `{}`').format(
+                    h.escape(node_path)), category='success')
         except NonRelativePathError as e:
             h.flash(_(
                 'The location specified must be a relative path and must not '
@@ -713,11 +713,10 b' class FilesController(BaseRepoController'
             return redirect(url('changeset_home', repo_name=c.repo_name,
                                 revision='tip'))
         except (NodeError, NodeAlreadyExistsError) as e:
-            h.flash(_(e), category='error')
+            h.flash(_(h.escape(e)), category='error')
         except Exception:
-            msg = _('Error occurred during commit')
-            log.exception(msg)
-            h.flash(msg, category='error')
+            log.exception('Error occurred during commit')
+            h.flash(_('Error occurred during commit'), category='error')
         return redirect(url('changeset_home',
                             repo_name=c.repo_name, revision='tip'))
 
@@ -801,7 +800,7 b' class FilesController(BaseRepoController'
         if not use_cached_archive:
             # generate new archive
             fd, archive = tempfile.mkstemp()
-            log.debug('Creating new temp archive in %s' % (archive,))
+            log.debug('Creating new temp archive in %s', archive)
             try:
                 commit.archive_repo(archive, kind=fileformat, subrepos=subrepos)
             except ImproperArchiveTypeError:
@@ -809,10 +808,26 b' class FilesController(BaseRepoController'
             if archive_cache_enabled:
                 # if we generated the archive and we have cache enabled
                 # let's use this for future
-                log.debug('Storing new archive in %s' % (cached_archive_path,))
+                log.debug('Storing new archive in %s', cached_archive_path)
                 shutil.move(archive, cached_archive_path)
                 archive = cached_archive_path
 
+        # store download action
+        audit_logger.store_web(
+            'repo.archive.download', action_data={
+                'user_agent': request.user_agent,
+                'archive_name': archive_name,
+                'archive_spec': fname,
+                'archive_cached': use_cached_archive},
+            user=c.rhodecode_user,
+            repo=dbrepo,
+            commit=True
+        )
+
+        response.content_disposition = str(
+            'attachment; filename=%s' % archive_name)
+        response.content_type = str(content_type)
+
         def get_chunked_archive(archive):
             with open(archive, 'rb') as stream:
                 while True:
@@ -826,14 +841,6 b' class FilesController(BaseRepoController'
                         break
                     yield data
 
-        # store download action
-        action_logger(user=c.rhodecode_user,
-                      action='user_downloaded_archive:%s' % archive_name,
-                      repo=repo_name, ipaddr=self.ip_addr, commit=True)
-        response.content_disposition = str(
-            'attachment; filename=%s' % archive_name)
-        response.content_type = str(content_type)
-
         return get_chunked_archive(archive)
 
     @LoginRequired()

rhodecode/controllers/forks.py

@@ -139,7 +139,7 b' class ForksController(BaseRepoController'
         c.repo_info = Repository.get_by_repo_name(repo_name)
         if not c.repo_info:
             h.not_mapped_error(repo_name)
-            return redirect(url('home'))
+            return redirect(h.route_path('home'))
 
         defaults = self.__load_data(repo_name)
 

rhodecode/controllers/home.py

@@ -24,20 +24,15 b' Home controller for RhodeCode Enterprise'
 
 import logging
 import time
-import re
 
-from pylons import tmpl_context as c, request, url, config
-from pylons.i18n.translation import _
-from sqlalchemy.sql import func
+from pylons import tmpl_context as c
 
 from rhodecode.lib.auth import (
-    LoginRequired, HasPermissionAllDecorator, AuthUser,
-    HasRepoGroupPermissionAnyDecorator, XHRRequired)
+    LoginRequired, HasPermissionAllDecorator,
+    HasRepoGroupPermissionAnyDecorator)
 from rhodecode.lib.base import BaseController, render
-from rhodecode.lib.index import searcher_from_config
+
 from rhodecode.lib.ext_json import json
-from rhodecode.lib.utils import jsonify
-from rhodecode.lib.utils2 import safe_unicode, str2bool
 from rhodecode.model.db import Repository, RepoGroup
 from rhodecode.model.repo import RepoModel
 from rhodecode.model.repo_group import RepoGroupModel
@@ -70,221 +65,3 b' class HomeController(BaseController):'
         msg = ('RhodeCode Enterprise %s test exception. Generation time: %s'
                % (c.rhodecode_name, time.time()))
         raise TestException(msg)
-
-    def _get_groups_and_repos(self, repo_group_id=None):
-        # repo groups groups
-        repo_group_list = RepoGroup.get_all_repo_groups(group_id=repo_group_id)
-        _perms = ['group.read', 'group.write', 'group.admin']
-        repo_group_list_acl = RepoGroupList(repo_group_list, perm_set=_perms)
-        repo_group_data = RepoGroupModel().get_repo_groups_as_dict(
-            repo_group_list=repo_group_list_acl, admin=False)
-
-        # repositories
-        repo_list = Repository.get_all_repos(group_id=repo_group_id)
-        _perms = ['repository.read', 'repository.write', 'repository.admin']
-        repo_list_acl = RepoList(repo_list, perm_set=_perms)
-        repo_data = RepoModel().get_repos_as_dict(
-            repo_list=repo_list_acl, admin=False)
-
-        return repo_data, repo_group_data
-
-    @LoginRequired()
-    def index(self):
-        c.repo_group = None
-
-        repo_data, repo_group_data = self._get_groups_and_repos()
-        # json used to render the grids
-        c.repos_data = json.dumps(repo_data)
-        c.repo_groups_data = json.dumps(repo_group_data)
-
-        return render('/index.mako')
-
-    @LoginRequired()
-    @HasRepoGroupPermissionAnyDecorator('group.read', 'group.write',
-                                        'group.admin')
-    def index_repo_group(self, group_name):
-        """GET /repo_group_name: Show a specific item"""
-        c.repo_group = RepoGroupModel()._get_repo_group(group_name)
-        repo_data, repo_group_data = self._get_groups_and_repos(
-            c.repo_group.group_id)
-
-        # json used to render the grids
-        c.repos_data = json.dumps(repo_data)
-        c.repo_groups_data = json.dumps(repo_group_data)
-
-        return render('index_repo_group.mako')
-
-    def _get_repo_list(self, name_contains=None, repo_type=None, limit=20):
-        query = Repository.query()\
-            .order_by(func.length(Repository.repo_name))\
-            .order_by(Repository.repo_name)
-
-        if repo_type:
-            query = query.filter(Repository.repo_type == repo_type)
-
-        if name_contains:
-            ilike_expression = u'%{}%'.format(safe_unicode(name_contains))
-            query = query.filter(
-                Repository.repo_name.ilike(ilike_expression))
-            query = query.limit(limit)
-
-        all_repos = query.all()
-        repo_iter = self.scm_model.get_repos(all_repos)
-        return [
-            {
-                'id': obj['name'],
-                'text': obj['name'],
-                'type': 'repo',
-                'obj': obj['dbrepo'],
-                'url': url('summary_home', repo_name=obj['name'])
-            }
-            for obj in repo_iter]
-
-    def _get_repo_group_list(self, name_contains=None, limit=20):
-        query = RepoGroup.query()\
-            .order_by(func.length(RepoGroup.group_name))\
-            .order_by(RepoGroup.group_name)
-
-        if name_contains:
-            ilike_expression = u'%{}%'.format(safe_unicode(name_contains))
-            query = query.filter(
-                RepoGroup.group_name.ilike(ilike_expression))
-            query = query.limit(limit)
-
-        all_groups = query.all()
-        repo_groups_iter = self.scm_model.get_repo_groups(all_groups)
-        return [
-            {
-                'id': obj.group_name,
-                'text': obj.group_name,
-                'type': 'group',
-                'obj': {},
-                'url': url('repo_group_home', group_name=obj.group_name)
-            }
-            for obj in repo_groups_iter]
-
-    def _get_hash_commit_list(self, hash_starts_with=None, limit=20):
-        if not hash_starts_with or len(hash_starts_with) < 3:
-            return []
-
-        commit_hashes = re.compile('([0-9a-f]{2,40})').findall(hash_starts_with)
-
-        if len(commit_hashes) != 1:
-            return []
-
-        commit_hash_prefix = commit_hashes[0]
-
-        auth_user = AuthUser(
-            user_id=c.rhodecode_user.user_id, ip_addr=self.ip_addr)
-        searcher = searcher_from_config(config)
-        result = searcher.search(
-            'commit_id:%s*' % commit_hash_prefix, 'commit', auth_user,
-            raise_on_exc=False)
-
-        return [
-            {
-                'id': entry['commit_id'],
-                'text': entry['commit_id'],
-                'type': 'commit',
-                'obj': {'repo': entry['repository']},
-                'url': url('changeset_home',
-                           repo_name=entry['repository'],
-                           revision=entry['commit_id'])
-            }
-            for entry in result['results']]
-
-    @LoginRequired()
-    @XHRRequired()
-    @jsonify
-    def goto_switcher_data(self):
-        query = request.GET.get('query')
-        log.debug('generating goto switcher list, query %s', query)
-
-        res = []
-        repo_groups = self._get_repo_group_list(query)
-        if repo_groups:
-            res.append({
-                'text': _('Groups'),
-                'children': repo_groups
-            })
-
-        repos = self._get_repo_list(query)
-        if repos:
-            res.append({
-                'text': _('Repositories'),
-                'children': repos
-            })
-
-        commits = self._get_hash_commit_list(query)
-        if commits:
-            unique_repos = {}
-            for commit in commits:
-                unique_repos.setdefault(commit['obj']['repo'], []
-                    ).append(commit)
-
-            for repo in unique_repos:
-                res.append({
-                    'text': _('Commits in %(repo)s') % {'repo': repo},
-                    'children': unique_repos[repo]
-                })
-
-        data = {
-            'more': False,
-            'results': res
-        }
-        return data
-
-    @LoginRequired()
-    @XHRRequired()
-    @jsonify
-    def repo_list_data(self):
-        query = request.GET.get('query')
-        repo_type = request.GET.get('repo_type')
-        log.debug('generating repo list, query:%s', query)
-
-        res = []
-        repos = self._get_repo_list(query, repo_type=repo_type)
-        if repos:
-            res.append({
-                'text': _('Repositories'),
-                'children': repos
-            })
-
-        data = {
-            'more': False,
-            'results': res
-        }
-        return data
-
-    @LoginRequired()
-    @XHRRequired()
-    @jsonify
-    def user_autocomplete_data(self):
-        query = request.GET.get('query')
-        active = str2bool(request.GET.get('active') or True)
-
-        repo_model = RepoModel()
-        _users = repo_model.get_users(
-            name_contains=query, only_active=active)
-
-        if request.GET.get('user_groups'):
-            # extend with user groups
-            _user_groups = repo_model.get_user_groups(
-                name_contains=query, only_active=active)
-            _users = _users + _user_groups
-
-        return {'suggestions': _users}
-
-    @LoginRequired()
-    @XHRRequired()
-    @jsonify
-    def user_group_autocomplete_data(self):
-        query = request.GET.get('query')
-        active = str2bool(request.GET.get('active') or True)
-
-        repo_model = RepoModel()
-        _user_groups = repo_model.get_user_groups(
-            name_contains=query, only_active=active)
-        _user_groups = _user_groups
-
-        return {'suggestions': _user_groups}

rhodecode/controllers/journal.py

@@ -34,11 +34,11 b' from webob.exc import HTTPBadRequest'
 from pylons import request, tmpl_context as c, response, url
 from pylons.i18n.translation import _
 
-from rhodecode.controllers.admin.admin import user_log_filter
 from rhodecode.model.db import UserLog, UserFollowing, User, UserApiKeys
 from rhodecode.model.meta import Session
 import rhodecode.lib.helpers as h
 from rhodecode.lib.helpers import Page
+from rhodecode.lib.user_log_filter import user_log_filter
 from rhodecode.lib.auth import LoginRequired, NotAnonymous, CSRFRequired
 from rhodecode.lib.base import BaseController, render
 from rhodecode.lib.utils2 import safe_int, AttributeDict

rhodecode/controllers/pullrequests.py

@@ -21,8 +21,6 b''
 """
 pull requests controller for rhodecode for initializing pull requests
 """
-import types
-
 import peppercorn
 import formencode
 import logging
@@ -33,6 +31,7 b' from pylons import request, tmpl_context'
 from pylons.controllers.util import redirect
 from pylons.i18n.translation import _
 from pyramid.threadlocal import get_current_registry
+from pyramid.httpexceptions import HTTPFound
 from sqlalchemy.sql import func
 from sqlalchemy.sql.expression import or_
 
@@ -72,124 +71,6 b' class PullrequestsController(BaseRepoCon'
         c.REVIEW_STATUS_APPROVED = ChangesetStatus.STATUS_APPROVED
         c.REVIEW_STATUS_REJECTED = ChangesetStatus.STATUS_REJECTED
 
-    def _extract_ordering(self, request):
-        column_index = safe_int(request.GET.get('order[0][column]'))
-        order_dir = request.GET.get('order[0][dir]', 'desc')
-        order_by = request.GET.get(
-            'columns[%s][data][sort]' % column_index, 'name_raw')
-        return order_by, order_dir
-
-    @LoginRequired()
-    @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
-                                   'repository.admin')
-    @HasAcceptedRepoType('git', 'hg')
-    def show_all(self, repo_name):
-        # filter types
-        c.active = 'open'
-        c.source = str2bool(request.GET.get('source'))
-        c.closed = str2bool(request.GET.get('closed'))
-        c.my = str2bool(request.GET.get('my'))
-        c.awaiting_review = str2bool(request.GET.get('awaiting_review'))
-        c.awaiting_my_review = str2bool(request.GET.get('awaiting_my_review'))
-        c.repo_name = repo_name
-
-        opened_by = None
-        if c.my:
-            c.active = 'my'
-            opened_by = [c.rhodecode_user.user_id]
-
-        statuses = [PullRequest.STATUS_NEW, PullRequest.STATUS_OPEN]
-        if c.closed:
-            c.active = 'closed'
-            statuses = [PullRequest.STATUS_CLOSED]
-
-        if c.awaiting_review and not c.source:
-            c.active = 'awaiting'
-        if c.source and not c.awaiting_review:
-            c.active = 'source'
-        if c.awaiting_my_review:
-            c.active = 'awaiting_my'
-
-        data = self._get_pull_requests_list(
-            repo_name=repo_name, opened_by=opened_by, statuses=statuses)
-        if not request.is_xhr:
-            c.data = json.dumps(data['data'])
-            c.records_total = data['recordsTotal']
-            return render('/pullrequests/pullrequests.mako')
-        else:
-            return json.dumps(data)
-
-    def _get_pull_requests_list(self, repo_name, opened_by, statuses):
-        # pagination
-        start = safe_int(request.GET.get('start'), 0)
-        length = safe_int(request.GET.get('length'), c.visual.dashboard_items)
-        order_by, order_dir = self._extract_ordering(request)
-
-        if c.awaiting_review:
-            pull_requests = PullRequestModel().get_awaiting_review(
-                repo_name, source=c.source, opened_by=opened_by,
-                statuses=statuses, offset=start, length=length,
-                order_by=order_by, order_dir=order_dir)
-            pull_requests_total_count = PullRequestModel(
-            ).count_awaiting_review(
-                repo_name, source=c.source, statuses=statuses,
-                opened_by=opened_by)
-        elif c.awaiting_my_review:
-            pull_requests = PullRequestModel().get_awaiting_my_review(
-                repo_name, source=c.source, opened_by=opened_by,
-                user_id=c.rhodecode_user.user_id, statuses=statuses,
-                offset=start, length=length, order_by=order_by,
-                order_dir=order_dir)
-            pull_requests_total_count = PullRequestModel(
-            ).count_awaiting_my_review(
-                repo_name, source=c.source, user_id=c.rhodecode_user.user_id,
-                statuses=statuses, opened_by=opened_by)
-        else:
-            pull_requests = PullRequestModel().get_all(
-                repo_name, source=c.source, opened_by=opened_by,
-                statuses=statuses, offset=start, length=length,
-                order_by=order_by, order_dir=order_dir)
-            pull_requests_total_count = PullRequestModel().count_all(
-                repo_name, source=c.source, statuses=statuses,
-                opened_by=opened_by)
-
-        from rhodecode.lib.utils import PartialRenderer
-        _render = PartialRenderer('data_table/_dt_elements.mako')
-        data = []
-        for pr in pull_requests:
-            comments = CommentsModel().get_all_comments(
-                c.rhodecode_db_repo.repo_id, pull_request=pr)
-
-            data.append({
-                'name': _render('pullrequest_name',
-                                pr.pull_request_id, pr.target_repo.repo_name),
-                'name_raw': pr.pull_request_id,
-                'status': _render('pullrequest_status',
-                                  pr.calculated_review_status()),
-                'title': _render(
-                    'pullrequest_title', pr.title, pr.description),
-                'description': h.escape(pr.description),
-                'updated_on': _render('pullrequest_updated_on',
-                                      h.datetime_to_time(pr.updated_on)),
-                'updated_on_raw': h.datetime_to_time(pr.updated_on),
-                'created_on': _render('pullrequest_updated_on',
-                                      h.datetime_to_time(pr.created_on)),
-                'created_on_raw': h.datetime_to_time(pr.created_on),
-                'author': _render('pullrequest_author',
-                                  pr.author.full_contact, ),
-                'author_raw': pr.author.full_name,
-                'comments': _render('pullrequest_comments', len(comments)),
-                'comments_raw': len(comments),
-                'closed': pr.is_closed(),
-            })
-        # json used to render the grid
-        data = ({
-            'data': data,
-            'recordsTotal': pull_requests_total_count,
-            'recordsFiltered': pull_requests_total_count,
-        })
-        return data
-
     @LoginRequired()
     @NotAnonymous()
     @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
@@ -203,7 +84,7 b' class PullrequestsController(BaseRepoCon'
         except EmptyRepositoryError:
             h.flash(h.literal(_('There are no commits yet')),
                     category='warning')
-            redirect(url('summary_home', repo_name=source_repo.repo_name))
+            redirect(h.route_path('repo_summary', repo_name=source_repo.repo_name))
 
         commit_id = request.GET.get('commit')
         branch_ref = request.GET.get('branch')
@@ -346,8 +227,6 b' class PullrequestsController(BaseRepoCon'
         target_repo = _form['target_repo']
         target_ref = _form['target_ref']
         commit_ids = _form['revisions'][::-1]
-        reviewers = [
-            (r['user_id'], r['reasons']) for r in _form['review_members']]
 
         # find the ancestor for this pr
         source_db_repo = Repository.get_by_repo_name(_form['source_repo'])
@@ -375,23 +254,36 b' class PullrequestsController(BaseRepoCon'
             )
 
         description = _form['pullrequest_desc']
+
+        get_default_reviewers_data, validate_default_reviewers = \
+            PullRequestModel().get_reviewer_functions()
+
+        # recalculate reviewers logic, to make sure we can validate this
+        reviewer_rules = get_default_reviewers_data(
+            c.rhodecode_user.get_instance(), source_db_repo,
+            source_commit, target_db_repo, target_commit)
+
+        given_reviewers = _form['review_members']
+        reviewers = validate_default_reviewers(given_reviewers, reviewer_rules)
+
         try:
             pull_request = PullRequestModel().create(
                 c.rhodecode_user.user_id, source_repo, source_ref, target_repo,
                 target_ref, commit_ids, reviewers, pullrequest_title,
-                description
+                description, reviewer_rules
             )
             Session().commit()
             h.flash(_('Successfully opened new pull request'),
                     category='success')
         except Exception as e:
-            msg = _('Error occurred during sending pull request')
+            msg = _('Error occurred during creation of this pull request.')
             log.exception(msg)
             h.flash(msg, category='error')
             return redirect(url('pullrequest_home', repo_name=repo_name))
 
-        return redirect(url('pullrequest_show', repo_name=target_repo,
-                            pull_request_id=pull_request.pull_request_id))
+        raise HTTPFound(
+            h.route_path('pullrequest_show', repo_name=target_repo,
+                         pull_request_id=pull_request.pull_request_id))
 
     @LoginRequired()
     @NotAnonymous()
@@ -410,11 +302,10 b' class PullrequestsController(BaseRepoCon'
 
             if 'review_members' in controls:
                 self._update_reviewers(
-                    pull_request_id, controls['review_members'])
+                    pull_request_id, controls['review_members'],
+                    pull_request.reviewer_data)
             elif str2bool(request.POST.get('update_commits', 'false')):
                 self._update_commits(pull_request)
-            elif str2bool(request.POST.get('close_pull_request', 'false')):
-                self._reject_close(pull_request)
             elif str2bool(request.POST.get('edit_pull_request', 'false')):
                 self._edit_pull_request(pull_request)
             else:
@@ -426,7 +317,7 b' class PullrequestsController(BaseRepoCon'
         try:
             PullRequestModel().edit(
                 pull_request, request.POST.get('title'),
-                request.POST.get('description'))
+                request.POST.get('description'), c.rhodecode_user)
         except ValueError:
             msg = _(u'Cannot update closed pull requests.')
             h.flash(msg, category='error')
@@ -492,7 +383,7 b' class PullrequestsController(BaseRepoCon'
             msg = PullRequestModel.UPDATE_STATUS_MESSAGES[resp.reason]
             warning_reasons = [
                 UpdateFailureReason.NO_CHANGE,
-                UpdateFailureReason.WRONG_REF_TPYE,
+                UpdateFailureReason.WRONG_REF_TYPE,
             ]
             category = 'warning' if resp.reason in warning_reasons else 'error'
             h.flash(msg, category=category)
@@ -529,10 +420,10 b' class PullrequestsController(BaseRepoCon'
                 scm=pull_request.target_repo.repo_type)
             self._merge_pull_request(pull_request, user, extras)
 
-        return redirect(url(
-            'pullrequest_show',
-            repo_name=pull_request.target_repo.repo_name,
-            pull_request_id=pull_request.pull_request_id))
+        raise HTTPFound(
+            h.route_path('pullrequest_show',
+                         repo_name=pull_request.target_repo.repo_name,
+                         pull_request_id=pull_request.pull_request_id))
 
     def _merge_pull_request(self, pull_request, user, extras):
         merge_resp = PullRequestModel().merge(
@@ -553,18 +444,21 b' class PullrequestsController(BaseRepoCon'
                 merge_resp.failure_reason)
             h.flash(msg, category='error')
 
-    def _update_reviewers(self, pull_request_id, review_members):
-        reviewers = [
-            (int(r['user_id']), r['reasons']) for r in review_members]
-        PullRequestModel().update_reviewers(pull_request_id, reviewers)
-        Session().commit()
+    def _update_reviewers(self, pull_request_id, review_members, reviewer_rules):
+
+        get_default_reviewers_data, validate_default_reviewers = \
+            PullRequestModel().get_reviewer_functions()
 
-    def _reject_close(self, pull_request):
-        if pull_request.is_closed():
-            raise HTTPForbidden()
+        try:
+            reviewers = validate_default_reviewers(review_members, reviewer_rules)
+        except ValueError as e:
+            log.error('Reviewers Validation: {}'.format(e))
+            h.flash(e, category='error')
+            return
 
-        PullRequestModel().close_pull_request_with_comment(
-            pull_request, c.rhodecode_user, c.rhodecode_db_repo)
+        PullRequestModel().update_reviewers(
+            pull_request_id, reviewers, c.rhodecode_user)
+        h.flash(_('Pull request reviewers updated.'), category='success')
         Session().commit()
 
     @LoginRequired()
@@ -583,7 +477,7 b' class PullrequestsController(BaseRepoCon'
 
         # only owner can delete it !
         if allowed_to_delete:
-            PullRequestModel().delete(pull_request)
+            PullRequestModel().delete(pull_request, c.rhodecode_user)
             Session().commit()
             h.flash(_('Successfully deleted pull request'),
                     category='success')
@@ -608,7 +502,8 b' class PullrequestsController(BaseRepoCon'
             _org_pull_request_obj = pull_request_ver.pull_request
             at_version = pull_request_ver.pull_request_version_id
         else:
-            _org_pull_request_obj = pull_request_obj = PullRequest.get_or_404(pull_request_id)
+            _org_pull_request_obj = pull_request_obj = PullRequest.get_or_404(
+                pull_request_id)
 
         pull_request_display_obj = PullRequest.get_pr_display_object(
             pull_request_obj, _org_pull_request_obj)
@@ -715,9 +610,9 b' class PullrequestsController(BaseRepoCon'
             c.allowed_to_comment = False
             c.allowed_to_close = False
         else:
-            c.allowed_to_change_status = PullRequestModel(). \
-                check_user_change_status(pull_request_at_ver, c.rhodecode_user) \
-                                         and not pr_closed
+            can_change_status = PullRequestModel().check_user_change_status(
+                pull_request_at_ver, c.rhodecode_user)
+            c.allowed_to_change_status = can_change_status and not pr_closed
 
             c.allowed_to_update = PullRequestModel().check_user_update(
                 pull_request_latest, c.rhodecode_user) and not pr_closed
@@ -726,7 +621,24 b' class PullrequestsController(BaseRepoCon'
             c.allowed_to_delete = PullRequestModel().check_user_delete(
                 pull_request_latest, c.rhodecode_user) and not pr_closed
             c.allowed_to_comment = not pr_closed
-            c.allowed_to_close = c.allowed_to_change_status and not pr_closed
+            c.allowed_to_close = c.allowed_to_merge and not pr_closed
+
+        c.forbid_adding_reviewers = False
+        c.forbid_author_to_review = False
+        c.forbid_commit_author_to_review = False
+
+        if pull_request_latest.reviewer_data and \
+                        'rules' in pull_request_latest.reviewer_data:
+            rules = pull_request_latest.reviewer_data['rules'] or {}
+            try:
+                c.forbid_adding_reviewers = rules.get(
+                    'forbid_adding_reviewers')
+                c.forbid_author_to_review = rules.get(
+                    'forbid_author_to_review')
+                c.forbid_commit_author_to_review = rules.get(
+                    'forbid_commit_author_to_review')
+            except Exception:
+                pass
 
         # check merge capabilities
         _merge_check = MergeCheck.validate(
@@ -748,7 +660,7 b' class PullrequestsController(BaseRepoCon'
         # GENERAL COMMENTS with versions #
         q = comments_model._all_general_comments_of_pull_request(pull_request_latest)
         q = q.order_by(ChangesetComment.comment_id.asc())
-        general_comments = q.order_by(ChangesetComment.pull_request_version_id.asc())
+        general_comments = q
 
         # pick comments we want to render at current version
         c.comment_versions = comments_model.aggregate_comments(
@@ -758,7 +670,8 b' class PullrequestsController(BaseRepoCon'
         # INLINE COMMENTS with versions  #
         q = comments_model._all_inline_comments_of_pull_request(pull_request_latest)
         q = q.order_by(ChangesetComment.comment_id.asc())
-        inline_comments = q.order_by(ChangesetComment.pull_request_version_id.asc())
+        inline_comments = q
+
         c.inline_versions = comments_model.aggregate_comments(
             inline_comments, versions, c.at_version_num, inline=True)
 
@@ -841,12 +754,18 b' class PullrequestsController(BaseRepoCon'
                 c.commit_ranges.append(comm)
                 commit_cache[comm.raw_id] = comm
 
+            # Order here matters, we first need to get target, and then
+            # the source
             target_commit = commits_source_repo.get_commit(
                 commit_id=safe_str(target_ref_id))
+
             source_commit = commits_source_repo.get_commit(
                 commit_id=safe_str(source_ref_id))
+
         except CommitDoesNotExistError:
-            pass
+            log.warning(
+                'Failed to get commit from `{}` repo'.format(
+                    commits_source_repo), exc_info=True)
         except RepositoryRequirementError:
             log.warning(
                 'Failed to get all required data from repo', exc_info=True)
@@ -960,6 +879,7 b' class PullrequestsController(BaseRepoCon'
         pull_request_id = safe_int(pull_request_id)
         pull_request = PullRequest.get_or_404(pull_request_id)
         if pull_request.is_closed():
+            log.debug('comment: forbidden because pull request is closed')
             raise HTTPForbidden()
 
         status = request.POST.get('changeset_status', None)
@@ -968,95 +888,95 b' class PullrequestsController(BaseRepoCon'
         resolves_comment_id = request.POST.get('resolves_comment_id', None)
         close_pull_request = request.POST.get('close_pull_request')
 
-        close_pr = False
-        if close_pull_request:
-            close_pr = True
-            pull_request_review_status = pull_request.calculated_review_status()
-            if pull_request_review_status == ChangesetStatus.STATUS_APPROVED:
-                # approved only if we have voting consent
-                status = ChangesetStatus.STATUS_APPROVED
-            else:
-                status = ChangesetStatus.STATUS_REJECTED
-
-        allowed_to_change_status = PullRequestModel().check_user_change_status(
-            pull_request, c.rhodecode_user)
+        # the logic here should work like following, if we submit close
+        # pr comment, use `close_pull_request_with_comment` function
+        # else handle regular comment logic
+        user = c.rhodecode_user
+        repo = c.rhodecode_db_repo
 
-        if status and allowed_to_change_status:
-            message = (_('Status change %(transition_icon)s %(status)s')
-                       % {'transition_icon': '>',
-                          'status': ChangesetStatus.get_status_lbl(status)})
-            if close_pr:
-                message = _('Closing with') + ' ' + message
-            text = text or message
-        comm = CommentsModel().create(
-            text=text,
-            repo=c.rhodecode_db_repo.repo_id,
-            user=c.rhodecode_user.user_id,
-            pull_request=pull_request_id,
-            f_path=request.POST.get('f_path'),
-            line_no=request.POST.get('line'),
-            status_change=(ChangesetStatus.get_status_lbl(status)
-                           if status and allowed_to_change_status else None),
-            status_change_type=(status
-                                if status and allowed_to_change_status else None),
-            closing_pr=close_pr,
-            comment_type=comment_type,
-            resolves_comment_id=resolves_comment_id
-        )
+        if close_pull_request:
+            # only owner or admin or person with write permissions
+            allowed_to_close = PullRequestModel().check_user_update(
+                pull_request, c.rhodecode_user)
+            if not allowed_to_close:
+                log.debug('comment: forbidden because not allowed to close '
+                          'pull request %s', pull_request_id)
+                raise HTTPForbidden()
+            comment, status = PullRequestModel().close_pull_request_with_comment(
+                pull_request, user, repo, message=text)
+            Session().flush()
+            events.trigger(
+                events.PullRequestCommentEvent(pull_request, comment))
+
+        else:
+            # regular comment case, could be inline, or one with status.
+            # for that one we check also permissions
+
+            allowed_to_change_status = PullRequestModel().check_user_change_status(
+                pull_request, c.rhodecode_user)
+
+            if status and allowed_to_change_status:
+                message = (_('Status change %(transition_icon)s %(status)s')
+                           % {'transition_icon': '>',
+                              'status': ChangesetStatus.get_status_lbl(status)})
+                text = text or message
 
-        if allowed_to_change_status:
-            old_calculated_status = pull_request.calculated_review_status()
-            # get status if set !
-            if status:
-                ChangesetStatusModel().set_status(
-                    c.rhodecode_db_repo.repo_id,
-                    status,
-                    c.rhodecode_user.user_id,
-                    comm,
-                    pull_request=pull_request_id
-                )
+            comment = CommentsModel().create(
+                text=text,
+                repo=c.rhodecode_db_repo.repo_id,
+                user=c.rhodecode_user.user_id,
+                pull_request=pull_request_id,
+                f_path=request.POST.get('f_path'),
+                line_no=request.POST.get('line'),
+                status_change=(ChangesetStatus.get_status_lbl(status)
+                               if status and allowed_to_change_status else None),
+                status_change_type=(status
+                                    if status and allowed_to_change_status else None),
+                comment_type=comment_type,
+                resolves_comment_id=resolves_comment_id
+            )
+
+            if allowed_to_change_status:
+                # calculate old status before we change it
+                old_calculated_status = pull_request.calculated_review_status()
 
-            Session().flush()
-            events.trigger(events.PullRequestCommentEvent(pull_request, comm))
-            # we now calculate the status of pull request, and based on that
-            # calculation we set the commits status
-            calculated_status = pull_request.calculated_review_status()
-            if old_calculated_status != calculated_status:
-                PullRequestModel()._trigger_pull_request_hook(
-                    pull_request, c.rhodecode_user, 'review_status_change')
-
-            calculated_status_lbl = ChangesetStatus.get_status_lbl(
-                calculated_status)
+                # get status if set !
+                if status:
+                    ChangesetStatusModel().set_status(
+                        c.rhodecode_db_repo.repo_id,
+                        status,
+                        c.rhodecode_user.user_id,
+                        comment,
+                        pull_request=pull_request_id
+                    )
 
-            if close_pr:
-                status_completed = (
-                    calculated_status in [ChangesetStatus.STATUS_APPROVED,
-                                          ChangesetStatus.STATUS_REJECTED])
-                if close_pull_request or status_completed:
-                    PullRequestModel().close_pull_request(
-                        pull_request_id, c.rhodecode_user)
-                else:
-                    h.flash(_('Closing pull request on other statuses than '
-                              'rejected or approved is forbidden. '
-                              'Calculated status from all reviewers '
-                              'is currently: %s') % calculated_status_lbl,
-                            category='warning')
+                Session().flush()
+                events.trigger(
+                    events.PullRequestCommentEvent(pull_request, comment))
+
+                # we now calculate the status of pull request, and based on that
+                # calculation we set the commits status
+                calculated_status = pull_request.calculated_review_status()
+                if old_calculated_status != calculated_status:
+                    PullRequestModel()._trigger_pull_request_hook(
+                        pull_request, c.rhodecode_user, 'review_status_change')
 
         Session().commit()
 
         if not request.is_xhr:
-            return redirect(h.url('pullrequest_show', repo_name=repo_name,
-                                  pull_request_id=pull_request_id))
+            raise HTTPFound(
+                h.route_path('pullrequest_show',
+                             repo_name=repo_name,
+                             pull_request_id=pull_request_id))
 
         data = {
             'target_id': h.safeid(h.safe_unicode(request.POST.get('f_path'))),
         }
-        if comm:
-            c.co = comm
-            c.inline_comment = True if comm.line_no else False
-            data.update(comm.get_dict())
-            data.update({'rendered_text':
-                             render('changeset/changeset_comment_block.mako')})
+        if comment:
+            c.co = comment
+            rendered_comment = render('changeset/changeset_comment_block.mako')
+            data.update(comment.get_dict())
+            data.update({'rendered_text': rendered_comment})
 
         return data
 
@@ -1067,25 +987,32 b' class PullrequestsController(BaseRepoCon'
     @auth.CSRFRequired()
     @jsonify
     def delete_comment(self, repo_name, comment_id):
-        return self._delete_comment(comment_id)
+        comment = ChangesetComment.get_or_404(safe_int(comment_id))
+        if not comment:
+            log.debug('Comment with id:%s not found, skipping', comment_id)
+            # comment already deleted in another call probably
+            return True
 
-    def _delete_comment(self, comment_id):
-        comment_id = safe_int(comment_id)
-        co = ChangesetComment.get_or_404(comment_id)
-        if co.pull_request.is_closed():
+        if comment.pull_request.is_closed():
             # don't allow deleting comments on closed pull request
             raise HTTPForbidden()
 
-        is_owner = co.author.user_id == c.rhodecode_user.user_id
         is_repo_admin = h.HasRepoPermissionAny('repository.admin')(c.repo_name)
-        if h.HasPermissionAny('hg.admin')() or is_repo_admin or is_owner:
-            old_calculated_status = co.pull_request.calculated_review_status()
-            CommentsModel().delete(comment=co)
+        super_admin = h.HasPermissionAny('hg.admin')()
+        comment_owner = comment.author.user_id == c.rhodecode_user.user_id
+        is_repo_comment = comment.repo.repo_name == c.repo_name
+        comment_repo_admin = is_repo_admin and is_repo_comment
+
+        if super_admin or comment_owner or comment_repo_admin:
+            old_calculated_status = comment.pull_request.calculated_review_status()
+            CommentsModel().delete(comment=comment, user=c.rhodecode_user)
             Session().commit()
-            calculated_status = co.pull_request.calculated_review_status()
+            calculated_status = comment.pull_request.calculated_review_status()
             if old_calculated_status != calculated_status:
                 PullRequestModel()._trigger_pull_request_hook(
-                    co.pull_request, c.rhodecode_user, 'review_status_change')
+                    comment.pull_request, c.rhodecode_user, 'review_status_change')
             return True
         else:
-            raise HTTPForbidden()
+            log.warning('No permissions for user %s to delete comment_id: %s',
+                        c.rhodecode_user, comment_id)
+            raise HTTPNotFound()

rhodecode/controllers/utils.py

@@ -87,21 +87,3 b' def get_commit_from_ref_name(repo, ref_n'
                     '%s "%s" does not exist' % (ref_type, ref_name))
 
     return repo_scm.get_commit(commit_id)
-
-
-def reviewer_as_json(user, reasons):
-    """
-    Returns json struct of a reviewer for frontend
-
-    :param user: the reviewer
-    :param reasons: list of strings of why they are reviewers
-    """
-
-    return {
-        'user_id': user.user_id,
-        'reasons': reasons,
-        'username': user.username,
-        'firstname': user.firstname,
-        'lastname': user.lastname,
-        'gravatar_link': h.gravatar_url(user.email, 14),
-    }

rhodecode/events/__init__.py

@@ -18,6 +18,8 b''
 
 import logging
 from pyramid.threadlocal import get_current_registry
+from rhodecode.events.base import RhodecodeEvent
+
 
 log = logging.getLogger(__name__)
 
@@ -32,20 +34,21 b' def trigger(event, registry=None):'
     # passing the registry as an argument to get rid of it.
     registry = registry or get_current_registry()
     registry.notify(event)
-    log.debug('event %s triggered', event)
+    log.debug('event %s triggered using registry %s', event, registry)
 
     # Until we can work around the problem that VCS operations do not have a
     # pyramid context to work with, we send the events to integrations directly
 
     # Later it will be possible to use regular pyramid subscribers ie:
-    #   config.add_subscriber(integrations_event_handler, RhodecodeEvent)
+    # config.add_subscriber(
+    #     'rhodecode.integrations.integrations_event_handler',
+    #     'rhodecode.events.RhodecodeEvent')
+    # trigger(event, request.registry)
+
     from rhodecode.integrations import integrations_event_handler
     if isinstance(event, RhodecodeEvent):
         integrations_event_handler(event)
 
-
-from rhodecode.events.base import RhodecodeEvent
-
 from rhodecode.events.user import (  # noqa
     UserPreCreate,
     UserPostCreate,

rhodecode/events/base.py

@@ -24,7 +24,8 b' from rhodecode.lib.utils2 import Attribu'
 
 # this is a user object to be used for events caused by the system (eg. shell)
 SYSTEM_USER = AttributeDict(dict(
-    username='__SYSTEM__'
+    username='__SYSTEM__',
+    user_id='__SYSTEM_ID__'
 ))
 
 log = logging.getLogger(__name__)
@@ -32,12 +33,12 b' log = logging.getLogger(__name__)'
 
 class RhodecodeEvent(object):
     """
-    Base event class for all Rhodecode events
+    Base event class for all RhodeCode events
     """
     name = "RhodeCodeEvent"
 
-    def __init__(self):
-        self.request = get_current_request()
+    def __init__(self, request=None):
+        self.request = request or get_current_request()
         self.utc_timestamp = datetime.utcnow()
 
     @property
@@ -61,7 +62,8 b' class RhodecodeEvent(object):'
             instance = auth_user.get_instance()
             if not instance:
                 return AttributeDict(dict(
-                    username=auth_user.username
+                    username=auth_user.username,
+                    user_id=auth_user.user_id,
                 ))
             return instance
 
@@ -78,9 +80,8 b' class RhodecodeEvent(object):'
     def server_url(self):
         default = '<no server_url available>'
         if self.request:
-            from rhodecode.lib import helpers as h
             try:
-                return h.url('home', qualified=True)
+                return self.request.route_url('home')
             except Exception:
                 log.exception('Failed to fetch URL for server')
                 return default
@@ -93,7 +94,8 b' class RhodecodeEvent(object):'
             'utc_timestamp': self.utc_timestamp,
             'actor_ip': self.actor_ip,
             'actor': {
-                'username': self.actor.username
+                'username': self.actor.username,
+                'user_id': self.actor.user_id
             },
             'server_url': self.server_url
         }

rhodecode/events/pullrequest.py

@@ -41,6 +41,7 b' class PullRequestEvent(RepoEvent):'
         data = super(PullRequestEvent, self).as_dict()
 
         commits = _commits_as_dict(
+            self,
             commit_ids=self.pullrequest.revisions,
             repos=[self.pullrequest.source_repo]
         )
@@ -52,6 +53,8 b' class PullRequestEvent(RepoEvent):'
                 'issues': issues,
                 'pull_request_id': self.pullrequest.pull_request_id,
                 'url': PullRequestModel().get_url(self.pullrequest),
+                'permalink_url': PullRequestModel().get_url(
+                    self.pullrequest, permalink=True),
                 'status': self.pullrequest.calculated_review_status(),
                 'commits': commits,
             }
@@ -131,7 +134,9 b' class PullRequestCommentEvent(PullReques'
                 'type': self.comment.comment_type,
                 'file': self.comment.f_path,
                 'line': self.comment.line_no,
-                'url': CommentsModel().get_url(self.comment)
+                'url': CommentsModel().get_url(self.comment),
+                'permalink_url': CommentsModel().get_url(
+                    self.comment, permalink=True),
             }
         })
         return data

rhodecode/events/repo.py

@@ -16,6 +16,7 b''
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
+import collections
 import logging
 
 from rhodecode.translation import lazy_ugettext
@@ -26,17 +27,18 b' from rhodecode.lib.vcs.exceptions import'
 log = logging.getLogger(__name__)
 
 
-def _commits_as_dict(commit_ids, repos):
+def _commits_as_dict(event, commit_ids, repos):
     """
     Helper function to serialize commit_ids
 
+    :param event: class calling this method
     :param commit_ids: commits to get
     :param repos: list of repos to check
     """
     from rhodecode.lib.utils2 import extract_mentioned_users
-    from rhodecode.lib import helpers as h
     from rhodecode.lib.helpers import (
         urlify_commit_message, process_patterns, chop_at_smart)
+    from rhodecode.model.repo import RepoModel
 
     if not repos:
         raise Exception('no repo defined')
@@ -53,7 +55,7 b' def _commits_as_dict(commit_ids, repos):'
     reviewers = []
     for repo in repos:
         if not needed_commits:
-            return commits # return early if we have the commits we need
+            return commits  # return early if we have the commits we need
 
         vcs_repo = repo.scm_instance(cache=False)
         try:
@@ -62,22 +64,22 b' def _commits_as_dict(commit_ids, repos):'
                 try:
                     cs = vcs_repo.get_changeset(commit_id)
                 except CommitDoesNotExistError:
-                    continue # maybe its in next repo
+                    continue  # maybe its in next repo
 
                 cs_data = cs.__json__()
                 cs_data['mentions'] = extract_mentioned_users(cs_data['message'])
                 cs_data['reviewers'] = reviewers
-                cs_data['url'] = h.url('changeset_home',
-                    repo_name=repo.repo_name,
-                    revision=cs_data['raw_id'],
-                    qualified=True
-                )
+                cs_data['url'] = RepoModel().get_commit_url(
+                    repo, cs_data['raw_id'], request=event.request)
+                cs_data['permalink_url'] = RepoModel().get_commit_url(
+                    repo, cs_data['raw_id'], request=event.request, permalink=True)
                 urlified_message, issues_data = process_patterns(
                     cs_data['message'], repo.repo_name)
                 cs_data['issues'] = issues_data
-                cs_data['message_html'] = urlify_commit_message(cs_data['message'],
-                    repo.repo_name)
-                cs_data['message_html_title'] = chop_at_smart(cs_data['message'], '\n', suffix_if_chopped='...')
+                cs_data['message_html'] = urlify_commit_message(
+                    cs_data['message'], repo.repo_name)
+                cs_data['message_html_title'] = chop_at_smart(
+                    cs_data['message'], '\n', suffix_if_chopped='...')
                 commits.append(cs_data)
 
                 needed_commits.remove(commit_id)
@@ -118,12 +120,20 b' class RepoEvent(RhodecodeEvent):'
     def as_dict(self):
         from rhodecode.model.repo import RepoModel
         data = super(RepoEvent, self).as_dict()
+        extra_fields = collections.OrderedDict()
+        for field in self.repo.extra_fields:
+            extra_fields[field.field_key] = field.field_value
+
         data.update({
             'repo': {
                 'repo_id': self.repo.repo_id,
                 'repo_name': self.repo.repo_name,
                 'repo_type': self.repo.repo_type,
-                'url': RepoModel().get_url(self.repo)
+                'url': RepoModel().get_url(
+                    self.repo, request=self.request),
+                'permalink_url': RepoModel().get_url(
+                    self.repo, request=self.request, permalink=True),
+                'extra_fields': extra_fields
             }
         })
         return data
@@ -235,10 +245,13 b' class RepoPushEvent(RepoVCSEvent):'
 
     def as_dict(self):
         data = super(RepoPushEvent, self).as_dict()
-        branch_url = repo_url = data['repo']['url']
+
+        def branch_url(branch_name):
+            return '{}/changelog?branch={}'.format(
+                data['repo']['url'], branch_name)
 
         commits = _commits_as_dict(
-            commit_ids=self.pushed_commit_ids, repos=[self.repo])
+            self, commit_ids=self.pushed_commit_ids, repos=[self.repo])
 
         last_branch = None
         for commit in reversed(commits):
@@ -251,8 +264,7 b' class RepoPushEvent(RepoVCSEvent):'
         branches = [
             {
                 'name': branch,
-                'url': '{}/changelog?branch={}'.format(
-                    data['repo']['url'], branch)
+                'url': branch_url(branch)
             }
             for branch in branches
         ]

rhodecode/forms/__init__.py

@@ -24,6 +24,9 b' deform - later can be replaced with some'
 """
 
 from rhodecode.translation import _
+from rhodecode.translation import TranslationString
+
+from mako.template import Template
 from deform import Button, Form, widget, ValidationFailure
 
 
@@ -31,3 +34,16 b' class buttons:'
     save = Button(name='Save', type='submit')
     reset = Button(name=_('Reset'), type='reset')
     delete = Button(name=_('Delete'), type='submit')
+
+
+class RcForm(Form):
+    def render_error(self, request, field):
+        html = ''
+        if field.error:
+            for err in field.error.messages():
+                if isinstance(err, TranslationString):
+                    err = request.translate(err)
+                html = Template(
+                    '<span class="error-message">${err}</span>').render(err=err)
+
+        return html

rhodecode/i18n/rhodecode.pot

@@ -6,9 +6,9 b''
 #, fuzzy
 msgid ""
 msgstr ""
-"Project-Id-Version: rhodecode-enterprise-ce 4.7.0\n"
+"Project-Id-Version: rhodecode-enterprise-ce 4.8.0\n"
 "Report-Msgid-Bugs-To: [e-mail]\n"
-"POT-Creation-Date: 2017-04-07 13:01+0200\n"
+"POT-Creation-Date: 2017-06-27 17:25+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[e-mail]>\n"
@@ -24,7 +24,7 b' msgid "Global"'
 msgstr ""
 
 #: rhodecode/apps/admin/navigation.py:84
-#: rhodecode/templates/admin/repos/repo_edit.mako:52
+#: rhodecode/templates/admin/repos/repo_edit.mako:55
 msgid "VCS"
 msgstr ""
 
@@ -37,7 +37,7 b' msgid "Remap and Rescan"'
 msgstr ""
 
 #: rhodecode/apps/admin/navigation.py:87
-#: rhodecode/templates/admin/repos/repo_edit.mako:58
+#: rhodecode/templates/admin/repos/repo_edit.mako:61
 msgid "Issue Tracker"
 msgstr ""
 
@@ -48,7 +48,7 b' msgstr ""'
 #: rhodecode/templates/admin/my_account/my_account_profile_edit.mako:97
 #: rhodecode/templates/admin/users/user_add.mako:86
 #: rhodecode/templates/admin/users/user_edit_profile.mako:65
-#: rhodecode/templates/admin/users/users.mako:64
+#: rhodecode/templates/admin/users/users.mako:65
 #: rhodecode/templates/email_templates/user_registration.mako:25
 #: rhodecode/templates/users/user_profile.mako:51
 msgid "Email"
@@ -75,7 +75,7 b' msgstr ""'
 #: rhodecode/templates/admin/integrations/new.mako:17
 #: rhodecode/templates/admin/integrations/new.mako:23
 #: rhodecode/templates/admin/repo_groups/repo_group_edit.mako:51
-#: rhodecode/templates/admin/repos/repo_edit.mako:72
+#: rhodecode/templates/admin/repos/repo_edit.mako:75
 #: rhodecode/templates/base/base.mako:82
 msgid "Integrations"
 msgstr ""
@@ -97,11 +97,11 b' msgstr ""'
 msgid "Labs"
 msgstr ""
 
-#: rhodecode/apps/admin/views/sessions.py:86
+#: rhodecode/apps/admin/views/sessions.py:92
 msgid "Cleaned up old sessions"
 msgstr ""
 
-#: rhodecode/apps/admin/views/sessions.py:92
+#: rhodecode/apps/admin/views/sessions.py:98
 msgid "Failed to cleanup up old sessions"
 msgstr ""
 
@@ -113,245 +113,409 b' msgstr ""'
 msgid "Failed to generate the Apache configuration for Subversion."
 msgstr ""
 
-#: rhodecode/apps/admin/views/system_info.py:95
+#: rhodecode/apps/admin/views/system_info.py:99
 msgid "Note: please make sure this server can access `${url}` for the update link to work"
 msgstr ""
 
-#: rhodecode/apps/admin/views/system_info.py:98
+#: rhodecode/apps/admin/views/system_info.py:102
 msgid "Update info"
 msgstr ""
 
-#: rhodecode/apps/admin/views/system_info.py:100
+#: rhodecode/apps/admin/views/system_info.py:104
 msgid "Check for updates"
 msgstr ""
 
-#: rhodecode/apps/admin/views/system_info.py:105
-msgid "RhodeCode Version"
-msgstr ""
-
-#: rhodecode/apps/admin/views/system_info.py:106
-msgid "RhodeCode Server IP"
-msgstr ""
-
-#: rhodecode/apps/admin/views/system_info.py:107
-msgid "RhodeCode Server ID"
-msgstr ""
-
-#: rhodecode/apps/admin/views/system_info.py:108
-msgid "RhodeCode Configuration"
-msgstr ""
-
 #: rhodecode/apps/admin/views/system_info.py:109
-msgid "Workers"
+msgid "RhodeCode Version"
 msgstr ""
 
 #: rhodecode/apps/admin/views/system_info.py:110
-msgid "Worker Type"
+msgid "RhodeCode Server IP"
+msgstr ""
+
+#: rhodecode/apps/admin/views/system_info.py:111
+msgid "RhodeCode Server ID"
+msgstr ""
+
+#: rhodecode/apps/admin/views/system_info.py:112
+msgid "RhodeCode Configuration"
+msgstr ""
+
+#: rhodecode/apps/admin/views/system_info.py:113
+msgid "RhodeCode Certificate"
 msgstr ""
 
 #: rhodecode/apps/admin/views/system_info.py:114
-msgid "Database"
+msgid "Workers"
 msgstr ""
 
 #: rhodecode/apps/admin/views/system_info.py:115
-msgid "Database version"
+msgid "Worker Type"
 msgstr ""
 
 #: rhodecode/apps/admin/views/system_info.py:119
-msgid "Platform"
+msgid "Database"
 msgstr ""
 
 #: rhodecode/apps/admin/views/system_info.py:120
+msgid "Database version"
+msgstr ""
+
+#: rhodecode/apps/admin/views/system_info.py:124
+msgid "Platform"
+msgstr ""
+
+#: rhodecode/apps/admin/views/system_info.py:125
 msgid "Platform UUID"
 msgstr ""
 
-#: rhodecode/apps/admin/views/system_info.py:121
-msgid "Python version"
-msgstr ""
-
-#: rhodecode/apps/admin/views/system_info.py:122
-msgid "Python path"
-msgstr ""
-
 #: rhodecode/apps/admin/views/system_info.py:126
-msgid "CPU"
+msgid "Python version"
 msgstr ""
 
 #: rhodecode/apps/admin/views/system_info.py:127
+msgid "Python path"
+msgstr ""
+
+#: rhodecode/apps/admin/views/system_info.py:131
+msgid "CPU"
+msgstr ""
+
+#: rhodecode/apps/admin/views/system_info.py:132
 msgid "Load"
 msgstr ""
 
-#: rhodecode/apps/admin/views/system_info.py:128
-msgid "Memory"
-msgstr ""
-
-#: rhodecode/apps/admin/views/system_info.py:129
-msgid "Uptime"
-msgstr ""
-
 #: rhodecode/apps/admin/views/system_info.py:133
-msgid "Storage location"
+msgid "Memory"
 msgstr ""
 
 #: rhodecode/apps/admin/views/system_info.py:134
-msgid "Storage info"
-msgstr ""
-
-#: rhodecode/apps/admin/views/system_info.py:135
-msgid "Storage inodes"
-msgstr ""
-
-#: rhodecode/apps/admin/views/system_info.py:137
-msgid "Gist storage location"
+msgid "Uptime"
 msgstr ""
 
 #: rhodecode/apps/admin/views/system_info.py:138
-msgid "Gist storage info"
+msgid "Storage location"
+msgstr ""
+
+#: rhodecode/apps/admin/views/system_info.py:139
+msgid "Storage info"
 msgstr ""
 
 #: rhodecode/apps/admin/views/system_info.py:140
-msgid "Archive cache storage location"
-msgstr ""
-
-#: rhodecode/apps/admin/views/system_info.py:141
-msgid "Archive cache info"
+msgid "Storage inodes"
+msgstr ""
+
+#: rhodecode/apps/admin/views/system_info.py:142
+msgid "Gist storage location"
 msgstr ""
 
 #: rhodecode/apps/admin/views/system_info.py:143
-msgid "Temp storage location"
-msgstr ""
-
-#: rhodecode/apps/admin/views/system_info.py:144
-msgid "Temp storage info"
+msgid "Gist storage info"
+msgstr ""
+
+#: rhodecode/apps/admin/views/system_info.py:145
+msgid "Archive cache storage location"
 msgstr ""
 
 #: rhodecode/apps/admin/views/system_info.py:146
-msgid "Search info"
-msgstr ""
-
-#: rhodecode/apps/admin/views/system_info.py:147
-msgid "Search location"
+msgid "Archive cache info"
+msgstr ""
+
+#: rhodecode/apps/admin/views/system_info.py:148
+msgid "Temp storage location"
+msgstr ""
+
+#: rhodecode/apps/admin/views/system_info.py:149
+msgid "Temp storage info"
 msgstr ""
 
 #: rhodecode/apps/admin/views/system_info.py:151
-msgid "VCS Backends"
+msgid "Search info"
 msgstr ""
 
 #: rhodecode/apps/admin/views/system_info.py:152
+msgid "Search location"
+msgstr ""
+
+#: rhodecode/apps/admin/views/system_info.py:156
+msgid "VCS Backends"
+msgstr ""
+
+#: rhodecode/apps/admin/views/system_info.py:157
 msgid "VCS Server"
 msgstr ""
 
-#: rhodecode/apps/admin/views/system_info.py:153
+#: rhodecode/apps/admin/views/system_info.py:158
 msgid "GIT"
 msgstr ""
 
-#: rhodecode/apps/admin/views/system_info.py:154
+#: rhodecode/apps/admin/views/system_info.py:159
 msgid "HG"
 msgstr ""
 
-#: rhodecode/apps/admin/views/system_info.py:155
+#: rhodecode/apps/admin/views/system_info.py:160
 msgid "SVN"
 msgstr ""
 
-#: rhodecode/apps/admin/views/users.py:60
-#: rhodecode/controllers/admin/users.py:359
-#: rhodecode/controllers/admin/users.py:380
+#: rhodecode/apps/admin/views/users.py:63
+#: rhodecode/controllers/admin/users.py:360
+#: rhodecode/controllers/admin/users.py:381
 #: rhodecode/controllers/admin/users.py:412
 #: rhodecode/controllers/admin/users.py:486
-#: rhodecode/controllers/admin/users.py:499
-#: rhodecode/controllers/admin/users.py:557
 msgid "You can't edit this user"
 msgstr ""
 
+#: rhodecode/apps/admin/views/users.py:168
+#: rhodecode/apps/my_account/views.py:148
+#: rhodecode/controllers/admin/gists.py:62
+msgid "forever"
+msgstr ""
+
+#: rhodecode/apps/admin/views/users.py:169
+#: rhodecode/apps/my_account/views.py:149
+#: rhodecode/controllers/admin/gists.py:63
+msgid "5 minutes"
+msgstr ""
+
+#: rhodecode/apps/admin/views/users.py:170
+#: rhodecode/apps/my_account/views.py:150
+#: rhodecode/controllers/admin/gists.py:64
+msgid "1 hour"
+msgstr ""
+
+#: rhodecode/apps/admin/views/users.py:171
+#: rhodecode/apps/my_account/views.py:151
+#: rhodecode/controllers/admin/gists.py:65
+msgid "1 day"
+msgstr ""
+
+#: rhodecode/apps/admin/views/users.py:172
+#: rhodecode/apps/my_account/views.py:152
+#: rhodecode/controllers/admin/gists.py:66
+msgid "1 month"
+msgstr ""
+
+#: rhodecode/apps/admin/views/users.py:174
+#: rhodecode/apps/my_account/views.py:154
+#: rhodecode/controllers/admin/gists.py:70
+msgid "Lifetime"
+msgstr ""
+
 #: rhodecode/apps/admin/views/users.py:178
-#: rhodecode/apps/my_account/views.py:138
-#: rhodecode/controllers/admin/gists.py:62
-msgid "forever"
-msgstr ""
-
-#: rhodecode/apps/admin/views/users.py:179
-#: rhodecode/apps/my_account/views.py:139
-#: rhodecode/controllers/admin/gists.py:63
-msgid "5 minutes"
-msgstr ""
-
-#: rhodecode/apps/admin/views/users.py:180
-#: rhodecode/apps/my_account/views.py:140
-#: rhodecode/controllers/admin/gists.py:64
-msgid "1 hour"
-msgstr ""
-
-#: rhodecode/apps/admin/views/users.py:181
-#: rhodecode/apps/my_account/views.py:141
-#: rhodecode/controllers/admin/gists.py:65
-msgid "1 day"
-msgstr ""
-
-#: rhodecode/apps/admin/views/users.py:182
-#: rhodecode/apps/my_account/views.py:142
-#: rhodecode/controllers/admin/gists.py:66
-msgid "1 month"
-msgstr ""
-
-#: rhodecode/apps/admin/views/users.py:184
-#: rhodecode/apps/my_account/views.py:144
-#: rhodecode/controllers/admin/gists.py:70
-msgid "Lifetime"
-msgstr ""
-
-#: rhodecode/apps/admin/views/users.py:188
-#: rhodecode/apps/my_account/views.py:148
+#: rhodecode/apps/my_account/views.py:158
 #: rhodecode/templates/admin/my_account/my_account_auth_tokens.mako:16
 #: rhodecode/templates/admin/users/user_edit_auth_tokens.mako:16
 msgid "Role"
 msgstr ""
 
-#: rhodecode/apps/admin/views/users.py:219
-#: rhodecode/apps/my_account/views.py:175
+#: rhodecode/apps/admin/views/users.py:217
+#: rhodecode/apps/my_account/views.py:191
 msgid "Auth token successfully created"
 msgstr ""
 
-#: rhodecode/apps/admin/views/users.py:240
-#: rhodecode/apps/my_account/views.py:192
+#: rhodecode/apps/admin/views/users.py:246
+#: rhodecode/apps/my_account/views.py:215
 msgid "Auth token successfully deleted"
 msgstr ""
 
-#: rhodecode/apps/admin/views/users.py:284
+#: rhodecode/apps/admin/views/users.py:290
+#: rhodecode/apps/my_account/views.py:253
+#, python-format
+msgid "Added new email address `%s` for user account"
+msgstr ""
+
+#: rhodecode/apps/admin/views/users.py:296
+#: rhodecode/apps/my_account/views.py:259
+msgid "An error occurred during email saving"
+msgstr ""
+
+#: rhodecode/apps/admin/views/users.py:323
+msgid "Removed email address from user account"
+msgstr ""
+
+#: rhodecode/apps/admin/views/users.py:372
+#, python-format
+msgid "An error occurred during ip saving:%s"
+msgstr ""
+
+#: rhodecode/apps/admin/views/users.py:389
+msgid "An error occurred during ip saving"
+msgstr ""
+
+#: rhodecode/apps/admin/views/users.py:393
+#, python-format
+msgid "Added ips %s to user whitelist"
+msgstr ""
+
+#: rhodecode/apps/admin/views/users.py:423
+msgid "Removed ip address from user whitelist"
+msgstr ""
+
+#: rhodecode/apps/admin/views/users.py:472
 msgid "Groups successfully changed"
 msgstr ""
 
-#: rhodecode/apps/login/views.py:247 rhodecode/apps/login/views.py:316
+#: rhodecode/apps/home/views.py:197 rhodecode/apps/home/views.py:230
+#: rhodecode/controllers/pullrequests.py:191
+#: rhodecode/templates/admin/my_account/my_account.mako:38
+#: rhodecode/templates/admin/repo_groups/repo_group_edit_perms.mako:128
+#: rhodecode/templates/admin/repos/repo_add.mako:15
+#: rhodecode/templates/admin/repos/repo_add.mako:19
+#: rhodecode/templates/admin/users/user_edit_advanced.mako:11
+#: rhodecode/templates/base/base.mako:76 rhodecode/templates/base/base.mako:148
+#: rhodecode/templates/base/base.mako:575
+msgid "Repositories"
+msgstr ""
+
+#: rhodecode/apps/home/views.py:223
+msgid "Groups"
+msgstr ""
+
+#: rhodecode/apps/home/views.py:243
+#, python-format
+msgid "Commits in %(repo)s"
+msgstr ""
+
+#: rhodecode/apps/login/views.py:270 rhodecode/apps/login/views.py:339
 msgid "Bad captcha"
 msgstr ""
 
-#: rhodecode/apps/login/views.py:256
+#: rhodecode/apps/login/views.py:279
 msgid "You have successfully registered with RhodeCode"
 msgstr ""
 
-#: rhodecode/apps/login/views.py:292
+#: rhodecode/apps/login/views.py:315
 msgid "If such email exists, a password reset link was sent to it."
 msgstr ""
 
-#: rhodecode/apps/login/views.py:298
+#: rhodecode/apps/login/views.py:321
 msgid "Password reset has been disabled."
 msgstr ""
 
-#: rhodecode/apps/login/views.py:381
+#: rhodecode/apps/login/views.py:410
 msgid "Given reset token is invalid"
 msgstr ""
 
-#: rhodecode/apps/login/views.py:389
+#: rhodecode/apps/login/views.py:418
 msgid "Your password reset was successful, a new password has been sent to your email"
 msgstr ""
 
-#: rhodecode/apps/my_account/views.py:115
+#: rhodecode/apps/my_account/views.py:125
 msgid "Error occurred during update of user password"
 msgstr ""
 
-#: rhodecode/apps/my_account/views.py:122
+#: rhodecode/apps/my_account/views.py:132
 msgid "Successfully updated password"
 msgstr ""
 
+#: rhodecode/apps/my_account/views.py:281
+msgid "Email successfully deleted"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_caches.py:70
+msgid "Cache invalidation successful"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_caches.py:74
+msgid "An error occurred during cache invalidation"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_permissions.py:95
+msgid "Repository permissions updated"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings.py:171
+msgid "Repository {} updated successfully"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings.py:175
+msgid "Error occurred during update of repository {}"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings_advanced.py:93
+#, python-format
+msgid "Detached %s forks"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings_advanced.py:96
+#, python-format
+msgid "Deleted %s forks"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings_advanced.py:109
+#, python-format
+msgid "Deleted repository `%s`"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings_advanced.py:116
+msgid "detach or delete"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings_advanced.py:117
+msgid "Cannot delete `{repo}` it still contains attached forks. Try using {delete_or_detach} option."
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings_advanced.py:127
+#, python-format
+msgid "An error occurred during deletion of `%s`"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings_advanced.py:152
+msgid "Updated repository visibility in public journal"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings_advanced.py:156
+msgid "An error occurred during setting this repository in public journal"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings_advanced.py:184
+msgid "Nothing"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings_advanced.py:186
+#, python-format
+msgid "Marked repo %s as fork of %s"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings_advanced.py:193
+msgid "An error occurred during this operation"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings_advanced.py:217
+msgid "Locked repository"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings_advanced.py:220
+msgid "Unlocked repository"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_settings_advanced.py:223
+#: rhodecode/controllers/admin/repos.py:363
+msgid "An error occurred during unlocking"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_summary.py:293
+msgid "Branch"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_summary.py:294
+msgid "Tag"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_summary.py:295
+msgid "Bookmark"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_summary.py:318
+#: rhodecode/controllers/files.py:1021 rhodecode/model/pull_request.py:1345
+#: rhodecode/model/scm.py:775 rhodecode/templates/base/vcs_settings.mako:255
+msgid "Branches"
+msgstr ""
+
+#: rhodecode/apps/repository/views/repo_summary.py:319
+msgid "Closed branches"
+msgstr ""
+
 #: rhodecode/apps/svn_support/events.py:30
 msgid "Configuration for Apaache mad_dav_svn changed."
 msgstr ""
@@ -408,7 +572,7 b' msgid "The Port in use by the Atlassian '
 msgstr ""
 
 #: rhodecode/authentication/plugins/auth_crowd.py:69
-#: rhodecode/authentication/plugins/auth_ldap.py:84
+#: rhodecode/authentication/plugins/auth_ldap.py:86
 msgid "Port"
 msgstr ""
 
@@ -436,7 +600,7 b' msgstr ""'
 msgid "Admin Groups"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_crowd.py:215
+#: rhodecode/authentication/plugins/auth_crowd.py:216
 msgid "CROWD"
 msgstr ""
 
@@ -483,126 +647,129 b' msgstr ""'
 
 #: rhodecode/authentication/plugins/auth_ldap.py:74
 msgid ""
-"Host of the LDAP Server \n"
-"(e.g., 192.168.2.154, or ldap-server.domain.com"
-msgstr ""
-
-#: rhodecode/authentication/plugins/auth_ldap.py:77
+"Host[s] of the LDAP Server \n"
+"(e.g., 192.168.2.154, or ldap-server.domain.com.\n"
+" Multiple servers can be specified using commas"
+msgstr ""
+
+#: rhodecode/authentication/plugins/auth_ldap.py:78
 msgid "LDAP Host"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:82
-msgid "Custom port that the LDAP server is listening on. Default: 389"
-msgstr ""
-
-#: rhodecode/authentication/plugins/auth_ldap.py:90
+#: rhodecode/authentication/plugins/auth_ldap.py:83
+msgid "Custom port that the LDAP server is listening on. Default value is: 389"
+msgstr ""
+
+#: rhodecode/authentication/plugins/auth_ldap.py:92
 msgid ""
 "Optional user DN/account to connect to LDAP if authentication is required. \n"
 "e.g., cn=admin,dc=mydomain,dc=com, or uid=root,cn=users,dc=mydomain,dc=com, or [e-mail]"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:95
+#: rhodecode/authentication/plugins/auth_ldap.py:97
 msgid "Account"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:100
+#: rhodecode/authentication/plugins/auth_ldap.py:102
 msgid "Password to authenticate for given user DN."
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:103
+#: rhodecode/authentication/plugins/auth_ldap.py:105
 #: rhodecode/templates/login.mako:50 rhodecode/templates/register.mako:48
 #: rhodecode/templates/admin/my_account/my_account.mako:30
 #: rhodecode/templates/admin/users/user_add.mako:44
-#: rhodecode/templates/base/base.mako:313
+#: rhodecode/templates/base/base.mako:315
 #: rhodecode/templates/debug_style/login.html:45
 msgid "Password"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:108
+#: rhodecode/authentication/plugins/auth_ldap.py:110
 msgid "TLS Type"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:109
+#: rhodecode/authentication/plugins/auth_ldap.py:111
 msgid "Connection Security"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:115
-msgid "Require Cert over TLS?"
-msgstr ""
-
-#: rhodecode/authentication/plugins/auth_ldap.py:116
+#: rhodecode/authentication/plugins/auth_ldap.py:117
+msgid ""
+"Require Cert over TLS?. Self-signed and custom certificates can be used when\n"
+" `RhodeCode Certificate` found in admin > settings > system info page is extended."
+msgstr ""
+
+#: rhodecode/authentication/plugins/auth_ldap.py:120
 msgid "Certificate Checks"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:122
+#: rhodecode/authentication/plugins/auth_ldap.py:126
 msgid ""
 "Base DN to search. Dynamic bind is supported. Add `$login` marker in it to be replaced with current user credentials \n"
 "(e.g., dc=mydomain,dc=com, or ou=Users,dc=mydomain,dc=com)"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:127
+#: rhodecode/authentication/plugins/auth_ldap.py:131
 msgid "Base DN"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:132
+#: rhodecode/authentication/plugins/auth_ldap.py:136
 msgid ""
 "Filter to narrow results \n"
 "(e.g., (&(objectCategory=Person)(objectClass=user)), or \n"
 "(memberof=cn=rc-login,ou=groups,ou=company,dc=mydomain,dc=com)))"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:137
+#: rhodecode/authentication/plugins/auth_ldap.py:141
 msgid "LDAP Search Filter"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:143
+#: rhodecode/authentication/plugins/auth_ldap.py:147
 msgid "How deep to search LDAP. If unsure set to SUBTREE"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:144
+#: rhodecode/authentication/plugins/auth_ldap.py:148
 msgid "LDAP Search Scope"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:150
+#: rhodecode/authentication/plugins/auth_ldap.py:154
 msgid "LDAP Attribute to map to user name (e.g., uid, or sAMAccountName)"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:152
+#: rhodecode/authentication/plugins/auth_ldap.py:156
 msgid "Login Attribute"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:153
+#: rhodecode/authentication/plugins/auth_ldap.py:157
 msgid "The LDAP Login attribute of the CN must be specified"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:158
+#: rhodecode/authentication/plugins/auth_ldap.py:162
 msgid "LDAP Attribute to map to first name (e.g., givenName)"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:161
+#: rhodecode/authentication/plugins/auth_ldap.py:165
 msgid "First Name Attribute"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:166
+#: rhodecode/authentication/plugins/auth_ldap.py:170
 msgid "LDAP Attribute to map to last name (e.g., sn)"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:169
+#: rhodecode/authentication/plugins/auth_ldap.py:173
 msgid "Last Name Attribute"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:174
+#: rhodecode/authentication/plugins/auth_ldap.py:178
 msgid ""
 "LDAP Attribute to map to email address (e.g., mail).\n"
 "Emails are a crucial part of RhodeCode. \n"
 "If possible add a valid email attribute to ldap users."
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:179
+#: rhodecode/authentication/plugins/auth_ldap.py:183
 msgid "Email Attribute"
 msgstr ""
 
-#: rhodecode/authentication/plugins/auth_ldap.py:360
+#: rhodecode/authentication/plugins/auth_ldap.py:365
 msgid "LDAP"
 msgstr ""
 
@@ -634,74 +801,71 b' msgstr ""'
 msgid "Rhodecode Token Auth"
 msgstr ""
 
-#: rhodecode/controllers/changelog.py:91 rhodecode/controllers/compare.py:64
-#: rhodecode/controllers/pullrequests.py:204
+#: rhodecode/controllers/changelog.py:70 rhodecode/controllers/compare.py:64
+#: rhodecode/controllers/pullrequests.py:85
 msgid "There are no commits yet"
 msgstr ""
 
+#: rhodecode/controllers/changeset.py:76
+msgid "Show whitespace"
+msgstr ""
+
 #: rhodecode/controllers/changeset.py:77
-msgid "Show whitespace"
-msgstr ""
-
-#: rhodecode/controllers/changeset.py:78
 msgid "Show whitespace for all diffs"
 msgstr ""
 
+#: rhodecode/controllers/changeset.py:83
+msgid "Ignore whitespace"
+msgstr ""
+
 #: rhodecode/controllers/changeset.py:84
-msgid "Ignore whitespace"
-msgstr ""
-
-#: rhodecode/controllers/changeset.py:85
 msgid "Ignore whitespace for all diffs"
 msgstr ""
 
+#: rhodecode/controllers/changeset.py:140
+msgid "Increase context"
+msgstr ""
+
 #: rhodecode/controllers/changeset.py:141
-msgid "Increase context"
-msgstr ""
-
-#: rhodecode/controllers/changeset.py:142
 msgid "Increase context for all diffs"
 msgstr ""
 
-#: rhodecode/controllers/changeset.py:190 rhodecode/controllers/files.py:106
-#: rhodecode/controllers/files.py:127
+#: rhodecode/controllers/changeset.py:189 rhodecode/controllers/files.py:106
+#: rhodecode/controllers/files.py:128
 msgid "No such commit exists for this repository"
 msgstr ""
 
-#: rhodecode/controllers/changeset.py:344
-#: rhodecode/controllers/pullrequests.py:985
-#: rhodecode/model/pull_request.py:1055
+#: rhodecode/controllers/changeset.py:343
+#: rhodecode/controllers/pullrequests.py:919
 #, python-format
 msgid "Status change %(transition_icon)s %(status)s"
 msgstr ""
 
-#: rhodecode/controllers/changeset.py:389
+#: rhodecode/controllers/changeset.py:387
 msgid "Changing the status of a commit associated with a closed pull request is not allowed"
 msgstr ""
 
-#: rhodecode/controllers/compare.py:89
+#: rhodecode/controllers/compare.py:92
 msgid "Select commit"
 msgstr ""
 
-#: rhodecode/controllers/compare.py:144
-#, python-format
-msgid "Could not find the original repo: %(repo)s"
-msgstr ""
-
-#: rhodecode/controllers/compare.py:152
-#, python-format
-msgid "Could not find the other repo: %(repo)s"
-msgstr ""
-
-#: rhodecode/controllers/compare.py:164
+#: rhodecode/controllers/compare.py:149
+msgid "Could not find the source repo: `{}`"
+msgstr ""
+
+#: rhodecode/controllers/compare.py:156
+msgid "Could not find the target repo: `{}`"
+msgstr ""
+
+#: rhodecode/controllers/compare.py:166
 msgid "The comparison of two different kinds of remote repos is not available"
 msgstr ""
 
-#: rhodecode/controllers/compare.py:202
+#: rhodecode/controllers/compare.py:204
 msgid "Could not compare repos with different large file settings"
 msgstr ""
 
-#: rhodecode/controllers/compare.py:242
+#: rhodecode/controllers/compare.py:244
 #, python-format
 msgid "Repositories unrelated. Cannot compare commit %(commit1)s from repository %(repo1)s with commit %(commit2)s from repository %(repo2)s."
 msgstr ""
@@ -725,51 +889,47 b' msgstr ""'
 msgid "There are no files yet. %s"
 msgstr ""
 
-#: rhodecode/controllers/files.py:435 rhodecode/controllers/files.py:488
-#: rhodecode/controllers/files.py:519 rhodecode/controllers/files.py:594
-#: rhodecode/controllers/files.py:639 rhodecode/controllers/files.py:730
+#: rhodecode/controllers/files.py:434 rhodecode/controllers/files.py:487
+#: rhodecode/controllers/files.py:518 rhodecode/controllers/files.py:593
+#: rhodecode/controllers/files.py:638 rhodecode/controllers/files.py:729
 #, python-format
 msgid "This repository has been locked by %s on %s"
 msgstr ""
 
-#: rhodecode/controllers/files.py:443 rhodecode/controllers/files.py:496
+#: rhodecode/controllers/files.py:442 rhodecode/controllers/files.py:495
 msgid "You can only delete files with revision being a valid branch "
 msgstr ""
 
-#: rhodecode/controllers/files.py:452 rhodecode/controllers/files.py:505
-#, python-format
-msgid "Deleted file %s via RhodeCode Enterprise"
+#: rhodecode/controllers/files.py:451 rhodecode/controllers/files.py:504
+msgid "Deleted file {} via RhodeCode Enterprise"
 msgstr ""
 
 #: rhodecode/controllers/files.py:472
-#, python-format
-msgid "Successfully deleted file %s"
-msgstr ""
-
-#: rhodecode/controllers/files.py:475 rhodecode/controllers/files.py:581
-#: rhodecode/controllers/files.py:718
+msgid "Successfully deleted file `{}`"
+msgstr ""
+
+#: rhodecode/controllers/files.py:476 rhodecode/controllers/files.py:582
+#: rhodecode/controllers/files.py:719
 msgid "Error occurred during commit"
 msgstr ""
 
-#: rhodecode/controllers/files.py:527 rhodecode/controllers/files.py:602
+#: rhodecode/controllers/files.py:526 rhodecode/controllers/files.py:601
 msgid "You can only edit files with revision being a valid branch "
 msgstr ""
 
-#: rhodecode/controllers/files.py:539 rhodecode/controllers/files.py:614
-#, python-format
-msgid "Edited file %s via RhodeCode Enterprise"
-msgstr ""
-
-#: rhodecode/controllers/files.py:556
+#: rhodecode/controllers/files.py:538 rhodecode/controllers/files.py:613
+msgid "Edited file {} via RhodeCode Enterprise"
+msgstr ""
+
+#: rhodecode/controllers/files.py:555
 msgid "No changes"
 msgstr ""
 
-#: rhodecode/controllers/files.py:578 rhodecode/controllers/files.py:707
-#, python-format
-msgid "Successfully committed to %s"
-msgstr ""
-
-#: rhodecode/controllers/files.py:652 rhodecode/controllers/files.py:741
+#: rhodecode/controllers/files.py:578
+msgid "Successfully committed changes to file `{}`"
+msgstr ""
+
+#: rhodecode/controllers/files.py:651 rhodecode/controllers/files.py:740
 msgid "Added file via RhodeCode Enterprise"
 msgstr ""
 
@@ -777,39 +937,37 b' msgstr ""'
 msgid "No filename"
 msgstr ""
 
+#: rhodecode/controllers/files.py:707
+msgid "Successfully committed new file `{}`"
+msgstr ""
+
 #: rhodecode/controllers/files.py:710
 msgid "The location specified must be a relative path and must not contain .. in the path"
 msgstr ""
 
-#: rhodecode/controllers/files.py:764
+#: rhodecode/controllers/files.py:763
 msgid "Downloads disabled"
 msgstr ""
 
-#: rhodecode/controllers/files.py:770
+#: rhodecode/controllers/files.py:769
 #, python-format
 msgid "Unknown revision %s"
 msgstr ""
 
-#: rhodecode/controllers/files.py:772
+#: rhodecode/controllers/files.py:771
 msgid "Empty repository"
 msgstr ""
 
-#: rhodecode/controllers/files.py:774 rhodecode/controllers/files.py:808
+#: rhodecode/controllers/files.py:773 rhodecode/controllers/files.py:807
 msgid "Unknown archive type"
 msgstr ""
 
-#: rhodecode/controllers/files.py:993
+#: rhodecode/controllers/files.py:1000
 msgid "Changesets"
 msgstr ""
 
-#: rhodecode/controllers/files.py:1014 rhodecode/controllers/summary.py:277
-#: rhodecode/model/pull_request.py:1280 rhodecode/model/scm.py:782
-#: rhodecode/templates/base/vcs_settings.mako:242
-msgid "Branches"
-msgstr ""
-
-#: rhodecode/controllers/files.py:1018 rhodecode/model/scm.py:797
-#: rhodecode/templates/base/vcs_settings.mako:267
+#: rhodecode/controllers/files.py:1025 rhodecode/model/scm.py:790
+#: rhodecode/templates/base/vcs_settings.mako:280
 msgid "Tags"
 msgstr ""
 
@@ -818,27 +976,6 b' msgstr ""'
 msgid "An error occurred during repository forking %s"
 msgstr ""
 
-#: rhodecode/controllers/home.py:207
-msgid "Groups"
-msgstr ""
-
-#: rhodecode/controllers/home.py:214 rhodecode/controllers/home.py:249
-#: rhodecode/controllers/pullrequests.py:310
-#: rhodecode/templates/admin/my_account/my_account.mako:38
-#: rhodecode/templates/admin/repo_groups/repo_group_edit_perms.mako:128
-#: rhodecode/templates/admin/repos/repo_add.mako:15
-#: rhodecode/templates/admin/repos/repo_add.mako:19
-#: rhodecode/templates/admin/users/user_edit_advanced.mako:11
-#: rhodecode/templates/base/base.mako:76 rhodecode/templates/base/base.mako:148
-#: rhodecode/templates/base/base.mako:572
-msgid "Repositories"
-msgstr ""
-
-#: rhodecode/controllers/home.py:227
-#, python-format
-msgid "Commits in %(repo)s"
-msgstr ""
-
 #: rhodecode/controllers/journal.py:107 rhodecode/controllers/journal.py:150
 msgid "public journal"
 msgstr ""
@@ -847,80 +984,58 b' msgstr ""'
 msgid "journal"
 msgstr ""
 
-#: rhodecode/controllers/pullrequests.py:218
+#: rhodecode/controllers/pullrequests.py:99
 msgid "Commit does not exist"
 msgstr ""
 
-#: rhodecode/controllers/pullrequests.py:335
+#: rhodecode/controllers/pullrequests.py:216
 msgid "Pull request requires a title with min. 3 chars"
 msgstr ""
 
-#: rhodecode/controllers/pullrequests.py:337
+#: rhodecode/controllers/pullrequests.py:218
 msgid "Error creating pull request: {}"
 msgstr ""
 
-#: rhodecode/controllers/pullrequests.py:385
+#: rhodecode/controllers/pullrequests.py:276
 msgid "Successfully opened new pull request"
 msgstr ""
 
-#: rhodecode/controllers/pullrequests.py:388
-msgid "Error occurred during sending pull request"
-msgstr ""
-
-#: rhodecode/controllers/pullrequests.py:431
+#: rhodecode/controllers/pullrequests.py:279
+msgid "Error occurred during creation of this pull request."
+msgstr ""
+
+#: rhodecode/controllers/pullrequests.py:322
 msgid "Cannot update closed pull requests."
 msgstr ""
 
+#: rhodecode/controllers/pullrequests.py:328
+msgid "Pull request title & description updated."
+msgstr ""
+
+#: rhodecode/controllers/pullrequests.py:346
+msgid "Pull request updated to \"{source_commit_id}\" with {count_added} added, {count_removed} removed commits. Source of changes: {change_source}"
+msgstr ""
+
+#: rhodecode/controllers/pullrequests.py:363
+msgid "Reload page"
+msgstr ""
+
 #: rhodecode/controllers/pullrequests.py:437
-msgid "Pull request title & description updated."
-msgstr ""
-
-#: rhodecode/controllers/pullrequests.py:455
-msgid "Pull request updated to \"{source_commit_id}\" with {count_added} added, {count_removed} removed commits. Source of changes: {change_source}"
-msgstr ""
-
-#: rhodecode/controllers/pullrequests.py:472
-msgid "Reload page"
-msgstr ""
-
-#: rhodecode/controllers/pullrequests.py:546
 msgid "Pull request was successfully merged and closed."
 msgstr ""
 
-#: rhodecode/controllers/pullrequests.py:588
+#: rhodecode/controllers/pullrequests.py:461
+msgid "Pull request reviewers updated."
+msgstr ""
+
+#: rhodecode/controllers/pullrequests.py:482
 msgid "Successfully deleted pull request"
 msgstr ""
 
-#: rhodecode/controllers/pullrequests.py:592
+#: rhodecode/controllers/pullrequests.py:486
 msgid "Your are not allowed to delete this pull request"
 msgstr ""
 
-#: rhodecode/controllers/pullrequests.py:989
-#: rhodecode/model/pull_request.py:1059
-msgid "Closing with"
-msgstr ""
-
-#: rhodecode/controllers/pullrequests.py:1039
-#, python-format
-msgid "Closing pull request on other statuses than rejected or approved is forbidden. Calculated status from all reviewers is currently: %s"
-msgstr ""
-
-#: rhodecode/controllers/summary.py:251
-msgid "Branch"
-msgstr ""
-
-#: rhodecode/controllers/summary.py:252
-msgid "Tag"
-msgstr ""
-
-#: rhodecode/controllers/summary.py:253
-msgid "Bookmark"
-msgstr ""
-
-#: rhodecode/controllers/summary.py:278
-msgid "Closed branches"
-msgstr ""
-
 #: rhodecode/controllers/admin/defaults.py:84
 msgid "Default settings updated successfully"
 msgstr ""
@@ -976,89 +1091,73 b' msgstr ""'
 msgid "%(expiry)s - current value"
 msgstr ""
 
-#: rhodecode/controllers/admin/my_account.py:78
+#: rhodecode/controllers/admin/my_account.py:70
 msgid "You can't edit this user since it's crucial for entire application"
 msgstr ""
 
-#: rhodecode/controllers/admin/my_account.py:138
+#: rhodecode/controllers/admin/my_account.py:110
 msgid "Your account was updated successfully"
 msgstr ""
 
-#: rhodecode/controllers/admin/my_account.py:153
-#: rhodecode/controllers/admin/users.py:184
+#: rhodecode/controllers/admin/my_account.py:125
+#: rhodecode/controllers/admin/users.py:182
 #, python-format
 msgid "Error occurred during update of user %s"
 msgstr ""
 
-#: rhodecode/controllers/admin/my_account.py:222
-#: rhodecode/controllers/admin/users.py:527
-#, python-format
-msgid "Added new email address `%s` for user account"
-msgstr ""
-
-#: rhodecode/controllers/admin/my_account.py:229
-#: rhodecode/controllers/admin/users.py:534
-msgid "An error occurred during email saving"
-msgstr ""
-
-#: rhodecode/controllers/admin/my_account.py:239
-#: rhodecode/controllers/admin/users.py:549
-msgid "Removed email address from user account"
-msgstr ""
-
-#: rhodecode/controllers/admin/permissions.py:112
+#: rhodecode/controllers/admin/permissions.py:107
 msgid "Application permissions updated successfully"
 msgstr ""
 
-#: rhodecode/controllers/admin/permissions.py:127
-#: rhodecode/controllers/admin/permissions.py:176
-#: rhodecode/controllers/admin/permissions.py:230
+#: rhodecode/controllers/admin/permissions.py:122
+#: rhodecode/controllers/admin/permissions.py:171
+#: rhodecode/controllers/admin/permissions.py:225
 msgid "Error occurred during update of permissions"
 msgstr ""
 
-#: rhodecode/controllers/admin/permissions.py:161
+#: rhodecode/controllers/admin/permissions.py:156
 msgid "Object permissions updated successfully"
 msgstr ""
 
-#: rhodecode/controllers/admin/permissions.py:215
+#: rhodecode/controllers/admin/permissions.py:210
 msgid "Global permissions updated successfully"
 msgstr ""
 
-#: rhodecode/controllers/admin/repo_groups.py:197
+#: rhodecode/controllers/admin/repo_groups.py:202
 #, python-format
 msgid "Created repository group %s"
 msgstr ""
 
-#: rhodecode/controllers/admin/repo_groups.py:210
+#: rhodecode/controllers/admin/repo_groups.py:215
 #, python-format
 msgid "Error occurred during creation of repository group %s"
 msgstr ""
 
-#: rhodecode/controllers/admin/repo_groups.py:258
+#: rhodecode/controllers/admin/repo_groups.py:261
 #, python-format
 msgid "Updated repository group %s"
 msgstr ""
 
-#: rhodecode/controllers/admin/repo_groups.py:274
+#: rhodecode/controllers/admin/repo_groups.py:276
 #, python-format
 msgid "Error occurred during update of repository group %s"
 msgstr ""
 
-#: rhodecode/controllers/admin/repo_groups.py:296
+#: rhodecode/controllers/admin/repo_groups.py:291
 #, python-format
 msgid "This group contains %(num)d repository and cannot be deleted"
 msgid_plural "This group contains %(num)d repositories and cannot be deleted"
 msgstr[0] ""
 msgstr[1] ""
 
-#: rhodecode/controllers/admin/repo_groups.py:305
+#: rhodecode/controllers/admin/repo_groups.py:300
 #, python-format
 msgid "This group contains %(num)d subgroup and cannot be deleted"
 msgid_plural "This group contains %(num)d subgroups and cannot be deleted"
 msgstr[0] ""
 msgstr[1] ""
 
-#: rhodecode/controllers/admin/repo_groups.py:312
+#: rhodecode/controllers/admin/repo_groups.py:313
 #, python-format
 msgid "Removed repository group %s"
 msgstr ""
@@ -1068,366 +1167,285 b' msgstr ""'
 msgid "Error occurred during deletion of repository group %s"
 msgstr ""
 
-#: rhodecode/controllers/admin/repo_groups.py:388
-#: rhodecode/controllers/admin/user_groups.py:323
+#: rhodecode/controllers/admin/repo_groups.py:381
+#: rhodecode/controllers/admin/user_groups.py:318
 msgid "Cannot change permission for yourself as admin"
 msgstr ""
 
-#: rhodecode/controllers/admin/repo_groups.py:405
+#: rhodecode/controllers/admin/repo_groups.py:404
 msgid "Repository Group permissions updated"
 msgstr ""
 
+#: rhodecode/controllers/admin/repos.py:125
+#, python-format
+msgid "Error creating repository %s: invalid certificate"
+msgstr ""
+
 #: rhodecode/controllers/admin/repos.py:129
 #, python-format
-msgid "Error creating repository %s: invalid certificate"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:133
-#, python-format
 msgid "Error creating repository %s"
 msgstr ""
 
-#: rhodecode/controllers/admin/repos.py:274
+#: rhodecode/controllers/admin/repos.py:270
 #, python-format
 msgid "Created repository %s from %s"
 msgstr ""
 
-#: rhodecode/controllers/admin/repos.py:283
+#: rhodecode/controllers/admin/repos.py:279
 #, python-format
 msgid "Forked repository %s as %s"
 msgstr ""
 
-#: rhodecode/controllers/admin/repos.py:286
+#: rhodecode/controllers/admin/repos.py:282
 #, python-format
 msgid "Created repository %s"
 msgstr ""
 
-#: rhodecode/controllers/admin/repos.py:327
-#, python-format
-msgid "Repository %s updated successfully"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:346
-#, python-format
-msgid "Error occurred during update of repository %s"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:374
-#, python-format
-msgid "Detached %s forks"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:377
-#, python-format
-msgid "Deleted %s forks"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:382
-#, python-format
-msgid "Deleted repository %s"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:385
-#, python-format
-msgid "Cannot delete %s it still contains attached forks"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:390
-#, python-format
-msgid "An error occurred during deletion of %s"
+#: rhodecode/controllers/admin/repos.py:319
+msgid "An error occurred during creation of field"
+msgstr ""
+
+#: rhodecode/controllers/admin/repos.py:334
+msgid "An error occurred during removal of field"
+msgstr ""
+
+#: rhodecode/controllers/admin/repos.py:353
+msgid "Unlocked"
+msgstr ""
+
+#: rhodecode/controllers/admin/repos.py:357
+msgid "Locked"
+msgstr ""
+
+#: rhodecode/controllers/admin/repos.py:359
+#, python-format
+msgid "Repository has been %s"
+msgstr ""
+
+#: rhodecode/controllers/admin/repos.py:373
+msgid "Pulled from remote location"
+msgstr ""
+
+#: rhodecode/controllers/admin/repos.py:376
+msgid "An error occurred during pull from remote location"
+msgstr ""
+
+#: rhodecode/controllers/admin/repos.py:397
+msgid "An error occurred during deletion of repository stats"
 msgstr ""
 
 #: rhodecode/controllers/admin/repos.py:443
-msgid "Repository permissions updated"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:474
-msgid "An error occurred during creation of field"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:489
-msgid "An error occurred during removal of field"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:528
-msgid "Updated repository visibility in public journal"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:532
-msgid "An error occurred during setting this repository in public journal"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:556
-msgid "Nothing"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:558
-#, python-format
-msgid "Marked repo %s as fork of %s"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:565
-msgid "An error occurred during this operation"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:583
-msgid "Locked repository"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:586
-msgid "Unlocked repository"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:589
-#: rhodecode/controllers/admin/repos.py:618
-msgid "An error occurred during unlocking"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:608
-msgid "Unlocked"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:612
-msgid "Locked"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:614
-#, python-format
-msgid "Repository has been %s"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:629
-msgid "Cache invalidation successful"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:633
-msgid "An error occurred during cache invalidation"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:653
-msgid "Pulled from remote location"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:656
-msgid "An error occurred during pull from remote location"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:678
-msgid "An error occurred during deletion of repository stats"
-msgstr ""
-
-#: rhodecode/controllers/admin/repos.py:725
 msgid "Error occurred during deleting issue tracker entry"
 msgstr ""
 
-#: rhodecode/controllers/admin/repos.py:728
-#: rhodecode/controllers/admin/settings.py:381
+#: rhodecode/controllers/admin/repos.py:446
+#: rhodecode/controllers/admin/settings.py:384
 msgid "Removed issue tracker entry"
 msgstr ""
 
-#: rhodecode/controllers/admin/repos.py:758
-#: rhodecode/controllers/admin/settings.py:428
+#: rhodecode/controllers/admin/repos.py:476
+#: rhodecode/controllers/admin/settings.py:431
 msgid "Updated issue tracker entries"
 msgstr ""
 
-#: rhodecode/controllers/admin/repos.py:819
+#: rhodecode/controllers/admin/repos.py:537
 #: rhodecode/controllers/admin/settings.py:147
-#: rhodecode/controllers/admin/settings.py:619
+#: rhodecode/controllers/admin/settings.py:622
 msgid "Some form inputs contain invalid data."
 msgstr ""
 
-#: rhodecode/controllers/admin/repos.py:837
+#: rhodecode/controllers/admin/repos.py:555
 msgid "Error occurred during updating repository VCS settings"
 msgstr ""
 
-#: rhodecode/controllers/admin/repos.py:841
+#: rhodecode/controllers/admin/repos.py:559
 #: rhodecode/controllers/admin/settings.py:176
 msgid "Updated VCS settings"
 msgstr ""
 
 #: rhodecode/controllers/admin/settings.py:172
-#: rhodecode/controllers/admin/settings.py:283
+#: rhodecode/controllers/admin/settings.py:286
 msgid "Error occurred during updating application settings"
 msgstr ""
 
-#: rhodecode/controllers/admin/settings.py:223
+#: rhodecode/controllers/admin/settings.py:226
 #, python-format
 msgid "Repositories successfully rescanned added: %s ; removed: %s"
 msgstr ""
 
-#: rhodecode/controllers/admin/settings.py:279
+#: rhodecode/controllers/admin/settings.py:282
 msgid "Updated application settings"
 msgstr ""
 
-#: rhodecode/controllers/admin/settings.py:345
-msgid "Updated visualisation settings"
-msgstr ""
-
 #: rhodecode/controllers/admin/settings.py:348
+msgid "Updated visualisation settings"
+msgstr ""
+
+#: rhodecode/controllers/admin/settings.py:351
 msgid "Error occurred during updating visualisation settings"
 msgstr ""
 
-#: rhodecode/controllers/admin/settings.py:441
+#: rhodecode/controllers/admin/settings.py:444
 msgid "Please enter email address"
 msgstr ""
 
-#: rhodecode/controllers/admin/settings.py:459
+#: rhodecode/controllers/admin/settings.py:462
 msgid "Send email task created"
 msgstr ""
 
-#: rhodecode/controllers/admin/settings.py:492
+#: rhodecode/controllers/admin/settings.py:495
 msgid "Added new hook"
 msgstr ""
 
-#: rhodecode/controllers/admin/settings.py:507
+#: rhodecode/controllers/admin/settings.py:510
 msgid "Updated hooks"
 msgstr ""
 
-#: rhodecode/controllers/admin/settings.py:511
+#: rhodecode/controllers/admin/settings.py:514
 msgid "Error occurred during hook creation"
 msgstr ""
 
-#: rhodecode/controllers/admin/settings.py:640
+#: rhodecode/controllers/admin/settings.py:643
 msgid "Error occurred during updating labs settings"
 msgstr ""
 
-#: rhodecode/controllers/admin/settings.py:645
+#: rhodecode/controllers/admin/settings.py:648
 msgid "Updated Labs settings"
 msgstr ""
 
-#: rhodecode/controllers/admin/user_groups.py:165
+#: rhodecode/controllers/admin/user_groups.py:164
 #, python-format
 msgid "Created user group %(user_group_link)s"
 msgstr ""
 
-#: rhodecode/controllers/admin/user_groups.py:179
+#: rhodecode/controllers/admin/user_groups.py:178
 #, python-format
 msgid "Error occurred during creation of user group %s"
 msgstr ""
 
-#: rhodecode/controllers/admin/user_groups.py:220
+#: rhodecode/controllers/admin/user_groups.py:218
 #, python-format
 msgid "Updated user group %s"
 msgstr ""
 
-#: rhodecode/controllers/admin/user_groups.py:236
+#: rhodecode/controllers/admin/user_groups.py:234
 #, python-format
 msgid "Error occurred during update of user group %s"
 msgstr ""
 
+#: rhodecode/controllers/admin/user_groups.py:253
+msgid "Successfully deleted user group"
+msgstr ""
+
 #: rhodecode/controllers/admin/user_groups.py:258
-msgid "Successfully deleted user group"
-msgstr ""
-
-#: rhodecode/controllers/admin/user_groups.py:263
 msgid "An error occurred during deletion of user group"
 msgstr ""
 
-#: rhodecode/controllers/admin/user_groups.py:331
+#: rhodecode/controllers/admin/user_groups.py:326
 msgid "Target group cannot be the same"
 msgstr ""
 
-#: rhodecode/controllers/admin/user_groups.py:337
+#: rhodecode/controllers/admin/user_groups.py:332
 msgid "User Group permissions updated"
 msgstr ""
 
-#: rhodecode/controllers/admin/user_groups.py:422
+#: rhodecode/controllers/admin/user_groups.py:415
 msgid "User Group global permissions updated successfully"
 msgstr ""
 
-#: rhodecode/controllers/admin/user_groups.py:437
+#: rhodecode/controllers/admin/user_groups.py:430
 #: rhodecode/controllers/admin/users.py:477
 msgid "An error occurred during permissions saving"
 msgstr ""
 
-#: rhodecode/controllers/admin/user_groups.py:481
+#: rhodecode/controllers/admin/user_groups.py:474
 msgid "User Group synchronization updated successfully"
 msgstr ""
 
-#: rhodecode/controllers/admin/user_groups.py:485
+#: rhodecode/controllers/admin/user_groups.py:478
 msgid "An error occurred during synchronization update"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:106
+#: rhodecode/controllers/admin/users.py:108
 #, python-format
 msgid "Created user %(user_link)s"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:122
+#: rhodecode/controllers/admin/users.py:124
 #, python-format
 msgid "Error occurred during creation of user %s"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:167
+#: rhodecode/controllers/admin/users.py:166
 msgid "User updated successfully"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:218
+#: rhodecode/controllers/admin/users.py:209
 #, python-format
 msgid "Detached %s repositories"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:223
+#: rhodecode/controllers/admin/users.py:214
 #, python-format
 msgid "Deleted %s repositories"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:231
+#: rhodecode/controllers/admin/users.py:222
 #, python-format
 msgid "Detached %s repository groups"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:236
+#: rhodecode/controllers/admin/users.py:227
 #, python-format
 msgid "Deleted %s repository groups"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:244
+#: rhodecode/controllers/admin/users.py:235
 #, python-format
 msgid "Detached %s user groups"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:249
+#: rhodecode/controllers/admin/users.py:240
 #, python-format
 msgid "Deleted %s user groups"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:260
+#: rhodecode/controllers/admin/users.py:257
 msgid "Successfully deleted user"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:266
+#: rhodecode/controllers/admin/users.py:263
 msgid "An error occurred during deletion of user"
 msgstr ""
 
+#: rhodecode/controllers/admin/users.py:280
+msgid "Force password change disabled for user"
+msgstr ""
+
 #: rhodecode/controllers/admin/users.py:285
-msgid "Force password change disabled for user"
-msgstr ""
-
-#: rhodecode/controllers/admin/users.py:287
 msgid "Force password change enabled for user"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:291
+#: rhodecode/controllers/admin/users.py:294
 msgid "An error occurred during password reset for user"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:324
+#: rhodecode/controllers/admin/users.py:325
 #, python-format
 msgid "Linked repository group `%s` as personal"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:330
+#: rhodecode/controllers/admin/users.py:331
 #, python-format
 msgid "Created repository group `%s`"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:334
+#: rhodecode/controllers/admin/users.py:335
 #, python-format
 msgid "Repository group `%s` is already taken"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:339
+#: rhodecode/controllers/admin/users.py:340
 msgid "An error occurred during repository group creation for user"
 msgstr ""
 
@@ -1435,81 +1453,63 b' msgstr ""'
 msgid "The user participates as reviewer in pull requests and cannot be deleted. You can set the user to \"inactive\" instead of deleting it."
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:461
+#: rhodecode/controllers/admin/users.py:462
 msgid "User global permissions updated successfully"
 msgstr ""
 
-#: rhodecode/controllers/admin/users.py:589
-#, python-format
-msgid "An error occurred during ip saving:%s"
-msgstr ""
-
-#: rhodecode/controllers/admin/users.py:604
-msgid "An error occurred during ip saving"
-msgstr ""
-
-#: rhodecode/controllers/admin/users.py:608
-#, python-format
-msgid "Added ips %s to user whitelist"
-msgstr ""
-
-#: rhodecode/controllers/admin/users.py:626
-msgid "Removed ip address from user whitelist"
-msgstr ""
-
-#: rhodecode/events/pullrequest.py:68
+#: rhodecode/events/pullrequest.py:71
 msgid "pullrequest created"
 msgstr ""
 
-#: rhodecode/events/pullrequest.py:77
+#: rhodecode/events/pullrequest.py:80
 msgid "pullrequest closed"
 msgstr ""
 
-#: rhodecode/events/pullrequest.py:86
+#: rhodecode/events/pullrequest.py:89
 msgid "pullrequest commits updated"
 msgstr ""
 
-#: rhodecode/events/pullrequest.py:95
+#: rhodecode/events/pullrequest.py:98
 msgid "pullrequest review changed"
 msgstr ""
 
-#: rhodecode/events/pullrequest.py:104
+#: rhodecode/events/pullrequest.py:107
 msgid "pullrequest merged"
 msgstr ""
 
-#: rhodecode/events/pullrequest.py:113
+#: rhodecode/events/pullrequest.py:116
 msgid "pullrequest commented"
 msgstr ""
 
-#: rhodecode/events/repo.py:138
+#: rhodecode/events/repo.py:148
 msgid "repository pre create"
 msgstr ""
 
-#: rhodecode/events/repo.py:147
+#: rhodecode/events/repo.py:157
 msgid "repository created"
 msgstr ""
 
-#: rhodecode/events/repo.py:156
+#: rhodecode/events/repo.py:166
 msgid "repository pre delete"
 msgstr ""
 
-#: rhodecode/events/repo.py:165
+#: rhodecode/events/repo.py:175
 msgid "repository deleted"
 msgstr ""
 
-#: rhodecode/events/repo.py:201
+#: rhodecode/events/repo.py:211
 msgid "repository pre pull"
 msgstr ""
 
-#: rhodecode/events/repo.py:210
+#: rhodecode/events/repo.py:220
 msgid "repository pull"
 msgstr ""
 
-#: rhodecode/events/repo.py:219
+#: rhodecode/events/repo.py:229
 msgid "repository pre push"
 msgstr ""
 
-#: rhodecode/events/repo.py:230
+#: rhodecode/events/repo.py:240
 msgid "repository push"
 msgstr ""
 
@@ -1541,7 +1541,7 b' msgstr ""'
 msgid "user pre update"
 msgstr ""
 
-#: rhodecode/forms/__init__.py:32 rhodecode/templates/admin/gists/new.mako:62
+#: rhodecode/forms/__init__.py:35 rhodecode/templates/admin/gists/new.mako:62
 #: rhodecode/templates/admin/my_account/my_account_auth_tokens.mako:87
 #: rhodecode/templates/admin/my_account/my_account_emails.mako:65
 #: rhodecode/templates/admin/my_account/my_account_profile_edit.mako:107
@@ -1552,8 +1552,8 b' msgstr ""'
 #: rhodecode/templates/admin/repo_groups/repo_group_edit_settings.mako:68
 #: rhodecode/templates/admin/repos/repo_edit_fields.mako:66
 #: rhodecode/templates/admin/repos/repo_edit_issuetracker.mako:80
-#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:111
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:161
+#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:110
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:195
 #: rhodecode/templates/admin/repos/repo_edit_vcs.mako:44
 #: rhodecode/templates/admin/settings/settings_global.mako:140
 #: rhodecode/templates/admin/settings/settings_issuetracker.mako:16
@@ -1563,13 +1563,13 b' msgstr ""'
 #: rhodecode/templates/admin/user_groups/user_group_edit_perms.mako:121
 #: rhodecode/templates/admin/users/user_edit_auth_tokens.mako:83
 #: rhodecode/templates/admin/users/user_edit_emails.mako:63
-#: rhodecode/templates/admin/users/user_edit_ips.mako:70
+#: rhodecode/templates/admin/users/user_edit_ips.mako:71
 #: rhodecode/templates/admin/users/user_edit_profile.mako:135
 #: rhodecode/templates/base/default_perms_box.mako:89
 msgid "Reset"
 msgstr ""
 
-#: rhodecode/forms/__init__.py:33 rhodecode/templates/admin/gists/show.mako:49
+#: rhodecode/forms/__init__.py:36 rhodecode/templates/admin/gists/show.mako:49
 #: rhodecode/templates/admin/integrations/list.mako:211
 #: rhodecode/templates/admin/my_account/my_account_auth_tokens.mako:49
 #: rhodecode/templates/admin/my_account/my_account_emails.mako:32
@@ -1578,13 +1578,13 b' msgstr ""'
 #: rhodecode/templates/admin/settings/settings_hooks.mako:46
 #: rhodecode/templates/admin/users/user_edit_auth_tokens.mako:45
 #: rhodecode/templates/admin/users/user_edit_emails.mako:31
-#: rhodecode/templates/admin/users/user_edit_ips.mako:34
+#: rhodecode/templates/admin/users/user_edit_ips.mako:35
 #: rhodecode/templates/base/issue_tracker_settings.mako:69
-#: rhodecode/templates/base/vcs_settings.mako:251
-#: rhodecode/templates/base/vcs_settings.mako:276
-#: rhodecode/templates/changeset/changeset_file_comment.mako:137
-#: rhodecode/templates/changeset/changeset_file_comment.mako:139
+#: rhodecode/templates/base/vcs_settings.mako:264
+#: rhodecode/templates/base/vcs_settings.mako:289
 #: rhodecode/templates/changeset/changeset_file_comment.mako:142
+#: rhodecode/templates/changeset/changeset_file_comment.mako:144
+#: rhodecode/templates/changeset/changeset_file_comment.mako:147
 #: rhodecode/templates/data_table/_dt_elements.mako:123
 #: rhodecode/templates/data_table/_dt_elements.mako:184
 #: rhodecode/templates/data_table/_dt_elements.mako:198
@@ -1732,16 +1732,15 b' msgstr ""'
 
 #: rhodecode/integrations/types/slack.py:60 rhodecode/templates/login.mako:43
 #: rhodecode/templates/register.mako:41
-#: rhodecode/templates/admin/admin_log.mako:7
+#: rhodecode/templates/admin/admin_log_base.mako:6
 #: rhodecode/templates/admin/my_account/my_account_profile.mako:24
 #: rhodecode/templates/admin/my_account/my_account_profile_edit.mako:24
 #: rhodecode/templates/admin/my_account/my_account_profile_edit.mako:69
 #: rhodecode/templates/admin/user_groups/user_group_edit_settings.mako:70
 #: rhodecode/templates/admin/users/user_add.mako:35
-#: rhodecode/templates/admin/users/user_edit_audit.mako:22
 #: rhodecode/templates/admin/users/user_edit_profile.mako:39
-#: rhodecode/templates/admin/users/users.mako:62
-#: rhodecode/templates/base/base.mako:304
+#: rhodecode/templates/admin/users/users.mako:63
+#: rhodecode/templates/base/base.mako:306
 #: rhodecode/templates/debug_style/login.html:36
 #: rhodecode/templates/email_templates/user_registration.mako:23
 #: rhodecode/templates/users/user_profile.mako:27
@@ -1776,180 +1775,180 b' msgstr ""'
 msgid "Send events such as repo pushes and pull requests to your slack channel."
 msgstr ""
 
-#: rhodecode/integrations/types/webhook.py:152
+#: rhodecode/integrations/types/webhook.py:164
 msgid "Webhook URL"
 msgstr ""
 
-#: rhodecode/integrations/types/webhook.py:154
+#: rhodecode/integrations/types/webhook.py:166
 msgid "URL of the webhook to receive POST event. Following variables are allowed to be used: {vars}. Some of the variables would trigger multiple calls, like ${{branch}} or ${{commit_id}}. Webhook will be called as many times as unique objects in data in such cases."
 msgstr ""
 
-#: rhodecode/integrations/types/webhook.py:168
+#: rhodecode/integrations/types/webhook.py:180
 msgid "Secret Token"
 msgstr ""
 
-#: rhodecode/integrations/types/webhook.py:169
+#: rhodecode/integrations/types/webhook.py:181
 msgid "String used to validate received payloads."
 msgstr ""
 
-#: rhodecode/integrations/types/webhook.py:178
+#: rhodecode/integrations/types/webhook.py:190
 msgid "Call Method"
 msgstr ""
 
-#: rhodecode/integrations/types/webhook.py:179
+#: rhodecode/integrations/types/webhook.py:191
 msgid "Select if the webhook call should be made with POST or GET."
 msgstr ""
 
-#: rhodecode/integrations/types/webhook.py:192
+#: rhodecode/integrations/types/webhook.py:204
 msgid "Webhook"
 msgstr ""
 
-#: rhodecode/integrations/types/webhook.py:193
+#: rhodecode/integrations/types/webhook.py:205
 msgid "Post json events to a webhook endpoint"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:89
+#: rhodecode/lib/action_parser.py:94
 msgid "[deleted] repository"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:92 rhodecode/lib/action_parser.py:110
+#: rhodecode/lib/action_parser.py:97 rhodecode/lib/action_parser.py:115
 msgid "[created] repository"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:95
+#: rhodecode/lib/action_parser.py:100
 msgid "[created] repository as fork"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:98 rhodecode/lib/action_parser.py:113
+#: rhodecode/lib/action_parser.py:103 rhodecode/lib/action_parser.py:118
 msgid "[forked] repository"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:101 rhodecode/lib/action_parser.py:116
+#: rhodecode/lib/action_parser.py:106 rhodecode/lib/action_parser.py:121
 msgid "[updated] repository"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:104
+#: rhodecode/lib/action_parser.py:109
 msgid "[downloaded] archive from repository"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:107
+#: rhodecode/lib/action_parser.py:112
 msgid "[delete] repository"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:119
+#: rhodecode/lib/action_parser.py:124
 msgid "[created] user"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:122
+#: rhodecode/lib/action_parser.py:127
 msgid "[updated] user"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:125
+#: rhodecode/lib/action_parser.py:130
 msgid "[created] user group"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:128
+#: rhodecode/lib/action_parser.py:133
 msgid "[updated] user group"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:131
+#: rhodecode/lib/action_parser.py:136
 msgid "[commented] on commit in repository"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:134
+#: rhodecode/lib/action_parser.py:139
 msgid "[commented] on pull request for"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:137
+#: rhodecode/lib/action_parser.py:142
 msgid "[closed] pull request for"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:140
+#: rhodecode/lib/action_parser.py:145
 msgid "[merged] pull request for"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:143
+#: rhodecode/lib/action_parser.py:148
 msgid "[pushed] into"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:146
+#: rhodecode/lib/action_parser.py:151
 msgid "[committed via RhodeCode] into repository"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:149
+#: rhodecode/lib/action_parser.py:154
 msgid "[pulled from remote] into repository"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:152
+#: rhodecode/lib/action_parser.py:157
 msgid "[pulled] from"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:155
+#: rhodecode/lib/action_parser.py:160
 msgid "[started following] repository"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:158
+#: rhodecode/lib/action_parser.py:163
 msgid "[stopped following] repository"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:166
+#: rhodecode/lib/action_parser.py:172
 #, python-format
 msgid "fork name %s"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:183
+#: rhodecode/lib/action_parser.py:190
 #: rhodecode/templates/pullrequests/pullrequest_show.mako:51
 #, python-format
 msgid "Pull request #%s"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:216
+#: rhodecode/lib/action_parser.py:223
 #, python-format
 msgid "Show all combined commits %s->%s"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:220
-msgid "compare view"
-msgstr ""
-
 #: rhodecode/lib/action_parser.py:227
+msgid "compare view"
+msgstr ""
+
+#: rhodecode/lib/action_parser.py:234
 #, python-format
 msgid " and %(num)s more commits"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:279
+#: rhodecode/lib/action_parser.py:286
 #, python-format
 msgid "Deleted branch: %s"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:282
+#: rhodecode/lib/action_parser.py:289
 #, python-format
 msgid "Created tag: %s"
 msgstr ""
 
-#: rhodecode/lib/action_parser.py:295
+#: rhodecode/lib/action_parser.py:302
 msgid "Commit not found"
 msgstr ""
 
-#: rhodecode/lib/auth.py:1197
+#: rhodecode/lib/auth.py:1220
 #, python-format
 msgid "IP %s not allowed"
 msgstr ""
 
-#: rhodecode/lib/auth.py:1281
+#: rhodecode/lib/auth.py:1309
 msgid "You need to be a registered user to perform this action"
 msgstr ""
 
-#: rhodecode/lib/auth.py:1329
+#: rhodecode/lib/auth.py:1366
 #, python-format
 msgid "Action not supported for %s."
 msgstr ""
 
-#: rhodecode/lib/auth.py:1379
+#: rhodecode/lib/auth.py:1412
 msgid "You need to be signed in to view this page"
 msgstr ""
 
-#: rhodecode/lib/base.py:549
+#: rhodecode/lib/base.py:561
 #, python-format
 msgid "The repository at %(repo_name)s cannot be located."
 msgstr ""
@@ -1974,20 +1973,21 b' msgstr ""'
 msgid "Click to select line"
 msgstr ""
 
-#: rhodecode/lib/helpers.py:1517
+#: rhodecode/lib/helpers.py:1527
 #, python-format
 msgid " and %s more"
 msgstr ""
 
-#: rhodecode/lib/helpers.py:1521
+#: rhodecode/lib/helpers.py:1531
 msgid "No Files"
 msgstr ""
 
-#: rhodecode/lib/helpers.py:1800
+#: rhodecode/lib/helpers.py:1836
 msgid ""
 "Example filter terms:\n"
 "     repository:vcs\n"
 "     username:marcin\n"
+"     username:(NOT marcin)\n"
 "     action:*push*\n"
 "     ip:127.0.0.1\n"
 "     date:20120101\n"
@@ -2002,7 +2002,21 b' msgid ""'
 "     \"username:test AND repository:test*\"\n"
 msgstr ""
 
-#: rhodecode/lib/helpers.py:1820
+#: rhodecode/lib/helpers.py:1859
+msgid ""
+"Example filter terms for `{searcher}` search:\n"
+"{terms}\n"
+"Generate wildcards using '*' character:\n"
+"     \"repo_name:vcs*\" - search everything starting with 'vcs'\n"
+"     \"repo_name:*vcs*\" - search for repository containing 'vcs'\n"
+"\n"
+"Optional AND / OR operators in queries\n"
+"     \"repo_name:vcs OR repo_name:test\"\n"
+"     \"owner:test AND repo_name:test*\"\n"
+"More: {search_doc}"
+msgstr ""
+
+#: rhodecode/lib/helpers.py:1875
 #, python-format
 msgid "%s repository is not mapped to db perhaps it was created or renamed from the filesystem please run the application again in order to rescan repositories"
 msgstr ""
@@ -2042,7 +2056,7 b' msgstr ""'
 #: rhodecode/lib/utils2.py:515
 #: rhodecode/public/js/rhodecode-components.js:33659
 #: rhodecode/public/js/scripts.js:25507
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:66
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:74
 #: rhodecode/public/js/src/plugins/jquery.timeago-extension.js:174
 msgid "just now"
 msgstr ""
@@ -2076,7 +2090,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2289
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2289
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2339
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2340 rhodecode/model/db.py:2410
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2340 rhodecode/model/db.py:2482
 msgid "Repository no access"
 msgstr ""
 
@@ -2109,7 +2123,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2290
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2290
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2340
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2341 rhodecode/model/db.py:2411
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2341 rhodecode/model/db.py:2483
 msgid "Repository read access"
 msgstr ""
 
@@ -2142,7 +2156,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2291
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2291
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2341
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2342 rhodecode/model/db.py:2412
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2342 rhodecode/model/db.py:2484
 msgid "Repository write access"
 msgstr ""
 
@@ -2175,7 +2189,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2292
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2292
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2342
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2343 rhodecode/model/db.py:2413
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2343 rhodecode/model/db.py:2485
 msgid "Repository admin access"
 msgstr ""
 
@@ -2248,7 +2262,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2310
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2310
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2360
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2361 rhodecode/model/db.py:2431
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2361 rhodecode/model/db.py:2503
 msgid "Repository creation disabled"
 msgstr ""
 
@@ -2281,7 +2295,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2311
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2311
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2361
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2362 rhodecode/model/db.py:2432
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2362 rhodecode/model/db.py:2504
 msgid "Repository creation enabled"
 msgstr ""
 
@@ -2314,7 +2328,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2315
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2315
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2365
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2366 rhodecode/model/db.py:2436
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2366 rhodecode/model/db.py:2508
 msgid "Repository forking disabled"
 msgstr ""
 
@@ -2347,7 +2361,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2316
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2316
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2366
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2367 rhodecode/model/db.py:2437
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2367 rhodecode/model/db.py:2509
 msgid "Repository forking enabled"
 msgstr ""
 
@@ -2401,7 +2415,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2950
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2950
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:3050
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:3051 rhodecode/model/db.py:3121
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:3051 rhodecode/model/db.py:3212
 msgid "Not Reviewed"
 msgstr ""
 
@@ -2434,7 +2448,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2951
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2951
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:3051
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:3052 rhodecode/model/db.py:3122
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:3052 rhodecode/model/db.py:3213
 msgid "Approved"
 msgstr ""
 
@@ -2467,7 +2481,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2952
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2952
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:3052
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:3053 rhodecode/model/db.py:3123
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:3053 rhodecode/model/db.py:3214
 msgid "Rejected"
 msgstr ""
 
@@ -2500,7 +2514,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2953
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2953
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:3053
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:3054 rhodecode/model/db.py:3124
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:3054 rhodecode/model/db.py:3215
 msgid "Under Review"
 msgstr ""
 
@@ -2530,7 +2544,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2294
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2294
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2344
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2345 rhodecode/model/db.py:2415
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2345 rhodecode/model/db.py:2487
 msgid "Repository group no access"
 msgstr ""
 
@@ -2560,7 +2574,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2295
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2295
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2345
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2346 rhodecode/model/db.py:2416
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2346 rhodecode/model/db.py:2488
 msgid "Repository group read access"
 msgstr ""
 
@@ -2590,7 +2604,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2296
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2296
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2346
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2347 rhodecode/model/db.py:2417
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2347 rhodecode/model/db.py:2489
 msgid "Repository group write access"
 msgstr ""
 
@@ -2620,7 +2634,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2297
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2297
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2347
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2348 rhodecode/model/db.py:2418
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2348 rhodecode/model/db.py:2490
 msgid "Repository group admin access"
 msgstr ""
 
@@ -2649,7 +2663,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2299
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2299
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2349
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2350 rhodecode/model/db.py:2420
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2350 rhodecode/model/db.py:2492
 msgid "User group no access"
 msgstr ""
 
@@ -2678,7 +2692,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2300
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2300
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2350
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2351 rhodecode/model/db.py:2421
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2351 rhodecode/model/db.py:2493
 msgid "User group read access"
 msgstr ""
 
@@ -2707,7 +2721,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2301
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2301
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2351
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2352 rhodecode/model/db.py:2422
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2352 rhodecode/model/db.py:2494
 msgid "User group write access"
 msgstr ""
 
@@ -2736,7 +2750,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2302
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2302
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2352
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2353 rhodecode/model/db.py:2423
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2353 rhodecode/model/db.py:2495
 msgid "User group admin access"
 msgstr ""
 
@@ -2765,7 +2779,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2304
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2304
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2354
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2355 rhodecode/model/db.py:2425
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2355 rhodecode/model/db.py:2497
 msgid "Repository Group creation disabled"
 msgstr ""
 
@@ -2794,7 +2808,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2305
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2305
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2355
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2356 rhodecode/model/db.py:2426
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2356 rhodecode/model/db.py:2498
 msgid "Repository Group creation enabled"
 msgstr ""
 
@@ -2823,7 +2837,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2307
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2307
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2357
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2358 rhodecode/model/db.py:2428
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2358 rhodecode/model/db.py:2500
 msgid "User Group creation disabled"
 msgstr ""
 
@@ -2852,7 +2866,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2308
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2308
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2358
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2359 rhodecode/model/db.py:2429
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2359 rhodecode/model/db.py:2501
 msgid "User Group creation enabled"
 msgstr ""
 
@@ -2881,7 +2895,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2318
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2318
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2368
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2369 rhodecode/model/db.py:2439
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2369 rhodecode/model/db.py:2511
 msgid "Registration disabled"
 msgstr ""
 
@@ -2910,7 +2924,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2319
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2319
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2369
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2370 rhodecode/model/db.py:2440
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2370 rhodecode/model/db.py:2512
 msgid "User Registration with manual account activation"
 msgstr ""
 
@@ -2939,7 +2953,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2320
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2320
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2370
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2371 rhodecode/model/db.py:2441
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2371 rhodecode/model/db.py:2513
 msgid "User Registration with automatic account activation"
 msgstr ""
 
@@ -2968,7 +2982,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2322
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2322
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2376
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2377 rhodecode/model/db.py:2447
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2377 rhodecode/model/db.py:2519
 #: rhodecode/model/permission.py:95
 msgid "Manual activation of external account"
 msgstr ""
@@ -2998,7 +3012,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2323
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2323
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2377
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2378 rhodecode/model/db.py:2448
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2378 rhodecode/model/db.py:2520
 #: rhodecode/model/permission.py:96
 msgid "Automatic activation of external account"
 msgstr ""
@@ -3022,7 +3036,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2312
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2312
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2362
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2363 rhodecode/model/db.py:2433
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2363 rhodecode/model/db.py:2505
 msgid "Repository creation enabled with write permission to a repository group"
 msgstr ""
 
@@ -3045,7 +3059,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2313
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2313
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2363
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2364 rhodecode/model/db.py:2434
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2364 rhodecode/model/db.py:2506
 msgid "Repository creation disabled with write permission to a repository group"
 msgstr ""
 
@@ -3065,7 +3079,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2287
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2287
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2337
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2338 rhodecode/model/db.py:2408
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2338 rhodecode/model/db.py:2480
 msgid "RhodeCode Super Administrator"
 msgstr ""
 
@@ -3083,7 +3097,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2325
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2325
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2379
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2380 rhodecode/model/db.py:2450
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2380 rhodecode/model/db.py:2522
 msgid "Inherit object permissions from default user disabled"
 msgstr ""
 
@@ -3101,7 +3115,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2326
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2326
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2380
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2381 rhodecode/model/db.py:2451
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2381 rhodecode/model/db.py:2523
 msgid "Inherit object permissions from default user enabled"
 msgstr ""
 
@@ -3111,7 +3125,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:912
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:912
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:954
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:955 rhodecode/model/db.py:1008
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:955 rhodecode/model/db.py:1043
 msgid "all"
 msgstr ""
 
@@ -3121,7 +3135,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:913
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:913
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:955
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:956 rhodecode/model/db.py:1009
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:956 rhodecode/model/db.py:1044
 msgid "http/web interface"
 msgstr ""
 
@@ -3131,7 +3145,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:914
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:914
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:956
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:957 rhodecode/model/db.py:1010
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:957 rhodecode/model/db.py:1045
 msgid "vcs (git/hg/svn protocol)"
 msgstr ""
 
@@ -3141,7 +3155,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:915
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:915
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:957
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:958 rhodecode/model/db.py:1011
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:958 rhodecode/model/db.py:1046
 msgid "api calls"
 msgstr ""
 
@@ -3151,7 +3165,7 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:916
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:916
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:958
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:959 rhodecode/model/db.py:1012
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:959 rhodecode/model/db.py:1047
 msgid "feed access"
 msgstr ""
 
@@ -3161,62 +3175,62 b' msgstr ""'
 #: rhodecode/lib/dbmigrate/schema/db_4_4_0_2.py:2065
 #: rhodecode/lib/dbmigrate/schema/db_4_5_0_0.py:2065
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2108
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2109 rhodecode/model/db.py:2179
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2109 rhodecode/model/db.py:2248
 msgid "No parent"
 msgstr ""
 
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2372
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2373 rhodecode/model/db.py:2443
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2373 rhodecode/model/db.py:2515
 msgid "Password reset enabled"
 msgstr ""
 
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2373
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2374 rhodecode/model/db.py:2444
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2374 rhodecode/model/db.py:2516
 msgid "Password reset hidden"
 msgstr ""
 
 #: rhodecode/lib/dbmigrate/schema/db_4_7_0_0.py:2374
-#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2375 rhodecode/model/db.py:2445
+#: rhodecode/lib/dbmigrate/schema/db_4_7_0_1.py:2375 rhodecode/model/db.py:2517
 msgid "Password reset disabled"
 msgstr ""
 
-#: rhodecode/lib/index/whoosh.py:149
+#: rhodecode/lib/index/whoosh.py:150
 msgid "Invalid search query. Try quoting it."
 msgstr ""
 
-#: rhodecode/lib/index/whoosh.py:151
+#: rhodecode/lib/index/whoosh.py:152
 msgid "There is no index to search in. Please run whoosh indexer"
 msgstr ""
 
-#: rhodecode/lib/index/whoosh.py:156
+#: rhodecode/lib/index/whoosh.py:157
 msgid "An error occurred during this search operation"
 msgstr ""
 
-#: rhodecode/lib/index/whoosh.py:164
-msgid "Index Type"
-msgstr ""
-
 #: rhodecode/lib/index/whoosh.py:165
+msgid "Index Type"
+msgstr ""
+
+#: rhodecode/lib/index/whoosh.py:166
 msgid "File Index"
 msgstr ""
 
-#: rhodecode/lib/index/whoosh.py:166 rhodecode/lib/index/whoosh.py:171
+#: rhodecode/lib/index/whoosh.py:167 rhodecode/lib/index/whoosh.py:172
 msgid "Indexed documents"
 msgstr ""
 
-#: rhodecode/lib/index/whoosh.py:168 rhodecode/lib/index/whoosh.py:173
+#: rhodecode/lib/index/whoosh.py:169 rhodecode/lib/index/whoosh.py:174
 msgid "Last update"
 msgstr ""
 
-#: rhodecode/lib/index/whoosh.py:170
+#: rhodecode/lib/index/whoosh.py:171
 msgid "Commit index"
 msgstr ""
 
-#: rhodecode/model/comment.py:368
+#: rhodecode/model/comment.py:374
 msgid "made a comment"
 msgstr ""
 
-#: rhodecode/model/comment.py:369
+#: rhodecode/model/comment.py:375
 msgid "Show it now"
 msgstr ""
 
@@ -3302,7 +3316,7 b' msgstr ""'
 #: rhodecode/model/permission.py:79
 #: rhodecode/templates/admin/repo_groups/repo_group_edit_perms.mako:11
 #: rhodecode/templates/admin/repo_groups/repo_group_edit_perms.mako:126
-#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:12
+#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:11
 #: rhodecode/templates/admin/user_groups/user_group_edit_perms.mako:11
 msgid "None"
 msgstr ""
@@ -3310,7 +3324,7 b' msgstr ""'
 #: rhodecode/model/permission.py:68 rhodecode/model/permission.py:74
 #: rhodecode/model/permission.py:80
 #: rhodecode/templates/admin/repo_groups/repo_group_edit_perms.mako:12
-#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:13
+#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:12
 #: rhodecode/templates/admin/user_groups/user_group_edit_perms.mako:12
 msgid "Read"
 msgstr ""
@@ -3318,10 +3332,10 b' msgstr ""'
 #: rhodecode/model/permission.py:69 rhodecode/model/permission.py:75
 #: rhodecode/model/permission.py:81
 #: rhodecode/templates/admin/repo_groups/repo_group_edit_perms.mako:13
-#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:14
+#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:13
 #: rhodecode/templates/admin/user_groups/user_group_edit_perms.mako:13
-#: rhodecode/templates/changeset/changeset_file_comment.mako:266
-#: rhodecode/templates/changeset/changeset_file_comment.mako:316
+#: rhodecode/templates/changeset/changeset_file_comment.mako:271
+#: rhodecode/templates/changeset/changeset_file_comment.mako:321
 msgid "Write"
 msgstr ""
 
@@ -3344,7 +3358,7 b' msgstr ""'
 #: rhodecode/templates/admin/repo_groups/repo_groups.mako:13
 #: rhodecode/templates/admin/repos/repo_add.mako:13
 #: rhodecode/templates/admin/repos/repo_add.mako:17
-#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:15
+#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:14
 #: rhodecode/templates/admin/repos/repos.mako:13
 #: rhodecode/templates/admin/settings/settings.mako:12
 #: rhodecode/templates/admin/user_groups/user_group_add.mako:11
@@ -3354,9 +3368,9 b' msgstr ""'
 #: rhodecode/templates/admin/users/user_add.mako:11
 #: rhodecode/templates/admin/users/user_edit.mako:12
 #: rhodecode/templates/admin/users/users.mako:13
-#: rhodecode/templates/admin/users/users.mako:75
-#: rhodecode/templates/base/base.mako:409
-#: rhodecode/templates/base/base.mako:416
+#: rhodecode/templates/admin/users/users.mako:76
+#: rhodecode/templates/base/base.mako:412
+#: rhodecode/templates/base/base.mako:419
 msgid "Admin"
 msgstr ""
 
@@ -3387,79 +3401,79 b' msgstr ""'
 msgid "Disable password recovery"
 msgstr ""
 
-#: rhodecode/model/pull_request.py:78
+#: rhodecode/model/pull_request.py:80
 msgid "This pull request can be automatically merged."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:80
+#: rhodecode/model/pull_request.py:82
 msgid "This pull request cannot be merged because of an unhandled exception."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:83
-msgid "This pull request cannot be merged because of merge conflicts."
-msgstr ""
-
 #: rhodecode/model/pull_request.py:85
+msgid "This pull request cannot be merged because of merge conflicts."
+msgstr ""
+
+#: rhodecode/model/pull_request.py:87
 msgid "This pull request could not be merged because push to target failed."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:88
+#: rhodecode/model/pull_request.py:90
 msgid "This pull request cannot be merged because the target is not a head."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:91
+#: rhodecode/model/pull_request.py:93
 msgid "This pull request cannot be merged because the source contains more branches than the target."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:94
+#: rhodecode/model/pull_request.py:96
 msgid "This pull request cannot be merged because the target has multiple heads."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:97
+#: rhodecode/model/pull_request.py:99
 msgid "This pull request cannot be merged because the target repository is locked."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:100
+#: rhodecode/model/pull_request.py:102
 msgid "This pull request cannot be merged because the target or the source reference is missing."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:103
+#: rhodecode/model/pull_request.py:105
 msgid "This pull request cannot be merged because the target reference is missing."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:106
+#: rhodecode/model/pull_request.py:108
 msgid "This pull request cannot be merged because the source reference is missing."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:109
+#: rhodecode/model/pull_request.py:111
 msgid "This pull request cannot be merged because of conflicts related to sub repositories."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:115
-msgid "Pull request update successful."
-msgstr ""
-
 #: rhodecode/model/pull_request.py:117
-msgid "Pull request update failed because of an unknown error."
+msgid "Pull request update successful."
 msgstr ""
 
 #: rhodecode/model/pull_request.py:119
-msgid "No update needed because the source and target have not changed."
+msgid "Pull request update failed because of an unknown error."
 msgstr ""
 
 #: rhodecode/model/pull_request.py:121
-msgid "Pull request cannot be updated because the reference type is not supported for an update."
-msgstr ""
-
-#: rhodecode/model/pull_request.py:124
+msgid "No update needed because the source and target have not changed."
+msgstr ""
+
+#: rhodecode/model/pull_request.py:123
+msgid "Pull request cannot be updated because the reference type is not supported for an update. Only Branch, Tag or Bookmark is allowed."
+msgstr ""
+
+#: rhodecode/model/pull_request.py:126
 msgid "This pull request cannot be updated because the target reference is missing."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:127
+#: rhodecode/model/pull_request.py:129
 msgid "This pull request cannot be updated because the source reference is missing."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:524
+#: rhodecode/model/pull_request.py:544
 #, python-format
 msgid ""
 "Merge pull request #%(pr_id)s from %(source_repo)s %(source_ref_name)s\n"
@@ -3467,86 +3481,90 b' msgid ""'
 " %(pr_title)s"
 msgstr ""
 
-#: rhodecode/model/pull_request.py:556
+#: rhodecode/model/pull_request.py:576
 msgid "Pull request merged and closed"
 msgstr ""
 
-#: rhodecode/model/pull_request.py:1087
+#: rhodecode/model/pull_request.py:1108
+msgid "Closing with status change {transition_icon} {status}."
+msgstr ""
+
+#: rhodecode/model/pull_request.py:1152
 msgid "Server-side pull request merging is disabled."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:1089
+#: rhodecode/model/pull_request.py:1154
 msgid "This pull request is closed."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:1101
+#: rhodecode/model/pull_request.py:1166
 msgid "Pull request merging is not supported."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:1119
+#: rhodecode/model/pull_request.py:1184
 msgid "Target repository large files support is disabled."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:1122
+#: rhodecode/model/pull_request.py:1187
 msgid "Source repository large files support is disabled."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:1279 rhodecode/model/scm.py:790
+#: rhodecode/model/pull_request.py:1344 rhodecode/model/scm.py:783
 msgid "Bookmarks"
 msgstr ""
 
-#: rhodecode/model/pull_request.py:1284
+#: rhodecode/model/pull_request.py:1349
 msgid "Commit IDs"
 msgstr ""
 
-#: rhodecode/model/pull_request.py:1287
+#: rhodecode/model/pull_request.py:1352
 msgid "Closed Branches"
 msgstr ""
 
-#: rhodecode/model/pull_request.py:1411
+#: rhodecode/model/pull_request.py:1493
 msgid "User `{}` not allowed to perform merge."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:1424
+#: rhodecode/model/pull_request.py:1506
 msgid "Pull request reviewer approval is pending."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:1439
+#: rhodecode/model/pull_request.py:1521
 msgid "Cannot merge, {} TODO still not resolved."
 msgstr ""
 
-#: rhodecode/model/pull_request.py:1442
+#: rhodecode/model/pull_request.py:1524
 msgid "Cannot merge, {} TODOs still not resolved."
 msgstr ""
 
-#: rhodecode/model/scm.py:768
+#: rhodecode/model/scm.py:761
 msgid "latest tip"
 msgstr ""
 
-#: rhodecode/model/user.py:126
+#: rhodecode/model/user.py:166
 msgid "You can't Edit this user since it's crucial for entire application"
 msgstr ""
 
-#: rhodecode/model/user.py:292
+#: rhodecode/model/user.py:332
 #, python-format
 msgid "You can't edit this user (`%(username)s`) since it's crucial for entire application"
 msgstr ""
 
-#: rhodecode/model/user.py:462
+#: rhodecode/model/user.py:502
 msgid "You can't remove this user since it's crucial for entire application"
 msgstr ""
 
-#: rhodecode/model/user.py:470
+#: rhodecode/model/user.py:510
 #, python-format
 msgid "user \"%s\" still owns %s repositories and cannot be removed. Switch owners or remove those repositories:%s"
 msgstr ""
 
-#: rhodecode/model/user.py:479
+#: rhodecode/model/user.py:519
 #, python-format
 msgid "user \"%s\" still owns %s repository groups and cannot be removed. Switch owners or remove those repository groups:%s"
 msgstr ""
 
-#: rhodecode/model/user.py:488
+#: rhodecode/model/user.py:528
 #, python-format
 msgid "user \"%s\" still owns %s user groups and cannot be removed. Switch owners or remove those user groups:%s"
 msgstr ""
@@ -3570,6 +3588,7 b' msgid "Username \\"%(username)s\\" is forb'
 msgstr ""
 
 #: rhodecode/model/validators.py:164
+#: rhodecode/model/validation_schema/schemas/user_schema.py:69
 msgid "Username may only contain alphanumeric characters underscores, periods or dashes and must begin with alphanumeric character or underscore"
 msgstr ""
 
@@ -3675,94 +3694,107 b' msgstr ""'
 msgid "Repository group with name \"%(repo)s\" exists in group \"%(group)s\""
 msgstr ""
 
-#: rhodecode/model/validators.py:620
+#: rhodecode/model/validators.py:581
+#: rhodecode/model/validation_schema/schemas/repo_schema.py:219
+msgid "Repository name cannot end with .git"
+msgstr ""
+
+#: rhodecode/model/validators.py:640
 #, python-format
 msgid "invalid clone url for %(rtype)s repository"
 msgstr ""
 
-#: rhodecode/model/validators.py:621
+#: rhodecode/model/validators.py:641
 #, python-format
 msgid "Invalid clone url, provide a valid clone url starting with one of %(allowed_prefixes)s"
 msgstr ""
 
-#: rhodecode/model/validators.py:650
+#: rhodecode/model/validators.py:670
 msgid "Fork have to be the same type as parent"
 msgstr ""
 
-#: rhodecode/model/validators.py:665
+#: rhodecode/model/validators.py:685
 msgid "You do not have the permission to create repositories in this group."
 msgstr ""
 
-#: rhodecode/model/validators.py:668
-#: rhodecode/model/validation_schema/schemas/repo_schema.py:102
+#: rhodecode/model/validators.py:688
+#: rhodecode/model/validation_schema/schemas/repo_schema.py:125
 msgid "You do not have the permission to store repositories in the root location."
 msgstr ""
 
-#: rhodecode/model/validators.py:728
+#: rhodecode/model/validators.py:748
 msgid "This username or user group name is not valid"
 msgstr ""
 
-#: rhodecode/model/validators.py:846
+#: rhodecode/model/validators.py:879
 msgid "This is not a valid path"
 msgstr ""
 
-#: rhodecode/model/validators.py:861
+#: rhodecode/model/validators.py:894
 msgid "This e-mail address is already taken"
 msgstr ""
 
-#: rhodecode/model/validators.py:881
+#: rhodecode/model/validators.py:914
 #, python-format
 msgid "e-mail \"%(email)s\" does not exist."
 msgstr ""
 
-#: rhodecode/model/validators.py:902
+#: rhodecode/model/validators.py:935
 #, python-format
 msgid "Revisions %(revs)s are already part of pull request or have set status"
 msgstr ""
 
-#: rhodecode/model/validators.py:933
-#: rhodecode/model/validation_schema/validators.py:16
-#: rhodecode/model/validation_schema/validators.py:29
+#: rhodecode/model/validators.py:966
+#: rhodecode/model/validation_schema/validators.py:40
+#: rhodecode/model/validation_schema/validators.py:53
 msgid "Please enter a valid IPv4 or IpV6 address"
 msgstr ""
 
-#: rhodecode/model/validators.py:934
+#: rhodecode/model/validators.py:967
 #, python-format
 msgid "The network size (bits) must be within the range of 0-32 (not %(bits)r)"
 msgstr ""
 
-#: rhodecode/model/validators.py:961
+#: rhodecode/model/validators.py:994
 msgid "Key name can only consist of letters, underscore, dash or numbers"
 msgstr ""
 
-#: rhodecode/model/validators.py:976
+#: rhodecode/model/validators.py:1009
 #, python-format
 msgid "Plugins %(loaded)s and %(next_to_load)s both export the same name"
 msgstr ""
 
-#: rhodecode/model/validators.py:979
+#: rhodecode/model/validators.py:1012
 #, python-format
 msgid "The plugin \"%(plugin_id)s\" is missing an includeme function."
 msgstr ""
 
-#: rhodecode/model/validators.py:982
+#: rhodecode/model/validators.py:1015
 #, python-format
 msgid "Can not load plugin \"%(plugin_id)s\""
 msgstr ""
 
-#: rhodecode/model/validators.py:984
+#: rhodecode/model/validators.py:1017
 #, python-format
 msgid "No plugin available with ID \"%(plugin_id)s\""
 msgstr ""
 
-#: rhodecode/model/validation_schema/validators.py:37
+#: rhodecode/model/validation_schema/validators.py:61
 msgid "Invalid glob pattern"
 msgstr ""
 
-#: rhodecode/model/validation_schema/validators.py:46
+#: rhodecode/model/validation_schema/validators.py:70
 msgid "Name must start with a letter or number. Got `{}`"
 msgstr ""
 
+#: rhodecode/model/validation_schema/validators.py:132
+msgid "Invalid clone url, provide a valid clone url starting with one of {allowed_prefixes}"
+msgstr ""
+
+#: rhodecode/model/validation_schema/validators.py:138
+msgid "invalid clone url for {repo_type} repository"
+msgstr ""
+
 #: rhodecode/model/validation_schema/schemas/comment_schema.py:42
 #: rhodecode/model/validation_schema/schemas/gist_schema.py:89
 msgid "Gist with name {} already exists"
@@ -3831,253 +3863,261 b' msgid "Repo group owner with id `{}` doe'
 msgstr ""
 
 #: rhodecode/model/validation_schema/schemas/repo_group_schema.py:130
-#: rhodecode/model/validation_schema/schemas/repo_schema.py:181
+#: rhodecode/model/validation_schema/schemas/repo_schema.py:204
 msgid "Repository with name `{}` already exists"
 msgstr ""
 
 #: rhodecode/model/validation_schema/schemas/repo_group_schema.py:135
-#: rhodecode/model/validation_schema/schemas/repo_schema.py:186
+#: rhodecode/model/validation_schema/schemas/repo_schema.py:209
 msgid "Repository group with name `{}` already exists"
 msgstr ""
 
-#: rhodecode/model/validation_schema/schemas/repo_schema.py:48
+#: rhodecode/model/validation_schema/schemas/repo_schema.py:55
 msgid "Repo owner with id `{}` does not exists"
 msgstr ""
 
-#: rhodecode/model/validation_schema/schemas/repo_schema.py:68
+#: rhodecode/model/validation_schema/schemas/repo_schema.py:91
 msgid "Fork with id `{}` does not exists"
 msgstr ""
 
-#: rhodecode/model/validation_schema/schemas/repo_schema.py:71
+#: rhodecode/model/validation_schema/schemas/repo_schema.py:94
 msgid "Cannot set fork of parameter of this repository to itself"
 msgstr ""
 
-#: rhodecode/model/validation_schema/schemas/repo_schema.py:96
-#: rhodecode/model/validation_schema/schemas/repo_schema.py:100
+#: rhodecode/model/validation_schema/schemas/repo_schema.py:119
+#: rhodecode/model/validation_schema/schemas/repo_schema.py:123
 msgid "Repository group `{}` does not exist"
 msgstr ""
 
-#: rhodecode/model/validation_schema/schemas/user_schema.py:36
+#: rhodecode/model/validation_schema/schemas/user_group_schema.py:32
+msgid "Allowed in name are letters, numbers, and `-`, `_`, `.` Name must start with a letter or number. Got `{}`"
+msgstr ""
+
+#: rhodecode/model/validation_schema/schemas/user_group_schema.py:48
+msgid "User group owner with id `{}` does not exists"
+msgstr ""
+
+#: rhodecode/model/validation_schema/schemas/user_schema.py:38
 msgid "Password is incorrect"
 msgstr ""
 
-#: rhodecode/model/validation_schema/schemas/user_schema.py:59
+#: rhodecode/model/validation_schema/schemas/user_schema.py:60
 msgid "New password must be different to old password"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:31663
 #: rhodecode/public/js/scripts.js:23511
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:23
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:29
 #: rhodecode/public/js/src/plugins/jquery.autocomplete.js:87
 msgid "No results"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:33594
 #: rhodecode/public/js/scripts.js:25442
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:88
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:97
 #: rhodecode/public/js/src/plugins/jquery.timeago-extension.js:109
 msgid "{0} year"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:33595
 #: rhodecode/public/js/scripts.js:25443
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:83
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:92
 #: rhodecode/public/js/src/plugins/jquery.timeago-extension.js:110
 msgid "{0} month"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:33596
 #: rhodecode/public/js/scripts.js:25444
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:78
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:87
 #: rhodecode/public/js/src/plugins/jquery.timeago-extension.js:111
 msgid "{0} day"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:33597
 #: rhodecode/public/js/scripts.js:25445
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:80
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:89
 #: rhodecode/public/js/src/plugins/jquery.timeago-extension.js:112
 msgid "{0} hour"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:33598
 #: rhodecode/public/js/scripts.js:25446
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:82
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:91
 #: rhodecode/public/js/src/plugins/jquery.timeago-extension.js:113
 msgid "{0} min"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:33599
 #: rhodecode/public/js/scripts.js:25447
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:87
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:96
 #: rhodecode/public/js/src/plugins/jquery.timeago-extension.js:114
 msgid "{0} sec"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:33619
 #: rhodecode/public/js/scripts.js:25467
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:63
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:71
 #: rhodecode/public/js/src/plugins/jquery.timeago-extension.js:134
 msgid "in {0}"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:33627
 #: rhodecode/public/js/scripts.js:25475
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:75
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:84
 #: rhodecode/public/js/src/plugins/jquery.timeago-extension.js:142
 msgid "{0} ago"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:33639
 #: rhodecode/public/js/scripts.js:25487
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:90
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:99
 #: rhodecode/public/js/src/plugins/jquery.timeago-extension.js:154
 msgid "{0}, {1} ago"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:33641
 #: rhodecode/public/js/scripts.js:25489
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:65
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:73
 #: rhodecode/public/js/src/plugins/jquery.timeago-extension.js:156
 msgid "in {0}, {1}"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:33645
 #: rhodecode/public/js/scripts.js:25493
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:76
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:85
 #: rhodecode/public/js/src/plugins/jquery.timeago-extension.js:160
 msgid "{0} and {1}"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:33647
 #: rhodecode/public/js/scripts.js:25495
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:77
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:86
 #: rhodecode/public/js/src/plugins/jquery.timeago-extension.js:162
 msgid "{0} and {1} ago"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:33649
 #: rhodecode/public/js/scripts.js:25497
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:64
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:72
 #: rhodecode/public/js/src/plugins/jquery.timeago-extension.js:164
 msgid "in {0} and {1}"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:47492
 #: rhodecode/public/js/scripts.js:39340
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:14
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:20
 #: rhodecode/public/js/rhodecode/i18n/select2/translations.js:4
 msgid "Loading more results..."
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:47495
 #: rhodecode/public/js/scripts.js:39343
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:36
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:43
 #: rhodecode/public/js/rhodecode/i18n/select2/translations.js:7
 msgid "Searching..."
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:47498
 #: rhodecode/public/js/scripts.js:39346
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:18
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:24
 #: rhodecode/public/js/rhodecode/i18n/select2/translations.js:10
 msgid "No matches found"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:47501
 #: rhodecode/public/js/scripts.js:39349
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:13
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:19
 #: rhodecode/public/js/rhodecode/i18n/select2/translations.js:13
 msgid "Loading failed"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:47505
 #: rhodecode/public/js/scripts.js:39353
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:28
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:34
 #: rhodecode/public/js/rhodecode/i18n/select2/translations.js:17
 msgid "One result is available, press enter to select it."
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:47507
 #: rhodecode/public/js/scripts.js:39355
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:86
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:95
 #: rhodecode/public/js/rhodecode/i18n/select2/translations.js:19
 msgid "{0} results are available, use up and down arrow keys to navigate."
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:47512
 #: rhodecode/public/js/scripts.js:39360
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:33
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:39
 #: rhodecode/public/js/rhodecode/i18n/select2/translations.js:24
 msgid "Please enter {0} or more character"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:47514
 #: rhodecode/public/js/scripts.js:39362
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:34
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:40
 #: rhodecode/public/js/rhodecode/i18n/select2/translations.js:26
 msgid "Please enter {0} or more characters"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:47519
 #: rhodecode/public/js/scripts.js:39367
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:31
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:37
 #: rhodecode/public/js/rhodecode/i18n/select2/translations.js:31
 msgid "Please delete {0} character"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:47521
 #: rhodecode/public/js/scripts.js:39369
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:32
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:38
 #: rhodecode/public/js/rhodecode/i18n/select2/translations.js:33
 msgid "Please delete {0} characters"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:47525
 #: rhodecode/public/js/scripts.js:39373
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:56
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:64
 #: rhodecode/public/js/rhodecode/i18n/select2/translations.js:37
 msgid "You can only select {0} item"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:47527
 #: rhodecode/public/js/scripts.js:39375
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:57
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:65
 #: rhodecode/public/js/rhodecode/i18n/select2/translations.js:39
 msgid "You can only select {0} items"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:48456
 #: rhodecode/public/js/scripts.js:40304
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:69
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:78
 #: rhodecode/public/js/src/rhodecode/changelog.js:35
 msgid "showing {0} out of {1} commit"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:48458
 #: rhodecode/public/js/scripts.js:40306
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:70
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:79
 #: rhodecode/public/js/src/rhodecode/changelog.js:37
 msgid "showing {0} out of {1} commits"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:48891
 #: rhodecode/public/js/scripts.js:40739
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:39
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:46
 #: rhodecode/public/js/src/rhodecode/codemirror.js:296
 msgid "Set status to Approved"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:48910
 #: rhodecode/public/js/scripts.js:40758
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:40
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:47
 #: rhodecode/public/js/src/rhodecode/codemirror.js:315
 msgid "Set status to Rejected"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:48929
 #: rhodecode/public/js/scripts.js:40777
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:51
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:58
 #: rhodecode/public/js/src/rhodecode/codemirror.js:334
 #: rhodecode/templates/email_templates/commit_comment.mako:99
 #: rhodecode/templates/email_templates/pull_request_comment.mako:107
@@ -4086,42 +4126,42 b' msgstr ""'
 
 #: rhodecode/public/js/rhodecode-components.js:48949
 #: rhodecode/public/js/scripts.js:40797
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:27
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:33
 #: rhodecode/public/js/src/rhodecode/codemirror.js:354
 msgid "Note Comment"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:49315
 #: rhodecode/public/js/scripts.js:41163
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:68
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:77
 #: rhodecode/public/js/src/rhodecode/comments.js:125
 msgid "resolve comment"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:49399
 #: rhodecode/public/js/scripts.js:41247
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:46
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:53
 #: rhodecode/public/js/src/rhodecode/comments.js:209
 msgid "Status Review"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:49414
 #: rhodecode/public/js/scripts.js:41262
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:5
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:10
 #: rhodecode/public/js/src/rhodecode/comments.js:224
 msgid "Comment text will be set automatically based on currently selected status ({0}) ..."
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:49571
 #: rhodecode/public/js/scripts.js:41419
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:48
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:55
 #: rhodecode/public/js/src/rhodecode/comments.js:381
 msgid "Submitting..."
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:49622
 #: rhodecode/public/js/scripts.js:41470
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:12
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:18
 #: rhodecode/public/js/src/rhodecode/comments.js:432
 #: rhodecode/templates/files/files_browser_tree.mako:51
 msgid "Loading ..."
@@ -4129,105 +4169,170 b' msgstr ""'
 
 #: rhodecode/public/js/rhodecode-components.js:49727
 #: rhodecode/public/js/scripts.js:41575
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:6
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:12
 #: rhodecode/public/js/src/rhodecode/comments.js:537
 msgid "Delete this comment?"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:49798
 #: rhodecode/public/js/scripts.js:41646
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:11
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:17
 #: rhodecode/public/js/src/rhodecode/comments.js:608
 msgid "Leave a comment, or click resolve button to resolve TODO comment #{0}"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:49875
 #: rhodecode/public/js/scripts.js:41723
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:10
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:16
 #: rhodecode/public/js/src/rhodecode/comments.js:685
 msgid "Leave a comment on line {0}."
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:49989
 #: rhodecode/public/js/scripts.js:41837
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:52
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:59
 #: rhodecode/public/js/src/rhodecode/comments.js:799
 msgid "TODO from comment {0} was fixed."
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:50195
 #: rhodecode/public/js/scripts.js:42043
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:72
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:81
 #: rhodecode/public/js/src/rhodecode/files.js:150
 msgid "truncated result"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:50197
 #: rhodecode/public/js/scripts.js:42045
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:73
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:82
 #: rhodecode/public/js/src/rhodecode/files.js:152
 msgid "truncated results"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:50206
 #: rhodecode/public/js/scripts.js:42054
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:19
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:25
 #: rhodecode/public/js/src/rhodecode/files.js:161
 msgid "No matching files"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:50341
 #: rhodecode/public/js/scripts.js:42189
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:37
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:44
 #: rhodecode/public/js/src/rhodecode/files.js:296
 msgid "Selection link"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:50381
 #: rhodecode/public/js/scripts.js:42229
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:47
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:54
 #: rhodecode/public/js/src/rhodecode/followers.js:26
 msgid "Stop following this repository"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:50382
 #: rhodecode/public/js/scripts.js:42230
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:54
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:61
 #: rhodecode/public/js/src/rhodecode/followers.js:27
 msgid "Unfollow"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:50391
 #: rhodecode/public/js/scripts.js:42239
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:45
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:52
 #: rhodecode/public/js/src/rhodecode/followers.js:36
 msgid "Start following this repository"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode-components.js:50392
 #: rhodecode/public/js/scripts.js:42240
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:8
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:14
 #: rhodecode/public/js/src/rhodecode/followers.js:37
 msgid "Follow"
 msgstr ""
 
-#: rhodecode/public/js/rhodecode-components.js:50849
-#: rhodecode/public/js/scripts.js:42697
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:58
-#: rhodecode/public/js/src/rhodecode/pullrequests.js:213
+#: rhodecode/public/js/rhodecode-components.js:50770
+#: rhodecode/public/js/rhodecode-components.js:50779
+#: rhodecode/public/js/scripts.js:42618 rhodecode/public/js/scripts.js:42627
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:5
+#: rhodecode/public/js/src/rhodecode/pullrequests.js:134
+#: rhodecode/public/js/src/rhodecode/pullrequests.js:143
+msgid "All reviewers must vote."
+msgstr ""
+
+#: rhodecode/public/js/rhodecode-components.js:50784
+#: rhodecode/public/js/scripts.js:42632
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:6
+#: rhodecode/public/js/src/rhodecode/pullrequests.js:148
+msgid "At least {0} reviewer must vote."
+msgstr ""
+
+#: rhodecode/public/js/rhodecode-components.js:50790
+#: rhodecode/public/js/scripts.js:42638
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:7
+#: rhodecode/public/js/src/rhodecode/pullrequests.js:154
+msgid "At least {0} reviewers must vote."
+msgstr ""
+
+#: rhodecode/public/js/rhodecode-components.js:50797
+#: rhodecode/public/js/scripts.js:42645
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:41
+#: rhodecode/public/js/src/rhodecode/pullrequests.js:161
+msgid "Reviewers picked from source code changes."
+msgstr ""
+
+#: rhodecode/public/js/rhodecode-components.js:50804
+#: rhodecode/public/js/scripts.js:42652
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:4
+#: rhodecode/public/js/src/rhodecode/pullrequests.js:168
+msgid "Adding new reviewers is forbidden."
+msgstr ""
+
+#: rhodecode/public/js/rhodecode-components.js:50811
+#: rhodecode/public/js/scripts.js:42659
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:8
+#: rhodecode/public/js/src/rhodecode/pullrequests.js:175
+msgid "Author is not allowed to be a reviewer."
+msgstr ""
+
+#: rhodecode/public/js/rhodecode-components.js:50825
+#: rhodecode/public/js/scripts.js:42673
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:11
+#: rhodecode/public/js/src/rhodecode/pullrequests.js:189
+msgid "Commit Authors are not allowed to be a reviewer."
+msgstr ""
+
+#: rhodecode/public/js/rhodecode-components.js:50972
+#: rhodecode/public/js/scripts.js:42820
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:63
+#: rhodecode/public/js/src/rhodecode/pullrequests.js:336
+msgid "User `{0}` not allowed to be a reviewer"
+msgstr ""
+
+#: rhodecode/public/js/rhodecode-components.js:51099
+#: rhodecode/public/js/scripts.js:42947
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:66
+#: rhodecode/public/js/src/rhodecode/pullrequests.js:463
 msgid "added manually by \"{0}\""
 msgstr ""
 
-#: rhodecode/public/js/rhodecode-components.js:51420
-#: rhodecode/public/js/scripts.js:43268
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:61
+#: rhodecode/public/js/rhodecode-components.js:51101
+#: rhodecode/public/js/scripts.js:42949
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:76
+#: rhodecode/public/js/src/rhodecode/pullrequests.js:465
+msgid "member of \"{0}\""
+msgstr ""
+
+#: rhodecode/public/js/rhodecode-components.js:51682
+#: rhodecode/public/js/scripts.js:43530
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:69
 #: rhodecode/public/js/src/rhodecode.js:142
 msgid "file"
 msgstr ""
 
-#: rhodecode/public/js/rhodecode-components.js:51440
-#: rhodecode/public/js/scripts.js:43288
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:42
+#: rhodecode/public/js/rhodecode-components.js:51702
+#: rhodecode/public/js/scripts.js:43550
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:49
 #: rhodecode/public/js/src/rhodecode.js:162
 msgid "Show more"
 msgstr ""
@@ -4242,150 +4347,150 b' msgstr ""'
 msgid "Add another comment"
 msgstr ""
 
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:4
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:9
 #: rhodecode/public/js/src/i18n_messages.js:5
 #: rhodecode/templates/pullrequests/pullrequest_show.mako:325
 msgid "Close"
 msgstr ""
 
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:7
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:13
 msgid "Diff to Commit "
 msgstr ""
 
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:9
-#: rhodecode/public/js/src/i18n_messages.js:4
-msgid "Invite reviewers to this discussion"
-msgstr ""
-
 #: rhodecode/public/js/rhodecode/i18n/js_translations.js:15
-msgid "No bookmarks available yet."
-msgstr ""
-
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:16
-msgid "No branches available yet."
-msgstr ""
-
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:17
-msgid "No gists available yet."
-msgstr ""
-
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:20
-msgid "No pull requests available yet."
+#: rhodecode/public/js/src/i18n_messages.js:4
+msgid "Invite reviewers to this discussion"
 msgstr ""
 
 #: rhodecode/public/js/rhodecode/i18n/js_translations.js:21
-msgid "No repositories available yet."
+msgid "No bookmarks available yet."
 msgstr ""
 
 #: rhodecode/public/js/rhodecode/i18n/js_translations.js:22
-msgid "No repository groups available yet."
-msgstr ""
-
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:24
-msgid "No tags available yet."
-msgstr ""
-
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:25
-msgid "No user groups available yet."
+msgid "No branches available yet."
+msgstr ""
+
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:23
+msgid "No gists available yet."
 msgstr ""
 
 #: rhodecode/public/js/rhodecode/i18n/js_translations.js:26
-msgid "No users available yet."
-msgstr ""
-
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:29
-#: rhodecode/templates/changelog/changelog.mako:61
-msgid "Open new pull request"
+msgid "No pull requests available yet."
+msgstr ""
+
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:27
+msgid "No repositories available yet."
+msgstr ""
+
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:28
+msgid "No repository groups available yet."
 msgstr ""
 
 #: rhodecode/public/js/rhodecode/i18n/js_translations.js:30
-msgid "Open new pull request for selected commit"
+msgid "No tags available yet."
+msgstr ""
+
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:31
+msgid "No user groups available yet."
+msgstr ""
+
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:32
+msgid "No users available yet."
 msgstr ""
 
 #: rhodecode/public/js/rhodecode/i18n/js_translations.js:35
+#: rhodecode/templates/changelog/changelog.mako:61
+msgid "Open new pull request"
+msgstr ""
+
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:36
+msgid "Open new pull request for selected commit"
+msgstr ""
+
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:42
 msgid "Saving..."
 msgstr ""
 
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:38
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:45
 #: rhodecode/public/js/src/i18n_messages.js:6
 #: rhodecode/templates/admin/settings/settings_email.mako:48
 msgid "Send"
 msgstr ""
 
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:41
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:48
 msgid "Show at Commit "
 msgstr ""
 
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:43
-msgid "Show selected commit __S"
-msgstr ""
-
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:44
-msgid "Show selected commits __S ... __E"
-msgstr ""
-
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:49
-#: rhodecode/public/js/src/i18n_messages.js:7
-msgid "Switch to chat"
-msgstr ""
-
 #: rhodecode/public/js/rhodecode/i18n/js_translations.js:50
+msgid "Show selected commit __S"
+msgstr ""
+
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:51
+msgid "Show selected commits __S ... __E"
+msgstr ""
+
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:56
+#: rhodecode/public/js/src/i18n_messages.js:7
+msgid "Switch to chat"
+msgstr ""
+
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:57
 #: rhodecode/public/js/src/i18n_messages.js:8
 msgid "Switch to comment"
 msgstr ""
 
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:53
-msgid "There are currently no open pull requests requiring your participation."
-msgstr ""
-
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:55
-msgid "Updating..."
-msgstr ""
-
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:59
-#: rhodecode/templates/admin/auth/auth_settings.mako:71
-msgid "disabled"
-msgstr ""
-
 #: rhodecode/public/js/rhodecode/i18n/js_translations.js:60
-#: rhodecode/templates/admin/auth/auth_settings.mako:71
-msgid "enabled"
+msgid "There are currently no open pull requests requiring your participation."
 msgstr ""
 
 #: rhodecode/public/js/rhodecode/i18n/js_translations.js:62
-msgid "files"
+msgid "Updating..."
 msgstr ""
 
 #: rhodecode/public/js/rhodecode/i18n/js_translations.js:67
-#: rhodecode/templates/pullrequests/pullrequest.mako:108
+#: rhodecode/templates/admin/auth/auth_settings.mako:71
+msgid "disabled"
+msgstr ""
+
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:68
+#: rhodecode/templates/admin/auth/auth_settings.mako:71
+msgid "enabled"
+msgstr ""
+
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:70
+msgid "files"
+msgstr ""
+
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:75
+#: rhodecode/templates/pullrequests/pullrequest.mako:140
 msgid "loading..."
 msgstr ""
 
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:71
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:80
 msgid "specify commit"
 msgstr ""
 
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:74
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:83
 msgid "{0} active out of {1} users"
 msgstr ""
 
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:79
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:88
 msgid "{0} days"
 msgstr ""
 
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:81
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:90
 msgid "{0} hours"
 msgstr ""
 
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:84
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:93
 msgid "{0} months"
 msgstr ""
 
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:85
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:94
 msgid "{0} out of {1} users"
 msgstr ""
 
-#: rhodecode/public/js/rhodecode/i18n/js_translations.js:89
+#: rhodecode/public/js/rhodecode/i18n/js_translations.js:98
 msgid "{0} years"
 msgstr ""
 
@@ -4467,7 +4572,7 b' msgstr ""'
 #: rhodecode/templates/admin/my_account/my_account_watched.mako:31
 #: rhodecode/templates/admin/repo_groups/repo_groups.mako:53
 #: rhodecode/templates/admin/repos/repo_add_base.mako:9
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:15
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:16
 #: rhodecode/templates/admin/repos/repos.mako:54
 #: rhodecode/templates/admin/user_groups/user_groups.mako:55
 #: rhodecode/templates/admin/users/user_edit_groups.mako:54
@@ -4475,7 +4580,7 b' msgstr ""'
 #: rhodecode/templates/bookmarks/bookmarks.mako:59
 #: rhodecode/templates/branches/branches.mako:58
 #: rhodecode/templates/files/files_browser_tree.mako:5
-#: rhodecode/templates/pullrequests/pullrequests.mako:100
+#: rhodecode/templates/pullrequests/pullrequests.mako:110
 #: rhodecode/templates/tags/tags.mako:59
 msgid "Name"
 msgstr ""
@@ -4490,7 +4595,7 b' msgstr ""'
 #: rhodecode/templates/admin/repo_groups/repo_groups.mako:56
 #: rhodecode/templates/admin/repos/repo_add_base.mako:43
 #: rhodecode/templates/admin/repos/repo_edit_issuetracker.mako:29
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:98
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:127
 #: rhodecode/templates/admin/repos/repos.mako:57
 #: rhodecode/templates/admin/user_groups/user_group_add.mako:43
 #: rhodecode/templates/admin/user_groups/user_group_edit_settings.mako:42
@@ -4498,9 +4603,10 b' msgstr ""'
 #: rhodecode/templates/admin/users/user_edit_auth_tokens.mako:15
 #: rhodecode/templates/admin/users/user_edit_auth_tokens.mako:67
 #: rhodecode/templates/admin/users/user_edit_groups.mako:59
+#: rhodecode/templates/admin/users/user_edit_ips.mako:12
 #: rhodecode/templates/base/issue_tracker_settings.mako:10
-#: rhodecode/templates/changeset/changeset.mako:53
-#: rhodecode/templates/compare/compare_commits.mako:20
+#: rhodecode/templates/changeset/changeset.mako:73
+#: rhodecode/templates/compare/compare_commits.mako:21
 #: rhodecode/templates/email_templates/commit_comment.mako:89
 #: rhodecode/templates/email_templates/pull_request_review.mako:41
 #: rhodecode/templates/email_templates/pull_request_review.mako:75
@@ -4508,9 +4614,9 b' msgstr ""'
 #: rhodecode/templates/files/file_tree_detail.mako:12
 #: rhodecode/templates/forks/fork.mako:48
 #: rhodecode/templates/forks/forks_data.mako:9
-#: rhodecode/templates/pullrequests/pullrequest.mako:47
+#: rhodecode/templates/pullrequests/pullrequest.mako:54
 #: rhodecode/templates/pullrequests/pullrequest_show.mako:163
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:460
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:487
 #: rhodecode/templates/summary/components.mako:73
 msgid "Description"
 msgstr ""
@@ -4521,7 +4627,7 b' msgstr ""'
 #: rhodecode/templates/admin/repo_groups/repo_group_edit_settings.mako:24
 #: rhodecode/templates/admin/repo_groups/repo_groups.mako:60
 #: rhodecode/templates/admin/repos/repo_edit_advanced.mako:5
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:80
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:109
 #: rhodecode/templates/admin/repos/repos.mako:65
 #: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:5
 #: rhodecode/templates/admin/user_groups/user_group_edit_settings.mako:24
@@ -4544,13 +4650,13 b' msgstr ""'
 #: rhodecode/templates/bookmarks/bookmarks.mako:66
 #: rhodecode/templates/branches/branches.mako:65
 #: rhodecode/templates/changelog/changelog.mako:107
-#: rhodecode/templates/changelog/changelog_summary_data.mako:8
 #: rhodecode/templates/changeset/changeset.mako:36
-#: rhodecode/templates/compare/compare_commits.mako:18
+#: rhodecode/templates/compare/compare_commits.mako:19
 #: rhodecode/templates/email_templates/commit_comment.mako:49
 #: rhodecode/templates/email_templates/commit_comment.mako:88
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:458
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:485
 #: rhodecode/templates/search/search_commit.mako:6
+#: rhodecode/templates/summary/summary_commits.mako:8
 #: rhodecode/templates/tags/tags.mako:66
 msgid "Commit"
 msgstr ""
@@ -4565,7 +4671,7 b' msgid "Home"'
 msgstr ""
 
 #: rhodecode/templates/login.mako:5 rhodecode/templates/login.mako:35
-#: rhodecode/templates/login.mako:75 rhodecode/templates/base/base.mako:329
+#: rhodecode/templates/login.mako:75 rhodecode/templates/base/base.mako:332
 #: rhodecode/templates/debug_style/login.html:60
 msgid "Sign In"
 msgstr ""
@@ -4588,13 +4694,13 b' msgstr ""'
 
 #: rhodecode/templates/login.mako:68 rhodecode/templates/password_reset.mako:37
 #: rhodecode/templates/base/base.mako:46
-#: rhodecode/templates/errors/error_document.mako:64
+#: rhodecode/templates/errors/error_document.mako:63
 msgid "Support"
 msgstr ""
 
 #: rhodecode/templates/login.mako:69 rhodecode/templates/password_reset.mako:38
 #: rhodecode/templates/files/files_add.mako:54
-#: rhodecode/templates/files/files_add.mako:65
+#: rhodecode/templates/files/files_add.mako:71
 msgid "or"
 msgstr ""
 
@@ -4653,7 +4759,7 b' msgstr ""'
 #: rhodecode/templates/admin/my_account/my_account_profile_edit.mako:79
 #: rhodecode/templates/admin/users/user_add.mako:68
 #: rhodecode/templates/admin/users/user_edit_profile.mako:47
-#: rhodecode/templates/admin/users/users.mako:66
+#: rhodecode/templates/admin/users/users.mako:67
 msgid "First Name"
 msgstr ""
 
@@ -4663,7 +4769,7 b' msgstr ""'
 #: rhodecode/templates/admin/my_account/my_account_profile_edit.mako:88
 #: rhodecode/templates/admin/users/user_add.mako:77
 #: rhodecode/templates/admin/users/user_edit_profile.mako:56
-#: rhodecode/templates/admin/users/users.mako:68
+#: rhodecode/templates/admin/users/users.mako:69
 msgid "Last Name"
 msgstr ""
 
@@ -4675,36 +4781,32 b' msgstr ""'
 msgid "Create Account"
 msgstr ""
 
-#: rhodecode/templates/admin/admin.mako:5
-#: rhodecode/templates/admin/admin.mako:15
+#: rhodecode/templates/admin/admin_audit_logs.mako:5
 #: rhodecode/templates/base/base.mako:75
-msgid "Admin journal"
-msgstr ""
-
-#: rhodecode/templates/admin/admin.mako:13
-msgid "journal filter..."
-msgstr ""
-
-#: rhodecode/templates/admin/admin.mako:14
+msgid "Admin audit logs"
+msgstr ""
+
+#: rhodecode/templates/admin/admin_audit_logs.mako:13
+msgid "filter..."
+msgstr ""
+
+#: rhodecode/templates/admin/admin_audit_logs.mako:14
 #: rhodecode/templates/admin/users/user_edit_audit.mako:15
 msgid "filter"
 msgstr ""
 
-#: rhodecode/templates/admin/admin.mako:15
-#: rhodecode/templates/journal/journal.mako:14
-#, python-format
-msgid "%s entry"
-msgid_plural "%s entries"
-msgstr[0] ""
-msgstr[1] ""
-
-#: rhodecode/templates/admin/admin.mako:17
+#: rhodecode/templates/admin/admin_audit_logs.mako:15
+msgid "Audit logs"
+msgstr ""
+
+#: rhodecode/templates/admin/admin_audit_logs.mako:17
 #: rhodecode/templates/admin/users/user_edit_audit.mako:17
 #: rhodecode/templates/journal/journal.mako:17
+#: rhodecode/templates/search/search.mako:76
 msgid "Example Queries"
 msgstr ""
 
-#: rhodecode/templates/admin/admin_log.mako:8
+#: rhodecode/templates/admin/admin_log_base.mako:7
 #: rhodecode/templates/admin/my_account/my_account_auth_tokens.mako:18
 #: rhodecode/templates/admin/my_account/my_account_repos.mako:37
 #: rhodecode/templates/admin/repo_groups/repo_groups.mako:62
@@ -4712,38 +4814,45 b' msgstr ""'
 #: rhodecode/templates/admin/repos/repos.mako:69
 #: rhodecode/templates/admin/user_groups/user_group_edit_settings.mako:71
 #: rhodecode/templates/admin/user_groups/user_groups.mako:68
-#: rhodecode/templates/admin/users/user_edit_audit.mako:23
 #: rhodecode/templates/admin/users/user_edit_auth_tokens.mako:18
 #: rhodecode/templates/admin/users/user_edit_groups.mako:73
-#: rhodecode/templates/admin/users/users.mako:79
+#: rhodecode/templates/admin/users/users.mako:80
 #: rhodecode/templates/files/files_detail.mako:58
 msgid "Action"
 msgstr ""
 
-#: rhodecode/templates/admin/admin_log.mako:9
+#: rhodecode/templates/admin/admin_log_base.mako:8
+msgid "Action Data"
+msgstr ""
+
+#: rhodecode/templates/admin/admin_log_base.mako:9
 #: rhodecode/templates/admin/defaults/defaults.mako:31
 #: rhodecode/templates/admin/permissions/permissions_objects.mako:13
-#: rhodecode/templates/admin/users/user_edit_audit.mako:24
 #: rhodecode/templates/search/search_commit.mako:5
 #: rhodecode/templates/search/search_path.mako:3
 msgid "Repository"
 msgstr ""
 
-#: rhodecode/templates/admin/admin_log.mako:10
-#: rhodecode/templates/admin/users/user_edit_audit.mako:25
+#: rhodecode/templates/admin/admin_log_base.mako:10
 #: rhodecode/templates/bookmarks/bookmarks.mako:61
 #: rhodecode/templates/branches/branches.mako:60
 #: rhodecode/templates/tags/tags.mako:61
 msgid "Date"
 msgstr ""
 
-#: rhodecode/templates/admin/admin_log.mako:11
-#: rhodecode/templates/admin/users/user_edit_audit.mako:26
-msgid "From IP"
-msgstr ""
-
-#: rhodecode/templates/admin/admin_log.mako:46
-#: rhodecode/templates/admin/users/user_edit_audit.mako:61
+#: rhodecode/templates/admin/admin_log_base.mako:11
+msgid "IP"
+msgstr ""
+
+#: rhodecode/templates/admin/admin_log_base.mako:38
+msgid "toggle"
+msgstr ""
+
+#: rhodecode/templates/admin/admin_log_base.mako:43
+msgid "data not available for v1 entries type"
+msgstr ""
+
+#: rhodecode/templates/admin/admin_log_base.mako:64
 msgid "No actions yet"
 msgstr ""
 
@@ -4784,8 +4893,8 b' msgstr ""'
 #: rhodecode/templates/admin/repo_groups/repo_group_edit_settings.mako:67
 #: rhodecode/templates/admin/repos/repo_add_base.mako:101
 #: rhodecode/templates/admin/repos/repo_edit_issuetracker.mako:79
-#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:110
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:160
+#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:109
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:194
 #: rhodecode/templates/admin/settings/settings_hooks.mako:63
 #: rhodecode/templates/admin/settings/settings_issuetracker.mako:15
 #: rhodecode/templates/admin/user_groups/user_group_add.mako:60
@@ -4826,7 +4935,7 b' msgstr ""'
 
 #: rhodecode/templates/admin/defaults/defaults_repositories.mako:27
 #: rhodecode/templates/admin/repos/repo_add_base.mako:97
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:112
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:143
 #: rhodecode/templates/forks/fork.mako:87
 msgid "Private repositories are only visible to people explicitly added as collaborators."
 msgstr ""
@@ -4877,7 +4986,7 b' msgstr ""'
 
 #: rhodecode/templates/admin/gists/edit.mako:56
 #: rhodecode/templates/admin/gists/new.mako:50
-#: rhodecode/templates/files/files_add.mako:74
+#: rhodecode/templates/files/files_add.mako:80
 #: rhodecode/templates/files/files_edit.mako:78
 msgid "plain"
 msgstr ""
@@ -4888,9 +4997,9 b' msgstr ""'
 
 #: rhodecode/templates/admin/gists/edit.mako:102
 #: rhodecode/templates/base/issue_tracker_settings.mako:73
-#: rhodecode/templates/changeset/changeset_file_comment.mako:385
+#: rhodecode/templates/changeset/changeset_file_comment.mako:390
 #: rhodecode/templates/codeblocks/diffs.mako:76
-#: rhodecode/templates/files/files_add.mako:102
+#: rhodecode/templates/files/files_add.mako:108
 #: rhodecode/templates/files/files_delete.mako:69
 #: rhodecode/templates/files/files_edit.mako:105
 #: rhodecode/templates/pullrequests/pullrequest_show.mako:64
@@ -4957,14 +5066,13 b' msgstr ""'
 #: rhodecode/templates/bookmarks/bookmarks.mako:63
 #: rhodecode/templates/branches/branches.mako:62
 #: rhodecode/templates/changelog/changelog.mako:113
-#: rhodecode/templates/changelog/changelog_summary_data.mako:11
-#: rhodecode/templates/changeset/changeset.mako:180
-#: rhodecode/templates/compare/compare_commits.mako:17
+#: rhodecode/templates/changeset/changeset.mako:200
+#: rhodecode/templates/compare/compare_commits.mako:18
 #: rhodecode/templates/files/files_browser_tree.mako:9
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:309
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:457
-#: rhodecode/templates/pullrequests/pullrequests.mako:102
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:484
+#: rhodecode/templates/pullrequests/pullrequests.mako:112
 #: rhodecode/templates/search/search_commit.mako:16
+#: rhodecode/templates/summary/summary_commits.mako:11
 #: rhodecode/templates/tags/tags.mako:63
 msgid "Author"
 msgstr ""
@@ -5025,12 +5133,12 b' msgstr ""'
 #: rhodecode/templates/data_table/_dt_elements.mako:193
 #: rhodecode/templates/data_table/_dt_elements.mako:206
 #: rhodecode/templates/debug_style/buttons.html:128
-#: rhodecode/templates/files/files_add.mako:204
+#: rhodecode/templates/files/files_add.mako:208
 #: rhodecode/templates/files/files_edit.mako:165
 #: rhodecode/templates/files/files_source.mako:48
 #: rhodecode/templates/files/files_source.mako:51
 #: rhodecode/templates/pullrequests/pullrequest_show.mako:63
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:324
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:339
 #: rhodecode/templates/users/user_profile.mako:7
 msgid "Edit"
 msgstr ""
@@ -5071,10 +5179,10 b' msgstr ""'
 #: rhodecode/templates/admin/integrations/new.mako:21
 #: rhodecode/templates/admin/repo_groups/repo_group_edit.mako:48
 #: rhodecode/templates/admin/repos/repo_edit.mako:15
-#: rhodecode/templates/admin/repos/repo_edit.mako:43
+#: rhodecode/templates/admin/repos/repo_edit.mako:46
 #: rhodecode/templates/admin/settings/settings.mako:14
 #: rhodecode/templates/admin/user_groups/user_group_edit.mako:33
-#: rhodecode/templates/base/base.mako:84 rhodecode/templates/base/base.mako:249
+#: rhodecode/templates/base/base.mako:84 rhodecode/templates/base/base.mako:251
 msgid "Settings"
 msgstr ""
 
@@ -5177,7 +5285,7 b' msgid "No description available"'
 msgstr ""
 
 #: rhodecode/templates/admin/my_account/my_account.mako:5
-#: rhodecode/templates/base/base.mako:343
+#: rhodecode/templates/base/base.mako:346
 msgid "My account"
 msgstr ""
 
@@ -5201,7 +5309,7 b' msgid "OAuth Identities"'
 msgstr ""
 
 #: rhodecode/templates/admin/my_account/my_account.mako:37
-#: rhodecode/templates/admin/users/user_edit.mako:38
+#: rhodecode/templates/admin/users/user_edit.mako:43
 msgid "Emails"
 msgstr ""
 
@@ -5218,7 +5326,7 b' msgstr ""'
 #: rhodecode/templates/admin/my_account/my_account.mako:41
 #: rhodecode/templates/admin/permissions/permissions.mako:14
 #: rhodecode/templates/admin/repo_groups/repo_group_edit.mako:49
-#: rhodecode/templates/admin/repos/repo_edit.mako:46
+#: rhodecode/templates/admin/repos/repo_edit.mako:49
 #: rhodecode/templates/admin/user_groups/user_group_edit.mako:34
 #: rhodecode/templates/base/base.mako:80
 msgid "Permissions"
@@ -5275,7 +5383,7 b' msgstr ""'
 #: rhodecode/templates/admin/repos/repo_edit_fields.mako:65
 #: rhodecode/templates/admin/users/user_edit_auth_tokens.mako:82
 #: rhodecode/templates/admin/users/user_edit_emails.mako:62
-#: rhodecode/templates/admin/users/user_edit_ips.mako:69
+#: rhodecode/templates/admin/users/user_edit_ips.mako:70
 msgid "Add"
 msgstr ""
 
@@ -5294,9 +5402,7 b' msgid "Primary"'
 msgstr ""
 
 #: rhodecode/templates/admin/my_account/my_account_emails.mako:31
-#: rhodecode/templates/admin/users/user_edit_emails.mako:30
-#, python-format
-msgid "Confirm to delete this email: %s"
+msgid "Confirm to delete this email: {}"
 msgstr ""
 
 #: rhodecode/templates/admin/my_account/my_account_emails.mako:42
@@ -5380,13 +5486,13 b' msgstr ""'
 #: rhodecode/templates/admin/settings/settings_global.mako:9
 #: rhodecode/templates/email_templates/pull_request_review.mako:39
 #: rhodecode/templates/email_templates/pull_request_review.mako:72
-#: rhodecode/templates/pullrequests/pullrequest.mako:38
-#: rhodecode/templates/pullrequests/pullrequests.mako:104
+#: rhodecode/templates/pullrequests/pullrequest.mako:45
+#: rhodecode/templates/pullrequests/pullrequests.mako:114
 msgid "Title"
 msgstr ""
 
 #: rhodecode/templates/admin/my_account/my_account_pullrequests.mako:47
-#: rhodecode/templates/pullrequests/pullrequests.mako:108
+#: rhodecode/templates/pullrequests/pullrequests.mako:118
 msgid "Last Update"
 msgstr ""
 
@@ -5404,7 +5510,7 b' msgid "My Notifications"'
 msgstr ""
 
 #: rhodecode/templates/admin/notifications/notifications.mako:32
-#: rhodecode/templates/changeset/changeset.mako:140
+#: rhodecode/templates/changeset/changeset.mako:160
 msgid "Comments"
 msgstr ""
 
@@ -5425,6 +5531,10 b' msgstr ""'
 msgid "Notifications"
 msgstr ""
 
+#: rhodecode/templates/admin/notifications/show_notification.mako:40
+msgid "Subject"
+msgstr ""
+
 #: rhodecode/templates/admin/permissions/permissions.mako:5
 msgid "Permissions Administration"
 msgstr ""
@@ -5483,23 +5593,23 b' msgid "Default IP Whitelist For All User'
 msgstr ""
 
 #: rhodecode/templates/admin/permissions/permissions_ips.mako:27
-#: rhodecode/templates/admin/users/user_edit_ips.mako:35
+#: rhodecode/templates/admin/users/user_edit_ips.mako:36
 #, python-format
 msgid "Confirm to delete this ip: %s"
 msgstr ""
 
 #: rhodecode/templates/admin/permissions/permissions_ips.mako:34
-#: rhodecode/templates/admin/users/user_edit_ips.mako:43
+#: rhodecode/templates/admin/users/user_edit_ips.mako:44
 msgid "All IP addresses are allowed"
 msgstr ""
 
 #: rhodecode/templates/admin/permissions/permissions_ips.mako:49
-#: rhodecode/templates/admin/users/user_edit_ips.mako:59
+#: rhodecode/templates/admin/users/user_edit_ips.mako:60
 msgid "New IP Address"
 msgstr ""
 
 #: rhodecode/templates/admin/permissions/permissions_ips.mako:53
-#: rhodecode/templates/admin/users/user_edit_ips.mako:62
+#: rhodecode/templates/admin/users/user_edit_ips.mako:63
 msgid "Description..."
 msgstr ""
 
@@ -5583,9 +5693,9 b' msgid "Add Child Group"'
 msgstr ""
 
 #: rhodecode/templates/admin/repo_groups/repo_group_edit.mako:50
-#: rhodecode/templates/admin/repos/repo_edit.mako:49
+#: rhodecode/templates/admin/repos/repo_edit.mako:52
 #: rhodecode/templates/admin/user_groups/user_group_edit.mako:35
-#: rhodecode/templates/admin/users/user_edit.mako:35
+#: rhodecode/templates/admin/users/user_edit.mako:40
 msgid "Advanced"
 msgstr ""
 
@@ -5642,26 +5752,26 b' msgid "Repository Group Permissions"'
 msgstr ""
 
 #: rhodecode/templates/admin/repo_groups/repo_group_edit_perms.mako:15
-#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:16
+#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:15
 #: rhodecode/templates/admin/user_groups/user_group_edit_perms.mako:15
 msgid "User/User Group"
 msgstr ""
 
 #: rhodecode/templates/admin/repo_groups/repo_group_edit_perms.mako:31
-#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:31
+#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:30
 #: rhodecode/templates/admin/user_groups/user_group_edit_perms.mako:31
 msgid "super admin"
 msgstr ""
 
 #: rhodecode/templates/admin/repo_groups/repo_group_edit_perms.mako:34
-#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:34
+#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:33
 #: rhodecode/templates/admin/user_groups/user_group_edit_perms.mako:34
 msgid "owner"
 msgstr ""
 
 #: rhodecode/templates/admin/repo_groups/repo_group_edit_perms.mako:52
 #: rhodecode/templates/admin/repo_groups/repo_group_edit_perms.mako:76
-#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:61
+#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:60
 #: rhodecode/templates/admin/user_groups/user_group_edit_perms.mako:52
 #: rhodecode/templates/admin/user_groups/user_group_edit_perms.mako:76
 msgid "permission for all other users"
@@ -5669,8 +5779,8 b' msgstr ""'
 
 #: rhodecode/templates/admin/repo_groups/repo_group_edit_perms.mako:62
 #: rhodecode/templates/admin/repo_groups/repo_group_edit_perms.mako:109
-#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:71
-#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:99
+#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:70
+#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:98
 msgid "Revoke"
 msgstr ""
 
@@ -5680,7 +5790,7 b' msgid "delegated admin"'
 msgstr ""
 
 #: rhodecode/templates/admin/repo_groups/repo_group_edit_perms.mako:118
-#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:107
+#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:106
 #: rhodecode/templates/admin/user_groups/user_group_edit_perms.mako:117
 #: rhodecode/templates/base/issue_tracker_settings.mako:83
 msgid "Add new"
@@ -5745,7 +5855,7 b' msgid "Clone from"'
 msgstr ""
 
 #: rhodecode/templates/admin/repos/repo_add_base.mako:47
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:102
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:132
 #: rhodecode/templates/forks/fork.mako:52
 msgid "Keep it short and to the point. Use a README file for longer descriptions."
 msgstr ""
@@ -5755,7 +5865,6 b' msgid "Repository Group"'
 msgstr ""
 
 #: rhodecode/templates/admin/repos/repo_add_base.mako:58
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:62
 #: rhodecode/templates/forks/fork.mako:64
 #, python-format
 msgid "Select my personal group (%(repo_group_name)s)"
@@ -5775,7 +5884,7 b' msgid "Set the type of repository to cre'
 msgstr ""
 
 #: rhodecode/templates/admin/repos/repo_add_base.mako:84
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:70
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:98
 #: rhodecode/templates/forks/fork.mako:73
 msgid "Landing commit"
 msgstr ""
@@ -5803,36 +5912,36 b' msgstr ""'
 msgid "%s repository settings"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit.mako:55
+#: rhodecode/templates/admin/repos/repo_edit.mako:58
 msgid "Extra Fields"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit.mako:61
+#: rhodecode/templates/admin/repos/repo_edit.mako:64
 msgid "Caches"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit.mako:65
+#: rhodecode/templates/admin/repos/repo_edit.mako:68
 msgid "Remote"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit.mako:69
+#: rhodecode/templates/admin/repos/repo_edit.mako:72
 #: rhodecode/templates/summary/components.mako:135
 msgid "Statistics"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit.mako:75
+#: rhodecode/templates/admin/repos/repo_edit.mako:79
+msgid "Reviewer Rules"
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit.mako:83
 #: rhodecode/templates/admin/repos/repo_edit_maintenance.mako:3
 msgid "Maintenance"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit.mako:78
+#: rhodecode/templates/admin/repos/repo_edit.mako:86
 msgid "Strip"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit.mako:93
-msgid "Reviewers"
-msgstr ""
-
 #: rhodecode/templates/admin/repos/repo_edit_advanced.mako:7
 msgid "Updated on"
 msgstr ""
@@ -5867,84 +5976,77 b' msgstr ""'
 msgid "Public Journal Visibility"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:56
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:55
 msgid "Remove from Public Journal"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:60
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:59
 msgid "Add to Public Journal"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:65
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:64
 msgid "All actions made on this repository will be visible to everyone following the public journal."
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:74
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:73
 msgid "Locking state"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:83
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:82
 msgid "This Repository is not currently locked."
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:90
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:89
 msgid "Confirm to unlock repository."
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:92
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:91
 msgid "Unlock repository"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:97
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:96
 msgid "Confirm to lock repository."
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:99
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:98
 msgid "Lock Repository"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:105
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:104
 msgid "Force repository locking. This only works when anonymous access is disabled. Pulling from the repository locks the repository to that user until the same user pushes to that repository again."
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:114
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:113
 msgid "Delete repository"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:121
-#, python-format
-msgid "This repository has %s fork."
-msgid_plural "This repository has %s forks."
-msgstr[0] ""
-msgstr[1] ""
-
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:125
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:124
 msgid "Detach forks"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:130
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:129
 msgid "Delete forks"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:139
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:138
 #: rhodecode/templates/data_table/_dt_elements.mako:124
 #, python-format
 msgid "Confirm to delete this repository: %s"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:141
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:140
 msgid "Delete This Repository"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:146
-msgid "This repository will be renamed in a special way in order to make it inaccessible to RhodeCode Enterprise and its VCS systems. If you need to fully delete it from the file system, please do it manually, or with rhodecode-cleanup-repos command."
-msgstr ""
-
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:180
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:145
+msgid "This repository will be renamed in a special way in order to make it inaccessible to RhodeCode Enterprise and its VCS systems. If you need to fully delete it from the file system, please do it manually, or with rhodecode-cleanup-repos command available in rhodecode-tools."
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:179
 msgid "Change repository"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:180
+#: rhodecode/templates/admin/repos/repo_edit_advanced.mako:179
 msgid "Pick repository"
 msgstr ""
 
@@ -5952,44 +6054,41 b' msgstr ""'
 msgid "Invalidate Cache for Repository"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_caches.mako:10
-msgid "Invalidate repository cache"
+#: rhodecode/templates/admin/repos/repo_edit_caches.mako:7
+msgid "Manually invalidate the repository cache. On the next access a repository cache will be recreated."
 msgstr ""
 
 #: rhodecode/templates/admin/repos/repo_edit_caches.mako:10
+msgid "Cache purge can be automated by such api call. Can be called periodically in crontab etc."
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_caches.mako:20
+msgid "Invalidate repository cache"
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_caches.mako:20
 msgid "Confirm to invalidate repository cache"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_caches.mako:14
-msgid "Manually invalidate the repository cache. On the next access a repository cache will be recreated."
-msgstr ""
-
-#: rhodecode/templates/admin/repos/repo_edit_caches.mako:28
-#, python-format
-msgid "List of repository caches (%(count)s entry)"
-msgid_plural "List of repository caches (%(count)s entries)"
-msgstr[0] ""
-msgstr[1] ""
-
-#: rhodecode/templates/admin/repos/repo_edit_caches.mako:35
+#: rhodecode/templates/admin/repos/repo_edit_caches.mako:39
 #: rhodecode/templates/admin/repos/repo_edit_issuetracker.mako:32
 #: rhodecode/templates/base/issue_tracker_settings.mako:13
 msgid "Prefix"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_caches.mako:36
+#: rhodecode/templates/admin/repos/repo_edit_caches.mako:40
 #: rhodecode/templates/admin/repos/repo_edit_fields.mako:11
 msgid "Key"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_caches.mako:37
+#: rhodecode/templates/admin/repos/repo_edit_caches.mako:41
 #: rhodecode/templates/admin/user_groups/user_group_add.mako:52
 #: rhodecode/templates/admin/user_groups/user_group_edit_settings.mako:51
 #: rhodecode/templates/admin/user_groups/user_groups.mako:64
 #: rhodecode/templates/admin/users/user_add.mako:97
 #: rhodecode/templates/admin/users/user_edit_groups.mako:64
 #: rhodecode/templates/admin/users/user_edit_profile.mako:90
-#: rhodecode/templates/admin/users/users.mako:73
+#: rhodecode/templates/admin/users/users.mako:74
 msgid "Active"
 msgstr ""
 
@@ -6063,19 +6162,27 b' msgstr ""'
 msgid "Test Patterns"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_maintenance.mako:9
-msgid "Perform maintenance tasks for this repo, following tasks will be performed"
-msgstr ""
-
-#: rhodecode/templates/admin/repos/repo_edit_maintenance.mako:16
+#: rhodecode/templates/admin/repos/repo_edit_maintenance.mako:8
+msgid "Perform maintenance tasks for this repo"
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_maintenance.mako:10
+msgid "Following tasks will be performed"
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_maintenance.mako:17
+msgid "Maintenance can be automated by such api call. Can be called periodically in crontab etc."
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_maintenance.mako:25
 msgid "No maintenance tasks for this repo available"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_maintenance.mako:26
+#: rhodecode/templates/admin/repos/repo_edit_maintenance.mako:34
 msgid "Run Maintenance"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_maintenance.mako:41
+#: rhodecode/templates/admin/repos/repo_edit_maintenance.mako:49
 msgid "Performing Maintenance"
 msgstr ""
 
@@ -6083,11 +6190,11 b' msgstr ""'
 msgid "Repository Permissions"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:43
+#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:42
 msgid "private repository"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:48
+#: rhodecode/templates/admin/repos/repo_edit_permissions.mako:47
 msgid "only users/user groups explicitly added here will have access"
 msgstr ""
 
@@ -6095,56 +6202,87 b' msgstr ""'
 msgid "Remote url"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_remote.mako:9
+#: rhodecode/templates/admin/repos/repo_edit_remote.mako:7
+msgid "Manually pull changes from external repository."
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_remote.mako:11
 msgid "Remote mirror url"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_remote.mako:12
-msgid "Pull can be automated by such api call called periodically (in crontab etc)"
-msgstr ""
-
-#: rhodecode/templates/admin/repos/repo_edit_remote.mako:22
-#: rhodecode/templates/admin/repos/repo_edit_remote.mako:30
+#: rhodecode/templates/admin/repos/repo_edit_remote.mako:15
+msgid "Pull can be automated by such api call. Can be called periodically in crontab etc."
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_remote.mako:25
+#: rhodecode/templates/admin/repos/repo_edit_remote.mako:36
 msgid "Pull changes from remote location"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_remote.mako:22
+#: rhodecode/templates/admin/repos/repo_edit_remote.mako:25
 msgid "Confirm to pull changes from remote side"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_remote.mako:27
+#: rhodecode/templates/admin/repos/repo_edit_remote.mako:31
 msgid "This repository does not have any remote mirror url set."
 msgstr ""
 
+#: rhodecode/templates/admin/repos/repo_edit_remote.mako:32
+msgid "Set remote url."
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_reviewers.mako:3
+msgid "Default Reviewer Rules"
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_reviewers.mako:6
+msgid "This feature is available in RhodeCode EE edition only. Contact {sales_email} to obtain a trial license."
+msgstr ""
+
 #: rhodecode/templates/admin/repos/repo_edit_settings.mako:6
 #, python-format
 msgid "Settings for Repository: %s"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:19
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:22
 msgid "Non-changeable id"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:19
-msgid "what is that ?"
-msgstr ""
-
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:21
-msgid "URL by id"
-msgstr ""
-
 #: rhodecode/templates/admin/repos/repo_edit_settings.mako:22
+msgid "what is that ?"
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:24
+msgid "URL by id"
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:25
 msgid ""
 "In case this repository is renamed or moved into another group the repository url changes.\n"
 "                               Using above url guarantees that this repository will always be accessible under such url.\n"
 "                               Useful for CI systems, or any other cases that you need to hardcode the url into 3rd party service."
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:30
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:33
+#: rhodecode/templates/data_table/_dt_elements.mako:164
+#: rhodecode/templates/forks/fork.mako:58
+msgid "Repository group"
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:41
+#, python-format
+msgid "Select my personal group (`%(repo_group_name)s`)"
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:44
+msgid "Optional select a group to put this repository into."
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:51
 msgid "Remote uri"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:36
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:59
 #: rhodecode/templates/base/perms_summary.mako:79
 #: rhodecode/templates/base/perms_summary.mako:149
 #: rhodecode/templates/base/perms_summary.mako:151
@@ -6152,63 +6290,56 b' msgstr ""'
 msgid "edit"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:39
-msgid "new value, leave empty to remove"
-msgstr ""
-
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:41
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:65
+msgid "enter new value, or leave empty to remove"
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:75
 msgid "cancel"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:48
-msgid "http[s] url where from repository was imported, also used for doing remote pulls."
-msgstr ""
-
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:56
-#: rhodecode/templates/data_table/_dt_elements.mako:164
-#: rhodecode/templates/forks/fork.mako:58
-msgid "Repository group"
-msgstr ""
-
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:65
-msgid "Optional select a group to put this repository into."
-msgstr ""
-
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:74
-#: rhodecode/templates/forks/fork.mako:77
-msgid "Default commit for files page, downloads, whoosh and readme"
-msgstr ""
-
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:92
-msgid "Change owner of this repository."
-msgstr ""
-
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:108
-#: rhodecode/templates/data_table/_dt_elements.mako:58
-msgid "Private repository"
-msgstr ""
-
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:117
-msgid "Enable statistics"
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:87
+msgid "http[s] url where from repository was imported, this field can used for doing {pull_link}."
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:88
+msgid "This field is stored encrypted inside Database, a format of http://user:[e-mail]/repo_name can be used and will be hidden from display."
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:103
+msgid "Default commit for files page, downloads, full text search index and readme"
 msgstr ""
 
 #: rhodecode/templates/admin/repos/repo_edit_settings.mako:121
+msgid "Change owner of this repository."
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:138
+#: rhodecode/templates/data_table/_dt_elements.mako:58
+msgid "Private repository"
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:148
+msgid "Enable statistics"
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:153
 msgid "Enable statistics window on summary page."
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:126
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:158
 msgid "Enable downloads"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:130
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:163
 msgid "Enable download menu on summary page."
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:135
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:168
 msgid "Enable automatic locking"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_settings.mako:139
+#: rhodecode/templates/admin/repos/repo_edit_settings.mako:173
 msgid "Enable automatic locking on repository. Pulling from this repository creates a lock that can be released by pushing back by the same user"
 msgstr ""
 
@@ -6272,32 +6403,24 b' msgstr ""'
 msgid "Remove"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_strip.mako:112
+#: rhodecode/templates/admin/repos/repo_edit_strip.mako:114
 msgid "Checking commits"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_strip.mako:127
-msgid "author"
-msgstr ""
-
-#: rhodecode/templates/admin/repos/repo_edit_strip.mako:127
-msgid "comment"
-msgstr ""
-
-#: rhodecode/templates/admin/repos/repo_edit_strip.mako:128
+#: rhodecode/templates/admin/repos/repo_edit_strip.mako:142
 msgid " commit verified positive"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_strip.mako:131
+#: rhodecode/templates/admin/repos/repo_edit_strip.mako:154
 msgid " commit verified negative"
 msgstr ""
 
-#: rhodecode/templates/admin/repos/repo_edit_strip.mako:153
-msgid " commit striped successful"
-msgstr ""
-
-#: rhodecode/templates/admin/repos/repo_edit_strip.mako:156
-msgid " commit striped failed"
+#: rhodecode/templates/admin/repos/repo_edit_strip.mako:179
+msgid " commit striped successfully"
+msgstr ""
+
+#: rhodecode/templates/admin/repos/repo_edit_strip.mako:182
+msgid " commit strip failed"
 msgstr ""
 
 #: rhodecode/templates/admin/repos/repo_edit_vcs.mako:13
@@ -6835,12 +6958,12 b' msgid "%s user group settings"'
 msgstr ""
 
 #: rhodecode/templates/admin/user_groups/user_group_edit.mako:36
-#: rhodecode/templates/admin/users/user_edit.mako:36
+#: rhodecode/templates/admin/users/user_edit.mako:41
 msgid "Global permissions"
 msgstr ""
 
 #: rhodecode/templates/admin/user_groups/user_group_edit.mako:37
-#: rhodecode/templates/admin/users/user_edit.mako:37
+#: rhodecode/templates/admin/users/user_edit.mako:42
 msgid "Permissions summary"
 msgstr ""
 
@@ -6877,43 +7000,35 b' msgid "This group is set to be automatic'
 msgstr ""
 
 #: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:37
-msgid "Each member will be added or removed from this groups once they interact with RhodeCode system."
-msgstr ""
-
-#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:38
 msgid "This group synchronization was set by"
 msgstr ""
 
-#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:42
+#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:41
 msgid "This group is not set to be automatically synchronised"
 msgstr ""
 
-#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:51
+#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:50
 msgid "Disable synchronization"
 msgstr ""
 
-#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:53
+#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:52
 msgid "Enable synchronization"
 msgstr ""
 
-#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:60
-msgid "User group will no longer synchronize membership"
-msgstr ""
-
-#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:62
-msgid "User group will start to synchronize membership"
-msgstr ""
-
-#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:75
+#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:58
+msgid "Users will be added or removed from this group when they authenticate with RhodeCode system, based on LDAP group membership. This requires `LDAP+User group` authentication plugin to be configured and enabled. (EE only feature)"
+msgstr ""
+
+#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:71
 msgid "Delete User Group"
 msgstr ""
 
-#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:81
+#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:77
 #, python-format
 msgid "Confirm to delete user group `%(ugroup)s` with all permission assignments"
 msgstr ""
 
-#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:83
+#: rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako:79
 msgid "Delete This User Group"
 msgstr ""
 
@@ -7005,24 +7120,28 b' msgstr ""'
 msgid "%s user settings"
 msgstr ""
 
-#: rhodecode/templates/admin/users/user_edit.mako:33
+#: rhodecode/templates/admin/users/user_edit.mako:19
+msgid "This user is set as disabled"
+msgstr ""
+
+#: rhodecode/templates/admin/users/user_edit.mako:38
 #: rhodecode/templates/admin/users/user_edit_profile.mako:5
 msgid "User Profile"
 msgstr ""
 
-#: rhodecode/templates/admin/users/user_edit.mako:34
-msgid "Auth tokens"
-msgstr ""
-
 #: rhodecode/templates/admin/users/user_edit.mako:39
+msgid "Auth tokens"
+msgstr ""
+
+#: rhodecode/templates/admin/users/user_edit.mako:44
 msgid "Ip Whitelist"
 msgstr ""
 
-#: rhodecode/templates/admin/users/user_edit.mako:40
+#: rhodecode/templates/admin/users/user_edit.mako:45
 msgid "User Groups Management"
 msgstr ""
 
-#: rhodecode/templates/admin/users/user_edit.mako:41
+#: rhodecode/templates/admin/users/user_edit.mako:46
 msgid "User audit"
 msgstr ""
 
@@ -7036,7 +7155,7 b' msgid "Last login"'
 msgstr ""
 
 #: rhodecode/templates/admin/users/user_edit_advanced.mako:9
-#: rhodecode/templates/admin/users/users.mako:71
+#: rhodecode/templates/admin/users/users.mako:72
 msgid "Last activity"
 msgstr ""
 
@@ -7151,6 +7270,11 b' msgstr ""'
 msgid "Additional Email Addresses"
 msgstr ""
 
+#: rhodecode/templates/admin/users/user_edit_emails.mako:30
+#, python-format
+msgid "Confirm to delete this email: %s"
+msgstr ""
+
 #: rhodecode/templates/admin/users/user_edit_groups.mako:12
 #, python-format
 msgid "Add `%s` to user group"
@@ -7160,12 +7284,24 b' msgstr ""'
 msgid "Custom IP Whitelist"
 msgstr ""
 
-#: rhodecode/templates/admin/users/user_edit_ips.mako:19
+#: rhodecode/templates/admin/users/user_edit_ips.mako:7
+msgid "Current IP address"
+msgstr ""
+
+#: rhodecode/templates/admin/users/user_edit_ips.mako:10
+msgid "IP Address"
+msgstr ""
+
+#: rhodecode/templates/admin/users/user_edit_ips.mako:11
+msgid "IP Range"
+msgstr ""
+
+#: rhodecode/templates/admin/users/user_edit_ips.mako:20
 #, python-format
 msgid "Inherited from %s"
 msgstr ""
 
-#: rhodecode/templates/admin/users/user_edit_ips.mako:63
+#: rhodecode/templates/admin/users/user_edit_ips.mako:64
 msgid ""
 "Enter comma separated list of ip addresses like 127.0.0.1,\n"
 "or use a ip address with a mask 127.0.0.1/24, to create a network range.\n"
@@ -7210,7 +7346,7 b' msgstr ""'
 msgid "Users administration"
 msgstr ""
 
-#: rhodecode/templates/admin/users/users.mako:77
+#: rhodecode/templates/admin/users/users.mako:78
 msgid "Auth type"
 msgstr ""
 
@@ -7278,110 +7414,110 b' msgstr ""'
 msgid "Show Pull Requests for %s"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:246
+#: rhodecode/templates/base/base.mako:247
 msgid "Options"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:253
+#: rhodecode/templates/base/base.mako:255
 #: rhodecode/templates/forks/forks_data.mako:30
 msgid "Compare fork"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:256
-#: rhodecode/templates/base/base.mako:403
+#: rhodecode/templates/base/base.mako:258
+#: rhodecode/templates/base/base.mako:406
 #: rhodecode/templates/search/search.mako:64
 msgid "Search"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:260
-msgid "Unlock"
-msgstr ""
-
 #: rhodecode/templates/base/base.mako:262
+msgid "Unlock"
+msgstr ""
+
+#: rhodecode/templates/base/base.mako:264
 msgid "Lock"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:267
+#: rhodecode/templates/base/base.mako:269
 #: rhodecode/templates/data_table/_dt_elements.mako:27
 #: rhodecode/templates/data_table/_dt_elements.mako:28
 #: rhodecode/templates/forks/forks_data.mako:8
-#: rhodecode/templates/summary/components.mako:103
 msgid "Fork"
-msgid_plural "Forks"
-msgstr[0] ""
-msgstr[1] ""
-
-#: rhodecode/templates/base/base.mako:268
+msgstr ""
+
+#: rhodecode/templates/base/base.mako:270
 msgid "Create Pull Request"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:290
+#: rhodecode/templates/base/base.mako:292
 msgid "Sign in"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:298
+#: rhodecode/templates/base/base.mako:300
 #: rhodecode/templates/debug_style/login.html:28
 msgid "Sign in to your account"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:315
+#: rhodecode/templates/base/base.mako:317
 #: rhodecode/templates/debug_style/login.html:46
 msgid "(Forgot password?)"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:325
-#: rhodecode/templates/debug_style/login.html:56
-msgid "Don't have an account ?"
-msgstr ""
-
-#: rhodecode/templates/base/base.mako:345
+#: rhodecode/templates/base/base.mako:327
+msgid "Don't have an account?"
+msgstr ""
+
+#: rhodecode/templates/base/base.mako:329
+msgid "Using external auth? Sign In here."
+msgstr ""
+
+#: rhodecode/templates/base/base.mako:348
 msgid "My personal group"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:349
+#: rhodecode/templates/base/base.mako:352
 msgid "Sign Out"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:385
+#: rhodecode/templates/base/base.mako:388
 msgid "Show activity journal"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:386
+#: rhodecode/templates/base/base.mako:389
 #: rhodecode/templates/journal/journal.mako:4
 #: rhodecode/templates/journal/journal.mako:14
 msgid "Journal"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:391
+#: rhodecode/templates/base/base.mako:394
 msgid "Show Public activity journal"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:392
+#: rhodecode/templates/base/base.mako:395
 msgid "Public journal"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:397
+#: rhodecode/templates/base/base.mako:400
 msgid "Show Gists"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:398
+#: rhodecode/templates/base/base.mako:401
 msgid "Gists"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:402
+#: rhodecode/templates/base/base.mako:405
 msgid "Search in repositories you have access to"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:408
+#: rhodecode/templates/base/base.mako:411
 msgid "Admin settings"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:415
+#: rhodecode/templates/base/base.mako:418
 msgid "Delegated Admin settings"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:425
-#: rhodecode/templates/base/base.mako:426
+#: rhodecode/templates/base/base.mako:428
+#: rhodecode/templates/base/base.mako:429
 #: rhodecode/templates/debug_style/alerts.html:5
 #: rhodecode/templates/debug_style/buttons.html:5
 #: rhodecode/templates/debug_style/code-block.html:6
@@ -7403,15 +7539,15 b' msgstr ""'
 msgid "Style"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:483
+#: rhodecode/templates/base/base.mako:486
 msgid "Go to"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:536
+#: rhodecode/templates/base/base.mako:539
 msgid "Keyboard shortcuts"
 msgstr ""
 
-#: rhodecode/templates/base/base.mako:544
+#: rhodecode/templates/base/base.mako:547
 msgid "Site-wide shortcuts"
 msgstr ""
 
@@ -7503,10 +7639,10 b' msgid "Confirm to remove this pattern:"'
 msgstr ""
 
 #: rhodecode/templates/base/issue_tracker_settings.mako:191
-#: rhodecode/templates/changeset/changeset_file_comment.mako:269
-#: rhodecode/templates/changeset/changeset_file_comment.mako:319
-#: rhodecode/templates/files/files_add.mako:78
-#: rhodecode/templates/files/files_add.mako:224
+#: rhodecode/templates/changeset/changeset_file_comment.mako:274
+#: rhodecode/templates/changeset/changeset_file_comment.mako:324
+#: rhodecode/templates/files/files_add.mako:84
+#: rhodecode/templates/files/files_add.mako:228
 #: rhodecode/templates/files/files_edit.mako:82
 #: rhodecode/templates/files/files_edit.mako:185
 msgid "Preview"
@@ -7586,7 +7722,7 b' msgstr ""'
 msgid "No permission defined"
 msgstr ""
 
-#: rhodecode/templates/base/root.mako:150
+#: rhodecode/templates/base/root.mako:155
 msgid "Please enable JavaScript to use RhodeCode Enterprise"
 msgstr ""
 
@@ -7682,95 +7818,107 b' msgstr ""'
 msgid "Requires hgsubversion library to be installed. Allows cloning remote SVN repositories and migrates them to Mercurial type."
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:139
+#: rhodecode/templates/base/vcs_settings.mako:136
+msgid "Enable evolve extension"
+msgstr ""
+
+#: rhodecode/templates/base/vcs_settings.mako:140
+msgid "Enable evolve extension for all repositories."
+msgstr ""
+
+#: rhodecode/templates/base/vcs_settings.mako:142
+msgid "Enable evolve extension for this repository."
+msgstr ""
+
+#: rhodecode/templates/base/vcs_settings.mako:152
 msgid "Mercurial Labs Settings"
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:139
+#: rhodecode/templates/base/vcs_settings.mako:152
 msgid "These features are considered experimental and may not work as expected."
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:145
+#: rhodecode/templates/base/vcs_settings.mako:158
 msgid "Use rebase as merge strategy"
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:148
+#: rhodecode/templates/base/vcs_settings.mako:161
 msgid "Use rebase instead of creating a merge commit when merging via web interface."
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:160
+#: rhodecode/templates/base/vcs_settings.mako:173
 msgid "Git Settings"
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:165
+#: rhodecode/templates/base/vcs_settings.mako:178
 msgid "Enable lfs extension"
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:169
-msgid "Enable lfs extensions for all repositories."
-msgstr ""
-
-#: rhodecode/templates/base/vcs_settings.mako:171
-msgid "Enable lfs extensions for this repository."
-msgstr ""
-
 #: rhodecode/templates/base/vcs_settings.mako:182
+msgid "Enable lfs extensions for all repositories."
+msgstr ""
+
+#: rhodecode/templates/base/vcs_settings.mako:184
+msgid "Enable lfs extensions for this repository."
+msgstr ""
+
+#: rhodecode/templates/base/vcs_settings.mako:195
 msgid "Filesystem location where Git lfs objects should be stored."
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:193
+#: rhodecode/templates/base/vcs_settings.mako:206
 msgid "Global Subversion Settings"
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:199
+#: rhodecode/templates/base/vcs_settings.mako:212
 msgid "Proxy subversion HTTP requests"
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:203
-msgid "Subversion HTTP Support. Enables communication with SVN over HTTP protocol."
-msgstr ""
-
-#: rhodecode/templates/base/vcs_settings.mako:204
-msgid "SVN Protocol setup Documentation"
-msgstr ""
-
-#: rhodecode/templates/base/vcs_settings.mako:210
-msgid "Subversion HTTP Server URL"
-msgstr ""
-
 #: rhodecode/templates/base/vcs_settings.mako:216
+msgid "Subversion HTTP Support. Enables communication with SVN over HTTP protocol."
+msgstr ""
+
+#: rhodecode/templates/base/vcs_settings.mako:217
+msgid "SVN Protocol setup Documentation"
+msgstr ""
+
+#: rhodecode/templates/base/vcs_settings.mako:223
+msgid "Subversion HTTP Server URL"
+msgstr ""
+
+#: rhodecode/templates/base/vcs_settings.mako:229
 msgid "Generate Apache Config"
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:228
+#: rhodecode/templates/base/vcs_settings.mako:241
 msgid "Subversion Settings"
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:233
+#: rhodecode/templates/base/vcs_settings.mako:246
 msgid "Repository patterns"
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:237
+#: rhodecode/templates/base/vcs_settings.mako:250
 msgid "Patterns for identifying SVN branches and tags. For recursive search, use \"*\". Eg.: \"/branches/*\""
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:301
+#: rhodecode/templates/base/vcs_settings.mako:314
 msgid "Pull Request Settings"
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:306
+#: rhodecode/templates/base/vcs_settings.mako:319
 msgid "Enable server-side merge for pull requests"
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:309
+#: rhodecode/templates/base/vcs_settings.mako:322
 msgid "Note: when this feature is enabled, it only runs hooks defined in the rcextension package. Custom hooks added on the Admin -> Settings -> Hooks page will not be run when pull requests are automatically merged from the web interface."
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:313
+#: rhodecode/templates/base/vcs_settings.mako:326
 msgid "Invalidate and relocate inline comments during update"
 msgstr ""
 
-#: rhodecode/templates/base/vcs_settings.mako:316
+#: rhodecode/templates/base/vcs_settings.mako:329
 msgid "During the update of a pull request, the position of inline comments will be updated and outdated inline comments will be hidden."
 msgstr ""
 
@@ -7788,10 +7936,10 b' msgid "Compare Selected Bookmarks"'
 msgstr ""
 
 #: rhodecode/templates/bookmarks/bookmarks_data.mako:13
-#: rhodecode/templates/changelog/changelog_elements.mako:91
-#: rhodecode/templates/changelog/changelog_summary_data.mako:62
-#: rhodecode/templates/changeset/changeset.mako:92
+#: rhodecode/templates/changelog/changelog_elements.mako:111
+#: rhodecode/templates/changeset/changeset.mako:112
 #: rhodecode/templates/files/base.mako:10
+#: rhodecode/templates/summary/summary_commits.mako:62
 #, python-format
 msgid "Bookmark %s"
 msgstr ""
@@ -7810,10 +7958,10 b' msgid "Compare Selected Branches"'
 msgstr ""
 
 #: rhodecode/templates/branches/branches_data.mako:12
-#: rhodecode/templates/changelog/changelog_elements.mako:83
-#: rhodecode/templates/changelog/changelog_summary_data.mako:76
-#: rhodecode/templates/changeset/changeset.mako:105
+#: rhodecode/templates/changelog/changelog_elements.mako:103
+#: rhodecode/templates/changeset/changeset.mako:125
 #: rhodecode/templates/files/base.mako:23
+#: rhodecode/templates/summary/summary_commits.mako:76
 #, python-format
 msgid "Branch %s"
 msgstr ""
@@ -7851,19 +7999,19 b' msgstr[0] ""'
 msgstr[1] ""
 
 #: rhodecode/templates/changelog/changelog.mako:110
-#: rhodecode/templates/files/files_add.mako:93
+#: rhodecode/templates/files/files_add.mako:99
 #: rhodecode/templates/files/files_delete.mako:60
 #: rhodecode/templates/files/files_edit.mako:96
 msgid "Commit Message"
 msgstr ""
 
 #: rhodecode/templates/changelog/changelog.mako:112
-#: rhodecode/templates/changelog/changelog_summary_data.mako:10
+#: rhodecode/templates/summary/summary_commits.mako:10
 msgid "Age"
 msgstr ""
 
 #: rhodecode/templates/changelog/changelog.mako:115
-#: rhodecode/templates/changelog/changelog_summary_data.mako:12
+#: rhodecode/templates/summary/summary_commits.mako:12
 msgid "Refs"
 msgstr ""
 
@@ -7880,7 +8028,7 b' msgid "load previous"'
 msgstr ""
 
 #: rhodecode/templates/changelog/changelog_elements.mako:26
-#: rhodecode/templates/changelog/changelog_summary_data.mako:21
+#: rhodecode/templates/summary/summary_commits.mako:21
 #, python-format
 msgid ""
 "Commit status: %s\n"
@@ -7888,44 +8036,66 b' msgid ""'
 msgstr ""
 
 #: rhodecode/templates/changelog/changelog_elements.mako:30
-#: rhodecode/templates/changelog/changelog_summary_data.mako:25
+#: rhodecode/templates/summary/summary_commits.mako:25
 #, python-format
 msgid "Commit status: %s"
 msgstr ""
 
 #: rhodecode/templates/changelog/changelog_elements.mako:36
-#: rhodecode/templates/changelog/changelog_summary_data.mako:31
+#: rhodecode/templates/summary/summary_commits.mako:31
 msgid "Commit status: Not Reviewed"
 msgstr ""
 
 #: rhodecode/templates/changelog/changelog_elements.mako:41
-#: rhodecode/templates/changelog/changelog_summary_data.mako:36
+#: rhodecode/templates/summary/summary_commits.mako:36
 msgid "Commit has comments"
 msgstr ""
 
 #: rhodecode/templates/changelog/changelog_elements.mako:53
-#: rhodecode/templates/compare/compare_commits.mako:46
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:495
+#: rhodecode/templates/changeset/changeset.mako:40
+msgid "Commit phase"
+msgstr ""
+
+#: rhodecode/templates/changelog/changelog_elements.mako:60
+#: rhodecode/templates/changelog/changelog_elements.mako:67
+#: rhodecode/templates/changeset/changeset.mako:46
+#: rhodecode/templates/changeset/changeset.mako:53
+msgid "Evolve State"
+msgstr ""
+
+#: rhodecode/templates/changelog/changelog_elements.mako:60
+#: rhodecode/templates/changeset/changeset.mako:46
+msgid "obsolete"
+msgstr ""
+
+#: rhodecode/templates/changelog/changelog_elements.mako:67
+#: rhodecode/templates/changeset/changeset.mako:53
+msgid "hidden"
+msgstr ""
+
+#: rhodecode/templates/changelog/changelog_elements.mako:73
+#: rhodecode/templates/compare/compare_commits.mako:47
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:522
 #: rhodecode/templates/search/search_commit.mako:36
 msgid "Expand commit message"
 msgstr ""
 
-#: rhodecode/templates/changelog/changelog_elements.mako:77
-#: rhodecode/templates/changeset/changeset.mako:86
+#: rhodecode/templates/changelog/changelog_elements.mako:97
+#: rhodecode/templates/changeset/changeset.mako:106
 #: rhodecode/templates/files/base.mako:4
 msgid "merge"
 msgstr ""
 
-#: rhodecode/templates/changelog/changelog_elements.mako:99
-#: rhodecode/templates/changelog/changelog_summary_data.mako:69
-#: rhodecode/templates/changeset/changeset.mako:99
+#: rhodecode/templates/changelog/changelog_elements.mako:119
+#: rhodecode/templates/changeset/changeset.mako:119
 #: rhodecode/templates/files/base.mako:17
+#: rhodecode/templates/summary/summary_commits.mako:69
 #: rhodecode/templates/tags/tags_data.mako:12
 #, python-format
 msgid "Tag %s"
 msgstr ""
 
-#: rhodecode/templates/changelog/changelog_elements.mako:113
+#: rhodecode/templates/changelog/changelog_elements.mako:133
 msgid "load next"
 msgstr ""
 
@@ -7933,100 +8103,78 b' msgstr ""'
 msgid "Show File"
 msgstr ""
 
-#: rhodecode/templates/changelog/changelog_summary_data.mako:9
-#: rhodecode/templates/search/search_commit.mako:8
-msgid "Commit message"
-msgstr ""
-
-#: rhodecode/templates/changelog/changelog_summary_data.mako:100
-msgid "Add or upload files directly via RhodeCode:"
-msgstr ""
-
-#: rhodecode/templates/changelog/changelog_summary_data.mako:103
-#: rhodecode/templates/files/files_browser.mako:25
-msgid "Add New File"
-msgstr ""
-
-#: rhodecode/templates/changelog/changelog_summary_data.mako:111
-msgid "Push new repo:"
-msgstr ""
-
-#: rhodecode/templates/changelog/changelog_summary_data.mako:122
-msgid "Existing repository?"
-msgstr ""
-
 #: rhodecode/templates/changeset/changeset.mako:7
 #, python-format
 msgid "%s Commit"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:43
+#: rhodecode/templates/changeset/changeset.mako:62
 msgid "Parent Commit"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:43
+#: rhodecode/templates/changeset/changeset.mako:62
 msgid "Parent"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:47
+#: rhodecode/templates/changeset/changeset.mako:66
 msgid "Child Commit"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:47
-msgid "Child"
-msgstr ""
-
-#: rhodecode/templates/changeset/changeset.mako:58
-msgid "Expand"
-msgstr ""
-
 #: rhodecode/templates/changeset/changeset.mako:66
-#: rhodecode/templates/changeset/changeset.mako:72
+msgid "Child"
+msgstr ""
+
+#: rhodecode/templates/changeset/changeset.mako:78
+msgid "Expand"
+msgstr ""
+
+#: rhodecode/templates/changeset/changeset.mako:86
+#: rhodecode/templates/changeset/changeset.mako:92
 #: rhodecode/templates/changeset/changeset_file_comment.mako:81
 #: rhodecode/templates/compare/compare_diff.mako:159
 msgid "Commit status"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:79
+#: rhodecode/templates/changeset/changeset.mako:99
 #: rhodecode/templates/files/file_tree_detail.mako:21
 #: rhodecode/templates/files/files_detail.mako:20
 msgid "References"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:115
+#: rhodecode/templates/changeset/changeset.mako:135
 msgid "Diff options"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:119
+#: rhodecode/templates/changeset/changeset.mako:139
 #: rhodecode/templates/codeblocks/diffs.mako:445
 #: rhodecode/templates/codeblocks/diffs.mako:448
 msgid "Raw diff"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:120
+#: rhodecode/templates/changeset/changeset.mako:140
 msgid "Raw Diff"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:123
+#: rhodecode/templates/changeset/changeset.mako:143
 msgid "Patch diff"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:124
+#: rhodecode/templates/changeset/changeset.mako:144
 msgid "Patch Diff"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:127
+#: rhodecode/templates/changeset/changeset.mako:147
 #: rhodecode/templates/codeblocks/diffs.mako:452
 #: rhodecode/templates/codeblocks/diffs.mako:455
 msgid "Download diff"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:128
+#: rhodecode/templates/changeset/changeset.mako:148
 msgid "Download Diff"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:145
-#: rhodecode/templates/changeset/changeset.mako:147
+#: rhodecode/templates/changeset/changeset.mako:165
+#: rhodecode/templates/changeset/changeset.mako:167
 #: rhodecode/tests/functional/test_commit_comments.py:275
 #, python-format
 msgid "%d Commit comment"
@@ -8034,8 +8182,8 b' msgid_plural "%d Commit comments"'
 msgstr[0] ""
 msgstr[1] ""
 
-#: rhodecode/templates/changeset/changeset.mako:150
-#: rhodecode/templates/changeset/changeset.mako:152
+#: rhodecode/templates/changeset/changeset.mako:170
+#: rhodecode/templates/changeset/changeset.mako:172
 #: rhodecode/tests/functional/test_commit_comments.py:282
 #, python-format
 msgid "%d Inline Comment"
@@ -8043,19 +8191,19 b' msgid_plural "%d Inline Comments"'
 msgstr[0] ""
 msgstr[1] ""
 
-#: rhodecode/templates/changeset/changeset.mako:160
+#: rhodecode/templates/changeset/changeset.mako:180
 msgid "Unresolved TODOs"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:169
+#: rhodecode/templates/changeset/changeset.mako:189
 msgid "There are no unresolved TODOs"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:249
+#: rhodecode/templates/changeset/changeset.mako:269
 msgid "No Child Commits"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset.mako:285
+#: rhodecode/templates/changeset/changeset.mako:305
 msgid "No Parent Commits"
 msgstr ""
 
@@ -8081,72 +8229,80 b' msgstr ""'
 msgid "resolves comment #{}"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset_file_comment.mako:100
+#: rhodecode/templates/changeset/changeset_file_comment.mako:96
+msgid "Pull request author"
+msgstr ""
+
+#: rhodecode/templates/changeset/changeset_file_comment.mako:97
+msgid "author"
+msgstr ""
+
+#: rhodecode/templates/changeset/changeset_file_comment.mako:105
 msgid "Outdated comment from pull request version {0}"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset_file_comment.mako:104
-#: rhodecode/templates/changeset/changeset_file_comment.mako:119
+#: rhodecode/templates/changeset/changeset_file_comment.mako:109
+#: rhodecode/templates/changeset/changeset_file_comment.mako:124
 msgid "Comment from pull request version {0}"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset_file_comment.mako:116
+#: rhodecode/templates/changeset/changeset_file_comment.mako:121
 msgid "Outdated comment from pull request version {}"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset_file_comment.mako:146
-#: rhodecode/templates/changeset/changeset_file_comment.mako:149
+#: rhodecode/templates/changeset/changeset_file_comment.mako:151
+#: rhodecode/templates/changeset/changeset_file_comment.mako:154
 msgid "Prev"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset_file_comment.mako:147
-#: rhodecode/templates/changeset/changeset_file_comment.mako:150
+#: rhodecode/templates/changeset/changeset_file_comment.mako:152
+#: rhodecode/templates/changeset/changeset_file_comment.mako:155
 msgid "Next"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset_file_comment.mako:185
+#: rhodecode/templates/changeset/changeset_file_comment.mako:190
 msgid "Leave a comment on this Pull Request."
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset_file_comment.mako:187
+#: rhodecode/templates/changeset/changeset_file_comment.mako:192
 msgid "Leave a comment on {} commits in this range."
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset_file_comment.mako:189
+#: rhodecode/templates/changeset/changeset_file_comment.mako:194
 msgid "Leave a comment on this Commit."
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset_file_comment.mako:277
+#: rhodecode/templates/changeset/changeset_file_comment.mako:282
 #: rhodecode/templates/codeblocks/diffs.mako:71
 msgid "You need to be logged in to leave comments."
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset_file_comment.mako:278
+#: rhodecode/templates/changeset/changeset_file_comment.mako:283
 #: rhodecode/templates/codeblocks/diffs.mako:71
 msgid "Login now"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset_file_comment.mako:343
+#: rhodecode/templates/changeset/changeset_file_comment.mako:348
 #, python-format
 msgid "Comments parsed using %s syntax with %s, and %s actions support."
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset_file_comment.mako:345
+#: rhodecode/templates/changeset/changeset_file_comment.mako:350
 msgid "Use @username inside this text to send notification to this RhodeCode user"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset_file_comment.mako:346
+#: rhodecode/templates/changeset/changeset_file_comment.mako:351
 msgid "Start typing with / for certain actions to be triggered via text box."
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset_file_comment.mako:363
+#: rhodecode/templates/changeset/changeset_file_comment.mako:368
 #: rhodecode/templates/pullrequests/pullrequest_show.mako:15
 #: rhodecode/templates/pullrequests/pullrequest_show.mako:153
 #: rhodecode/templates/pullrequests/pullrequests.mako:52
 msgid "Closed"
 msgstr ""
 
-#: rhodecode/templates/changeset/changeset_file_comment.mako:393
+#: rhodecode/templates/changeset/changeset_file_comment.mako:398
 #: rhodecode/templates/compare/compare_diff.mako:104
 #: rhodecode/templates/compare/compare_diff.mako:112
 #: rhodecode/templates/compare/compare_diff.mako:120
@@ -8185,7 +8341,7 b' msgstr ""'
 
 #: rhodecode/templates/changeset/changeset_range.mako:99
 #: rhodecode/templates/compare/compare_diff.mako:312
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:419
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:446
 #, python-format
 msgid "Expand %s commit"
 msgid_plural "Expand %s commits"
@@ -8194,7 +8350,7 b' msgstr[1] ""'
 
 #: rhodecode/templates/changeset/changeset_range.mako:105
 #: rhodecode/templates/compare/compare_diff.mako:318
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:425
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:452
 #, python-format
 msgid "Collapse %s commit"
 msgid_plural "Collapse %s commits"
@@ -8363,26 +8519,26 b' msgstr ""'
 msgid "Compare was calculated based on this shared commit."
 msgstr ""
 
-#: rhodecode/templates/compare/compare_commits.mako:16
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:456
+#: rhodecode/templates/compare/compare_commits.mako:17
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:483
 msgid "Time"
 msgstr ""
 
-#: rhodecode/templates/compare/compare_commits.mako:67
+#: rhodecode/templates/compare/compare_commits.mako:68
 #, python-format
 msgid "%s commit hidden"
 msgid_plural "%s commits hidden"
 msgstr[0] ""
 msgstr[1] ""
 
-#: rhodecode/templates/compare/compare_commits.mako:68
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:573
+#: rhodecode/templates/compare/compare_commits.mako:69
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:600
 msgid "show it"
 msgid_plural "show them"
 msgstr[0] ""
 msgstr[1] ""
 
-#: rhodecode/templates/compare/compare_commits.mako:74
+#: rhodecode/templates/compare/compare_commits.mako:75
 msgid "No commits in this compare"
 msgstr ""
 
@@ -8420,6 +8576,7 b' msgstr ""'
 #: rhodecode/templates/email_templates/pull_request_comment.mako:90
 #: rhodecode/templates/email_templates/pull_request_review.mako:73
 #: rhodecode/templates/files/files_source.mako:23
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:71
 msgid "Source"
 msgstr ""
 
@@ -8633,6 +8790,10 b' msgstr ""'
 msgid "Form vertical"
 msgstr ""
 
+#: rhodecode/templates/debug_style/login.html:56
+msgid "Don't have an account ?"
+msgstr ""
+
 #: rhodecode/templates/email_templates/base.mako:32
 #, python-format
 msgid "This is a notification from RhodeCode. %(instance_url)s"
@@ -8746,6 +8907,7 b' msgid "%(user)s left %(comment_type)s on'
 msgstr ""
 
 #: rhodecode/templates/email_templates/pull_request_comment.mako:49
+#: rhodecode/templates/pullrequests/pullrequest.mako:72
 msgid "Source repository"
 msgstr ""
 
@@ -8814,8 +8976,6 b' msgid "%(target_ref_type)s of %(target_r'
 msgstr ""
 
 #: rhodecode/templates/email_templates/pull_request_review.mako:76
-#: rhodecode/templates/summary/components.mako:95
-#: rhodecode/templates/summary/components.mako:98
 #, python-format
 msgid "%(num)s Commit"
 msgid_plural "%(num)s Commits"
@@ -8839,7 +8999,7 b' msgstr ""'
 msgid "Full Name"
 msgstr ""
 
-#: rhodecode/templates/errors/error_document.mako:46
+#: rhodecode/templates/errors/error_document.mako:45
 #, python-format
 msgid "You will be redirected to %s in %s seconds"
 msgstr ""
@@ -8910,6 +9070,7 b' msgid "Remove Custom Path"'
 msgstr ""
 
 #: rhodecode/templates/files/files_add.mako:50
+#: rhodecode/templates/files/files_add.mako:59
 msgid "Filename"
 msgstr ""
 
@@ -8917,34 +9078,34 b' msgstr ""'
 msgid "Upload File"
 msgstr ""
 
-#: rhodecode/templates/files/files_add.mako:59
-msgid "Upload file"
-msgstr ""
-
-#: rhodecode/templates/files/files_add.mako:63
+#: rhodecode/templates/files/files_add.mako:62
 msgid "No file selected"
 msgstr ""
 
 #: rhodecode/templates/files/files_add.mako:65
+msgid "Upload file"
+msgstr ""
+
+#: rhodecode/templates/files/files_add.mako:71
 msgid "Create New File"
 msgstr ""
 
-#: rhodecode/templates/files/files_add.mako:75
+#: rhodecode/templates/files/files_add.mako:81
 #: rhodecode/templates/files/files_edit.mako:79
 msgid "line wraps"
 msgstr ""
 
-#: rhodecode/templates/files/files_add.mako:76
+#: rhodecode/templates/files/files_add.mako:82
 #: rhodecode/templates/files/files_edit.mako:80
 msgid "on"
 msgstr ""
 
-#: rhodecode/templates/files/files_add.mako:76
+#: rhodecode/templates/files/files_add.mako:82
 #: rhodecode/templates/files/files_edit.mako:80
 msgid "off"
 msgstr ""
 
-#: rhodecode/templates/files/files_add.mako:103
+#: rhodecode/templates/files/files_add.mako:109
 #: rhodecode/templates/files/files_edit.mako:106
 msgid "Commit changes"
 msgstr ""
@@ -8965,6 +9126,11 b' msgstr ""'
 msgid "Close File List"
 msgstr ""
 
+#: rhodecode/templates/files/files_browser.mako:25
+#: rhodecode/templates/summary/summary_commits.mako:103
+msgid "Add New File"
+msgstr ""
+
 #: rhodecode/templates/files/files_browser.mako:27
 msgid "Add File"
 msgstr ""
@@ -9077,7 +9243,6 b' msgid "LargeFile"'
 msgstr ""
 
 #: rhodecode/templates/files/files_source.mako:10
-#: rhodecode/templates/search/search_content.mako:57
 msgid "line"
 msgid_plural "lines"
 msgstr[0] ""
@@ -9141,6 +9306,10 b' msgstr ""'
 msgid "Fork name"
 msgstr ""
 
+#: rhodecode/templates/forks/fork.mako:77
+msgid "Default commit for files page, downloads, whoosh and readme"
+msgstr ""
+
 #: rhodecode/templates/forks/fork.mako:93
 msgid "Copy permissions"
 msgstr ""
@@ -9178,6 +9347,13 b' msgstr ""'
 msgid "Filter"
 msgstr ""
 
+#: rhodecode/templates/journal/journal.mako:14
+#, python-format
+msgid "%s entry"
+msgid_plural "%s entries"
+msgstr[0] ""
+msgstr[1] ""
+
 #: rhodecode/templates/journal/journal.mako:23
 msgid "ATOM journal feed"
 msgstr ""
@@ -9208,65 +9384,75 b' msgstr ""'
 msgid "New pull request"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest.mako:51
+#: rhodecode/templates/pullrequests/pullrequest.mako:35
+msgid "Pull request summary"
+msgstr ""
+
+#: rhodecode/templates/pullrequests/pullrequest.mako:58
 msgid "Write a short description on this pull request"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest.mako:57
+#: rhodecode/templates/pullrequests/pullrequest.mako:64
 msgid "Commit flow"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest.mako:65
-msgid "Origin repository"
-msgstr ""
-
-#: rhodecode/templates/pullrequests/pullrequest.mako:83
+#: rhodecode/templates/pullrequests/pullrequest.mako:90
 msgid "Loading refs..."
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest.mako:94
+#: rhodecode/templates/pullrequests/pullrequest.mako:101
 msgid "Submit Pull Request"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest.mako:107
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:322
+#: rhodecode/templates/pullrequests/pullrequest.mako:115
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:309
+msgid "Author of this pull request"
+msgstr ""
+
+#: rhodecode/templates/pullrequests/pullrequest.mako:129
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:323
+msgid "Reviewer rules"
+msgstr ""
+
+#: rhodecode/templates/pullrequests/pullrequest.mako:139
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:337
 msgid "Pull request reviewers"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest.mako:118
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:366
-msgid "Add reviewer"
-msgstr ""
-
-#: rhodecode/templates/pullrequests/pullrequest.mako:297
-#: rhodecode/templates/pullrequests/pullrequest.mako:570
-msgid "Please select origin and destination"
-msgstr ""
-
-#: rhodecode/templates/pullrequests/pullrequest.mako:303
+#: rhodecode/templates/pullrequests/pullrequest.mako:150
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:392
+msgid "Add reviewer or reviewer group"
+msgstr ""
+
+#: rhodecode/templates/pullrequests/pullrequest.mako:302
+#: rhodecode/templates/pullrequests/pullrequest.mako:504
+msgid "Please select source and target"
+msgstr ""
+
+#: rhodecode/templates/pullrequests/pullrequest.mako:308
 msgid "Loading compare ..."
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest.mako:350
-#: rhodecode/templates/pullrequests/pullrequest.mako:352
+#: rhodecode/templates/pullrequests/pullrequest.mako:356
+#: rhodecode/templates/pullrequests/pullrequest.mako:358
 msgid "This pull request will consist of __COMMITS__ commit."
 msgid_plural "This pull request will consist of __COMMITS__ commits."
 msgstr[0] ""
 msgstr[1] ""
 
-#: rhodecode/templates/pullrequests/pullrequest.mako:355
+#: rhodecode/templates/pullrequests/pullrequest.mako:361
 msgid "Show detailed compare."
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest.mako:362
+#: rhodecode/templates/pullrequests/pullrequest.mako:368
 msgid "There are no commits to merge."
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest.mako:462
-msgid "Destination repository"
-msgstr ""
-
-#: rhodecode/templates/pullrequests/pullrequest.mako:473
+#: rhodecode/templates/pullrequests/pullrequest.mako:431
+msgid "Target repository"
+msgstr ""
+
+#: rhodecode/templates/pullrequests/pullrequest.mako:441
 msgid "Select commit reference"
 msgstr ""
 
@@ -9314,10 +9500,6 b' msgstr ""'
 msgid "Confirm to delete this pull request"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:71
-msgid "Origin"
-msgstr ""
-
 #: rhodecode/templates/pullrequests/pullrequest_show.mako:88
 msgid "Common ancestor"
 msgstr ""
@@ -9416,69 +9598,69 b' msgid "Pull request versions not availab'
 msgstr ""
 
 #: rhodecode/templates/pullrequests/pullrequest_show.mako:300
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:370
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:397
 msgid "Save Changes"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:387
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:414
 msgid "Missing requirements:"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:388
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:415
 msgid "These commits cannot be displayed, because this repository uses the Mercurial largefiles extension, which was not enabled."
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:396
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:423
 msgid "Missing commits"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:397
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:424
 msgid "This pull request cannot be displayed, because one or more commits no longer exist in the source repository."
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:398
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:425
 msgid "Please update this pull request, push the commits back into the source repository, or consider closing this pull request."
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:409
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:436
 #, python-format
 msgid "Showing changes at v%d, commenting is disabled."
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:432
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:434
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:459
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:461
 msgid "Update commits"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:434
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:461
 msgid "Update is disabled for current view"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:445
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:472
 msgid "Commits and changes between v{ver_from} and {ver_to} of this pull request, commenting is disabled"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:449
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:476
 msgid "commits added: {}, removed: {}"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:467
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:494
 msgid "Commit added in displayed changes"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:469
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:496
 msgid "Commit removed in displayed changes"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:572
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:599
 msgid "there is {num} general comment from older versions"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:575
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:602
 msgid "there are {num} general comments from older versions"
 msgstr ""
 
-#: rhodecode/templates/pullrequests/pullrequest_show.mako:576
+#: rhodecode/templates/pullrequests/pullrequest_show.mako:603
 msgid "show them"
 msgstr ""
 
@@ -9568,6 +9750,11 b' msgstr ""'
 msgid "File names"
 msgstr ""
 
+#: rhodecode/templates/search/search_commit.mako:8
+#: rhodecode/templates/summary/summary_commits.mako:9
+msgid "Commit message"
+msgstr ""
+
 #: rhodecode/templates/search/search_commit.mako:11
 msgid "Age (new first)"
 msgstr ""
@@ -9599,34 +9786,6 b' msgstr ""'
 msgid "%s RSS feed"
 msgstr ""
 
-#: rhodecode/templates/summary/components.mako:5
-#, python-format
-msgid "%(num)s Branch"
-msgid_plural "%(num)s Branches"
-msgstr[0] ""
-msgstr[1] ""
-
-#: rhodecode/templates/summary/components.mako:12
-#, python-format
-msgid "%(num)s Closed Branch"
-msgid_plural "%(num)s Closed Branches"
-msgstr[0] ""
-msgstr[1] ""
-
-#: rhodecode/templates/summary/components.mako:19
-#, python-format
-msgid "%(num)s Tag"
-msgid_plural "%(num)s Tags"
-msgstr[0] ""
-msgstr[1] ""
-
-#: rhodecode/templates/summary/components.mako:26
-#, python-format
-msgid "%(num)s Bookmark"
-msgid_plural "%(num)s Bookmarks"
-msgstr[0] ""
-msgstr[1] ""
-
 #: rhodecode/templates/summary/components.mako:49
 msgid "Read-only url"
 msgstr ""
@@ -9707,6 +9866,18 b' msgstr ""'
 msgid "Readme file from commit %s:%s"
 msgstr ""
 
+#: rhodecode/templates/summary/summary_commits.mako:100
+msgid "Add or upload files directly via RhodeCode:"
+msgstr ""
+
+#: rhodecode/templates/summary/summary_commits.mako:111
+msgid "Push new repo:"
+msgstr ""
+
+#: rhodecode/templates/summary/summary_commits.mako:122
+msgid "Existing repository?"
+msgstr ""
+
 #: rhodecode/templates/tags/tags.mako:5
 #, python-format
 msgid "%s Tags"

rhodecode/integrations/types/webhook.py

@@ -35,12 +35,14 b' from rhodecode.integrations.types.base i'
 
 log = logging.getLogger(__name__)
 
-# updating this required to update the `base_vars` passed in url calling func
+# updating this required to update the `common_vars` passed in url calling func
 WEBHOOK_URL_VARS = [
     'repo_name',
     'repo_type',
     'repo_id',
     'repo_url',
+    # extra repo fields
+    'extra:<extra_key_name>',
 
     # special attrs below that we handle, using multi-call
     'branch',
@@ -50,6 +52,10 b' WEBHOOK_URL_VARS = ['
     'pull_request_id',
     'pull_request_url',
 
+    # user who triggers the call
+    'username',
+    'user_id',
+
 ]
 URL_VARS = ', '.join('${' + x + '}' for x in WEBHOOK_URL_VARS)
 
@@ -70,7 +76,13 b' class WebhookHandler(object):'
             'repo_type': data['repo']['repo_type'],
             'repo_id': data['repo']['repo_id'],
             'repo_url': data['repo']['url'],
+            'username': data['actor']['username'],
+            'user_id': data['actor']['user_id']
         }
+        extra_vars = {}
+        for extra_key, extra_val in data['repo']['extra_fields'].items():
+            extra_vars['extra:{}'.format(extra_key)] = extra_val
+        common_vars.update(extra_vars)
 
         return string.Template(
             self.template_url).safe_substitute(**common_vars)

rhodecode/lib/action_parser.py

@@ -42,8 +42,13 b' def action_parser(user_log, feed=False, '
     :param feed: use output for feeds (no html and fancy icons)
     :param parse_cs: parse Changesets into VCS instances
     """
-    ap = ActionParser(user_log, feed=False, parse_commits=False)
-    return ap.callbacks()
+    if user_log.version == 'v2':
+        ap = AuditLogParser(user_log)
+        return ap.callbacks()
+    else:
+        # old style
+        ap = ActionParser(user_log, feed=False, parse_commits=False)
+        return ap.callbacks()
 
 
 class ActionParser(object):
@@ -161,8 +166,9 b' class ActionParser(object):'
         return action_map
 
     def get_fork_name(self):
+        from rhodecode.lib import helpers as h
         repo_name = self.action_params
-        _url = url('summary_home', repo_name=repo_name)
+        _url = h.route_path('repo_summary', repo_name=repo_name)
         return _('fork name %s') % link_to(self.action_params, _url)
 
     def get_user_name(self):
@@ -174,6 +180,7 b' class ActionParser(object):'
         return group_name
 
     def get_pull_request(self):
+        from rhodecode.lib import helpers as h
         pull_request_id = self.action_params
         if self.is_deleted():
             repo_name = self.user_log.repository_name
@@ -181,8 +188,8 b' class ActionParser(object):'
             repo_name = self.user_log.repository.repo_name
         return link_to(
             _('Pull request #%s') % pull_request_id,
-            url('pullrequest_show', repo_name=repo_name,
-                pull_request_id=pull_request_id))
+            h.route_path('pullrequest_show', repo_name=repo_name,
+                         pull_request_id=pull_request_id))
 
     def get_archive_name(self):
         archive_name = self.action_params
@@ -302,6 +309,34 b' class ActionParser(object):'
         return self.user_log.repository is None
 
 
+class AuditLogParser(object):
+    def __init__(self, audit_log_entry):
+        self.audit_log_entry = audit_log_entry
+
+    def get_icon(self, action):
+        return 'icon-rhodecode'
+
+    def callbacks(self):
+        action_str = self.audit_log_entry.action
+
+        def callback():
+            # returned callbacks we need to call to get
+            action = action_str \
+                .replace('[', '<span class="journal_highlight">')\
+                .replace(']', '</span>')
+            return literal(action)
+
+        def icon():
+            tmpl = """<i class="%s" alt="%s"></i>"""
+            ico = self.get_icon(action_str)
+            return literal(tmpl % (ico, action_str))
+
+        action_params_func = _no_params_func
+
+        return [
+            callback, action_params_func, icon]
+
+
 def _no_params_func():
     return ""
 

rhodecode/lib/auth.py

@@ -34,10 +34,10 b' import traceback'
 from functools import wraps
 
 import ipaddress
-from pyramid.httpexceptions import HTTPForbidden, HTTPFound
-from pylons import url, request
-from pylons.controllers.util import abort, redirect
+from pyramid.httpexceptions import HTTPForbidden, HTTPFound, HTTPNotFound
 from pylons.i18n.translation import _
+# NOTE(marcink): this has to be removed only after pyramid migration,
+# replace with _ = request.translate
 from sqlalchemy.orm.exc import ObjectDeletedError
 from sqlalchemy.orm import joinedload
 from zope.cachedescriptors.property import Lazy as LazyProperty
@@ -138,7 +138,7 b' class _RhodeCodeCryptoBase(object):'
 
 
 class _RhodeCodeCryptoBCrypt(_RhodeCodeCryptoBase):
-    ENC_PREF = '$2a$10'
+    ENC_PREF = ('$2a$10', '$2b$10')
 
     def hash_create(self, str_):
         self._assert_bytes(str_)
@@ -302,7 +302,8 b' def _cached_perms_data(user_id, scope, u'
         explicit, algo)
     return permissions.calculate()
 
-class PermOrigin:
+
+class PermOrigin(object):
     ADMIN = 'superadmin'
 
     REPO_USER = 'user:%s'
@@ -341,7 +342,6 b' class PermOriginDict(dict):'
     {'resource': [('read', 'default'), ('write', 'admin')]}
     """
 
-
     def __init__(self, *args, **kw):
         dict.__init__(self, *args, **kw)
         self.perm_origin_stack = {}
@@ -807,6 +807,8 b' class AuthUser(object):'
         self.ip_addr = ip_addr
         self.name = ''
         self.lastname = ''
+        self.first_name = ''
+        self.last_name = ''
         self.email = ''
         self.is_authenticated = False
         self.admin = False
@@ -1045,8 +1047,8 b' class AuthUser(object):'
             default_ips = UserIpMap.query().filter(
                 UserIpMap.user == User.get_default_user(cache=True))
             if cache:
-                default_ips = default_ips.options(FromCache("sql_cache_short",
-                                                  "get_user_ips_default"))
+                default_ips = default_ips.options(
+                    FromCache("sql_cache_short", "get_user_ips_default"))
 
             # populate from default user
             for ip in default_ips:
@@ -1059,8 +1061,8 b' class AuthUser(object):'
 
         user_ips = UserIpMap.query().filter(UserIpMap.user_id == user_id)
         if cache:
-            user_ips = user_ips.options(FromCache("sql_cache_short",
-                                                  "get_user_ips_%s" % user_id))
+            user_ips = user_ips.options(
+                FromCache("sql_cache_short", "get_user_ips_%s" % user_id))
 
         for ip in user_ips:
             try:
@@ -1114,6 +1116,17 b' def get_csrf_token(session=None, force_n'
     return session.get(csrf_token_key)
 
 
+def get_request(perm_class):
+    from pyramid.threadlocal import get_current_request
+    pyramid_request = get_current_request()
+    if not pyramid_request:
+        # return global request of pylons in case pyramid isn't available
+        # NOTE(marcink): this should be removed after migration to pyramid
+        from pylons import request
+        return request
+    return pyramid_request
+
+
 # CHECK DECORATORS
 class CSRFRequired(object):
     """
@@ -1144,7 +1157,12 b' class CSRFRequired(object):'
         supplied_token = self._get_csrf(_request)
         return supplied_token and supplied_token == cur_token
 
+    def _get_request(self):
+        return get_request(self)
+
     def __wrapper(self, func, *fargs, **fkwargs):
+        request = self._get_request()
+
         if request.method in self.except_methods:
             return func(*fargs, **fkwargs)
 
@@ -1157,8 +1175,8 b' class CSRFRequired(object):'
             reason = 'token-missing'
             supplied_token = self._get_csrf(request)
             if supplied_token and cur_token != supplied_token:
-                reason = 'token-mismatch [%s:%s]' % (cur_token or ''[:6],
-                                                     supplied_token or ''[:6])
+                reason = 'token-mismatch [%s:%s]' % (
+                    cur_token or ''[:6], supplied_token or ''[:6])
 
             csrf_message = \
                 ("Cross-site request forgery detected, request denied. See "
@@ -1185,10 +1203,15 b' class LoginRequired(object):'
     def __call__(self, func):
         return get_cython_compat_decorator(self.__wrapper, func)
 
+    def _get_request(self):
+        return get_request(self)
+
     def __wrapper(self, func, *fargs, **fkwargs):
         from rhodecode.lib import helpers as h
         cls = fargs[0]
         user = cls._rhodecode_user
+        request = self._get_request()
+
         loc = "%s:%s" % (cls.__class__.__name__, func.__name__)
         log.debug('Starting login restriction checks for user: %s' % (user,))
         # check if our IP is allowed
@@ -1255,22 +1278,27 b' class LoginRequired(object):'
             # we preserve the get PARAM
             came_from = request.path_qs
             log.debug('redirecting to login page with %s' % (came_from,))
-            return redirect(
+            raise HTTPFound(
                 h.route_path('login', _query={'came_from': came_from}))
 
 
 class NotAnonymous(object):
     """
     Must be logged in to execute this function else
-    redirect to login page"""
+    redirect to login page
+    """
 
     def __call__(self, func):
         return get_cython_compat_decorator(self.__wrapper, func)
 
+    def _get_request(self):
+        return get_request(self)
+
     def __wrapper(self, func, *fargs, **fkwargs):
         import rhodecode.lib.helpers as h
         cls = fargs[0]
         self.user = cls._rhodecode_user
+        request = self._get_request()
 
         log.debug('Checking if user is not anonymous @%s' % cls)
 
@@ -1281,19 +1309,28 b' class NotAnonymous(object):'
             h.flash(_('You need to be a registered user to '
                       'perform this action'),
                     category='warning')
-            return redirect(
+            raise HTTPFound(
                 h.route_path('login', _query={'came_from': came_from}))
         else:
             return func(*fargs, **fkwargs)
 
 
 class XHRRequired(object):
+    # TODO(marcink): remove this in favor of the predicates in pyramid routes
+
     def __call__(self, func):
         return get_cython_compat_decorator(self.__wrapper, func)
 
+    def _get_request(self):
+        return get_request(self)
+
     def __wrapper(self, func, *fargs, **fkwargs):
+        from pylons.controllers.util import abort
+        request = self._get_request()
+
         log.debug('Checking if request is XMLHttpRequest (XHR)')
         xhr_message = 'This is not a valid XMLHttpRequest (XHR) request'
+
         if not request.is_xhr:
             abort(400, detail=xhr_message)
 
@@ -1303,9 +1340,9 b' class XHRRequired(object):'
 class HasAcceptedRepoType(object):
     """
     Check if requested repo is within given repo type aliases
+    """
 
-    TODO: anderson: not sure where to put this decorator
-    """
+    # TODO(marcink): remove this in favor of the predicates in pyramid routes
 
     def __init__(self, *repo_type_list):
         self.repo_type_list = set(repo_type_list)
@@ -1328,8 +1365,9 b' class HasAcceptedRepoType(object):'
             h.flash(h.literal(
                 _('Action not supported for %s.' % rhodecode_repo.alias)),
                 category='warning')
-            return redirect(
-                url('summary_home', repo_name=cls.rhodecode_db_repo.repo_name))
+            raise HTTPFound(
+                h.route_path('repo_summary',
+                             repo_name=cls.rhodecode_db_repo.repo_name))
 
 
 class PermsDecorator(object):
@@ -1345,12 +1383,7 b' class PermsDecorator(object):'
         return get_cython_compat_decorator(self.__wrapper, func)
 
     def _get_request(self):
-        from pyramid.threadlocal import get_current_request
-        pyramid_request = get_current_request()
-        if not pyramid_request:
-            # return global request of pylons in case pyramid isn't available
-            return request
-        return pyramid_request
+        return get_request(self)
 
     def _get_came_from(self):
         _request = self._get_request()
@@ -1377,13 +1410,13 b' class PermsDecorator(object):'
             if anonymous:
                 came_from = self._get_came_from()
                 h.flash(_('You need to be signed in to view this page'),
-                               category='warning')
+                        category='warning')
                 raise HTTPFound(
                     h.route_path('login', _query={'came_from': came_from}))
 
             else:
-                # redirect with forbidden ret code
-                raise HTTPForbidden()
+                # redirect with 404 to prevent resource discovery
+                raise HTTPNotFound()
 
     def check_permissions(self, user):
         """Dummy function for overriding"""
@@ -1429,10 +1462,16 b' class HasRepoPermissionAllDecorator(Perm'
     def check_permissions(self, user):
         perms = user.permissions
         repo_name = self._get_repo_name()
+
         try:
             user_perms = set([perms['repositories'][repo_name]])
         except KeyError:
+            log.debug('cannot locate repo with name: `%s` in permissions defs',
+                      repo_name)
             return False
+
+        log.debug('checking `%s` permissions for repo `%s`',
+                  user_perms, repo_name)
         if self.required_perms.issubset(user_perms):
             return True
         return False
@@ -1450,11 +1489,16 b' class HasRepoPermissionAnyDecorator(Perm'
     def check_permissions(self, user):
         perms = user.permissions
         repo_name = self._get_repo_name()
+
         try:
             user_perms = set([perms['repositories'][repo_name]])
         except KeyError:
+            log.debug('cannot locate repo with name: `%s` in permissions defs',
+                      repo_name)
             return False
 
+        log.debug('checking `%s` permissions for repo `%s`',
+                  user_perms, repo_name)
         if self.required_perms.intersection(user_perms):
             return True
         return False
@@ -1476,8 +1520,12 b' class HasRepoGroupPermissionAllDecorator'
         try:
             user_perms = set([perms['repositories_groups'][group_name]])
         except KeyError:
+            log.debug('cannot locate repo group with name: `%s` in permissions defs',
+                      group_name)
             return False
 
+        log.debug('checking `%s` permissions for repo group `%s`',
+                  user_perms, group_name)
         if self.required_perms.issubset(user_perms):
             return True
         return False
@@ -1496,11 +1544,16 b' class HasRepoGroupPermissionAnyDecorator'
     def check_permissions(self, user):
         perms = user.permissions
         group_name = self._get_repo_group_name()
+
         try:
             user_perms = set([perms['repositories_groups'][group_name]])
         except KeyError:
+            log.debug('cannot locate repo group with name: `%s` in permissions defs',
+                      group_name)
             return False
 
+        log.debug('checking `%s` permissions for repo group `%s`',
+                  user_perms, group_name)
         if self.required_perms.intersection(user_perms):
             return True
         return False
@@ -1575,6 +1628,7 b' class PermsFunction(object):'
         if not user:
             log.debug('Using user attribute from global request')
             # TODO: remove this someday,put as user as attribute here
+            request = self._get_request()
             user = request.user
 
         # init auth user if not already given
@@ -1603,12 +1657,7 b' class PermsFunction(object):'
             return False
 
     def _get_request(self):
-        from pyramid.threadlocal import get_current_request
-        pyramid_request = get_current_request()
-        if not pyramid_request:
-            # return global request of pylons incase pyramid one isn't available
-            return request
-        return pyramid_request
+        return get_request(self)
 
     def _get_check_scope(self, cls_name):
         return {
@@ -1673,7 +1722,8 b' class HasRepoPermissionAny(PermsFunction'
 
     def _get_repo_name(self):
         if not self.repo_name:
-            self.repo_name = get_repo_slug(request)
+            _request = self._get_request()
+            self.repo_name = get_repo_slug(_request)
         return self.repo_name
 
     def check_permissions(self, user):

rhodecode/lib/base.py

@@ -162,6 +162,10 b' def get_access_path(environ):'
     return path
 
 
+def get_user_agent(environ):
+    return environ.get('HTTP_USER_AGENT')
+
+
 def vcs_operation_context(
         environ, repo_name, username, action, scm, check_locking=True,
         is_shadow_repo=False):
@@ -200,6 +204,7 b' def vcs_operation_context('
         'make_lock': make_lock,
         'locked_by': locked_by,
         'server_url': utils2.get_server_url(environ),
+        'user_agent': get_user_agent(environ),
         'hooks': get_enabled_hook_classes(ui_settings),
         'is_shadow_repo': is_shadow_repo,
     }
@@ -260,7 +265,7 b' class BasicAuth(AuthBasicAuthenticator):'
     __call__ = authenticate
 
 
-def attach_context_attributes(context, request):
+def attach_context_attributes(context, request, user_id, attach_to_request=False):
     """
     Attach variables into template context called `c`, please note that
     request could be pylons or pyramid request in here.
@@ -302,7 +307,7 b' def attach_context_attributes(context, r'
         'rhodecode_markup_renderer', 'rst')
     context.visual.comment_types = ChangesetComment.COMMENT_TYPES
     context.visual.rhodecode_support_url = \
-        rc_config.get('rhodecode_support_url') or url('rhodecode_support')
+        rc_config.get('rhodecode_support_url') or h.route_url('rhodecode_support')
 
     context.pre_code = rc_config.get('rhodecode_pre_code')
     context.post_code = rc_config.get('rhodecode_post_code')
@@ -325,6 +330,11 b' def attach_context_attributes(context, r'
 
     context.rhodecode_instanceid = config.get('instance_id')
 
+    context.visual.cut_off_limit_diff = safe_int(
+        config.get('cut_off_limit_diff'))
+    context.visual.cut_off_limit_file = safe_int(
+        config.get('cut_off_limit_file'))
+
     # AppEnlight
     context.appenlight_enabled = str2bool(config.get('appenlight', 'false'))
     context.appenlight_api_public_key = config.get(
@@ -382,10 +392,12 b' def attach_context_attributes(context, r'
     context.csrf_token = auth.get_csrf_token()
     context.backends = rhodecode.BACKENDS.keys()
     context.backends.sort()
-    context.unread_notifications = NotificationModel().get_unread_cnt_for_user(
-        context.rhodecode_user.user_id)
+    context.unread_notifications = NotificationModel().get_unread_cnt_for_user(user_id)
+    if attach_to_request:
+        request.call_context = context
+    else:
+        context.pyramid_request = pyramid.threadlocal.get_current_request()
 
-    context.pyramid_request = pyramid.threadlocal.get_current_request()
 
 
 def get_auth_user(environ):
@@ -435,7 +447,7 b' class BaseController(WSGIController):'
         """
         # on each call propagate settings calls into global settings.
         set_rhodecode_config(config)
-        attach_context_attributes(c, request)
+        attach_context_attributes(c, request, c.rhodecode_user.user_id)
 
         # TODO: Remove this when fixed in attach_context_attributes()
         c.repo_name = get_repo_slug(request)  # can be empty
@@ -550,7 +562,7 b' class BaseRepoController(BaseController)'
                     "The repository at %(repo_name)s cannot be located.") %
                     {'repo_name': c.repo_name},
                     category='error', ignore_duplicate=True)
-                redirect(url('home'))
+                redirect(h.route_path('home'))
 
             # update last change according to VCS data
             if not missing_requirements:
@@ -577,7 +589,7 b' class BaseRepoController(BaseController)'
             'Requirements are missing for repository %s: %s',
             c.repo_name, error.message)
 
-        summary_url = url('summary_home', repo_name=c.repo_name)
+        summary_url = h.route_path('repo_summary', repo_name=c.repo_name)
         statistics_url = url('edit_repo_statistics', repo_name=c.repo_name)
         settings_update_url = url('repo', repo_name=c.repo_name)
         path = request.path

rhodecode/lib/celerylib/tasks.py

@@ -31,12 +31,13 b' from celery.task import task'
 from pylons import config
 
 import rhodecode
+from rhodecode.lib import audit_logger
 from rhodecode.lib.celerylib import (
     run_task, dbsession, __get_lockkey, LockHeld, DaemonLock,
     get_session, vcsconnection, RhodecodeCeleryTask)
 from rhodecode.lib.hooks_base import log_create_repository
 from rhodecode.lib.rcmail.smtp_mailer import SmtpMailer
-from rhodecode.lib.utils import add_cache, action_logger
+from rhodecode.lib.utils import add_cache
 from rhodecode.lib.utils2 import safe_int, str2bool
 from rhodecode.model.db import Repository, User
 
@@ -141,7 +142,7 b' def create_repo(form_data, cur_user):'
         'enable_downloads', defs.get('repo_enable_downloads'))
 
     try:
-        RepoModel(DBS)._create_repo(
+        repo = RepoModel(DBS)._create_repo(
             repo_name=repo_name_full,
             repo_type=repo_type,
             description=description,
@@ -158,8 +159,6 b' def create_repo(form_data, cur_user):'
             enable_downloads=enable_downloads,
             state=state
         )
-
-        action_logger(cur_user, 'user_created_repo', repo_name_full, '', DBS)
         DBS.commit()
 
         # now create this repo on Filesystem
@@ -177,6 +176,14 b' def create_repo(form_data, cur_user):'
 
         # set new created state
         repo.set_state(Repository.STATE_CREATED)
+        repo_id = repo.repo_id
+        repo_data = repo.get_api_data()
+
+        audit_logger.store(
+            'repo.create', action_data={'data': repo_data},
+            user=cur_user,
+            repo=audit_logger.RepoWrap(repo_name=repo_name, repo_id=repo_id))
+
         DBS.commit()
     except Exception:
         log.warning('Exception occurred when creating repository, '
@@ -240,8 +247,7 b' def create_repo_fork(form_data, cur_user'
             fork_of=fork_of,
             copy_fork_permissions=copy_fork_permissions
         )
-        action_logger(cur_user, 'user_forked_repo:%s' % repo_name_full,
-                      fork_of.repo_name, '', DBS)
+
         DBS.commit()
 
         base_path = Repository.base_path()
@@ -264,6 +270,14 b' def create_repo_fork(form_data, cur_user'
 
         # set new created state
         repo.set_state(Repository.STATE_CREATED)
+
+        repo_id = repo.repo_id
+        repo_data = repo.get_api_data()
+        audit_logger.store(
+            'repo.fork', action_data={'data': repo_data},
+            user=cur_user,
+            repo=audit_logger.RepoWrap(repo_name=repo_name, repo_id=repo_id))
+
         DBS.commit()
     except Exception as e:
         log.warning('Exception %s occurred when forking repository, '

rhodecode/lib/channelstream.py

@@ -77,8 +77,8 b' def get_user_data(user_id):'
     return {
         'id': user.user_id,
         'username': user.username,
-        'first_name': user.name,
-        'last_name': user.lastname,
+        'first_name': user.first_name,
+        'last_name': user.last_name,
         'icon_link': h.gravatar_url(user.email, 60),
         'display_name': h.person(user, 'username_or_name_or_email'),
         'display_link': h.link_to_user(user),

rhodecode/lib/codeblocks.py

@@ -471,31 +471,29 b' class DiffSet(object):'
         source_file_type = source_lexer.name
         target_file_type = target_lexer.name
 
-        op_hunks = patch['chunks'][0]
-        hunks = patch['chunks'][1:]
-
         filediff = AttributeDict({
             'source_file_path': source_file_path,
             'target_file_path': target_file_path,
             'source_filenode': source_filenode,
             'target_filenode': target_filenode,
-            'hunks': [],
             'source_file_type': target_file_type,
             'target_file_type': source_file_type,
-            'patch': patch,
+            'patch': {'filename': patch['filename'], 'stats': patch['stats']},
+            'operation': patch['operation'],
             'source_mode': patch['stats']['old_mode'],
             'target_mode': patch['stats']['new_mode'],
             'limited_diff': isinstance(patch, LimitedDiffContainer),
+            'hunks': [],
             'diffset': self,
         })
 
-        for hunk in hunks:
+        for hunk in patch['chunks'][1:]:
             hunkbit = self.parse_hunk(hunk, source_file, target_file)
-            hunkbit.filediff = filediff
+            hunkbit.source_file_path = source_file_path
+            hunkbit.target_file_path = target_file_path
             filediff.hunks.append(hunkbit)
 
         left_comments = {}
-
         if source_file_path in self.comments_store:
             for lineno, comments in self.comments_store[source_file_path].items():
                 left_comments[lineno] = comments
@@ -503,8 +501,8 b' class DiffSet(object):'
         if target_file_path in self.comments_store:
             for lineno, comments in self.comments_store[target_file_path].items():
                 left_comments[lineno] = comments
+        filediff.left_comments = left_comments
 
-        filediff.left_comments = left_comments
         return filediff
 
     def parse_hunk(self, hunk, source_file, target_file):
@@ -519,6 +517,7 b' class DiffSet(object):'
         before, after = [], []
 
         for line in hunk['lines']:
+
             if line['action'] == 'unmod':
                 result.lines.extend(
                     self.parse_lines(before, after, source_file, target_file))
@@ -567,7 +566,8 b' class DiffSet(object):'
                     before_tokens = [('nonl', before['line'])]
                 else:
                     before_tokens = self.get_line_tokens(
-                        line_text=before['line'], line_number=before['old_lineno'],
+                        line_text=before['line'],
+                        line_number=before['old_lineno'],
                         file=source_file)
                 original.lineno = before['old_lineno']
                 original.content = before['line']

rhodecode/lib/db_manage.py

@@ -319,6 +319,7 b' class DbManage(object):'
             (RhodeCodeUi.HOOK_PRE_PUSH, 'python:vcsserver.hooks.pre_push'),
             (RhodeCodeUi.HOOK_PRETX_PUSH, 'python:vcsserver.hooks.pre_push'),
             (RhodeCodeUi.HOOK_PUSH, 'python:vcsserver.hooks.log_push_action'),
+            (RhodeCodeUi.HOOK_PUSH_KEY, 'python:vcsserver.hooks.key_push'),
 
         ]
 
@@ -363,6 +364,14 b' class DbManage(object):'
         hgsubversion.ui_active = False
         self.sa.add(hgsubversion)
 
+        # enable hgevolve disabled by default
+        hgevolve = RhodeCodeUi()
+        hgevolve.ui_section = 'extensions'
+        hgevolve.ui_key = 'evolve'
+        hgevolve.ui_value = ''
+        hgevolve.ui_active = False
+        self.sa.add(hgevolve)
+
         # enable hggit disabled by default
         hggit = RhodeCodeUi()
         hggit.ui_section = 'extensions'

rhodecode/lib/helpers.py

@@ -36,6 +36,8 b' import urlparse'
 import time
 import string
 import hashlib
+from collections import OrderedDict
+
 import pygments
 import itertools
 import fnmatch
@@ -891,8 +893,9 b' def author_string(email):'
     if email:
         user = User.get_by_email(email, case_insensitive=True, cache=True)
         if user:
-            if user.firstname or user.lastname:
-                return '%s %s <%s>' % (user.firstname, user.lastname, email)
+            if user.first_name or user.last_name:
+                return '%s %s <%s>' % (
+                    user.first_name, user.last_name, email)
             else:
                 return email
         else:
@@ -1141,14 +1144,14 b' class InitialsGravatar(object):'
         # first push the email initials
         prefix, server = email_address.split('@', 1)
 
-        # check if prefix is maybe a 'firstname.lastname' syntax
+        # check if prefix is maybe a 'first_name.last_name' syntax
         _dot_split = prefix.rsplit('.', 1)
         if len(_dot_split) == 2:
             initials = [_dot_split[0][0], _dot_split[1][0]]
         else:
             initials = [prefix[0], server[0]]
 
-        # then try to replace either firtname or lastname
+        # then try to replace either first_name or last_name
         fn_letter = (first_name or " ")[0].strip()
         ln_letter = (last_name.split(' ', 1)[-1] or " ")[0].strip()
 
@@ -1245,12 +1248,19 b' def initials_gravatar(email_address, fir'
     return klass.generate_svg(svg_type=svg_type)
 
 
-def gravatar_url(email_address, size=30):
-    # doh, we need to re-import those to mock it later
-    from pylons import tmpl_context as c
+def gravatar_url(email_address, size=30, request=None):
+    request = get_current_request()
+    if request and hasattr(request, 'call_context'):
+        _use_gravatar = request.call_context.visual.use_gravatar
+        _gravatar_url = request.call_context.visual.gravatar_url
+    else:
+        # doh, we need to re-import those to mock it later
+        from pylons import tmpl_context as c
 
-    _use_gravatar = c.visual.use_gravatar
-    _gravatar_url = c.visual.gravatar_url or User.DEFAULT_GRAVATAR_URL
+        _use_gravatar = c.visual.use_gravatar
+        _gravatar_url = c.visual.gravatar_url
+
+    _gravatar_url = _gravatar_url or User.DEFAULT_GRAVATAR_URL
 
     email_address = email_address or User.DEFAULT_USER_EMAIL
     if isinstance(email_address, unicode):
@@ -1532,10 +1542,10 b' def breadcrumb_repo_link(repo):'
     """
 
     path = [
-        link_to(group.name, url('repo_group_home', group_name=group.group_name))
+        link_to(group.name, route_path('repo_group_home', repo_group_name=group.group_name))
         for group in repo.groups_with_parents
     ] + [
-        link_to(repo.just_name, url('summary_home', repo_name=repo.repo_name))
+        link_to(repo.just_name, route_path('repo_summary', repo_name=repo.repo_name))
     ]
 
     return literal(' » '.join(path))
@@ -1602,16 +1612,24 b' def urlify_commits(text_, repository):'
 
 
 def _process_url_func(match_obj, repo_name, uid, entry,
-                      return_raw_data=False):
+                      return_raw_data=False, link_format='html'):
     pref = ''
     if match_obj.group().startswith(' '):
         pref = ' '
 
     issue_id = ''.join(match_obj.groups())
-    tmpl = (
-        '%(pref)s<a class="%(cls)s" href="%(url)s">'
-        '%(issue-prefix)s%(id-repr)s'
-        '</a>')
+
+    if link_format == 'html':
+        tmpl = (
+            '%(pref)s<a class="%(cls)s" href="%(url)s">'
+            '%(issue-prefix)s%(id-repr)s'
+            '</a>')
+    elif link_format == 'rst':
+        tmpl = '`%(issue-prefix)s%(id-repr)s <%(url)s>`_'
+    elif link_format == 'markdown':
+        tmpl = '[%(issue-prefix)s%(id-repr)s](%(url)s)'
+    else:
+        raise ValueError('Bad link_format:{}'.format(link_format))
 
     (repo_name_cleaned,
      parent_group_name) = RepoGroupModel().\
@@ -1644,7 +1662,12 b' def _process_url_func(match_obj, repo_na'
     return tmpl % data
 
 
-def process_patterns(text_string, repo_name, config=None):
+def process_patterns(text_string, repo_name, link_format='html'):
+    allowed_formats = ['html', 'rst', 'markdown']
+    if link_format not in allowed_formats:
+        raise ValueError('Link format can be only one of:{} got {}'.format(
+                         allowed_formats, link_format))
+
     repo = None
     if repo_name:
         # Retrieving repo_name to avoid invalid repo_name to explode on
@@ -1656,6 +1679,7 b' def process_patterns(text_string, repo_n'
 
     issues_data = []
     newtext = text_string
+
     for uid, entry in active_entries.items():
         log.debug('found issue tracker entry with uid %s' % (uid,))
 
@@ -1682,7 +1706,8 b' def process_patterns(text_string, repo_n'
             issues_data.append(data_func(match_obj))
 
         url_func = partial(
-            _process_url_func, repo_name=repo_name, entry=entry, uid=uid)
+            _process_url_func, repo_name=repo_name, entry=entry, uid=uid,
+            link_format=link_format)
 
         newtext = pattern.sub(url_func, newtext)
         log.debug('processed prefix:uid `%s`' % (uid,))
@@ -1750,7 +1775,8 b' def renderer_from_filename(filename, exc'
     return None
 
 
-def render(source, renderer='rst', mentions=False, relative_url=None):
+def render(source, renderer='rst', mentions=False, relative_url=None,
+           repo_name=None):
 
     def maybe_convert_relative_links(html_source):
         if relative_url:
@@ -1758,11 +1784,21 b" def render(source, renderer='rst', menti"
         return html_source
 
     if renderer == 'rst':
+        if repo_name:
+            # process patterns on comments if we pass in repo name
+            source, issues = process_patterns(
+                source, repo_name, link_format='rst')
+
         return literal(
             '<div class="rst-block">%s</div>' %
             maybe_convert_relative_links(
                 MarkupRenderer.rst(source, mentions=mentions)))
     elif renderer == 'markdown':
+        if repo_name:
+            # process patterns on comments if we pass in repo name
+            source, issues = process_patterns(
+                source, repo_name, link_format='markdown')
+
         return literal(
             '<div class="markdown-block">%s</div>' %
             maybe_convert_relative_links(
@@ -1801,6 +1837,7 b' def journal_filter_help():'
         'Example filter terms:\n' +
         '     repository:vcs\n' +
         '     username:marcin\n' +
+        '     username:(NOT marcin)\n' +
         '     action:*push*\n' +
         '     ip:127.0.0.1\n' +
         '     date:20120101\n' +
@@ -1816,6 +1853,24 b' def journal_filter_help():'
     )
 
 
+def search_filter_help(searcher):
+
+    terms = ''
+    return _(
+        'Example filter terms for `{searcher}` search:\n' +
+        '{terms}\n' +
+        'Generate wildcards using \'*\' character:\n' +
+        '     "repo_name:vcs*" - search everything starting with \'vcs\'\n' +
+        '     "repo_name:*vcs*" - search for repository containing \'vcs\'\n' +
+        '\n' +
+        'Optional AND / OR operators in queries\n' +
+        '     "repo_name:vcs OR repo_name:test"\n' +
+        '     "owner:test AND repo_name:test*"\n' +
+        'More: {search_doc}'
+    ).format(searcher=searcher.name,
+             terms=terms, search_doc=searcher.query_lang_doc)
+
+
 def not_mapped_error(repo_name):
     flash(_('%s repository is not mapped to db perhaps'
             ' it was created or renamed from the filesystem'
@@ -1914,24 +1969,24 b' def get_last_path_part(file_node):'
     return u'../' + path
 
 
-def route_url(*args, **kwds):
+def route_url(*args, **kwargs):
     """
-    Wrapper around pyramids `route_url` function. It is used to generate
-    URLs from within pylons views or templates. This will be removed when
-    pyramid migration if finished.
+    Wrapper around pyramids `route_url` (fully qualified url) function. 
+    It is used to generate URLs from within pylons views or templates. 
+    This will be removed when pyramid migration if finished.
     """
     req = get_current_request()
-    return req.route_url(*args, **kwds)
+    return req.route_url(*args, **kwargs)
 
 
-def route_path(*args, **kwds):
+def route_path(*args, **kwargs):
     """
     Wrapper around pyramids `route_path` function. It is used to generate
     URLs from within pylons views or templates. This will be removed when
     pyramid migration if finished.
     """
     req = get_current_request()
-    return req.route_path(*args, **kwds)
+    return req.route_path(*args, **kwargs)
 
 
 def route_path_or_none(*args, **kwargs):
@@ -1959,3 +2014,23 b' def resource_path(*args, **kwds):'
     """
     req = get_current_request()
     return req.resource_path(*args, **kwds)
+
+
+def api_call_example(method, args):
+    """
+    Generates an API call example via CURL
+    """
+    args_json = json.dumps(OrderedDict([
+        ('id', 1),
+        ('auth_token', 'SECRET'),
+        ('method', method),
+        ('args', args)
+    ]))
+    return literal(
+        "curl {api_url} -X POST -H 'content-type:text/plain' --data-binary '{data}'"
+        "<br/><br/>SECRET can be found in <a href=\"{token_url}\">auth-tokens</a> page, "
+        "and needs to be of `api calls` role."
+        .format(
+            api_url=route_url('apiv2'),
+            token_url=route_url('my_account_auth_tokens'),
+            data=args_json))

rhodecode/lib/hooks_base.py

@@ -30,7 +30,7 b' import logging'
 import rhodecode
 from rhodecode import events
 from rhodecode.lib import helpers as h
-from rhodecode.lib.utils import action_logger
+from rhodecode.lib import audit_logger
 from rhodecode.lib.utils2 import safe_str
 from rhodecode.lib.exceptions import HTTPLockedRC, UserCreationError
 from rhodecode.model.db import Repository, User
@@ -152,9 +152,15 b' def pre_pull(extras):'
 
 def post_pull(extras):
     """Hook executed after client pulls the code."""
-    user = User.get_by_username(extras.username)
-    action = 'pull'
-    action_logger(user, action, extras.repository, extras.ip, commit=True)
+
+    audit_user = audit_logger.UserWrap(
+        username=extras.username,
+        ip_addr=extras.ip)
+    repo = audit_logger.RepoWrap(repo_name=extras.repository)
+    audit_logger.store(
+        'user.pull', action_data={
+            'user_agent': extras.user_agent},
+        user=audit_user, repo=repo, commit=True)
 
     # Propagate to external components.
     if not is_shadow_repo(extras):
@@ -165,6 +171,7 b' def post_pull(extras):'
     output = ''
     # make lock is a tri state False, True, None. We only make lock on True
     if extras.make_lock is True and not is_shadow_repo(extras):
+        user = User.get_by_username(extras.username)
         Repository.lock(Repository.get_by_repo_name(extras.repository),
                         user.user_id,
                         lock_reason=Repository.LOCK_PULL)
@@ -185,12 +192,17 b' def post_pull(extras):'
 
 def post_push(extras):
     """Hook executed after user pushes to the repository."""
-    action_tmpl = extras.action + ':%s'
-    commit_ids = extras.commit_ids[:29000]
+    commit_ids = extras.commit_ids
 
-    action = action_tmpl % ','.join(commit_ids)
-    action_logger(
-        extras.username, action, extras.repository, extras.ip, commit=True)
+    # log the push call
+    audit_user = audit_logger.UserWrap(
+        username=extras.username, ip_addr=extras.ip)
+    repo = audit_logger.RepoWrap(repo_name=extras.repository)
+    audit_logger.store(
+        'user.push', action_data={
+            'user_agent': extras.user_agent,
+            'commit_ids': commit_ids[:10000]},
+        user=audit_user, repo=repo, commit=True)
 
     # Propagate to external components.
     if not is_shadow_repo(extras):
@@ -220,8 +232,20 b' def post_push(extras):'
             # 2xx Codes don't raise exceptions
             output += _http_ret.title
 
+    if extras.new_refs:
+        tmpl = \
+            extras.server_url + '/' + \
+            extras.repository + \
+            "/pull-request/new?{ref_type}={ref_name}"
+        for branch_name in extras.new_refs['branches']:
+            output += 'RhodeCode: open pull request link: {}\n'.format(
+                tmpl.format(ref_type='branch', ref_name=branch_name))
+
+        for book_name in extras.new_refs['bookmarks']:
+            output += 'RhodeCode: open pull request link: {}\n'.format(
+                tmpl.format(ref_type='bookmark', ref_name=book_name))
+
     output += 'RhodeCode: push completed\n'
-
     return HookResponse(0, output)
 
 

rhodecode/lib/index/__init__.py

@@ -33,6 +33,8 b" default_location = '%(here)s/data/index'"
 
 
 class BaseSearch(object):
+    query_lang_doc = ''
+
     def __init__(self):
         pass
 

rhodecode/lib/index/whoosh.py

@@ -61,7 +61,8 b' log = logging.getLogger(__name__)'
 
 
 class Search(BaseSearch):
-
+    # this also shows in UI
+    query_lang_doc = 'http://whoosh.readthedocs.io/en/latest/querylang.html'
     name = 'whoosh'
 
     def __init__(self, config):

rhodecode/lib/markup_renderer.py

@@ -34,6 +34,8 b' from mako.template import Template as Ma'
 
 from docutils.core import publish_parts
 from docutils.parsers.rst import directives
+from docutils import writers
+from docutils.writers import html4css1
 import markdown
 
 from rhodecode.lib.markdown_ext import GithubFlavoredMarkdownExtension
@@ -46,6 +48,31 b' log = logging.getLogger(__name__)'
 DEFAULT_COMMENTS_RENDERER = 'rst'
 
 
+class CustomHTMLTranslator(writers.html4css1.HTMLTranslator):
+    """
+    Custom HTML Translator used for sandboxing potential
+    JS injections in ref links
+    """
+
+    def visit_reference(self, node):
+        if 'refuri' in node.attributes:
+            refuri = node['refuri']
+            if ':' in refuri:
+                prefix, link = refuri.lstrip().split(':', 1)
+                if prefix == 'javascript':
+                    # we don't allow javascript type of refs...
+                    node['refuri'] = 'javascript:alert("SandBoxedJavascript")'
+
+        # old style class requires this...
+        return html4css1.HTMLTranslator.visit_reference(self, node)
+
+
+class RhodeCodeWriter(writers.html4css1.Writer):
+    def __init__(self):
+        writers.Writer.__init__(self)
+        self.translator_class = CustomHTMLTranslator
+
+
 def relative_links(html_source, server_path):
     if not html_source:
         return html_source
@@ -56,12 +83,12 b' def relative_links(html_source, server_p'
         return html_source
 
     for el in doc.cssselect('img, video'):
-        src = el.attrib['src']
+        src = el.attrib.get('src')
         if src:
             el.attrib['src'] = relative_path(src, server_path)
 
     for el in doc.cssselect('a:not(.gfm)'):
-        src = el.attrib['href']
+        src = el.attrib.get('href')
         if src:
             el.attrib['href'] = relative_path(src, server_path)
 
@@ -341,7 +368,7 b' class MarkupRenderer(object):'
                 directives.register_directive(k, v)
 
             parts = publish_parts(source=source,
-                                  writer_name="html4css1",
+                                  writer=RhodeCodeWriter(),
                                   settings_overrides=docutils_settings)
 
             return parts['html_title'] + parts["fragment"]

rhodecode/lib/middleware/simplevcs.py

@@ -36,7 +36,8 b' from webob.exc import ('
 import rhodecode
 from rhodecode.authentication.base import authenticate, VCS_TYPE
 from rhodecode.lib.auth import AuthUser, HasPermissionAnyMiddleware
-from rhodecode.lib.base import BasicAuth, get_ip_addr, vcs_operation_context
+from rhodecode.lib.base import (
+    BasicAuth, get_ip_addr, get_user_agent, vcs_operation_context)
 from rhodecode.lib.exceptions import (
     HTTPLockedRC, HTTPRequirementError, UserCreationError,
     NotAllowedToCreateUserError)
@@ -310,6 +311,7 b' class SimpleVCS(object):'
         log.debug('Extracted repo name is %s', self.url_repo_name)
 
         ip_addr = get_ip_addr(environ)
+        user_agent = get_user_agent(environ)
         username = None
 
         # skip passing error to error controller
@@ -429,9 +431,9 b' class SimpleVCS(object):'
         fix_PATH()
 
         log.info(
-            '%s action on %s repo "%s" by "%s" from %s',
+            '%s action on %s repo "%s" by "%s" from %s %s',
             action, self.SCM, safe_str(self.url_repo_name),
-            safe_str(username), ip_addr)
+            safe_str(username), ip_addr, user_agent)
 
         return self._generate_vcs_response(
             environ, start_response, repo_path, extras, action)

rhodecode/lib/rcmail/message.py

@@ -114,14 +114,18 b' class Message(object):'
 
         return response
 
+    def _get_headers(self):
+        headers = [self.subject, self.sender]
+        headers += list(self.send_to)
+        headers += self.extra_headers.values()
+        return headers
+
     def is_bad_headers(self):
         """
         Checks for bad headers i.e. newlines in subject, sender or recipients.
         """
 
-        headers = [self.subject, self.sender]
-        headers += list(self.send_to)
-        headers += self.extra_headers.values()
+        headers = self._get_headers()
 
         for val in headers:
             for c in '\r\n':
@@ -144,7 +148,8 b' class Message(object):'
             raise InvalidMessage("No sender address has been set")
 
         if self.is_bad_headers():
-            raise BadHeaders
+            headers = self._get_headers()
+            raise BadHeaders(headers)
 
     def add_recipient(self, recipient):
         """

rhodecode/lib/repo_maintenance.py

@@ -83,6 +83,15 b' class HGVerify(MaintenanceTask):'
         return res
 
 
+class SVNVerify(MaintenanceTask):
+    human_name = 'SVN Verify repo'
+
+    def run(self):
+        instance = self.db_repo.scm_instance()
+        res = instance.verify()
+        return res
+
+
 class RepoMaintenance(object):
     """
     Performs maintenance of repository based on it's type
@@ -90,7 +99,7 b' class RepoMaintenance(object):'
     tasks = {
         'hg': [HGVerify],
         'git': [GitGC],
-        'svn': [],
+        'svn': [SVNVerify],
     }
 
     def get_tasks_for_repo(self, db_repo):

rhodecode/lib/system_info.py

@@ -570,6 +570,10 b' def rhodecode_config():'
         log.exception('Failed to read .ini file for display')
         parsed_ini = {}
 
+    cert_path = os.path.join(
+        os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(path)))),
+        '.rccontrol-profile/etc/ca-bundle.crt')
+
     rhodecode_ini_safe['server:main'] = parsed_ini
 
     blacklist = [
@@ -608,7 +612,8 b' def rhodecode_config():'
             rhodecode_ini_safe.pop(k, None)
 
     # TODO: maybe put some CONFIG checks here ?
-    return SysInfoRes(value={'config': rhodecode_ini_safe, 'path': path})
+    return SysInfoRes(value={'config': rhodecode_ini_safe,
+                             'path': path, 'cert_path': cert_path})
 
 
 def database_info():

rhodecode/lib/user_log_filter.py

@@ -23,10 +23,10 b' import logging'
 from whoosh.qparser.default import QueryParser, query
 from whoosh.qparser.dateparse import DateParserPlugin
 from whoosh.fields import (TEXT, Schema, DATETIME)
-from sqlalchemy.sql.expression import or_, and_, func
+from sqlalchemy.sql.expression import or_, and_, not_, func
 
 from rhodecode.model.db import UserLog
-from rhodecode.lib.utils2 import remove_prefix, remove_suffix
+from rhodecode.lib.utils2 import remove_prefix, remove_suffix, safe_unicode
 
 # JOURNAL SCHEMA used only to generate queries in journal. We use whoosh
 # querylang to build sql queries and filter journals
@@ -54,7 +54,7 b' def user_log_filter(user_log, search_ter'
     if search_term:
         qp = QueryParser('repository', schema=JOURNAL_SCHEMA)
         qp.add_plugin(DateParserPlugin())
-        qry = qp.parse(unicode(search_term))
+        qry = qp.parse(safe_unicode(search_term))
         log.debug('Filtering using parsed query %r' % qry)
 
     def wildcard_handler(col, wc_term):
@@ -89,16 +89,27 b' def user_log_filter(user_log, search_ter'
             return func.lower(field).startswith(func.lower(val))
         elif isinstance(term, query.DateRange):
             return and_(field >= val[0], field <= val[1])
+        elif isinstance(term, query.Not):
+            return not_(field == val)
         return func.lower(field) == func.lower(val)
 
-    if isinstance(qry, (query.And, query.Term, query.Prefix, query.Wildcard,
-                        query.DateRange)):
+    if isinstance(qry, (query.And, query.Not, query.Term, query.Prefix,
+                        query.Wildcard, query.DateRange)):
         if not isinstance(qry, query.And):
             qry = [qry]
+
         for term in qry:
-            field = term.fieldname
-            val = (term.text if not isinstance(term, query.DateRange)
-                   else [term.startdate, term.enddate])
+            if isinstance(term, query.Not):
+                not_term = [z for z in term.leaves()][0]
+                field = not_term.fieldname
+                val = not_term.text
+            elif isinstance(term, query.DateRange):
+                field = term.fieldname
+                val = [term.startdate, term.enddate]
+            else:
+                field = term.fieldname
+                val = term.text
+
             user_log = user_log.filter(get_filterion(field, val, term))
     elif isinstance(qry, query.Or):
         filters = []

rhodecode/lib/utils.py

@@ -96,10 +96,11 b' def repo_name_slug(value):'
 # PERM DECORATOR HELPERS FOR EXTRACTING NAMES FOR PERM CHECKS
 #==============================================================================
 def get_repo_slug(request):
-    if isinstance(request, Request) and getattr(request, 'matchdict', None):
+    if isinstance(request, Request) and getattr(request, 'db_repo', None):
         # pyramid
-        _repo = request.matchdict.get('repo_name')
+        _repo = request.db_repo.repo_name
     else:
+        # TODO(marcink): remove after pylons migration...
         _repo = request.environ['pylons.routes_dict'].get('repo_name')
 
     if _repo:
@@ -110,7 +111,7 b' def get_repo_slug(request):'
 def get_repo_group_slug(request):
     if isinstance(request, Request) and getattr(request, 'matchdict', None):
         # pyramid
-        _group = request.matchdict.get('group_name')
+        _group = request.matchdict.get('repo_group_name')
     else:
         _group = request.environ['pylons.routes_dict'].get('group_name')
 
@@ -138,68 +139,6 b' def get_user_group_slug(request):'
     return _group
 
 
-def action_logger(user, action, repo, ipaddr='', sa=None, commit=False):
-    """
-    Action logger for various actions made by users
-
-    :param user: user that made this action, can be a unique username string or
-        object containing user_id attribute
-    :param action: action to log, should be on of predefined unique actions for
-        easy translations
-    :param repo: string name of repository or object containing repo_id,
-        that action was made on
-    :param ipaddr: optional ip address from what the action was made
-    :param sa: optional sqlalchemy session
-
-    """
-
-    if not sa:
-        sa = meta.Session()
-    # if we don't get explicit IP address try to get one from registered user
-    # in tmpl context var
-    if not ipaddr:
-        ipaddr = getattr(get_current_rhodecode_user(), 'ip_addr', '')
-
-    try:
-        if getattr(user, 'user_id', None):
-            user_obj = User.get(user.user_id)
-        elif isinstance(user, basestring):
-            user_obj = User.get_by_username(user)
-        else:
-            raise Exception('You have to provide a user object or a username')
-
-        if getattr(repo, 'repo_id', None):
-            repo_obj = Repository.get(repo.repo_id)
-            repo_name = repo_obj.repo_name
-        elif isinstance(repo, basestring):
-            repo_name = repo.lstrip('/')
-            repo_obj = Repository.get_by_repo_name(repo_name)
-        else:
-            repo_obj = None
-            repo_name = ''
-
-        user_log = UserLog()
-        user_log.user_id = user_obj.user_id
-        user_log.username = user_obj.username
-        action = safe_unicode(action)
-        user_log.action = action[:1200000]
-
-        user_log.repository = repo_obj
-        user_log.repository_name = repo_name
-
-        user_log.action_date = datetime.datetime.now()
-        user_log.user_ip = ipaddr
-        sa.add(user_log)
-
-        log.info('Logging action:`%s` on repo:`%s` by user:%s ip:%s',
-                 action, safe_unicode(repo), user_obj, ipaddr)
-        if commit:
-            sa.commit()
-    except Exception:
-        log.error(traceback.format_exc())
-        raise
-
-
 def get_filesystem_repos(path, recursive=False, skip_removed_repos=True):
     """
     Scans given path for repos and return (name,(type,path)) tuple
@@ -428,6 +367,7 b' def config_data_from_db(clear_session=Tr'
     if 'push' not in enabled_hook_classes:
         skip_entries.append(('hooks', RhodeCodeUi.HOOK_PRE_PUSH))
         skip_entries.append(('hooks', RhodeCodeUi.HOOK_PRETX_PUSH))
+        skip_entries.append(('hooks', RhodeCodeUi.HOOK_PUSH_KEY))
 
     config = [entry for entry in config if entry[:2] not in skip_entries]
 

rhodecode/lib/utils2.py

@@ -572,7 +572,8 b' def credentials_filter(uri):'
     return ''.join(uri)
 
 
-def get_clone_url(uri_tmpl, qualifed_home_url, repo_name, repo_id, **override):
+def get_clone_url(request, uri_tmpl, repo_name, repo_id, **override):
+    qualifed_home_url = request.route_url('home')
     parsed_url = urlobject.URLObject(qualifed_home_url)
     decoded_path = safe_unicode(urllib.unquote(parsed_url.path.rstrip('/')))
     args = {

rhodecode/lib/vcs/backends/base.py

@@ -130,7 +130,7 b' class UpdateFailureReason(object):'
     NO_CHANGE = 2
 
     # The pull request has a reference type that is not supported for update.
-    WRONG_REF_TPYE = 3
+    WRONG_REF_TYPE = 3
 
     # Update failed because the target reference is missing.
     MISSING_TARGET_REF = 4
@@ -1065,8 +1065,8 b' class BaseCommit(object):'
 
     def no_node_at_path(self, path):
         return NodeDoesNotExistError(
-            "There is no file nor directory at the given path: "
-            "'%s' at commit %s" % (path, self.short_id))
+            u"There is no file nor directory at the given path: "
+            u"`%s` at commit %s" % (safe_unicode(path), self.short_id))
 
     def _fix_path(self, path):
         """

rhodecode/lib/vcs/backends/hg/commit.py

@@ -160,6 +160,27 b' class MercurialCommit(base.BaseCommit):'
         return self._make_commits(parents)
 
     @LazyProperty
+    def phase(self):
+        phase_id = self._remote.ctx_phase(self.idx)
+        phase_text = {
+            0: 'public',
+            1: 'draft',
+            2: 'secret',
+        }.get(phase_id) or ''
+
+        return safe_unicode(phase_text)
+
+    @LazyProperty
+    def obsolete(self):
+        obsolete = self._remote.ctx_obsolete(self.idx)
+        return obsolete
+
+    @LazyProperty
+    def hidden(self):
+        hidden = self._remote.ctx_hidden(self.idx)
+        return hidden
+
+    @LazyProperty
     def children(self):
         """
         Returns list of child commits.

rhodecode/lib/vcs/backends/svn/repository.py

@@ -158,6 +158,12 b' class SubversionRepository(base.BaseRepo'
             return commit_id1
         return commit_id2
 
+    def verify(self):
+        verify = self._remote.verify()
+
+        self._remote.invalidate_vcs_cache()
+        return verify
+
     def compare(self, commit_id1, commit_id2, repo2, merge, pre_load=None):
         # TODO: johbo: Implement better comparison, this is a very naive
         # version which does not allow to compare branches, tags or folders

rhodecode/model/auth_token.py

@@ -59,23 +59,25 b' class AuthTokenModel(BaseModel):'
 
         return new_auth_token
 
-    def delete(self, api_key, user=None):
+    def delete(self, auth_token_id, user=None):
         """
         Deletes given api_key, if user is set it also filters the object for
         deletion by given user.
         """
-        api_key = UserApiKeys.query().filter(UserApiKeys.api_key == api_key)
+        auth_token = UserApiKeys.query().filter(
+            UserApiKeys.user_api_key_id == auth_token_id)
 
         if user:
             user = self._get_user(user)
-            api_key = api_key.filter(UserApiKeys.user_id == user.user_id)
+            auth_token = auth_token.filter(UserApiKeys.user_id == user.user_id)
+            auth_token = auth_token.scalar()
 
-        api_key = api_key.scalar()
-        try:
-            Session().delete(api_key)
-        except Exception:
-            log.error(traceback.format_exc())
-            raise
+        if auth_token:
+            try:
+                Session().delete(auth_token)
+            except Exception:
+                log.error(traceback.format_exc())
+                raise
 
     def get_auth_tokens(self, user, show_expired=True):
         user = self._get_user(user)

rhodecode/model/changeset_status.py

@@ -80,7 +80,7 b' class ChangesetStatusModel(BaseModel):'
         """
         votes = defaultdict(int)
         reviewers_number = len(statuses_by_reviewers)
-        for user, reasons, statuses in statuses_by_reviewers:
+        for user, reasons, mandatory, statuses in statuses_by_reviewers:
             if statuses:
                 ver, latest = statuses[0]
                 votes[latest.status] += 1
@@ -248,13 +248,14 b' class ChangesetStatusModel(BaseModel):'
         for o in pull_request.reviewers:
             if not o.user:
                 continue
-            st = commit_statuses.get(o.user.username, None)
-            if st:
-                st = [(x, list(y)[0])
-                      for x, y in (itertools.groupby(sorted(st, key=version),
-                                                     version))]
+            statuses = commit_statuses.get(o.user.username, None)
+            if statuses:
+                statuses = [(x, list(y)[0])
+                      for x, y in (itertools.groupby(
+                        sorted(statuses, key=version),version))]
 
-            pull_request_reviewers.append((o.user, o.reasons, st))
+            pull_request_reviewers.append(
+                (o.user, o.reasons, o.mandatory, statuses))
         return pull_request_reviewers
 
     def calculated_review_status(self, pull_request, reviewers_statuses=None):

rhodecode/model/comment.py

@@ -29,14 +29,14 b' import collections'
 from datetime import datetime
 
 from pylons.i18n.translation import _
-from pyramid.threadlocal import get_current_registry
+from pyramid.threadlocal import get_current_registry, get_current_request
 from sqlalchemy.sql.expression import null
 from sqlalchemy.sql.functions import coalesce
 
 from rhodecode.lib import helpers as h, diffs
+from rhodecode.lib import audit_logger
 from rhodecode.lib.channelstream import channelstream_request
-from rhodecode.lib.utils import action_logger
-from rhodecode.lib.utils2 import extract_mentioned_users
+from rhodecode.lib.utils2 import extract_mentioned_users, safe_str
 from rhodecode.model import BaseModel
 from rhodecode.model.db import (
     ChangesetComment, User, Notification, PullRequest, AttributeDict)
@@ -163,6 +163,13 b' class CommentsModel(BaseModel):'
 
         return todos
 
+    def _log_audit_action(self, action, action_data, user, comment):
+        audit_logger.store(
+            action=action,
+            action_data=action_data,
+            user=user,
+            repo=comment.repo)
+
     def create(self, text, repo, user, commit_id=None, pull_request=None,
                f_path=None, line_no=None, status_change=None,
                status_change_type=None, comment_type=None,
@@ -268,8 +275,7 b' class CommentsModel(BaseModel):'
 
             target_repo_url = h.link_to(
                 repo.repo_name,
-                h.url('summary_home',
-                      repo_name=repo.repo_name, qualified=True))
+                h.route_url('repo_summary', repo_name=repo.repo_name))
 
             # commit specifics
             kwargs.update({
@@ -300,13 +306,11 b' class CommentsModel(BaseModel):'
                 qualified=True,)
 
             # set some variables for email notification
-            pr_target_repo_url = h.url(
-                'summary_home', repo_name=pr_target_repo.repo_name,
-                qualified=True)
+            pr_target_repo_url = h.route_url(
+                'repo_summary', repo_name=pr_target_repo.repo_name)
 
-            pr_source_repo_url = h.url(
-                'summary_home', repo_name=pr_source_repo.repo_name,
-                qualified=True)
+            pr_source_repo_url = h.route_url(
+                'repo_summary', repo_name=pr_source_repo.repo_name)
 
             # pull request specifics
             kwargs.update({
@@ -340,13 +344,15 b' class CommentsModel(BaseModel):'
                 email_kwargs=kwargs,
             )
 
-        action = (
-            'user_commented_pull_request:{}'.format(
-                comment.pull_request.pull_request_id)
-            if comment.pull_request
-            else 'user_commented_revision:{}'.format(comment.revision)
-        )
-        action_logger(user, action, comment.repo)
+        Session().flush()
+        if comment.pull_request:
+            action = 'repo.pull_request.comment.create'
+        else:
+            action = 'repo.commit.comment.create'
+
+        comment_data = comment.get_api_data()
+        self._log_audit_action(
+            action, {'data': comment_data}, user, comment)
 
         registry = get_current_registry()
         rhodecode_plugins = getattr(registry, 'rhodecode_plugins', {})
@@ -388,15 +394,22 b' class CommentsModel(BaseModel):'
 
         return comment
 
-    def delete(self, comment):
+    def delete(self, comment, user):
         """
         Deletes given comment
-
-        :param comment_id:
         """
         comment = self.__get_commit_comment(comment)
+        old_data = comment.get_api_data()
         Session().delete(comment)
 
+        if comment.pull_request:
+            action = 'repo.pull_request.comment.delete'
+        else:
+            action = 'repo.commit.comment.delete'
+
+        self._log_audit_action(
+            action, {'old_data': old_data}, user, comment)
+
         return comment
 
     def get_all_comments(self, repo_id, revision=None, pull_request=None):
@@ -412,22 +425,39 b' class CommentsModel(BaseModel):'
         q = q.order_by(ChangesetComment.created_on)
         return q.all()
 
-    def get_url(self, comment):
+    def get_url(self, comment, request=None, permalink=False):
+        if not request:
+            request = get_current_request()
+
         comment = self.__get_commit_comment(comment)
         if comment.pull_request:
-            return h.url(
-                'pullrequest_show',
-                repo_name=comment.pull_request.target_repo.repo_name,
-                pull_request_id=comment.pull_request.pull_request_id,
-                anchor='comment-%s' % comment.comment_id,
-                qualified=True,)
+            pull_request = comment.pull_request
+            if permalink:
+                return request.route_url(
+                    'pull_requests_global',
+                    pull_request_id=pull_request.pull_request_id,
+                    _anchor='comment-%s' % comment.comment_id)
+            else:
+                return request.route_url('pullrequest_show',
+                    repo_name=safe_str(pull_request.target_repo.repo_name),
+                    pull_request_id=pull_request.pull_request_id,
+                    _anchor='comment-%s' % comment.comment_id)
+
         else:
-            return h.url(
-                'changeset_home',
-                repo_name=comment.repo.repo_name,
-                revision=comment.revision,
-                anchor='comment-%s' % comment.comment_id,
-                qualified=True,)
+            repo = comment.repo
+            commit_id = comment.revision
+
+            if permalink:
+                return request.route_url(
+                    'repo_commit', repo_name=safe_str(repo.repo_id),
+                    commit_id=commit_id,
+                    _anchor='comment-%s' % comment.comment_id)
+
+            else:
+                return request.route_url(
+                    'repo_commit', repo_name=safe_str(repo.repo_name),
+                    commit_id=commit_id,
+                    _anchor='comment-%s' % comment.comment_id)
 
     def get_comments(self, repo_id, revision=None, pull_request=None):
         """

rhodecode/model/db.py

@@ -44,8 +44,8 b' from sqlalchemy.sql.expression import tr'
 from beaker.cache import cache_region
 from zope.cachedescriptors.property import Lazy as LazyProperty
 
-from pylons import url
 from pylons.i18n.translation import lazy_ugettext as _
+from pyramid.threadlocal import get_current_request
 
 from rhodecode.lib.vcs import get_vcs_instance
 from rhodecode.lib.vcs.backends.base import EmptyCommit, Reference
@@ -358,6 +358,7 b' class RhodeCodeUi(Base, BaseModel):'
     HOOK_PRE_PUSH = 'prechangegroup.pre_push'
     HOOK_PRETX_PUSH = 'pretxnchangegroup.pre_push'
     HOOK_PUSH = 'changegroup.push_logger'
+    HOOK_PUSH_KEY = 'pushkey.key_push'
 
     # TODO: johbo: Unify way how hooks are configured for git and hg,
     # git part is currently hardcoded.
@@ -571,6 +572,20 b' class User(Base, BaseModel):'
         self._email = val.lower() if val else None
 
     @hybrid_property
+    def first_name(self):
+        from rhodecode.lib import helpers as h
+        if self.name:
+            return h.escape(self.name)
+        return self.name
+
+    @hybrid_property
+    def last_name(self):
+        from rhodecode.lib import helpers as h
+        if self.lastname:
+            return h.escape(self.lastname)
+        return self.lastname
+
+    @hybrid_property
     def api_key(self):
         """
         Fetch if exist an auth-token with role ALL connected to this user
@@ -689,7 +704,7 b' class User(Base, BaseModel):'
 
     @property
     def username_and_name(self):
-        return '%s (%s %s)' % (self.username, self.firstname, self.lastname)
+        return '%s (%s %s)' % (self.username, self.first_name, self.last_name)
 
     @property
     def username_or_name_or_email(self):
@@ -698,20 +713,20 b' class User(Base, BaseModel):'
 
     @property
     def full_name(self):
-        return '%s %s' % (self.firstname, self.lastname)
+        return '%s %s' % (self.first_name, self.last_name)
 
     @property
     def full_name_or_username(self):
-        return ('%s %s' % (self.firstname, self.lastname)
-                if (self.firstname and self.lastname) else self.username)
+        return ('%s %s' % (self.first_name, self.last_name)
+                if (self.first_name and self.last_name) else self.username)
 
     @property
     def full_contact(self):
-        return '%s %s <%s>' % (self.firstname, self.lastname, self.email)
+        return '%s %s <%s>' % (self.first_name, self.last_name, self.email)
 
     @property
     def short_contact(self):
-        return '%s %s' % (self.firstname, self.lastname)
+        return '%s %s' % (self.first_name, self.last_name)
 
     @property
     def is_admin(self):
@@ -761,9 +776,9 b' class User(Base, BaseModel):'
                 if val:
                     return val
             else:
+                cache_key = "get_user_by_name_%s" % _hash_key(username)
                 q = q.options(
-                    FromCache("sql_cache_short",
-                              "get_user_by_name_%s" % _hash_key(username)))
+                    FromCache("sql_cache_short", cache_key))
 
         return q.scalar()
 
@@ -774,8 +789,8 b' class User(Base, BaseModel):'
             .filter(or_(UserApiKeys.expires == -1,
                         UserApiKeys.expires >= time.time()))
         if cache:
-            q = q.options(FromCache("sql_cache_short",
-                                    "get_auth_token_%s" % auth_token))
+            q = q.options(
+                FromCache("sql_cache_short", "get_auth_token_%s" % auth_token))
 
         match = q.first()
         if match:
@@ -790,9 +805,10 b' class User(Base, BaseModel):'
         else:
             q = cls.query().filter(cls.email == email)
 
+        email_key = _hash_key(email)
         if cache:
-            q = q.options(FromCache("sql_cache_short",
-                                    "get_email_key_%s" % _hash_key(email)))
+            q = q.options(
+                FromCache("sql_cache_short", "get_email_key_%s" % email_key))
 
         ret = q.scalar()
         if ret is None:
@@ -804,8 +820,8 b' class User(Base, BaseModel):'
                 q = q.filter(UserEmailMap.email == email)
             q = q.options(joinedload(UserEmailMap.user))
             if cache:
-                q = q.options(FromCache("sql_cache_short",
-                                        "get_email_map_key_%s" % email))
+                q = q.options(
+                    FromCache("sql_cache_short", "get_email_map_key_%s" % email_key))
             ret = getattr(q.scalar(), 'user', None)
 
         return ret
@@ -872,10 +888,16 b' class User(Base, BaseModel):'
             .order_by(User.username.asc()).all()
 
     @classmethod
-    def get_default_user(cls, cache=False):
+    def get_default_user(cls, cache=False, refresh=False):
         user = User.get_by_username(User.DEFAULT_USER, cache=cache)
         if user is None:
             raise Exception('FATAL: Missing default account!')
+        if refresh:
+            # The default user might be based on outdated state which
+            # has been loaded from the cache.
+            # A call to refresh() ensures that the
+            # latest state from the database is used.
+            Session().refresh(user)
         return user
 
     def _get_default_perms(self, user, suffix=''):
@@ -996,6 +1018,19 b' class UserApiKeys(Base, BaseModel):'
         }
         return data
 
+    def get_api_data(self, include_secrets=False):
+        data = self.__json__()
+        if include_secrets:
+            return data
+        else:
+            data['auth_token'] = self.token_obfuscated
+            return data
+
+    @hybrid_property
+    def description_safe(self):
+        from rhodecode.lib import helpers as h
+        return h.escape(self.description)
+
     @property
     def expired(self):
         if self.expires == -1:
@@ -1027,6 +1062,11 b' class UserApiKeys(Base, BaseModel):'
     def scope_humanized(self):
         return self._get_scope()
 
+    @property
+    def token_obfuscated(self):
+        if self.api_key:
+            return self.api_key[:4] + "****"
+
 
 class UserEmailMap(Base, BaseModel):
     __tablename__ = 'user_email_map'
@@ -1076,6 +1116,11 b' class UserIpMap(Base, BaseModel):'
     description = Column("description", String(10000), nullable=True, unique=None, default=None)
     user = relationship('User', lazy='joined')
 
+    @hybrid_property
+    def description_safe(self):
+        from rhodecode.lib import helpers as h
+        return h.escape(self.description)
+
     @classmethod
     def _get_ip_range(cls, ip_addr):
         net = ipaddress.ip_network(ip_addr, strict=False)
@@ -1098,6 +1143,10 b' class UserLog(Base, BaseModel):'
         {'extend_existing': True, 'mysql_engine': 'InnoDB',
          'mysql_charset': 'utf8', 'sqlite_autoincrement': True},
     )
+    VERSION_1 = 'v1'
+    VERSION_2 = 'v2'
+    VERSIONS = [VERSION_1, VERSION_2]
+
     user_log_id = Column("user_log_id", Integer(), nullable=False, unique=True, default=None, primary_key=True)
     user_id = Column("user_id", Integer(), ForeignKey('users.user_id'), nullable=True, unique=None, default=None)
     username = Column("username", String(255), nullable=True, unique=None, default=None)
@@ -1107,6 +1156,10 b' class UserLog(Base, BaseModel):'
     action = Column("action", Text().with_variant(Text(1200000), 'mysql'), nullable=True, unique=None, default=None)
     action_date = Column("action_date", DateTime(timezone=False), nullable=True, unique=None, default=None)
 
+    version = Column("version", String(255), nullable=True, default=VERSION_1)
+    user_data = Column('user_data_json', MutationObj.as_mutable(JsonType(dialect_map=dict(mysql=UnicodeText(16384)))))
+    action_data = Column('action_data_json', MutationObj.as_mutable(JsonType(dialect_map=dict(mysql=UnicodeText(16384)))))
+
     def __unicode__(self):
         return u"<%s('id:%s:%s')>" % (
             self.__class__.__name__, self.repository_name, self.action)
@@ -1156,6 +1209,11 b' class UserGroup(Base, BaseModel):'
     user = relationship('User')
 
     @hybrid_property
+    def description_safe(self):
+        from rhodecode.lib import helpers as h
+        return h.escape(self.description)
+
+    @hybrid_property
     def group_data(self):
         if not self._group_data:
             return {}
@@ -1187,17 +1245,16 b' class UserGroup(Base, BaseModel):'
         else:
             q = cls.query().filter(cls.users_group_name == group_name)
         if cache:
-            q = q.options(FromCache(
-                            "sql_cache_short",
-                            "get_group_%s" % _hash_key(group_name)))
+            q = q.options(
+                FromCache("sql_cache_short", "get_group_%s" % _hash_key(group_name)))
         return q.scalar()
 
     @classmethod
     def get(cls, user_group_id, cache=False):
         user_group = cls.query()
         if cache:
-            user_group = user_group.options(FromCache("sql_cache_short",
-                                    "get_users_group_%s" % user_group_id))
+            user_group = user_group.options(
+                FromCache("sql_cache_short", "get_users_group_%s" % user_group_id))
         return user_group.get(user_group_id)
 
     def permissions(self, with_admins=True, with_owner=True):
@@ -1454,6 +1511,11 b' class Repository(Base, BaseModel):'
                                    safe_unicode(self.repo_name))
 
     @hybrid_property
+    def description_safe(self):
+        from rhodecode.lib import helpers as h
+        return h.escape(self.description)
+
+    @hybrid_property
     def landing_rev(self):
         # always should return [rev_type, rev]
         if self._landing_revision:
@@ -1538,9 +1600,9 b' class Repository(Base, BaseModel):'
                 if val:
                     return val
             else:
+                cache_key = "get_repo_by_name_%s" % _hash_key(repo_name)
                 q = q.options(
-                    FromCache("sql_cache_short",
-                              "get_repo_by_name_%s" % _hash_key(repo_name)))
+                    FromCache("sql_cache_short", cache_key))
 
         return q.scalar()
 
@@ -1750,6 +1812,7 b' class Repository(Base, BaseModel):'
         # TODO: mikhail: Here there is an anti-pattern, we probably need to
         # move this methods on models level.
         from rhodecode.model.settings import SettingsModel
+        from rhodecode.model.repo import RepoModel
 
         repo = self
         _user_id, _time, _reason = self.locked
@@ -1759,13 +1822,14 b' class Repository(Base, BaseModel):'
             'repo_name': repo.repo_name,
             'repo_type': repo.repo_type,
             'clone_uri': repo.clone_uri or '',
-            'url': url('summary_home', repo_name=self.repo_name, qualified=True),
+            'url': RepoModel().get_url(self),
             'private': repo.private,
             'created_on': repo.created_on,
-            'description': repo.description,
+            'description': repo.description_safe,
             'landing_rev': repo.landing_rev,
             'owner': repo.user.username,
             'fork_of': repo.fork.repo_name if repo.fork else None,
+            'fork_of_id': repo.fork.repo_id if repo.fork else None,
             'enable_statistics': repo.enable_statistics,
             'enable_locking': repo.enable_locking,
             'enable_downloads': repo.enable_downloads,
@@ -1893,7 +1957,6 b' class Repository(Base, BaseModel):'
         return clone_uri
 
     def clone_url(self, **override):
-        qualified_home_url = url('home', qualified=True)
 
         uri_tmpl = None
         if 'with_id' in override:
@@ -1915,8 +1978,9 b' class Repository(Base, BaseModel):'
                 # ie, not having tmpl_context set up
                 pass
 
-        return get_clone_url(uri_tmpl=uri_tmpl,
-                             qualifed_home_url=qualified_home_url,
+        request = get_current_request()
+        return get_clone_url(request=request,
+                             uri_tmpl=uri_tmpl,
                              repo_name=self.repo_name,
                              repo_id=self.repo_id, **override)
 
@@ -2160,8 +2224,13 b' class RepoGroup(Base, BaseModel):'
         self.parent_group = parent_group
 
     def __unicode__(self):
-        return u"<%s('id:%s:%s')>" % (self.__class__.__name__, self.group_id,
-                                      self.group_name)
+        return u"<%s('id:%s:%s')>" % (
+            self.__class__.__name__, self.group_id, self.group_name)
+
+    @hybrid_property
+    def description_safe(self):
+        from rhodecode.lib import helpers as h
+        return h.escape(self.group_description)
 
     @classmethod
     def _generate_choice(cls, repo_group):
@@ -2176,7 +2245,7 b' class RepoGroup(Base, BaseModel):'
 
         repo_groups = []
         if show_empty_group:
-            repo_groups = [('-1', u'-- %s --' % _('No parent'))]
+            repo_groups = [(-1, u'-- %s --' % _('No parent'))]
 
         repo_groups.extend([cls._generate_choice(x) for x in groups])
 
@@ -2196,16 +2265,19 b' class RepoGroup(Base, BaseModel):'
         else:
             gr = cls.query().filter(cls.group_name == group_name)
         if cache:
-            gr = gr.options(FromCache(
-                            "sql_cache_short",
-                            "get_group_%s" % _hash_key(group_name)))
+            name_key = _hash_key(group_name)
+            gr = gr.options(
+                FromCache("sql_cache_short", "get_group_%s" % name_key))
         return gr.scalar()
 
     @classmethod
     def get_user_personal_repo_group(cls, user_id):
         user = User.get(user_id)
+        if user.username == User.DEFAULT_USER:
+            return None
+
         return cls.query()\
-            .filter(cls.personal == true())\
+            .filter(cls.personal == true()) \
             .filter(cls.user == user).scalar()
 
     @classmethod
@@ -2389,7 +2461,7 b' class RepoGroup(Base, BaseModel):'
         data = {
             'group_id': group.group_id,
             'group_name': group.group_name,
-            'group_description': group.group_description,
+            'group_description': group.description_safe,
             'parent_group': group.parent_group.group_name if group.parent_group else None,
             'repositories': [x.repo_name for x in group.repositories],
             'owner': group.user.username,
@@ -3088,20 +3160,39 b' class ChangesetComment(Base, BaseModel):'
     def is_todo(self):
         return self.comment_type == self.COMMENT_TYPE_TODO
 
+    @property
+    def is_inline(self):
+        return self.line_no and self.f_path
+
     def get_index_version(self, versions):
         return self.get_index_from_version(
             self.pull_request_version_id, versions)
 
-    def render(self, mentions=False):
-        from rhodecode.lib import helpers as h
-        return h.render(self.text, renderer=self.renderer, mentions=mentions)
-
     def __repr__(self):
         if self.comment_id:
             return '<DB:Comment #%s>' % self.comment_id
         else:
             return '<DB:Comment at %#x>' % id(self)
 
+    def get_api_data(self):
+        comment = self
+        data = {
+            'comment_id': comment.comment_id,
+            'comment_type': comment.comment_type,
+            'comment_text': comment.text,
+            'comment_status': comment.status_change,
+            'comment_f_path': comment.f_path,
+            'comment_lineno': comment.line_no,
+            'comment_author': comment.author,
+            'comment_created_on': comment.created_on
+        }
+        return data
+
+    def __json__(self):
+        data = dict()
+        data.update(self.get_api_data())
+        return data
+
 
 class ChangesetStatus(Base, BaseModel):
     __tablename__ = 'changeset_statuses'
@@ -3153,6 +3244,19 b' class ChangesetStatus(Base, BaseModel):'
     def status_lbl(self):
         return ChangesetStatus.get_status_lbl(self.status)
 
+    def get_api_data(self):
+        status = self
+        data = {
+            'status_id': status.changeset_status_id,
+            'status': status.status,
+        }
+        return data
+
+    def __json__(self):
+        data = dict()
+        data.update(self.get_api_data())
+        return data
+
 
 class _PullRequestBase(BaseModel):
     """
@@ -3215,6 +3319,19 b' class _PullRequestBase(BaseModel):'
     _last_merge_status = Column('merge_status', Integer(), nullable=True)
     merge_rev = Column('merge_rev', String(40), nullable=True)
 
+    reviewer_data = Column(
+        'reviewer_data_json', MutationObj.as_mutable(
+            JsonType(dialect_map=dict(mysql=UnicodeText(16384)))))
+
+    @property
+    def reviewer_data_json(self):
+        return json.dumps(self.reviewer_data)
+
+    @hybrid_property
+    def description_safe(self):
+        from rhodecode.lib import helpers as h
+        return h.escape(self.description)
+
     @hybrid_property
     def revisions(self):
         return self._revisions.split(':') if self._revisions else []
@@ -3276,14 +3393,19 b' class _PullRequestBase(BaseModel):'
         else:
             return None
 
-    def get_api_data(self):
+    def get_api_data(self, with_merge_state=True):
         from rhodecode.model.pull_request import PullRequestModel
+
         pull_request = self
-        merge_status = PullRequestModel().merge_status(pull_request)
-
-        pull_request_url = url(
-            'pullrequest_show', repo_name=self.target_repo.repo_name,
-            pull_request_id=self.pull_request_id, qualified=True)
+        if with_merge_state:
+            merge_status = PullRequestModel().merge_status(pull_request)
+            merge_state = {
+                'status': merge_status[0],
+                'message': safe_unicode(merge_status[1]),
+            }
+        else:
+            merge_state = {'status': 'not_available',
+                           'message': 'not_available'}
 
         merge_data = {
             'clone_url': PullRequestModel().get_shadow_clone_url(pull_request),
@@ -3294,7 +3416,7 b' class _PullRequestBase(BaseModel):'
 
         data = {
             'pull_request_id': pull_request.pull_request_id,
-            'url': pull_request_url,
+            'url': PullRequestModel().get_url(pull_request),
             'title': pull_request.title,
             'description': pull_request.description,
             'status': pull_request.status,
@@ -3302,10 +3424,7 b' class _PullRequestBase(BaseModel):'
             'updated_on': pull_request.updated_on,
             'commit_ids': pull_request.revisions,
             'review_status': pull_request.calculated_review_status(),
-            'mergeable': {
-                'status': merge_status[0],
-                'message': unicode(merge_status[1]),
-            },
+            'mergeable': merge_state,
             'source': {
                 'clone_url': pull_request.source_repo.clone_url(),
                 'repository': pull_request.source_repo.repo_name,
@@ -3334,7 +3453,8 b' class _PullRequestBase(BaseModel):'
                     'reasons': reasons,
                     'review_status': st[0][1].status if st else 'not_reviewed',
                 }
-                for reviewer, reasons, st in pull_request.reviewers_statuses()
+                for reviewer, reasons, mandatory, st in
+                pull_request.reviewers_statuses()
             ]
         }
 
@@ -3359,7 +3479,8 b' class PullRequest(Base, _PullRequestBase'
 
     reviewers = relationship('PullRequestReviewers',
                              cascade="all, delete, delete-orphan")
-    statuses = relationship('ChangesetStatus')
+    statuses = relationship('ChangesetStatus',
+                            cascade="all, delete, delete-orphan")
     comments = relationship('ChangesetComment',
                             cascade="all, delete, delete-orphan")
     versions = relationship('PullRequestVersion',
@@ -3424,6 +3545,8 b' class PullRequest(Base, _PullRequestBase'
         attrs.revisions = pull_request_obj.revisions
 
         attrs.shadow_merge_ref = org_pull_request_obj.shadow_merge_ref
+        attrs.reviewer_data = org_pull_request_obj.reviewer_data
+        attrs.reviewer_data_json = org_pull_request_obj.reviewer_data_json
 
         return PullRequestDisplay(attrs, internal=internal_methods)
 
@@ -3502,11 +3625,6 b' class PullRequestReviewers(Base, BaseMod'
          'mysql_charset': 'utf8', 'sqlite_autoincrement': True},
     )
 
-    def __init__(self, user=None, pull_request=None, reasons=None):
-        self.user = user
-        self.pull_request = pull_request
-        self.reasons = reasons or []
-
     @hybrid_property
     def reasons(self):
         if not self._reasons:
@@ -3531,7 +3649,7 b' class PullRequestReviewers(Base, BaseMod'
     _reasons = Column(
         'reason', MutationList.as_mutable(
             JsonType('list', dialect_map=dict(mysql=UnicodeText(16384)))))
-
+    mandatory = Column("mandatory", Boolean(), nullable=False, default=False)
     user = relationship('User')
     pull_request = relationship('PullRequest')
 
@@ -3651,6 +3769,11 b' class Gist(Base, BaseModel):'
     def __repr__(self):
         return '<Gist:[%s]%s>' % (self.gist_type, self.gist_access_id)
 
+    @hybrid_property
+    def description_safe(self):
+        from rhodecode.lib import helpers as h
+        return h.escape(self.gist_description)
+
     @classmethod
     def get_or_404(cls, id_, pyramid_exc=False):
 
@@ -3670,6 +3793,8 b' class Gist(Base, BaseModel):'
 
     def gist_url(self):
         import rhodecode
+        from pylons import url
+
         alias_url = rhodecode.CONFIG.get('gist_alias_url')
         if alias_url:
             return alias_url.replace('{gistid}', self.gist_access_id)
@@ -3835,14 +3960,17 b' class RepoReviewRuleUser(Base, BaseModel'
         {'extend_existing': True, 'mysql_engine': 'InnoDB',
          'mysql_charset': 'utf8', 'sqlite_autoincrement': True,}
     )
-    repo_review_rule_user_id = Column(
-        'repo_review_rule_user_id', Integer(), primary_key=True)
-    repo_review_rule_id = Column("repo_review_rule_id",
-        Integer(), ForeignKey('repo_review_rules.repo_review_rule_id'))
-    user_id = Column("user_id", Integer(), ForeignKey('users.user_id'),
-        nullable=False)
+    repo_review_rule_user_id = Column('repo_review_rule_user_id', Integer(), primary_key=True)
+    repo_review_rule_id = Column("repo_review_rule_id", Integer(), ForeignKey('repo_review_rules.repo_review_rule_id'))
+    user_id = Column("user_id", Integer(), ForeignKey('users.user_id'), nullable=False)
+    mandatory = Column("mandatory", Boolean(), nullable=False, default=False)
     user = relationship('User')
 
+    def rule_data(self):
+        return {
+            'mandatory': self.mandatory
+        }
+
 
 class RepoReviewRuleUserGroup(Base, BaseModel):
     __tablename__ = 'repo_review_rules_users_groups'
@@ -3850,14 +3978,17 b' class RepoReviewRuleUserGroup(Base, Base'
         {'extend_existing': True, 'mysql_engine': 'InnoDB',
          'mysql_charset': 'utf8', 'sqlite_autoincrement': True,}
     )
-    repo_review_rule_users_group_id = Column(
-        'repo_review_rule_users_group_id', Integer(), primary_key=True)
-    repo_review_rule_id = Column("repo_review_rule_id",
-        Integer(), ForeignKey('repo_review_rules.repo_review_rule_id'))
-    users_group_id = Column("users_group_id", Integer(),
-        ForeignKey('users_groups.users_group_id'), nullable=False)
+    repo_review_rule_users_group_id = Column('repo_review_rule_users_group_id', Integer(), primary_key=True)
+    repo_review_rule_id = Column("repo_review_rule_id", Integer(), ForeignKey('repo_review_rules.repo_review_rule_id'))
+    users_group_id = Column("users_group_id", Integer(),ForeignKey('users_groups.users_group_id'), nullable=False)
+    mandatory = Column("mandatory", Boolean(), nullable=False, default=False)
     users_group = relationship('UserGroup')
 
+    def rule_data(self):
+        return {
+            'mandatory': self.mandatory
+        }
+
 
 class RepoReviewRule(Base, BaseModel):
     __tablename__ = 'repo_review_rules'
@@ -3872,13 +4003,14 b' class RepoReviewRule(Base, BaseModel):'
         "repo_id", Integer(), ForeignKey('repositories.repo_id'))
     repo = relationship('Repository', backref='review_rules')
 
-    _branch_pattern = Column("branch_pattern", UnicodeText().with_variant(UnicodeText(255), 'mysql'),
-        default=u'*') # glob
-    _file_pattern = Column("file_pattern", UnicodeText().with_variant(UnicodeText(255), 'mysql'),
-        default=u'*') # glob
-
-    use_authors_for_review = Column("use_authors_for_review", Boolean(),
-        nullable=False, default=False)
+    _branch_pattern = Column("branch_pattern", UnicodeText().with_variant(UnicodeText(255), 'mysql'), default=u'*')  # glob
+    _file_pattern = Column("file_pattern", UnicodeText().with_variant(UnicodeText(255), 'mysql'), default=u'*')  # glob
+
+    use_authors_for_review = Column("use_authors_for_review", Boolean(), nullable=False, default=False)
+    forbid_author_to_review = Column("forbid_author_to_review", Boolean(), nullable=False, default=False)
+    forbid_commit_author_to_review = Column("forbid_commit_author_to_review", Boolean(), nullable=False, default=False)
+    forbid_adding_reviewers = Column("forbid_adding_reviewers", Boolean(), nullable=False, default=False)
+
     rule_users = relationship('RepoReviewRuleUser')
     rule_user_groups = relationship('RepoReviewRuleUserGroup')
 
@@ -3934,16 +4066,32 b' class RepoReviewRule(Base, BaseModel):'
     def review_users(self):
         """ Returns the users which this rule applies to """
 
-        users = set()
-        users |= set([
-            rule_user.user for rule_user in self.rule_users
-            if rule_user.user.active])
-        users |= set(
-            member.user
-            for rule_user_group in self.rule_user_groups
-            for member in rule_user_group.users_group.members
-            if member.user.active
-        )
+        users = collections.OrderedDict()
+
+        for rule_user in self.rule_users:
+            if rule_user.user.active:
+                if rule_user.user not in users:
+                    users[rule_user.user.username] = {
+                        'user': rule_user.user,
+                        'source': 'user',
+                        'source_data': {},
+                        'data': rule_user.rule_data()
+                    }
+
+        for rule_user_group in self.rule_user_groups:
+            source_data = {
+                'name': rule_user_group.users_group.users_group_name,
+                'members': len(rule_user_group.users_group.members)
+            }
+            for member in rule_user_group.users_group.members:
+                if member.user.active:
+                    users[member.user.username] = {
+                        'user': member.user,
+                        'source': 'user_group',
+                        'source_data': source_data,
+                        'data': rule_user_group.rule_data()
+                    }
+
         return users
 
     def __repr__(self):

rhodecode/model/forms.py

@@ -242,7 +242,7 b' def RepoForm(edit=False, old_data=None, '
         allow_extra_fields = True
         filter_extra_fields = False
         repo_name = All(v.UnicodeString(strip=True, min=1, not_empty=True),
-                        v.SlugifyName())
+                        v.SlugifyName(), v.CannotHaveGitSuffix())
         repo_group = All(v.CanWriteGroup(old_data),
                          v.OneOf(repo_groups, hideList=True))
         repo_type = v.OneOf(supported_backends, required=False,
@@ -384,6 +384,7 b' class _BaseVcsSettingsForm(formencode.Sc'
 
     # hg
     extensions_largefiles = v.StringBoolean(if_missing=False)
+    extensions_evolve = v.StringBoolean(if_missing=False)
     phases_publish = v.StringBoolean(if_missing=False)
     rhodecode_hg_use_rebase_for_merging = v.StringBoolean(if_missing=False)
 
@@ -534,12 +535,13 b' def PullRequestForm(repo_id):'
     class ReviewerForm(formencode.Schema):
         user_id = v.Int(not_empty=True)
         reasons = All()
+        mandatory = v.StringBoolean()
 
     class _PullRequestForm(formencode.Schema):
         allow_extra_fields = True
         filter_extra_fields = True
 
-        user = v.UnicodeString(strip=True, required=True)
+        common_ancestor = v.UnicodeString(strip=True, required=True)
         source_repo = v.UnicodeString(strip=True, required=True)
         source_ref = v.UnicodeString(strip=True, required=True)
         target_repo = v.UnicodeString(strip=True, required=True)

rhodecode/model/integration.py

@@ -96,6 +96,9 b' class IntegrationModel(BaseModel):'
         """ Send an event to an integration """
         handler = self.get_integration_handler(integration)
         if handler:
+            log.debug(
+                'events: sending event %s on integration %s using handler %s',
+                event, integration, handler)
             handler.send_event(event)
 
     def get_integrations(self, scope, IntegrationType=None):
@@ -200,14 +203,14 b' class IntegrationModel(BaseModel):'
             query = query.filter(or_(*clauses))
 
             if cache:
-                query = query.options(FromCache(
-                    "sql_cache_short",
-                    "get_enabled_repo_integrations_%i" % event.repo.repo_id))
+                cache_key = "get_enabled_repo_integrations_%i" % event.repo.repo_id
+                query = query.options(
+                    FromCache("sql_cache_short", cache_key))
         else: # only global integrations
             query = query.filter(global_integrations_filter)
             if cache:
-                query = query.options(FromCache(
-                    "sql_cache_short", "get_enabled_global_integrations"))
+                query = query.options(
+                    FromCache("sql_cache_short", "get_enabled_global_integrations"))
 
         result = query.all()
         return result
  No newline at end of file

rhodecode/model/notification.py

@@ -332,14 +332,19 b' class EmailNotificationModel(BaseModel):'
 
         :param kwargs:
         """
+
         kwargs['rhodecode_instance_name'] = self.rhodecode_instance_name
-
+        instance_url = h.route_url('home')
         _kwargs = {
-            'instance_url': h.url('home', qualified=True),
+            'instance_url': instance_url,
+            'whitespace_filter': self.whitespace_filter
         }
         _kwargs.update(kwargs)
         return _kwargs
 
+    def whitespace_filter(self, text):
+        return text.replace('\n', '').replace('\t', '')
+
     def get_renderer(self, type_):
         template_name = self.email_types[type_]
         return PartialRenderer(template_name)

rhodecode/model/pull_request.py

@@ -31,14 +31,16 b' import urllib'
 
 from pylons.i18n.translation import _
 from pylons.i18n.translation import lazy_ugettext
+from pyramid.threadlocal import get_current_request
 from sqlalchemy import or_
 
+from rhodecode import events
 from rhodecode.lib import helpers as h, hooks_utils, diffs
+from rhodecode.lib import audit_logger
 from rhodecode.lib.compat import OrderedDict
 from rhodecode.lib.hooks_daemon import prepare_callback_daemon
 from rhodecode.lib.markup_renderer import (
     DEFAULT_COMMENTS_RENDERER, RstTemplateRenderer)
-from rhodecode.lib.utils import action_logger
 from rhodecode.lib.utils2 import safe_unicode, safe_str, md5_safe
 from rhodecode.lib.vcs.backends.base import (
     Reference, MergeResponse, MergeFailureReason, UpdateFailureReason)
@@ -118,9 +120,9 b' class PullRequestModel(BaseModel):'
             'Pull request update failed because of an unknown error.'),
         UpdateFailureReason.NO_CHANGE: lazy_ugettext(
             'No update needed because the source and target have not changed.'),
-        UpdateFailureReason.WRONG_REF_TPYE: lazy_ugettext(
+        UpdateFailureReason.WRONG_REF_TYPE: lazy_ugettext(
             'Pull request cannot be updated because the reference type is '
-            'not supported for an update.'),
+            'not supported for an update. Only Branch, Tag or Bookmark is allowed.'),
         UpdateFailureReason.MISSING_TARGET_REF: lazy_ugettext(
             'This pull request cannot be updated because the target '
             'reference is missing.'),
@@ -415,7 +417,9 b' class PullRequestModel(BaseModel):'
             .all()
 
     def create(self, created_by, source_repo, source_ref, target_repo,
-        target_ref, revisions, reviewers, title, description=None):
+               target_ref, revisions, reviewers, title, description=None,
+               reviewer_data=None):
+
         created_by_user = self._get_user(created_by)
         source_repo = self._get_repo(source_repo)
         target_repo = self._get_repo(target_repo)
@@ -429,6 +433,7 b' class PullRequestModel(BaseModel):'
         pull_request.title = title
         pull_request.description = description
         pull_request.author = created_by_user
+        pull_request.reviewer_data = reviewer_data
 
         Session().add(pull_request)
         Session().flush()
@@ -436,15 +441,20 b' class PullRequestModel(BaseModel):'
         reviewer_ids = set()
         # members / reviewers
         for reviewer_object in reviewers:
-            if isinstance(reviewer_object, tuple):
-                user_id, reasons = reviewer_object
-            else:
-                user_id, reasons = reviewer_object, []
+            user_id, reasons, mandatory = reviewer_object
+            user = self._get_user(user_id)
 
-            user = self._get_user(user_id)
+            # skip duplicates
+            if user.user_id in reviewer_ids:
+                continue
+
             reviewer_ids.add(user.user_id)
 
-            reviewer = PullRequestReviewers(user, pull_request, reasons)
+            reviewer = PullRequestReviewers()
+            reviewer.user = user
+            reviewer.pull_request = pull_request
+            reviewer.reasons = reasons
+            reviewer.mandatory = mandatory
             Session().add(reviewer)
 
         # Set approval status to "Under Review" for all commits which are
@@ -460,6 +470,11 b' class PullRequestModel(BaseModel):'
         self._trigger_pull_request_hook(
             pull_request, created_by_user, 'create')
 
+        creation_data = pull_request.get_api_data(with_merge_state=False)
+        self._log_audit_action(
+            'repo.pull_request.create', {'data': creation_data},
+            created_by_user, pull_request)
+
         return pull_request
 
     def _trigger_pull_request_hook(self, pull_request, user, action):
@@ -510,7 +525,12 b' class PullRequestModel(BaseModel):'
             log.debug(
                 "Merge was successful, updating the pull request comments.")
             self._comment_and_close_pr(pull_request, user, merge_state)
-            self._log_action('user_merged_pull_request', user, pull_request)
+
+            self._log_audit_action(
+                'repo.pull_request.merge',
+                {'merge_state': merge_state.__dict__},
+                user, pull_request)
+
         else:
             log.warn("Merge failed, not updating the pull request.")
         return merge_state
@@ -594,7 +614,7 b' class PullRequestModel(BaseModel):'
                 pull_request, source_ref_type)
             return UpdateResponse(
                 executed=False,
-                reason=UpdateFailureReason.WRONG_REF_TPYE,
+                reason=UpdateFailureReason.WRONG_REF_TYPE,
                 old=pull_request, new=None, changes=None,
                 source_changed=False, target_changed=False)
 
@@ -763,6 +783,7 b' class PullRequestModel(BaseModel):'
         version._last_merge_status = pull_request._last_merge_status
         version.shadow_merge_ref = pull_request.shadow_merge_ref
         version.merge_rev = pull_request.merge_rev
+        version.reviewer_data = pull_request.reviewer_data
 
         version.revisions = pull_request.revisions
         version.pull_request = pull_request
@@ -806,13 +827,15 b' class PullRequestModel(BaseModel):'
 
         """
         pull_request = pull_request_version.pull_request
-        comments = ChangesetComment.query().filter(
-            # TODO: johbo: Should we query for the repo at all here?
-            # Pending decision on how comments of PRs are to be related
-            # to either the source repo, the target repo or no repo at all.
-            ChangesetComment.repo_id == pull_request.target_repo.repo_id,
-            ChangesetComment.pull_request == pull_request,
-            ChangesetComment.pull_request_version == None)
+        comments = ChangesetComment.query()\
+            .filter(
+                # TODO: johbo: Should we query for the repo at all here?
+                # Pending decision on how comments of PRs are to be related
+                # to either the source repo, the target repo or no repo at all.
+                ChangesetComment.repo_id == pull_request.target_repo.repo_id,
+                ChangesetComment.pull_request == pull_request,
+                ChangesetComment.pull_request_version == None)\
+            .order_by(ChangesetComment.comment_id.asc())
 
         # TODO: johbo: Find out why this breaks if it is done in a bulk
         # operation.
@@ -886,8 +909,9 b' class PullRequestModel(BaseModel):'
         renderer = RstTemplateRenderer()
         return renderer.render('pull_request_update.mako', **params)
 
-    def edit(self, pull_request, title, description):
+    def edit(self, pull_request, title, description, user):
         pull_request = self.__get_pull_request(pull_request)
+        old_data = pull_request.get_api_data(with_merge_state=False)
         if pull_request.is_closed():
             raise ValueError('This pull request is closed')
         if title:
@@ -895,22 +919,27 b' class PullRequestModel(BaseModel):'
         pull_request.description = description
         pull_request.updated_on = datetime.datetime.now()
         Session().add(pull_request)
+        self._log_audit_action(
+            'repo.pull_request.edit', {'old_data': old_data},
+            user, pull_request)
 
-    def update_reviewers(self, pull_request, reviewer_data):
+    def update_reviewers(self, pull_request, reviewer_data, user):
         """
         Update the reviewers in the pull request
 
         :param pull_request: the pr to update
-        :param reviewer_data: list of tuples [(user, ['reason1', 'reason2'])]
+        :param reviewer_data: list of tuples
+            [(user, ['reason1', 'reason2'], mandatory_flag)]
         """
 
-        reviewers_reasons = {}
-        for user_id, reasons in reviewer_data:
+        reviewers = {}
+        for user_id, reasons, mandatory in reviewer_data:
             if isinstance(user_id, (int, basestring)):
                 user_id = self._get_user(user_id).user_id
-            reviewers_reasons[user_id] = reasons
+            reviewers[user_id] = {
+                'reasons': reasons, 'mandatory': mandatory}
 
-        reviewers_ids = set(reviewers_reasons.keys())
+        reviewers_ids = set(reviewers.keys())
         pull_request = self.__get_pull_request(pull_request)
         current_reviewers = PullRequestReviewers.query()\
             .filter(PullRequestReviewers.pull_request ==
@@ -926,9 +955,16 b' class PullRequestModel(BaseModel):'
         for uid in ids_to_add:
             changed = True
             _usr = self._get_user(uid)
-            reasons = reviewers_reasons[uid]
-            reviewer = PullRequestReviewers(_usr, pull_request, reasons)
+            reviewer = PullRequestReviewers()
+            reviewer.user = _usr
+            reviewer.pull_request = pull_request
+            reviewer.reasons = reviewers[uid]['reasons']
+            # NOTE(marcink): mandatory shouldn't be changed now
+            # reviewer.mandatory = reviewers[uid]['reasons']
             Session().add(reviewer)
+            self._log_audit_action(
+                'repo.pull_request.reviewer.add', {'data': reviewer.get_dict()},
+                user, pull_request)
 
         for uid in ids_to_remove:
             changed = True
@@ -939,7 +975,11 b' class PullRequestModel(BaseModel):'
             # use .all() in case we accidentally added the same person twice
             # this CAN happen due to the lack of DB checks
             for obj in reviewers:
+                old_data = obj.get_dict()
                 Session().delete(obj)
+                self._log_audit_action(
+                    'repo.pull_request.reviewer.delete',
+                    {'old_data': old_data}, user, pull_request)
 
         if changed:
             pull_request.updated_on = datetime.datetime.now()
@@ -948,11 +988,18 b' class PullRequestModel(BaseModel):'
         self.notify_reviewers(pull_request, ids_to_add)
         return ids_to_add, ids_to_remove
 
-    def get_url(self, pull_request):
-        return h.url('pullrequest_show',
-                     repo_name=safe_str(pull_request.target_repo.repo_name),
-                     pull_request_id=pull_request.pull_request_id,
-                     qualified=True)
+    def get_url(self, pull_request, request=None, permalink=False):
+        if not request:
+            request = get_current_request()
+
+        if permalink:
+            return request.route_url(
+                'pull_requests_global',
+                pull_request_id=pull_request.pull_request_id,)
+        else:
+            return request.route_url('pullrequest_show',
+                repo_name=safe_str(pull_request.target_repo.repo_name),
+                pull_request_id=pull_request.pull_request_id,)
 
     def get_shadow_clone_url(self, pull_request):
         """
@@ -979,22 +1026,16 b' class PullRequestModel(BaseModel):'
         pr_source_repo = pull_request_obj.source_repo
         pr_target_repo = pull_request_obj.target_repo
 
-        pr_url = h.url(
-            'pullrequest_show',
+        pr_url = h.route_url('pullrequest_show',
             repo_name=pr_target_repo.repo_name,
-            pull_request_id=pull_request_obj.pull_request_id,
-            qualified=True,)
+            pull_request_id=pull_request_obj.pull_request_id,)
 
         # set some variables for email notification
-        pr_target_repo_url = h.url(
-            'summary_home',
-            repo_name=pr_target_repo.repo_name,
-            qualified=True)
+        pr_target_repo_url = h.route_url(
+            'repo_summary', repo_name=pr_target_repo.repo_name)
 
-        pr_source_repo_url = h.url(
-            'summary_home',
-            repo_name=pr_source_repo.repo_name,
-            qualified=True)
+        pr_source_repo_url = h.route_url(
+            'repo_summary', repo_name=pr_source_repo.repo_name)
 
         # pull request specifics
         pull_request_commits = [
@@ -1031,9 +1072,13 b' class PullRequestModel(BaseModel):'
             email_kwargs=kwargs,
         )
 
-    def delete(self, pull_request):
+    def delete(self, pull_request, user):
         pull_request = self.__get_pull_request(pull_request)
+        old_data = pull_request.get_api_data(with_merge_state=False)
         self._cleanup_merge_workspace(pull_request)
+        self._log_audit_action(
+            'repo.pull_request.delete', {'old_data': old_data},
+            user, pull_request)
         Session().delete(pull_request)
 
     def close_pull_request(self, pull_request, user):
@@ -1044,44 +1089,64 b' class PullRequestModel(BaseModel):'
         Session().add(pull_request)
         self._trigger_pull_request_hook(
             pull_request, pull_request.author, 'close')
-        self._log_action('user_closed_pull_request', user, pull_request)
+        self._log_audit_action(
+            'repo.pull_request.close', {}, user, pull_request)
 
-    def close_pull_request_with_comment(self, pull_request, user, repo,
-                                        message=None):
-        status = ChangesetStatus.STATUS_REJECTED
+    def close_pull_request_with_comment(
+            self, pull_request, user, repo, message=None):
+
+        pull_request_review_status = pull_request.calculated_review_status()
 
-        if not message:
-            message = (
-                _('Status change %(transition_icon)s %(status)s') % {
-                    'transition_icon': '>',
-                    'status': ChangesetStatus.get_status_lbl(status)})
+        if pull_request_review_status == ChangesetStatus.STATUS_APPROVED:
+            # approved only if we have voting consent
+            status = ChangesetStatus.STATUS_APPROVED
+        else:
+            status = ChangesetStatus.STATUS_REJECTED
+        status_lbl = ChangesetStatus.get_status_lbl(status)
 
-        internal_message = _('Closing with') + ' ' + message
+        default_message = (
+            _('Closing with status change {transition_icon} {status}.')
+        ).format(transition_icon='>', status=status_lbl)
+        text = message or default_message
 
-        comm = CommentsModel().create(
-            text=internal_message,
+        # create a comment, and link it to new status
+        comment = CommentsModel().create(
+            text=text,
             repo=repo.repo_id,
             user=user.user_id,
             pull_request=pull_request.pull_request_id,
-            f_path=None,
-            line_no=None,
-            status_change=ChangesetStatus.get_status_lbl(status),
+            status_change=status_lbl,
             status_change_type=status,
             closing_pr=True
         )
 
+        # calculate old status before we change it
+        old_calculated_status = pull_request.calculated_review_status()
         ChangesetStatusModel().set_status(
             repo.repo_id,
             status,
             user.user_id,
-            comm,
+            comment=comment,
             pull_request=pull_request.pull_request_id
         )
+
         Session().flush()
+        events.trigger(events.PullRequestCommentEvent(pull_request, comment))
+        # we now calculate the status of pull request again, and based on that
+        # calculation trigger status change. This might happen in cases
+        # that non-reviewer admin closes a pr, which means his vote doesn't
+        # change the status, while if he's a reviewer this might change it.
+        calculated_status = pull_request.calculated_review_status()
+        if old_calculated_status != calculated_status:
+            self._trigger_pull_request_hook(
+                pull_request, user, 'review_status_change')
 
+        # finally close the PR
         PullRequestModel().close_pull_request(
             pull_request.pull_request_id, user)
 
+        return comment, status
+
     def merge_status(self, pull_request):
         if not self._is_merge_enabled(pull_request):
             return False, _('Server-side pull request merging is disabled.')
@@ -1226,11 +1291,11 b' class PullRequestModel(BaseModel):'
             'user': {
                 'user_id': repo.user.user_id,
                 'username': repo.user.username,
-                'firstname': repo.user.firstname,
-                'lastname': repo.user.lastname,
+                'firstname': repo.user.first_name,
+                'lastname': repo.user.last_name,
                 'gravatar_link': h.gravatar_url(repo.user.email, 14),
             },
-            'description': h.chop_at_smart(repo.description, '\n'),
+            'description': h.chop_at_smart(repo.description_safe, '\n'),
             'refs': {
                 'all_refs': all_refs,
                 'selected_ref': selected_ref,
@@ -1360,12 +1425,29 b' class PullRequestModel(BaseModel):'
         settings = settings_model.get_general_settings()
         return settings.get('rhodecode_hg_use_rebase_for_merging', False)
 
-    def _log_action(self, action, user, pull_request):
-        action_logger(
-            user,
-            '{action}:{pr_id}'.format(
-                action=action, pr_id=pull_request.pull_request_id),
-            pull_request.target_repo)
+    def _log_audit_action(self, action, action_data, user, pull_request):
+        audit_logger.store(
+            action=action,
+            action_data=action_data,
+            user=user,
+            repo=pull_request.target_repo)
+
+    def get_reviewer_functions(self):
+        """
+        Fetches functions for validation and fetching default reviewers.
+        If available we use the EE package, else we fallback to CE
+        package functions
+        """
+        try:
+            from rc_reviewers.utils import get_default_reviewers_data
+            from rc_reviewers.utils import validate_default_reviewers
+        except ImportError:
+            from rhodecode.apps.repository.utils import \
+                get_default_reviewers_data
+            from rhodecode.apps.repository.utils import \
+                validate_default_reviewers
+
+        return get_default_reviewers_data, validate_default_reviewers
 
 
 class MergeCheck(object):

rhodecode/model/repo.py

@@ -30,8 +30,7 b' import time'
 import traceback
 from datetime import datetime, timedelta
 
-from sqlalchemy.sql import func
-from sqlalchemy.sql.expression import true, or_
+from pyramid.threadlocal import get_current_request
 from zope.cachedescriptors.property import Lazy as LazyProperty
 
 from rhodecode import events
@@ -40,19 +39,17 b' from rhodecode.lib.auth import HasUserGr'
 from rhodecode.lib.caching_query import FromCache
 from rhodecode.lib.exceptions import AttachedForksError
 from rhodecode.lib.hooks_base import log_delete_repository
-from rhodecode.lib.markup_renderer import MarkupRenderer
 from rhodecode.lib.utils import make_db_config
 from rhodecode.lib.utils2 import (
     safe_str, safe_unicode, remove_prefix, obfuscate_url_pw,
     get_current_rhodecode_user, safe_int, datetime_to_time, action_logger_generic)
 from rhodecode.lib.vcs.backends import get_backend
-from rhodecode.lib.vcs.exceptions import NodeDoesNotExistError
 from rhodecode.model import BaseModel
-from rhodecode.model.db import (
+from rhodecode.model.db import (_hash_key,
     Repository, UserRepoToPerm, UserGroupRepoToPerm, UserRepoGroupToPerm,
     UserGroupRepoGroupToPerm, User, Permission, Statistics, UserGroup,
     RepoGroup, RepositoryField)
-from rhodecode.model.scm import UserGroupList
+
 from rhodecode.model.settings import VcsSettingsModel
 
 
@@ -103,8 +100,8 b' class RepoModel(BaseModel):'
             .filter(Repository.repo_id == repo_id)
 
         if cache:
-            repo = repo.options(FromCache("sql_cache_short",
-                                          "get_repo_%s" % repo_id))
+            repo = repo.options(
+                FromCache("sql_cache_short", "get_repo_%s" % repo_id))
         return repo.scalar()
 
     def get_repo(self, repository):
@@ -115,8 +112,9 b' class RepoModel(BaseModel):'
             .filter(Repository.repo_name == repo_name)
 
         if cache:
-            repo = repo.options(FromCache("sql_cache_short",
-                                          "get_repo_%s" % repo_name))
+            name_key = _hash_key(repo_name)
+            repo = repo.options(
+                FromCache("sql_cache_short", "get_repo_%s" % name_key))
         return repo.scalar()
 
     def _extract_id_from_repo_name(self, repo_name):
@@ -134,6 +132,7 b' class RepoModel(BaseModel):'
         :param repo_name:
         :return: repo object if matched else None
         """
+
         try:
             _repo_id = self._extract_id_from_repo_name(repo_name)
             if _repo_id:
@@ -156,86 +155,36 b' class RepoModel(BaseModel):'
             repos = Repository.query().filter(Repository.group == root).all()
         return repos
 
-    def get_url(self, repo):
-        return h.url('summary_home', repo_name=safe_str(repo.repo_name),
-            qualified=True)
+    def get_url(self, repo, request=None, permalink=False):
+        if not request:
+            request = get_current_request()
 
-    def get_users(self, name_contains=None, limit=20, only_active=True):
-
-        # TODO: mikhail: move this method to the UserModel.
-        query = self.sa.query(User)
-        if only_active:
-            query = query.filter(User.active == true())
+        if not request:
+            return
 
-        if name_contains:
-            ilike_expression = u'%{}%'.format(safe_unicode(name_contains))
-            query = query.filter(
-                or_(
-                    User.name.ilike(ilike_expression),
-                    User.lastname.ilike(ilike_expression),
-                    User.username.ilike(ilike_expression)
-                )
-            )
-            query = query.limit(limit)
-        users = query.all()
-
-        _users = [
-            {
-                'id': user.user_id,
-                'first_name': user.name,
-                'last_name': user.lastname,
-                'username': user.username,
-                'email': user.email,
-                'icon_link': h.gravatar_url(user.email, 30),
-                'value_display': h.person(user),
-                'value': user.username,
-                'value_type': 'user',
-                'active': user.active,
-            }
-            for user in users
-        ]
-        return _users
+        if permalink:
+            return request.route_url(
+                'repo_summary', repo_name=safe_str(repo.repo_id))
+        else:
+            return request.route_url(
+                'repo_summary', repo_name=safe_str(repo.repo_name))
 
-    def get_user_groups(self, name_contains=None, limit=20, only_active=True):
-
-        # TODO: mikhail: move this method to the UserGroupModel.
-        query = self.sa.query(UserGroup)
-        if only_active:
-            query = query.filter(UserGroup.users_group_active == true())
+    def get_commit_url(self, repo, commit_id, request=None, permalink=False):
+        if not request:
+            request = get_current_request()
 
-        if name_contains:
-            ilike_expression = u'%{}%'.format(safe_unicode(name_contains))
-            query = query.filter(
-                UserGroup.users_group_name.ilike(ilike_expression))\
-                .order_by(func.length(UserGroup.users_group_name))\
-                .order_by(UserGroup.users_group_name)
-
-            query = query.limit(limit)
-        user_groups = query.all()
-        perm_set = ['usergroup.read', 'usergroup.write', 'usergroup.admin']
-        user_groups = UserGroupList(user_groups, perm_set=perm_set)
+        if not request:
+            return
 
-        _groups = [
-            {
-                'id': group.users_group_id,
-                # TODO: marcink figure out a way to generate the url for the
-                # icon
-                'icon_link': '',
-                'value_display': 'Group: %s (%d members)' % (
-                    group.users_group_name, len(group.members),),
-                'value': group.users_group_name,
-                'description': group.user_group_description,
-                'owner': group.user.username,
+        if permalink:
+            return request.route_url(
+                'repo_commit', repo_name=safe_str(repo.repo_id),
+                commit_id=commit_id)
 
-                'owner_icon': h.gravatar_url(group.user.email, 30),
-                'value_display_owner': h.person(group.user.email),
-
-                'value_type': 'user_group',
-                'active': group.users_group_active,
-            }
-            for group in user_groups
-        ]
-        return _groups
+        else:
+            return request.route_url(
+                'repo_commit', repo_name=safe_str(repo.repo_name),
+                commit_id=commit_id)
 
     @classmethod
     def update_repoinfo(cls, repositories=None):
@@ -308,7 +257,7 b' class RepoModel(BaseModel):'
                 "last_changeset": last_rev(repo.repo_name, cs_cache),
                 "last_changeset_raw": cs_cache.get('revision'),
 
-                "desc": desc(repo.description),
+                "desc": desc(repo.description_safe),
                 "owner": user_profile(repo.user.username),
 
                 "state": state(repo.repo_state),
@@ -340,7 +289,7 b' class RepoModel(BaseModel):'
         defaults = repo_info.get_dict()
         defaults['repo_name'] = repo_info.just_name
 
-        groups  = repo_info.groups_with_parents
+        groups = repo_info.groups_with_parents
         parent_group = groups[-1] if groups else None
 
         # we use -1 as this is how in HTML, we mark an empty group
@@ -376,16 +325,6 b' class RepoModel(BaseModel):'
             replacement_user = User.get_first_super_admin().username
             defaults.update({'user': replacement_user})
 
-        # fill repository users
-        for p in repo_info.repo_to_perm:
-            defaults.update({'u_perm_%s' % p.user.user_id:
-                            p.permission.permission_name})
-
-        # fill repository groups
-        for p in repo_info.users_group_to_perm:
-            defaults.update({'g_perm_%s' % p.users_group.users_group_id:
-                            p.permission.permission_name})
-
         return defaults
 
     def update(self, repo, **kwargs):
@@ -414,12 +353,6 b' class RepoModel(BaseModel):'
                     val = kwargs[k]
                     if strip:
                         k = remove_prefix(k, 'repo_')
-                    if k == 'clone_uri':
-                        from rhodecode.model.validators import Missing
-                        _change = kwargs.get('clone_uri_change')
-                        if _change in [Missing, 'OLD']:
-                            # we don't change the value, so use original one
-                            val = cur_repo.clone_uri
 
                     setattr(cur_repo, k, val)
 
@@ -594,10 +527,16 b' class RepoModel(BaseModel):'
 
         req_perms = ('usergroup.read', 'usergroup.write', 'usergroup.admin')
 
+        changes = {
+            'added': [],
+            'updated': [],
+            'deleted': []
+        }
         # update permissions
         for member_id, perm, member_type in perm_updates:
             member_id = int(member_id)
             if member_type == 'user':
+                member_name = User.get(member_id).username
                 # this updates also current one if found
                 self.grant_user_permission(
                     repo=repo, user=member_id, perm=perm)
@@ -609,10 +548,14 b' class RepoModel(BaseModel):'
                     self.grant_user_group_permission(
                         repo=repo, group_name=member_id, perm=perm)
 
+            changes['updated'].append({'type': member_type, 'id': member_id,
+                                       'name': member_name, 'new_perm': perm})
+
         # set new permissions
         for member_id, perm, member_type in perm_additions:
             member_id = int(member_id)
             if member_type == 'user':
+                member_name = User.get(member_id).username
                 self.grant_user_permission(
                     repo=repo, user=member_id, perm=perm)
             else:  # set for user group
@@ -622,11 +565,13 b' class RepoModel(BaseModel):'
                         *req_perms)(member_name, user=cur_user):
                     self.grant_user_group_permission(
                         repo=repo, group_name=member_id, perm=perm)
-
+            changes['added'].append({'type': member_type, 'id': member_id,
+                                     'name': member_name, 'new_perm': perm})
         # delete permissions
         for member_id, perm, member_type in perm_deletions:
             member_id = int(member_id)
             if member_type == 'user':
+                member_name = User.get(member_id).username
                 self.revoke_user_permission(repo=repo, user=member_id)
             else:  # set for user group
                 # check if we have permissions to alter this usergroup
@@ -636,6 +581,10 b' class RepoModel(BaseModel):'
                     self.revoke_user_group_permission(
                         repo=repo, group_name=member_id)
 
+            changes['deleted'].append({'type': member_type, 'id': member_id,
+                                       'name': member_name, 'new_perm': perm})
+        return changes
+
     def create_fork(self, form_data, cur_user):
         """
         Simple wrapper into executing celery task for fork creation

rhodecode/model/repo_group.py

@@ -35,7 +35,7 b' from zope.cachedescriptors.property impo'
 
 from rhodecode import events
 from rhodecode.model import BaseModel
-from rhodecode.model.db import (
+from rhodecode.model.db import (_hash_key,
     RepoGroup, UserRepoGroupToPerm, User, Permission, UserGroupRepoGroupToPerm,
     UserGroup, Repository)
 from rhodecode.model.settings import VcsSettingsModel, SettingsModel
@@ -73,8 +73,9 b' class RepoGroupModel(BaseModel):'
             .filter(RepoGroup.group_name == repo_group_name)
 
         if cache:
-            repo = repo.options(FromCache(
-                "sql_cache_short", "get_repo_group_%s" % repo_group_name))
+            name_key = _hash_key(repo_group_name)
+            repo = repo.options(
+                FromCache("sql_cache_short", "get_repo_group_%s" % name_key))
         return repo.scalar()
 
     def get_default_create_personal_repo_group(self):
@@ -339,6 +340,12 b' class RepoGroupModel(BaseModel):'
 
         req_perms = ('usergroup.read', 'usergroup.write', 'usergroup.admin')
 
+        changes = {
+            'added': [],
+            'updated': [],
+            'deleted': []
+        }
+
         def _set_perm_user(obj, user, perm):
             if isinstance(obj, RepoGroup):
                 self.grant_user_permission(
@@ -381,7 +388,6 b' class RepoGroupModel(BaseModel):'
                     repo=obj, group_name=user_group)
 
         # start updates
-        updates = []
         log.debug('Now updating permissions for %s in recursive mode:%s',
                   repo_group, recursive)
 
@@ -407,10 +413,13 b' class RepoGroupModel(BaseModel):'
                 # in recursive mode
                 obj = repo_group
 
+            change_obj = obj.get_api_data()
+
             # update permissions
             for member_id, perm, member_type in perm_updates:
                 member_id = int(member_id)
                 if member_type == 'user':
+                    member_name = User.get(member_id).username
                     # this updates also current one if found
                     _set_perm_user(obj, user=member_id, perm=perm)
                 else:  # set for user group
@@ -419,10 +428,15 b' class RepoGroupModel(BaseModel):'
                                                          user=cur_user):
                         _set_perm_group(obj, users_group=member_id, perm=perm)
 
+                changes['updated'].append(
+                    {'change_obj': change_obj, 'type': member_type,
+                     'id': member_id, 'name': member_name, 'new_perm': perm})
+
             # set new permissions
             for member_id, perm, member_type in perm_additions:
                 member_id = int(member_id)
                 if member_type == 'user':
+                    member_name = User.get(member_id).username
                     _set_perm_user(obj, user=member_id, perm=perm)
                 else:  # set for user group
                     # check if we have permissions to alter this usergroup
@@ -431,10 +445,15 b' class RepoGroupModel(BaseModel):'
                                                          user=cur_user):
                         _set_perm_group(obj, users_group=member_id, perm=perm)
 
+                changes['added'].append(
+                    {'change_obj': change_obj, 'type': member_type,
+                     'id': member_id, 'name': member_name, 'new_perm': perm})
+
             # delete permissions
             for member_id, perm, member_type in perm_deletions:
                 member_id = int(member_id)
                 if member_type == 'user':
+                    member_name = User.get(member_id).username
                     _revoke_perm_user(obj, user=member_id)
                 else:  # set for user group
                     # check if we have permissions to alter this usergroup
@@ -443,13 +462,16 b' class RepoGroupModel(BaseModel):'
                                                          user=cur_user):
                         _revoke_perm_group(obj, user_group=member_id)
 
-            updates.append(obj)
+                changes['deleted'].append(
+                    {'change_obj': change_obj, 'type': member_type,
+                     'id': member_id, 'name': member_name, 'new_perm': perm})
+
             # if it's not recursive call for all,repos,groups
             # break the loop and don't proceed with other changes
             if recursive not in ['all', 'repos', 'groups']:
                 break
 
-        return updates
+        return changes
 
     def update(self, repo_group, form_data):
         try:
@@ -689,7 +711,7 b' class RepoGroupModel(BaseModel):'
                 "menu": quick_menu(group.group_name),
                 "name": repo_group_lnk(group.group_name),
                 "name_raw": group.group_name,
-                "desc": desc(group.group_description, group.personal),
+                "desc": desc(group.description_safe, group.personal),
                 "top_level_repos": 0,
                 "owner": user_profile(group.user.username)
             }

rhodecode/model/scm.py

@@ -47,7 +47,7 b' from rhodecode.lib.auth import ('
 from rhodecode.lib.exceptions import NonRelativePathError, IMCCommitError
 from rhodecode.lib import hooks_utils, caches
 from rhodecode.lib.utils import (
-    get_filesystem_repos, action_logger, make_db_config)
+    get_filesystem_repos, make_db_config)
 from rhodecode.lib.utils2 import (safe_str, safe_unicode)
 from rhodecode.lib.system_info import get_system_info
 from rhodecode.model import BaseModel
@@ -289,9 +289,6 b' class ScmModel(BaseModel):'
         if f is not None:
             try:
                 self.sa.delete(f)
-                action_logger(UserTemp(user_id),
-                              'stopped_following_repo',
-                              RepoTemp(follow_repo_id))
                 return
             except Exception:
                 log.error(traceback.format_exc())
@@ -302,10 +299,6 b' class ScmModel(BaseModel):'
             f.user_id = user_id
             f.follows_repo_id = follow_repo_id
             self.sa.add(f)
-
-            action_logger(UserTemp(user_id),
-                          'started_following_repo',
-                          RepoTemp(follow_repo_id))
         except Exception:
             log.error(traceback.format_exc())
             raise
@@ -503,7 +496,7 b' class ScmModel(BaseModel):'
 
                     if not flat:
                         _data = {
-                            "name": f.unicode_path,
+                            "name": h.escape(f.unicode_path),
                             "type": "file",
                             }
                         if extended_info:
@@ -529,7 +522,7 b' class ScmModel(BaseModel):'
                     _data = d.unicode_path
                     if not flat:
                         _data = {
-                            "name": d.unicode_path,
+                            "name": h.escape(d.unicode_path),
                             "type": "dir",
                             }
                     if extended_info:

rhodecode/model/settings.py

@@ -18,6 +18,7 b''
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
+import os
 import hashlib
 import logging
 from collections import namedtuple
@@ -51,7 +52,8 b' class SettingsModel(BaseModel):'
     BUILTIN_HOOKS = (
         RhodeCodeUi.HOOK_REPO_SIZE, RhodeCodeUi.HOOK_PUSH,
         RhodeCodeUi.HOOK_PRE_PUSH, RhodeCodeUi.HOOK_PRETX_PUSH,
-        RhodeCodeUi.HOOK_PULL, RhodeCodeUi.HOOK_PRE_PULL)
+        RhodeCodeUi.HOOK_PULL, RhodeCodeUi.HOOK_PRE_PULL,
+        RhodeCodeUi.HOOK_PUSH_KEY,)
     HOOKS_SECTION = 'hooks'
 
     def __init__(self, sa=None, repo=None):
@@ -207,6 +209,7 b' class SettingsModel(BaseModel):'
         caches.clear_cache_manager(cache_manager)
 
     def get_all_settings(self, cache=False):
+
         def _compute():
             q = self._get_settings_query()
             if not q:
@@ -413,15 +416,16 b' class VcsSettingsModel(object):'
         ('hooks', 'outgoing.pull_logger'),)
     HG_SETTINGS = (
         ('extensions', 'largefiles'),
-        ('phases', 'publish'),)
+        ('phases', 'publish'),
+        ('extensions', 'evolve'),)
     GIT_SETTINGS = (
         ('vcs_git_lfs', 'enabled'),)
-
     GLOBAL_HG_SETTINGS = (
         ('extensions', 'largefiles'),
         ('largefiles', 'usercache'),
         ('phases', 'publish'),
-        ('extensions', 'hgsubversion'))
+        ('extensions', 'hgsubversion'),
+        ('extensions', 'evolve'),)
     GLOBAL_GIT_SETTINGS = (
         ('vcs_git_lfs', 'enabled'),
         ('vcs_git_lfs', 'store_location'))
@@ -544,22 +548,26 b' class VcsSettingsModel(object):'
 
     @assert_repo_settings
     def create_or_update_repo_hg_settings(self, data):
-        largefiles, phases = \
+        largefiles, phases, evolve = \
             self.HG_SETTINGS
-        largefiles_key, phases_key = \
+        largefiles_key, phases_key, evolve_key = \
             self._get_settings_keys(self.HG_SETTINGS, data)
 
         self._create_or_update_ui(
             self.repo_settings, *largefiles, value='',
             active=data[largefiles_key])
         self._create_or_update_ui(
+            self.repo_settings, *evolve, value='',
+            active=data[evolve_key])
+        self._create_or_update_ui(
             self.repo_settings, *phases, value=safe_str(data[phases_key]))
 
     def create_or_update_global_hg_settings(self, data):
-        largefiles, largefiles_store, phases, hgsubversion \
+        largefiles, largefiles_store, phases, hgsubversion, evolve \
             = self.GLOBAL_HG_SETTINGS
-        largefiles_key, largefiles_store_key, phases_key, subversion_key \
+        largefiles_key, largefiles_store_key, phases_key, subversion_key, evolve_key \
             = self._get_settings_keys(self.GLOBAL_HG_SETTINGS, data)
+
         self._create_or_update_ui(
             self.global_settings, *largefiles, value='',
             active=data[largefiles_key])
@@ -570,6 +578,9 b' class VcsSettingsModel(object):'
             self.global_settings, *phases, value=safe_str(data[phases_key]))
         self._create_or_update_ui(
             self.global_settings, *hgsubversion, active=data[subversion_key])
+        self._create_or_update_ui(
+            self.global_settings, *evolve, value='',
+            active=data[evolve_key])
 
     def create_or_update_repo_git_settings(self, data):
         # NOTE(marcink): # comma make unpack work properly
@@ -774,3 +785,27 b' class VcsSettingsModel(object):'
                 raise ValueError(
                     'The given data does not contain {} key'.format(data_key))
         return data_keys
+
+    def create_largeobjects_dirs_if_needed(self, repo_store_path):
+        """
+        This is subscribed to the `pyramid.events.ApplicationCreated` event. It
+        does a repository scan if enabled in the settings.
+        """
+
+        from rhodecode.lib.vcs.backends.hg import largefiles_store
+        from rhodecode.lib.vcs.backends.git import lfs_store
+
+        paths = [
+            largefiles_store(repo_store_path),
+            lfs_store(repo_store_path)]
+
+        for path in paths:
+            if os.path.isdir(path):
+                continue
+            if os.path.isfile(path):
+                continue
+            # not a file nor dir, we try to create it
+            try:
+                os.makedirs(path)
+            except Exception:
+                log.warning('Failed to create largefiles dir:%s', path)

rhodecode/model/user.py

@@ -30,21 +30,21 b' from pylons.i18n.translation import _'
 
 import ipaddress
 from sqlalchemy.exc import DatabaseError
-from sqlalchemy.sql.expression import true, false
 
 from rhodecode import events
 from rhodecode.lib.user_log_filter import user_log_filter
 from rhodecode.lib.utils2 import (
     safe_unicode, get_current_rhodecode_user, action_logger_generic,
     AttributeDict, str2bool)
+from rhodecode.lib.exceptions import (
+    DefaultUserException, UserOwnsReposException, UserOwnsRepoGroupsException,
+    UserOwnsUserGroupsException, NotAllowedToCreateUserError)
 from rhodecode.lib.caching_query import FromCache
 from rhodecode.model import BaseModel
 from rhodecode.model.auth_token import AuthTokenModel
 from rhodecode.model.db import (
-    or_, joinedload, User, UserToPerm, UserEmailMap, UserIpMap, UserLog)
-from rhodecode.lib.exceptions import (
-    DefaultUserException, UserOwnsReposException, UserOwnsRepoGroupsException,
-    UserOwnsUserGroupsException, NotAllowedToCreateUserError)
+    _hash_key, true, false, or_, joinedload, User, UserToPerm,
+    UserEmailMap, UserIpMap, UserLog)
 from rhodecode.model.meta import Session
 from rhodecode.model.repo_group import RepoGroupModel
 
@@ -58,13 +58,52 b' class UserModel(BaseModel):'
     def get(self, user_id, cache=False):
         user = self.sa.query(User)
         if cache:
-            user = user.options(FromCache("sql_cache_short",
-                                          "get_user_%s" % user_id))
+            user = user.options(
+                FromCache("sql_cache_short", "get_user_%s" % user_id))
         return user.get(user_id)
 
     def get_user(self, user):
         return self._get_user(user)
 
+    def _serialize_user(self, user):
+        import rhodecode.lib.helpers as h
+
+        return {
+            'id': user.user_id,
+            'first_name': user.first_name,
+            'last_name': user.last_name,
+            'username': user.username,
+            'email': user.email,
+            'icon_link': h.gravatar_url(user.email, 30),
+            'value_display': h.escape(h.person(user)),
+            'value': user.username,
+            'value_type': 'user',
+            'active': user.active,
+        }
+
+    def get_users(self, name_contains=None, limit=20, only_active=True):
+
+        query = self.sa.query(User)
+        if only_active:
+            query = query.filter(User.active == true())
+
+        if name_contains:
+            ilike_expression = u'%{}%'.format(safe_unicode(name_contains))
+            query = query.filter(
+                or_(
+                    User.name.ilike(ilike_expression),
+                    User.lastname.ilike(ilike_expression),
+                    User.username.ilike(ilike_expression)
+                )
+            )
+            query = query.limit(limit)
+        users = query.all()
+
+        _users = [
+            self._serialize_user(user) for user in users
+        ]
+        return _users
+
     def get_by_username(self, username, cache=False, case_insensitive=False):
 
         if case_insensitive:
@@ -73,8 +112,9 b' class UserModel(BaseModel):'
             user = self.sa.query(User)\
                 .filter(User.username == username)
         if cache:
-            user = user.options(FromCache("sql_cache_short",
-                                          "get_user_%s" % username))
+            name_key = _hash_key(username)
+            user = user.options(
+                FromCache("sql_cache_short", "get_user_%s" % name_key))
         return user.scalar()
 
     def get_by_email(self, email, cache=False, case_insensitive=False):
@@ -630,7 +670,8 b' class UserModel(BaseModel):'
                     user_id, api_key, username)
                 return False
             if not dbuser.active:
-                log.debug('User `%s` is inactive, skipping fill data', username)
+                log.debug('User `%s:%s` is inactive, skipping fill data',
+                          username, user_id)
                 return False
 
             log.debug('filling user:%s data', dbuser)
@@ -638,6 +679,11 b' class UserModel(BaseModel):'
             # TODO: johbo: Think about this and find a clean solution
             user_data = dbuser.get_dict()
             user_data.update(dbuser.get_api_data(include_secrets=True))
+            user_data.update({
+                # set explicit the safe escaped values
+                'first_name': dbuser.first_name,
+                'last_name': dbuser.last_name,
+            })
 
             for k, v in user_data.iteritems():
                 # properties of auth user we dont update
@@ -726,7 +772,7 b' class UserModel(BaseModel):'
         """
         user = self._get_user(user)
         obj = UserEmailMap.query().get(email_id)
-        if obj:
+        if obj and obj.user_id == user.user_id:
             self.sa.delete(obj)
 
     def parse_ip_range(self, ip_range):
@@ -783,7 +829,7 b' class UserModel(BaseModel):'
         """
         user = self._get_user(user)
         obj = UserIpMap.query().get(ip_id)
-        if obj:
+        if obj and obj.user_id == user.user_id:
             self.sa.delete(obj)
 
     def get_accounts_in_creation_order(self, current_user=None):

rhodecode/model/user_group.py

@@ -27,14 +27,18 b' user group model for RhodeCode'
 import logging
 import traceback
 
-from rhodecode.lib.utils2 import safe_str
+from rhodecode.lib.utils2 import safe_str, safe_unicode
+from rhodecode.lib.exceptions import (
+    UserGroupAssignedException, RepoGroupAssignmentError)
+from rhodecode.lib.utils2 import (
+    get_current_rhodecode_user, action_logger_generic)
 from rhodecode.model import BaseModel
-from rhodecode.model.db import UserGroupMember, UserGroup,\
-    UserGroupRepoToPerm, Permission, UserGroupToPerm, User, UserUserGroupToPerm,\
-    UserGroupUserGroupToPerm, UserGroupRepoGroupToPerm
-from rhodecode.lib.exceptions import UserGroupAssignedException,\
-    RepoGroupAssignmentError
-from rhodecode.lib.utils2 import get_current_rhodecode_user, action_logger_generic
+from rhodecode.model.scm import UserGroupList
+from rhodecode.model.db import (
+    true, func, User, UserGroupMember, UserGroup,
+    UserGroupRepoToPerm, Permission, UserGroupToPerm, UserUserGroupToPerm,
+    UserGroupUserGroupToPerm, UserGroupRepoGroupToPerm)
+
 
 log = logging.getLogger(__name__)
 
@@ -112,7 +116,7 b' class UserGroupModel(BaseModel):'
             if member_type == 'user':
                 self.revoke_user_permission(user_group=user_group, user=member_id)
             else:
-                #check if we have permissions to alter this usergroup
+                # check if we have permissions to alter this usergroup
                 member_name = UserGroup.get(member_id).users_group_name
                 if not check_perms or HasUserGroupPermissionAny(*req_perms)(member_name, user=cur_user):
                     self.revoke_user_group_permission(
@@ -171,7 +175,7 b' class UserGroupModel(BaseModel):'
                 user_id for user_id in current_members_ids
                 if user_id not in user_id_list]
 
-        return (added_members, deleted_members)
+        return added_members, deleted_members
 
     def _set_users_as_members(self, user_group, user_ids):
         user_group.members = []
@@ -187,6 +191,7 b' class UserGroupModel(BaseModel):'
         self._set_users_as_members(user_group, user_ids)
         self._log_user_changes('added to', user_group, added)
         self._log_user_changes('removed from', user_group, removed)
+        return added, removed
 
     def _clean_members_data(self, members_data):
         if not members_data:
@@ -221,12 +226,16 b' class UserGroupModel(BaseModel):'
 
             user_group.user = owner
 
+        added_user_ids = []
+        removed_user_ids = []
         if 'users_group_members' in form_data:
             members_id_list = self._clean_members_data(
                 form_data['users_group_members'])
-            self._update_members_from_user_ids(user_group, members_id_list)
+            added_user_ids, removed_user_ids = \
+                self._update_members_from_user_ids(user_group, members_id_list)
 
         self.sa.add(user_group)
+        return user_group, added_user_ids, removed_user_ids
 
     def delete(self, user_group, force=False):
         """
@@ -539,6 +548,59 b' class UserGroupModel(BaseModel):'
             log.debug('Adding user %s to user group %s', user.username, gr.users_group_name)
             UserGroupModel().add_user_to_group(gr.users_group_name, user.username)
 
+    def _serialize_user_group(self, user_group):
+        import rhodecode.lib.helpers as h
+        return {
+                'id': user_group.users_group_id,
+                # TODO: marcink figure out a way to generate the url for the
+                # icon
+                'icon_link': '',
+                'value_display': 'Group: %s (%d members)' % (
+                    user_group.users_group_name, len(user_group.members),),
+                'value': user_group.users_group_name,
+                'description': user_group.user_group_description,
+                'owner': user_group.user.username,
+
+                'owner_icon': h.gravatar_url(user_group.user.email, 30),
+                'value_display_owner': h.person(user_group.user.email),
+
+                'value_type': 'user_group',
+                'active': user_group.users_group_active,
+            }
+
+    def get_user_groups(self, name_contains=None, limit=20, only_active=True,
+                        expand_groups=False):
+        query = self.sa.query(UserGroup)
+        if only_active:
+            query = query.filter(UserGroup.users_group_active == true())
+
+        if name_contains:
+            ilike_expression = u'%{}%'.format(safe_unicode(name_contains))
+            query = query.filter(
+                UserGroup.users_group_name.ilike(ilike_expression))\
+                .order_by(func.length(UserGroup.users_group_name))\
+                .order_by(UserGroup.users_group_name)
+
+            query = query.limit(limit)
+        user_groups = query.all()
+        perm_set = ['usergroup.read', 'usergroup.write', 'usergroup.admin']
+        user_groups = UserGroupList(user_groups, perm_set=perm_set)
+
+        # store same serialize method to extract data from User
+        from rhodecode.model.user import UserModel
+        serialize_user = UserModel()._serialize_user
+
+        _groups = []
+        for group in user_groups:
+            entry = self._serialize_user_group(group)
+            if expand_groups:
+                expanded_members = []
+                for member in group.members:
+                    expanded_members.append(serialize_user(member.user))
+                entry['members'] = expanded_members
+            _groups.append(entry)
+        return _groups
+
     @staticmethod
     def get_user_groups_as_dict(user_group):
         import rhodecode.lib.helpers as h
@@ -550,7 +612,9 b' class UserGroupModel(BaseModel):'
             'active': user_group.users_group_active,
             "owner": user_group.user.username,
             'owner_icon': h.gravatar_url(user_group.user.email, 30),
-            "owner_data": {'owner': user_group.user.username, 'owner_icon': h.gravatar_url(user_group.user.email, 30)}
+            "owner_data": {
+                'owner': user_group.user.username,
+                'owner_icon': h.gravatar_url(user_group.user.email, 30)}
             }
         return data
 

rhodecode/model/validation_schema/schemas/repo_schema.py

@@ -19,8 +19,10 b''
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
 import colander
+import deform.widget
 
 from rhodecode.translation import _
+from rhodecode.model.validation_schema.utils import convert_to_optgroup
 from rhodecode.model.validation_schema import validators, preparers, types
 
 DEFAULT_LANDING_REF = 'rev:tip'
@@ -32,6 +34,11 b' def get_group_and_repo(repo_name):'
         repo_name, get_object=True)
 
 
+def get_repo_group(repo_group_id):
+    from rhodecode.model.repo_group import RepoGroup
+    return RepoGroup.get(repo_group_id), RepoGroup.CHOICES_SEPARATOR
+
+
 @colander.deferred
 def deferred_repo_type_validator(node, kw):
     options = kw.get('repo_type_options', [])
@@ -53,11 +60,27 b' def deferred_repo_owner_validator(node, '
 
 @colander.deferred
 def deferred_landing_ref_validator(node, kw):
-    options = kw.get('repo_ref_options', [DEFAULT_LANDING_REF])
+    options = kw.get(
+        'repo_ref_options', [DEFAULT_LANDING_REF])
     return colander.OneOf([x for x in options])
 
 
 @colander.deferred
+def deferred_clone_uri_validator(node, kw):
+    repo_type = kw.get('repo_type')
+    validator = validators.CloneUriValidator(repo_type)
+    return validator
+
+
[e-mail]
+def deferred_landing_ref_widget(node, kw):
+    items = kw.get(
+        'repo_ref_items', [(DEFAULT_LANDING_REF, DEFAULT_LANDING_REF)])
+    items = convert_to_optgroup(items)
+    return deform.widget.Select2Widget(values=items)
+
+
[e-mail]
 def deferred_fork_of_validator(node, kw):
     old_values = kw.get('old_values') or {}
 
@@ -191,7 +214,25 b' def deferred_unique_name_validator(node,'
 
 @colander.deferred
 def deferred_repo_name_validator(node, kw):
-    return validators.valid_name_validator
+    def no_git_suffix_validator(node, value):
+        if value.endswith('.git'):
+            msg = _('Repository name cannot end with .git')
+            raise colander.Invalid(node, msg)
+    return colander.All(
+        no_git_suffix_validator, validators.valid_name_validator)
+
+
[e-mail]
+def deferred_repo_group_validator(node, kw):
+    options = kw.get(
+        'repo_repo_group_options')
+    return colander.OneOf([x for x in options])
+
+
[e-mail]
+def deferred_repo_group_widget(node, kw):
+    items = kw.get('repo_repo_group_items')
+    return deform.widget.Select2Widget(values=items)
 
 
 class GroupType(colander.Mapping):
@@ -215,8 +256,10 b' class GroupType(colander.Mapping):'
          parent_group_name,
          parent_group) = get_group_and_repo(validated_name)
 
+        appstruct['repo_name_with_group'] = validated_name
         appstruct['repo_name_without_group'] = repo_name_without_group
         appstruct['repo_group_name'] = parent_group_name or types.RootLocation
+
         if parent_group:
             appstruct['repo_group_id'] = parent_group.group_id
 
@@ -260,16 +303,19 b' class RepoSchema(colander.MappingSchema)'
 
     repo_owner = colander.SchemaNode(
         colander.String(),
-        validator=deferred_repo_owner_validator)
+        validator=deferred_repo_owner_validator,
+        widget=deform.widget.TextInputWidget())
 
     repo_description = colander.SchemaNode(
-        colander.String(), missing='')
+        colander.String(), missing='',
+        widget=deform.widget.TextAreaWidget())
 
     repo_landing_commit_ref = colander.SchemaNode(
         colander.String(),
         validator=deferred_landing_ref_validator,
         preparers=[preparers.strip_preparer],
-        missing=DEFAULT_LANDING_REF)
+        missing=DEFAULT_LANDING_REF,
+        widget=deferred_landing_ref_widget)
 
     repo_clone_uri = colander.SchemaNode(
         colander.String(),
@@ -284,19 +330,19 b' class RepoSchema(colander.MappingSchema)'
 
     repo_private = colander.SchemaNode(
         types.StringBooleanType(),
-        missing=False)
+        missing=False, widget=deform.widget.CheckboxWidget())
     repo_copy_permissions = colander.SchemaNode(
         types.StringBooleanType(),
-        missing=False)
+        missing=False, widget=deform.widget.CheckboxWidget())
     repo_enable_statistics = colander.SchemaNode(
         types.StringBooleanType(),
-        missing=False)
+        missing=False, widget=deform.widget.CheckboxWidget())
     repo_enable_downloads = colander.SchemaNode(
         types.StringBooleanType(),
-        missing=False)
+        missing=False, widget=deform.widget.CheckboxWidget())
     repo_enable_locking = colander.SchemaNode(
         types.StringBooleanType(),
-        missing=False)
+        missing=False, widget=deform.widget.CheckboxWidget())
 
     def deserialize(self, cstruct):
         """
@@ -319,3 +365,50 b' class RepoSchema(colander.MappingSchema)'
         third.deserialize({'unique_repo_name': validated_name})
 
         return appstruct
+
+
+class RepoSettingsSchema(RepoSchema):
+    repo_group = colander.SchemaNode(
+        colander.Integer(),
+        validator=deferred_repo_group_validator,
+        widget=deferred_repo_group_widget,
+        missing='')
+
+    repo_clone_uri_change = colander.SchemaNode(
+        colander.String(),
+        missing='NEW')
+
+    repo_clone_uri = colander.SchemaNode(
+        colander.String(),
+        preparers=[preparers.strip_preparer],
+        validator=deferred_clone_uri_validator,
+        missing='')
+
+    def deserialize(self, cstruct):
+        """
+        Custom deserialize that allows to chain validation, and verify
+        permissions, and as last step uniqueness
+        """
+
+        # first pass, to validate given data
+        appstruct = super(RepoSchema, self).deserialize(cstruct)
+        validated_name = appstruct['repo_name']
+        # because of repoSchema adds repo-group as an ID, we inject it as
+        # full name here because validators require it, it's unwrapped later
+        # so it's safe to use and final name is going to be without group anyway
+
+        group, separator = get_repo_group(appstruct['repo_group'])
+        if group:
+            validated_name = separator.join([group.group_name, validated_name])
+
+        # second pass to validate permissions to repo_group
+        second = RepoGroupAccessSchema().bind(**self.bindings)
+        appstruct_second = second.deserialize({'repo_group': validated_name})
+        # save result
+        appstruct['repo_group'] = appstruct_second['repo_group']
+
+        # thirds to validate uniqueness
+        third = RepoNameUniqueSchema().bind(**self.bindings)
+        third.deserialize({'unique_repo_name': validated_name})
+
+        return appstruct

rhodecode/model/validation_schema/schemas/user_schema.py

@@ -18,10 +18,12 b''
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
+import re
 import colander
 
 from rhodecode import forms
 from rhodecode.model.db import User
+from rhodecode.model.validation_schema import types, validators
 from rhodecode.translation import _
 from rhodecode.lib.auth import check_password
 
@@ -52,10 +54,72 b' class ChangePasswordSchema(colander.Sche'
         widget=forms.widget.CheckedPasswordWidget(redisplay=True),
         validator=colander.Length(min=6))
 
-
     def validator(self, form, values):
         if values['current_password'] == values['new_password']:
             exc = colander.Invalid(form)
             exc['new_password'] = _('New password must be different '
                                     'to old password')
             raise exc
+
+
[e-mail]
+def deferred_username_validator(node, kw):
+
+    def name_validator(node, value):
+        msg = _(
+            u'Username may only contain alphanumeric characters '
+            u'underscores, periods or dashes and must begin with '
+            u'alphanumeric character or underscore')
+
+        if not re.match(r'^[\w]{1}[\w\-\.]{0,254}$', value):
+            raise colander.Invalid(node, msg)
+
+    return name_validator
+
+
[e-mail]
+def deferred_email_validator(node, kw):
+    # NOTE(marcink): we might provide uniqueness validation later here...
+    return colander.Email()
+
+
+class UserSchema(colander.Schema):
+    username = colander.SchemaNode(
+        colander.String(),
+        validator=deferred_username_validator)
+
+    email = colander.SchemaNode(
+        colander.String(),
+        validator=deferred_email_validator)
+
+    password = colander.SchemaNode(
+        colander.String(), missing='')
+
+    first_name = colander.SchemaNode(
+        colander.String(), missing='')
+
+    last_name = colander.SchemaNode(
+        colander.String(), missing='')
+
+    active = colander.SchemaNode(
+        types.StringBooleanType(),
+        missing=False)
+
+    admin = colander.SchemaNode(
+        types.StringBooleanType(),
+        missing=False)
+
+    extern_name = colander.SchemaNode(
+        colander.String(), missing='')
+
+    extern_type = colander.SchemaNode(
+        colander.String(), missing='')
+
+    def deserialize(self, cstruct):
+        """
+        Custom deserialize that allows to chain validation, and verify
+        permissions, and as last step uniqueness
+        """
+
+        appstruct = super(UserSchema, self).deserialize(cstruct)
+        return appstruct

rhodecode/model/validation_schema/types.py

@@ -190,7 +190,7 b' class UserGroupType(UserOrUserGroupType)'
 
 class StrOrIntType(colander.String):
     def deserialize(self, node, cstruct):
-        if isinstance(node, basestring):
+        if isinstance(cstruct, basestring):
             return super(StrOrIntType, self).deserialize(node, cstruct)
         else:
             return colander.Integer().deserialize(node, cstruct)

rhodecode/model/validation_schema/validators.py

@@ -1,5 +1,27 b''
+# -*- coding: utf-8 -*-
+
+# Copyright (C) 2011-2017 RhodeCode GmbH
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License, version 3
+# (only), as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# This program is dual-licensed. If you wish to learn more about the
+# RhodeCode Enterprise Edition, including its added features, Support services,
+# and proprietary license terms, please see https://rhodecode.com/licenses/
+
 import os
 import re
+import logging
+
 
 import ipaddress
 import colander
@@ -7,6 +29,8 b' import colander'
 from rhodecode.translation import _
 from rhodecode.lib.utils2 import glob2re
 
+log = logging.getLogger(__name__)
+
 
 def ip_addr_validator(node, value):
     try:
@@ -46,3 +70,71 b' def valid_name_validator(node, value):'
     msg = _('Name must start with a letter or number. Got `{}`').format(value)
     if not re.match(r'^[a-zA-z0-9]{1,}', value):
         raise colander.Invalid(node, msg)
+
+
+class InvalidCloneUrl(Exception):
+    allowed_prefixes = ()
+
+
+def url_validator(url, repo_type, config):
+    from rhodecode.lib.vcs.backends.hg import MercurialRepository
+    from rhodecode.lib.vcs.backends.git import GitRepository
+    from rhodecode.lib.vcs.backends.svn import SubversionRepository
+
+    if repo_type == 'hg':
+        allowed_prefixes = ('http', 'svn+http', 'git+http')
+
+        if 'http' in url[:4]:
+            # initially check if it's at least the proper URL
+            # or does it pass basic auth
+
+            MercurialRepository.check_url(url, config)
+        elif 'svn+http' in url[:8]:  # svn->hg import
+            SubversionRepository.check_url(url, config)
+        elif 'git+http' in url[:8]:  # git->hg import
+            raise NotImplementedError()
+        else:
+            exc = InvalidCloneUrl('Clone from URI %s not allowed. '
+                                  'Allowed url must start with one of %s'
+                                  % (url, ','.join(allowed_prefixes)))
+            exc.allowed_prefixes = allowed_prefixes
+            raise exc
+
+    elif repo_type == 'git':
+        allowed_prefixes = ('http', 'svn+http', 'hg+http')
+        if 'http' in url[:4]:
+            # initially check if it's at least the proper URL
+            # or does it pass basic auth
+            GitRepository.check_url(url, config)
+        elif 'svn+http' in url[:8]:  # svn->git import
+            raise NotImplementedError()
+        elif 'hg+http' in url[:8]:  # hg->git import
+            raise NotImplementedError()
+        else:
+            exc = InvalidCloneUrl('Clone from URI %s not allowed. '
+                                  'Allowed url must start with one of %s'
+                                  % (url, ','.join(allowed_prefixes)))
+            exc.allowed_prefixes = allowed_prefixes
+            raise exc
+
+
+class CloneUriValidator(object):
+    def __init__(self, repo_type):
+        self.repo_type = repo_type
+
+    def __call__(self, node, value):
+        from rhodecode.lib.utils import make_db_config
+        try:
+            config = make_db_config(clear_session=False)
+            url_validator(value, self.repo_type, config)
+        except InvalidCloneUrl as e:
+            log.warning(e)
+            msg = _(u'Invalid clone url, provide a valid clone '
+                    u'url starting with one of {allowed_prefixes}').format(
+                allowed_prefixes=e.allowed_prefixes)
+            raise colander.Invalid(node, msg)
+        except Exception:
+            log.exception('Url validation failed')
+            msg = _(u'invalid clone url for {repo_type} repository').format(
+                repo_type=self.repo_type)
+            raise colander.Invalid(node, msg)

rhodecode/model/validators.py

@@ -574,6 +574,26 b' def SlugifyName():'
     return _validator
 
 
+def CannotHaveGitSuffix():
+    class _validator(formencode.validators.FancyValidator):
+        messages = {
+            'has_git_suffix':
+                _(u'Repository name cannot end with .git'),
+        }
+
+        def _to_python(self, value, state):
+            return value
+
+        def validate_python(self, value, state):
+            if value and value.endswith('.git'):
+                msg = M(
+                    self, 'has_git_suffix', state)
+                raise formencode.Invalid(
+                    msg, value, state, error_dict={'repo_name': msg})
+
+    return _validator
+
+
 def ValidCloneUri():
     class InvalidCloneUrl(Exception):
         allowed_prefixes = ()
@@ -764,7 +784,8 b" def ValidPerms(type_='repo'):"
                 del_member = perm_dict.get('id')
                 del_type = perm_dict.get('type')
                 if del_member and del_type:
-                    perm_deletions.add((del_member, None, del_type))
+                    perm_deletions.add(
+                        (del_member, None, del_type))
 
             # store additions in order of how they were added in web form
             for k in sorted(new_perms_group.keys()):
@@ -773,36 +794,48 b" def ValidPerms(type_='repo'):"
                 new_type = perm_dict.get('type')
                 new_perm = perm_dict.get('perm')
                 if new_member and new_perm and new_type:
-                    perm_additions.add((new_member, new_perm, new_type))
+                    perm_additions.add(
+                        (new_member, new_perm, new_type))
 
             # get updates of permissions
             # (read the existing radio button states)
+            default_user_id = User.get_default_user().user_id
             for k, update_value in value.iteritems():
                 if k.startswith('u_perm_') or k.startswith('g_perm_'):
                     member = k[7:]
                     update_type = {'u': 'user',
                                    'g': 'users_group'}[k[0]]
-                    if member == User.DEFAULT_USER:
+
+                    if safe_int(member) == default_user_id:
                         if str2bool(value.get('repo_private')):
-                            # set none for default when updating to
-                            # private repo protects agains form manipulation
+                            # prevent from updating default user permissions
+                            # when this repository is marked as private
                             update_value = EMPTY_PERM
-                    perm_updates.add((member, update_value, update_type))
-            # check the deletes
 
-            value['perm_additions'] = list(perm_additions)
+                    perm_updates.add(
+                        (member, update_value, update_type))
+
+            value['perm_additions'] = []  # propagated later
             value['perm_updates'] = list(perm_updates)
             value['perm_deletions'] = list(perm_deletions)
 
-            # validate users they exist and they are active !
-            for member_id, _perm, member_type in perm_additions:
+            updates_map = dict(
+                (x[0], (x[1], x[2])) for x in value['perm_updates'])
+            # make sure Additions don't override updates.
+            for member_id, perm, member_type in list(perm_additions):
+                if member_id in updates_map:
+                    perm = updates_map[member_id][0]
+                value['perm_additions'].append((member_id, perm, member_type))
+
+                # on new entries validate users they exist and they are active !
+                # this leaves feedback to the form
                 try:
                     if member_type == 'user':
-                        self.user_db = User.query()\
+                        User.query()\
                             .filter(User.active == true())\
                             .filter(User.user_id == member_id).one()
                     if member_type == 'users_group':
-                        self.user_db = UserGroup.query()\
+                        UserGroup.query()\
                             .filter(UserGroup.users_group_active == true())\
                             .filter(UserGroup.users_group_id == member_id)\
                             .one()

rhodecode/public/css/buttons.less

@@ -62,6 +62,10 b' input[type="button"] {'
         text-shadow: none;
     }
 
+    &.no-margin {
+        margin: 0 0 0 0;
+    }
+
 }
 
 
@@ -270,11 +274,17 b' input[type="button"] {'
     font-size: inherit;
     color: @rcblue;
     border: none;
-    .border-radius (0);
+    border-radius: 0;
     background-color: transparent;
 
+    &.last-item {
+        border: none;
+        padding: 0 0 0 0;
+    }
+
     &:last-child {
         border: none;
+        padding: 0 0 0 0;
     }
 
     &:hover {

rhodecode/public/css/deform.less

@@ -12,7 +12,7 b''
 
   .control-label {
     width: 200px;
-    padding: 10px;
+    padding: 10px 0px;
     float: left;
   }
   .control-inputs {

rhodecode/public/css/legacy_code_styles.less

@@ -165,6 +165,7 b' div.markdown-block h6 {'
 div.markdown-block hr {
     border: 0;
     color: #e6e5e5;
+    background-color: #e6e5e5;
     height: 3px;
     margin-bottom: 13px;
 }
@@ -200,6 +201,12 b' div.markdown-block img {'
   background-color: #fff;
 }
 
+
+div.markdown-block strong {
+  font-weight: 600;
+  margin: 0;
+}
+
 div.markdown-block ul,
 div.markdown-block ol {
     padding-left: 30px !important;
@@ -210,7 +217,7 b' div.markdown-block ol {'
 div.markdown-block ul li,
 div.markdown-block ol li {
     list-style: disc !important;
-    margin: 13px !important;
+    margin: 6px !important;
     padding: 0 !important;
 }
 

rhodecode/public/css/main.less

@@ -11,6 +11,7 b''
 @import 'form-bootstrap';
 @import 'codemirror';
 @import 'legacy_code_styles';
+@import 'readme-box';
 @import 'progress-bar';
 
 @import 'type';
@@ -358,9 +359,26 b' ul.auth_plugins {'
     }
 }
 
+.pr-mergeinfo {
+    clear: both;
+    margin: .5em 0;
+
+    input {
+      min-width: 100% !important;
+      padding: 0 !important;
+      border: 0;
+    }
+}
+
 .pr-pullinfo {
     clear: both;
     margin: .5em 0;
+
+    input {
+      min-width: 100% !important;
+      padding: 0 !important;
+      border: 0;
+    }
 }
 
 #pr-title-input {
@@ -1297,6 +1315,11 b' table.integrations {'
     width: 100%;
     margin-bottom: 8px;
 }
+
+.reviewer_entry {
+  min-height: 55px;
+}
+
 .reviewers_member {
     width: 100%;
     overflow: auto;
@@ -1331,6 +1354,8 b' table.integrations {'
     }
 }
 
+.reviewer_member_mandatory,
+.reviewer_member_mandatory_remove,
 .reviewer_member_remove {
     position: absolute;
     right: 0;
@@ -1340,6 +1365,15 b' table.integrations {'
     padding: 0;
     color: black;
 }
+
+.reviewer_member_mandatory_remove {
+  color: @grey4;
+}
+
+.reviewer_member_mandatory {
+  padding-top:20px;
+}
+
 .reviewer_member_status {
     margin-top: 5px;
 }
@@ -1369,6 +1403,11 b' table.integrations {'
 .pr-description {
     white-space:pre-wrap;
 }
+
+.pr-reviewer-rules {
+   padding: 10px 0px 20px 0px;
+}
+
 .group_members {
     margin-top: 0;
     padding: 0;
@@ -2008,6 +2047,10 b' BIN_FILENODE = 7'
             input {
                 display: none;
             }
+          margin-top: 10px;
+        }
+        .file-upload-label {
+          margin-top: 10px;
         }
         p {
             margin-top: 5px;

rhodecode/public/css/navigation.less

@@ -558,6 +558,8 b' ul#context-pages {'
 .dataTables_processing {
     text-align: center;
     font-size: 1.1em;
+    position: relative;
+    top: 95px;
 }
 
 .dataTables_paginate, .pagination-wh {

rhodecode/public/css/panels.less

@@ -42,6 +42,10 b''
 
     .panel-body {
         padding: @panel-padding;
+
+        &.panel-body-min-height {
+            min-height: 150px
+        }
     }
     
     .panel-footer {

rhodecode/public/css/summary.less

@@ -57,9 +57,13 b''
           white-space: pre-wrap;
         }
 
-        #clone_url,
+        #clone_url {
+            width: ~"calc(100% - 96px)";
+            padding:  @padding/4;
+        }
+
         #clone_url_id {
-            min-width: 29em;
+            width: ~"calc(100% - 118px)";
             padding:  @padding/4;
         }
 
@@ -211,6 +215,7 b''
     float: left;
     display: block;
     position: relative;
+    width: 100%;
 
     // adds some space to make copy and paste easier
     .left-label,

rhodecode/public/css/tables.less

@@ -108,6 +108,11 b' table.dataTable {'
         &.td-hash {
             min-width: 80px;
             width: 200px;
+
+            .obsolete {
+                text-decoration: line-through;
+                color: lighten(@grey2,25%);
+            }
         }
 
         &.td-time {

rhodecode/public/css/tags.less

@@ -98,4 +98,12 b''
     &.admin {
         &:extend(.tag5);
     }
-}
  No newline at end of file
+}
+
+.phase-draft {
+  color: @color3
+}
+
+.phase-secret {
+  color:@grey3
+}

rhodecode/public/js/rhodecode/base/keyboard-bindings.js

@@ -62,7 +62,7 b' function setRCMouseBindings(repoName, re'
         // nav in repo context
         Mousetrap.bind(['g s'], function(e) {
             window.location = pyroutes.url(
-                'summary_home', {'repo_name': repoName});
+                'repo_summary', {'repo_name': repoName});
         });
         Mousetrap.bind(['g c'], function(e) {
             window.location = pyroutes.url(

rhodecode/public/js/rhodecode/i18n/be.js

@@ -7,8 +7,14 b''
 var _TM = {
     '(from usergroup {0})': '(from usergroup {0})',
     'Add another comment': 'Add another comment',
+    'Adding new reviewers is forbidden.': 'Adding new reviewers is forbidden.',
+    'All reviewers must vote.': 'All reviewers must vote.',
+    'At least {0} reviewer must vote.': 'At least {0} reviewer must vote.',
+    'At least {0} reviewers must vote.': 'At least {0} reviewers must vote.',
+    'Author is not allowed to be a reviewer.': 'Author is not allowed to be a reviewer.',
     'Close': 'Close',
     'Comment text will be set automatically based on currently selected status ({0}) ...': 'Comment text will be set automatically based on currently selected status ({0}) ...',
+    'Commit Authors are not allowed to be a reviewer.': 'Commit Authors are not allowed to be a reviewer.',
     'Delete this comment?': 'Delete this comment?',
     'Diff to Commit ': 'Diff to Commit ',
     'Follow': 'Follow',
@@ -38,6 +44,7 b' var _TM = {'
     'Please delete {0} characters': 'Please delete {0} characters',
     'Please enter {0} or more character': 'Please enter {0} or more character',
     'Please enter {0} or more characters': 'Please enter {0} or more characters',
+    'Reviewers picked from source code changes.': 'Reviewers picked from source code changes.',
     'Saving...': 'Saving...',
     'Searching...': 'Searching...',
     'Selection link': 'Selection link',
@@ -59,6 +66,7 b' var _TM = {'
     'There are currently no open pull requests requiring your participation.': 'There are currently no open pull requests requiring your participation.',
     'Unfollow': 'Unfollow',
     'Updating...': 'Updating...',
+    'User `{0}` not allowed to be a reviewer': 'User `{0}` not allowed to be a reviewer',
     'You can only select {0} item': 'You can only select {0} item',
     'You can only select {0} items': 'You can only select {0} items',
     'added manually by "{0}"': 'added manually by "{0}"',
@@ -71,6 +79,7 b' var _TM = {'
     'in {0}, {1}': 'in {0}, {1}',
     'just now': 'just now',
     'loading...': 'loading...',
+    'member of "{0}"': 'member of "{0}"',
     'resolve comment': 'resolve comment',
     'showing {0} out of {1} commit': 'showing {0} out of {1} commit',
     'showing {0} out of {1} commits': 'showing {0} out of {1} commits',

rhodecode/public/js/rhodecode/i18n/de.js

@@ -7,8 +7,14 b''
 var _TM = {
     '(from usergroup {0})': '(from usergroup {0})',
     'Add another comment': 'Add another comment',
+    'Adding new reviewers is forbidden.': 'Adding new reviewers is forbidden.',
+    'All reviewers must vote.': 'All reviewers must vote.',
+    'At least {0} reviewer must vote.': 'At least {0} reviewer must vote.',
+    'At least {0} reviewers must vote.': 'At least {0} reviewers must vote.',
+    'Author is not allowed to be a reviewer.': 'Author is not allowed to be a reviewer.',
     'Close': 'Close',
     'Comment text will be set automatically based on currently selected status ({0}) ...': 'Comment text will be set automatically based on currently selected status ({0}) ...',
+    'Commit Authors are not allowed to be a reviewer.': 'Commit Authors are not allowed to be a reviewer.',
     'Delete this comment?': 'Delete this comment?',
     'Diff to Commit ': 'Diff to Commit ',
     'Follow': 'Follow',
@@ -38,6 +44,7 b' var _TM = {'
     'Please delete {0} characters': 'Bitte {0} Zeichen löschen',
     'Please enter {0} or more character': 'Bitte {0} oder mehr Zeichen eingeben',
     'Please enter {0} or more characters': 'Bitte {0} oder mehr Zeichen eingeben',
+    'Reviewers picked from source code changes.': 'Reviewers picked from source code changes.',
     'Saving...': 'Saving...',
     'Searching...': 'Searching...',
     'Selection link': 'Selection link',
@@ -59,6 +66,7 b' var _TM = {'
     'There are currently no open pull requests requiring your participation.': 'There are currently no open pull requests requiring your participation.',
     'Unfollow': 'Unfollow',
     'Updating...': 'Updating...',
+    'User `{0}` not allowed to be a reviewer': 'User `{0}` not allowed to be a reviewer',
     'You can only select {0} item': 'You can only select {0} item',
     'You can only select {0} items': 'You can only select {0} items',
     'added manually by "{0}"': 'added manually by "{0}"',
@@ -71,6 +79,7 b' var _TM = {'
     'in {0}, {1}': 'in {0}, {1}',
     'just now': 'jetzt gerade',
     'loading...': 'loading...',
+    'member of "{0}"': 'member of "{0}"',
     'resolve comment': 'resolve comment',
     'showing {0} out of {1} commit': 'showing {0} out of {1} commit',
     'showing {0} out of {1} commits': 'showing {0} out of {1} commits',

rhodecode/public/js/rhodecode/i18n/en.js

@@ -7,8 +7,14 b''
 var _TM = {
     '(from usergroup {0})': '(from usergroup {0})',
     'Add another comment': 'Add another comment',
+    'Adding new reviewers is forbidden.': 'Adding new reviewers is forbidden.',
+    'All reviewers must vote.': 'All reviewers must vote.',
+    'At least {0} reviewer must vote.': 'At least {0} reviewer must vote.',
+    'At least {0} reviewers must vote.': 'At least {0} reviewers must vote.',
+    'Author is not allowed to be a reviewer.': 'Author is not allowed to be a reviewer.',
     'Close': 'Close',
     'Comment text will be set automatically based on currently selected status ({0}) ...': 'Comment text will be set automatically based on currently selected status ({0}) ...',
+    'Commit Authors are not allowed to be a reviewer.': 'Commit Authors are not allowed to be a reviewer.',
     'Delete this comment?': 'Delete this comment?',
     'Diff to Commit ': 'Diff to Commit ',
     'Follow': 'Follow',
@@ -38,6 +44,7 b' var _TM = {'
     'Please delete {0} characters': 'Please delete {0} characters',
     'Please enter {0} or more character': 'Please enter {0} or more character',
     'Please enter {0} or more characters': 'Please enter {0} or more characters',
+    'Reviewers picked from source code changes.': 'Reviewers picked from source code changes.',
     'Saving...': 'Saving...',
     'Searching...': 'Searching...',
     'Selection link': 'Selection link',
@@ -59,6 +66,7 b' var _TM = {'
     'There are currently no open pull requests requiring your participation.': 'There are currently no open pull requests requiring your participation.',
     'Unfollow': 'Unfollow',
     'Updating...': 'Updating...',
+    'User `{0}` not allowed to be a reviewer': 'User `{0}` not allowed to be a reviewer',
     'You can only select {0} item': 'You can only select {0} item',
     'You can only select {0} items': 'You can only select {0} items',
     'added manually by "{0}"': 'added manually by "{0}"',
@@ -71,6 +79,7 b' var _TM = {'
     'in {0}, {1}': 'in {0}, {1}',
     'just now': 'just now',
     'loading...': 'loading...',
+    'member of "{0}"': 'member of "{0}"',
     'resolve comment': 'resolve comment',
     'showing {0} out of {1} commit': 'showing {0} out of {1} commit',
     'showing {0} out of {1} commits': 'showing {0} out of {1} commits',

rhodecode/public/js/rhodecode/i18n/es.js

@@ -7,8 +7,14 b''
 var _TM = {
     '(from usergroup {0})': '(from usergroup {0})',
     'Add another comment': 'Add another comment',
+    'Adding new reviewers is forbidden.': 'Adding new reviewers is forbidden.',
+    'All reviewers must vote.': 'All reviewers must vote.',
+    'At least {0} reviewer must vote.': 'At least {0} reviewer must vote.',
+    'At least {0} reviewers must vote.': 'At least {0} reviewers must vote.',
+    'Author is not allowed to be a reviewer.': 'Author is not allowed to be a reviewer.',
     'Close': 'Close',
     'Comment text will be set automatically based on currently selected status ({0}) ...': 'Comment text will be set automatically based on currently selected status ({0}) ...',
+    'Commit Authors are not allowed to be a reviewer.': 'Commit Authors are not allowed to be a reviewer.',
     'Delete this comment?': 'Delete this comment?',
     'Diff to Commit ': 'Diff to Commit ',
     'Follow': 'Follow',
@@ -38,6 +44,7 b' var _TM = {'
     'Please delete {0} characters': 'Please delete {0} characters',
     'Please enter {0} or more character': 'Please enter {0} or more character',
     'Please enter {0} or more characters': 'Please enter {0} or more characters',
+    'Reviewers picked from source code changes.': 'Reviewers picked from source code changes.',
     'Saving...': 'Saving...',
     'Searching...': 'Searching...',
     'Selection link': 'Selection link',
@@ -59,6 +66,7 b' var _TM = {'
     'There are currently no open pull requests requiring your participation.': 'There are currently no open pull requests requiring your participation.',
     'Unfollow': 'Unfollow',
     'Updating...': 'Updating...',
+    'User `{0}` not allowed to be a reviewer': 'User `{0}` not allowed to be a reviewer',
     'You can only select {0} item': 'You can only select {0} item',
     'You can only select {0} items': 'You can only select {0} items',
     'added manually by "{0}"': 'added manually by "{0}"',
@@ -71,6 +79,7 b' var _TM = {'
     'in {0}, {1}': 'in {0}, {1}',
     'just now': 'just now',
     'loading...': 'loading...',
+    'member of "{0}"': 'member of "{0}"',
     'resolve comment': 'resolve comment',
     'showing {0} out of {1} commit': 'showing {0} out of {1} commit',
     'showing {0} out of {1} commits': 'showing {0} out of {1} commits',

rhodecode/public/js/rhodecode/i18n/fr.js

@@ -7,8 +7,14 b''
 var _TM = {
     '(from usergroup {0})': '(from usergroup {0})',
     'Add another comment': 'Add another comment',
+    'Adding new reviewers is forbidden.': 'Adding new reviewers is forbidden.',
+    'All reviewers must vote.': 'All reviewers must vote.',
+    'At least {0} reviewer must vote.': 'At least {0} reviewer must vote.',
+    'At least {0} reviewers must vote.': 'At least {0} reviewers must vote.',
+    'Author is not allowed to be a reviewer.': 'Author is not allowed to be a reviewer.',
     'Close': 'Close',
     'Comment text will be set automatically based on currently selected status ({0}) ...': 'Comment text will be set automatically based on currently selected status ({0}) ...',
+    'Commit Authors are not allowed to be a reviewer.': 'Commit Authors are not allowed to be a reviewer.',
     'Delete this comment?': 'Delete this comment?',
     'Diff to Commit ': 'Diff to Commit ',
     'Follow': 'Follow',
@@ -38,6 +44,7 b' var _TM = {'
     'Please delete {0} characters': 'Please delete {0} characters',
     'Please enter {0} or more character': 'Please enter {0} or more character',
     'Please enter {0} or more characters': 'Please enter {0} or more characters',
+    'Reviewers picked from source code changes.': 'Reviewers picked from source code changes.',
     'Saving...': 'Saving...',
     'Searching...': 'Searching...',
     'Selection link': 'Lien vers la sélection',
@@ -59,6 +66,7 b' var _TM = {'
     'There are currently no open pull requests requiring your participation.': 'There are currently no open pull requests requiring your participation.',
     'Unfollow': 'Unfollow',
     'Updating...': 'Updating...',
+    'User `{0}` not allowed to be a reviewer': 'User `{0}` not allowed to be a reviewer',
     'You can only select {0} item': 'You can only select {0} item',
     'You can only select {0} items': 'You can only select {0} items',
     'added manually by "{0}"': 'added manually by "{0}"',
@@ -71,6 +79,7 b' var _TM = {'
     'in {0}, {1}': 'in {0}, {1}',
     'just now': 'à l’instant',
     'loading...': 'Chargement…',
+    'member of "{0}"': 'member of "{0}"',
     'resolve comment': 'resolve comment',
     'showing {0} out of {1} commit': 'showing {0} out of {1} commit',
     'showing {0} out of {1} commits': 'showing {0} out of {1} commits',

rhodecode/public/js/rhodecode/i18n/it.js

@@ -7,8 +7,14 b''
 var _TM = {
     '(from usergroup {0})': '(from usergroup {0})',
     'Add another comment': 'Aggiungi un altro commento',
+    'Adding new reviewers is forbidden.': 'Adding new reviewers is forbidden.',
+    'All reviewers must vote.': 'All reviewers must vote.',
+    'At least {0} reviewer must vote.': 'At least {0} reviewer must vote.',
+    'At least {0} reviewers must vote.': 'At least {0} reviewers must vote.',
+    'Author is not allowed to be a reviewer.': 'Author is not allowed to be a reviewer.',
     'Close': 'Close',
     'Comment text will be set automatically based on currently selected status ({0}) ...': 'Comment text will be set automatically based on currently selected status ({0}) ...',
+    'Commit Authors are not allowed to be a reviewer.': 'Commit Authors are not allowed to be a reviewer.',
     'Delete this comment?': 'Delete this comment?',
     'Diff to Commit ': 'Diff to Commit ',
     'Follow': 'Segui',
@@ -38,6 +44,7 b' var _TM = {'
     'Please delete {0} characters': 'Please delete {0} characters',
     'Please enter {0} or more character': 'Please enter {0} or more character',
     'Please enter {0} or more characters': 'Please enter {0} or more characters',
+    'Reviewers picked from source code changes.': 'Reviewers picked from source code changes.',
     'Saving...': 'Saving...',
     'Searching...': 'Searching...',
     'Selection link': 'Collegamento selezione',
@@ -59,6 +66,7 b' var _TM = {'
     'There are currently no open pull requests requiring your participation.': 'Al momento non ci sono richieste di PULL che richiedono il tuo intervento',
     'Unfollow': 'Smetti di seguire',
     'Updating...': 'Updating...',
+    'User `{0}` not allowed to be a reviewer': 'User `{0}` not allowed to be a reviewer',
     'You can only select {0} item': 'You can only select {0} item',
     'You can only select {0} items': 'You can only select {0} items',
     'added manually by "{0}"': 'added manually by "{0}"',
@@ -71,6 +79,7 b' var _TM = {'
     'in {0}, {1}': 'in {0}, {1}',
     'just now': 'proprio ora',
     'loading...': 'loading...',
+    'member of "{0}"': 'member of "{0}"',
     'resolve comment': 'resolve comment',
     'showing {0} out of {1} commit': 'showing {0} out of {1} commit',
     'showing {0} out of {1} commits': 'showing {0} out of {1} commits',

rhodecode/public/js/rhodecode/i18n/ja.js

@@ -7,8 +7,14 b''
 var _TM = {
     '(from usergroup {0})': '(from usergroup {0})',
     'Add another comment': '別のコメントを追加',
+    'Adding new reviewers is forbidden.': 'Adding new reviewers is forbidden.',
+    'All reviewers must vote.': 'All reviewers must vote.',
+    'At least {0} reviewer must vote.': 'At least {0} reviewer must vote.',
+    'At least {0} reviewers must vote.': 'At least {0} reviewers must vote.',
+    'Author is not allowed to be a reviewer.': 'Author is not allowed to be a reviewer.',
     'Close': 'Close',
     'Comment text will be set automatically based on currently selected status ({0}) ...': '選択したステータス ({0}) を元にコメントが自動的に設定されます...',
+    'Commit Authors are not allowed to be a reviewer.': 'Commit Authors are not allowed to be a reviewer.',
     'Delete this comment?': 'Delete this comment?',
     'Diff to Commit ': 'Diff to Commit ',
     'Follow': 'フォロー',
@@ -38,6 +44,7 b' var _TM = {'
     'Please delete {0} characters': '{0} 文字削除してください',
     'Please enter {0} or more character': '{0} 文字以上入力してください',
     'Please enter {0} or more characters': '{0} 文字以上入力してください',
+    'Reviewers picked from source code changes.': 'Reviewers picked from source code changes.',
     'Saving...': 'Saving...',
     'Searching...': '検索中...',
     'Selection link': 'セレクション・リンク',
@@ -59,6 +66,7 b' var _TM = {'
     'There are currently no open pull requests requiring your participation.': 'There are currently no open pull requests requiring your participation.',
     'Unfollow': 'アンフォロー',
     'Updating...': 'Updating...',
+    'User `{0}` not allowed to be a reviewer': 'User `{0}` not allowed to be a reviewer',
     'You can only select {0} item': '{0} 件のみ選択できます',
     'You can only select {0} items': '{0} 件のみ選択できます',
     'added manually by "{0}"': 'added manually by "{0}"',
@@ -71,6 +79,7 b' var _TM = {'
     'in {0}, {1}': 'in {0}, {1}',
     'just now': 'たったいま',
     'loading...': '読み込み中...',
+    'member of "{0}"': 'member of "{0}"',
     'resolve comment': 'resolve comment',
     'showing {0} out of {1} commit': 'showing {0} out of {1} commit',
     'showing {0} out of {1} commits': 'showing {0} out of {1} commits',

rhodecode/public/js/rhodecode/i18n/js_translations.js

@@ -1,8 +1,14 b''
 // AUTO GENERATED FILE FOR Babel JS-GETTEXT EXTRACTORS, DO NOT CHANGE
 _gettext('(from usergroup {0})');
 _gettext('Add another comment');
+_gettext('Adding new reviewers is forbidden.');
+_gettext('All reviewers must vote.');
+_gettext('At least {0} reviewer must vote.');
+_gettext('At least {0} reviewers must vote.');
+_gettext('Author is not allowed to be a reviewer.');
 _gettext('Close');
 _gettext('Comment text will be set automatically based on currently selected status ({0}) ...');
+_gettext('Commit Authors are not allowed to be a reviewer.');
 _gettext('Delete this comment?');
 _gettext('Diff to Commit ');
 _gettext('Follow');
@@ -32,6 +38,7 b''
 _gettext('Please delete {0} characters');
 _gettext('Please enter {0} or more character');
 _gettext('Please enter {0} or more characters');
+_gettext('Reviewers picked from source code changes.');
 _gettext('Saving...');
 _gettext('Searching...');
 _gettext('Selection link');
@@ -53,6 +60,7 b''
 _gettext('There are currently no open pull requests requiring your participation.');
 _gettext('Unfollow');
 _gettext('Updating...');
+_gettext('User `{0}` not allowed to be a reviewer');
 _gettext('You can only select {0} item');
 _gettext('You can only select {0} items');
 _gettext('added manually by "{0}"');
@@ -65,6 +73,7 b''
 _gettext('in {0}, {1}');
 _gettext('just now');
 _gettext('loading...');
+_gettext('member of "{0}"');
 _gettext('resolve comment');
 _gettext('showing {0} out of {1} commit');
 _gettext('showing {0} out of {1} commits');

rhodecode/public/js/rhodecode/i18n/pl.js

@@ -7,8 +7,14 b''
 var _TM = {
     '(from usergroup {0})': '(from usergroup {0})',
     'Add another comment': 'Dodaj kolejny komentarz',
+    'Adding new reviewers is forbidden.': 'Adding new reviewers is forbidden.',
+    'All reviewers must vote.': 'All reviewers must vote.',
+    'At least {0} reviewer must vote.': 'At least {0} reviewer must vote.',
+    'At least {0} reviewers must vote.': 'At least {0} reviewers must vote.',
+    'Author is not allowed to be a reviewer.': 'Author is not allowed to be a reviewer.',
     'Close': 'Zamknij',
     'Comment text will be set automatically based on currently selected status ({0}) ...': 'Comment text will be set automatically based on currently selected status ({0}) ...',
+    'Commit Authors are not allowed to be a reviewer.': 'Commit Authors are not allowed to be a reviewer.',
     'Delete this comment?': 'Delete this comment?',
     'Diff to Commit ': 'Diff to Commit ',
     'Follow': 'Obserwuj',
@@ -38,6 +44,7 b' var _TM = {'
     'Please delete {0} characters': 'Please delete {0} characters',
     'Please enter {0} or more character': 'Please enter {0} or more character',
     'Please enter {0} or more characters': 'Please enter {0} or more characters',
+    'Reviewers picked from source code changes.': 'Reviewers picked from source code changes.',
     'Saving...': 'Saving...',
     'Searching...': 'Searching...',
     'Selection link': 'Wybór linku',
@@ -59,6 +66,7 b' var _TM = {'
     'There are currently no open pull requests requiring your participation.': 'There are currently no open pull requests requiring your participation.',
     'Unfollow': 'Nie obserwuj',
     'Updating...': 'Updating...',
+    'User `{0}` not allowed to be a reviewer': 'User `{0}` not allowed to be a reviewer',
     'You can only select {0} item': 'You can only select {0} item',
     'You can only select {0} items': 'You can only select {0} items',
     'added manually by "{0}"': 'added manually by "{0}"',
@@ -71,6 +79,7 b' var _TM = {'
     'in {0}, {1}': 'in {0}, {1}',
     'just now': 'przed chwilą',
     'loading...': 'wczytywanie...',
+    'member of "{0}"': 'member of "{0}"',
     'resolve comment': 'resolve comment',
     'showing {0} out of {1} commit': 'showing {0} out of {1} commit',
     'showing {0} out of {1} commits': 'showing {0} out of {1} commits',

rhodecode/public/js/rhodecode/i18n/pt.js

@@ -7,8 +7,14 b''
 var _TM = {
     '(from usergroup {0})': '(from usergroup {0})',
     'Add another comment': 'Adicionar outro comentário',
+    'Adding new reviewers is forbidden.': 'Adding new reviewers is forbidden.',
+    'All reviewers must vote.': 'All reviewers must vote.',
+    'At least {0} reviewer must vote.': 'At least {0} reviewer must vote.',
+    'At least {0} reviewers must vote.': 'At least {0} reviewers must vote.',
+    'Author is not allowed to be a reviewer.': 'Author is not allowed to be a reviewer.',
     'Close': 'Close',
     'Comment text will be set automatically based on currently selected status ({0}) ...': 'Comment text will be set automatically based on currently selected status ({0}) ...',
+    'Commit Authors are not allowed to be a reviewer.': 'Commit Authors are not allowed to be a reviewer.',
     'Delete this comment?': 'Delete this comment?',
     'Diff to Commit ': 'Diff to Commit ',
     'Follow': 'Seguir',
@@ -38,6 +44,7 b' var _TM = {'
     'Please delete {0} characters': 'Please delete {0} characters',
     'Please enter {0} or more character': 'Please enter {0} or more character',
     'Please enter {0} or more characters': 'Please enter {0} or more characters',
+    'Reviewers picked from source code changes.': 'Reviewers picked from source code changes.',
     'Saving...': 'Saving...',
     'Searching...': 'Searching...',
     'Selection link': 'Link da seleção',
@@ -59,6 +66,7 b' var _TM = {'
     'There are currently no open pull requests requiring your participation.': 'There are currently no open pull requests requiring your participation.',
     'Unfollow': 'Parar de seguir',
     'Updating...': 'Updating...',
+    'User `{0}` not allowed to be a reviewer': 'User `{0}` not allowed to be a reviewer',
     'You can only select {0} item': 'You can only select {0} item',
     'You can only select {0} items': 'You can only select {0} items',
     'added manually by "{0}"': 'added manually by "{0}"',
@@ -71,6 +79,7 b' var _TM = {'
     'in {0}, {1}': 'in {0}, {1}',
     'just now': 'agora há pouco',
     'loading...': 'loading...',
+    'member of "{0}"': 'member of "{0}"',
     'resolve comment': 'resolve comment',
     'showing {0} out of {1} commit': 'showing {0} out of {1} commit',
     'showing {0} out of {1} commits': 'showing {0} out of {1} commits',

rhodecode/public/js/rhodecode/i18n/ru.js

@@ -7,8 +7,14 b''
 var _TM = {
     '(from usergroup {0})': '(from usergroup {0})',
     'Add another comment': 'Добавить другой комментарий',
+    'Adding new reviewers is forbidden.': 'Adding new reviewers is forbidden.',
+    'All reviewers must vote.': 'All reviewers must vote.',
+    'At least {0} reviewer must vote.': 'At least {0} reviewer must vote.',
+    'At least {0} reviewers must vote.': 'At least {0} reviewers must vote.',
+    'Author is not allowed to be a reviewer.': 'Author is not allowed to be a reviewer.',
     'Close': 'Close',
     'Comment text will be set automatically based on currently selected status ({0}) ...': 'Comment text will be set automatically based on currently selected status ({0}) ...',
+    'Commit Authors are not allowed to be a reviewer.': 'Commit Authors are not allowed to be a reviewer.',
     'Delete this comment?': 'Delete this comment?',
     'Diff to Commit ': 'Diff to Commit ',
     'Follow': 'Наблюдать',
@@ -38,6 +44,7 b' var _TM = {'
     'Please delete {0} characters': 'Please delete {0} characters',
     'Please enter {0} or more character': 'Please enter {0} or more character',
     'Please enter {0} or more characters': 'Please enter {0} or more characters',
+    'Reviewers picked from source code changes.': 'Reviewers picked from source code changes.',
     'Saving...': 'Saving...',
     'Searching...': 'Searching...',
     'Selection link': 'Ссылка выбора',
@@ -59,6 +66,7 b' var _TM = {'
     'There are currently no open pull requests requiring your participation.': 'There are currently no open pull requests requiring your participation.',
     'Unfollow': 'Не наблюдать',
     'Updating...': 'Updating...',
+    'User `{0}` not allowed to be a reviewer': 'User `{0}` not allowed to be a reviewer',
     'You can only select {0} item': 'You can only select {0} item',
     'You can only select {0} items': 'You can only select {0} items',
     'added manually by "{0}"': 'added manually by "{0}"',
@@ -71,6 +79,7 b' var _TM = {'
     'in {0}, {1}': 'in {0}, {1}',
     'just now': 'прямо сейчас',
     'loading...': 'загрузка...',
+    'member of "{0}"': 'member of "{0}"',
     'resolve comment': 'resolve comment',
     'showing {0} out of {1} commit': 'showing {0} out of {1} commit',
     'showing {0} out of {1} commits': 'showing {0} out of {1} commits',

rhodecode/public/js/rhodecode/i18n/zh.js

@@ -7,8 +7,14 b''
 var _TM = {
     '(from usergroup {0})': '(from usergroup {0})',
     'Add another comment': 'Add another comment',
+    'Adding new reviewers is forbidden.': 'Adding new reviewers is forbidden.',
+    'All reviewers must vote.': 'All reviewers must vote.',
+    'At least {0} reviewer must vote.': 'At least {0} reviewer must vote.',
+    'At least {0} reviewers must vote.': 'At least {0} reviewers must vote.',
+    'Author is not allowed to be a reviewer.': 'Author is not allowed to be a reviewer.',
     'Close': 'Close',
     'Comment text will be set automatically based on currently selected status ({0}) ...': 'Comment text will be set automatically based on currently selected status ({0}) ...',
+    'Commit Authors are not allowed to be a reviewer.': 'Commit Authors are not allowed to be a reviewer.',
     'Delete this comment?': 'Delete this comment?',
     'Diff to Commit ': 'Diff to Commit ',
     'Follow': 'Follow',
@@ -38,6 +44,7 b' var _TM = {'
     'Please delete {0} characters': 'Please delete {0} characters',
     'Please enter {0} or more character': 'Please enter {0} or more character',
     'Please enter {0} or more characters': 'Please enter {0} or more characters',
+    'Reviewers picked from source code changes.': 'Reviewers picked from source code changes.',
     'Saving...': 'Saving...',
     'Searching...': 'Searching...',
     'Selection link': '选择链接',
@@ -59,6 +66,7 b' var _TM = {'
     'There are currently no open pull requests requiring your participation.': 'There are currently no open pull requests requiring your participation.',
     'Unfollow': 'Unfollow',
     'Updating...': 'Updating...',
+    'User `{0}` not allowed to be a reviewer': 'User `{0}` not allowed to be a reviewer',
     'You can only select {0} item': 'You can only select {0} item',
     'You can only select {0} items': 'You can only select {0} items',
     'added manually by "{0}"': 'added manually by "{0}"',
@@ -71,6 +79,7 b' var _TM = {'
     'in {0}, {1}': 'in {0}, {1}',
     'just now': '刚才',
     'loading...': 'loading...',
+    'member of "{0}"': 'member of "{0}"',
     'resolve comment': 'resolve comment',
     'showing {0} out of {1} commit': 'showing {0} out of {1} commit',
     'showing {0} out of {1} commits': 'showing {0} out of {1} commits',

rhodecode/public/js/rhodecode/routes.js

@@ -12,22 +12,13 b''
  ******************************************************************************/
 function registerRCRoutes() {
     // routes registration
-    pyroutes.register('home', '/', []);
-    pyroutes.register('user_autocomplete_data', '/_users', []);
-    pyroutes.register('user_group_autocomplete_data', '/_user_groups', []);
     pyroutes.register('new_repo', '/_admin/create_repository', []);
     pyroutes.register('edit_user', '/_admin/users/%(user_id)s/edit', ['user_id']);
     pyroutes.register('edit_user_group_members', '/_admin/user_groups/%(user_group_id)s/edit/members', ['user_group_id']);
     pyroutes.register('gists', '/_admin/gists', []);
     pyroutes.register('new_gist', '/_admin/gists/new', []);
     pyroutes.register('toggle_following', '/_admin/toggle_following', []);
-    pyroutes.register('repo_stats', '/%(repo_name)s/repo_stats/%(commit_id)s', ['repo_name', 'commit_id']);
-    pyroutes.register('repo_refs_data', '/%(repo_name)s/refs-data', ['repo_name']);
-    pyroutes.register('repo_refs_changelog_data', '/%(repo_name)s/refs-data-changelog', ['repo_name']);
-    pyroutes.register('repo_default_reviewers_data', '/%(repo_name)s/default-reviewers', ['repo_name']);
     pyroutes.register('changeset_home', '/%(repo_name)s/changeset/%(revision)s', ['repo_name', 'revision']);
-    pyroutes.register('edit_repo', '/%(repo_name)s/settings', ['repo_name']);
-    pyroutes.register('edit_repo_perms', '/%(repo_name)s/settings/permissions', ['repo_name']);
     pyroutes.register('changeset_comment', '/%(repo_name)s/changeset/%(revision)s/comment', ['repo_name', 'revision']);
     pyroutes.register('changeset_comment_preview', '/%(repo_name)s/changeset/comment/preview', ['repo_name']);
     pyroutes.register('changeset_comment_delete', '/%(repo_name)s/changeset/comment/%(comment_id)s/delete', ['repo_name', 'comment_id']);
@@ -39,7 +30,6 b' function registerRCRoutes() {'
     pyroutes.register('pullrequest_repo_destinations', '/%(repo_name)s/pull-request/repo-destinations', ['repo_name']);
     pyroutes.register('pullrequest_show', '/%(repo_name)s/pull-request/%(pull_request_id)s', ['repo_name', 'pull_request_id']);
     pyroutes.register('pullrequest_update', '/%(repo_name)s/pull-request/%(pull_request_id)s', ['repo_name', 'pull_request_id']);
-    pyroutes.register('pullrequest_show_all', '/%(repo_name)s/pull-request', ['repo_name']);
     pyroutes.register('pullrequest_comment', '/%(repo_name)s/pull-request-comment/%(pull_request_id)s', ['repo_name', 'pull_request_id']);
     pyroutes.register('pullrequest_comment_delete', '/%(repo_name)s/pull-request-comment/%(comment_id)s/delete', ['repo_name', 'comment_id']);
     pyroutes.register('changelog_home', '/%(repo_name)s/changelog', ['repo_name']);
@@ -53,8 +43,6 b' function registerRCRoutes() {'
     pyroutes.register('files_archive_home', '/%(repo_name)s/archive/%(fname)s', ['repo_name', 'fname']);
     pyroutes.register('files_nodelist_home', '/%(repo_name)s/nodelist/%(revision)s/%(f_path)s', ['repo_name', 'revision', 'f_path']);
     pyroutes.register('files_nodetree_full', '/%(repo_name)s/nodetree_full/%(commit_id)s/%(f_path)s', ['repo_name', 'commit_id', 'f_path']);
-    pyroutes.register('summary_home_slash', '/%(repo_name)s/', ['repo_name']);
-    pyroutes.register('summary_home', '/%(repo_name)s', ['repo_name']);
     pyroutes.register('favicon', '/favicon.ico', []);
     pyroutes.register('robots', '/robots.txt', []);
     pyroutes.register('auth_home', '/_admin/auth*traverse', []);
@@ -73,17 +61,30 b' function registerRCRoutes() {'
     pyroutes.register('repo_integrations_new', '%(repo_name)s/settings/integrations/new', ['repo_name']);
     pyroutes.register('repo_integrations_create', '%(repo_name)s/settings/integrations/%(integration)s/new', ['repo_name', 'integration']);
     pyroutes.register('repo_integrations_edit', '%(repo_name)s/settings/integrations/%(integration)s/%(integration_id)s', ['repo_name', 'integration', 'integration_id']);
+    pyroutes.register('ops_ping', '_admin/ops/ping', []);
+    pyroutes.register('admin_home', '/_admin', []);
+    pyroutes.register('admin_audit_logs', '_admin/audit_logs', []);
+    pyroutes.register('pull_requests_global_0', '_admin/pull_requests/%(pull_request_id)s', ['pull_request_id']);
+    pyroutes.register('pull_requests_global_1', '_admin/pull-requests/%(pull_request_id)s', ['pull_request_id']);
+    pyroutes.register('pull_requests_global', '_admin/pull-request/%(pull_request_id)s', ['pull_request_id']);
     pyroutes.register('admin_settings_open_source', '_admin/settings/open_source', []);
     pyroutes.register('admin_settings_vcs_svn_generate_cfg', '_admin/settings/vcs/svn_generate_cfg', []);
     pyroutes.register('admin_settings_system', '_admin/settings/system', []);
     pyroutes.register('admin_settings_system_update', '_admin/settings/system/updates', []);
     pyroutes.register('admin_settings_sessions', '_admin/settings/sessions', []);
     pyroutes.register('admin_settings_sessions_cleanup', '_admin/settings/sessions/cleanup', []);
+    pyroutes.register('admin_permissions_ips', '_admin/permissions/ips', []);
     pyroutes.register('users', '_admin/users', []);
     pyroutes.register('users_data', '_admin/users_data', []);
     pyroutes.register('edit_user_auth_tokens', '_admin/users/%(user_id)s/edit/auth_tokens', ['user_id']);
     pyroutes.register('edit_user_auth_tokens_add', '_admin/users/%(user_id)s/edit/auth_tokens/new', ['user_id']);
     pyroutes.register('edit_user_auth_tokens_delete', '_admin/users/%(user_id)s/edit/auth_tokens/delete', ['user_id']);
+    pyroutes.register('edit_user_emails', '_admin/users/%(user_id)s/edit/emails', ['user_id']);
+    pyroutes.register('edit_user_emails_add', '_admin/users/%(user_id)s/edit/emails/new', ['user_id']);
+    pyroutes.register('edit_user_emails_delete', '_admin/users/%(user_id)s/edit/emails/delete', ['user_id']);
+    pyroutes.register('edit_user_ips', '_admin/users/%(user_id)s/edit/ips', ['user_id']);
+    pyroutes.register('edit_user_ips_add', '_admin/users/%(user_id)s/edit/ips/new', ['user_id']);
+    pyroutes.register('edit_user_ips_delete', '_admin/users/%(user_id)s/edit/ips/delete', ['user_id']);
     pyroutes.register('edit_user_groups_management', '_admin/users/%(user_id)s/edit/groups_management', ['user_id']);
     pyroutes.register('edit_user_groups_management_updates', '_admin/users/%(user_id)s/edit/edit_user_groups_management/updates', ['user_id']);
     pyroutes.register('edit_user_audit_logs', '_admin/users/%(user_id)s/edit/audit', ['user_id']);
@@ -95,11 +96,44 b' function registerRCRoutes() {'
     pyroutes.register('register', '/_admin/register', []);
     pyroutes.register('reset_password', '/_admin/password_reset', []);
     pyroutes.register('reset_password_confirmation', '/_admin/password_reset_confirmation', []);
-    pyroutes.register('repo_maintenance', '/%(repo_name)s/maintenance', ['repo_name']);
-    pyroutes.register('repo_maintenance_execute', '/%(repo_name)s/maintenance/execute', ['repo_name']);
-    pyroutes.register('strip', '/%(repo_name)s/strip', ['repo_name']);
-    pyroutes.register('strip_check', '/%(repo_name)s/strip_check', ['repo_name']);
-    pyroutes.register('strip_execute', '/%(repo_name)s/strip_execute', ['repo_name']);
+    pyroutes.register('home', '/', []);
+    pyroutes.register('user_autocomplete_data', '/_users', []);
+    pyroutes.register('user_group_autocomplete_data', '/_user_groups', []);
+    pyroutes.register('repo_list_data', '/_repos', []);
+    pyroutes.register('goto_switcher_data', '/_goto_data', []);
+    pyroutes.register('repo_summary_explicit', '/%(repo_name)s/summary', ['repo_name']);
+    pyroutes.register('repo_summary_commits', '/%(repo_name)s/summary-commits', ['repo_name']);
+    pyroutes.register('repo_commit', '/%(repo_name)s/changeset/%(commit_id)s', ['repo_name', 'commit_id']);
+    pyroutes.register('repo_refs_data', '/%(repo_name)s/refs-data', ['repo_name']);
+    pyroutes.register('repo_refs_changelog_data', '/%(repo_name)s/refs-data-changelog', ['repo_name']);
+    pyroutes.register('repo_stats', '/%(repo_name)s/repo_stats/%(commit_id)s', ['repo_name', 'commit_id']);
+    pyroutes.register('tags_home', '/%(repo_name)s/tags', ['repo_name']);
+    pyroutes.register('branches_home', '/%(repo_name)s/branches', ['repo_name']);
+    pyroutes.register('bookmarks_home', '/%(repo_name)s/bookmarks', ['repo_name']);
+    pyroutes.register('pullrequest_show', '/%(repo_name)s/pull-request/%(pull_request_id)s', ['repo_name', 'pull_request_id']);
+    pyroutes.register('pullrequest_show_all', '/%(repo_name)s/pull-request', ['repo_name']);
+    pyroutes.register('pullrequest_show_all_data', '/%(repo_name)s/pull-request-data', ['repo_name']);
+    pyroutes.register('edit_repo', '/%(repo_name)s/settings', ['repo_name']);
+    pyroutes.register('edit_repo_advanced', '/%(repo_name)s/settings/advanced', ['repo_name']);
+    pyroutes.register('edit_repo_advanced_delete', '/%(repo_name)s/settings/advanced/delete', ['repo_name']);
+    pyroutes.register('edit_repo_advanced_locking', '/%(repo_name)s/settings/advanced/locking', ['repo_name']);
+    pyroutes.register('edit_repo_advanced_journal', '/%(repo_name)s/settings/advanced/journal', ['repo_name']);
+    pyroutes.register('edit_repo_advanced_fork', '/%(repo_name)s/settings/advanced/fork', ['repo_name']);
+    pyroutes.register('edit_repo_caches', '/%(repo_name)s/settings/caches', ['repo_name']);
+    pyroutes.register('edit_repo_perms', '/%(repo_name)s/settings/permissions', ['repo_name']);
+    pyroutes.register('repo_reviewers', '/%(repo_name)s/settings/review/rules', ['repo_name']);
+    pyroutes.register('repo_default_reviewers_data', '/%(repo_name)s/settings/review/default-reviewers', ['repo_name']);
+    pyroutes.register('repo_maintenance', '/%(repo_name)s/settings/maintenance', ['repo_name']);
+    pyroutes.register('repo_maintenance_execute', '/%(repo_name)s/settings/maintenance/execute', ['repo_name']);
+    pyroutes.register('strip', '/%(repo_name)s/settings/strip', ['repo_name']);
+    pyroutes.register('strip_check', '/%(repo_name)s/settings/strip_check', ['repo_name']);
+    pyroutes.register('strip_execute', '/%(repo_name)s/settings/strip_execute', ['repo_name']);
+    pyroutes.register('repo_summary', '/%(repo_name)s', ['repo_name']);
+    pyroutes.register('repo_summary_slash', '/%(repo_name)s/', ['repo_name']);
+    pyroutes.register('repo_group_home', '/%(repo_group_name)s', ['repo_group_name']);
+    pyroutes.register('repo_group_home_slash', '/%(repo_group_name)s/', ['repo_group_name']);
+    pyroutes.register('search', '/_admin/search', []);
+    pyroutes.register('search_repo', '/%(repo_name)s/search', ['repo_name']);
     pyroutes.register('user_profile', '/_profiles/%(username)s', ['username']);
     pyroutes.register('my_account_profile', '/_admin/my_account/profile', []);
     pyroutes.register('my_account_password', '/_admin/my_account/password', []);
@@ -107,5 +141,14 b' function registerRCRoutes() {'
     pyroutes.register('my_account_auth_tokens', '/_admin/my_account/auth_tokens', []);
     pyroutes.register('my_account_auth_tokens_add', '/_admin/my_account/auth_tokens/new', []);
     pyroutes.register('my_account_auth_tokens_delete', '/_admin/my_account/auth_tokens/delete', []);
+    pyroutes.register('my_account_emails', '/_admin/my_account/emails', []);
+    pyroutes.register('my_account_emails_add', '/_admin/my_account/emails/new', []);
+    pyroutes.register('my_account_emails_delete', '/_admin/my_account/emails/delete', []);
+    pyroutes.register('my_account_repos', '/_admin/my_account/repos', []);
+    pyroutes.register('my_account_watched', '/_admin/my_account/watched', []);
+    pyroutes.register('my_account_perms', '/_admin/my_account/perms', []);
+    pyroutes.register('my_account_notifications', '/_admin/my_account/notifications', []);
+    pyroutes.register('my_account_notifications_toggle_visibility', '/_admin/my_account/toggle_visibility', []);
+    pyroutes.register('my_account_notifications_test_channelstream', '/_admin/my_account/test_channelstream', []);
     pyroutes.register('apiv2', '/_admin/api', []);
 }

rhodecode/public/js/src/rhodecode/pullrequests.js

@@ -16,77 +16,342 b''
 // # RhodeCode Enterprise Edition, including its added features, Support services,
 // # and proprietary license terms, please see https://rhodecode.com/licenses/
 
+
+var prButtonLockChecks = {
+  'compare': false,
+  'reviewers': false
+};
+
 /**
- * Pull request reviewers
+ * lock button until all checks and loads are made. E.g reviewer calculation
+ * should prevent from submitting a PR
+ * @param lockEnabled
+ * @param msg
+ * @param scope
  */
-var removeReviewMember = function(reviewer_id, mark_delete){
-    var reviewer = $('#reviewer_{0}'.format(reviewer_id));
+var prButtonLock = function(lockEnabled, msg, scope) {
+      scope = scope || 'all';
+      if (scope == 'all'){
+          prButtonLockChecks['compare'] = !lockEnabled;
+          prButtonLockChecks['reviewers'] = !lockEnabled;
+      } else if (scope == 'compare') {
+          prButtonLockChecks['compare'] = !lockEnabled;
+      } else if (scope == 'reviewers'){
+          prButtonLockChecks['reviewers'] = !lockEnabled;
+      }
+      var checksMeet = prButtonLockChecks.compare && prButtonLockChecks.reviewers;
+      if (lockEnabled) {
+          $('#save').attr('disabled', 'disabled');
+      }
+      else if (checksMeet) {
+          $('#save').removeAttr('disabled');
+      }
 
-    if(typeof(mark_delete) === undefined){
-        mark_delete = false;
-    }
+      if (msg) {
+          $('#pr_open_message').html(msg);
+      }
+};
 
-    if(mark_delete === true){
-        if (reviewer){
-            // now delete the input
-            $('#reviewer_{0} input'.format(reviewer_id)).remove();
-            // mark as to-delete
-            var obj = $('#reviewer_{0}_name'.format(reviewer_id));
-            obj.addClass('to-delete');
-            obj.css({"text-decoration":"line-through", "opacity": 0.5});
-        }
-    }
-    else{
-        $('#reviewer_{0}'.format(reviewer_id)).remove();
-    }
+
+/**
+Generate Title and Description for a PullRequest.
+In case of 1 commits, the title and description is that one commit
+in case of multiple commits, we iterate on them with max N number of commits,
+and build description in a form
+- commitN
+- commitN+1
+...
+
+Title is then constructed from branch names, or other references,
+replacing '-' and '_' into spaces
+
+* @param sourceRef
+* @param elements
+* @param limit
+* @returns {*[]}
+*/
+var getTitleAndDescription = function(sourceRef, elements, limit) {
+  var title = '';
+  var desc = '';
+
+  $.each($(elements).get().reverse().slice(0, limit), function(idx, value) {
+      var rawMessage = $(value).find('td.td-description .message').data('messageRaw');
+      desc += '- ' + rawMessage.split('\n')[0].replace(/\n+$/, "") + '\n';
+  });
+  // only 1 commit, use commit message as title
+  if (elements.length === 1) {
+      title = $(elements[0]).find('td.td-description .message').data('messageRaw').split('\n')[0];
+  }
+  else {
+      // use reference name
+      title = sourceRef.replace(/-/g, ' ').replace(/_/g, ' ').capitalizeFirstLetter();
+  }
+
+  return [title, desc]
 };
 
-var addReviewMember = function(id, fname, lname, nname, gravatar_link, reasons) {
-    var members = $('#review_members').get(0);
-    var reasons_html = '';
-    var reasons_inputs = '';
-    var reasons = reasons || [];
-    if (reasons) {
-        for (var i = 0; i < reasons.length; i++) {
-            reasons_html += '<div class="reviewer_reason">- {0}</div>'.format(reasons[i]);
-            reasons_inputs += '<input type="hidden" name="reason" value="' + escapeHtml(reasons[i]) + '">';
+
+
+ReviewersController = function () {
+    var self = this;
+    this.$reviewRulesContainer = $('#review_rules');
+    this.$rulesList = this.$reviewRulesContainer.find('.pr-reviewer-rules');
+    this.forbidReviewUsers = undefined;
+    this.$reviewMembers = $('#review_members');
+    this.currentRequest = null;
+
+    this.defaultForbidReviewUsers = function() {
+        return [
+            {'username': 'default',
+             'user_id': templateContext.default_user.user_id}
+        ];
+    };
+
+    this.hideReviewRules = function() {
+        self.$reviewRulesContainer.hide();
+    };
+
+    this.showReviewRules = function() {
+        self.$reviewRulesContainer.show();
+    };
+
+    this.addRule = function(ruleText) {
+        self.showReviewRules();
+        return '<div>- {0}</div>'.format(ruleText)
+    };
+
+    this.loadReviewRules = function(data) {
+        // reset forbidden Users
+        this.forbidReviewUsers = self.defaultForbidReviewUsers();
+
+        // reset state of review rules
+        self.$rulesList.html('');
+
+        if (!data || data.rules === undefined || $.isEmptyObject(data.rules)) {
+            // default rule, case for older repo that don't have any rules stored
+            self.$rulesList.append(
+                self.addRule(
+                    _gettext('All reviewers must vote.'))
+            );
+            return self.forbidReviewUsers
+        }
+
+        if (data.rules.voting !== undefined) {
+            if (data.rules.voting < 0){
+                self.$rulesList.append(
+                    self.addRule(
+                        _gettext('All reviewers must vote.'))
+                )
+            } else if (data.rules.voting === 1) {
+                self.$rulesList.append(
+                    self.addRule(
+                        _gettext('At least {0} reviewer must vote.').format(data.rules.voting))
+                )
+
+            } else {
+                self.$rulesList.append(
+                    self.addRule(
+                        _gettext('At least {0} reviewers must vote.').format(data.rules.voting))
+                )
+            }
+        }
+        if (data.rules.use_code_authors_for_review) {
+            self.$rulesList.append(
+                self.addRule(
+                    _gettext('Reviewers picked from source code changes.'))
+            )
+        }
+        if (data.rules.forbid_adding_reviewers) {
+            $('#add_reviewer_input').remove();
+            self.$rulesList.append(
+                self.addRule(
+                    _gettext('Adding new reviewers is forbidden.'))
+            )
+        }
+        if (data.rules.forbid_author_to_review) {
+            self.forbidReviewUsers.push(data.rules_data.pr_author);
+            self.$rulesList.append(
+                self.addRule(
+                    _gettext('Author is not allowed to be a reviewer.'))
+            )
+        }
+        if (data.rules.forbid_commit_author_to_review) {
+
+            if (data.rules_data.forbidden_users) {
+                $.each(data.rules_data.forbidden_users, function(index, member_data) {
+                    self.forbidReviewUsers.push(member_data)
+                });
+
+            }
+
+            self.$rulesList.append(
+                self.addRule(
+                    _gettext('Commit Authors are not allowed to be a reviewer.'))
+            )
+        }
+
+        return self.forbidReviewUsers
+    };
+
+    this.loadDefaultReviewers = function(sourceRepo, sourceRef, targetRepo, targetRef) {
+
+        if (self.currentRequest) {
+            // make sure we cleanup old running requests before triggering this
+            // again
+            self.currentRequest.abort();
         }
-    }
-    var tmpl = '<li id="reviewer_{2}">'+
-       '<input type="hidden" name="__start__" value="reviewer:mapping">'+
-       '<div class="reviewer_status">'+
-          '<div class="flag_status not_reviewed pull-left reviewer_member_status"></div>'+
-       '</div>'+
-      '<img alt="gravatar" class="gravatar" src="{0}"/>'+
-      '<span class="reviewer_name user">{1}</span>'+
-      reasons_html +
-      '<input type="hidden" name="user_id" value="{2}">'+
-       '<input type="hidden" name="__start__" value="reasons:sequence">'+
-       '{3}'+
-       '<input type="hidden" name="__end__" value="reasons:sequence">'+
-      '<div class="reviewer_member_remove action_button" onclick="removeReviewMember({2})">' +
-      '<i class="icon-remove-sign"></i>'+
-        '</div>'+
-    '</div>'+
-    '<input type="hidden" name="__end__" value="reviewer:mapping">'+
-    '</li>' ;
+
+        $('.calculate-reviewers').show();
+        // reset reviewer members
+        self.$reviewMembers.empty();
+
+        prButtonLock(true, null, 'reviewers');
+        $('#user').hide(); // hide user autocomplete before load
+
+        var url = pyroutes.url('repo_default_reviewers_data',
+                {
+                    'repo_name': templateContext.repo_name,
+                    'source_repo': sourceRepo,
+                    'source_ref': sourceRef[2],
+                    'target_repo': targetRepo,
+                    'target_ref': targetRef[2]
+                });
+
+        self.currentRequest = $.get(url)
+            .done(function(data) {
+                self.currentRequest = null;
+
+                // review rules
+                self.loadReviewRules(data);
+
+                for (var i = 0; i < data.reviewers.length; i++) {
+                  var reviewer = data.reviewers[i];
+                  self.addReviewMember(
+                      reviewer.user_id, reviewer.first_name,
+                      reviewer.last_name, reviewer.username,
+                      reviewer.gravatar_link, reviewer.reasons,
+                      reviewer.mandatory);
+                }
+                $('.calculate-reviewers').hide();
+                prButtonLock(false, null, 'reviewers');
+                $('#user').show(); // show user autocomplete after load
+            });
+    };
+
+    // check those, refactor
+    this.removeReviewMember = function(reviewer_id, mark_delete) {
+        var reviewer = $('#reviewer_{0}'.format(reviewer_id));
+
+        if(typeof(mark_delete) === undefined){
+            mark_delete = false;
+        }
+
+        if(mark_delete === true){
+            if (reviewer){
+                // now delete the input
+                $('#reviewer_{0} input'.format(reviewer_id)).remove();
+                // mark as to-delete
+                var obj = $('#reviewer_{0}_name'.format(reviewer_id));
+                obj.addClass('to-delete');
+                obj.css({"text-decoration":"line-through", "opacity": 0.5});
+            }
+        }
+        else{
+            $('#reviewer_{0}'.format(reviewer_id)).remove();
+        }
+    };
+
+    this.addReviewMember = function(id, fname, lname, nname, gravatar_link, reasons, mandatory) {
+        var members = self.$reviewMembers.get(0);
+        var reasons_html = '';
+        var reasons_inputs = '';
+        var reasons = reasons || [];
+        var mandatory = mandatory || false;
 
-    var displayname = "{0} ({1} {2})".format(
-            nname, escapeHtml(fname), escapeHtml(lname));
-    var element = tmpl.format(gravatar_link,displayname,id,reasons_inputs);
-    // check if we don't have this ID already in
-    var ids = [];
-    var _els = $('#review_members li').toArray();
-    for (el in _els){
-        ids.push(_els[el].id)
-    }
-    if(ids.indexOf('reviewer_'+id) == -1){
-        // only add if it's not there
-        members.innerHTML += element;
-    }
+        if (reasons) {
+            for (var i = 0; i < reasons.length; i++) {
+                reasons_html += '<div class="reviewer_reason">- {0}</div>'.format(reasons[i]);
+                reasons_inputs += '<input type="hidden" name="reason" value="' + escapeHtml(reasons[i]) + '">';
+            }
+        }
+        var tmpl = '' +
+        '<li id="reviewer_{2}" class="reviewer_entry">'+
+           '<input type="hidden" name="__start__" value="reviewer:mapping">'+
+           '<div class="reviewer_status">'+
+              '<div class="flag_status not_reviewed pull-left reviewer_member_status"></div>'+
+           '</div>'+
+          '<img alt="gravatar" class="gravatar" src="{0}"/>'+
+          '<span class="reviewer_name user">{1}</span>'+
+          reasons_html +
+          '<input type="hidden" name="user_id" value="{2}">'+
+          '<input type="hidden" name="__start__" value="reasons:sequence">'+
+           '{3}'+
+          '<input type="hidden" name="__end__" value="reasons:sequence">';
+
+        if (mandatory) {
+            tmpl += ''+
+            '<div class="reviewer_member_mandatory_remove">' +
+            '<i class="icon-remove-sign"></i>'+
+            '</div>' +
+            '<input type="hidden" name="mandatory" value="true">'+
+            '<div class="reviewer_member_mandatory">' +
+                '<i class="icon-lock" title="Mandatory reviewer"></i>'+
+            '</div>';
+
+        } else {
+            tmpl += ''+
+            '<input type="hidden" name="mandatory" value="false">'+
+            '<div class="reviewer_member_remove action_button" onclick="reviewersController.removeReviewMember({2})">' +
+                '<i class="icon-remove-sign"></i>'+
+            '</div>';
+        }
+        // continue template
+        tmpl += ''+
+        '<input type="hidden" name="__end__" value="reviewer:mapping">'+
+        '</li>' ;
+
+        var displayname = "{0} ({1} {2})".format(
+                nname, escapeHtml(fname), escapeHtml(lname));
+        var element = tmpl.format(gravatar_link,displayname,id,reasons_inputs);
+        // check if we don't have this ID already in
+        var ids = [];
+        var _els = self.$reviewMembers.find('li').toArray();
+        for (el in _els){
+            ids.push(_els[el].id)
+        }
+
+        var userAllowedReview = function(userId) {
+            var allowed = true;
+            $.each(self.forbidReviewUsers, function(index, member_data) {
+                if (parseInt(userId) === member_data['user_id']) {
+                    allowed = false;
+                    return false // breaks the loop
+                }
+            });
+            return allowed
+        };
+
+        var userAllowed = userAllowedReview(id);
+        if (!userAllowed){
+           alert(_gettext('User `{0}` not allowed to be a reviewer').format(nname));
+        }
+        var shouldAdd = userAllowed && ids.indexOf('reviewer_'+id) == -1;
+
+        if(shouldAdd) {
+            // only add if it's not there
+            members.innerHTML += element;
+        }
+
+    };
+
+    this.updateReviewers = function(repo_name, pull_request_id){
+        var postData = '_method=put&' + $('#reviewers input').serialize();
+        _updatePullRequest(repo_name, pull_request_id, postData);
+    };
 
 };
 
+
 var _updatePullRequest = function(repo_name, pull_request_id, postData) {
     var url = pyroutes.url(
         'pullrequest_update',
@@ -102,23 +367,6 b' var _updatePullRequest = function(repo_n'
     ajaxPOST(url, postData, success);
 };
 
-var updateReviewers = function(reviewers_ids, repo_name, pull_request_id){
-    if (reviewers_ids === undefined){
-      var postData = '_method=put&' + $('#reviewers input').serialize();
-      _updatePullRequest(repo_name, pull_request_id, postData);
-    }
-};
-
-/**
- * PULL REQUEST reject & close
- */
-var closePullRequest = function(repo_name, pull_request_id) {
-    var postData = {
-        '_method': 'put',
-        'close_pull_request': true};
-    _updatePullRequest(repo_name, pull_request_id, postData);
-};
-
 /**
  * PULL REQUEST update commits
  */
@@ -198,8 +446,8 b' var initPullRequestsCodeMirror = functio'
 /**
  * Reviewer autocomplete
  */
-var ReviewerAutoComplete = function(input_id) {
-  $('#'+input_id).autocomplete({
+var ReviewerAutoComplete = function(inputId) {
+  $(inputId).autocomplete({
     serviceUrl: pyroutes.url('user_autocomplete_data'),
     minChars:2,
     maxHeight:400,
@@ -207,14 +455,28 b' var ReviewerAutoComplete = function(inpu'
     showNoSuggestionNotice: true,
     tabDisabled: true,
     autoSelectFirst: true,
+    params: { user_id: templateContext.rhodecode_user.user_id, user_groups:true, user_groups_expand:true, skip_default_user:true },
     formatResult: autocompleteFormatResult,
     lookupFilter: autocompleteFilterResult,
-    onSelect: function(suggestion, data){
-      var msg = _gettext('added manually by "{0}"');
-      var reasons = [msg.format(templateContext.rhodecode_user.username)];
-      addReviewMember(data.id, data.first_name, data.last_name,
-                      data.username, data.icon_link, reasons);
-      $('#'+input_id).val('');
+    onSelect: function(element, data) {
+
+        var reasons = [_gettext('added manually by "{0}"').format(templateContext.rhodecode_user.username)];
+        if (data.value_type == 'user_group') {
+            reasons.push(_gettext('member of "{0}"').format(data.value_display));
+
+            $.each(data.members, function(index, member_data) {
+                reviewersController.addReviewMember(
+                    member_data.id, member_data.first_name, member_data.last_name,
+                    member_data.username, member_data.icon_link, reasons);
+            })
+
+        } else {
+          reviewersController.addReviewMember(
+              data.id, data.first_name, data.last_name,
+              data.username, data.icon_link, reasons);
+        }
+
+      $(inputId).val('');
     }
   });
 };

rhodecode/subscribers.py

@@ -121,7 +121,7 b' def add_pylons_context(event):'
     # Setup the pylons context object ('c')
     context = ContextObj()
     context.rhodecode_user = auth_user
-    attach_context_attributes(context, request)
+    attach_context_attributes(context, request, request.user.user_id)
     pylons.tmpl_context._push_object(context)
 
 
@@ -130,12 +130,12 b' def scan_repositories_if_enabled(event):'
     This is subscribed to the `pyramid.events.ApplicationCreated` event. It
     does a repository scan if enabled in the settings.
     """
-    from rhodecode.model.scm import ScmModel
-    from rhodecode.lib.utils import repo2db_mapper, get_rhodecode_base_path
     settings = event.app.registry.settings
     vcs_server_enabled = settings['vcs.server.enable']
     import_on_startup = settings['startup.import_repos']
     if vcs_server_enabled and import_on_startup:
+        from rhodecode.model.scm import ScmModel
+        from rhodecode.lib.utils import repo2db_mapper, get_rhodecode_base_path
         repositories = ScmModel().repo_scan(get_rhodecode_base_path())
         repo2db_mapper(repositories, remove_obsolete=False)
 
@@ -172,6 +172,10 b' def write_metadata_if_needed(event):'
         with open(metadata_destination, 'wb') as f:
             f.write(ext_json.json.dumps(metadata))
 
+    settings = event.app.registry.settings
+    if settings.get('metadata.skip'):
+        return
+
     try:
         write()
     except Exception:

rhodecode/templates/admin/admin_audit_logs.mako

@@ -2,7 +2,7 b''
 <%inherit file="/base/base.mako"/>
 
 <%def name="title()">
-    ${_('Admin journal')}
+    ${_('Admin audit logs')}
     %if c.rhodecode_name:
         &middot; ${h.branding(c.rhodecode_name)}
     %endif
@@ -10,9 +10,9 b''
 
 <%def name="breadcrumbs_links()">
     ${h.form(None, id_="filter_form", method="get")}
-        <input class="q_filter_box ${'' if c.search_term else 'initial'}" id="j_filter" size="15" type="text" name="filter" value="${c.search_term or ''}" placeholder="${_('journal filter...')}"/>
+        <input class="q_filter_box ${'' if c.search_term else 'initial'}" id="j_filter" size="15" type="text" name="filter" value="${c.search_term or ''}" placeholder="${_('filter...')}"/>
         <input type='submit' value="${_('filter')}" class="btn" />
-        ${_('Admin journal')} - ${ungettext('%s entry', '%s entries', c.users_log.item_count) % (c.users_log.item_count)}
+        ${_('Audit logs')} - ${_ungettext('%s entry', '%s entries', c.audit_logs.item_count) % (c.audit_logs.item_count)}
     ${h.end_form()}
     <p class="tooltip filterexample" title="${h.tooltip(h.journal_filter_help())}">${_('Example Queries')}</p>
 </%def>
@@ -29,7 +29,7 b''
     <!-- end box / title -->
     <div class="table">
         <div id="user_log">
-            ${c.log_data}
+            <%include file="/admin/admin_log_base.mako" />
         </div>
     </div>
 </div>

rhodecode/templates/admin/auth/auth_settings.mako

@@ -9,7 +9,7 b''
 </%def>
 
 <%def name="breadcrumbs_links()">
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${_('Authentication Plugins')}
 </%def>

rhodecode/templates/admin/auth/plugin_settings.mako

@@ -9,7 +9,7 b''
 </%def>
 
 <%def name="breadcrumbs_links()">
-  ${h.link_to(_('Admin'),h.url('admin_home'))}
+  ${h.link_to(_('Admin'),h.route_path('admin_home'))}
   &raquo;
   ${h.link_to(_('Authentication Plugins'),request.resource_path(resource.__parent__, route_name='auth_home'))}
   &raquo;

rhodecode/templates/admin/defaults/defaults.mako

@@ -9,7 +9,7 b''
 </%def>
 
 <%def name="breadcrumbs_links()">
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${_('Repositories defaults')}
 </%def>

rhodecode/templates/admin/gists/show.mako

@@ -73,7 +73,7 b''
                     </div>
 
                     <div class="author">
-                        <div title="${c.file_last_commit.author}">
+                        <div title="${h.tooltip(c.file_last_commit.author)}">
                           ${self.gravatar_with_user(c.file_last_commit.author, 16)} - ${_('created')} ${h.age_component(c.file_last_commit.date)}
                         </div>
 

rhodecode/templates/admin/integrations/base.mako

@@ -18,7 +18,7 b''
 </%def>
 
 <%def name="breadcrumbs_links()">
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${_('Integrations')}
 </%def>

rhodecode/templates/admin/integrations/form.mako

@@ -3,7 +3,7 b''
 
 <%def name="breadcrumbs_links()">
   %if c.repo:
-    ${h.link_to('Settings',h.url('edit_repo', repo_name=c.repo.repo_name))}
+    ${h.link_to('Settings',h.route_path('edit_repo', repo_name=c.repo.repo_name))}
     &raquo;
     ${h.link_to(_('Integrations'),request.route_url(route_name='repo_integrations_home', repo_name=c.repo.repo_name))}
     &raquo;
@@ -12,7 +12,7 b''
                         repo_name=c.repo.repo_name,
                         integration=current_IntegrationType.key))}
   %elif c.repo_group:
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${h.link_to(_('Repository Groups'),h.url('repo_groups'))}
     &raquo;
@@ -25,7 +25,7 b''
                         repo_group_name=c.repo_group.group_name,
                         integration=current_IntegrationType.key))}
   %else:
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${h.link_to(_('Settings'),h.url('admin_settings'))}
     &raquo;

rhodecode/templates/admin/integrations/list.mako

@@ -3,15 +3,15 b''
 
 <%def name="breadcrumbs_links()">
   %if c.repo:
-    ${h.link_to('Settings',h.url('edit_repo', repo_name=c.repo.repo_name))}
+    ${h.link_to('Settings',h.route_path('edit_repo', repo_name=c.repo.repo_name))}
   %elif c.repo_group:
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${h.link_to(_('Repository Groups'),h.url('repo_groups'))}
     &raquo;
     ${h.link_to(c.repo_group.group_name,h.url('edit_repo_group', group_name=c.repo_group.group_name))}
   %else:
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${h.link_to(_('Settings'),h.url('admin_settings'))}
   %endif
@@ -160,11 +160,11 b''
           </td>
           <td class="td-scope">
             %if integration.repo:
-            <a href="${h.url('summary_home', repo_name=integration.repo.repo_name)}">
+            <a href="${h.route_path('repo_summary', repo_name=integration.repo.repo_name)}">
               ${_('repo')}:${integration.repo.repo_name}
             </a>
             %elif integration.repo_group:
-            <a href="${h.url('repo_group_home', group_name=integration.repo_group.group_name)}">
+            <a href="${h.route_path('repo_group_home', repo_group_name=integration.repo_group.group_name)}">
               ${_('repogroup')}:${integration.repo_group.group_name}
               %if integration.child_repos_only:
               ${_('child repos only')}

rhodecode/templates/admin/integrations/new.mako

@@ -4,11 +4,11 b''
 
 <%def name="breadcrumbs_links()">
   %if c.repo:
-    ${h.link_to('Settings',h.url('edit_repo', repo_name=c.repo.repo_name))}
+    ${h.link_to('Settings',h.route_path('edit_repo', repo_name=c.repo.repo_name))}
     &raquo;
     ${h.link_to(_('Integrations'),request.route_url(route_name='repo_integrations_home', repo_name=c.repo.repo_name))}
   %elif c.repo_group:
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${h.link_to(_('Repository Groups'),h.url('repo_groups'))}
     &raquo;
@@ -16,7 +16,7 b''
     &raquo;
     ${h.link_to(_('Integrations'),request.route_url(route_name='repo_group_integrations_home', repo_group_name=c.repo_group.group_name))}
   %else:
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${h.link_to(_('Settings'),h.url('admin_settings'))}
     &raquo;

rhodecode/templates/admin/my_account/my_account.mako

@@ -34,12 +34,12 b''
           % if my_account_oauth_url:
           <li class="${'active' if c.active=='oauth' else ''}"><a href="${my_account_oauth_url}">${_('OAuth Identities')}</a></li>
           % endif
-          <li class="${'active' if c.active=='emails' else ''}"><a href="${h.url('my_account_emails')}">${_('Emails')}</a></li>
-          <li class="${'active' if c.active=='repos' else ''}"><a href="${h.url('my_account_repos')}">${_('Repositories')}</a></li>
-          <li class="${'active' if c.active=='watched' else ''}"><a href="${h.url('my_account_watched')}">${_('Watched')}</a></li>
+          <li class="${'active' if c.active=='emails' else ''}"><a href="${h.route_path('my_account_emails')}">${_('Emails')}</a></li>
+          <li class="${'active' if c.active=='repos' else ''}"><a href="${h.route_path('my_account_repos')}">${_('Repositories')}</a></li>
+          <li class="${'active' if c.active=='watched' else ''}"><a href="${h.route_path('my_account_watched')}">${_('Watched')}</a></li>
           <li class="${'active' if c.active=='pullrequests' else ''}"><a href="${h.url('my_account_pullrequests')}">${_('Pull Requests')}</a></li>
-          <li class="${'active' if c.active=='perms' else ''}"><a href="${h.url('my_account_perms')}">${_('Permissions')}</a></li>
-          <li class="${'active' if c.active=='my_notifications' else ''}"><a href="${h.url('my_account_notifications')}">${_('Live Notifications')}</a></li>
+          <li class="${'active' if c.active=='perms' else ''}"><a href="${h.route_path('my_account_perms')}">${_('Permissions')}</a></li>
+          <li class="${'active' if c.active=='my_notifications' else ''}"><a href="${h.route_path('my_account_notifications')}">${_('Live Notifications')}</a></li>
         </ul>
     </div>
 

rhodecode/templates/admin/my_account/my_account_auth_tokens.mako

@@ -43,9 +43,9 b''
                 </td>
                 <td class="td-action">
                     ${h.secure_form(h.route_path('my_account_auth_tokens_delete'), method='post')}
-                        ${h.hidden('del_auth_token',auth_token.api_key)}
+                        ${h.hidden('del_auth_token', auth_token.user_api_key_id)}
                         <button class="btn btn-link btn-danger" type="submit"
-                                onclick="return confirm('${_('Confirm to remove this auth token: %s') % auth_token.api_key}');">
+                                onclick="return confirm('${_('Confirm to remove this auth token: %s') % auth_token.token_obfuscated}');">
                             ${_('Delete')}
                         </button>
                     ${h.end_form()}
@@ -139,7 +139,7 b' var repoFilter = function(data) {'
             query.callback({results: cachedData.results});
         } else {
             $.ajax({
-                url: "${h.url('repo_list_data')}",
+                url: pyroutes.url('repo_list_data'),
                 data: {'query': query.term},
                 dataType: 'json',
                 type: 'GET',

rhodecode/templates/admin/my_account/my_account_emails.mako

@@ -25,10 +25,10 b''
                         <span class="user email">${em.email}</span>
                     </td>
                     <td class="td-action">
-                        ${h.secure_form(url('my_account_emails'),method='delete')}
+                        ${h.secure_form(h.route_path('my_account_emails_delete'), method='POST')}
                             ${h.hidden('del_email_id',em.email_id)}
-                            <button class="btn btn-link btn-danger" type="submit" id="remove_email_%s" % em.email_id
-                                    onclick="return confirm('${_('Confirm to delete this email: %s') % em.email}');">
+                            <button class="btn btn-link btn-danger" type="submit" id="${'remove_email_%s'.format(em.email_id)}"
+                                    onclick="return confirm('${_('Confirm to delete this email: {}').format(em.email)}');">
                                 ${_('Delete')}
                             </button>
                         ${h.end_form()}
@@ -48,7 +48,7 b''
         </div>
 
         <div>
-            ${h.secure_form(url('my_account_emails'), method='post')}
+            ${h.secure_form(h.route_path('my_account_emails_add'), method='POST')}
             <div class="form">
                 <!-- fields -->
                 <div class="fields">

rhodecode/templates/admin/my_account/my_account_notifications.mako

@@ -1,7 +1,7 b''
 <template is="dom-bind" id="notificationsPage">
 <iron-ajax id="toggleNotifications"
            method="post"
-           url="${url('my_account_notifications_toggle_visibility')}"
+           url="${h.route_path('my_account_notifications_toggle_visibility')}"
            content-type="application/json"
            loading="{{changeNotificationsLoading}}"
            on-response="handleNotifications"
@@ -10,7 +10,7 b''
 
 <iron-ajax id="sendTestNotification"
            method="post"
-           url="${url('my_account_notifications_test_channelstream')}"
+           url="${h.route_path('my_account_notifications_test_channelstream')}"
            content-type="application/json"
            on-response="handleTestNotification"
            handle-as="json">

rhodecode/templates/admin/my_account/my_account_profile.mako

@@ -32,7 +32,7 b''
                 ${_('First Name')}:
             </div>
             <div class="right-content">
-                ${c.user.firstname}
+                ${c.user.first_name}
             </div>
         </div>
         <div class="fieldset">
@@ -40,7 +40,7 b''
                 ${_('Last Name')}:
             </div>
             <div class="right-content">
-                ${c.user.lastname}
+                ${c.user.last_name}
             </div>
         </div>
         <div class="fieldset">

rhodecode/templates/admin/notifications/show_notification.mako

@@ -9,7 +9,7 b''
 </%def>
 
 <%def name="breadcrumbs_links()">
-    ${h.link_to(_('Notifications'),h.url('notifications'))}
+    ${h.link_to(_('Notifications'), h.url('notifications'))}
     &raquo;
     ${_('Show notification')}
 </%def>
@@ -23,11 +23,6 b''
     <!-- box / title -->
     <div class="title">
         ${self.breadcrumbs()}
-        ##<ul class="links">
-        ##    <li>
-        ##      <span ><a href="#">${_('Compose message')}</a></span>
-        ##    </li>
-        ##</ul>
     </div>
     <div class="table">
       <div id="notification_${c.notification.notification_id}" class="main-content-full">
@@ -41,7 +36,9 b''
           </div>
         </div>
         <div class="notification-body">
-        <div class="notification-subject">${h.literal(c.notification.subject)}</div>
+        <div class="notification-subject">
+            <h3>${_('Subject')}: ${c.notification.subject}</h3>
+        </div>
         %if c.notification.body:
             ${h.render(c.notification.body, renderer=c.visual.default_renderer, mentions=True)}
         %endif

rhodecode/templates/admin/permissions/permissions.mako

@@ -9,7 +9,7 b''
 </%def>
 
 <%def name="breadcrumbs_links()">
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${_('Permissions')}
 </%def>

rhodecode/templates/admin/permissions/permissions_ips.mako

@@ -20,7 +20,7 b''
               <td class="td-iprange"><div class="ip">${h.ip_range(ip.ip_addr)}</div></td>
               <td class="td-description"><div class="ip">${ip.description}</div></td>
               <td class="td-action">
-                ${h.secure_form(url('edit_user_ips', user_id=c.user.user_id),method='delete')}
+                ${h.secure_form(h.route_path('edit_user_ips_delete', user_id=c.user.user_id), method='POST')}
                     ${h.hidden('del_ip_id',ip.ip_id)}
                     ${h.hidden('default_user', 'True')}
                     ${h.submit('remove_',_('Delete'),id="remove_ip_%s" % ip.ip_id,
@@ -40,7 +40,7 b''
       </table>
     </div>
 
-    ${h.secure_form(url('edit_user_ips', user_id=c.user.user_id),method='put')}
+    ${h.secure_form(h.route_path('edit_user_ips_add', user_id=c.user.user_id), method='POST')}
       <div class="form">
         <!-- fields -->
         <div class="fields">

rhodecode/templates/admin/repo_groups/repo_group_add.mako

@@ -9,7 +9,7 b''
 </%def>
 
 <%def name="breadcrumbs_links()">
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${h.link_to(_('Repository groups'),h.url('repo_groups'))}
     &raquo;

rhodecode/templates/admin/repo_groups/repo_group_edit.mako

@@ -9,11 +9,11 b''
 </%def>
 
 <%def name="breadcrumbs_links()">
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${h.link_to(_('Repository Groups'),h.url('repo_groups'))}
     %if c.repo_group.parent_group:
-        &raquo; ${h.link_to(c.repo_group.parent_group.name,h.url('repo_group_home',group_name=c.repo_group.parent_group.group_name))}
+        &raquo; ${h.link_to(c.repo_group.parent_group.name, h.route_path('repo_group_home', repo_group_name=c.repo_group.parent_group.group_name))}
     %endif
     &raquo; ${c.repo_group.name}
 </%def>

rhodecode/templates/admin/repo_groups/repo_groups.mako

@@ -10,7 +10,7 b''
 
 <%def name="breadcrumbs_links()">
     <input class="q_filter_box" id="q_filter" size="15" type="text" name="filter" placeholder="${_('quick filter...')}" value=""/>
-    ${h.link_to(_('Admin'),h.url('admin_home'))} &raquo; <span id="repo_group_count">0</span> ${_('repository groups')}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))} &raquo; <span id="repo_group_count">0</span> ${_('repository groups')}
 </%def>
 
 <%def name="menu_bar_nav()">

rhodecode/templates/admin/repos/repo_add.mako

@@ -10,7 +10,7 b''
 
 <%def name="breadcrumbs_links()">
     %if c.rhodecode_user.is_admin:
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${h.link_to(_('Repositories'),h.url('repos'))}
     %else:

rhodecode/templates/admin/repos/repo_creating.mako

@@ -48,12 +48,12 b''
             if (jsonResponse === undefined) {
                 setTimeout(function () {
                     // we might have a backend problem, try dashboard again
-                    window.location = "${h.url('summary_home', repo_name = c.repo)}";
+                    window.location = "${h.route_path('repo_summary', repo_name = c.repo)}";
                 }, 3000);
             } else {
                 if (skipCheck || jsonResponse.result === true) {
                     // success, means go to dashboard
-                    window.location = "${h.url('summary_home', repo_name = c.repo)}";
+                    window.location = "${h.route_path('repo_summary', repo_name = c.repo)}";
                 } else {
                     // Schedule the next request when the current one's complete
                     setTimeout(worker, 1000);
@@ -61,7 +61,7 b''
             }
         }
         else {
-            window.location = "${h.url('home')}";
+            window.location = "${h.route_path('home')}";
         }
     }
   });

rhodecode/templates/admin/repos/repo_edit.mako

@@ -24,7 +24,11 b''
 </%def>
 
 <%def name="main_content()">
-  <%include file="/admin/repos/repo_edit_${c.active}.mako"/>
+  % if hasattr(c, 'repo_edit_template'):
+    <%include file="${c.repo_edit_template}"/>
+  % else:
+    <%include file="/admin/repos/repo_edit_${c.active}.mako"/>
+  % endif
 </%def>
 
 
@@ -36,17 +40,16 b''
   </div>
 
   <div class="sidebar-col-wrapper scw-small">
-    ##main
     <div class="sidebar">
         <ul class="nav nav-pills nav-stacked">
           <li class="${'active' if c.active=='settings' else ''}">
-              <a href="${h.url('edit_repo', repo_name=c.repo_name)}">${_('Settings')}</a>
+              <a href="${h.route_path('edit_repo', repo_name=c.repo_name)}">${_('Settings')}</a>
           </li>
           <li class="${'active' if c.active=='permissions' else ''}">
-              <a href="${h.url('edit_repo_perms', repo_name=c.repo_name)}">${_('Permissions')}</a>
+              <a href="${h.route_path('edit_repo_perms', repo_name=c.repo_name)}">${_('Permissions')}</a>
           </li>
           <li class="${'active' if c.active=='advanced' else ''}">
-              <a href="${h.url('edit_repo_advanced', repo_name=c.repo_name)}">${_('Advanced')}</a>
+              <a href="${h.route_path('edit_repo_advanced', repo_name=c.repo_name)}">${_('Advanced')}</a>
           </li>
           <li class="${'active' if c.active=='vcs' else ''}">
               <a href="${h.url('repo_vcs_settings', repo_name=c.repo_name)}">${_('VCS')}</a>
@@ -58,7 +61,7 b''
               <a href="${h.url('repo_settings_issuetracker', repo_name=c.repo_name)}">${_('Issue Tracker')}</a>
           </li>
           <li class="${'active' if c.active=='caches' else ''}">
-              <a href="${h.url('edit_repo_caches', repo_name=c.repo_name)}">${_('Caches')}</a>
+              <a href="${h.route_path('edit_repo_caches', repo_name=c.repo_name)}">${_('Caches')}</a>
           </li>
           %if c.repo_info.repo_type != 'svn':
           <li class="${'active' if c.active=='remote' else ''}">
@@ -71,28 +74,18 b''
           <li class="${'active' if c.active=='integrations' else ''}">
               <a href="${h.route_path('repo_integrations_home', repo_name=c.repo_name)}">${_('Integrations')}</a>
           </li>
+          %if c.repo_info.repo_type != 'svn':
+          <li class="${'active' if c.active=='reviewers' else ''}">
+              <a href="${h.route_path('repo_reviewers', repo_name=c.repo_name)}">${_('Reviewer Rules')}</a>
+          </li>
+          %endif
           <li class="${'active' if c.active=='maintenance' else ''}">
               <a href="${h.route_path('repo_maintenance', repo_name=c.repo_name)}">${_('Maintenance')}</a>
           </li>
           <li class="${'active' if c.active=='strip' else ''}">
               <a href="${h.route_path('strip', repo_name=c.repo_name)}">${_('Strip')}</a>
           </li>
-          ## TODO: dan: replace repo navigation with navlist registry like with
-          ## admin menu. First must find way to allow runtime configuration
-          ## it to account for the c.repo_info.repo_type != 'svn' call above
-          <%
-          reviewer_settings = False
-          try:
-            import rc_reviewers
-            reviewer_settings = True
-          except ImportError:
-            pass
-          %>
-          %if reviewer_settings:
-          <li class="${'active' if c.active=='reviewers' else ''}">
-              <a href="${h.route_path('repo_reviewers_home', repo_name=c.repo_name)}">${_('Reviewers')}</a>
-          </li>
-          %endif
+
         </ul>
     </div>
 

rhodecode/templates/admin/repos/repo_edit_advanced.mako

@@ -10,8 +10,8 b''
 %>
 
 <div class="panel panel-default">
-    <div class="panel-heading">
-        <h3 class="panel-title">${_('Repository: %s') % c.repo_info.repo_name}</h3>
+    <div class="panel-heading" id="advanced-info" >
+        <h3 class="panel-title">${_('Repository: %s') % c.repo_info.repo_name} <a class="permalink" href="#advanced-info"> ¶</a></h3>
     </div>
     <div class="panel-body">
         ${base.dt_info_panel(elems)}
@@ -20,14 +20,14 b''
 
 
 <div class="panel panel-default">
-    <div class="panel-heading">
-        <h3 class="panel-title">${_('Fork Reference')}</h3>
+    <div class="panel-heading" id="advanced-fork">
+        <h3 class="panel-title">${_('Fork Reference')} <a class="permalink" href="#advanced-fork"> ¶</a></h3>
     </div>
     <div class="panel-body">
-      ${h.secure_form(url('edit_repo_advanced_fork', repo_name=c.repo_info.repo_name), method='put')}
+      ${h.secure_form(h.route_path('edit_repo_advanced_fork', repo_name=c.repo_info.repo_name), method='POST')}
 
         % if c.repo_info.fork:
-            <div class="panel-body-title-text">${h.literal(_('This repository is a fork of %(repo_link)s') % {'repo_link': h.link_to_if(c.has_origin_repo_read_perm,c.repo_info.fork.repo_name, h.url('summary_home', repo_name=c.repo_info.fork.repo_name))})}
+            <div class="panel-body-title-text">${h.literal(_('This repository is a fork of %(repo_link)s') % {'repo_link': h.link_to_if(c.has_origin_repo_read_perm,c.repo_info.fork.repo_name, h.route_path('repo_summary', repo_name=c.repo_info.fork.repo_name))})}
             | <button class="btn btn-link btn-danger" type="submit">Remove fork reference</button></div>
         % endif
 
@@ -44,15 +44,14 b''
 
 
 <div class="panel panel-default">
-    <div class="panel-heading">
-        <h3 class="panel-title">${_('Public Journal Visibility')}</h3>
+    <div class="panel-heading" id="advanced-journal">
+        <h3 class="panel-title">${_('Public Journal Visibility')} <a class="permalink" href="#advanced-journal"> ¶</a></h3>
     </div>
     <div class="panel-body">
-      ${h.secure_form(url('edit_repo_advanced_journal', repo_name=c.repo_info.repo_name), method='put')}
+      ${h.secure_form(h.route_path('edit_repo_advanced_journal', repo_name=c.repo_info.repo_name), method='POST')}
         <div class="field">
         %if c.in_public_journal:
           <button class="btn btn-small" type="submit">
-              <i class="icon-minus"></i>
               ${_('Remove from Public Journal')}
           </button>
         %else:
@@ -70,11 +69,11 b''
 
 
 <div class="panel panel-default">
-    <div class="panel-heading">
-        <h3 class="panel-title">${_('Locking state')}</h3>
+    <div class="panel-heading" id="advanced-locking">
+        <h3 class="panel-title">${_('Locking state')} <a class="permalink" href="#advanced-locking"> ¶</a></h3>
     </div>
     <div class="panel-body">
-        ${h.secure_form(url('edit_repo_advanced_locking', repo_name=c.repo_info.repo_name), method='put')}
+        ${h.secure_form(h.route_path('edit_repo_advanced_locking', repo_name=c.repo_info.repo_name), method='POST')}
 
         %if c.repo_info.locked[0]:
              <div class="panel-body-title-text">${'Locked by %s on %s. Lock reason: %s' % (h.person_by_id(c.repo_info.locked[0]),
@@ -110,15 +109,15 b''
 </div>
 
 <div class="panel panel-danger">
-    <div class="panel-heading">
-        <h3 class="panel-title">${_('Delete repository')}</h3>
+    <div class="panel-heading" id="advanced-delete">
+        <h3 class="panel-title">${_('Delete repository')} <a class="permalink" href="#advanced-delete"> ¶</a></h3>
     </div>
     <div class="panel-body">
-      ${h.secure_form(url('repo', repo_name=c.repo_name),method='delete')}
+      ${h.secure_form(h.route_path('edit_repo_advanced_delete', repo_name=c.repo_name), method='POST')}
         <table class="display">
             <tr>
                 <td>
-                    ${ungettext('This repository has %s fork.', 'This repository has %s forks.', c.repo_info.  forks.count()) % c.repo_info.forks.count()}
+                    ${_ungettext('This repository has %s fork.', 'This repository has %s forks.', c.repo_info.forks.count()) % c.repo_info.forks.count()}
                 </td>
                 <td>
                     %if c.repo_info.forks.count():
@@ -143,7 +142,7 b''
         </div>
         <div class="field">
             <span class="help-block">
-                ${_('This repository will be renamed in a special way in order to make it inaccessible to RhodeCode Enterprise and its VCS systems. If you need to fully delete it from the file system, please do it manually, or with rhodecode-cleanup-repos command.')}
+                ${_('This repository will be renamed in a special way in order to make it inaccessible to RhodeCode Enterprise and its VCS systems. If you need to fully delete it from the file system, please do it manually, or with rhodecode-cleanup-repos command available in rhodecode-tools.')}
             </span>
         </div>
 
@@ -191,7 +190,7 b' var repoTypeFilter = function(data) {'
             query.callback({results: cachedData.results});
         } else {
             $.ajax({
-                url: "${h.url('repo_list_data')}",
+                url: pyroutes.url('repo_list_data'),
                 data: {'query': query.term, repo_type: '${c.repo_info.repo_type}'},
                 dataType: 'json',
                 type: 'GET',

rhodecode/templates/admin/repos/repo_edit_caches.mako

@@ -3,21 +3,25 b''
         <h3 class="panel-title">${_('Invalidate Cache for Repository')}</h3>
     </div>
     <div class="panel-body">
-        ${h.secure_form(url('edit_repo_caches', repo_name=c.repo_name), method='put')}
-        <div>
+
+        <h4>${_('Manually invalidate the repository cache. On the next access a repository cache will be recreated.')}</h4>
+
+        <p>
+            ${_('Cache purge can be automated by such api call. Can be called periodically in crontab etc.')}
+            <br/>
+            <code>
+            ${h.api_call_example(method='invalidate_cache', args={"repoid": c.repo_info.repo_name})}
+            </code>
+        </p>
+
+        ${h.secure_form(h.route_path('edit_repo_caches', repo_name=c.repo_name), method='POST')}
+        <div class="form">
            <div class="fields">
-              <p>
-                 ${h.submit('reset_cache_%s' % c.repo_info.repo_name,_('Invalidate repository cache'),class_="btn btn-small",onclick="return confirm('"+_('Confirm to invalidate repository cache')+"');")}
-              </p>
-              <div class="field" >
-                  <span class="help-block">
-                  ${_('Manually invalidate the repository cache. On the next access a repository cache will be recreated.')}
-                  </span>
-              </div>
-
+               ${h.submit('reset_cache_%s' % c.repo_info.repo_name,_('Invalidate repository cache'),class_="btn btn-small",onclick="return confirm('"+_('Confirm to invalidate repository cache')+"');")}
            </div>
         </div>
         ${h.end_form()}
+
     </div>
 </div>
 
@@ -25,7 +29,7 b''
 <div class="panel panel-default">
     <div class="panel-heading">
         <h3 class="panel-title">
-            ${(ungettext('List of repository caches (%(count)s entry)', 'List of repository caches (%(count)s entries)' ,len(c.repo_info.cache_keys)) % {'count': len(c.repo_info.cache_keys)})}
+            ${(_ungettext('List of repository caches (%(count)s entry)', 'List of repository caches (%(count)s entries)' ,len(c.repo_info.cache_keys)) % {'count': len(c.repo_info.cache_keys)})}
         </h3>
     </div>
     <div class="panel-body">
@@ -47,5 +51,3 b''
       </div>
     </div>
 </div>
-
-

rhodecode/templates/admin/repos/repo_edit_maintenance.mako

@@ -4,19 +4,27 b''
     </div>
     <div class="panel-body">
 
+        % if c.executable_tasks:
+        <h4>${_('Perform maintenance tasks for this repo')}</h4>
+
+        <span>${_('Following tasks will be performed')}:</span>
+        <ol>
+        % for task in c.executable_tasks:
+            <li>${task}</li>
+        % endfor
+        </ol>
         <p>
-            % if c.executable_tasks:
-            ${_('Perform maintenance tasks for this repo, following tasks will be performed')}:
-            <ol>
-            % for task in c.executable_tasks:
-                <li>${task}</li>
-            % endfor
-            </ol>
-            % else:
-                ${_('No maintenance tasks for this repo available')}
-            % endif
+            ${_('Maintenance can be automated by such api call. Can be called periodically in crontab etc.')}
+            <br/>
+            <code>
+                ${h.api_call_example(method='maintenance', args={"repoid": c.repo_info.repo_name})}
+            </code>
         </p>
 
+        % else:
+            <h4>${_('No maintenance tasks for this repo available')}</h4>
+        % endif
+
         <div id="results" style="display:none; padding: 10px 0px;"></div>
 
         % if c.executable_tasks:

rhodecode/templates/admin/repos/repo_edit_permissions.mako

@@ -5,8 +5,7 b''
         <h3 class="panel-title">${_('Repository Permissions')}</h3>
     </div>
     <div class="panel-body">
-        ${h.secure_form(url('edit_repo_perms_update', repo_name=c.repo_name), method='put')}
-        ${h.hidden('repo_private')}
+        ${h.secure_form(h.route_path('edit_repo_perms', repo_name=c.repo_name), method='POST')}
         <table id="permissions_manage" class="rctable permissions">
             <tr>
                 <th class="td-radio">${_('None')}</th>
@@ -40,7 +39,7 b''
                     <tr>
                         <td colspan="4">
                             <span class="private_repo_msg">
-                            <strong>${_('private repository')}</strong>
+                            <strong title="${h.tooltip(_user.permission)}">${_('private repository')}</strong>
                             </span>
                         </td>
                         <td class="private_repo_msg">
@@ -50,10 +49,10 b''
                     </tr>
                 %else:
                     <tr>
-                        <td class="td-radio">${h.radio('u_perm_%s' % _user.user_id,'repository.none')}</td>
-                        <td class="td-radio">${h.radio('u_perm_%s' % _user.user_id,'repository.read')}</td>
-                        <td class="td-radio">${h.radio('u_perm_%s' % _user.user_id,'repository.write')}</td>
-                        <td class="td-radio">${h.radio('u_perm_%s' % _user.user_id,'repository.admin')}</td>
+                        <td class="td-radio">${h.radio('u_perm_%s' % _user.user_id,'repository.none', checked=_user.permission=='repository.none')}</td>
+                        <td class="td-radio">${h.radio('u_perm_%s' % _user.user_id,'repository.read', checked=_user.permission=='repository.read')}</td>
+                        <td class="td-radio">${h.radio('u_perm_%s' % _user.user_id,'repository.write', checked=_user.permission=='repository.write')}</td>
+                        <td class="td-radio">${h.radio('u_perm_%s' % _user.user_id,'repository.admin', checked=_user.permission=='repository.admin')}</td>
                         <td class="td-user">
                             ${base.gravatar(_user.email, 16)}
                             <span class="user">
@@ -79,10 +78,10 b''
             ## USER GROUPS
             %for _user_group in c.repo_info.permission_user_groups():
                 <tr>
-                    <td class="td-radio">${h.radio('g_perm_%s' % _user_group.users_group_id,'repository.none')}</td>
-                    <td class="td-radio">${h.radio('g_perm_%s' % _user_group.users_group_id,'repository.read')}</td>
-                    <td class="td-radio">${h.radio('g_perm_%s' % _user_group.users_group_id,'repository.write')}</td>
-                    <td class="td-radio">${h.radio('g_perm_%s' % _user_group.users_group_id,'repository.admin')}</td>
+                    <td class="td-radio">${h.radio('g_perm_%s' % _user_group.users_group_id,'repository.none', checked=_user_group.permission=='repository.none')}</td>
+                    <td class="td-radio">${h.radio('g_perm_%s' % _user_group.users_group_id,'repository.read', checked=_user_group.permission=='repository.read')}</td>
+                    <td class="td-radio">${h.radio('g_perm_%s' % _user_group.users_group_id,'repository.write', checked=_user_group.permission=='repository.write')}</td>
+                    <td class="td-radio">${h.radio('g_perm_%s' % _user_group.users_group_id,'repository.admin', checked=_user_group.permission=='repository.admin')}</td>
                     <td class="td-componentname">
                         <i class="icon-group" ></i>
                         %if h.HasPermissionAny('hg.admin')():

rhodecode/templates/admin/repos/repo_edit_remote.mako

@@ -4,17 +4,20 b''
     </div>
     <div class="panel-body">
 
+        <h4>${_('Manually pull changes from external repository.')}</h4>
+
         %if c.repo_info.clone_uri:
 
-            <div class="panel-body-title-text">${_('Remote mirror url')}:
-                <a href="${c.repo_info.clone_uri}">${c.repo_info.clone_uri_hidden}</a>
-                <p>
-                ${_('Pull can be automated by such api call called periodically (in crontab etc)')}
-                </p>
+            ${_('Remote mirror url')}:
+            <a href="${c.repo_info.clone_uri}">${c.repo_info.clone_uri_hidden}</a>
+
+            <p>
+                ${_('Pull can be automated by such api call. Can be called periodically in crontab etc.')}
+                <br/>
                 <code>
-                curl ${h.route_url('apiv2')} -X POST -H 'content-type:text/plain' --data-binary '{"id":1, "auth_token":"SECRET","method":"pull", "args":{"repoid":"${c.repo_info.repo_name}"}}'
+                ${h.api_call_example(method='pull', args={"repoid": c.repo_info.repo_name})}
                 </code>
-            </div>
+            </p>
 
             ${h.secure_form(url('edit_repo_remote', repo_name=c.repo_name), method='put')}
             <div class="form">
@@ -24,14 +27,14 b''
             </div>
             ${h.end_form()}
         %else:
-          <div class="panel-body-title-text">${_('This repository does not have any remote mirror url set.')}</div>
 
+          ${_('This repository does not have any remote mirror url set.')}
+          <a href="${h.route_path('edit_repo', repo_name=c.repo_info.repo_name)}">${_('Set remote url.')}</a>
+          <br/>
+          <br/>
           <button class="btn disabled" type="submit" disabled="disabled">
             ${_('Pull changes from remote location')}
           </button>
         %endif
     </div>
 </div>
-
-
-

rhodecode/templates/admin/repos/repo_edit_settings.mako

@@ -3,92 +3,121 b''
 
 <div class="panel panel-default">
     <div class="panel-heading">
-        <h3 class="panel-title">${_('Settings for Repository: %s') % c.repo_info.repo_name}</h3>
+        <h3 class="panel-title">${_('Settings for Repository: %s') % c.rhodecode_db_repo.repo_name}</h3>
     </div>
     <div class="panel-body">
-    ${h.secure_form(url('repo', repo_name=c.repo_info.repo_name),method='put')}
+    ${h.secure_form(h.route_path('edit_repo', repo_name=c.rhodecode_db_repo.repo_name), method='POST')}
     <div class="form">
         <!-- fields -->
         <div class="fields">
+
             <div class="field">
                 <div class="label">
                     <label for="repo_name">${_('Name')}:</label>
                 </div>
                 <div class="input">
-                    ${h.text('repo_name',class_="medium")}
-                    <p class="help-block">${_('Non-changeable id')}: `_${c.repo_info.repo_id}` <span><a id="show_more_clone_id" href="#">${_('what is that ?')}</a></span></p>
+                    ${c.form['repo_name'].render(css_class='medium', oid='repo_name')|n}
+                    ${c.form.render_error(request, c.form['repo_name'])|n}
+
+                    <p class="help-block">${_('Non-changeable id')}: `_${c.rhodecode_db_repo.repo_id}` <span><a href="#" onclick="$('#clone_id').toggle();return false">${_('what is that ?')}</a></span></p>
                     <p id="clone_id" style="display:none;">
-                        ${_('URL by id')}: `${c.repo_info.clone_url(with_id=True)}` </br>
+                        ${_('URL by id')}: `${c.rhodecode_db_repo.clone_url(with_id=True)}` <br/>
                         ${_('''In case this repository is renamed or moved into another group the repository url changes.
                                Using above url guarantees that this repository will always be accessible under such url.
                                Useful for CI systems, or any other cases that you need to hardcode the url into 3rd party service.''')}</p>
                 </div>
            </div>
-           % if c.repo_info.repo_type != 'svn':
+
+           <div class="field">
+                <div class="label">
+                    <label for="repo_group">${_('Repository group')}:</label>
+                </div>
+                <div class="select">
+                    ${c.form['repo_group'].render(css_class='medium', oid='repo_group')|n}
+                    ${c.form.render_error(request, c.form['repo_group'])|n}
+
+                    % if c.personal_repo_group:
+                         <a class="btn" href="#" data-personal-group-name="${c.personal_repo_group.group_name}" data-personal-group-id="${c.personal_repo_group.group_id}" onclick="selectMyGroup(this); return false">
+                             ${_('Select my personal group (`%(repo_group_name)s`)') % {'repo_group_name': c.personal_repo_group.group_name}}
+                         </a>
+                    % endif
+                    <p class="help-block">${_('Optional select a group to put this repository into.')}</p>
+                </div>
+           </div>
+
+           % if c.rhodecode_db_repo.repo_type != 'svn':
            <div class="field">
                <div class="label">
                    <label for="clone_uri">${_('Remote uri')}:</label>
                </div>
                <div class="input">
-                   %if c.repo_info.clone_uri:
+                   %if c.rhodecode_db_repo.clone_uri:
+                    ## display, if we don't have any errors
+                    % if not c.form['repo_clone_uri'].error:
                     <div id="clone_uri_hidden" class='text-as-placeholder'>
-                        <span id="clone_uri_hidden_value">${c.repo_info.clone_uri_hidden}</span>
+                        <span id="clone_uri_hidden_value">${c.rhodecode_db_repo.clone_uri_hidden}</span>
                         <span class="link" id="edit_clone_uri"><i class="icon-edit"></i>${_('edit')}</span>
                     </div>
-                    <div id="alter_clone_uri" style="display: none">
-                        ${h.text('clone_uri',class_="medium",  placeholder=_('new value, leave empty to remove'))}
-                        ${h.hidden('clone_uri_change', 'OLD')}
+                    % endif
+
+                    ## alter field
+                    <div id="alter_clone_uri" style="${'' if c.form['repo_clone_uri'].error else 'display: none'}">
+                        ${c.form['repo_clone_uri'].render(css_class='medium', oid='clone_uri', placeholder=_('enter new value, or leave empty to remove'))|n}
+                        ${c.form.render_error(request, c.form['repo_clone_uri'])|n}
+                        % if c.form['repo_clone_uri'].error:
+                            ## we got error from form subit, means we modify the url
+                            ${h.hidden('repo_clone_uri_change', 'MOD')}
+                        % else:
+                            ${h.hidden('repo_clone_uri_change', 'OLD')}
+                        % endif
+
+                        % if not c.form['repo_clone_uri'].error:
                         <span class="link" id="cancel_edit_clone_uri">${_('cancel')}</span>
+                        % endif
+
                     </div>
                    %else:
                     ## not set yet, display form to set it
-                    ${h.text('clone_uri',class_="medium")}
-                    ${h.hidden('clone_uri_change', 'NEW')}
+                    ${c.form['repo_clone_uri'].render(css_class='medium', oid='clone_uri')|n}
+                    ${c.form.render_error(request, c.form['repo_clone_uri'])|n}
+                    ${h.hidden('repo_clone_uri_change', 'NEW')}
                    %endif
-                 <p id="alter_clone_uri_help_block" class="help-block">${_('http[s] url where from repository was imported, also used for doing remote pulls.')}</p>
+                 <p id="alter_clone_uri_help_block" class="help-block">
+                     <% pull_link = h.literal(h.link_to('remote sync', h.url('edit_repo_remote', repo_name=c.repo_name))) %>
+                     ${_('http[s] url where from repository was imported, this field can used for doing {pull_link}.').format(pull_link=pull_link)|n} <br/>
+                     ${_('This field is stored encrypted inside Database, a format of http://user:[e-mail]/repo_name can be used and will be hidden from display.')}
+                 </p>
                </div>
             </div>
-            % else:
-              ${h.hidden('clone_uri', '')}
-            % endif
+           % else:
+           ${h.hidden('repo_clone_uri', '')}
+           % endif
+
             <div class="field">
                 <div class="label">
-                    <label for="repo_group">${_('Repository group')}:</label>
+                    <label for="repo_landing_commit_ref">${_('Landing commit')}:</label>
                 </div>
                 <div class="select">
-                    ${h.select('repo_group','',c.repo_groups,class_="medium")}
-                    % if c.personal_repo_group:
-                         <a class="btn" href="#" id="select_my_group" data-personal-group-id="${c.personal_repo_group.group_id}">
-                             ${_('Select my personal group (%(repo_group_name)s)') % {'repo_group_name': c.personal_repo_group.group_name}}
-                         </a>
-                    % endif
-                    <p class="help-block">${_('Optional select a group to put this repository into.')}</p>
-                </div>
-            </div>
-            <div class="field">
-                <div class="label">
-                    <label for="repo_landing_rev">${_('Landing commit')}:</label>
-                </div>
-                <div class="select">
-                    ${h.select('repo_landing_rev','',c.landing_revs,class_="medium")}
-                    <p class="help-block">${_('Default commit for files page, downloads, whoosh and readme')}</p>
+                    ${c.form['repo_landing_commit_ref'].render(css_class='medium', oid='repo_landing_commit_ref')|n}
+                    ${c.form.render_error(request, c.form['repo_landing_commit_ref'])|n}
+                    <p class="help-block">${_('Default commit for files page, downloads, full text search index and readme')}</p>
                 </div>
             </div>
 
             <div class="field badged-field">
                 <div class="label">
-                    <label for="user">${_('Owner')}:</label>
+                    <label for="repo_owner">${_('Owner')}:</label>
                 </div>
                 <div class="input">
                     <div class="badge-input-container">
                         <div class="user-badge">
-                            ${base.gravatar_with_user(c.repo_info.user.email, show_disabled=not c.repo_info.user.active)}
+                            ${base.gravatar_with_user(c.rhodecode_db_repo.user.email or c.rhodecode_db_repo.user.username, show_disabled=not c.rhodecode_db_repo.user.active)}
                         </div>
                         <div class="badge-input-wrap">
-                            ${h.text('user', class_="medium", autocomplete="off")}
+                            ${c.form['repo_owner'].render(css_class='medium', oid='repo_owner')|n}
                         </div>
                     </div>
-                    <form:error name="user"/>
+                    ${c.form.render_error(request, c.form['repo_owner'])|n}
                     <p class="help-block">${_('Change owner of this repository.')}</p>
                 </div>
             </div>
@@ -98,44 +127,49 b''
                     <label for="repo_description">${_('Description')}:</label>
                 </div>
                 <div class="textarea text-area editor">
-                    ${h.textarea('repo_description', )}
+                    ${c.form['repo_description'].render(css_class='medium', oid='repo_description')|n}
+                    ${c.form.render_error(request, c.form['repo_description'])|n}
                     <p class="help-block">${_('Keep it short and to the point. Use a README file for longer descriptions.')}</p>
                 </div>
             </div>
 
             <div class="field">
                 <div class="label label-checkbox">
-                    <label for="repo_private">${_('Private repository')}:</label>
+                    <label for="${c.form['repo_private'].oid}">${_('Private repository')}:</label>
                 </div>
                 <div class="checkboxes">
-                    ${h.checkbox('repo_private',value="True")}
+                    ${c.form['repo_private'].render(css_class='medium')|n}
+                    ${c.form.render_error(request, c.form['repo_private'])|n}
                     <span class="help-block">${_('Private repositories are only visible to people explicitly added as collaborators.')}</span>
                 </div>
             </div>
             <div class="field">
                 <div class="label label-checkbox">
-                    <label for="repo_enable_statistics">${_('Enable statistics')}:</label>
+                    <label for="${c.form['repo_enable_statistics'].oid}">${_('Enable statistics')}:</label>
                 </div>
                 <div class="checkboxes">
-                    ${h.checkbox('repo_enable_statistics',value="True")}
+                    ${c.form['repo_enable_statistics'].render(css_class='medium')|n}
+                    ${c.form.render_error(request, c.form['repo_enable_statistics'])|n}
                     <span class="help-block">${_('Enable statistics window on summary page.')}</span>
                 </div>
             </div>
             <div class="field">
                 <div class="label label-checkbox">
-                    <label for="repo_enable_downloads">${_('Enable downloads')}:</label>
+                    <label for="${c.form['repo_enable_downloads'].oid}">${_('Enable downloads')}:</label>
                 </div>
                 <div class="checkboxes">
-                    ${h.checkbox('repo_enable_downloads',value="True")}
+                    ${c.form['repo_enable_downloads'].render(css_class='medium')|n}
+                    ${c.form.render_error(request, c.form['repo_enable_downloads'])|n}
                     <span class="help-block">${_('Enable download menu on summary page.')}</span>
                 </div>
             </div>
             <div class="field">
                 <div class="label label-checkbox">
-                    <label for="repo_enable_locking">${_('Enable automatic locking')}:</label>
+                    <label for="${c.form['repo_enable_locking'].oid}">${_('Enable automatic locking')}:</label>
                 </div>
                 <div class="checkboxes">
-                    ${h.checkbox('repo_enable_locking',value="True")}
+                    ${c.form['repo_enable_locking'].render(css_class='medium')|n}
+                    ${c.form.render_error(request, c.form['repo_enable_locking'])|n}
                     <span class="help-block">${_('Enable automatic locking on repository. Pulling from this repository creates a lock that can be released by pushing back by the same user')}</span>
                 </div>
             </div>
@@ -168,12 +202,6 b''
 
 <script>
     $(document).ready(function(){
-        var select2Options = {
-          'containerCssClass': "drop-menu",
-          'dropdownCssClass': "drop-menu-dropdown",
-          'dropdownAutoWidth': true
-        };
-
         var cloneUrl = function() {
           var alterButton = $('#alter_clone_uri');
           var editButton = $('#edit_clone_uri');
@@ -182,7 +210,7 b''
           var hiddenUrlValue = $('#clone_uri_hidden_value');
           var input = $('#clone_uri');
           var helpBlock = $('#alter_clone_uri_help_block');
-          var changedFlag = $('#clone_uri_change');
+          var changedFlag = $('#repo_clone_uri_change');
           var originalText = helpBlock.html();
           var obfuscatedUrl = hiddenUrlValue.html();
 
@@ -223,18 +251,10 b''
           initEvents();
         }();
 
-        $('#show_more_clone_id').on('click', function(e){
-            $('#clone_id').show();
-            e.preventDefault();
-        });
+        selectMyGroup = function(element) {
+            $("#repo_group").val($(element).data('personalGroupId')).trigger("change");
+        };
 
-        $('#repo_landing_rev').select2(select2Options);
-        $('#repo_group').select2(select2Options);
-
-        UsersAutoComplete('user', '${c.rhodecode_user.user_id}');
-        $('#select_my_group').on('click', function(e){
-            e.preventDefault();
-            $("#repo_group").val($(this).data('personalGroupId')).trigger("change");
-        });
+        UsersAutoComplete('repo_owner', '${c.rhodecode_user.user_id}');
     });
 </script>

rhodecode/templates/admin/repos/repo_edit_strip.mako

@@ -23,7 +23,7 b''
                 <div id="results" style="display:none; padding: 10px 0px;"></div>
 
                 <div class="buttons">
-                   <button class="btn btn-small btn-primary" onclick="checkCommits();return false">
+                   <button id="strip_action" class="btn btn-small btn-primary" onclick="checkCommits();return false">
                    ${_('Check commits')}
                    </button>
                 </div>
@@ -104,34 +104,60 b' delOld = function(number){'
 
 };
 
-var result_data;
+var resultData = {
+    'csrf_token': CSRF_TOKEN
+};
 
 checkCommits = function() {
     var postData = $('form').serialize();
     $('#results').show();
     $('#results').html('<h4>${_('Checking commits')}...</h4>');
     var url = "${h.route_path('strip_check', repo_name=c.repo_info.repo_name)}";
-    var btn = $('button');
+    var btn = $('#strip_action');
     btn.attr('disabled', 'disabled');
     btn.addClass('disabled');
 
     var success = function (data) {
-        result_data = {};
+        resultData = {
+            'csrf_token': CSRF_TOKEN
+        };
         var i = 0;
-        result ='';
+        var result = '<ol>';
         $.each(data, function(index, value){
             i= index;
             var box = $('#box-'+index);
             if (value.rev){
-                result_data[index] = JSON.stringify(value);
-                msg = '${_("author")}: ' + value.author + ' ${_("comment")}: ' + value.comment;
-                result += '<h4><code>' +value.rev+ '</code>${_(' commit verified positive')}</br> '+ msg + '</h4>';
+                resultData[index] = JSON.stringify(value);
+
+                var verifiedHtml = (
+                        '<li style="line-height:1.2em">' +
+                            '<code>{0}</code>' +
+                            '{1}' +
+                            '<div style="white-space:pre">' +
+                            'author: {2}\n' +
+                            'description: {3}' +
+                            '</div>' +
+                        '</li>').format(
+                            value.rev,
+                            "${_(' commit verified positive')}",
+                            value.author, value.comment
+                            );
+                result += verifiedHtml;
             }
-            else{
-                result += '<h4><code>' +value.commit+ '</code>${_(' commit verified negative')}' + '</h4>';
+            else {
+                var verifiedHtml = (
+                        '<li style="line-height:1.2em">' +
+                            '<code><strike>{0}</strike></code>' +
+                            '{1}' +
+                        '</li>').format(
+                            value.commit,
+                            "${_(' commit verified negative')}"
+                            );
+                result += verifiedHtml;
             }
             box.remove();
         });
+        result += '</ol>';
         var box = $('#box-'+(parseInt(i)+1));
         box.remove();
         $('#results').html(result);
@@ -144,25 +170,28 b' checkCommits = function() {'
     ajaxPOST(url, postData, success, null);
 };
 
-strip = function(){
+strip = function() {
     var url = "${h.route_path('strip_execute', repo_name=c.repo_info.repo_name)}";
-    var success = function(data){
-        result = '';
+    var success = function(data) {
+        var result = '<h4>Strip executed</h4><ol>';
         $.each(data, function(index, value){
-             if(data[index]){
-                 result += '<h4>' +index+ '${_(' commit striped successful')}' + '</h4>';
+             if(data[index]) {
+                 result += '<li><code>' +index+ '</code> ${_(' commit striped successfully')}' + '</li>';
              }
-             else{
-                 result += '<h4>' +index+ '${_(' commit striped failed')}' + '</h4>';
+             else {
+                 result += '<li><code>' +index+ '</code> ${_(' commit strip failed')}' + '</li>';
              }
         });
+        if ($.isEmptyObject(data)) {
+            result += '<li>Nothing done...</li>'
+        }
+        result += '</ol>';
         $('#results').html(result);
 
     };
-    ajaxPOST(url, result_data, success, null);
-    var btn = $('button');
-    btn.attr('disabled', 'disabled');
-    btn.addClass('disabled');
+    ajaxPOST(url, resultData, success, null);
+    var btn = $('#strip_action');
+    btn.remove();
 
 };
 </script>

rhodecode/templates/admin/repos/repos.mako

@@ -10,7 +10,7 b''
 
 <%def name="breadcrumbs_links()">
     <input class="q_filter_box" id="q_filter" size="15" type="text" name="filter" placeholder="${_('quick filter...')}" value=""/>
-    ${h.link_to(_('Admin'),h.url('admin_home'))} &raquo; <span id="repo_count">0</span> ${_('repositories')}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))} &raquo; <span id="repo_count">0</span> ${_('repositories')}
 </%def>
 
 <%def name="menu_bar_nav()">

rhodecode/templates/admin/settings/settings.mako

@@ -9,7 +9,7 b''
 </%def>
 
 <%def name="breadcrumbs_links()">
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${_('Settings')}
 </%def>

rhodecode/templates/admin/settings/settings_email.mako

@@ -23,7 +23,7 b''
         <dl class="dl-horizontal settings">
         %for dt, dd, tt in elems:
           <dt >${dt}:</dt>
-          <dd  title="${tt}">${dd}</dd>
+          <dd  title="${h.tooltip(tt)}">${dd}</dd>
         %endfor
         </dl>
     </div>

rhodecode/templates/admin/settings/settings_sessions.mako

@@ -16,7 +16,7 b''
         <dl class="dl-horizontal settings">
         %for dt, dd, tt in elems:
           <dt>${dt}:</dt>
-          <dd title="${tt}">${dd}</dd>
+          <dd title="${h.tooltip(tt)}">${dd}</dd>
         %endfor
         </dl>
     </div>

rhodecode/templates/admin/settings/settings_system.mako

@@ -52,6 +52,6 b''
 <script>
     $('#check_for_update').click(function(e){
         $('#update_notice').show();
-        $('#update_notice').load("${h.route_path('admin_settings_system_update',version=c.rhodecode_version, platform=c.platform)}");
+        $('#update_notice').load("${h.route_path('admin_settings_system_update')}");
     })
 </script>

rhodecode/templates/admin/user_groups/user_group_add.mako

@@ -8,7 +8,7 b''
     %endif
 </%def>
 <%def name="breadcrumbs_links()">
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${h.link_to(_('User groups'),h.url('users_groups'))}
     &raquo;

rhodecode/templates/admin/user_groups/user_group_edit.mako

@@ -9,7 +9,7 b''
 </%def>
 
 <%def name="breadcrumbs_links()">
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${h.link_to(_('User Groups'),h.url('users_groups'))}
     &raquo;

rhodecode/templates/admin/user_groups/user_group_edit_advanced.mako

@@ -34,7 +34,6 b''
         % if sync_type:
             <p>
                 ${_('This group is set to be automatically synchronised.')}<br/>
-                ${_('Each member will be added or removed from this groups once they interact with RhodeCode system.')}<br/>
                 ${_('This group synchronization was set by')}: <strong>${sync_type}</strong>
             </p>
         % else:
@@ -56,11 +55,8 b''
             </div>
             <div class="field">
                 <span class="help-block">
-                    %if sync_type:
-                        ${_('User group will no longer synchronize membership')}
-                    %else:
-                        ${_('User group will start to synchronize membership')}
-                    %endif
+                    ${_('Users will be added or removed from this group when they authenticate with RhodeCode system, based on LDAP group membership. '
+                        'This requires `LDAP+User group` authentication plugin to be configured and enabled. (EE only feature)')}
                 </span>
             </div>
         ${h.end_form()}

rhodecode/templates/admin/user_groups/user_groups.mako

@@ -10,7 +10,7 b''
 
 <%def name="breadcrumbs_links()">
     <input class="q_filter_box" id="q_filter" size="15" type="text" name="filter" placeholder="${_('quick filter...')}" value=""/>
-    ${h.link_to(_('Admin'),h.url('admin_home'))} &raquo; <span id="user_group_count">0</span> ${_('user groups')}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))} &raquo; <span id="user_group_count">0</span> ${_('user groups')}
 </%def>
 
 <%def name="menu_bar_nav()">

rhodecode/templates/admin/users/user_add.mako

@@ -8,7 +8,7 b''
     %endif
 </%def>
 <%def name="breadcrumbs_links()">
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${h.link_to(_('Users'),h.route_path('users'))}
     &raquo;

rhodecode/templates/admin/users/user_edit.mako

@@ -9,11 +9,16 b''
 </%def>
 
 <%def name="breadcrumbs_links()">
-    ${h.link_to(_('Admin'),h.url('admin_home'))}
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))}
     &raquo;
     ${h.link_to(_('Users'),h.route_path('users'))}
     &raquo;
+    % if c.user.active:
     ${c.user.username}
+    % else:
+    <strike title="${_('This user is set as disabled')}">${c.user.username}</strike>
+    % endif
+
 </%def>
 
 <%def name="menu_bar_nav()">
@@ -35,8 +40,8 b''
           <li class="${'active' if c.active=='advanced' else ''}"><a href="${h.url('edit_user_advanced', user_id=c.user.user_id)}">${_('Advanced')}</a></li>
           <li class="${'active' if c.active=='global_perms' else ''}"><a href="${h.url('edit_user_global_perms', user_id=c.user.user_id)}">${_('Global permissions')}</a></li>
           <li class="${'active' if c.active=='perms_summary' else ''}"><a href="${h.url('edit_user_perms_summary', user_id=c.user.user_id)}">${_('Permissions summary')}</a></li>
-          <li class="${'active' if c.active=='emails' else ''}"><a href="${h.url('edit_user_emails', user_id=c.user.user_id)}">${_('Emails')}</a></li>
-          <li class="${'active' if c.active=='ips' else ''}"><a href="${h.url('edit_user_ips', user_id=c.user.user_id)}">${_('Ip Whitelist')}</a></li>
+          <li class="${'active' if c.active=='emails' else ''}"><a href="${h.route_path('edit_user_emails', user_id=c.user.user_id)}">${_('Emails')}</a></li>
+          <li class="${'active' if c.active=='ips' else ''}"><a href="${h.route_path('edit_user_ips', user_id=c.user.user_id)}">${_('Ip Whitelist')}</a></li>
           <li class="${'active' if c.active=='groups' else ''}"><a href="${h.route_path('edit_user_groups_management', user_id=c.user.user_id)}">${_('User Groups Management')}</a></li>
           <li class="${'active' if c.active=='audit' else ''}"><a href="${h.route_path('edit_user_audit_logs', user_id=c.user.user_id)}">${_('User audit')}</a></li>
         </ul>

rhodecode/templates/admin/users/user_edit_advanced.mako

@@ -59,7 +59,7 b''
         ${h.secure_form(h.url('create_personal_repo_group', user_id=c.user.user_id), method='post')}
 
         %if c.personal_repo_group:
-            <div class="panel-body-title-text">${_('Users personal repository group')} : ${h.link_to(c.personal_repo_group.group_name, url('repo_group_home', group_name=c.personal_repo_group.group_name))}</div>
+            <div class="panel-body-title-text">${_('Users personal repository group')} : ${h.link_to(c.personal_repo_group.group_name, h.route_path('repo_group_home', repo_group_name=c.personal_repo_group.group_name))}</div>
         %else:
             <div class="panel-body-title-text">
                 ${_('This user currently does not have a personal repository group')}

rhodecode/templates/admin/users/user_edit_audit.mako

@@ -5,7 +5,7 b''
 <div class="panel panel-default">
     <div class="panel-heading">
       <h3 class="panel-title">${_('User Audit Logs')} -
-      ${_ungettext('%s entry', '%s entries', c.user_log.item_count) % (c.user_log.item_count)}
+      ${_ungettext('%s entry', '%s entries', c.audit_logs.item_count) % (c.audit_logs.item_count)}
       </h3>
     </div>
     <div class="panel-body">
@@ -16,50 +16,7 b''
         ${h.end_form()}
         <p class="tooltip filterexample" style="position: inherit" title="${h.tooltip(h.journal_filter_help())}">${_('Example Queries')}</p>
 
-        % if c.user_log:
-            <table class="rctable admin_log">
-                <tr>
-                    <th>${_('Username')}</th>
-                    <th>${_('Action')}</th>
-                    <th>${_('Repository')}</th>
-                    <th>${_('Date')}</th>
-                    <th>${_('From IP')}</th>
-                </tr>
-
-                %for cnt,l in enumerate(c.user_log):
-                <tr class="parity${cnt%2}">
-                    <td class="td-user">
-                        %if l.user is not None:
-                          ${base.gravatar_with_user(l.user.email)}
-                        %else:
-                          ${l.username}
-                        %endif
-                    </td>
-                    <td class="td-journalaction">${h.action_parser(l)[0]()}
-                        <div class="journal_action_params">
-                            ${h.literal(h.action_parser(l)[1]())}
-                        </div>
-                    </td>
-                    <td class="td-componentname">
-                        %if l.repository is not None:
-                          ${h.link_to(l.repository.repo_name,h.url('summary_home',repo_name=l.repository.repo_name))}
-                        %else:
-                          ${l.repository_name}
-                        %endif
-                    </td>
-
-                    <td class="td-time">${h.format_date(l.action_date)}</td>
-                    <td class="td-ip">${l.user_ip}</td>
-                </tr>
-                %endfor
-            </table>
-
-            <div class="pagination-wh pagination-left">
-            ${c.user_log.pager('$link_previous ~2~ $link_next')}
-            </div>
-        % else:
-            ${_('No actions yet')}
-        % endif
+        <%include file="/admin/admin_log_base.mako" />
 
     </div>
 </div>

rhodecode/templates/admin/users/user_edit_auth_tokens.mako

@@ -38,10 +38,10 b''
                          %endif
                     </td>
                     <td class="td-action">
-                        ${h.secure_form(h.route_path('edit_user_auth_tokens_delete', user_id=c.user.user_id), method='post')}
-                            ${h.hidden('del_auth_token',auth_token.api_key)}
+                        ${h.secure_form(h.route_path('edit_user_auth_tokens_delete', user_id=c.user.user_id), method='POST')}
+                            ${h.hidden('del_auth_token', auth_token.user_api_key_id)}
                             <button class="btn btn-link btn-danger" type="submit"
-                                    onclick="return confirm('${_('Confirm to remove this auth token: %s') % auth_token.api_key}');">
+                                    onclick="return confirm('${_('Confirm to remove this auth token: %s') % auth_token.token_obfuscated}');">
                                 ${_('Delete')}
                             </button>
                         ${h.end_form()}
@@ -55,7 +55,7 b''
         </div>
 
         <div class="user_auth_tokens">
-            ${h.secure_form(h.route_path('edit_user_auth_tokens_add', user_id=c.user.user_id), method='post')}
+            ${h.secure_form(h.route_path('edit_user_auth_tokens_add', user_id=c.user.user_id), method='POST')}
             <div class="form form-vertical">
                 <!-- fields -->
                 <div class="fields">
@@ -136,7 +136,7 b' var repoFilter = function(data) {'
             query.callback({results: cachedData.results});
         } else {
             $.ajax({
-                url: "${h.url('repo_list_data')}",
+                url: pyroutes.url('repo_list_data'),
                 data: {'query': query.term},
                 dataType: 'json',
                 type: 'GET',

rhodecode/templates/admin/users/user_edit_emails.mako

@@ -24,8 +24,8 b''
                         <span class="user email">${em.email}</span>
                     </td>
                     <td class="td-action">
-                        ${h.secure_form(url('edit_user_emails', user_id=c.user.user_id),method='delete')}
-                            ${h.hidden('del_email_id',em.email_id)}
+                        ${h.secure_form(h.route_path('edit_user_emails_delete', user_id=c.user.user_id), method='POST')}
+                            ${h.hidden('del_email_id', em.email_id)}
                             <button class="btn btn-link btn-danger" type="submit"
                                     onclick="return confirm('${_('Confirm to delete this email: %s') % em.email}');">
                                 ${_('Delete')}
@@ -46,7 +46,7 b''
           </table>
         </div>
 
-        ${h.secure_form(url('edit_user_emails', user_id=c.user.user_id),method='put')}
+        ${h.secure_form(h.route_path('edit_user_emails_add', user_id=c.user.user_id), method='POST')}
         <div class="form">
             <!-- fields -->
             <div class="fields">

rhodecode/templates/admin/users/user_edit_ips.mako

@@ -4,11 +4,12 b''
     </div>
     <div class="panel-body">
         <div class="ips_wrap">
+        <h5>${_('Current IP address')}: <code>${c.rhodecode_user.ip_addr}</code></h5>
   <table class="rctable ip-whitelist">
     <tr>
-      <th>IP Address</th>
-      <th>IP Range</th>
-      <th>Description</th>
+      <th>${_('IP Address')}</th>
+      <th>${_('IP Range')}</th>
+      <th>${_('Description')}</th>
       <th></th>
     </tr>
     %if c.default_user_ip_map and c.inherit_default_ips:
@@ -29,9 +30,9 b''
             <td class="td-iprange"><div class="ip">${h.ip_range(ip.ip_addr)}</div></td>
             <td class="td-description"><div class="ip">${ip.description}</div></td>
             <td class="td-action">
-                ${h.secure_form(url('edit_user_ips', user_id=c.user.user_id),method='delete')}
-                    ${h.hidden('del_ip_id',ip.ip_id)}
-                    ${h.submit('remove_',_('Delete'),id="remove_ip_%s" % ip.ip_id,
+                ${h.secure_form(h.route_path('edit_user_ips_delete', user_id=c.user.user_id), method='POST')}
+                    ${h.hidden('del_ip_id', ip.ip_id)}
+                    ${h.submit('remove_', _('Delete'),id="remove_ip_%s" % ip.ip_id,
                     class_="btn btn-link btn-danger", onclick="return confirm('"+_('Confirm to delete this ip: %s') % ip.ip_addr+"');")}
                 ${h.end_form()}
             </td>
@@ -50,7 +51,7 b''
 </div>
 
         <div>
-    ${h.secure_form(url('edit_user_ips', user_id=c.user.user_id),method='put')}
+    ${h.secure_form(h.route_path('edit_user_ips_add', user_id=c.user.user_id), method='POST')}
     <div class="form">
         <!-- fields -->
         <div class="fields">

rhodecode/templates/admin/users/user_edit_profile.mako

@@ -127,7 +127,7 b''
                     ## allowed_languages is defined in the users.py
                     ## c.language comes from base.py as a default language
                     ${h.select('language', c.language, c.allowed_languages)}
-                    <p class="help-block">${h.literal(_('Help translate %(rc_link)s into your language.') % {'rc_link': h.link_to('RhodeCode Enterprise', h.url('rhodecode_translations'))})}</p>
+                    <p class="help-block">${h.literal(_('Help translate %(rc_link)s into your language.') % {'rc_link': h.link_to('RhodeCode Enterprise', h.route_url('rhodecode_translations'))})}</p>
                 </div>
             </div>
             <div class="buttons">

rhodecode/templates/admin/users/users.mako

@@ -10,7 +10,7 b''
 
 <%def name="breadcrumbs_links()">
     <input class="q_filter_box" id="q_filter" size="15" type="text" name="filter" placeholder="${_('quick filter...')}" value=""/>
-    ${h.link_to(_('Admin'),h.url('admin_home'))} &raquo; <span id="user_count">0</span>
+    ${h.link_to(_('Admin'),h.route_path('admin_home'))} &raquo; <span id="user_count">0</span>
 </%def>
 
 <%def name="menu_bar_nav()">
@@ -38,9 +38,10 b''
 <script type="text/javascript">
 
 $(document).ready(function() {
+    var $userListTable = $('#user_list_table');
 
     var getDatatableCount = function(){
-      var table = $('#user_list_table').dataTable();
+      var table = $userListTable.dataTable();
       var page = table.api().page.info();
       var  active = page.recordsDisplay;
       var  total = page.recordsTotal;
@@ -50,7 +51,7 b''
     };
 
     // user list
-    $('#user_list_table').DataTable({
+    $userListTable.DataTable({
       processing: true,
       serverSide: true,
       ajax: "${h.route_path('users_data')}",
@@ -76,7 +77,7 b''
          { data: {"_": "extern_type",
                   "sort": "extern_type"}, title: "${_('Auth type')}", className: "td-type"  },
          { data: {"_": "action",
-                  "sort": "action"}, title: "${_('Action')}", className: "td-action" }
+                  "sort": "action"}, title: "${_('Action')}", className: "td-action", orderable: false }
       ],
       language: {
           paginate: DEFAULT_GRID_PAGINATION,
@@ -91,23 +92,23 b''
       }
     });
 
-    $('#user_list_table').on('xhr.dt', function(e, settings, json, xhr){
-        $('#user_list_table').css('opacity', 1);
+    $userListTable.on('xhr.dt', function(e, settings, json, xhr){
+        $userListTable.css('opacity', 1);
     });
 
-    $('#user_list_table').on('preXhr.dt', function(e, settings, data){
-        $('#user_list_table').css('opacity', 0.3);
+    $userListTable.on('preXhr.dt', function(e, settings, data){
+        $userListTable.css('opacity', 0.3);
     });
 
     // refresh counters on draw
-    $('#user_list_table').on('draw.dt', function(){
+    $userListTable.on('draw.dt', function(){
         getDatatableCount();
     });
 
     // filter
     $('#q_filter').on('keyup',
         $.debounce(250, function() {
-            $('#user_list_table').DataTable().search(
+            $userListTable.DataTable().search(
                 $('#q_filter').val()
             ).draw();
         })

rhodecode/templates/base/base.mako

@@ -7,7 +7,7 b''
       <div id="header-inner" class="wrapper">
           <div id="logo">
               <div class="logo-wrapper">
-                  <a href="${h.url('home')}"><img src="${h.asset('images/rhodecode-logo-white-216x60.png')}" alt="RhodeCode"/></a>
+                  <a href="${h.route_path('home')}"><img src="${h.asset('images/rhodecode-logo-white-216x60.png')}" alt="RhodeCode"/></a>
               </div>
               %if c.rhodecode_name:
                <div class="branding">- ${h.branding(c.rhodecode_name)}</div>
@@ -41,7 +41,7 b''
                % if c.visual.show_version:
                    RhodeCode Enterprise ${c.rhodecode_version} ${c.rhodecode_edition}
                % endif
-               &copy; 2010-${h.datetime.today().year}, <a href="${h.url('rhodecode_official')}" target="_blank">RhodeCode GmbH</a>. All rights reserved.
+               &copy; 2010-${h.datetime.today().year}, <a href="${h.route_url('rhodecode_official')}" target="_blank">RhodeCode GmbH</a>. All rights reserved.
                % if c.visual.rhodecode_support_url:
                   <a href="${c.visual.rhodecode_support_url}" target="_blank">${_('Support')}</a>
                % endif
@@ -72,7 +72,7 b''
 
 <%def name="admin_menu()">
   <ul class="admin_menu submenu">
-      <li><a href="${h.url('admin_home')}">${_('Admin journal')}</a></li>
+      <li><a href="${h.route_path('admin_audit_logs')}">${_('Admin audit logs')}</a></li>
       <li><a href="${h.url('repos')}">${_('Repositories')}</a></li>
       <li><a href="${h.url('repo_groups')}">${_('Repository groups')}</a></li>
       <li><a href="${h.route_path('users')}">${_('Users')}</a></li>
@@ -90,7 +90,7 b''
     <dl class="dl-horizontal">
     %for dt, dd, title, show_items in elements:
       <dt>${dt}:</dt>
-      <dd title="${title}">
+      <dd title="${h.tooltip(title)}">
       %if callable(dd):
           ## allow lazy evaluation of elements
           ${dd()}
@@ -134,7 +134,7 b''
 
 <%def name="gravatar_with_user(contact, size=16, show_disabled=False)">
   <% email = h.email_or_none(contact) %>
-  <div class="rc-user tooltip" title="${h.author_string(email)}">
+  <div class="rc-user tooltip" title="${h.tooltip(h.author_string(email))}">
     ${self.gravatar(email, size)}
     <span class="${'user user-disabled' if show_disabled else 'user'}"> ${h.link_to_user(contact)}</span>
   </div>
@@ -186,7 +186,7 b''
     %if repo_instance.fork:
     <p>
         <i class="icon-code-fork"></i> ${_('Fork of')}
-        <a href="${h.url('summary_home',repo_name=repo_instance.fork.repo_name)}">${repo_instance.fork.repo_name}</a>
+        <a href="${h.route_path('repo_summary',repo_name=repo_instance.fork.repo_name)}">${repo_instance.fork.repo_name}</a>
     </p>
     %endif
 
@@ -225,7 +225,7 b''
   <div id="context-bar">
     <div class="wrapper">
       <ul id="context-pages" class="horizontal-list navigation">
-        <li class="${is_active('summary')}"><a class="menulink" href="${h.url('summary_home', repo_name=c.repo_name)}"><div class="menulabel">${_('Summary')}</div></a></li>
+        <li class="${is_active('summary')}"><a class="menulink" href="${h.route_path('repo_summary', repo_name=c.repo_name)}"><div class="menulabel">${_('Summary')}</div></a></li>
         <li class="${is_active('changelog')}"><a class="menulink" href="${h.url('changelog_home', repo_name=c.repo_name)}"><div class="menulabel">${_('Changelog')}</div></a></li>
         <li class="${is_active('files')}"><a class="menulink" href="${h.url('files_home', repo_name=c.repo_name, revision=c.rhodecode_db_repo.landing_rev[1])}"><div class="menulabel">${_('Files')}</div></a></li>
         <li class="${is_active('compare')}">
@@ -234,7 +234,7 b''
         ## TODO: anderson: ideally it would have a function on the scm_instance "enable_pullrequest() and enable_fork()"
         %if c.rhodecode_db_repo.repo_type in ['git','hg']:
           <li class="${is_active('showpullrequest')}">
-            <a class="menulink" href="${h.url('pullrequest_show_all',repo_name=c.repo_name)}" title="${_('Show Pull Requests for %s') % c.repo_name}">
+            <a class="menulink" href="${h.route_path('pullrequest_show_all', repo_name=c.repo_name)}" title="${h.tooltip(_('Show Pull Requests for %s') % c.repo_name)}">
               %if c.repository_pull_requests:
                 <span class="pr_notifications">${c.repository_pull_requests}</span>
               %endif
@@ -243,17 +243,19 b''
           </li>
         %endif
         <li class="${is_active('options')}">
-          <a class="menulink" href="#" class="dropdown"><div class="menulabel">${_('Options')} <div class="show_more"></div></div></a>
+          <a class="menulink dropdown">
+              <div class="menulabel">${_('Options')} <div class="show_more"></div></div>
+          </a>
           <ul class="submenu">
              %if h.HasRepoPermissionAll('repository.admin')(c.repo_name):
-                   <li><a href="${h.url('edit_repo',repo_name=c.repo_name)}">${_('Settings')}</a></li>
+                   <li><a href="${h.route_path('edit_repo',repo_name=c.repo_name)}">${_('Settings')}</a></li>
              %endif
               %if c.rhodecode_db_repo.fork:
                <li><a href="${h.url('compare_url',repo_name=c.rhodecode_db_repo.fork.repo_name,source_ref_type=c.rhodecode_db_repo.landing_rev[0],source_ref=c.rhodecode_db_repo.landing_rev[1], target_repo=c.repo_name,target_ref_type='branch' if request.GET.get('branch') else c.rhodecode_db_repo.landing_rev[0],target_ref=request.GET.get('branch') or c.rhodecode_db_repo.landing_rev[1], merge=1)}">
                    ${_('Compare fork')}</a></li>
               %endif
 
-              <li><a href="${h.url('search_repo_home',repo_name=c.repo_name)}">${_('Search')}</a></li>
+              <li><a href="${h.route_path('search_repo',repo_name=c.repo_name)}">${_('Search')}</a></li>
 
               %if h.HasRepoPermissionAny('repository.write','repository.admin')(c.repo_name) and c.rhodecode_db_repo.enable_locking:
                 %if c.rhodecode_db_repo.locked[0]:
@@ -322,8 +324,9 b''
                     <div class="buttons">
                         <div class="register">
                         %if h.HasPermissionAny('hg.admin', 'hg.register.auto_activate', 'hg.register.manual_activate')():
-                         ${h.link_to(_("Don't have an account ?"),h.route_path('register'))}
+                         ${h.link_to(_("Don't have an account?"),h.route_path('register'))} <br/>
                         %endif
+                        ${h.link_to(_("Using external auth? Sign In here."),h.route_path('login'))}
                         </div>
                         <div class="submit">
                             ${h.submit('sign_in',_('Sign In'),class_="btn btn-small",tabindex=3)}
@@ -342,7 +345,7 b''
             <ol class="links">
               <li>${h.link_to(_(u'My account'),h.route_path('my_account_profile'))}</li>
               % if c.rhodecode_user.personal_repo_group:
-                <li>${h.link_to(_(u'My personal group'), h.url('repo_group_home', group_name=c.rhodecode_user.personal_repo_group.group_name))}</li>
+                <li>${h.link_to(_(u'My personal group'), h.route_path('repo_group_home', repo_group_name=c.rhodecode_user.personal_repo_group.group_name))}</li>
               % endif
               <li class="logout">
               ${h.secure_form(h.route_path('logout'))}
@@ -399,7 +402,7 b''
           </a>
         </li>
       <li class="${is_active('search')}">
-          <a class="menulink" title="${_('Search in repositories you have access to')}" href="${h.url('search')}">
+          <a class="menulink" title="${_('Search in repositories you have access to')}" href="${h.route_path('search')}">
             <div class="menulabel">${_('Search')}</div>
           </a>
       </li>
@@ -503,7 +506,7 b''
                     query.callback({results: cachedData.results});
                 } else {
                     $.ajax({
-                        url: "${h.url('goto_switcher_data')}",
+                        url: pyroutes.url('goto_switcher_data'),
                         data: {'query': query.term},
                         dataType: 'json',
                         type: 'GET',

rhodecode/templates/base/issue_tracker_settings.mako

@@ -18,7 +18,7 b''
           <td class="td-regex issue-tracker-example">${'(?:#)(?P<issue_id>\d+)'}</td>
           <td class="td-url issue-tracker-example">${'https://myissueserver.com/${repo}/issue/${issue_id}'}</td>
           <td class="td-prefix issue-tracker-example">#</td>
-          <td class="issue-tracker-example"><a href="https://docs.rhodecode.com/RhodeCode-Enterprise/issue-trackers/issue-trackers.html" target="_blank">${_('Read more')}</a></td>
+          <td class="issue-tracker-example"><a href="${h.route_url('enterprise_issue_tracker_settings')}" target="_blank">${_('Read more')}</a></td>
       </tr>
       %for uid, entry in patterns:
         <tr id="entry_${uid}">

rhodecode/templates/base/perms_summary.mako

@@ -124,9 +124,9 b''
                 <tr class="perm_row ${'%s_%s' % (section, section_perm.split('.')[-1])}">
                     <td class="td-componentname">
                         %if section == 'repositories':
-                            <a href="${h.url('summary_home',repo_name=k)}">${k}</a>
+                            <a href="${h.route_path('repo_summary',repo_name=k)}">${k}</a>
                         %elif section == 'repositories_groups':
-                            <a href="${h.url('repo_group_home',group_name=k)}">${k}</a>
+                            <a href="${h.route_path('repo_group_home', repo_group_name=k)}">${k}</a>
                         %elif section == 'user_groups':
                             ##<a href="${h.url('edit_users_group',user_group_id=k)}">${k}</a>
                             ${k}
@@ -146,7 +146,7 b''
                     %if actions:
                     <td class="td-action">
                         %if section == 'repositories':
-                            <a href="${h.url('edit_repo_perms',repo_name=k,anchor='permissions_manage')}">${_('edit')}</a>
+                            <a href="${h.route_path('edit_repo_perms',repo_name=k,anchor='permissions_manage')}">${_('edit')}</a>
                         %elif section == 'repositories_groups':
                             <a href="${h.url('edit_repo_group_perms',group_name=k,anchor='permissions_manage')}">${_('edit')}</a>
                         %elif section == 'user_groups':

rhodecode/templates/base/root.mako

@@ -12,10 +12,15 b" if getattr(c, 'rhodecode_user', None) an"
     c.template_context['rhodecode_user']['username'] = c.rhodecode_user.username
     c.template_context['rhodecode_user']['email'] = c.rhodecode_user.email
     c.template_context['rhodecode_user']['notification_status'] = c.rhodecode_user.get_instance().user_data.get('notification_status', True)
-    c.template_context['rhodecode_user']['first_name'] = c.rhodecode_user.name
-    c.template_context['rhodecode_user']['last_name'] = c.rhodecode_user.lastname
+    c.template_context['rhodecode_user']['first_name'] = c.rhodecode_user.first_name
+    c.template_context['rhodecode_user']['last_name'] = c.rhodecode_user.last_name
 
 c.template_context['visual']['default_renderer'] = h.get_visual_attr(c, 'default_renderer')
+c.template_context['default_user'] = {
+    'username': h.DEFAULT_USER,
+    'user_id': 1
+}
+
 %>
 <html xmlns="http://www.w3.org/1999/xhtml">
     <head>
@@ -79,7 +84,7 b" c.template_context['visual']['default_re"
             // register templateContext to pass template variables to JS
             var templateContext = ${h.json.dumps(c.template_context)|n};
 
-            var APPLICATION_URL = "${h.url('home').rstrip('/')}";
+            var APPLICATION_URL = "${h.route_path('home').rstrip('/')}";
             var ASSET_URL = "${h.asset('')}";
             var DEFAULT_RENDERER = "${h.get_visual_attr(c, 'default_renderer')}";
             var CSRF_TOKEN = "${getattr(c, 'csrf_token', '')}";

rhodecode/templates/base/vcs_settings.mako

@@ -130,6 +130,19 b''
                         <span class="help-block">${_('Requires hgsubversion library to be installed. Allows cloning remote SVN repositories and migrates them to Mercurial type.')}</span>
                     </div>
                 % endif
+
+                <div class="checkbox">
+                    ${h.checkbox('extensions_evolve' + suffix, 'True', **kwargs)}
+                    <label for="extensions_evolve${suffix}">${_('Enable evolve extension')}</label>
+                </div>
+                <div class="label">
+                    % if display_globals:
+                        <span class="help-block">${_('Enable evolve extension for all repositories.')}</span>
+                    % else:
+                        <span class="help-block">${_('Enable evolve extension for this repository.')}</span>
+                    % endif
+                </div>
+
             </div>
         </div>
         ## LABS for HG
@@ -201,7 +214,7 b''
                     <div class="label">
                         <span class="help-block">
                             ${_('Subversion HTTP Support. Enables communication with SVN over HTTP protocol.')}
-                            <a href="${h.url('enterprise_svn_setup')}" target="_blank">${_('SVN Protocol setup Documentation')}</a>.
+                            <a href="${h.route_url('enterprise_svn_setup')}" target="_blank">${_('SVN Protocol setup Documentation')}</a>.
                         </span>
                     </div>
                 </div>

rhodecode/templates/bookmarks/bookmarks_data.mako

@@ -10,7 +10,7 b''
 
 
 <%def name="name(name, files_url)">
-     <span class="tag booktag" title="${_('Bookmark %s') % (name,)}">
+     <span class="tag booktag" title="${h.tooltip(_('Bookmark %s') % (name,))}">
      <a href="${files_url}">
          <i class="icon-bookmark"></i>
          ${name}
@@ -23,11 +23,11 b''
 </%def>
 
 <%def name="author(author)">
-    <span class="tooltip" title="${author}">${h.link_to_user(author)}</span>
+    <span class="tooltip" title="${h.tooltip(author)}">${h.link_to_user(author)}</span>
 </%def>
 
 <%def name="commit(message, commit_id, commit_idx)">
     <div>
-        <pre><a title="${message}" href="${h.url('files_home',repo_name=c.repo_name,revision=commit_id)}">r${commit_idx}:${h.short_id(commit_id)}</a></pre>
+        <pre><a title="${h.tooltip(message)}" href="${h.url('files_home',repo_name=c.repo_name,revision=commit_id)}">r${commit_idx}:${h.short_id(commit_id)}</a></pre>
     </div>
 </%def>

rhodecode/templates/branches/branches_data.mako

@@ -9,7 +9,7 b''
 </%def>
 
 <%def name="name(name, files_url)">
-     <span class="tag branchtag" title="${_('Branch %s') % (name,)}">
+     <span class="tag branchtag" title="${h.tooltip(_('Branch %s') % (name,))}">
      <a href="${files_url}"><i class="icon-code-fork"></i>${name}
         %if name in c.closed_branches:
             [closed]
@@ -23,11 +23,11 b''
 </%def>
 
 <%def name="author(author)">
-    <span class="tooltip" title="${author}">${h.link_to_user(author)}</span>
+    <span class="tooltip" title="${h.tooltip(author)}">${h.link_to_user(author)}</span>
 </%def>
 
 <%def name="commit(message, commit_id, commit_idx)">
     <div>
-        <pre><a title="${message}" href="${h.url('files_home',repo_name=c.repo_name,revision=commit_id)}">r${commit_idx}:${h.short_id(commit_id)}</a></pre>
+        <pre><a title="${h.tooltip(message)}" href="${h.url('files_home',repo_name=c.repo_name,revision=commit_id)}">r${commit_idx}:${h.short_id(commit_id)}</a></pre>
     </div>
 </%def>

rhodecode/templates/changelog/changelog.mako

@@ -37,7 +37,7 b''
                 %if c.rhodecode_db_repo.fork:
                     <span>
                         <a  id="compare_fork_button"
-                            title="${_('Compare fork with %s' % c.rhodecode_db_repo.fork.repo_name)}"
+                            title="${h.tooltip(_('Compare fork with %s' % c.rhodecode_db_repo.fork.repo_name))}"
                             class="btn btn-small"
                             href="${h.url('compare_url',
                                 repo_name=c.rhodecode_db_repo.fork.repo_name,

rhodecode/templates/changelog/changelog_elements.mako

@@ -23,7 +23,7 b''
     %if c.statuses.get(commit.raw_id):
       <div class="changeset-status-ico">
         %if c.statuses.get(commit.raw_id)[2]:
-          <a class="tooltip" title="${_('Commit status: %s\nClick to open associated pull request #%s') % (h.commit_status_lbl(c.statuses.get(commit.raw_id)[0]), c.statuses.get(commit.raw_id)[2])}" href="${h.url('pullrequest_show',repo_name=c.statuses.get(commit.raw_id)[3],pull_request_id=c.statuses.get(commit.raw_id)[2])}">
+          <a class="tooltip" title="${_('Commit status: %s\nClick to open associated pull request #%s') % (h.commit_status_lbl(c.statuses.get(commit.raw_id)[0]), c.statuses.get(commit.raw_id)[2])}" href="${h.route_path('pullrequest_show',repo_name=c.statuses.get(commit.raw_id)[3],pull_request_id=c.statuses.get(commit.raw_id)[2])}">
             <div class="${'flag_status %s' % c.statuses.get(commit.raw_id)[0]}"></div>
           </a>
         %else:
@@ -46,8 +46,28 b''
     <td class="td-hash">
     <code>
       <a href="${h.url('changeset_home',repo_name=c.repo_name,revision=commit.raw_id)}">
-        <span class="commit_hash">${h.show_id(commit)}</span>
+        <span class="${'commit_hash obsolete' if getattr(commit, 'obsolete', None) else 'commit_hash'}">${h.show_id(commit)}</span>
       </a>
+      % if hasattr(commit, 'phase'):
+          % if commit.phase != 'public':
+              <span class="tag phase-${commit.phase} tooltip" title="${_('Commit phase')}">${commit.phase}</span>
+          % endif
+      % endif
+
+      ## obsolete commits
+      % if hasattr(commit, 'obsolete'):
+          % if commit.obsolete:
+              <span class="tag obsolete-${commit.obsolete} tooltip" title="${_('Evolve State')}">${_('obsolete')}</span>
+          % endif
+      % endif
+
+      ## hidden commits
+      % if hasattr(commit, 'hidden'):
+          % if commit.hidden:
+              <span class="tag obsolete-${commit.hidden} tooltip" title="${_('Evolve State')}">${_('hidden')}</span>
+          % endif
+      % endif
+
     </code>
     </td>
     <td class="td-message expand_commit" data-commit-id="${commit.raw_id}" title="${_('Expand commit message')}" onclick="commitsController.expandCommit(this); return false">
@@ -80,7 +100,7 b''
 
         ## branch
         %if commit.branch:
-          <span class="tag branchtag" title="${_('Branch %s') % commit.branch}">
+          <span class="tag branchtag" title="${h.tooltip(_('Branch %s') % commit.branch)}">
              <a href="${h.url('changelog_home',repo_name=c.repo_name,branch=commit.branch)}"><i class="icon-code-fork"></i>${h.shorter(commit.branch)}</a>
           </span>
         %endif
@@ -88,7 +108,7 b''
         ## bookmarks
         %if h.is_hg(c.rhodecode_repo):
             %for book in commit.bookmarks:
-                <span class="tag booktag" title="${_('Bookmark %s') % book}">
+                <span class="tag booktag" title="${h.tooltip(_('Bookmark %s') % book)}">
                   <a href="${h.url('files_home',repo_name=c.repo_name,revision=commit.raw_id)}"><i class="icon-bookmark"></i>${h.shorter(book)}</a>
                 </span>
             %endfor
@@ -96,7 +116,7 b''
 
         ## tags
         %for tag in commit.tags:
-          <span class="tag tagtag"  title="${_('Tag %s') % tag}">
+          <span class="tag tagtag"  title="${h.tooltip(_('Tag %s') % tag)}">
             <a href="${h.url('files_home',repo_name=c.repo_name,revision=commit.raw_id)}"><i class="icon-tag"></i>${h.shorter(tag)}</a>
           </span>
         %endfor

rhodecode/templates/changelog/changelog_file_history.mako

@@ -14,7 +14,7 b''
             </td>
             <td class="td-message">
                 <div class="log-container">
-                    <div class="message_history" title="${cs.message}">
+                    <div class="message_history" title="${h.tooltip(cs.message)}">
                         <a href="${h.url('changeset_home',repo_name=c.repo_name,revision=cs.raw_id)}">
                             ${h.shorter(cs.message, 75)}
                         </a>

rhodecode/templates/changeset/changeset.mako

@@ -36,16 +36,36 b''
             <h4>${_('Commit')}
               <code>
                 ${h.show_id(c.commit)}
+                % if hasattr(c.commit, 'phase'):
+                      <span class="tag phase-${c.commit.phase} tooltip" title="${_('Commit phase')}">${c.commit.phase}</span>
+                % endif
+
+                ## obsolete commits
+                % if hasattr(c.commit, 'obsolete'):
+                  % if c.commit.obsolete:
+                      <span class="tag obsolete-${c.commit.obsolete} tooltip" title="${_('Evolve State')}">${_('obsolete')}</span>
+                  % endif
+                % endif
+
+                ## hidden commits
+                % if hasattr(c.commit, 'hidden'):
+                  % if c.commit.hidden:
+                      <span class="tag hidden-${c.commit.hidden} tooltip" title="${_('Evolve State')}">${_('hidden')}</span>
+                  % endif
+                % endif
+
               </code>
             </h4>
           </span>
-          <span id="parent_link">
-            <a href="#" title="${_('Parent Commit')}">${_('Parent')}</a>
-          </span>
-           |
-          <span id="child_link">
-            <a href="#" title="${_('Child Commit')}">${_('Child')}</a>
-          </span>
+          <div class="pull-right">
+              <span id="parent_link">
+                <a href="#" title="${_('Parent Commit')}">${_('Parent')}</a>
+              </span>
+               |
+              <span id="child_link">
+                <a href="#" title="${_('Child Commit')}">${_('Child')}</a>
+              </span>
+          </div>
       </div>
 
       <div class="fieldset">
@@ -89,20 +109,20 b''
 
             %if h.is_hg(c.rhodecode_repo):
               %for book in c.commit.bookmarks:
-              <span class="booktag tag" title="${_('Bookmark %s') % book}">
+              <span class="booktag tag" title="${h.tooltip(_('Bookmark %s') % book)}">
                 <a href="${h.url('files_home',repo_name=c.repo_name,revision=c.commit.raw_id)}"><i class="icon-bookmark"></i>${h.shorter(book)}</a>
               </span>
               %endfor
             %endif
 
             %for tag in c.commit.tags:
-             <span class="tagtag tag"  title="${_('Tag %s') % tag}">
+             <span class="tagtag tag"  title="${h.tooltip(_('Tag %s') % tag)}">
               <a href="${h.url('files_home',repo_name=c.repo_name,revision=c.commit.raw_id)}"><i class="icon-tag"></i>${tag}</a>
              </span>
             %endfor
 
             %if c.commit.branch:
-              <span class="branchtag tag" title="${_('Branch %s') % c.commit.branch}">
+              <span class="branchtag tag" title="${h.tooltip(_('Branch %s') % c.commit.branch)}">
                 <a href="${h.url('files_home',repo_name=c.repo_name,revision=c.commit.raw_id)}"><i class="icon-code-fork"></i>${h.shorter(c.commit.branch)}</a>
               </span>
             %endif

rhodecode/templates/changeset/changeset_comment_block.mako

@@ -1,4 +1,4 b''
 ## this is a dummy html file for partial rendering on server and sending
 ## generated output via ajax after comment submit
 <%namespace name="comment" file="/changeset/changeset_file_comment.mako"/>
-${comment.comment_block(c.co, inline=c.inline_comment)}
+${comment.comment_block(c.co, inline=c.co.is_inline)}

rhodecode/templates/changeset/changeset_file_comment.mako

@@ -61,7 +61,7 b''
           % else:
               <div class="status-change">
                   % if comment.pull_request:
-                      <a href="${h.url('pullrequest_show',repo_name=comment.pull_request.target_repo.repo_name,pull_request_id=comment.pull_request.pull_request_id)}">
+                      <a href="${h.route_path('pullrequest_show',repo_name=comment.pull_request.target_repo.repo_name,pull_request_id=comment.pull_request.pull_request_id)}">
                           % if comment.status_change:
                               ${_('pull request #%s') % comment.pull_request.pull_request_id}:
                           % else:
@@ -92,7 +92,12 b''
           <a class="permalink" href="#comment-${comment.comment_id}"> &para;</a>
 
           <div class="comment-links-block">
-
+              % if comment.pull_request and comment.pull_request.author.user_id == comment.author.user_id:
+                <span class="tag authortag tooltip" title="${_('Pull request author')}">
+                ${_('author')}
+                </span>
+                |
+              % endif
             % if inline:
                   <div class="pr-version-inline">
                     <a href="${h.url.current(version=comment.pull_request_version_id, anchor='comment-{}'.format(comment.comment_id))}">
@@ -117,7 +122,7 b''
                         </a>
                       % else:
                         <div title="${_('Comment from pull request version {0}').format(pr_index_ver)}">
-                            <a href="${h.url('pullrequest_show',repo_name=comment.pull_request.target_repo.repo_name,pull_request_id=comment.pull_request.pull_request_id, version=comment.pull_request_version_id)}">
+                            <a href="${h.route_path('pullrequest_show',repo_name=comment.pull_request.target_repo.repo_name,pull_request_id=comment.pull_request.pull_request_id, version=comment.pull_request_version_id)}">
                             <code class="pr-version-num">
                                 ${'v{}'.format(pr_index_ver)}
                             </code>
@@ -153,7 +158,7 b''
           </div>
       </div>
       <div class="text">
-          ${comment.render(mentions=True)|n}
+          ${h.render(comment.text, renderer=comment.renderer, mentions=True)}
       </div>
 
   </div>
@@ -341,7 +346,7 b''
             <div class="toolbar">
                 <div class="toolbar-text">
                   ${(_('Comments parsed using %s syntax with %s, and %s actions support.') % (
-                           ('<a href="%s">%s</a>' % (h.url('%s_help' % c.visual.default_renderer), c.visual.default_renderer.upper())),
+                           ('<a href="%s">%s</a>' % (h.route_url('%s_help' % c.visual.default_renderer), c.visual.default_renderer.upper())),
                            ('<span class="tooltip" title="%s">@mention</span>' % _('Use @username inside this text to send notification to this RhodeCode user')),
                            ('<span class="tooltip" title="%s">`/`</span>' % _('Start typing with / for certain actions to be triggered via text box.'))
                        )

rhodecode/templates/codeblocks/diffs.mako

@@ -114,7 +114,7 b' collapse_all = len(diffset.files) > coll'
     <div class="diffset-heading ${diffset.limited_diff and 'diffset-heading-warning' or ''}">
         %if commit:
             <div class="pull-right">
-                <a class="btn tooltip" title="${_('Browse Files at revision {}').format(commit.raw_id)}" href="${h.url('files_home',repo_name=diffset.repo_name, revision=commit.raw_id, f_path='')}">
+                <a class="btn tooltip" title="${h.tooltip(_('Browse Files at revision {}').format(commit.raw_id))}" href="${h.url('files_home',repo_name=diffset.repo_name, revision=commit.raw_id, f_path='')}">
                     ${_('Browse Files')}
                 </a>
             </div>
@@ -147,14 +147,14 b' collapse_all = len(diffset.files) > coll'
     %for i, filediff in enumerate(diffset.files):
 
         <%
-        lines_changed = filediff['patch']['stats']['added'] + filediff['patch']['stats']['deleted']
+        lines_changed = filediff.patch['stats']['added'] + filediff.patch['stats']['deleted']
         over_lines_changed_limit = lines_changed > lines_changed_limit
         %>
         <input ${collapse_all and 'checked' or ''} class="filediff-collapse-state" id="filediff-collapse-${id(filediff)}" type="checkbox">
         <div
             class="filediff"
-            data-f-path="${filediff['patch']['filename']}"
-            id="a_${h.FID('', filediff['patch']['filename'])}">
+            data-f-path="${filediff.patch['filename']}"
+            id="a_${h.FID('', filediff.patch['filename'])}">
             <label for="filediff-collapse-${id(filediff)}" class="filediff-heading">
                 <div class="filediff-collapse-indicator"></div>
                 ${diff_ops(filediff)}
@@ -162,7 +162,7 b' collapse_all = len(diffset.files) > coll'
             ${diff_menu(filediff, use_comments=use_comments)}
             <table class="cb cb-diff-${c.diffmode} code-highlight ${over_lines_changed_limit and 'cb-collapsed' or ''}">
         %if not filediff.hunks:
-            %for op_id, op_text in filediff['patch']['stats']['ops'].items():
+            %for op_id, op_text in filediff.patch['stats']['ops'].items():
                 <tr>
                     <td class="cb-text cb-${op_class(op_id)}" ${c.diffmode == 'unified' and 'colspan=4' or 'colspan=6'}>
                         %if op_id == DEL_FILENODE:
@@ -176,7 +176,7 b' collapse_all = len(diffset.files) > coll'
                 </tr>
             %endfor
         %endif
-        %if filediff.patch['is_limited_diff']:
+        %if filediff.limited_diff:
                 <tr class="cb-warning cb-collapser">
                     <td class="cb-text" ${c.diffmode == 'unified' and 'colspan=4' or 'colspan=6'}>
                         ${_('The requested commit is too big and content was truncated.')} <a href="${link_for(fulldiff=1)}" onclick="return confirm('${_("Showing a big diff might take some time and resources, continue?")}')">${_('Show full diff')}</a>
@@ -322,7 +322,6 b' collapse_all = len(diffset.files) > coll'
 
 <%def name="diff_ops(filediff)">
 <%
-stats = filediff['patch']['stats']
 from rhodecode.lib.diffs import NEW_FILENODE, DEL_FILENODE, \
     MOD_FILENODE, RENAMED_FILENODE, CHMOD_FILENODE, BIN_FILENODE, COPIED_FILENODE
 %>
@@ -330,9 +329,9 b' from rhodecode.lib.diffs import NEW_FILE'
         %if filediff.source_file_path and filediff.target_file_path:
             %if filediff.source_file_path != filediff.target_file_path:
                  ## file was renamed, or copied
-                %if RENAMED_FILENODE in stats['ops']:
+                %if RENAMED_FILENODE in filediff.patch['stats']['ops']:
                     <strong>${filediff.target_file_path}</strong> ⬅ <del>${filediff.source_file_path}</del>
-                %elif COPIED_FILENODE in stats['ops']:
+                %elif COPIED_FILENODE in filediff.patch['stats']['ops']:
                     <strong>${filediff.target_file_path}</strong> ⬅ ${filediff.source_file_path}
                 %endif
             %else:
@@ -350,19 +349,19 b' from rhodecode.lib.diffs import NEW_FILE'
         %endif
     </span>
     <span class="pill-group" style="float: left">
-        %if filediff.patch['is_limited_diff']:
+        %if filediff.limited_diff:
         <span class="pill tooltip" op="limited" title="The stats for this diff are not complete">limited diff</span>
         %endif
 
-        %if RENAMED_FILENODE in stats['ops']:
+        %if RENAMED_FILENODE in filediff.patch['stats']['ops']:
         <span class="pill" op="renamed">renamed</span>
         %endif
 
-        %if COPIED_FILENODE in stats['ops']:
+        %if COPIED_FILENODE in filediff.patch['stats']['ops']:
         <span class="pill" op="copied">copied</span>
         %endif
 
-        %if NEW_FILENODE in stats['ops']:
+        %if NEW_FILENODE in filediff.patch['stats']['ops']:
         <span class="pill" op="created">created</span>
             %if filediff['target_mode'].startswith('120'):
         <span class="pill" op="symlink">symlink</span>
@@ -371,11 +370,11 b' from rhodecode.lib.diffs import NEW_FILE'
             %endif
         %endif
 
-        %if DEL_FILENODE in stats['ops']:
+        %if DEL_FILENODE in filediff.patch['stats']['ops']:
         <span class="pill" op="removed">removed</span>
         %endif
 
-        %if CHMOD_FILENODE in stats['ops']:
+        %if CHMOD_FILENODE in filediff.patch['stats']['ops']:
         <span class="pill" op="mode">
             ${nice_mode(filediff['source_mode'])} ➡ ${nice_mode(filediff['target_mode'])}
         </span>
@@ -385,17 +384,17 b' from rhodecode.lib.diffs import NEW_FILE'
     <a class="pill filediff-anchor" href="#a_${h.FID('', filediff.patch['filename'])}">¶</a>
 
     <span class="pill-group" style="float: right">
-        %if BIN_FILENODE in stats['ops']:
+        %if BIN_FILENODE in filediff.patch['stats']['ops']:
         <span class="pill" op="binary">binary</span>
-            %if MOD_FILENODE in stats['ops']:
+            %if MOD_FILENODE in filediff.patch['stats']['ops']:
             <span class="pill" op="modified">modified</span>
             %endif
         %endif
-        %if stats['added']:
-        <span class="pill" op="added">+${stats['added']}</span>
+        %if filediff.patch['stats']['added']:
+        <span class="pill" op="added">+${filediff.patch['stats']['added']}</span>
         %endif
-        %if stats['deleted']:
-        <span class="pill" op="deleted">-${stats['deleted']}</span>
+        %if filediff.patch['stats']['deleted']:
+        <span class="pill" op="deleted">-${filediff.patch['stats']['deleted']}</span>
         %endif
     </span>
 
@@ -408,7 +407,7 b' from rhodecode.lib.diffs import NEW_FILE'
 <%def name="diff_menu(filediff, use_comments=False)">
     <div class="filediff-menu">
 %if filediff.diffset.source_ref:
-    %if filediff.patch['operation'] in ['D', 'M']:
+    %if filediff.operation in ['D', 'M']:
         <a
             class="tooltip"
             href="${h.url('files_home',repo_name=filediff.diffset.repo_name,f_path=filediff.source_file_path,revision=filediff.diffset.source_ref)}"
@@ -424,7 +423,7 b' from rhodecode.lib.diffs import NEW_FILE'
             ${_('Show file before')}
         </span> |
     %endif
-    %if filediff.patch['operation'] in ['A', 'M']:
+    %if filediff.operation in ['A', 'M']:
         <a
             class="tooltip"
             href="${h.url('files_home',repo_name=filediff.diffset.source_repo_name,f_path=filediff.target_file_path,revision=filediff.diffset.target_ref)}"
@@ -460,10 +459,10 b' from rhodecode.lib.diffs import NEW_FILE'
 
         ## TODO: dan: refactor ignorews_url and context_url into the diff renderer same as diffmode=unified/sideside. Also use ajax to load more context (by clicking hunks)
         %if hasattr(c, 'ignorews_url'):
-        ${c.ignorews_url(request.GET, h.FID('', filediff['patch']['filename']))}
+        ${c.ignorews_url(request.GET, h.FID('', filediff.patch['filename']))}
         %endif
         %if hasattr(c, 'context_url'):
-        ${c.context_url(request.GET, h.FID('', filediff['patch']['filename']))}
+        ${c.context_url(request.GET, h.FID('', filediff.patch['filename']))}
         %endif
 
         %if use_comments:
@@ -503,9 +502,9 b' from rhodecode.lib.diffs import NEW_FILE'
     <%
     old_line_anchor, new_line_anchor = None, None
     if line.original.lineno:
-        old_line_anchor = diff_line_anchor(hunk.filediff.source_file_path, line.original.lineno, 'o')
+        old_line_anchor = diff_line_anchor(hunk.source_file_path, line.original.lineno, 'o')
     if line.modified.lineno:
-        new_line_anchor = diff_line_anchor(hunk.filediff.target_file_path, line.modified.lineno, 'n')
+        new_line_anchor = diff_line_anchor(hunk.target_file_path, line.modified.lineno, 'n')
     %>
 
     <tr class="cb-line">
@@ -579,9 +578,9 b' from rhodecode.lib.diffs import NEW_FILE'
     <%
     old_line_anchor, new_line_anchor = None, None
     if old_line_no:
-        old_line_anchor = diff_line_anchor(hunk.filediff.source_file_path, old_line_no, 'o')
+        old_line_anchor = diff_line_anchor(hunk.source_file_path, old_line_no, 'o')
     if new_line_no:
-        new_line_anchor = diff_line_anchor(hunk.filediff.target_file_path, new_line_no, 'n')
+        new_line_anchor = diff_line_anchor(hunk.target_file_path, new_line_no, 'n')
     %>
     <tr class="cb-line">
         <td class="cb-data ${action_class(action)}">
@@ -640,13 +639,13 b' from rhodecode.lib.diffs import NEW_FILE'
 
                 <a
                   class="btn ${c.diffmode == 'sideside' and 'btn-primary'} tooltip"
-                  title="${_('View side by side')}"
+                  title="${h.tooltip(_('View side by side'))}"
                   href="${h.url_replace(diffmode='sideside')}">
                     <span>${_('Side by Side')}</span>
                 </a>
                 <a
                   class="btn ${c.diffmode == 'unified' and 'btn-primary'} tooltip"
-                  title="${_('View unified')}" href="${h.url_replace(diffmode='unified')}">
+                  title="${h.tooltip(_('View unified'))}" href="${h.url_replace(diffmode='unified')}">
                     <span>${_('Unified')}</span>
                 </a>
             </div>

rhodecode/templates/codeblocks/source.mako

@@ -5,6 +5,7 b''
     from rhodecode.lib.codeblocks import render_tokenstream
     # avoid module lookup for performance
     html_escape = h.html_escape
+    tooltip = h.tooltip
     %>
     <tr class="cb-line cb-line-fresh ${'cb-annotate' if show_annotation else ''}"
     %if annotation:
@@ -15,13 +16,13 b''
     % if annotation:
         % if show_annotation:
             <td class="cb-annotate-info tooltip"
-                title="Author: ${annotation.author | entity}<br>Date: ${annotation.date}<br>Message: ${annotation.message | entity}"
+                title="Author: ${tooltip(annotation.author) | entity}<br>Date: ${annotation.date}<br>Message: ${annotation.message | entity}"
             >
               ${h.gravatar_with_user(annotation.author, 16) | n}
               <div class="cb-annotate-message truncate-wrap">${h.chop_at_smart(annotation.message, '\n', suffix_if_chopped='...')}</div>
             </td>
             <td class="cb-annotate-message-spacer">
-                <a class="tooltip" href="#show-previous-annotation" onclick="return annotationController.previousAnnotation('${annotation.raw_id}', '${c.f_path}')" title="${_('view annotation from before this change')}">
+                <a class="tooltip" href="#show-previous-annotation" onclick="return annotationController.previousAnnotation('${annotation.raw_id}', '${c.f_path}')" title="${tooltip(_('view annotation from before this change'))}">
                     <i class="icon-left"></i>
                 </a>
             </td>

rhodecode/templates/compare/compare_commits.mako

@@ -6,6 +6,7 b''
     <a href="${h.url('changeset_home', repo_name=c.repo_name, revision=c.ancestor)}">
         ${h.short_id(c.ancestor)}
     </a>. ${_('Compare was calculated based on this shared commit.')}
+    <input id="common_ancestor" type="hidden" name="common_ancestor" value="${c.ancestor}">
 </div>
 %endif
 

rhodecode/templates/data_table/_dt_elements.mako

@@ -9,7 +9,7 b''
   <div class="menu_items_container hidden">
     <ul class="menu_items">
       <li>
-         <a title="${_('Summary')}" href="${h.url('summary_home',repo_name=repo_name)}">
+         <a title="${_('Summary')}" href="${h.route_path('repo_summary',repo_name=repo_name)}">
          <span>${_('Summary')}</span>
          </a>
       </li>
@@ -42,7 +42,7 b''
     %>
   <div class="${'repo_state_pending' if rstate == 'repo_state_pending' else ''} truncate">
     ##NAME
-    <a href="${h.url('edit_repo' if admin else 'summary_home',repo_name=name)}">
+    <a href="${h.route_path('edit_repo',repo_name=name) if admin else h.route_path('repo_summary',repo_name=name)}">
 
     ##TYPE OF REPO
     %if h.is_hg(rtype):
@@ -64,7 +64,7 b''
     ${get_name(name)}
     </a>
     %if fork_of:
-      <a href="${h.url('summary_home',repo_name=fork_of.repo_name)}"><i class="icon-code-fork"></i></a>
+      <a href="${h.route_path('repo_summary',repo_name=fork_of.repo_name)}"><i class="icon-code-fork"></i></a>
     %endif
     %if rstate == 'repo_state_pending':
       <i class="icon-cogs" title="${_('Repository creating in progress...')}"></i>
@@ -92,22 +92,22 b''
 
 <%def name="rss(name)">
   %if c.rhodecode_user.username != h.DEFAULT_USER:
-    <a title="${_('Subscribe to %s rss feed')% name}" href="${h.url('rss_feed_home',repo_name=name,auth_token=c.rhodecode_user.feed_token)}"><i class="icon-rss-sign"></i></a>
+    <a title="${h.tooltip(_('Subscribe to %s rss feed')% name)}" href="${h.url('rss_feed_home',repo_name=name,auth_token=c.rhodecode_user.feed_token)}"><i class="icon-rss-sign"></i></a>
   %else:
-    <a title="${_('Subscribe to %s rss feed')% name}" href="${h.url('rss_feed_home',repo_name=name)}"><i class="icon-rss-sign"></i></a>
+    <a title="${h.tooltip(_('Subscribe to %s rss feed')% name)}" href="${h.url('rss_feed_home',repo_name=name)}"><i class="icon-rss-sign"></i></a>
   %endif
 </%def>
 
 <%def name="atom(name)">
   %if c.rhodecode_user.username != h.DEFAULT_USER:
-    <a title="${_('Subscribe to %s atom feed')% name}" href="${h.url('atom_feed_home',repo_name=name,auth_token=c.rhodecode_user.feed_token)}"><i class="icon-rss-sign"></i></a>
+    <a title="${h.tooltip(_('Subscribe to %s atom feed')% name)}" href="${h.url('atom_feed_home',repo_name=name,auth_token=c.rhodecode_user.feed_token)}"><i class="icon-rss-sign"></i></a>
   %else:
-    <a title="${_('Subscribe to %s atom feed')% name}" href="${h.url('atom_feed_home',repo_name=name)}"><i class="icon-rss-sign"></i></a>
+    <a title="${h.tooltip(_('Subscribe to %s atom feed')% name)}" href="${h.url('atom_feed_home',repo_name=name)}"><i class="icon-rss-sign"></i></a>
   %endif
 </%def>
 
 <%def name="user_gravatar(email, size=16)">
-  <div class="rc-user tooltip" title="${h.author_string(email)}">
+  <div class="rc-user tooltip" title="${h.tooltip(h.author_string(email))}">
     ${base.gravatar(email, 16)}
   </div>
 </%def>
@@ -115,11 +115,11 b''
 <%def name="repo_actions(repo_name, super_user=True)">
   <div>
     <div class="grid_edit">
-      <a href="${h.url('edit_repo',repo_name=repo_name)}" title="${_('Edit')}">
+      <a href="${h.route_path('edit_repo',repo_name=repo_name)}" title="${_('Edit')}">
         <i class="icon-pencil"></i>Edit</a>
     </div>
     <div class="grid_delete">
-      ${h.secure_form(h.url('repo', repo_name=repo_name),method='delete')}
+      ${h.secure_form(h.route_path('edit_repo_advanced_delete', repo_name=repo_name), method='POST')}
         ${h.submit('remove_%s' % repo_name,_('Delete'),class_="btn btn-link btn-danger",
         onclick="return confirm('"+_('Confirm to delete this repository: %s') % repo_name+"');")}
       ${h.end_form()}
@@ -134,7 +134,7 b''
     %elif repo_state == 'repo_state_created':
         <div class="tag tag1">${_('Created')}</div>
     %else:
-        <div class="tag alert2" title="${repo_state}">invalid</div>
+        <div class="tag alert2" title="${h.tooltip(repo_state)}">invalid</div>
     %endif
   </div>
 </%def>
@@ -146,7 +146,7 b''
   <div class="menu_items_container hidden">
     <ul class="menu_items">
       <li>
-         <a href="${h.url('repo_group_home',group_name=repo_group_name)}">
+         <a href="${h.route_path('repo_group_home', repo_group_name=repo_group_name)}">
          <span class="icon">
              <i class="icon-file-text"></i>
          </span>
@@ -160,7 +160,7 b''
 
 <%def name="repo_group_name(repo_group_name, children_groups=None)">
   <div>
-    <a href="${h.url('repo_group_home',group_name=repo_group_name)}">
+    <a href="${h.route_path('repo_group_home', repo_group_name=repo_group_name)}">
     <i class="icon-folder-close" title="${_('Repository group')}"></i>
       %if children_groups:
           ${h.literal(' &raquo; '.join(children_groups))}
@@ -282,7 +282,7 b''
 
 <%def name="pullrequest_target_repo(repo_name)">
     <div class="truncate">
-      ${h.link_to(repo_name,h.url('summary_home',repo_name=repo_name))}
+      ${h.link_to(repo_name,h.route_path('repo_summary',repo_name=repo_name))}
     </div>
 </%def>
 <%def name="pullrequest_status(status)">
@@ -299,7 +299,7 b''
 </%def>
 
 <%def name="pullrequest_name(pull_request_id, target_repo_name, short=False)">
-    <a href="${h.url('pullrequest_show',repo_name=target_repo_name,pull_request_id=pull_request_id)}">
+    <a href="${h.route_path('pullrequest_show',repo_name=target_repo_name,pull_request_id=pull_request_id)}">
       % if short:
         #${pull_request_id}
       % else:

rhodecode/templates/debug_style/collapsable-content.html

@@ -886,7 +886,7 b''
         AJAX_COMMENT_DELETE_URL = "/rhodecode-momentum/pull-request-comment/__COMMENT_ID__/delete";
 
         $(function(){
-            ReviewerAutoComplete('user');
+            ReviewerAutoComplete('#user');
 
             $('#open_edit_reviewers').on('click', function(e){
                 $('#open_edit_reviewers').hide();
@@ -949,9 +949,6 b''
                 updateCommits("rhodecode-momentum", "720");
             });
 
-            $('#close_pull_request').on('click', function(e){
-                closePullRequest("rhodecode-momentum", "720");
-            });
         })
       </script>
 

rhodecode/templates/email_templates/commit_comment.mako

@@ -3,7 +3,7 b''
 <%namespace name="base" file="base.mako"/>
 
 ## EMAIL SUBJECT
-<%def name="subject()" filter="n,trim">
+<%def name="subject()" filter="n,trim,whitespace_filter">
 <%
 data = {
     'user': h.person(user),

rhodecode/templates/email_templates/email_test.mako

@@ -1,7 +1,7 b''
 ## -*- coding: utf-8 -*-
 <%inherit file="base.mako"/>
 
-<%def name="subject()" filter="n,trim">
+<%def name="subject()" filter="n,trim,whitespace_filter">
 RhodeCode test email: ${h.format_date(date)}
 </%def>
 

rhodecode/templates/email_templates/main.mako

@@ -1,7 +1,7 b''
 ## -*- coding: utf-8 -*-
 <%inherit file="base.mako"/>
 
-<%def name="subject()" filter="n,trim">
+<%def name="subject()" filter="n,trim,whitespace_filter">
 </%def>
 
 

rhodecode/templates/email_templates/password_reset.mako

@@ -1,7 +1,7 b''
 ## -*- coding: utf-8 -*-
 <%inherit file="base.mako"/>
 
-<%def name="subject()" filter="n,trim">
+<%def name="subject()" filter="n,trim,whitespace_filter">
 RhodeCode Password reset
 </%def>
 

rhodecode/templates/email_templates/password_reset_confirmation.mako

@@ -1,7 +1,7 b''
 ## -*- coding: utf-8 -*-
 <%inherit file="base.mako"/>
 
-<%def name="subject()" filter="n,trim">
+<%def name="subject()" filter="n,trim,whitespace_filter">
 Your new RhodeCode password
 </%def>
 

rhodecode/templates/email_templates/pull_request_comment.mako

@@ -3,7 +3,7 b''
 <%namespace name="base" file="base.mako"/>
 
 ## EMAIL SUBJECT
-<%def name="subject()" filter="n,trim">
+<%def name="subject()" filter="n,trim,whitespace_filter">
 <%
 data = {
     'user': h.person(user),

rhodecode/templates/email_templates/pull_request_review.mako

@@ -2,7 +2,7 b''
 <%inherit file="base.mako"/>
 <%namespace name="base" file="base.mako"/>
 
-<%def name="subject()" filter="n,trim">
+<%def name="subject()" filter="n,trim,whitespace_filter">
 <%
 data = {
     'user': h.person(user),

rhodecode/templates/email_templates/test.mako

@@ -1,7 +1,7 b''
 ## -*- coding: utf-8 -*-
 <%inherit file="base.mako"/>
 
-<%def name="subject()" filter="n,trim">
+<%def name="subject()" filter="n,trim,whitespace_filter">
 Test "Subject" ${_('hello "world"')|n}
 </%def>
 

rhodecode/templates/email_templates/user_registration.mako

@@ -1,7 +1,7 b''
 ## -*- coding: utf-8 -*-
 <%inherit file="base.mako"/>
 
-<%def name="subject()" filter="n,trim">
+<%def name="subject()" filter="n,trim,whitespace_filter">
 RhodeCode new user registration: ${user.username}
 </%def>
 
@@ -10,18 +10,18 b' RhodeCode new user registration: ${user.'
 A new user `${user.username}` has registered on ${h.format_date(date)}
 
 - Username: ${user.username}
-- Full Name: ${user.firstname} ${user.lastname}
+- Full Name: ${user.first_name} ${user.last_name}
 - Email: ${user.email}
-- Profile link: ${h.route_path('user_profile', username=user.username, qualified=True)}
+- Profile link: ${h.route_url('user_profile', username=user.username)}
 
 ${self.plaintext_footer()}
 </%def>
 
 ## BODY GOES BELOW
 <table style="text-align:left;vertical-align:middle;">
-    <tr><td colspan="2" style="width:100%;padding-bottom:15px;border-bottom:1px solid #dbd9da;"><h4><a href="${h.route_path('user_profile', username=user.username, qualified=True)}" style="color:#427cc9;text-decoration:none;cursor:pointer">${_('New user %(user)s has registered on %(date)s') % {'user': user.username, 'date': h.format_date(date)}}</a></h4></td></tr>
+    <tr><td colspan="2" style="width:100%;padding-bottom:15px;border-bottom:1px solid #dbd9da;"><h4><a href="${h.route_url('user_profile', username=user.username)}" style="color:#427cc9;text-decoration:none;cursor:pointer">${_('New user %(user)s has registered on %(date)s') % {'user': user.username, 'date': h.format_date(date)}}</a></h4></td></tr>
     <tr><td style="padding-right:20px;padding-top:20px;">${_('Username')}</td><td style="line-height:1;padding-top:20px;"><img style="margin-bottom:-5px;text-align:left;border:1px solid #dbd9da" src="${h.gravatar_url(user.email, 16)}" height="16" width="16">&nbsp;${user.username}</td></tr>
-    <tr><td style="padding-right:20px;">${_('Full Name')}</td><td>${user.firstname} ${user.lastname}</td></tr>
+    <tr><td style="padding-right:20px;">${_('Full Name')}</td><td>${user.first_name} ${user.last_name}</td></tr>
     <tr><td style="padding-right:20px;">${_('Email')}</td><td>${user.email}</td></tr>
-    <tr><td style="padding-right:20px;">${_('Profile')}</td><td><a href="${h.route_path('user_profile', username=user.username, qualified=True)}">${h.route_path('user_profile', username=user.username, qualified=True)}</a></td></tr>
+    <tr><td style="padding-right:20px;">${_('Profile')}</td><td><a href="${h.route_url('user_profile', username=user.username)}">${h.route_url('user_profile', username=user.username)}</a></td></tr>
 </table>
  No newline at end of file

rhodecode/templates/errors/error_document.mako

@@ -24,11 +24,10 b''
         <script type="text/javascript" src="${h.asset('js/scripts.js', ver=c.rhodecode_version_hash)}"></script>
     </head>
     <body>
-        <% messages = h.flash.pop_messages() %>
 
         <div class="wrapper error_page">
             <div class="sidebar">
-                <a href="${h.url('home')}"><img class="error-page-logo" src="${h.asset('images/RhodeCode_Logo_Black.png')}" alt="RhodeCode"/></a>
+                <a href="${h.route_path('home')}"><img class="error-page-logo" src="${h.asset('images/RhodeCode_Logo_Black.png')}" alt="RhodeCode"/></a>
             </div>
             <div class="main-content">
                 <h1>
@@ -37,8 +36,8 b''
                     </span><br/>
                     ${c.error_message} | <span class="error_message">${c.error_explanation}</span>
                 </h1>
-                % if messages:
-                    % for message in messages:
+                % if c.messages:
+                    % for message in c.messages:
                         <div class="alert alert-${message.category}">${message}</div>
                     % endfor
                 % endif    
@@ -62,12 +61,12 b''
                 <div class="inner-column">
                     <h4>Support</h4>
                     <p>For support, go to <a href="${c.visual.rhodecode_support_url}" target="_blank">${_('Support')}</a>.
-                       It may be useful to include your log file; see the log file locations <a href="${h.url('enterprise_log_file_locations')}">here</a>.
+                       It may be useful to include your log file; see the log file locations <a href="${h.route_url('enterprise_log_file_locations')}">here</a>.
                     </p>
                 </div>
                 <div class="inner-column">
                     <h4>Documentation</h4>
-                    <p>For more information, see <a href="${h.url('enterprise_docs')}">docs.rhodecode.com</a>.</p>
+                    <p>For more information, see <a href="${h.route_url('enterprise_docs')}">docs.rhodecode.com</a>.</p>
                 </div>
             </div>
         </div>

rhodecode/templates/files/base.mako

@@ -7,20 +7,20 b''
 
     %if h.is_hg(c.rhodecode_repo):
         %for book in commit.bookmarks:
-            <span class="booktag tag" title="${_('Bookmark %s') % book}">
+            <span class="booktag tag" title="${h.tooltip(_('Bookmark %s') % book)}">
               <a href="${h.url('files_home',repo_name=c.repo_name,revision=commit.raw_id)}"><i class="icon-bookmark"></i>${h.shorter(book)}</a>
             </span>
         %endfor
     %endif
 
     %for tag in commit.tags:
-        <span class="tagtag tag"  title="${_('Tag %s') % tag}">
+        <span class="tagtag tag"  title="${h.tooltip(_('Tag %s') % tag)}">
             <a href="${h.url('files_home',repo_name=c.repo_name,revision=commit.raw_id)}"><i class="icon-tag"></i>${tag}</a>
         </span>
     %endfor
 
     %if commit.branch:
-        <span class="branchtag tag" title="${_('Branch %s') % commit.branch}">
+        <span class="branchtag tag" title="${h.tooltip(_('Branch %s') % commit.branch)}">
           <a href="${h.url('files_home',repo_name=c.repo_name,revision=commit.raw_id)}"><i class="icon-code-fork"></i>${h.shorter(commit.branch)}</a>
         </span>
     %endif

rhodecode/templates/files/file_authors_box.mako

@@ -15,7 +15,7 b''
 <ul class="sidebar-right-content">
     % for email, user in sorted(c.authors, key=lambda e: c.file_last_commit.author_email!=e[0]):
     <li class="file_author">
-        <div class="rc-user tooltip" title="${h.author_string(email)}">
+        <div class="rc-user tooltip" title="${h.tooltip(h.author_string(email))}">
           ${base.gravatar(email, 16)}
           <span class="user">${h.link_to_user(user)}</span>
         </div>

rhodecode/templates/files/files_add.mako

@@ -56,11 +56,17 b''
         </div>
         <div id="upload_file_container" class="fieldset" style="display: none;">
             <div class="filename-label left-label">
+                ${_('Filename')}:
+            </div>
+            <div class="right-content">
+                <input class="input-small" type="text" value="" size="46" name="filename_upload" id="filename_upload" placeholder="${_('No file selected')}">
+            </div>
+            <div class="filename-label left-label file-upload-label">
                 ${_('Upload file')}:
             </div>
             <div class="right-content file-upload-input">
                 <label for="upload_file" class="btn btn-default">Browse</label>
-                <span id="selected-file">${_('No file selected')}</span>
+
                 <input type="file" name="upload_file" id="upload_file">
                 <p>${_('or')} <a id="file_enable" href="#">${_('Create New File')}</a></p>
             </div>
@@ -155,10 +161,8 b''
     });
 
     $('#upload_file').on('change', function() {
-        if (detectIE() && detectIE() <= 9) {
-            if (this.files && this.files[0]) {
-                $('#selected-file').html(this.files[0].name);
-            }
+        if (this.files && this.files[0]) {
+            $('#filename_upload').val(this.files[0].name);
         }
     });
 

rhodecode/templates/files/files_browser_tree.mako

@@ -58,14 +58,14 b''
               </td>
               <td class="td-hash" data-attr-name="commit_id">
                   % if c.full_load:
-                  <div class="tooltip" title="${node.last_commit.message}">
+                  <div class="tooltip" title="${h.tooltip(node.last_commit.message)}">
                       <pre data-commit-id="${node.last_commit.raw_id}">r${node.last_commit.revision}:${node.last_commit.short_id}</pre>
                   </div>
                   % endif
               </td>
               <td class="td-user" data-attr-name="author">
                   % if c.full_load:
-                  <span data-author="${node.last_commit.author}" title="${node.last_commit.author}">${h.gravatar_with_user(node.last_commit.author)|n}</span>
+                  <span data-author="${node.last_commit.author}" title="${h.tooltip(node.last_commit.author)}">${h.gravatar_with_user(node.last_commit.author)|n}</span>
                   % endif
               </td>
             %else:

rhodecode/templates/forks/forks_data.mako

@@ -16,7 +16,7 b''
               ${base.gravatar_with_user(f.user.email, 16)}
             </td>
             <td class="td-componentname">
-              ${h.link_to(f.repo_name,h.url('summary_home',repo_name=f.repo_name))}
+              ${h.link_to(f.repo_name,h.route_path('repo_summary',repo_name=f.repo_name))}
             </td>
             <td class="td-description">
                 <div class="truncate">${f.description}</div>
@@ -25,7 +25,7 b''
                 ${h.age_component(f.created_on, time_is_local=True)}
             </td>
             <td class="td-compare">
-                <a title="${_('Compare fork with %s' % c.repo_name)}"
+                <a title="${h.tooltip(_('Compare fork with %s' % c.repo_name))}"
                    href="${h.url('compare_url',repo_name=c.repo_name, source_ref_type=c.rhodecode_db_repo.landing_rev[0],source_ref=c.rhodecode_db_repo.landing_rev[1],target_repo=f.repo_name,target_ref_type=c.rhodecode_db_repo.landing_rev[0],target_ref=c.rhodecode_db_repo.landing_rev[1], merge=1)}"
                    class="btn-link"><i class="icon-loop"></i> ${_('Compare fork')}</a>
             </td>

rhodecode/templates/forms/select2.pt

@@ -21,7 +21,7 b''
                 tal:attributes="label item.label">
         <option tal:repeat="(value, description) item.options"
                 tal:attributes="
-                selected (multiple and value in list(map(unicode, cstruct)) or value == list(map(unicode, cstruct))) and 'selected';
+                selected python:field.widget.get_select_value(cstruct, value);
                 class css_class;
                 label field.widget.long_label_generator and description;
                 value value"
@@ -29,7 +29,7 b''
       </optgroup>
       <option tal:condition="not isinstance(item, optgroup_class)"
               tal:attributes="
-              selected (multiple and item[0] in list(map(unicode, cstruct)) or item[0] == unicode(cstruct)) and 'selected';
+              selected python:field.widget.get_select_value(cstruct, item[0]);
               class css_class;
               value item[0]">${item[1]}</option>
     </tal:loop>
@@ -37,7 +37,7 b''
 
   <script type="text/javascript">
    deform.addCallback(
-     '${field.oid}',
+     '${oid}',
      function(oid) {
        $('#' + oid).select2({
          containerCssClass: 'form-control drop-menu',

rhodecode/templates/forms/sequence.pt

@@ -32,21 +32,21 b''
          tal:attributes="prototype prototype"/>
 
   <div class="panel panel-default">
-    <div class="panel-heading">${title}</div>
     <div class="panel-body">
 
       <div class="deform-seq-container"
            id="${oid}-orderable">
         <div tal:define="subfields [ x[1] for x in subfields ]"
              tal:repeat="subfield subfields"
-             tal:replace="structure subfield.render_template(item_tmpl,
-                                                          parent=field)" />
+             tal:replace="structure subfield.render_template(item_tmpl,parent=field)" />
         <span class="deform-insert-before"
               tal:attributes="
                  min_len min_len;
                  max_len max_len;
                  now_len now_len;
-                 orderable orderable;"></span>
+                 orderable orderable;">
+
+        </span>
       </div>
 
       <div style="clear: both"></div>
@@ -78,12 +78,12 b''
                placeholder: '<span class="glyphicon glyphicon-arrow-right placeholder"></span>',
                onDragStart: function ($item, container, _super) {
                  var offset = $item.offset(),
-                 pointer = container.rootGroup.pointer
+                 pointer = container.rootGroup.pointer;
 
                  adjustment = {
                    left: pointer.left - offset.left,
                    top: pointer.top - offset.top
-                 }
+                 };
 
                  _super($item, container)
                },

rhodecode/templates/forms/sequence_item.pt

@@ -6,6 +6,7 b''
                  oid oid|field.oid"
      class="form-group row deform-seq-item ${field.error and error_class or ''} ${field.widget.item_css_class or ''}"
      i18n:domain="deform">
+
   <div class="deform-seq-item-group">
     <span tal:replace="structure field.serialize(cstruct)"/>
     <tal:errors condition="field.error and not hidden"
@@ -17,13 +18,8 b''
          i18n:translate="">${msg}</p>
     </tal:errors>
   </div>
+
   <div class="deform-seq-item-handle" style="padding:0">
-    <!-- sequence_item -->
-    <span class="deform-order-button close glyphicon glyphicon-resize-vertical"
-          id="${oid}-order"
-          tal:condition="not hidden"
-          title="Reorder (via drag and drop)"
-          i18n:attributes="title"></span>
     <a class="deform-close-button close"
        id="${oid}-close"
        tal:condition="not field.widget.hidden"
@@ -31,5 +27,5 b''
        i18n:attributes="title"
        onclick="javascript:deform.removeSequenceItem(this);">&times;</a>
   </div>
-  <!-- /sequence_item -->
+
 </div>

rhodecode/templates/index_repo_group.mako

@@ -10,9 +10,9 b''
 
 <%def name="breadcrumbs()">
     <span class="groups_breadcrumbs">
-    ${h.link_to(_(u'Home'),h.url('/'))}
+    ${h.link_to(_(u'Home'), h.route_path('home'))}
     %if c.repo_group.parent_group:
-        &raquo; ${h.link_to(c.repo_group.parent_group.name,h.url('repo_group_home',group_name=c.repo_group.parent_group.group_name))}
+        &raquo; ${h.link_to(c.repo_group.parent_group.name, h.route_path('repo_group_home', repo_group_name=c.repo_group.parent_group.group_name))}
     %endif
     &raquo; ${c.repo_group.name}
     </span>

rhodecode/templates/journal/journal_data.mako

@@ -20,7 +20,7 b''
                         <span class="journal_repo_name">
                         %if entry.repository is not None:
                           ${h.link_to(entry.repository.repo_name,
-                                      h.url('summary_home',repo_name=entry.repository.repo_name))}
+                                      h.route_path('repo_summary',repo_name=entry.repository.repo_name))}
                         %else:
                           ${entry.repository_name}
                         %endif

rhodecode/templates/login.mako

@@ -14,7 +14,7 b''
         <div id="header-inner" class="title">
             <div id="logo">
                 <div class="logo-wrapper">
-                    <a href="${h.url('home')}"><img src="${h.asset('images/rhodecode-logo-white-216x60.png')}" alt="RhodeCode"/></a>
+                    <a href="${h.route_path('home')}"><img src="${h.asset('images/rhodecode-logo-white-216x60.png')}" alt="RhodeCode"/></a>
                 </div>
                 %if c.rhodecode_name:
                 <div class="branding"> ${h.branding(c.rhodecode_name)}</div>

rhodecode/templates/password_reset.mako

@@ -14,7 +14,7 b''
         <div id="header-inner" class="title">
             <div id="logo">
                 <div class="logo-wrapper">
-                    <a href="${h.url('home')}"><img src="${h.asset('images/rhodecode-logo-white-216x60.png')}" alt="RhodeCode"/></a>
+                    <a href="${h.route_path('home')}"><img src="${h.asset('images/rhodecode-logo-white-216x60.png')}" alt="RhodeCode"/></a>
                 </div>
                 %if c.rhodecode_name:
                 <div class="branding"> ${h.branding(c.rhodecode_name)}</div>

rhodecode/templates/pullrequests/pullrequest.mako

@@ -20,15 +20,22 b''
 <div class="box">
     <div class="title">
         ${self.repo_page_title(c.rhodecode_db_repo)}
-        ${self.breadcrumbs()}
     </div>
 
     ${h.secure_form(url('pullrequest', repo_name=c.repo_name), method='post', id='pull_request_form')}
+
+        ${self.breadcrumbs()}
+
         <div class="box pr-summary">
 
             <div class="summary-details block-left">
 
-                <div class="form">
+
+                <div class="pr-details-title">
+                    ${_('Pull request summary')}
+                </div>
+
+                <div class="form" style="padding-top: 10px">
                     <!-- fields -->
 
                     <div class="fields" >
@@ -62,7 +69,7 b''
 
                             ##ORG
                             <div class="content">
-                                <strong>${_('Origin repository')}:</strong>
+                                <strong>${_('Source repository')}:</strong>
                                 ${c.rhodecode_db_repo.description}
                             </div>
                             <div class="content">
@@ -102,6 +109,31 b''
                 </div>
             </div>
             <div>
+                ## AUTHOR
+                <div class="reviewers-title block-right">
+                  <div class="pr-details-title">
+                      ${_('Author of this pull request')}
+                  </div>
+                </div>
+                <div class="block-right pr-details-content reviewers">
+                    <ul class="group_members">
+                      <li>
+                        ${self.gravatar_with_user(c.rhodecode_user.email, 16)}
+                      </li>
+                    </ul>
+                </div>
+
+                ## REVIEW RULES
+                <div id="review_rules" style="display: none" class="reviewers-title block-right">
+                    <div class="pr-details-title">
+                        ${_('Reviewer rules')}
+                    </div>
+                    <div class="pr-reviewer-rules">
+                        ## review rules will be appended here, by default reviewers logic
+                    </div>
+                </div>
+
+                ## REVIEWERS
                 <div class="reviewers-title block-right">
                     <div class="pr-details-title">
                         ${_('Pull request reviewers')}
@@ -115,7 +147,7 b''
                     <input type="hidden" name="__end__" value="review_members:sequence">
                     <div id="add_reviewer_input" class='ac'>
                         <div class="reviewer_ac">
-                            ${h.text('user', class_='ac-input', placeholder=_('Add reviewer'))}
+                            ${h.text('user', class_='ac-input', placeholder=_('Add reviewer or reviewer group'))}
                             <div id="reviewers_container"></div>
                         </div>
                     </div>
@@ -137,7 +169,6 b''
   var defaultSourceRepoData = ${c.default_repo_data['source_refs_json']|n};
   var defaultTargetRepo = '${c.default_repo_data['target_repo_name']}';
   var defaultTargetRepoData = ${c.default_repo_data['target_refs_json']|n};
-  var targetRepoName = '${c.repo_name}';
 
   var $pullRequestForm = $('#pull_request_form');
   var $sourceRepo = $('#source_repo', $pullRequestForm);
@@ -145,6 +176,12 b''
   var $sourceRef = $('#source_ref', $pullRequestForm);
   var $targetRef = $('#target_ref', $pullRequestForm);
 
+  var sourceRepo = function() { return $sourceRepo.eq(0).val() };
+  var sourceRef = function() { return $sourceRef.eq(0).val().split(':') };
+
+  var targetRepo = function() { return $targetRepo.eq(0).val() };
+  var targetRef = function() { return $targetRef.eq(0).val().split(':') };
+
   var calculateContainerWidth = function() {
       var maxWidth = 0;
       var repoSelect2Containers = ['#source_repo', '#target_repo'];
@@ -204,6 +241,8 b''
   // custom code mirror
   var codeMirrorInstance = initPullRequestsCodeMirror('#pullrequest_desc');
 
+  reviewersController = new ReviewersController();
+
   var queryTargetRepo = function(self, query) {
       // cache ALL results if query is empty
       var cacheKey = query.term || '__';
@@ -213,7 +252,7 b''
           query.callback({results: cachedData.results});
       } else {
           $.ajax({
-              url: pyroutes.url('pullrequest_repo_destinations', {'repo_name': targetRepoName}),
+              url: pyroutes.url('pullrequest_repo_destinations', {'repo_name': templateContext.repo_name}),
               data: {query: query.term},
               dataType: 'json',
               type: 'GET',
@@ -246,55 +285,21 b''
       query.callback({results: data.results});
   };
 
-
-  var prButtonLockChecks = {
-      'compare': false,
-      'reviewers': false
-  };
-
-  var prButtonLock = function(lockEnabled, msg, scope) {
-      scope = scope || 'all';
-      if (scope == 'all'){
-          prButtonLockChecks['compare'] = !lockEnabled;
-          prButtonLockChecks['reviewers'] = !lockEnabled;
-      } else if (scope == 'compare') {
-          prButtonLockChecks['compare'] = !lockEnabled;
-      } else if (scope == 'reviewers'){
-          prButtonLockChecks['reviewers'] = !lockEnabled;
-      }
-      var checksMeet = prButtonLockChecks.compare && prButtonLockChecks.reviewers;
-      if (lockEnabled) {
-          $('#save').attr('disabled', 'disabled');
-      }
-      else if (checksMeet) {
-          $('#save').removeAttr('disabled');
-      }
-
-      if (msg) {
-          $('#pr_open_message').html(msg);
-      }
-  };
-
   var loadRepoRefDiffPreview = function() {
-      var sourceRepo = $sourceRepo.eq(0).val();
-      var sourceRef = $sourceRef.eq(0).val().split(':');
-
-      var targetRepo = $targetRepo.eq(0).val();
-      var targetRef = $targetRef.eq(0).val().split(':');
 
       var url_data = {
-          'repo_name': targetRepo,
-          'target_repo': sourceRepo,
-          'source_ref': targetRef[2],
+          'repo_name': targetRepo(),
+          'target_repo': sourceRepo(),
+          'source_ref': targetRef()[2],
           'source_ref_type': 'rev',
-          'target_ref': sourceRef[2],
+          'target_ref': sourceRef()[2],
           'target_ref_type': 'rev',
           'merge': true,
           '_': Date.now() // bypass browser caching
       }; // gather the source/target ref and repo here
 
-      if (sourceRef.length !== 3 || targetRef.length !== 3) {
-          prButtonLock(true, "${_('Please select origin and destination')}");
+      if (sourceRef().length !== 3 || targetRef().length !== 3) {
+          prButtonLock(true, "${_('Please select source and target')}");
           return;
       }
       var url = pyroutes.url('compare_url', url_data);
@@ -315,10 +320,11 b''
           .done(function(data) {
               loadRepoRefDiffPreview._currentRequest = null;
               $('#pull_request_overview').html(data);
+
               var commitElements = $(data).find('tr[commit_id]');
 
-              var prTitleAndDesc = getTitleAndDescription(sourceRef[1],
-                                                          commitElements, 5);
+              var prTitleAndDesc = getTitleAndDescription(
+                  sourceRef()[1], commitElements, 5);
 
               var title = prTitleAndDesc[0];
               var proposedDescription = prTitleAndDesc[1];
@@ -366,43 +372,6 b''
           });
   };
 
-  /**
-   Generate Title and Description for a PullRequest.
-   In case of 1 commits, the title and description is that one commit
-   in case of multiple commits, we iterate on them with max N number of commits,
-   and build description in a form
-   - commitN
-   - commitN+1
-   ...
-
-   Title is then constructed from branch names, or other references,
-   replacing '-' and '_' into spaces
-
-   * @param sourceRef
-   * @param elements
-   * @param limit
-   * @returns {*[]}
-   */
-  var getTitleAndDescription = function(sourceRef, elements, limit) {
-      var title = '';
-      var desc = '';
-
-      $.each($(elements).get().reverse().slice(0, limit), function(idx, value) {
-          var rawMessage = $(value).find('td.td-description .message').data('messageRaw');
-          desc += '- ' + rawMessage.split('\n')[0].replace(/\n+$/, "") + '\n';
-      });
-      // only 1 commit, use commit message as title
-      if (elements.length == 1) {
-          title = $(elements[0]).find('td.td-description .message').data('messageRaw').split('\n')[0];
-      }
-      else {
-          // use reference name
-          title = sourceRef.replace(/-/g, ' ').replace(/_/g, ' ').capitalizeFirstLetter();
-      }
-
-      return [title, desc]
-  };
-
   var Select2Box = function(element, overrides) {
     var globalDefaults = {
         dropdownAutoWidth: true,
@@ -459,7 +428,7 b''
   var targetRepoChanged = function(repoData) {
       // generate new DESC of target repo displayed next to select
       $('#target_repo_desc').html(
-          "<strong>${_('Destination repository')}</strong>: {0}".format(repoData['description'])
+          "<strong>${_('Target repository')}</strong>: {0}".format(repoData['description'])
       );
 
       // generate dynamic select2 for refs.
@@ -468,8 +437,7 b''
 
   };
 
-  var sourceRefSelect2 = Select2Box(
-    $sourceRef, {
+  var sourceRefSelect2 = Select2Box($sourceRef, {
       placeholder: "${_('Select commit reference')}",
       query: function(query) {
         var initialData = defaultSourceRepoData['refs']['select2_refs'];
@@ -499,12 +467,14 b''
 
   $sourceRef.on('change', function(e){
     loadRepoRefDiffPreview();
-    loadDefaultReviewers();
+    reviewersController.loadDefaultReviewers(
+        sourceRepo(), sourceRef(), targetRepo(), targetRef());
   });
 
   $targetRef.on('change', function(e){
     loadRepoRefDiffPreview();
-    loadDefaultReviewers();
+    reviewersController.loadDefaultReviewers(
+        sourceRepo(), sourceRef(), targetRepo(), targetRef());
   });
 
   $targetRepo.on('change', function(e){
@@ -515,7 +485,7 b''
 
       $.ajax({
           url: pyroutes.url('pullrequest_repo_refs',
-            {'repo_name': targetRepoName, 'target_repo_name':repoName}),
+            {'repo_name': templateContext.repo_name, 'target_repo_name':repoName}),
           data: {},
           dataType: 'json',
           type: 'GET',
@@ -531,43 +501,7 b''
 
   });
 
-  var loadDefaultReviewers = function() {
-    if (loadDefaultReviewers._currentRequest) {
-        loadDefaultReviewers._currentRequest.abort();
-    }
-    $('.calculate-reviewers').show();
-    prButtonLock(true, null, 'reviewers');
-
-    var url = pyroutes.url('repo_default_reviewers_data', {'repo_name': targetRepoName});
-
-    var sourceRepo = $sourceRepo.eq(0).val();
-    var sourceRef = $sourceRef.eq(0).val().split(':');
-    var targetRepo = $targetRepo.eq(0).val();
-    var targetRef = $targetRef.eq(0).val().split(':');
-    url += '?source_repo=' + sourceRepo;
-    url += '&source_ref=' + sourceRef[2];
-    url += '&target_repo=' + targetRepo;
-    url += '&target_ref=' + targetRef[2];
-
-    loadDefaultReviewers._currentRequest = $.get(url)
-        .done(function(data) {
-            loadDefaultReviewers._currentRequest = null;
-
-            // reset && add the reviewer based on selected repo
-            $('#review_members').html('');
-            for (var i = 0; i < data.reviewers.length; i++) {
-              var reviewer = data.reviewers[i];
-              addReviewMember(
-                  reviewer.user_id, reviewer.firstname,
-                  reviewer.lastname, reviewer.username,
-                  reviewer.gravatar_link, reviewer.reasons);
-            }
-            $('.calculate-reviewers').hide();
-            prButtonLock(false, null, 'reviewers');
-        });
-  };
-
-  prButtonLock(true, "${_('Please select origin and destination')}", 'all');
+  prButtonLock(true, "${_('Please select source and target')}", 'all');
 
   // auto-load on init, the target refs select2
   calculateContainerWidth();
@@ -578,13 +512,14 b''
   });
 
   % if c.default_source_ref:
-      // in case we have a pre-selected value, use it now
-      $sourceRef.select2('val', '${c.default_source_ref}');
-      loadRepoRefDiffPreview();
-      loadDefaultReviewers();
+  // in case we have a pre-selected value, use it now
+  $sourceRef.select2('val', '${c.default_source_ref}');
+  loadRepoRefDiffPreview();
+  reviewersController.loadDefaultReviewers(
+      sourceRepo(), sourceRef(), targetRepo(), targetRef());
   % endif
 
-  ReviewerAutoComplete('user');
+  ReviewerAutoComplete('#user');
 });
 </script>
 

rhodecode/templates/pullrequests/pullrequest_show.mako

@@ -48,13 +48,13 b''
       <div class="summary-details block-left">
         <% summary = lambda n:{False:'summary-short'}.get(n) %>
         <div class="pr-details-title">
-            <a href="${h.url('pull_requests_global', pull_request_id=c.pull_request.pull_request_id)}">${_('Pull request #%s') % c.pull_request.pull_request_id}</a> ${_('From')} ${h.format_date(c.pull_request.created_on)}
+            <a href="${h.route_path('pull_requests_global', pull_request_id=c.pull_request.pull_request_id)}">${_('Pull request #%s') % c.pull_request.pull_request_id}</a> ${_('From')} ${h.format_date(c.pull_request.created_on)}
             %if c.allowed_to_update:
               <div id="delete_pullrequest" class="pull-right action_button ${'' if c.allowed_to_delete else 'disabled' }" style="clear:inherit;padding: 0">
                   % if c.allowed_to_delete:
                       ${h.secure_form(url('pullrequest_delete', repo_name=c.pull_request.target_repo.repo_name, pull_request_id=c.pull_request.pull_request_id),method='delete')}
                           ${h.submit('remove_%s' % c.pull_request.pull_request_id, _('Delete'),
-                        class_="btn btn-link btn-danger",onclick="return confirm('"+_('Confirm to delete this pull request')+"');")}
+                        class_="btn btn-link btn-danger no-margin",onclick="return confirm('"+_('Confirm to delete this pull request')+"');")}
                       ${h.end_form()}
                   % else:
                     ${_('Delete')}
@@ -68,7 +68,7 b''
         <div id="summary" class="fields pr-details-content">
            <div class="field">
             <div class="label-summary">
-                <label>${_('Origin')}:</label>
+                <label>${_('Source')}:</label>
             </div>
             <div class="input">
                 <div class="pr-origininfo">
@@ -81,7 +81,7 b''
                       %endif
                     </span>
                     <span class="clone-url">
-                        <a href="${h.url('summary_home', repo_name=c.pull_request.source_repo.repo_name)}">${c.pull_request.source_repo.clone_url()}</a>
+                        <a href="${h.route_path('repo_summary', repo_name=c.pull_request.source_repo.repo_name)}">${c.pull_request.source_repo.clone_url()}</a>
                     </span>
                     <br/>
                     % if c.ancestor_commit:
@@ -113,7 +113,7 b''
                       %endif
                     </span>
                     <span class="clone-url">
-                        <a href="${h.url('summary_home', repo_name=c.pull_request.target_repo.repo_name)}">${c.pull_request.target_repo.clone_url()}</a>
+                        <a href="${h.route_path('repo_summary', repo_name=c.pull_request.target_repo.repo_name)}">${c.pull_request.target_repo.clone_url()}</a>
                     </span>
                 </div>
             </div>
@@ -297,7 +297,7 b''
            <div id="pr-save" class="field" style="display: none;">
             <div class="label-summary"></div>
             <div class="input">
-              <span id="edit_pull_request" class="btn btn-small">${_('Save Changes')}</span>
+              <span id="edit_pull_request" class="btn btn-small no-margin">${_('Save Changes')}</span>
             </div>
            </div>
         </div>
@@ -306,7 +306,7 b''
         ## AUTHOR
         <div class="reviewers-title block-right">
           <div class="pr-details-title">
-              ${_('Author')}
+              ${_('Author of this pull request')}
           </div>
         </div>
         <div class="block-right pr-details-content reviewers">
@@ -316,13 +316,27 b''
               </li>
             </ul>
         </div>
+
+        ## REVIEW RULES
+        <div id="review_rules" style="display: none" class="reviewers-title block-right">
+            <div class="pr-details-title">
+                ${_('Reviewer rules')}
+              %if c.allowed_to_update:
+                <span id="close_edit_reviewers" class="block-right action_button last-item" style="display: none;">${_('Close')}</span>
+              %endif
+            </div>
+            <div class="pr-reviewer-rules">
+                ## review rules will be appended here, by default reviewers logic
+            </div>
+            <input id="review_data" type="hidden" name="review_data" value="">
+        </div>
+
         ## REVIEWERS
         <div class="reviewers-title block-right">
           <div class="pr-details-title">
               ${_('Pull request reviewers')}
               %if c.allowed_to_update:
-                <span id="open_edit_reviewers" class="block-right action_button">${_('Edit')}</span>
-                <span id="close_edit_reviewers" class="block-right action_button" style="display: none;">${_('Close')}</span>
+                <span id="open_edit_reviewers" class="block-right action_button last-item">${_('Edit')}</span>
               %endif
           </div>
         </div>
@@ -330,8 +344,8 b''
           ## members goes here !
             <input type="hidden" name="__start__" value="review_members:sequence">
             <ul id="review_members" class="group_members">
-            %for member,reasons,status in c.pull_request_reviewers:
-              <li id="reviewer_${member.user_id}">
+            %for member,reasons,mandatory,status in c.pull_request_reviewers:
+              <li id="reviewer_${member.user_id}" class="reviewer_entry">
                 <div class="reviewers_member">
                     <div class="reviewer_status tooltip" title="${h.tooltip(h.commit_status_lbl(status[0][1].status if status else 'not_reviewed'))}">
                       <div class="${'flag_status %s' % (status[0][1].status if status else 'not_reviewed')} pull-left reviewer_member_status"></div>
@@ -348,30 +362,43 b''
                   %endfor
                   <input type="hidden" name="__end__" value="reasons:sequence">
                   <input id="reviewer_${member.user_id}_input" type="hidden" value="${member.user_id}" name="user_id" />
+                  <input type="hidden" name="mandatory" value="${mandatory}"/>
                   <input type="hidden" name="__end__" value="reviewer:mapping">
-                  %if c.allowed_to_update:
-                  <div class="reviewer_member_remove action_button" onclick="removeReviewMember(${member.user_id}, true)" style="visibility: hidden;">
-                      <i class="icon-remove-sign" ></i>
-                  </div>
-                  %endif
+                  % if mandatory:
+                        <div class="reviewer_member_mandatory_remove">
+                            <i class="icon-remove-sign"></i>
+                        </div>
+                        <div class="reviewer_member_mandatory">
+                            <i class="icon-lock" title="${h.tooltip(_('Mandatory reviewer'))}"></i>
+                        </div>
+                  % else:
+                    %if c.allowed_to_update:
+                      <div class="reviewer_member_remove action_button" onclick="reviewersController.removeReviewMember(${member.user_id}, true)" style="visibility: hidden;">
+                          <i class="icon-remove-sign" ></i>
+                      </div>
+                    %endif
+                  % endif
                 </div>
               </li>
             %endfor
             </ul>
             <input type="hidden" name="__end__" value="review_members:sequence">
-          %if not c.pull_request.is_closed():
-          <div id="add_reviewer_input" class='ac' style="display: none;">
-            %if c.allowed_to_update:
-            <div class="reviewer_ac">
-               ${h.text('user', class_='ac-input', placeholder=_('Add reviewer'))}
-               <div id="reviewers_container"></div>
-            </div>
-            <div>
-             <button id="update_pull_request" class="btn btn-small">${_('Save Changes')}</button>
-            </div>
+
+            %if not c.pull_request.is_closed():
+                <div id="add_reviewer" class="ac" style="display: none;">
+                %if c.allowed_to_update:
+                    % if not c.forbid_adding_reviewers:
+                        <div id="add_reviewer_input" class="reviewer_ac">
+                           ${h.text('user', class_='ac-input', placeholder=_('Add reviewer or reviewer group'))}
+                           <div id="reviewers_container"></div>
+                        </div>
+                    % endif
+                    <div class="pull-right">
+                        <button id="update_pull_request" class="btn btn-small no-margin">${_('Save Changes')}</button>
+                    </div>
+                %endif
+                </div>
             %endif
-          </div>
-          %endif
         </div>
       </div>
   </div>
@@ -429,7 +456,7 b''
 
                     <div class="pull-right">
                         % if c.allowed_to_update and not c.pull_request.is_closed():
-                          <a id="update_commits" class="btn btn-primary pull-right">${_('Update commits')}</a>
+                          <a id="update_commits" class="btn btn-primary no-margin pull-right">${_('Update commits')}</a>
                         % else:
                           <a class="tooltip btn disabled pull-right" disabled="disabled" title="${_('Update is disabled for current view')}">${_('Update commits')}</a>
                         % endif
@@ -473,7 +500,7 b''
                                 <tr id="row-${commit.raw_id}" commit_id="${commit.raw_id}" class="compare_select">
                                 <td>
                                     <div class="commit-change-indicator color-${c_type}-border">
-                                      <div class="commit-change-content color-${c_type} tooltip" title="${cc_title}">
+                                      <div class="commit-change-content color-${c_type} tooltip" title="${h.tooltip(cc_title)}">
                                         ${c_type.upper()}
                                       </div>
                                     </div>
@@ -615,9 +642,10 b''
         versionController = new VersionController();
         versionController.init();
 
+        reviewersController = new ReviewersController();
 
         $(function(){
-            ReviewerAutoComplete('user');
+
             // custom code mirror
             var codeMirrorInstance = initPullRequestsCodeMirror('#pr-description-input');
 
@@ -655,13 +683,13 b''
             var ReviewersPanel = {
               editButton: $('#open_edit_reviewers'),
               closeButton: $('#close_edit_reviewers'),
-              addButton: $('#add_reviewer_input'),
-              removeButtons: $('.reviewer_member_remove'),
+              addButton: $('#add_reviewer'),
+              removeButtons: $('.reviewer_member_remove,.reviewer_member_mandatory_remove,.reviewer_member_mandatory'),
 
               init: function() {
-                var that = this;
-                this.editButton.on('click', function(e) { that.edit(); });
-                this.closeButton.on('click', function(e) { that.close(); });
+                var self = this;
+                this.editButton.on('click', function(e) { self.edit(); });
+                this.closeButton.on('click', function(e) { self.close(); });
               },
 
               edit: function(event) {
@@ -669,6 +697,9 b''
                 this.closeButton.show();
                 this.addButton.show();
                 this.removeButtons.css('visibility', 'visible');
+                // review rules
+                reviewersController.loadReviewRules(
+                    ${c.pull_request.reviewer_data_json | n});
               },
 
               close: function(event) {
@@ -676,6 +707,8 b''
                 this.closeButton.hide();
                 this.addButton.hide();
                 this.removeButtons.css('visibility', 'hidden');
+                // hide review rules
+                reviewersController.hideReviewRules()
               }
             };
 
@@ -774,7 +807,8 b''
                 $(this).attr('disabled', 'disabled');
                 $(this).addClass('disabled');
                 $(this).html(_gettext('Saving...'));
-                updateReviewers(undefined, "${c.repo_name}", "${c.pull_request.pull_request_id}");
+                reviewersController.updateReviewers(
+                    "${c.repo_name}", "${c.pull_request.pull_request_id}");
             });
 
             $('#update_commits').on('click', function(e){
@@ -784,16 +818,13 b''
                 $(e.currentTarget).removeClass('btn-primary');
                 $(e.currentTarget).text(_gettext('Updating...'));
                 if(isDisabled){
-                    updateCommits("${c.repo_name}", "${c.pull_request.pull_request_id}");
+                    updateCommits(
+                        "${c.repo_name}", "${c.pull_request.pull_request_id}");
                 }
             });
             // fixing issue with caches on firefox
             $('#update_commits').removeAttr("disabled");
 
-            $('#close_pull_request').on('click', function(e){
-                closePullRequest("${c.repo_name}", "${c.pull_request.pull_request_id}");
-            });
-
             $('.show-inline-comments').on('click', function(e){
                 var boxid = $(this).attr('data-comment-id');
                 var button = $(this);
@@ -818,6 +849,8 b''
             // initial injection
             injectCloseAction();
 
+            ReviewerAutoComplete('#user');
+
         })
       </script>
 

rhodecode/templates/pullrequests/pullrequests.mako

@@ -45,12 +45,12 b''
     ##main
     <div class="sidebar">
         <ul class="nav nav-pills nav-stacked">
-          <li class="${'active' if c.active=='open' else ''}"><a href="${h.url('pullrequest_show_all',repo_name=c.repo_name,source=0)}">${_('Opened')}</a></li>
-          <li class="${'active' if c.active=='my' else ''}"><a href="${h.url('pullrequest_show_all',repo_name=c.repo_name,source=0,my=1)}">${_('Opened by me')}</a></li>
-          <li class="${'active' if c.active=='awaiting' else ''}"><a href="${h.url('pullrequest_show_all',repo_name=c.repo_name,source=0,awaiting_review=1)}">${_('Awaiting review')}</a></li>
-          <li class="${'active' if c.active=='awaiting_my' else ''}"><a href="${h.url('pullrequest_show_all',repo_name=c.repo_name,source=0,awaiting_my_review=1)}">${_('Awaiting my review')}</a></li>
-          <li class="${'active' if c.active=='closed' else ''}"><a href="${h.url('pullrequest_show_all',repo_name=c.repo_name,source=0,closed=1)}">${_('Closed')}</a></li>
-          <li class="${'active' if c.active=='source' else ''}"><a href="${h.url('pullrequest_show_all',repo_name=c.repo_name,source=1)}">${_('From this repo')}</a></li>
+          <li class="${'active' if c.active=='open' else ''}"><a href="${h.route_path('pullrequest_show_all',repo_name=c.repo_name,         _query={'source':0})}">${_('Opened')}</a></li>
+          <li class="${'active' if c.active=='my' else ''}"><a href="${h.route_path('pullrequest_show_all',repo_name=c.repo_name,           _query={'source':0,'my':1})}">${_('Opened by me')}</a></li>
+          <li class="${'active' if c.active=='awaiting' else ''}"><a href="${h.route_path('pullrequest_show_all',repo_name=c.repo_name,     _query={'source':0,'awaiting_review':1})}">${_('Awaiting review')}</a></li>
+          <li class="${'active' if c.active=='awaiting_my' else ''}"><a href="${h.route_path('pullrequest_show_all',repo_name=c.repo_name,  _query={'source':0,'awaiting_my_review':1})}">${_('Awaiting my review')}</a></li>
+          <li class="${'active' if c.active=='closed' else ''}"><a href="${h.route_path('pullrequest_show_all',repo_name=c.repo_name,       _query={'source':0,'closed':1})}">${_('Closed')}</a></li>
+          <li class="${'active' if c.active=='source' else ''}"><a href="${h.route_path('pullrequest_show_all',repo_name=c.repo_name,       _query={'source':1})}">${_('From this repo')}</a></li>
         </ul>
     </div>
 
@@ -73,7 +73,7 b''
               %endif
           </h3>
         </div>
-        <div class="panel-body">
+        <div class="panel-body panel-body-min-height">
           <table id="pull_request_list_table" class="display"></table>
         </div>
       </div>
@@ -83,14 +83,24 b''
 
 <script type="text/javascript">
 $(document).ready(function() {
+
+    var $pullRequestListTable = $('#pull_request_list_table');
+
     // object list
-    $('#pull_request_list_table').DataTable({
-      data: ${c.data|n},
-      processing: false,
+    $pullRequestListTable.DataTable({
+      processing: true,
       serverSide: true,
-      deferLoading: ${c.records_total},
-      ajax: "",
-      dom: 'tp',
+      ajax: {
+          "url": "${h.route_path('pullrequest_show_all_data', repo_name=c.repo_name)}",
+          "data": function (d) {
+              d.source = "${c.source}";
+              d.closed = "${c.closed}";
+              d.my = "${c.my}";
+              d.awaiting_review = "${c.awaiting_review}";
+              d.awaiting_my_review = "${c.awaiting_my_review}";
+          }
+      },
+      dom: 'rtp',
       pageLength: ${c.visual.dashboard_items},
       order: [[ 1, "desc" ]],
       columns: [
@@ -109,6 +119,7 b''
       ],
       language: {
             paginate: DEFAULT_GRID_PAGINATION,
+            sProcessing: _gettext('loading...'),
             emptyTable: _gettext("No pull requests available yet.")
       },
       "drawCallback": function( settings, json ) {
@@ -120,13 +131,16 b''
           }
       }
     });
-});
-$('#pull_request_list_table').on('xhr.dt', function(e, settings, json, xhr){
-    $('#pull_request_list_table').css('opacity', 1);
+
+    $pullRequestListTable.on('xhr.dt', function(e, settings, json, xhr){
+        $pullRequestListTable.css('opacity', 1);
+    });
+
+    $pullRequestListTable.on('preXhr.dt', function(e, settings, data){
+        $pullRequestListTable.css('opacity', 0.3);
+    });
+
 });
 
-$('#pull_request_list_table').on('preXhr.dt', function(e, settings, data){
-    $('#pull_request_list_table').css('opacity', 0.3);
-});
 </script>
 </%def>

rhodecode/templates/register.mako

@@ -14,7 +14,7 b''
         <div id="header-inner" class="title">
             <div id="logo">
                 <div class="logo-wrapper">
-                    <a href="${h.url('home')}"><img src="${h.asset('images/rhodecode-logo-white-216x60.png')}" alt="RhodeCode"/></a>
+                    <a href="${h.route_path('home')}"><img src="${h.asset('images/rhodecode-logo-white-216x60.png')}" alt="RhodeCode"/></a>
                 </div>
                 %if c.rhodecode_name:
                 <div class="branding"> ${h.branding(c.rhodecode_name)}</div>

rhodecode/templates/search/search.mako

@@ -45,7 +45,7 b''
         <div class="title">
             ${self.repo_page_title(c.rhodecode_db_repo)}
         </div>
-        ${h.form(h.url('search_repo_home',repo_name=c.repo_name),method='get')}
+        ${h.form(h.route_path('search_repo',repo_name=c.repo_name),method='get')}
     %else:
         <!-- box / title -->
         <div class="title">
@@ -53,7 +53,7 b''
             <ul class="links">&nbsp;</ul>
         </div>
         <!-- end box / title -->
-        ${h.form(h.url('search'),method='get')}
+        ${h.form(h.route_path('search'), method='get')}
     %endif
     <div class="form search-form">
         <div class="fields">
@@ -63,6 +63,7 b''
             ${h.select('type',c.search_type,[('content',_('File contents')), ('commit',_('Commit messages')), ('path',_('File names')),],id='id_search_type')}
             <input type="submit" value="${_('Search')}" class="btn"/>
             <br/>
+
             <div class="search-feedback-items">
             % for error in c.errors:
               <span class="error-message">
@@ -71,10 +72,16 b''
                   % endfor
               </span>
             % endfor
+            <div class="field">
+                <p class="filterexample" style="position: inherit" onclick="$('#search-help').toggle()">${_('Example Queries')}</p>
+                <pre id="search-help" style="display: none">${h.tooltip(h.search_filter_help(c.searcher))}</pre>
+            </div>
+
             <div class="field">${c.runtime}</div>
             </div>
         </div>
     </div>
+
     ${h.end_form()}
     <div class="search">
     % if c.search_type == 'content':

rhodecode/templates/search/search_commit.mako

@@ -27,7 +27,7 b''
                     %elif h.get_repo_type_by_name(entry.get('repository')) == 'svn':
                         <i class="icon-svn"></i>
                     %endif
-                    ${h.link_to(entry['repository'], h.url('summary_home',repo_name=entry['repository']))}
+                    ${h.link_to(entry['repository'], h.route_path('repo_summary',repo_name=entry['repository']))}
                 </td>
                 <td class="td-commit">
                     ${h.link_to(h._shorten_commit_id(entry['commit_id']),

rhodecode/templates/search/search_content.mako

@@ -49,12 +49,12 b' for line_number in matching_lines:'
             %elif h.get_repo_type_by_name(entry.get('repository')) == 'svn':
                 <i class="icon-svn"></i>
             %endif
-            ${h.link_to(entry['repository'], h.url('summary_home',repo_name=entry['repository']))}
+            ${h.link_to(entry['repository'], h.route_path('repo_summary',repo_name=entry['repository']))}
           </h2>
           <div class="stats">
             ${h.link_to(h.literal(entry['f_path']), h.url('files_home',repo_name=entry['repository'],revision=entry.get('commit_id', 'tip'),f_path=entry['f_path']))}
             %if entry.get('lines'):
-              | ${entry.get('lines', 0.)} ${ungettext('line', 'lines', entry.get('lines', 0.))}
+              | ${entry.get('lines', 0.)} ${_ungettext('line', 'lines', entry.get('lines', 0.))}
             %endif
             %if entry.get('size'):
               | ${h.format_byte_size_binary(entry['size'])}

rhodecode/templates/search/search_path.mako

@@ -16,7 +16,7 b''
                     %elif h.get_repo_type_by_name(entry.get('repository')) == 'svn':
                         <i class="icon-svn"></i>
                     %endif
-                    ${h.link_to(entry['repository'], h.url('summary_home',repo_name=entry['repository']))}
+                    ${h.link_to(entry['repository'], h.route_path('repo_summary',repo_name=entry['repository']))}
                 </td>
                 <td class="td-componentname">
                     ${h.link_to(h.literal(entry['f_path']),

rhodecode/templates/summary/base.mako

@@ -10,8 +10,8 b''
 
 
 <%def name="head_extra()">
-    <link href="${h.url('atom_feed_home',repo_name=c.rhodecode_db_repo.repo_name,auth_token=c.rhodecode_user.feed_token)}" rel="alternate" title="${_('%s ATOM feed') % c.repo_name}" type="application/atom+xml" />
-    <link href="${h.url('rss_feed_home',repo_name=c.rhodecode_db_repo.repo_name,auth_token=c.rhodecode_user.feed_token)}" rel="alternate" title="${_('%s RSS feed') % c.repo_name}" type="application/rss+xml" />
+    <link href="${h.url('atom_feed_home',repo_name=c.rhodecode_db_repo.repo_name,auth_token=c.rhodecode_user.feed_token)}" rel="alternate" title="${h.tooltip(_('%s ATOM feed') % c.repo_name)}" type="application/atom+xml" />
+    <link href="${h.url('rss_feed_home',repo_name=c.rhodecode_db_repo.repo_name,auth_token=c.rhodecode_user.feed_token)}" rel="alternate" title="${h.tooltip(_('%s RSS feed') % c.repo_name)}" type="application/rss+xml" />
 </%def>
 
 

rhodecode/templates/summary/components.mako

@@ -1,28 +1,28 b''
 <%def name="refs_counters(branches, closed_branches, tags, bookmarks)">
     <span class="branchtag tag">
-    <a href="${h.url('branches_home',repo_name=c.repo_name)}" class="childs">
-      <i class="icon-branch"></i>${ungettext(
+    <a href="${h.route_path('branches_home',repo_name=c.repo_name)}" class="childs">
+      <i class="icon-branch"></i>${_ungettext(
       '%(num)s Branch','%(num)s Branches', len(branches)) % {'num': len(branches)}}</a>
     </span>
 
     %if closed_branches:
     <span class="branchtag tag">
-    <a href="${h.url('branches_home',repo_name=c.repo_name)}" class="childs">
-      <i class="icon-branch"></i>${ungettext(
+    <a href="${h.route_path('branches_home',repo_name=c.repo_name)}" class="childs">
+      <i class="icon-branch"></i>${_ungettext(
       '%(num)s Closed Branch', '%(num)s Closed Branches', len(closed_branches)) % {'num': len(closed_branches)}}</a>
     </span>
     %endif
 
     <span class="tagtag tag">
-    <a href="${h.url('tags_home',repo_name=c.repo_name)}" class="childs">
-        <i class="icon-tag"></i>${ungettext(
+    <a href="${h.route_path('tags_home',repo_name=c.repo_name)}" class="childs">
+        <i class="icon-tag"></i>${_ungettext(
         '%(num)s Tag', '%(num)s Tags', len(tags)) % {'num': len(tags)}}</a>
     </span>
 
     %if bookmarks:
     <span class="booktag tag">
-    <a href="${h.url('bookmarks_home',repo_name=c.repo_name)}" class="childs">
-        <i class="icon-bookmark"></i>${ungettext(
+    <a href="${h.route_path('bookmarks_home',repo_name=c.repo_name)}" class="childs">
+        <i class="icon-bookmark"></i>${_ungettext(
         '%(num)s Bookmark', '%(num)s Bookmarks', len(bookmarks)) % {'num': len(bookmarks)}}</a>
     </span>
     %endif
@@ -53,7 +53,7 b''
                 <input type="text" class="input-monospace" id="clone_url_id" disabled value="${c.clone_repo_url_id}" style="display: none;"/>
                 <a id="clone_by_name" class="clone" style="display: none;">${_('Show by Name')}</a>
                 <a id="clone_by_id" class="clone">${_('Show by ID')}</a>
-                <p class="help-block">${_('SVN Protocol is disabled. To enable it, see the')} <a href="${h.url('enterprise_svn_setup')}" target="_blank">${_('documentation here')}</a>.</p>
+                <p class="help-block">${_('SVN Protocol is disabled. To enable it, see the')} <a href="${h.route_url('enterprise_svn_setup')}" target="_blank">${_('documentation here')}</a>.</p>
             </div>
           %else:
             <div class="left-label">
@@ -92,15 +92,15 b''
 
                   ## commits
                   % if commit_rev == -1:
-                      ${ungettext('%(num)s Commit', '%(num)s Commits', 0) % {'num': 0}},
+                      ${_ungettext('%(num)s Commit', '%(num)s Commits', 0) % {'num': 0}},
                   % else:
                       <a href="${h.url('changelog_home', repo_name=c.repo_name)}">
-                        ${ungettext('%(num)s Commit', '%(num)s Commits', commit_rev) % {'num': commit_rev}}</a>,
+                        ${_ungettext('%(num)s Commit', '%(num)s Commits', commit_rev) % {'num': commit_rev}}</a>,
                   % endif
 
                   ## forks
                   <a title="${_('Number of Repository Forks')}" href="${h.url('repo_forks_home', repo_name=c.repo_name)}">
-                     ${c.repository_forks} ${ungettext('Fork', 'Forks', c.repository_forks)}</a>,
+                     ${c.repository_forks} ${_ungettext('Fork', 'Forks', c.repository_forks)}</a>,
 
                   ## repo size
                   % if commit_rev == -1:
@@ -145,7 +145,7 b''
                       ${_('Statistics are disabled for this repository')}
                   </span>
                   % if h.HasPermissionAll('hg.admin')('enable stats on from summary'):
-                     , ${h.link_to(_('enable statistics'),h.url('edit_repo',repo_name=c.repo_name, anchor='repo_enable_statistics'))}
+                     , ${h.link_to(_('enable statistics'),h.route_path('edit_repo',repo_name=c.repo_name, anchor='repo_enable_statistics'))}
                   % endif
               % endif
             </div>
@@ -169,7 +169,7 b''
                         ${_('Downloads are disabled for this repository')}
                     </span>
                     % if h.HasPermissionAll('hg.admin')('enable downloads on from summary'):
-                       , ${h.link_to(_('enable downloads'),h.url('edit_repo',repo_name=c.repo_name, anchor='repo_enable_downloads'))}
+                       , ${h.link_to(_('enable downloads'),h.route_path('edit_repo',repo_name=c.repo_name, anchor='repo_enable_downloads'))}
                     % endif
                 % else:
                     <span class="enabled">

rhodecode/templates/summary/missing_requirements.mako

@@ -14,8 +14,14 b''
 
   <div class="alert alert-dismissable alert-warning">
     <strong>Missing requirements</strong>
-    These commits cannot be displayed, because this repository uses the Mercurial largefiles extension, which was not enabled.
-    Please <a href="${h.url('repo_vcs_settings', repo_name=c.repo_name)}">enable this extension in settings</a>, or contact the repository owner for help.
+    Commits cannot be displayed, because this repository uses one or more extensions, which was not enabled. <br/>
+    Please <a href="${h.url('repo_vcs_settings', repo_name=c.repo_name)}">enable extension in settings</a>, or contact the repository owner for help.
+    Missing extensions could be:
+<pre>
+
+- Mercurial largefiles
+- Git LFS
+</pre>
   </div>
 
 </%def>

rhodecode/templates/summary/summary.mako

@@ -36,7 +36,7 b''
      %endif
     <div class="table">
         <div id="shortlog_data">
-            <%include file='../changelog/changelog_summary_data.mako'/>
+            <%include file='summary_commits.mako'/>
         </div>
     </div>
 </div>
@@ -44,13 +44,13 b''
 %if c.readme_data:
 <div id="readme" class="anchor">
 <div class="box" >
-    <div class="title" title="${_('Readme file from commit %s:%s') % (c.rhodecode_db_repo.landing_rev[0], c.rhodecode_db_repo.landing_rev[1])}">
+    <div class="title" title="${h.tooltip(_('Readme file from commit %s:%s') % (c.rhodecode_db_repo.landing_rev[0], c.rhodecode_db_repo.landing_rev[1]))}">
         <h3 class="breadcrumbs">
             <a href="${h.url('files_home',repo_name=c.repo_name,revision='tip',f_path=c.readme_file)}">${c.readme_file}</a>
         </h3>
     </div>
     <div class="readme codeblock">
-      <div class="readme_box markdown-block">
+      <div class="readme_box">
         ${c.readme_data|n}
       </div>
     </div>
@@ -110,8 +110,7 b''
 
         var callback = function (data) {
             % if c.show_stats:
-                showRepoStats(
-                    'lang_stats', data);
+                showRepoStats('lang_stats', data);
             % endif
         };
 

rhodecode/templates/tags/tags_data.mako

@@ -9,7 +9,7 b''
 </%def>
 
 <%def name="name(name, files_url)">
-     <span class="tagtag tag" title="${_('Tag %s') % (name,)}">
+     <span class="tagtag tag" title="${h.tooltip(_('Tag %s') % (name,))}">
      <a href="${files_url}"><i class="icon-tag"></i>${name}</a>
      </span>
 </%def>
@@ -19,11 +19,11 b''
 </%def>
 
 <%def name="author(author)">
-    <span class="tooltip" title="${author}">${h.link_to_user(author)}</span>
+    <span class="tooltip" title="${h.tooltip(author)}">${h.link_to_user(author)}</span>
 </%def>
 
 <%def name="commit(message, commit_id, commit_idx)">
     <div>
-        <pre><a title="${message}" href="${h.url('files_home',repo_name=c.repo_name,revision=commit_id)}">r${commit_idx}:${h.short_id(commit_id)}</a></pre>
+        <pre><a title="${h.tooltip(message)}" href="${h.url('files_home',repo_name=c.repo_name,revision=commit_id)}">r${commit_idx}:${h.short_id(commit_id)}</a></pre>
     </div>
 </%def>

rhodecode/templates/users/user_profile.mako

@@ -35,7 +35,7 b''
                 ${_('First name')}:
             </div>
             <div class="right-content">
-                ${c.user.firstname}
+                ${c.user.first_name}
             </div>
         </div>
         <div class="fieldset">
@@ -43,7 +43,7 b''
                 ${_('Last name')}:
             </div>
             <div class="right-content">
-                ${c.user.lastname}
+                ${c.user.last_name}
             </div>
         </div>
         <div class="fieldset">

rhodecode/tests/__init__.py

@@ -48,7 +48,6 b' from rhodecode.model.db import User'
 from rhodecode.lib import auth
 from rhodecode.lib.helpers import flash, link_to
 from rhodecode.lib.utils2 import safe_unicode, safe_str
-from rhodecode.tests.utils import get_session_from_response
 
 
 log = logging.getLogger(__name__)
@@ -56,7 +55,7 b' log = logging.getLogger(__name__)'
 __all__ = [
     'get_new_dir', 'TestController', 'SkipTest',
     'url', 'link_to', 'ldap_lib_installed', 'clear_all_caches',
-    'assert_session_flash', 'login_user',
+    'assert_session_flash', 'login_user', 'no_newline_id_generator',
     'TESTS_TMP_PATH', 'HG_REPO', 'GIT_REPO', 'SVN_REPO',
     'NEW_HG_REPO', 'NEW_GIT_REPO',
     'HG_FORK', 'GIT_FORK', 'TEST_USER_ADMIN_LOGIN', 'TEST_USER_ADMIN_PASS',
@@ -178,7 +177,7 b' def login_user_session('
     response = response.follow()
     assert response.status == '200 OK'
 
-    session = get_session_from_response(response)
+    session = response.get_session_from_response()
     assert 'rhodecode_user' in session
     rc_user = session['rhodecode_user']
     assert rc_user.get('username') == username
@@ -249,3 +248,17 b' def assert_session_flash_is_empty(respon'
         msg = 'flash messages are present in session:%s' % \
               response.session['flash'][0]
         pytest.fail(safe_str(msg))
+
+
+def no_newline_id_generator(test_name):
+    """
+    Generates a test name without spaces or newlines characters. Used for
+    nicer output of progress of test
+    """
+    org_name = test_name
+    test_name = test_name\
+        .replace('\n', '_N') \
+        .replace('\t', '_T') \
+        .replace(' ', '_S')
+
+    return test_name or 'test-with-empty-name'

rhodecode/tests/config/test_routing_links.py

@@ -18,23 +18,28 b''
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
-import mock
-
+import pytest
+import requests
 from rhodecode.config import routing_links
 
 
-def test_connect_redirection_links():
-    link_config = [
-        {"name": "example_link",
-         "external_target": "http://example.com",
-         "target": "https://rhodecode.com/r/v1/enterprise/example",
-         },
-    ]
+def check_connection():
+    try:
+        response = requests.get('https://rhodecode.com')
+        return response.status_code == 200
+    except Exception as e:
+        print(e)
+
+    return False
+
 
-    rmap = mock.Mock()
-    with mock.patch.object(routing_links, 'link_config', link_config):
-        routing_links.connect_redirection_links(rmap)
+connection_available = pytest.mark.skipif(
+    not check_connection(), reason="No outside internet connection available")
+
 
-    rmap.connect.assert_called_with(
-        link_config[0]['name'], link_config[0]['target'],
-        _static=True)
+@connection_available
+def test_connect_redirection_links():
+
+    for link_data in routing_links.link_config:
+        response = requests.get(link_data['target'])
+        assert response.url == link_data['external_target']

rhodecode/tests/config/test_sanitize_settings.py

@@ -21,6 +21,7 b''
 
 import pytest
 
+from rhodecode.tests import no_newline_id_generator
 from rhodecode.config.middleware import (
     _sanitize_vcs_settings, _bool_setting, _string_setting, _list_setting,
     _int_setting)
@@ -70,7 +71,7 b' class TestHelperFunctions(object):'
         (' hg\n git\n svn ', ['hg', 'git', 'svn']),
         (', hg , git , svn , ', ['', 'hg', 'git', 'svn', '']),
         ('cheese,free node,other', ['cheese', 'free node', 'other']),
-    ])
+    ], ids=no_newline_id_generator)
     def test_list_setting_helper(self, raw, expected):
         key = 'dummy-key'
         settings = {key: raw}

rhodecode/tests/controllers/test_repo_groups.py

@@ -64,7 +64,7 b' def test_repo_groups_load_defaults('
     personal_group = personal_group_with_parent
     controller._RepoGroupsController__load_defaults(True, personal_group)
 
-    expected_list = ['-1', personal_group.parent_group.group_id]
+    expected_list = [-1, personal_group.parent_group.group_id]
     returned_group_ids = [group[0] for group in c.repo_groups]
     assert returned_group_ids == expected_list
 
@@ -74,6 +74,6 b' def test_repo_groups_load_defaults_with_'
     personal_group = personal_group_with_parent
     controller._RepoGroupsController__load_defaults(True)
 
-    expected_list = sorted(['-1', personal_group.group_id])
+    expected_list = sorted([-1, personal_group.group_id])
     returned_group_ids = sorted([group[0] for group in c.repo_groups])
     assert returned_group_ids == expected_list

rhodecode/tests/events/test_pullrequest.py

@@ -42,7 +42,7 b' from rhodecode.events import ('
     PullRequestMergeEvent,
     PullRequestCloseEvent,
 ])
-def test_pullrequest_events_serialized(pr_util, EventClass):
+def test_pullrequest_events_serialized(EventClass, pr_util, config_stub):
     pr = pr_util.create_pull_request()
     event = EventClass(pr)
     data = event.as_dict()
@@ -50,16 +50,19 b' def test_pullrequest_events_serialized(p'
     assert data['repo']['repo_name'] == pr.target_repo.repo_name
     assert data['pullrequest']['pull_request_id'] == pr.pull_request_id
     assert data['pullrequest']['url']
+    assert data['pullrequest']['permalink_url']
+
 
 @pytest.mark.backends("git", "hg")
-def test_create_pull_request_events(pr_util):
+def test_create_pull_request_events(pr_util, config_stub):
     with EventCatcher() as event_catcher:
         pr_util.create_pull_request()
 
     assert PullRequestCreateEvent in event_catcher.events_types
 
+
 @pytest.mark.backends("git", "hg")
-def test_pullrequest_comment_events_serialized(pr_util):
+def test_pullrequest_comment_events_serialized(pr_util, config_stub):
     pr = pr_util.create_pull_request()
     comment = CommentsModel().get_comments(
         pr.target_repo.repo_id, pull_request=pr)[0]
@@ -69,11 +72,12 b' def test_pullrequest_comment_events_seri'
     assert data['repo']['repo_name'] == pr.target_repo.repo_name
     assert data['pullrequest']['pull_request_id'] == pr.pull_request_id
     assert data['pullrequest']['url']
+    assert data['pullrequest']['permalink_url']
     assert data['comment']['text'] == comment.text
 
 
 @pytest.mark.backends("git", "hg")
-def test_close_pull_request_events(pr_util, user_admin):
+def test_close_pull_request_events(pr_util, user_admin, config_stub):
     pr = pr_util.create_pull_request()
 
     with EventCatcher() as event_catcher:
@@ -83,7 +87,7 b' def test_close_pull_request_events(pr_ut'
 
 
 @pytest.mark.backends("git", "hg")
-def test_close_pull_request_with_comment_events(pr_util, user_admin):
+def test_close_pull_request_with_comment_events(pr_util, user_admin, config_stub):
     pr = pr_util.create_pull_request()
 
     with EventCatcher() as event_catcher:

rhodecode/tests/events/test_repo.py

@@ -43,6 +43,7 b' def scm_extras(user_regular, repo_stub):'
         'config': '',
         'server_url': 'http://example.com',
         'make_lock': None,
+        'user-agent': 'some-client',
         'locked_by': [None],
         'commit_ids': ['a' * 40] * 3,
         'is_shadow_repo': False,
@@ -55,28 +56,29 b' def scm_extras(user_regular, repo_stub):'
     RepoPreCreateEvent, RepoCreateEvent,
     RepoPreDeleteEvent, RepoDeleteEvent,
 ])
-def test_repo_events_serialized(repo_stub, EventClass):
+def test_repo_events_serialized(config_stub, repo_stub, EventClass):
     event = EventClass(repo_stub)
     data = event.as_dict()
     assert data['name'] == EventClass.name
     assert data['repo']['repo_name'] == repo_stub.repo_name
     assert data['repo']['url']
+    assert data['repo']['permalink_url']
 
 
 @pytest.mark.parametrize('EventClass', [
     RepoPrePullEvent, RepoPullEvent, RepoPrePushEvent
 ])
-def test_vcs_repo_events_serialize(repo_stub, scm_extras, EventClass):
+def test_vcs_repo_events_serialize(config_stub, repo_stub, scm_extras, EventClass):
     event = EventClass(repo_name=repo_stub.repo_name, extras=scm_extras)
     data = event.as_dict()
     assert data['name'] == EventClass.name
     assert data['repo']['repo_name'] == repo_stub.repo_name
     assert data['repo']['url']
-
+    assert data['repo']['permalink_url']
 
 
 @pytest.mark.parametrize('EventClass', [RepoPushEvent])
-def test_vcs_repo_push_event_serialize(repo_stub, scm_extras, EventClass):
+def test_vcs_repo_push_event_serialize(config_stub, repo_stub, scm_extras, EventClass):
     event = EventClass(repo_name=repo_stub.repo_name,
                        pushed_commit_ids=scm_extras['commit_ids'],
                        extras=scm_extras)
@@ -84,6 +86,7 b' def test_vcs_repo_push_event_serialize(r'
     assert data['name'] == EventClass.name
     assert data['repo']['repo_name'] == repo_stub.repo_name
     assert data['repo']['url']
+    assert data['repo']['permalink_url']
 
 
 def test_create_delete_repo_fires_events(backend):

rhodecode/tests/fixture.py

@@ -286,6 +286,10 b' class Fixture(object):'
             gr = UserGroup.get_by_group_name(group_name=name)
             if gr:
                 return gr
+        # map active flag to the real attribute. For API consistency of fixtures
+        if 'active' in kwargs:
+            kwargs['users_group_active'] = kwargs['active']
+            del kwargs['active']
         form_data = self._get_user_group_create_params(name, **kwargs)
         owner = kwargs.get('cur_user', TEST_USER_ADMIN_LOGIN)
         user_group = UserGroupModel().create(

rhodecode/tests/functional/test_admin_gists.py

@@ -28,7 +28,6 b' from rhodecode.model.meta import Session'
 from rhodecode.tests import (
     TEST_USER_ADMIN_LOGIN, TEST_USER_REGULAR_LOGIN, TEST_USER_REGULAR_PASS,
     TestController, assert_session_flash, url)
-from rhodecode.tests.utils import AssertResponse
 
 
 class GistUtility(object):
@@ -273,7 +272,7 b' class TestGistsController(TestController'
 
         response.mustcontain('added file: gist-show-me<')
 
-        assert_response = AssertResponse(response)
+        assert_response = response.assert_response()
         assert_response.element_equals_to(
             'div.rc-user span.user',
             '<a href="/_profiles/test_admin">test_admin</a></span>')
@@ -296,7 +295,7 b' class TestGistsController(TestController'
         response = self.app.get(url('gist', gist_id=gist.gist_access_id))
         response.mustcontain('added file: gist-show-me-only-when-im-logged-in')
 
-        assert_response = AssertResponse(response)
+        assert_response = response.assert_response()
         assert_response.element_equals_to(
             'div.rc-user span.user',
             '<a href="/_profiles/test_admin">test_admin</a></span>')
@@ -337,9 +336,7 b' class TestGistsController(TestController'
 
     def test_user_first_name_is_escaped(self, user_util, create_gist):
         xss_atack_string = '"><script>alert(\'First Name\')</script>'
-        xss_escaped_string = (
-            '&#34;&gt;&lt;script&gt;alert(&#39;First Name&#39;)&lt;/script'
-            '&gt;')
+        xss_escaped_string = h.html_escape(h.escape(xss_atack_string))
         password = 'test'
         user = user_util.create_user(
             firstname=xss_atack_string, password=password)
@@ -349,8 +346,7 b' class TestGistsController(TestController'
 
     def test_user_last_name_is_escaped(self, user_util, create_gist):
         xss_atack_string = '"><script>alert(\'Last Name\')</script>'
-        xss_escaped_string = (
-            '&#34;&gt;&lt;script&gt;alert(&#39;Last Name&#39;)&lt;/script&gt;')
+        xss_escaped_string = h.html_escape(h.escape(xss_atack_string))
         password = 'test'
         user = user_util.create_user(
             lastname=xss_atack_string, password=password)

rhodecode/tests/functional/test_admin_my_account.py

@@ -23,14 +23,19 b' import pytest'
 from rhodecode.lib import helpers as h
 from rhodecode.model.db import User, UserFollowing, Repository
 from rhodecode.tests import (
-    TestController, url, TEST_USER_ADMIN_LOGIN, TEST_USER_REGULAR_EMAIL,
-    assert_session_flash)
+    TestController, url, TEST_USER_ADMIN_LOGIN, assert_session_flash)
 from rhodecode.tests.fixture import Fixture
 from rhodecode.tests.utils import AssertResponse
 
 fixture = Fixture()
 
 
+def route_path(name, **kwargs):
+    return {
+        'home': '/',
+    }[name].format(**kwargs)
+
+
 class TestMyAccountController(TestController):
     test_user_1 = 'testme'
     test_user_1_password = '0jd83nHNS/d23n'
@@ -41,7 +46,7 b' class TestMyAccountController(TestContro'
         fixture.destroy_users(cls.destroy_users)
 
     def test_logout_form_contains_csrf(self, autologin_user, csrf_token):
-        response = self.app.get(url('home'))
+        response = self.app.get(route_path('home'))
         assert_response = AssertResponse(response)
         element = assert_response.get_element('.logout #csrf_token')
         assert element.value == csrf_token
@@ -52,26 +57,6 b' class TestMyAccountController(TestContro'
 
         response.mustcontain('value="test_admin')
 
-    def test_my_account_my_repos(self):
-        self.log_user()
-        response = self.app.get(url('my_account_repos'))
-        repos = Repository.query().filter(
-            Repository.user == User.get_by_username(
-                TEST_USER_ADMIN_LOGIN)).all()
-        for repo in repos:
-            response.mustcontain('"name_raw": "%s"' % repo.repo_name)
-
-    def test_my_account_my_watched(self):
-        self.log_user()
-        response = self.app.get(url('my_account_watched'))
-
-        repos = UserFollowing.query().filter(
-            UserFollowing.user == User.get_by_username(
-                TEST_USER_ADMIN_LOGIN)).all()
-        for repo in repos:
-            response.mustcontain(
-                '"name_raw": "%s"' % repo.follows_repository.repo_name)
-
     @pytest.mark.backends("git", "hg")
     def test_my_account_my_pullrequests(self, pr_util):
         self.log_user()
@@ -84,57 +69,6 b' class TestMyAccountController(TestContro'
         response.mustcontain('"name_raw": %s' % pr.pull_request_id)
         response.mustcontain('TestMyAccountPR')
 
-    def test_my_account_my_emails(self):
-        self.log_user()
-        response = self.app.get(url('my_account_emails'))
-        response.mustcontain('No additional emails specified')
-
-    def test_my_account_my_emails_add_existing_email(self):
-        self.log_user()
-        response = self.app.get(url('my_account_emails'))
-        response.mustcontain('No additional emails specified')
-        response = self.app.post(url('my_account_emails'),
-                                 {'new_email': TEST_USER_REGULAR_EMAIL,
-                                  'csrf_token': self.csrf_token})
-        assert_session_flash(response, 'This e-mail address is already taken')
-
-    def test_my_account_my_emails_add_mising_email_in_form(self):
-        self.log_user()
-        response = self.app.get(url('my_account_emails'))
-        response.mustcontain('No additional emails specified')
-        response = self.app.post(url('my_account_emails'),
-                                 {'csrf_token': self.csrf_token})
-        assert_session_flash(response, 'Please enter an email address')
-
-    def test_my_account_my_emails_add_remove(self):
-        self.log_user()
-        response = self.app.get(url('my_account_emails'))
-        response.mustcontain('No additional emails specified')
-
-        response = self.app.post(url('my_account_emails'),
-                                 {'new_email': '[e-mail]',
-                                  'csrf_token': self.csrf_token})
-
-        response = self.app.get(url('my_account_emails'))
-
-        from rhodecode.model.db import UserEmailMap
-        email_id = UserEmailMap.query().filter(
-            UserEmailMap.user == User.get_by_username(
-                TEST_USER_ADMIN_LOGIN)).filter(
-                    UserEmailMap.email == '[e-mail]').one().email_id
-
-        response.mustcontain('[e-mail]')
-        response.mustcontain('<input id="del_email_id" name="del_email_id" '
-                             'type="hidden" value="%s" />' % email_id)
-
-        response = self.app.post(
-            url('my_account_emails'), {
-                'del_email_id': email_id, '_method': 'delete',
-                'csrf_token': self.csrf_token})
-        assert_session_flash(response, 'Removed email address from user account')
-        response = self.app.get(url('my_account_emails'))
-        response.mustcontain('No additional emails specified')
-
     @pytest.mark.parametrize(
         "name, attrs", [
             ('firstname', {'firstname': 'new_username'}),

rhodecode/tests/functional/test_admin_permissions.py

@@ -25,6 +25,24 b' from rhodecode.tests import ('
     TestController, url, clear_all_caches, assert_session_flash)
 
 
+def route_path(name, params=None, **kwargs):
+    import urllib
+    from rhodecode.apps._base import ADMIN_PREFIX
+
+    base_url = {
+        'edit_user_ips':
+            ADMIN_PREFIX + '/users/{user_id}/edit/ips',
+        'edit_user_ips_add':
+            ADMIN_PREFIX + '/users/{user_id}/edit/ips/new',
+        'edit_user_ips_delete':
+            ADMIN_PREFIX + '/users/{user_id}/edit/ips/delete',
+    }[name].format(**kwargs)
+
+    if params:
+        base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
+    return base_url
+
+
 class TestAdminPermissionsController(TestController):
 
     @pytest.fixture(scope='class', autouse=True)
@@ -181,10 +199,9 b' class TestAdminPermissionsController(Tes'
 
         # ADD
         default_user_id = User.get_default_user().user_id
-        response = self.app.post(
-            url('edit_user_ips', user_id=default_user_id),
-            params={'new_ip': '127.0.0.0/24', '_method': 'put',
-                    'csrf_token': self.csrf_token})
+        self.app.post(
+            route_path('edit_user_ips_add', user_id=default_user_id),
+            params={'new_ip': '127.0.0.0/24', 'csrf_token': self.csrf_token})
 
         response = self.app.get(url('admin_permissions_ips'))
         response.mustcontain('127.0.0.0/24')
@@ -196,9 +213,11 b' class TestAdminPermissionsController(Tes'
                                              default_user_id).first().ip_id
 
         response = self.app.post(
-            url('edit_user_ips', user_id=default_user_id),
-            params={'_method': 'delete', 'del_ip_id': del_ip_id,
-                    'csrf_token': self.csrf_token})
+            route_path('edit_user_ips_delete', user_id=default_user_id),
+            params={'del_ip_id': del_ip_id, 'csrf_token': self.csrf_token})
+
+        assert_session_flash(response, 'Removed ip address from user whitelist')
+
         clear_all_caches()
         response = self.app.get(url('admin_permissions_ips'))
         response.mustcontain('All IP addresses are allowed')

rhodecode/tests/functional/test_admin_repo_groups.py

@@ -31,6 +31,7 b' from rhodecode.tests.fixture import Fixt'
 fixture = Fixture()
 
 
+
 def test_update(app, csrf_token, autologin_user, user_util):
     repo_group = user_util.create_repo_group()
     description = 'description for newly created repo group'
@@ -123,11 +124,13 b' class _BaseTest(TestController):'
         # run the check page that triggers the flash message
         # response = self.app.get(url('repo_check_home', repo_name=repo_name))
         # assert response.json == {u'result': True}
+        repo_gr_url = h.route_path(
+            'repo_group_home', repo_group_name=repo_group_name)
+
         assert_session_flash(
             response,
-            u'Created repository group <a href="%s">%s</a>' % (
-                h.url('repo_group_home', group_name=repo_group_name),
-                repo_group_name_unicode))
+            'Created repository group <a href="%s">%s</a>' % (
+                repo_gr_url, repo_group_name_unicode))
 
         # # test if the repo group was created in the database
         new_repo_group = RepoGroupModel()._get_repo_group(
@@ -138,8 +141,7 b' class _BaseTest(TestController):'
         assert new_repo_group.group_description == description
 
         # test if the repository is visible in the list ?
-        response = self.app.get(
-            url('repo_group_home', group_name=repo_group_name))
+        response = self.app.get(repo_gr_url)
         response.mustcontain(repo_group_name)
 
         # test if the repository group was created on filesystem
@@ -173,7 +175,7 b' class _BaseTest(TestController):'
             assert_session_flash(
                 response,
                 u'Created repository group <a href="%s">%s</a>' % (
-                    h.url('repo_group_home', group_name=expected_group_name),
+                    h.route_path('repo_group_home', repo_group_name=expected_group_name),
                     expected_group_name_unicode))
         finally:
             RepoGroupModel().delete(expected_group_name_unicode)
@@ -199,6 +201,13 b' class TestRepoGroupsControllerGIT(_BaseT'
     REPO_TYPE = 'git'
 
 
+class TestRepoGroupsControllerNonAsciiGit(_BaseTest):
+    REPO_GROUP = None
+    NEW_REPO_GROUP = 'git_repo_ąć'
+    REPO = GIT_REPO
+    REPO_TYPE = 'git'
+
+
 class TestRepoGroupsControllerHG(_BaseTest):
     REPO_GROUP = None
     NEW_REPO_GROUP = 'hg_repo'

rhodecode/tests/functional/test_admin_repos.py

@@ -25,9 +25,9 b' import pytest'
 
 from rhodecode.lib import auth
 from rhodecode.lib.utils2 import safe_str, str2bool
-from rhodecode.lib.vcs.exceptions import RepositoryRequirementError
-from rhodecode.model.db import Repository, RepoGroup, UserRepoToPerm, User,\
-    Permission
+from rhodecode.lib import helpers as h
+from rhodecode.model.db import (
+    Repository, RepoGroup, UserRepoToPerm, User, Permission)
 from rhodecode.model.meta import Session
 from rhodecode.model.repo import RepoModel
 from rhodecode.model.repo_group import RepoGroupModel
@@ -44,7 +44,7 b' fixture = Fixture()'
 
 
 @pytest.mark.usefixtures("app")
-class TestAdminRepos:
+class TestAdminRepos(object):
 
     def test_index(self):
         self.app.get(url('repos'))
@@ -63,13 +63,14 b' class TestAdminRepos:'
         assert_response.element_contains('#repo_type', 'svn')
         assert_response.element_contains('#repo_type', 'hg')
 
-    @pytest.mark.parametrize("suffix", [u'', u''], ids=['', 'non-ascii'])
+    @pytest.mark.parametrize("suffix",
+                             [u'', u'xxa'], ids=['', 'non-ascii'])
     def test_create(self, autologin_user, backend, suffix, csrf_token):
         repo_name_unicode = backend.new_repo_name(suffix=suffix)
         repo_name = repo_name_unicode.encode('utf8')
         description_unicode = u'description for newly created repo' + suffix
         description = description_unicode.encode('utf8')
-        self.app.post(
+        response = self.app.post(
             url('repos'),
             fixture._get_repo_create_params(
                 repo_private=False,
@@ -77,8 +78,7 b' class TestAdminRepos:'
                 repo_type=backend.alias,
                 repo_description=description,
                 csrf_token=csrf_token),
-            status=302
-            )
+            status=302)
 
         self.assert_repository_is_created_correctly(
             repo_name, description, backend)
@@ -368,85 +368,23 b' class TestAdminRepos:'
                 csrf_token=csrf_token))
         response.mustcontain('invalid clone url')
 
-    @pytest.mark.parametrize("suffix", [u'', u'ąęł'], ids=['', 'non-ascii'])
-    def test_delete(self, autologin_user, backend, suffix, csrf_token):
-        repo = backend.create_repo(name_suffix=suffix)
-        repo_name = repo.repo_name
-
-        response = self.app.post(url('repo', repo_name=repo_name),
-                                 params={'_method': 'delete',
-                                         'csrf_token': csrf_token})
-        assert_session_flash(response, 'Deleted repository %s' % (repo_name))
-        response.follow()
-
-        # check if repo was deleted from db
-        assert RepoModel().get_by_repo_name(repo_name) is None
-        assert not repo_on_filesystem(repo_name)
+    def test_create_with_git_suffix(
+            self, autologin_user, backend, csrf_token):
+        repo_name = backend.new_repo_name() + ".git"
+        description = 'description for newly created repo'
+        response = self.app.post(
+            url('repos'),
+            fixture._get_repo_create_params(
+                repo_private=False,
+                repo_name=repo_name,
+                repo_type=backend.alias,
+                repo_description=description,
+                csrf_token=csrf_token))
+        response.mustcontain('Repository name cannot end with .git')
 
     def test_show(self, autologin_user, backend):
         self.app.get(url('repo', repo_name=backend.repo_name))
 
-    def test_edit(self, backend, autologin_user):
-        self.app.get(url('edit_repo', repo_name=backend.repo_name))
-
-    def test_edit_accessible_when_missing_requirements(
-            self, backend_hg, autologin_user):
-        scm_patcher = mock.patch.object(
-            Repository, 'scm_instance', side_effect=RepositoryRequirementError)
-        with scm_patcher:
-            self.app.get(url('edit_repo', repo_name=backend_hg.repo_name))
-
-    def test_set_private_flag_sets_default_to_none(
-            self, autologin_user, backend, csrf_token):
-        # initially repository perm should be read
-        perm = _get_permission_for_user(user='default', repo=backend.repo_name)
-        assert len(perm) == 1
-        assert perm[0].permission.permission_name == 'repository.read'
-        assert not backend.repo.private
-
-        response = self.app.post(
-            url('repo', repo_name=backend.repo_name),
-            fixture._get_repo_create_params(
-                repo_private=1,
-                repo_name=backend.repo_name,
-                repo_type=backend.alias,
-                user=TEST_USER_ADMIN_LOGIN,
-                _method='put',
-                csrf_token=csrf_token))
-        assert_session_flash(
-            response,
-            msg='Repository %s updated successfully' % (backend.repo_name))
-        assert backend.repo.private
-
-        # now the repo default permission should be None
-        perm = _get_permission_for_user(user='default', repo=backend.repo_name)
-        assert len(perm) == 1
-        assert perm[0].permission.permission_name == 'repository.none'
-
-        response = self.app.post(
-            url('repo', repo_name=backend.repo_name),
-            fixture._get_repo_create_params(
-                repo_private=False,
-                repo_name=backend.repo_name,
-                repo_type=backend.alias,
-                user=TEST_USER_ADMIN_LOGIN,
-                _method='put',
-                csrf_token=csrf_token))
-        assert_session_flash(
-            response,
-            msg='Repository %s updated successfully' % (backend.repo_name))
-        assert not backend.repo.private
-
-        # we turn off private now the repo default permission should stay None
-        perm = _get_permission_for_user(user='default', repo=backend.repo_name)
-        assert len(perm) == 1
-        assert perm[0].permission.permission_name == 'repository.none'
-
-        # update this permission back
-        perm[0].permission = Permission.get_by_key('repository.read')
-        Session().add(perm[0])
-        Session().commit()
-
     def test_default_user_cannot_access_private_repo_in_a_group(
             self, autologin_user, user_util, backend, csrf_token):
 
@@ -461,82 +399,6 b' class TestAdminRepos:'
         assert permissions[0].permission.permission_name == 'repository.none'
         assert permissions[0].repository.private is True
 
-    def test_set_repo_fork_has_no_self_id(self, autologin_user, backend):
-        repo = backend.repo
-        response = self.app.get(
-            url('edit_repo_advanced', repo_name=backend.repo_name))
-        opt = """<option value="%s">vcs_test_git</option>""" % repo.repo_id
-        response.mustcontain(no=[opt])
-
-    def test_set_fork_of_target_repo(
-            self, autologin_user, backend, csrf_token):
-        target_repo = 'target_%s' % backend.alias
-        fixture.create_repo(target_repo, repo_type=backend.alias)
-        repo2 = Repository.get_by_repo_name(target_repo)
-        response = self.app.post(
-            url('edit_repo_advanced_fork', repo_name=backend.repo_name),
-            params={'id_fork_of': repo2.repo_id, '_method': 'put',
-                    'csrf_token': csrf_token})
-        repo = Repository.get_by_repo_name(backend.repo_name)
-        repo2 = Repository.get_by_repo_name(target_repo)
-        assert_session_flash(
-            response,
-            'Marked repo %s as fork of %s' % (repo.repo_name, repo2.repo_name))
-
-        assert repo.fork == repo2
-        response = response.follow()
-        # check if given repo is selected
-
-        opt = 'This repository is a fork of <a href="%s">%s</a>' % (
-            url('summary_home', repo_name=repo2.repo_name), repo2.repo_name)
-
-        response.mustcontain(opt)
-
-        fixture.destroy_repo(target_repo, forks='detach')
-
-    @pytest.mark.backends("hg", "git")
-    def test_set_fork_of_other_type_repo(self, autologin_user, backend,
-                                         csrf_token):
-        TARGET_REPO_MAP = {
-            'git': {
-                'type': 'hg',
-                'repo_name': HG_REPO},
-            'hg': {
-                'type': 'git',
-                'repo_name': GIT_REPO},
-        }
-        target_repo = TARGET_REPO_MAP[backend.alias]
-
-        repo2 = Repository.get_by_repo_name(target_repo['repo_name'])
-        response = self.app.post(
-            url('edit_repo_advanced_fork', repo_name=backend.repo_name),
-            params={'id_fork_of': repo2.repo_id, '_method': 'put',
-                    'csrf_token': csrf_token})
-        assert_session_flash(
-            response,
-            'Cannot set repository as fork of repository with other type')
-
-    def test_set_fork_of_none(self, autologin_user, backend, csrf_token):
-        # mark it as None
-        response = self.app.post(
-            url('edit_repo_advanced_fork', repo_name=backend.repo_name),
-            params={'id_fork_of': None, '_method': 'put',
-                    'csrf_token': csrf_token})
-        assert_session_flash(
-            response,
-            'Marked repo %s as fork of %s'
-            % (backend.repo_name, "Nothing"))
-        assert backend.repo.fork is None
-
-    def test_set_fork_of_same_repo(self, autologin_user, backend, csrf_token):
-        repo = Repository.get_by_repo_name(backend.repo_name)
-        response = self.app.post(
-            url('edit_repo_advanced_fork', repo_name=backend.repo_name),
-            params={'id_fork_of': repo.repo_id, '_method': 'put',
-                    'csrf_token': csrf_token})
-        assert_session_flash(
-            response, 'An error occurred during this operation')
-
     def test_create_on_top_level_without_permissions(self, backend):
         session = login_user_session(
             self.app, TEST_USER_REGULAR_LOGIN, TEST_USER_REGULAR_PASS)
@@ -596,15 +458,15 b' class TestAdminRepos:'
 
     def assert_repository_is_created_correctly(
             self, repo_name, description, backend):
-        repo_name_utf8 = repo_name.encode('utf-8')
+        repo_name_utf8 = safe_str(repo_name)
 
         # run the check page that triggers the flash message
         response = self.app.get(url('repo_check_home', repo_name=repo_name))
         assert response.json == {u'result': True}
-        assert_session_flash(
-            response,
-            u'Created repository <a href="/%s">%s</a>'
-            % (urllib.quote(repo_name_utf8), repo_name))
+
+        flash_msg = u'Created repository <a href="/{}">{}</a>'.format(
+            urllib.quote(repo_name_utf8), repo_name)
+        assert_session_flash(response, flash_msg)
 
         # test if the repo was created in the database
         new_repo = RepoModel().get_by_repo_name(repo_name)
@@ -613,7 +475,7 b' class TestAdminRepos:'
         assert new_repo.description == description
 
         # test if the repository is visible in the list ?
-        response = self.app.get(url('summary_home', repo_name=repo_name))
+        response = self.app.get(h.route_path('repo_summary', repo_name=repo_name))
         response.mustcontain(repo_name)
         response.mustcontain(backend.alias)
 
@@ -628,6 +490,7 b' class TestVcsSettings(object):'
         'hooks_changegroup_push_logger': False,
         'hooks_outgoing_pull_logger': False,
         'extensions_largefiles': False,
+        'extensions_evolve': False,
         'phases_publish': 'False',
         'rhodecode_pr_merge_enabled': False,
         'rhodecode_use_outdated_comments': False,
@@ -783,13 +646,14 b' class TestVcsSettings(object):'
             self, backend, user_util, settings_util, csrf_token):
         repo = backend.create_repo()
         repo_name = repo.repo_name
-        user = UserModel().get_by_username(TEST_USER_REGULAR_LOGIN)
 
         logout_user_session(self.app, csrf_token)
         session = login_user_session(
             self.app, TEST_USER_REGULAR_LOGIN, TEST_USER_REGULAR_PASS)
         new_csrf_token = auth.get_csrf_token(session)
 
+        user = UserModel().get_by_username(TEST_USER_REGULAR_LOGIN)
+        repo = Repository.get_by_repo_name(repo_name)
         user_util.grant_user_permission_to_repo(repo, user, 'repository.admin')
         data = self.FORM_DATA.copy()
         data['csrf_token'] = new_csrf_token
@@ -1165,11 +1029,14 b' class TestVcsSettings(object):'
             self, backend_svn, user_util, settings_util, csrf_token):
         repo = backend_svn.create_repo()
         repo_name = repo.repo_name
-        user = UserModel().get_by_username(TEST_USER_REGULAR_LOGIN)
+
         logout_user_session(self.app, csrf_token)
         session = login_user_session(
             self.app, TEST_USER_REGULAR_LOGIN, TEST_USER_REGULAR_PASS)
         csrf_token = auth.get_csrf_token(session)
+
+        repo = Repository.get_by_repo_name(repo_name)
+        user = UserModel().get_by_username(TEST_USER_REGULAR_LOGIN)
         user_util.grant_user_permission_to_repo(repo, user, 'repository.admin')
         branch = settings_util.create_repo_rhodecode_ui(
             repo, VcsSettingsModel.SVN_BRANCH_SECTION, 'test_branch',

rhodecode/tests/functional/test_admin_settings.py

@@ -275,6 +275,23 b' class TestAdminSettingsVcs(object):'
             'value="True" checked="checked" />')
         response.mustcontain(extensions_input)
 
+    def test_extensions_hgevolve(self, app, form_defaults, csrf_token):
+        form_defaults.update({
+            'csrf_token': csrf_token,
+            'extensions_evolve': 'True',
+        })
+        response = app.post(
+            url('admin_settings_vcs'),
+            params=form_defaults,
+            status=302)
+
+        response = response.follow()
+        extensions_input = (
+            '<input id="extensions_evolve" '
+            'name="extensions_evolve" type="checkbox" '
+            'value="True" checked="checked" />')
+        response.mustcontain(extensions_input)
+
     def test_has_a_section_for_pull_request_settings(self, app):
         response = app.get(url('admin_settings_vcs'))
         response.mustcontain('Pull Request Settings')
@@ -445,7 +462,7 b' class TestOpenSourceLicenses(object):'
             '.panel-heading', 'Licenses of Third Party Packages')
 
     def test_forbidden_when_normal_user(self, autologin_regular_user):
-        self.app.get(self._get_url(), status=403)
+        self.app.get(self._get_url(), status=404)
 
 
 @pytest.mark.usefixtures('app')
@@ -458,7 +475,7 b' class TestUserSessions(object):'
         }[name]
 
     def test_forbidden_when_normal_user(self, autologin_regular_user):
-        self.app.get(self._get_url(), status=403)
+        self.app.get(self._get_url(), status=404)
 
     def test_show_sessions_page(self, autologin_user):
         response = self.app.get(self._get_url(), status=200)
@@ -485,7 +502,7 b' class TestAdminSystemInfo(object):'
         }[name]
 
     def test_forbidden_when_normal_user(self, autologin_regular_user):
-        self.app.get(self._get_url(), status=403)
+        self.app.get(self._get_url(), status=404)
 
     def test_system_info_page(self, autologin_user):
         response = self.app.get(self._get_url())

rhodecode/tests/functional/test_admin_users.py

@@ -510,66 +510,3 b' class TestAdminUsersController(TestContr'
             element = assert_response.get_element(css_selector)
             assert element.value == default_permissions[permission]
 
-    def test_ips(self):
-        self.log_user()
-        user = User.get_by_username(TEST_USER_REGULAR_LOGIN)
-        response = self.app.get(url('edit_user_ips', user_id=user.user_id))
-        response.mustcontain('All IP addresses are allowed')
-
-    @pytest.mark.parametrize("test_name, ip, ip_range, failure", [
-        ('127/24', '127.0.0.1/24', '127.0.0.0 - 127.0.0.255', False),
-        ('10/32', '10.0.0.10/32', '10.0.0.10 - 10.0.0.10', False),
-        ('0/16', '0.0.0.0/16', '0.0.0.0 - 0.0.255.255', False),
-        ('0/8', '0.0.0.0/8', '0.0.0.0 - 0.255.255.255', False),
-        ('127_bad_mask', '127.0.0.1/99', '127.0.0.1 - 127.0.0.1', True),
-        ('127_bad_ip', 'foobar', 'foobar', True),
-    ])
-    def test_add_ip(self, test_name, ip, ip_range, failure):
-        self.log_user()
-        user = User.get_by_username(TEST_USER_REGULAR_LOGIN)
-        user_id = user.user_id
-
-        response = self.app.post(url('edit_user_ips', user_id=user_id),
-                                 params={'new_ip': ip, '_method': 'put',
-                                         'csrf_token': self.csrf_token})
-
-        if failure:
-            assert_session_flash(
-                response, 'Please enter a valid IPv4 or IpV6 address')
-            response = self.app.get(url('edit_user_ips', user_id=user_id))
-            response.mustcontain(no=[ip])
-            response.mustcontain(no=[ip_range])
-
-        else:
-            response = self.app.get(url('edit_user_ips', user_id=user_id))
-            response.mustcontain(ip)
-            response.mustcontain(ip_range)
-
-        # cleanup
-        for del_ip in UserIpMap.query().filter(
-                UserIpMap.user_id == user_id).all():
-            Session().delete(del_ip)
-            Session().commit()
-
-    def test_delete_ip(self):
-        self.log_user()
-        user = User.get_by_username(TEST_USER_REGULAR_LOGIN)
-        user_id = user.user_id
-        ip = '127.0.0.1/32'
-        ip_range = '127.0.0.1 - 127.0.0.1'
-        new_ip = UserModel().add_extra_ip(user_id, ip)
-        Session().commit()
-        new_ip_id = new_ip.ip_id
-
-        response = self.app.get(url('edit_user_ips', user_id=user_id))
-        response.mustcontain(ip)
-        response.mustcontain(ip_range)
-
-        self.app.post(url('edit_user_ips', user_id=user_id),
-                      params={'_method': 'delete', 'del_ip_id': new_ip_id,
-                              'csrf_token': self.csrf_token})
-
-        response = self.app.get(url('edit_user_ips', user_id=user_id))
-        response.mustcontain('All IP addresses are allowed')
-        response.mustcontain(no=[ip])
-        response.mustcontain(no=[ip_range])

rhodecode/tests/functional/test_compare.py

@@ -489,7 +489,22 b' class TestCompareController(object):'
         compare_page = ComparePage(response)
         compare_page.contains_commits(commits=[commit1], ancestors=[commit0])
 
-    def test_errors_when_comparing_unknown_repo(self, backend):
+    def test_errors_when_comparing_unknown_source_repo(self, backend):
+        repo = backend.repo
+        badrepo = 'badrepo'
+
+        response = self.app.get(
+            url('compare_url',
+                repo_name=badrepo,
+                source_ref_type="rev",
+                source_ref='tip',
+                target_ref_type="rev",
+                target_ref='tip',
+                target_repo=repo.repo_name,
+                merge='1',),
+            status=404)
+
+    def test_errors_when_comparing_unknown_target_repo(self, backend):
         repo = backend.repo
         badrepo = 'badrepo'
 
@@ -504,7 +519,8 b' class TestCompareController(object):'
                 merge='1',),
             status=302)
         redirected = response.follow()
-        redirected.mustcontain('Could not find the other repo: %s' % badrepo)
+        redirected.mustcontain(
+            'Could not find the target repo: `{}`'.format(badrepo))
 
     def test_compare_not_in_preview_mode(self, backend_stub):
         commit0 = backend_stub.repo.get_commit(commit_idx=0)

rhodecode/tests/functional/test_delegated_admin.py

@@ -30,6 +30,12 b' from rhodecode.tests.fixture import Fixt'
 fixture = Fixture()
 
 
+def route_path(name, **kwargs):
+    return {
+        'home': '/',
+    }[name].format(**kwargs)
+
+
 class TestAdminUsersGroupsController(TestController):
 
     def test_regular_user_cannot_see_admin_interfaces(self, user_util):
@@ -37,7 +43,7 b' class TestAdminUsersGroupsController(Tes'
         self.log_user(user.username, 'qweqwe')
 
         # check if in home view, such user doesn't see the "admin" menus
-        response = self.app.get(url('home'))
+        response = self.app.get(route_path('home'))
 
         assert_response = response.assert_response()
 
@@ -69,7 +75,7 b' class TestAdminUsersGroupsController(Tes'
 
         self.log_user(username, 'qweqwe')
         # check if in home view, such user doesn't see the "admin" menus
-        response = self.app.get(url('home'))
+        response = self.app.get(route_path('home'))
 
         assert_response = response.assert_response()
 
@@ -109,7 +115,7 b' class TestAdminUsersGroupsController(Tes'
 
         self.log_user(username, 'qweqwe')
         # check if in home view, such user doesn't see the "admin" menus
-        response = self.app.get(url('home'))
+        response = self.app.get(route_path('home'))
 
         assert_response = response.assert_response()
 

rhodecode/tests/functional/test_files.py

@@ -484,7 +484,7 b' class TestRawFileHandling(object):'
 
         msg = (
             "There is no file nor directory at the given path: "
-            "'%s' at commit %s" % (f_path, commit.short_id))
+            "`%s` at commit %s" % (f_path, commit.short_id))
         response.mustcontain(msg)
 
     def test_raw_ok(self, backend):
@@ -517,7 +517,7 b' class TestRawFileHandling(object):'
                                     f_path=f_path), status=404)
         msg = (
             "There is no file nor directory at the given path: "
-            "'%s' at commit %s" % (f_path, commit.short_id))
+            "`%s` at commit %s" % (f_path, commit.short_id))
         response.mustcontain(msg)
 
     def test_raw_svg_should_not_be_rendered(self, backend):
@@ -758,9 +758,8 b' class TestChangingFiles:'
                 'csrf_token': csrf_token,
             },
             status=302)
-        assert_session_flash(
-            response, 'Successfully committed to %s'
-            % os.path.join(filename))
+        assert_session_flash(response,
+            'Successfully committed new file `{}`'.format(os.path.join(filename)))
 
     def test_add_file_into_repo_missing_filename(self, backend, csrf_token):
         response = self.app.post(
@@ -796,11 +795,12 b' class TestChangingFiles:'
 
         # Not allowed, redirect to the summary
         redirected = response.follow()
-        summary_url = url('summary_home', repo_name=repo.repo_name)
+        summary_url = h.route_path('repo_summary', repo_name=repo.repo_name)
 
         # As there are no commits, displays the summary page with the error of
         # creating a file with no filename
-        assert redirected.req.path == summary_url
+
+        assert redirected.request.path == summary_url
 
     @pytest.mark.parametrize("location, filename", [
         ('/abs', 'foo'),
@@ -847,9 +847,9 b' class TestChangingFiles:'
                 'csrf_token': csrf_token,
             },
             status=302)
-        assert_session_flash(
-            response, 'Successfully committed to %s'
-            % os.path.join(location, filename))
+        assert_session_flash(response,
+            'Successfully committed new file `{}`'.format(
+                os.path.join(location, filename)))
 
     def test_edit_file_view(self, backend):
         response = self.app.get(
@@ -893,7 +893,7 b' class TestChangingFiles:'
             },
             status=302)
         assert_session_flash(
-            response, 'Successfully committed to vcs/nodes.py')
+            response, 'Successfully committed changes to file `vcs/nodes.py`')
         tip = repo.get_commit(commit_idx=-1)
         assert tip.message == 'I committed'
 
@@ -920,7 +920,7 b' class TestChangingFiles:'
             },
             status=302)
         assert_session_flash(
-            response, 'Successfully committed to vcs/nodes.py')
+            response, 'Successfully committed changes to file `vcs/nodes.py`')
         tip = repo.get_commit(commit_idx=-1)
         assert tip.message == 'Edited file vcs/nodes.py via RhodeCode Enterprise'
 
@@ -960,7 +960,7 b' class TestChangingFiles:'
             },
             status=302)
         assert_session_flash(
-            response, 'Successfully deleted file vcs/nodes.py')
+            response, 'Successfully deleted file `vcs/nodes.py`')
 
 
 def assert_files_in_response(response, files, params):

rhodecode/tests/functional/test_forks.py

@@ -22,6 +22,7 b' import pytest'
 
 from rhodecode.tests import *
 from rhodecode.tests.fixture import Fixture
+from rhodecode.lib import helpers as h
 
 from rhodecode.model.db import Repository
 from rhodecode.model.repo import RepoModel
@@ -74,7 +75,7 b' class _BaseTest(TestController):'
         repo_name = self.REPO
         self.app.post(
             url(controller='forks', action='fork_create', repo_name=repo_name),
-            {'csrf_token': self.csrf_token}, status=403)
+            {'csrf_token': self.csrf_token}, status=404)
 
     def test_index_with_fork(self):
         self.log_user()
@@ -106,9 +107,7 b' class _BaseTest(TestController):'
         )
 
         # remove this fork
-        response = self.app.post(
-            url('repo', repo_name=fork_name),
-            params={'_method': 'delete', 'csrf_token': self.csrf_token})
+        fixture.destroy_repo(fork_name)
 
     def test_fork_create_into_group(self):
         self.log_user()
@@ -149,7 +148,7 b' class _BaseTest(TestController):'
         assert fork_repo.fork.repo_name == repo_name
 
         # test if the repository is visible in the list ?
-        response = self.app.get(url('summary_home', repo_name=fork_name_full))
+        response = self.app.get(h.route_path('repo_summary', repo_name=fork_name_full))
         response.mustcontain(fork_name_full)
         response.mustcontain(self.REPO_TYPE)
 
@@ -195,7 +194,7 b' class _BaseTest(TestController):'
         assert fork_repo.fork.repo_name == repo_name
 
         # test if the repository is visible in the list ?
-        response = self.app.get(url('summary_home', repo_name=fork_name))
+        response = self.app.get(h.route_path('repo_summary', repo_name=fork_name))
         response.mustcontain(fork_name)
         response.mustcontain(self.REPO_TYPE)
         response.mustcontain('Fork of')
@@ -256,7 +255,7 b' class TestHG(_BaseTest):'
 
 @pytest.mark.usefixtures('app', 'autologin_user')
 @pytest.mark.skip_backends('git','hg')
-class TestSVNFork:
+class TestSVNFork(object):
 
     def test_fork_redirects(self, backend):
         denied_actions = ['fork','fork_create']
@@ -268,7 +267,7 b' class TestSVNFork:'
 
             # Not allowed, redirect to the summary
             redirected = response.follow()
-            summary_url = url('summary_home', repo_name=backend.repo_name)
+            summary_url = h.route_path('repo_summary', repo_name=backend.repo_name)
 
             # URL adds leading slash and path doesn't have it
-            assert redirected.req.path == summary_url
+            assert redirected.request.path == summary_url

rhodecode/tests/functional/test_integrations.py

@@ -214,7 +214,7 b' def _post_integration_test_helper(app, u'
     checks if the redirect url is correct.
     """
 
-    app.post(url, params={}, status=403) # missing csrf check
+    app.post(url, params={}, status=403)  # missing csrf check
     response = app.post(url, params={'csrf_token': csrf_token})
     assert response.status_code == 200
     assert 'Errors exist' in response.body

rhodecode/tests/functional/test_login.py

@@ -25,10 +25,11 b' import pytest'
 
 from rhodecode.config.routing import ADMIN_PREFIX
 from rhodecode.tests import (
-    assert_session_flash, url, HG_REPO, TEST_USER_ADMIN_LOGIN)
+    assert_session_flash, url, HG_REPO, TEST_USER_ADMIN_LOGIN,
+    no_newline_id_generator)
 from rhodecode.tests.fixture import Fixture
-from rhodecode.tests.utils import AssertResponse, get_session_from_response
 from rhodecode.lib.auth import check_password
+from rhodecode.lib import helpers as h
 from rhodecode.model.auth_token import AuthTokenModel
 from rhodecode.model import validators
 from rhodecode.model.db import User, Notification, UserApiKeys
@@ -71,7 +72,7 b' class TestLoginController(object):'
                                  {'username': 'test_admin',
                                   'password': 'test12'})
         assert response.status == '302 Found'
-        session = get_session_from_response(response)
+        session = response.get_session_from_response()
         username = session['rhodecode_user'].get('username')
         assert username == 'test_admin'
         response = response.follow()
@@ -83,7 +84,7 b' class TestLoginController(object):'
                                   'password': 'test12'})
 
         assert response.status == '302 Found'
-        session = get_session_from_response(response)
+        session = response.get_session_from_response()
         username = session['rhodecode_user'].get('username')
         assert username == 'test_regular'
         response = response.follow()
@@ -105,8 +106,9 b' class TestLoginController(object):'
         with fixture.anon_access(False):
             kwargs = {'branch': 'stable'}
             response = self.app.get(
-                url('summary_home', repo_name=HG_REPO, **kwargs))
+                h.route_path('repo_summary', repo_name=HG_REPO, _query=kwargs))
             assert response.status == '302 Found'
+
             response_query = urlparse.parse_qsl(response.location)
             assert 'branch=stable' in response_query[0][1]
 
@@ -122,7 +124,7 b' class TestLoginController(object):'
         'ftp://some.ftp.server',
         'http://other.domain',
         '/\r\nX-Forwarded-Host: http://example.org',
-    ])
+    ], ids=no_newline_id_generator)
     def test_login_bad_came_froms(self, url_came_from):
         _url = '{}?came_from={}'.format(login_url, url_came_from)
         response = self.app.post(
@@ -183,7 +185,7 b' class TestLoginController(object):'
                                   'password': 'test123'})
 
         assert response.status == '302 Found'
-        session = get_session_from_response(response)
+        session = response.get_session_from_response()
         username = session['rhodecode_user'].get('username')
         assert username == temp_user
         response = response.follow()
@@ -212,7 +214,7 b' class TestLoginController(object):'
             }
         )
 
-        assertr = AssertResponse(response)
+        assertr = response.assert_response()
         msg = validators.ValidUsername()._messages['username_exists']
         msg = msg % {'username': uname}
         assertr.element_contains('#username+.error-message', msg)
@@ -230,7 +232,7 b' class TestLoginController(object):'
             }
         )
 
-        assertr = AssertResponse(response)
+        assertr = response.assert_response()
         msg = validators.UniqSystemEmail()()._messages['email_taken']
         assertr.element_contains('#email+.error-message', msg)
 
@@ -246,7 +248,7 b' class TestLoginController(object):'
                 'lastname': 'test'
             }
         )
-        assertr = AssertResponse(response)
+        assertr = response.assert_response()
         msg = validators.UniqSystemEmail()()._messages['email_taken']
         assertr.element_contains('#email+.error-message', msg)
 
@@ -300,7 +302,7 b' class TestLoginController(object):'
             }
         )
 
-        assertr = AssertResponse(response)
+        assertr = response.assert_response()
         msg = validators.ValidUsername()._messages['username_exists']
         msg = msg % {'username': usr}
         assertr.element_contains('#username+.error-message', msg)

rhodecode/tests/functional/test_pullrequests.py

@@ -24,20 +24,21 b' from webob.exc import HTTPNotFound'
 
 import rhodecode
 from rhodecode.lib.vcs.nodes import FileNode
+from rhodecode.lib import helpers as h
 from rhodecode.model.changeset_status import ChangesetStatusModel
 from rhodecode.model.db import (
-    PullRequest, ChangesetStatus, UserLog, Notification)
+    PullRequest, ChangesetStatus, UserLog, Notification, ChangesetComment)
 from rhodecode.model.meta import Session
 from rhodecode.model.pull_request import PullRequestModel
 from rhodecode.model.user import UserModel
-from rhodecode.model.repo import RepoModel
-from rhodecode.tests import assert_session_flash, url, TEST_USER_ADMIN_LOGIN
+from rhodecode.tests import (
+    assert_session_flash, url, TEST_USER_ADMIN_LOGIN, TEST_USER_REGULAR_LOGIN)
 from rhodecode.tests.utils import AssertResponse
 
 
 @pytest.mark.usefixtures('app', 'autologin_user')
 @pytest.mark.backends("git", "hg")
-class TestPullrequestsController:
+class TestPullrequestsController(object):
 
     def test_index(self, backend):
         self.app.get(url(
@@ -46,25 +47,12 b' class TestPullrequestsController:'
 
     def test_option_menu_create_pull_request_exists(self, backend):
         repo_name = backend.repo_name
-        response = self.app.get(url('summary_home', repo_name=repo_name))
+        response = self.app.get(h.route_path('repo_summary', repo_name=repo_name))
 
         create_pr_link = '<a href="%s">Create Pull Request</a>' % url(
             'pullrequest', repo_name=repo_name)
         response.mustcontain(create_pr_link)
 
-    def test_global_redirect_of_pr(self, backend, pr_util):
-        pull_request = pr_util.create_pull_request()
-
-        response = self.app.get(
-            url('pull_requests_global',
-                pull_request_id=pull_request.pull_request_id))
-
-        repo_name = pull_request.target_repo.repo_name
-        redirect_url = url('pullrequest_show', repo_name=repo_name,
-                           pull_request_id=pull_request.pull_request_id)
-        assert response.status == '302 Found'
-        assert redirect_url in response.location
-
     def test_create_pr_form_with_raw_commit_id(self, backend):
         repo = backend.repo
 
@@ -97,7 +85,7 b' class TestPullrequestsController:'
             'Server-side pull request merging is disabled.'
             in response) != pr_merge_enabled
 
-    def test_close_status_visibility(self, pr_util, csrf_token):
+    def test_close_status_visibility(self, pr_util, user_util, csrf_token):
         from rhodecode.tests.functional.test_login import login_url, logut_url
         # Logout
         response = self.app.post(
@@ -105,10 +93,11 b' class TestPullrequestsController:'
             params={'csrf_token': csrf_token})
         # Login as regular user
         response = self.app.post(login_url,
-                                 {'username': 'test_regular',
+                                 {'username': TEST_USER_REGULAR_LOGIN,
                                   'password': 'test12'})
 
-        pull_request = pr_util.create_pull_request(author='test_regular')
+        pull_request = pr_util.create_pull_request(
+            author=TEST_USER_REGULAR_LOGIN)
 
         response = self.app.get(url(
             controller='pullrequests', action='show',
@@ -118,6 +107,22 b' class TestPullrequestsController:'
         response.mustcontain('Server-side pull request merging is disabled.')
 
         assert_response = response.assert_response()
+        # for regular user without a merge permissions, we don't see it
+        assert_response.no_element_exists('#close-pull-request-action')
+
+        user_util.grant_user_permission_to_repo(
+            pull_request.target_repo,
+            UserModel().get_by_username(TEST_USER_REGULAR_LOGIN),
+            'repository.write')
+        response = self.app.get(url(
+            controller='pullrequests', action='show',
+            repo_name=pull_request.target_repo.scm_instance().name,
+            pull_request_id=str(pull_request.pull_request_id)))
+
+        response.mustcontain('Server-side pull request merging is disabled.')
+
+        assert_response = response.assert_response()
+        # now regular user has a merge permissions, we have CLOSE button
         assert_response.one_element_exists('#close-pull-request-action')
 
     def test_show_invalid_commit_id(self, pr_util):
@@ -232,7 +237,9 b' class TestPullrequestsController:'
         assertr.element_contains(
             'span[data-role="merge-message"]', str(expected_msg))
 
-    def test_comment_and_close_pull_request(self, pr_util, csrf_token):
+    def test_comment_and_close_pull_request_custom_message_approved(
+            self, pr_util, csrf_token, xhr_header):
+
         pull_request = pr_util.create_pull_request(approved=True)
         pull_request_id = pull_request.pull_request_id
         author = pull_request.user_id
@@ -244,75 +251,82 b' class TestPullrequestsController:'
                 repo_name=pull_request.target_repo.scm_instance().name,
                 pull_request_id=str(pull_request_id)),
             params={
-                'changeset_status': ChangesetStatus.STATUS_APPROVED,
                 'close_pull_request': '1',
                 'text': 'Closing a PR',
                 'csrf_token': csrf_token},
-            status=302)
+            extra_environ=xhr_header,)
 
-        action = 'user_closed_pull_request:%d' % pull_request_id
         journal = UserLog.query()\
             .filter(UserLog.user_id == author)\
-            .filter(UserLog.repository_id == repo)\
-            .filter(UserLog.action == action)\
+            .filter(UserLog.repository_id == repo) \
+            .order_by('user_log_id') \
             .all()
-        assert len(journal) == 1
+        assert journal[-1].action == 'repo.pull_request.close'
 
         pull_request = PullRequest.get(pull_request_id)
         assert pull_request.is_closed()
 
-        # check only the latest status, not the review status
         status = ChangesetStatusModel().get_status(
             pull_request.source_repo, pull_request=pull_request)
         assert status == ChangesetStatus.STATUS_APPROVED
+        comments = ChangesetComment().query() \
+            .filter(ChangesetComment.pull_request == pull_request) \
+            .order_by(ChangesetComment.comment_id.asc())\
+            .all()
+        assert comments[-1].text == 'Closing a PR'
 
-    def test_reject_and_close_pull_request(self, pr_util, csrf_token):
+    def test_comment_force_close_pull_request_rejected(
+            self, pr_util, csrf_token, xhr_header):
         pull_request = pr_util.create_pull_request()
         pull_request_id = pull_request.pull_request_id
-        response = self.app.post(
+        PullRequestModel().update_reviewers(
+            pull_request_id, [(1, ['reason'], False), (2, ['reason2'], False)],
+            pull_request.author)
+        author = pull_request.user_id
+        repo = pull_request.target_repo.repo_id
+
+        self.app.post(
             url(controller='pullrequests',
-                action='update',
+                action='comment',
                 repo_name=pull_request.target_repo.scm_instance().name,
-                pull_request_id=str(pull_request.pull_request_id)),
-            params={'close_pull_request': 'true', '_method': 'put',
-                    'csrf_token': csrf_token})
+                pull_request_id=str(pull_request_id)),
+            params={
+                'close_pull_request': '1',
+                'csrf_token': csrf_token},
+            extra_environ=xhr_header)
 
         pull_request = PullRequest.get(pull_request_id)
 
-        assert response.json is True
-        assert pull_request.is_closed()
+        journal = UserLog.query()\
+            .filter(UserLog.user_id == author, UserLog.repository_id == repo) \
+            .order_by('user_log_id') \
+            .all()
+        assert journal[-1].action == 'repo.pull_request.close'
 
         # check only the latest status, not the review status
         status = ChangesetStatusModel().get_status(
             pull_request.source_repo, pull_request=pull_request)
         assert status == ChangesetStatus.STATUS_REJECTED
 
-    def test_comment_force_close_pull_request(self, pr_util, csrf_token):
+    def test_comment_and_close_pull_request(
+            self, pr_util, csrf_token, xhr_header):
         pull_request = pr_util.create_pull_request()
         pull_request_id = pull_request.pull_request_id
-        reviewers_data = [(1, ['reason']), (2, ['reason2'])]
-        PullRequestModel().update_reviewers(pull_request_id, reviewers_data)
-        author = pull_request.user_id
-        repo = pull_request.target_repo.repo_id
-        self.app.post(
+
+        response = self.app.post(
             url(controller='pullrequests',
                 action='comment',
                 repo_name=pull_request.target_repo.scm_instance().name,
-                pull_request_id=str(pull_request_id)),
+                pull_request_id=str(pull_request.pull_request_id)),
             params={
-                'changeset_status': 'rejected',
-                'close_pull_request': '1',
+                'close_pull_request': 'true',
                 'csrf_token': csrf_token},
-            status=302)
+            extra_environ=xhr_header)
+
+        assert response.json
 
         pull_request = PullRequest.get(pull_request_id)
-
-        action = 'user_closed_pull_request:%d' % pull_request_id
-        journal = UserLog.query().filter(
-            UserLog.user_id == author,
-            UserLog.repository_id == repo,
-            UserLog.action == action).all()
-        assert len(journal) == 1
+        assert pull_request.is_closed()
 
         # check only the latest status, not the review status
         status = ChangesetStatusModel().get_status(
@@ -340,6 +354,7 b' class TestPullrequestsController:'
                 ('source_ref', 'branch:default:' + commit_ids['change2']),
                 ('target_repo', target.repo_name),
                 ('target_ref',  'branch:default:' + commit_ids['ancestor']),
+                ('common_ancestor', commit_ids['ancestor']),
                 ('pullrequest_desc', 'Description'),
                 ('pullrequest_title', 'Title'),
                 ('__start__', 'review_members:sequence'),
@@ -348,6 +363,7 b' class TestPullrequestsController:'
                         ('__start__', 'reasons:sequence'),
                             ('reason', 'Some reason'),
                         ('__end__', 'reasons:sequence'),
+                        ('mandatory', 'False'),
                     ('__end__', 'reviewer:mapping'),
                 ('__end__', 'review_members:sequence'),
                 ('__start__', 'revisions:sequence'),
@@ -360,8 +376,9 b' class TestPullrequestsController:'
             status=302)
 
         location = response.headers['Location']
-        pull_request_id = int(location.rsplit('/', 1)[1])
-        pull_request = PullRequest.get(pull_request_id)
+        pull_request_id = location.rsplit('/', 1)[1]
+        assert pull_request_id != 'new'
+        pull_request = PullRequest.get(int(pull_request_id))
 
         # check that we have now both revisions
         assert pull_request.revisions == [commit_ids['change2'], commit_ids['change']]
@@ -398,6 +415,7 b' class TestPullrequestsController:'
                 ('source_ref', 'branch:default:' + commit_ids['change']),
                 ('target_repo', target.repo_name),
                 ('target_ref',  'branch:default:' + commit_ids['ancestor-child']),
+                ('common_ancestor', commit_ids['ancestor']),
                 ('pullrequest_desc', 'Description'),
                 ('pullrequest_title', 'Title'),
                 ('__start__', 'review_members:sequence'),
@@ -406,6 +424,7 b' class TestPullrequestsController:'
                         ('__start__', 'reasons:sequence'),
                             ('reason', 'Some reason'),
                         ('__end__', 'reasons:sequence'),
+                        ('mandatory', 'False'),
                     ('__end__', 'reviewer:mapping'),
                 ('__end__', 'review_members:sequence'),
                 ('__start__', 'revisions:sequence'),
@@ -417,21 +436,23 b' class TestPullrequestsController:'
             status=302)
 
         location = response.headers['Location']
-        pull_request_id = int(location.rsplit('/', 1)[1])
-        pull_request = PullRequest.get(pull_request_id)
+
+        pull_request_id = location.rsplit('/', 1)[1]
+        assert pull_request_id != 'new'
+        pull_request = PullRequest.get(int(pull_request_id))
 
         # Check that a notification was made
         notifications = Notification.query()\
             .filter(Notification.created_by == pull_request.author.user_id,
                     Notification.type_ == Notification.TYPE_PULL_REQUEST,
-                    Notification.subject.contains("wants you to review "
-                                                  "pull request #%d"
-                                                  % pull_request_id))
+                    Notification.subject.contains(
+                        "wants you to review pull request #%s" % pull_request_id))
         assert len(notifications.all()) == 1
 
         # Change reviewers and check that a notification was made
         PullRequestModel().update_reviewers(
-            pull_request.pull_request_id, [(1, [])])
+            pull_request.pull_request_id, [(1, [], False)],
+            pull_request.author)
         assert len(notifications.all()) == 2
 
     def test_create_pull_request_stores_ancestor_commit_id(self, backend,
@@ -462,6 +483,7 b' class TestPullrequestsController:'
                 ('source_ref', 'branch:default:' + commit_ids['change']),
                 ('target_repo', target.repo_name),
                 ('target_ref',  'branch:default:' + commit_ids['ancestor-child']),
+                ('common_ancestor', commit_ids['ancestor']),
                 ('pullrequest_desc', 'Description'),
                 ('pullrequest_title', 'Title'),
                 ('__start__', 'review_members:sequence'),
@@ -470,6 +492,7 b' class TestPullrequestsController:'
                         ('__start__', 'reasons:sequence'),
                             ('reason', 'Some reason'),
                         ('__end__', 'reasons:sequence'),
+                        ('mandatory', 'False'),
                     ('__end__', 'reviewer:mapping'),
                 ('__end__', 'review_members:sequence'),
                 ('__start__', 'revisions:sequence'),
@@ -481,8 +504,10 b' class TestPullrequestsController:'
             status=302)
 
         location = response.headers['Location']
-        pull_request_id = int(location.rsplit('/', 1)[1])
-        pull_request = PullRequest.get(pull_request_id)
+
+        pull_request_id = location.rsplit('/', 1)[1]
+        assert pull_request_id != 'new'
+        pull_request = PullRequest.get(int(pull_request_id))
 
         # target_ref has to point to the ancestor's commit_id in order to
         # show the correct diff
@@ -519,18 +544,21 b' class TestPullrequestsController:'
             pull_request, ChangesetStatus.STATUS_APPROVED)
 
         # Check the relevant log entries were added
-        user_logs = UserLog.query().order_by('-user_log_id').limit(4)
+        user_logs = UserLog.query().order_by('-user_log_id').limit(3)
         actions = [log.action for log in user_logs]
         pr_commit_ids = PullRequestModel()._get_commit_ids(pull_request)
         expected_actions = [
-            u'user_closed_pull_request:%d' % pull_request_id,
-            u'user_merged_pull_request:%d' % pull_request_id,
-            # The action below reflect that the post push actions were executed
-            u'user_commented_pull_request:%d' % pull_request_id,
-            u'push:%s' % ','.join(pr_commit_ids),
+             u'repo.pull_request.close',
+             u'repo.pull_request.merge',
+             u'repo.pull_request.comment.create'
         ]
         assert actions == expected_actions
 
+        user_logs = UserLog.query().order_by('-user_log_id').limit(4)
+        actions = [log for log in user_logs]
+        assert actions[-1].action == 'user.push'
+        assert actions[-1].action_data['commit_ids'] == pr_commit_ids
+
         # Check post_push rcextension was really executed
         push_calls = rhodecode.EXTENSIONS.calls['post_push']
         assert len(push_calls) == 1
@@ -941,18 +969,9 b' class TestPullrequestsController:'
         assert target.text.strip() == 'tag: target'
         assert target.getchildren() == []
 
-    def test_description_is_escaped_on_index_page(self, backend, pr_util):
-        xss_description = "<script>alert('Hi!')</script>"
-        pull_request = pr_util.create_pull_request(description=xss_description)
-        response = self.app.get(url(
-            controller='pullrequests', action='show_all',
-            repo_name=pull_request.target_repo.repo_name))
-        response.mustcontain(
-            "&lt;script&gt;alert(&#39;Hi!&#39;)&lt;/script&gt;")
-
     @pytest.mark.parametrize('mergeable', [True, False])
     def test_shadow_repository_link(
-            self, mergeable, pr_util, http_host_stub):
+            self, mergeable, pr_util, http_host_only_stub):
         """
         Check that the pull request summary page displays a link to the shadow
         repository if the pull request is mergeable. If it is not mergeable
@@ -963,7 +982,7 b' class TestPullrequestsController:'
         target_repo = pull_request.target_repo.scm_instance()
         pr_id = pull_request.pull_request_id
         shadow_url = '{host}/{repo}/pull-request/{pr_id}/repository'.format(
-            host=http_host_stub, repo=target_repo.name, pr_id=pr_id)
+            host=http_host_only_stub, repo=target_repo.name, pr_id=pr_id)
 
         response = self.app.get(url(
             controller='pullrequests', action='show',
@@ -1041,6 +1060,17 b' class TestPullrequestsControllerDelete(o'
         response.mustcontain('id="delete_pullrequest"')
         response.mustcontain(no=['Confirm to delete this pull request'])
 
+    def test_delete_comment_returns_404_if_comment_does_not_exist(
+            self, autologin_user, pr_util, user_admin):
+
+        pull_request = pr_util.create_pull_request(
+            author=user_admin.username, enable_notifications=False)
+
+        self.app.get(url(
+            controller='pullrequests', action='delete_comment',
+            repo_name=pull_request.target_repo.scm_instance().name,
+            comment_id=1024404), status=404)
+
 
 def assert_pull_request_status(pull_request, expected_status):
     status = ChangesetStatusModel().calculated_review_status(
@@ -1048,30 +1078,17 b' def assert_pull_request_status(pull_requ'
     assert status == expected_status
 
 
[e-mail]('action', ['show_all', 'index', 'create'])
[e-mail]('action', ['index', 'create'])
 @pytest.mark.usefixtures("autologin_user")
-def test_redirects_to_repo_summary_for_svn_repositories(
-        backend_svn, app, action):
-    denied_actions = ['show_all', 'index', 'create']
-    for action in denied_actions:
-        response = app.get(url(
-            controller='pullrequests', action=action,
-            repo_name=backend_svn.repo_name))
-        assert response.status_int == 302
+def test_redirects_to_repo_summary_for_svn_repositories(backend_svn, app, action):
+    response = app.get(url(
+        controller='pullrequests', action=action,
+        repo_name=backend_svn.repo_name))
+    assert response.status_int == 302
 
-        # Not allowed, redirect to the summary
-        redirected = response.follow()
-        summary_url = url('summary_home', repo_name=backend_svn.repo_name)
-
-        # URL adds leading slash and path doesn't have it
-        assert redirected.req.path == summary_url
-
+    # Not allowed, redirect to the summary
+    redirected = response.follow()
+    summary_url = h.route_path('repo_summary', repo_name=backend_svn.repo_name)
 
-def test_delete_comment_returns_404_if_comment_does_not_exist(pylonsapp):
-    # TODO: johbo: Global import not possible because models.forms blows up
-    from rhodecode.controllers.pullrequests import PullrequestsController
-    controller = PullrequestsController()
-    patcher = mock.patch(
-        'rhodecode.model.db.BaseModel.get', return_value=None)
-    with pytest.raises(HTTPNotFound), patcher:
-        controller._delete_comment(1)
+    # URL adds leading slash and path doesn't have it
+    assert redirected.request.path == summary_url

rhodecode/tests/functional/test_sessions.py

@@ -21,8 +21,13 b''
 import mock
 import pytest
 
-from rhodecode.tests import TEST_USER_ADMIN_LOGIN, url
-from rhodecode.tests.utils import AssertResponse
+from rhodecode.tests import TEST_USER_ADMIN_LOGIN
+
+
+def route_path(name, **kwargs):
+    return {
+        'home': '/',
+    }[name].format(**kwargs)
 
 
 class TestSessionBehaviorOnPasswordChange(object):
@@ -39,18 +44,23 b' class TestSessionBehaviorOnPasswordChang'
 
     def test_sessions_are_ok_when_password_is_not_changed(
             self, app, autologin_user):
-        response = app.get(url('home'))
-        assert_response = AssertResponse(response)
+        response = app.get(route_path('home'))
+        assert_response = response.assert_response()
         assert_response.element_contains(
             '#quick_login_link .menu_link_user', TEST_USER_ADMIN_LOGIN)
-        assert 'rhodecode_user' in response.session
-        assert response.session.was_invalidated is False
+
+        session = response.get_session_from_response()
+
+        assert 'rhodecode_user' in session
+        assert session.was_invalidated is False
 
     def test_sessions_invalidated_when_password_is_changed(
             self, app, autologin_user):
         self.password_changed_mock.return_value = True
-        response = app.get(url('home'))
-        assert_response = AssertResponse(response)
+        response = app.get(route_path('home'))
+        assert_response = response.assert_response()
         assert_response.element_contains('#quick_login_link .user', 'Sign in')
-        assert 'rhodecode_user' not in response.session
-        assert response.session.was_invalidated is True
+
+        session = response.get_session_from_response()
+        assert 'rhodecode_user' not in session
+        assert session.was_invalidated is True

rhodecode/tests/integrations/test_webhook.py

@@ -32,7 +32,12 b' def base_data():'
             'repo_name': 'foo',
             'repo_type': 'hg',
             'repo_id': '12',
-            'url': 'http://repo.url/foo'
+            'url': 'http://repo.url/foo',
+            'extra_fields': {},
+        },
+        'actor': {
+            'username': 'actor_name',
+            'user_id': 1
         }
     }
 

rhodecode/tests/lib/middleware/test_simplevcs.py

@@ -35,7 +35,6 b' from rhodecode.model.meta import Session'
 from rhodecode.tests import (
     HG_REPO, TEST_USER_ADMIN_LOGIN, TEST_USER_ADMIN_PASS)
 from rhodecode.tests.lib.middleware import mock_scm_app
-from rhodecode.tests.utils import set_anonymous_access
 
 
 class StubVCSController(simplevcs.SimpleVCS):
@@ -70,7 +69,7 b' def vcscontroller(pylonsapp, config_stub'
     config_stub.testing_securitypolicy()
     config_stub.include('rhodecode.authentication')
 
-    set_anonymous_access(True)
+    #set_anonymous_access(True)
     controller = StubVCSController(pylonsapp, pylonsapp.config, None)
     app = HttpsFixup(controller, pylonsapp.config)
     app = CustomTestApp(app)
@@ -87,19 +86,12 b' def vcscontroller(pylonsapp, config_stub'
 def _remove_default_user_from_query_cache():
     user = User.get_default_user(cache=True)
     query = Session().query(User).filter(User.username == user.username)
-    query = query.options(FromCache(
-        "sql_cache_short", "get_user_%s" % _hash_key(user.username)))
+    query = query.options(
+        FromCache("sql_cache_short", "get_user_%s" % _hash_key(user.username)))
     query.invalidate()
     Session().expire(user)
 
 
[e-mail]
-def disable_anonymous_user(request, pylonsapp):
-    set_anonymous_access(False)
-
-    @request.addfinalizer
-    def cleanup():
-        set_anonymous_access(True)
 
 
 def test_handles_exceptions_during_permissions_checks(
@@ -275,7 +267,7 b' class TestShadowRepoExposure(object):'
                 controller.vcs_repo_name ==
                 controller._get_repository_name(environ_stub))
 
-    def test_set_repo_names_with_shadow(self, pylonsapp, pr_util):
+    def test_set_repo_names_with_shadow(self, pylonsapp, pr_util, config_stub):
         """
         Check that the set_repo_names method sets correct names on a request
         to a shadow repo.
@@ -304,7 +296,7 b' class TestShadowRepoExposure(object):'
         assert controller.is_shadow_repo
 
     def test_set_repo_names_with_shadow_but_missing_pr(
-            self, pylonsapp, pr_util):
+            self, pylonsapp, pr_util, config_stub):
         """
         Checks that the set_repo_names method enforces matching target repos
         and pull request IDs.
@@ -326,7 +318,7 b' class TestShadowRepoExposure(object):'
 
 
 @pytest.mark.usefixtures('db')
-class TestGenerateVcsResponse:
+class TestGenerateVcsResponse(object):
 
     def test_ensures_that_start_response_is_called_early_enough(self):
         self.call_controller_with_response_body(iter(['a', 'b']))
@@ -418,7 +410,7 b' class TestGenerateVcsResponse:'
         return self.controller._invalidate_cache.called
 
 
-class TestInitializeGenerator:
+class TestInitializeGenerator(object):
 
     def test_drains_first_element(self):
         gen = self.factory(['__init__', 1, 2])

rhodecode/tests/lib/test_base.py

@@ -20,10 +20,10 b''
 
 import pytest
 from mock import Mock, patch
-from pylons import url
 
 from rhodecode.lib import base
 from rhodecode.lib.vcs.exceptions import RepositoryRequirementError
+from rhodecode.lib import helpers as h
 from rhodecode.model import db
 
 
@@ -34,8 +34,9 b' from rhodecode.model import db'
     ('scm', 'stub_scm'),
     ('hooks', ['stub_hook']),
     ('config', 'stub_ini_filename'),
-    ('ip', 'fake_ip'),
+    ('ip', '1.2.3.4'),
     ('server_url', 'https://example.com'),
+    ('user_agent', 'client-text-v1.1'),
     # TODO: johbo: Commpare locking parameters with `_get_rc_scm_extras`
     # in hooks_utils.
     ('make_lock', None),
@@ -71,7 +72,6 b' def test_vcs_operation_context_can_skip_'
 
 @patch.object(
     base, 'get_enabled_hook_classes', Mock(return_value=['stub_hook']))
[e-mail](base, 'get_ip_addr', Mock(return_value="fake_ip"))
 @patch('rhodecode.lib.utils2.get_server_url',
        Mock(return_value='https://example.com'))
 def call_vcs_operation_context(**kwargs_override):
@@ -87,7 +87,9 b' def call_vcs_operation_context(**kwargs_'
         'rhodecode.CONFIG', {'__file__': 'stub_ini_filename'})
     settings_patch = patch.object(base, 'VcsSettingsModel')
     with config_file_patch, settings_patch as settings_mock:
-        result = base.vcs_operation_context(environ={}, **kwargs)
+        result = base.vcs_operation_context(
+            environ={'HTTP_USER_AGENT': 'client-text-v1.1',
+                     'REMOTE_ADDR': '1.2.3.4'}, **kwargs)
     settings_mock.assert_called_once_with(repo='stub_repo_name')
     return result
 
@@ -163,7 +165,7 b' class TestBaseRepoControllerHandleMissin'
             context_mock.repo_name = repo_name
             controller._handle_missing_requirements(error)
 
-        expected_url = url('summary_home', repo_name=repo_name)
+        expected_url = h.route_path('repo_summary', repo_name=repo_name)
         if should_redirect:
             redirect_mock.assert_called_once_with(expected_url)
         else:

rhodecode/tests/lib/test_codeblocks.py

@@ -19,11 +19,12 b''
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
 import pytest
+from pygments.lexers import get_lexer_by_name
 
+from rhodecode.tests import no_newline_id_generator
 from rhodecode.lib.codeblocks import (
     tokenize_string, split_token_stream, rollup_tokenstream,
     render_tokenstream)
-from pygments.lexers import get_lexer_by_name
 
 
 class TestTokenizeString(object):
@@ -298,7 +299,7 b' class TestRenderTokenStream(object):'
             [('A', '', u'hel'), ('B', 'ins', u'lo')],
             '<span class="A">hel</span><span class="B"><ins>lo</ins></span>',
         ),
-    ])
+    ], ids=no_newline_id_generator)
     def test_render_tokenstream_with_ops(self, tokenstream, output):
         html = render_tokenstream(tokenstream)
         assert html == output

rhodecode/tests/lib/test_helpers.py

@@ -27,6 +27,7 b' from pylons.util import ContextObj'
 from rhodecode.lib import helpers
 from rhodecode.lib.utils2 import AttributeDict
 from rhodecode.model.settings import IssueTrackerSettingsModel
+from rhodecode.tests import no_newline_id_generator
 
 
 @pytest.mark.parametrize('url, expected_url', [
@@ -103,55 +104,62 b' def test_extract_issues(backend, text_st'
     assert issues == expected
 
 
[e-mail]('text_string, pattern, expected_text', [
-    ('Fix #42', '(?:#)(?P<issue_id>\d+)',
-     'Fix <a class="issue-tracker-link" href="http://r.io/{repo}/i/42">#42</a>'
-     ),
-    ('Fix #42', '(?:#)?<issue_id>\d+)', 'Fix #42'),  # Broken regex
[e-mail]('text_string, pattern, link_format, expected_text', [
+    ('Fix #42', '(?:#)(?P<issue_id>\d+)', 'html',
+     'Fix <a class="issue-tracker-link" href="http://r.io/{repo}/i/42">#42</a>'),
+
+    ('Fix #42', '(?:#)(?P<issue_id>\d+)', 'markdown',
+     'Fix [#42](http://r.io/{repo}/i/42)'),
+
+    ('Fix #42', '(?:#)(?P<issue_id>\d+)', 'rst',
+     'Fix `#42 <http://r.io/{repo}/i/42>`_'),
+
+    ('Fix #42', '(?:#)?<issue_id>\d+)', 'html',
+     'Fix #42'),  # Broken regex
 ])
-def test_process_patterns_repo(backend, text_string, pattern, expected_text):
+def test_process_patterns_repo(backend, text_string, pattern, expected_text, link_format):
     repo = backend.create_repo()
-    config = {'123': {
-        'uid': '123',
-        'pat': pattern,
-        'url': 'http://r.io/${repo}/i/${issue_id}',
-        'pref': '#',
-        }
-    }
 
     def get_settings_mock(self, cache=True):
-        return config
+        return {
+            '123': {
+                'uid': '123',
+                'pat': pattern,
+                'url': 'http://r.io/${repo}/i/${issue_id}',
+                'pref': '#',
+            }
+        }
 
     with mock.patch.object(IssueTrackerSettingsModel,
                            'get_settings', get_settings_mock):
         processed_text, issues = helpers.process_patterns(
-            text_string, repo.repo_name, config)
+            text_string, repo.repo_name, link_format)
 
     assert processed_text == expected_text.format(repo=repo.repo_name)
 
 
 @pytest.mark.parametrize('text_string, pattern, expected_text', [
     ('Fix #42', '(?:#)(?P<issue_id>\d+)',
-     'Fix <a class="issue-tracker-link" href="http://r.io/i/42">#42</a>'
-     ),
-    ('Fix #42', '(?:#)?<issue_id>\d+)', 'Fix #42'),  # Broken regex
+     'Fix <a class="issue-tracker-link" href="http://r.io/i/42">#42</a>'),
+    ('Fix #42', '(?:#)?<issue_id>\d+)',
+     'Fix #42'),  # Broken regex
 ])
 def test_process_patterns_no_repo(text_string, pattern, expected_text):
-    config = {'123': {
-        'uid': '123',
-        'pat': pattern,
-        'url': 'http://r.io/i/${issue_id}',
-        'pref': '#',
-        }
-    }
 
     def get_settings_mock(self, cache=True):
-        return config
+        return {
+            '123': {
+                'uid': '123',
+                'pat': pattern,
+                'url': 'http://r.io/i/${issue_id}',
+                'pref': '#',
+            }
+        }
 
     with mock.patch.object(IssueTrackerSettingsModel,
                            'get_global_settings', get_settings_mock):
         processed_text, issues = helpers.process_patterns(
-            text_string, '', config)
+            text_string, '')
 
     assert processed_text == expected_text
 
@@ -161,21 +169,21 b' def test_process_patterns_non_existent_r'
     pattern = '(?:#)(?P<issue_id>\d+)'
     expected_text = ('Fix <a class="issue-tracker-link" '
                      'href="http://r.io/do-not-exist/i/42">#42</a>')
-    config = {'123': {
-        'uid': '123',
-        'pat': pattern,
-        'url': 'http://r.io/${repo}/i/${issue_id}',
-        'pref': '#',
-        }
-    }
 
     def get_settings_mock(self, cache=True):
-        return config
+        return {
+            '123': {
+                'uid': '123',
+                'pat': pattern,
+                'url': 'http://r.io/${repo}/i/${issue_id}',
+                'pref': '#',
+            }
+        }
 
     with mock.patch.object(IssueTrackerSettingsModel,
                            'get_global_settings', get_settings_mock):
         processed_text, issues = helpers.process_patterns(
-            text_string, 'do-not-exist', config)
+            text_string, 'do-not-exist')
 
     assert processed_text == expected_text
 
@@ -197,7 +205,7 b' def test_get_visual_attr(pylonsapp):'
     ('just a string\n', False, 'just a string'),
     ('just a string\n next line', False, 'just a string...'),
     ('just a string\n next line', True, 'just a string\n...'),
-])
+], ids=no_newline_id_generator)
 def test_chop_at(test_text, inclusive, expected_text):
     assert helpers.chop_at_smart(
         test_text, '\n', inclusive, '...') == expected_text

rhodecode/tests/lib/test_hooks_base.py

@@ -20,15 +20,10 b''
 
 import mock
 import pytest
-
+from rhodecode.model.db import Session, UserLog
 from rhodecode.lib import hooks_base, utils2
 
 
[e-mail](
-    hooks_base,
-    action_logger=mock.Mock(),
-    post_push_extension=mock.Mock(),
-    Repository=mock.Mock())
 def test_post_push_truncates_commits(user_regular, repo_stub):
     extras = {
         'ip': '127.0.0.1',
@@ -39,6 +34,7 b' def test_post_push_truncates_commits(use'
         'config': '',
         'server_url': 'http://example.com',
         'make_lock': None,
+        'user_agent': 'some-client',
         'locked_by': [None],
         'commit_ids': ['abcde12345' * 4] * 30000,
         'is_shadow_repo': False,
@@ -48,11 +44,13 b' def test_post_push_truncates_commits(use'
     hooks_base.post_push(extras)
 
     # Calculate appropriate action string here
-    expected_action = 'push_local:%s' % ','.join(extras.commit_ids[:29000])
+    commit_ids = extras.commit_ids[:10000]
 
-    hooks_base.action_logger.assert_called_with(
-        extras.username, expected_action, extras.repository, extras.ip,
-        commit=True)
+    entry = UserLog.query().order_by('-user_log_id').first()
+    assert entry.action == 'user.push'
+    assert entry.action_data['commit_ids'] == commit_ids
+    Session().delete(entry)
+    Session().commit()
 
 
 def assert_called_with_mock(callable_, expected_mock_name):
@@ -72,6 +70,7 b' def hook_extras(user_regular, repo_stub)'
         'config': '',
         'server_url': 'http://example.com',
         'make_lock': None,
+        'user_agent': 'some-client',
         'locked_by': [None],
         'commit_ids': [],
         'is_shadow_repo': False,

rhodecode/tests/lib/test_mako_emails.py

@@ -3,16 +3,17 b' import collections'
 import pytest
 
 from rhodecode.lib.utils import PartialRenderer
+from rhodecode.lib.utils2 import AttributeDict
 from rhodecode.model.notification import EmailNotificationModel
 
 
-def test_get_template_obj(pylonsapp):
+def test_get_template_obj(app):
     template = EmailNotificationModel().get_renderer(
         EmailNotificationModel.TYPE_TEST)
     assert isinstance(template, PartialRenderer)
 
 
-def test_render_email(pylonsapp):
+def test_render_email(app, http_host_only_stub):
     kwargs = {}
     subject, headers, body, body_plaintext = EmailNotificationModel().render_email(
         EmailNotificationModel.TYPE_TEST, **kwargs)
@@ -27,12 +28,13 b' def test_render_email(pylonsapp):'
     assert body_plaintext == 'Email Plaintext Body'
 
     # body
-    assert 'This is a notification ' \
-           'from RhodeCode. http://test.example.com:80/' in body
+    notification_footer = 'This is a notification from RhodeCode. http://%s/' \
+                          % http_host_only_stub
+    assert notification_footer in body
     assert 'Email Body' in body
 
 
-def test_render_pr_email(pylonsapp, user_admin):
+def test_render_pr_email(app, user_admin):
 
     ref = collections.namedtuple('Ref',
         'name, type')(
@@ -66,3 +68,57 b' def test_render_pr_email(pylonsapp, user'
 
     # subject
     assert subject == 'Marcin Kuzminski wants you to review pull request #200: "Example Pull Request"'
+
+
[e-mail]('mention', [
+    True,
+    False
+])
[e-mail]('email_type', [
+    EmailNotificationModel.TYPE_COMMIT_COMMENT,
+    EmailNotificationModel.TYPE_PULL_REQUEST_COMMENT
+])
+def test_render_comment_subject_no_newlines(app, mention, email_type):
+    ref = collections.namedtuple('Ref',
+        'name, type')(
+        'fxies123', 'book'
+        )
+
+    pr = collections.namedtuple('PullRequest',
+        'pull_request_id, title, description, source_ref_parts, source_ref_name, target_ref_parts, target_ref_name')(
+        200, 'Example Pull Request', 'Desc of PR', ref, 'bookmark', ref, 'Branch')
+
+    source_repo = target_repo = collections.namedtuple('Repo',
+        'type, repo_name')(
+        'hg', 'pull_request_1')
+
+    kwargs = {
+        'user': '<[e-mail]> Marcin Kuzminski',
+        'commit': AttributeDict(raw_id='a'*40, message='Commit message'),
+        'status_change': 'approved',
+        'commit_target_repo': AttributeDict(),
+        'repo_name': 'test-repo',
+        'comment_file': 'test-file.py',
+        'comment_line': 'n100',
+        'comment_type': 'note',
+        'commit_comment_url': 'http://comment-url',
+        'instance_url': 'http://rc-instance',
+        'comment_body': 'hello world',
+        'mention': mention,
+
+        'pr_comment_url': 'http://comment-url',
+        'pr_source_repo': AttributeDict(repo_name='foobar'),
+        'pr_source_repo_url': 'http://soirce-repo/url',
+        'pull_request': pr,
+        'pull_request_commits': [],
+
+        'pull_request_target_repo': target_repo,
+        'pull_request_target_repo_url': 'x',
+
+        'pull_request_source_repo': source_repo,
+        'pull_request_source_repo_url': 'x',
+    }
+    subject, headers, body, body_plaintext = EmailNotificationModel().render_email(
+        email_type, **kwargs)
+
+    assert '\n' not in subject

rhodecode/tests/lib/test_utils.py

@@ -86,22 +86,24 b' HOOK_PUSH = db.RhodeCodeUi.HOOK_PUSH'
 HOOK_PRE_PULL = db.RhodeCodeUi.HOOK_PRE_PULL
 HOOK_PULL = db.RhodeCodeUi.HOOK_PULL
 HOOK_REPO_SIZE = db.RhodeCodeUi.HOOK_REPO_SIZE
+HOOK_PUSH_KEY = db.RhodeCodeUi.HOOK_PUSH_KEY
 
 HG_HOOKS = frozenset(
     (HOOK_PRE_PULL, HOOK_PULL, HOOK_PRE_PUSH, HOOK_PRETX_PUSH, HOOK_PUSH,
-     HOOK_REPO_SIZE))
+     HOOK_REPO_SIZE, HOOK_PUSH_KEY))
 
 
 @pytest.mark.parametrize('disabled_hooks,expected_hooks', [
     ([], HG_HOOKS),
     (HG_HOOKS, []),
 
-    ([HOOK_PRE_PUSH, HOOK_PRETX_PUSH, HOOK_REPO_SIZE], [HOOK_PRE_PULL, HOOK_PULL, HOOK_PUSH]),
+    ([HOOK_PRE_PUSH, HOOK_PRETX_PUSH, HOOK_REPO_SIZE, HOOK_PUSH_KEY], [HOOK_PRE_PULL, HOOK_PULL, HOOK_PUSH]),
 
     # When a pull/push hook is disabled, its pre-pull/push counterpart should
     # be disabled too.
     ([HOOK_PUSH], [HOOK_PRE_PULL, HOOK_PULL, HOOK_REPO_SIZE]),
-    ([HOOK_PULL], [HOOK_PRE_PUSH, HOOK_PRETX_PUSH, HOOK_PUSH, HOOK_REPO_SIZE]),
+    ([HOOK_PULL], [HOOK_PRE_PUSH, HOOK_PRETX_PUSH, HOOK_PUSH, HOOK_REPO_SIZE,
+                   HOOK_PUSH_KEY]),
 ])
 def test_make_db_config_hg_hooks(pylonsapp, request, disabled_hooks,
                                  expected_hooks):
@@ -219,11 +221,6 b' def platform_encodes_filenames():'
     return path_with_latin1 != read_path
 
 
-def test_action_logger_action_size(pylonsapp, test_repo):
-    action = 'x' * 1200001
-    utils.action_logger(TEST_USER_ADMIN_LOGIN, action, test_repo, commit=True)
-
-
 @pytest.fixture
 def repo_groups(request):
     session = meta.Session()

rhodecode/tests/models/schemas/test_repo_group_schema.py

@@ -52,18 +52,18 b' class TestRepoGroupSchema(object):'
         )
 
         schema_data = schema.deserialize(dict(
-            repo_group_name='dupa',
+            repo_group_name='my_schema_group',
             repo_group_owner=user_admin.username
         ))
 
-        assert schema_data['repo_group_name'] == 'dupa'
+        assert schema_data['repo_group_name'] == u'my_schema_group'
         assert schema_data['repo_group'] == {
             'repo_group_id': None,
             'repo_group_name': types.RootLocation,
-            'repo_group_name_without_group': 'dupa'}
+            'repo_group_name_without_group': u'my_schema_group'}
 
     @pytest.mark.parametrize('given, err_key, expected_exc', [
-        ('xxx/dupa', 'repo_group', 'Parent repository group `xxx` does not exist'),
+        ('xxx/my_schema_group', 'repo_group', 'Parent repository group `xxx` does not exist'),
         ('', 'repo_group_name', 'Name must start with a letter or number. Got ``'),
     ])
     def test_deserialize_with_bad_group_name(
@@ -86,7 +86,7 b' class TestRepoGroupSchema(object):'
             user=user_admin
         )
 
-        full_name = test_repo_group.group_name + '/dupa'
+        full_name = test_repo_group.group_name + u'/my_schema_group'
         schema_data = schema.deserialize(dict(
             repo_group_name=full_name,
             repo_group_owner=user_admin.username
@@ -96,7 +96,7 b' class TestRepoGroupSchema(object):'
         assert schema_data['repo_group'] == {
             'repo_group_id': test_repo_group.group_id,
             'repo_group_name': test_repo_group.group_name,
-            'repo_group_name_without_group': 'dupa'}
+            'repo_group_name_without_group': u'my_schema_group'}
 
     def test_deserialize_with_group_name_regular_user_no_perms(
             self, app, user_regular, test_repo_group):
@@ -104,7 +104,7 b' class TestRepoGroupSchema(object):'
             user=user_regular
         )
 
-        full_name = test_repo_group.group_name + '/dupa'
+        full_name = test_repo_group.group_name + u'/my_schema_group'
         with pytest.raises(colander.Invalid) as excinfo:
             schema.deserialize(dict(
                 repo_group_name=full_name,

rhodecode/tests/models/schemas/test_repo_schema.py

@@ -57,19 +57,20 b' class TestRepoSchema(object):'
         )
 
         schema_data = schema.deserialize(dict(
-            repo_name='dupa',
+            repo_name='my_schema_repo',
             repo_type='hg',
             repo_owner=user_admin.username
         ))
 
-        assert schema_data['repo_name'] == 'dupa'
+        assert schema_data['repo_name'] == u'my_schema_repo'
         assert schema_data['repo_group'] == {
             'repo_group_id': None,
             'repo_group_name': types.RootLocation,
-            'repo_name_without_group': 'dupa'}
+            'repo_name_with_group': u'my_schema_repo',
+            'repo_name_without_group': u'my_schema_repo'}
 
     @pytest.mark.parametrize('given, err_key, expected_exc', [
-        ('xxx/dupa','repo_group', 'Repository group `xxx` does not exist'),
+        ('xxx/my_schema_repo','repo_group', 'Repository group `xxx` does not exist'),
         ('', 'repo_name', 'Name must start with a letter or number. Got ``'),
     ])
     def test_deserialize_with_bad_group_name(
@@ -95,7 +96,7 b' class TestRepoSchema(object):'
             user=user_admin
         )
 
-        full_name = test_repo_group.group_name + '/dupa'
+        full_name = test_repo_group.group_name + u'/my_schema_repo'
         schema_data = schema.deserialize(dict(
             repo_name=full_name,
             repo_type='hg',
@@ -106,7 +107,8 b' class TestRepoSchema(object):'
         assert schema_data['repo_group'] == {
             'repo_group_id': test_repo_group.group_id,
             'repo_group_name': test_repo_group.group_name,
-            'repo_name_without_group': 'dupa'}
+            'repo_name_with_group': full_name,
+            'repo_name_without_group': u'my_schema_repo'}
 
     def test_deserialize_with_group_name_regular_user_no_perms(
             self, app, user_regular, test_repo_group):
@@ -115,7 +117,7 b' class TestRepoSchema(object):'
             user=user_regular
         )
 
-        full_name = test_repo_group.group_name + '/dupa'
+        full_name = test_repo_group.group_name + '/my_schema_repo'
         with pytest.raises(colander.Invalid) as excinfo:
             schema.deserialize(dict(
                 repo_name=full_name,

rhodecode/tests/models/settings/test_vcs_settings.py

@@ -500,7 +500,8 b' class TestCreateOrUpdateUi(object):'
     def test_update(self, repo_stub, settings_util):
         model = VcsSettingsModel(repo=repo_stub.repo_name)
 
-        largefiles, phases = model.HG_SETTINGS
+        largefiles, phases, evolve = model.HG_SETTINGS
+
         section = 'test-section'
         key = 'test-key'
         settings_util.create_repo_rhodecode_ui(
@@ -519,6 +520,7 b' class TestCreateOrUpdateUi(object):'
 class TestCreateOrUpdateRepoHgSettings(object):
     FORM_DATA = {
         'extensions_largefiles': False,
+        'extensions_evolve': False,
         'phases_publish': False
     }
 
@@ -529,6 +531,8 b' class TestCreateOrUpdateRepoHgSettings(o'
         expected_calls = [
             mock.call(model.repo_settings, 'extensions', 'largefiles',
                       active=False, value=''),
+            mock.call(model.repo_settings, 'extensions', 'evolve',
+                      active=False, value=''),
             mock.call(model.repo_settings, 'phases', 'publish', value='False'),
         ]
         assert expected_calls == create_mock.call_args_list
@@ -574,7 +578,8 b' class TestCreateOrUpdateGlobalHgSettings'
         'extensions_largefiles': False,
         'largefiles_usercache': '/example/largefiles-store',
         'phases_publish': False,
-        'extensions_hgsubversion': False
+        'extensions_hgsubversion': False,
+        'extensions_evolve': False
     }
 
     def test_creates_repo_hg_settings_when_data_is_correct(self):
@@ -589,7 +594,9 b' class TestCreateOrUpdateGlobalHgSettings'
             mock.call(model.global_settings, 'phases', 'publish',
                       value='False'),
             mock.call(model.global_settings, 'extensions', 'hgsubversion',
-                      active=False)
+                      active=False),
+            mock.call(model.global_settings, 'extensions', 'evolve',
+                      active=False, value='')
         ]
         assert expected_calls == create_mock.call_args_list
 
@@ -957,6 +964,7 b' class TestCreateOrUpdateRepoSettings(obj'
         'hooks_changegroup_push_logger': False,
         'hooks_outgoing_pull_logger': False,
         'extensions_largefiles': False,
+        'extensions_evolve': False,
         'largefiles_usercache': '/example/largefiles-store',
         'vcs_git_lfs_enabled': False,
         'vcs_git_lfs_store_location': '/',

rhodecode/tests/models/test_changeset_status.py

@@ -30,7 +30,7 b' pytestmark = ['
 ]
 
 
-def test_new_pull_request_is_under_review(pr_util):
+def test_new_pull_request_is_under_review(pr_util, config_stub):
     pull_request = pr_util.create_pull_request()
 
     # Expect that review status "Under Review"
@@ -44,7 +44,7 b' def test_new_pull_request_is_under_revie'
     db.ChangesetStatus.STATUS_UNDER_REVIEW,
 ])
 def test_pull_request_under_review_if_one_reviewer_voted(
-        pr_util, voted_status):
+        pr_util, voted_status, config_stub):
     pull_request = pr_util.create_pull_request()
     pr_util.create_status_votes(
         voted_status, pull_request.reviewers[0])
@@ -59,7 +59,7 b' def test_pull_request_under_review_if_on'
     db.ChangesetStatus.STATUS_REJECTED,
     db.ChangesetStatus.STATUS_UNDER_REVIEW,
 ])
-def test_pull_request_has_voted_status_if_all_voted(pr_util, voted_status):
+def test_pull_request_has_voted_status_if_all_voted(pr_util, voted_status, config_stub):
     pull_request = pr_util.create_pull_request()
     pr_util.create_status_votes(
         voted_status, *pull_request.reviewers)
@@ -74,7 +74,8 b' def test_pull_request_has_voted_status_i'
     db.ChangesetStatus.STATUS_REJECTED,
     db.ChangesetStatus.STATUS_UNDER_REVIEW,
 ])
-def test_pull_request_stays_if_update_without_change(pr_util, voted_status):
+def test_pull_request_stays_if_update_without_change(
+        pr_util, voted_status, config_stub):
     pull_request = pr_util.create_pull_request()
     pr_util.create_status_votes(
         voted_status, *pull_request.reviewers)
@@ -92,7 +93,7 b' def test_pull_request_stays_if_update_wi'
     db.ChangesetStatus.STATUS_REJECTED,
     db.ChangesetStatus.STATUS_UNDER_REVIEW,
 ])
-def test_pull_request_under_review_if_update(pr_util, voted_status):
+def test_pull_request_under_review_if_update(pr_util, voted_status, config_stub):
     pull_request = pr_util.create_pull_request()
     pr_util.create_status_votes(
         voted_status, *pull_request.reviewers)
@@ -106,7 +107,7 b' def test_pull_request_under_review_if_up'
     assert pull_request.calculated_review_status() == expected_review_status
 
 
-def test_commit_under_review_if_part_of_new_pull_request(pr_util):
+def test_commit_under_review_if_part_of_new_pull_request(pr_util, config_stub):
     pull_request = pr_util.create_pull_request()
     for commit_id in pull_request.revisions:
         status = ChangesetStatusModel().get_status(
@@ -120,7 +121,7 b' def test_commit_under_review_if_part_of_'
     db.ChangesetStatus.STATUS_UNDER_REVIEW,
 ])
 def test_commit_has_voted_status_after_vote_on_pull_request(
-        pr_util, voted_status):
+        pr_util, voted_status, config_stub):
     pull_request = pr_util.create_pull_request()
     pr_util.create_status_votes(
         voted_status, pull_request.reviewers[0])
@@ -130,7 +131,7 b' def test_commit_has_voted_status_after_v'
         assert status == voted_status
 
 
-def test_commit_under_review_if_added_to_pull_request(pr_util):
+def test_commit_under_review_if_added_to_pull_request(pr_util, config_stub):
     pull_request = pr_util.create_pull_request()
     pr_util.create_status_votes(
         db.ChangesetStatus.STATUS_APPROVED, pull_request.reviewers[0])
@@ -147,7 +148,7 b' def test_commit_under_review_if_added_to'
     db.ChangesetStatus.STATUS_UNDER_REVIEW,
 ])
 def test_commit_keeps_status_if_removed_from_pull_request(
-        pr_util, voted_status):
+        pr_util, voted_status, config_stub):
     pull_request = pr_util.create_pull_request()
     pr_util.add_one_commit()
     pr_util.create_status_votes(voted_status, pull_request.reviewers[0])
@@ -165,7 +166,7 b' def test_commit_keeps_status_if_removed_'
     db.ChangesetStatus.STATUS_UNDER_REVIEW,
 ])
 def test_commit_keeps_status_if_unchanged_after_update_of_pull_request(
-        pr_util, voted_status):
+        pr_util, voted_status, config_stub):
     pull_request = pr_util.create_pull_request()
     commit_id = pull_request.revisions[-1]
     pr_util.create_status_votes(voted_status, pull_request.reviewers[0])

rhodecode/tests/models/test_notifications.py

@@ -30,7 +30,7 b' from rhodecode.model.user import UserMod'
 fixture = Fixture()
 
 
-class TestNotifications:
+class TestNotifications(object):
     destroy_users = set()
 
     @classmethod
@@ -38,7 +38,7 b' class TestNotifications:'
         fixture.destroy_users(cls.destroy_users)
 
     @pytest.fixture(autouse=True)
-    def create_users(self, request, pylonsapp):
+    def create_users(self, request, app):
         Session.remove()
         self.u1 = UserModel().create_or_update(
             username=u'u1', password=u'qweqwe',
@@ -62,7 +62,7 b' class TestNotifications:'
         self.destroy_users.add('u3')
 
     @pytest.fixture(autouse=True)
-    def _clean_notifications(self, request, pylonsapp):
+    def _clean_notifications(self, request, app):
         for n in Notification.query().all():
             Session().delete(n)
 

rhodecode/tests/models/test_pullrequest.py

@@ -41,7 +41,8 b' pytestmark = ['
 ]
 
 
-class TestPullRequestModel:
[e-mail]('config_stub')
+class TestPullRequestModel(object):
 
     @pytest.fixture
     def pull_request(self, request, backend, pr_util):
@@ -49,7 +50,9 b' class TestPullRequestModel:'
         A pull request combined with multiples patches.
         """
         BackendClass = get_backend(backend.alias)
-        self.merge_patcher = mock.patch.object(BackendClass, 'merge')
+        self.merge_patcher = mock.patch.object(
+            BackendClass, 'merge', return_value=MergeResponse(
+            False, False, None, MergeFailureReason.UNKNOWN))
         self.workspace_remove_patcher = mock.patch.object(
             BackendClass, 'cleanup_merge_workspace')
 
@@ -116,7 +119,8 b' class TestPullRequestModel:'
 
     def test_get_awaiting_my_review(self, pull_request):
         PullRequestModel().update_reviewers(
-            pull_request, [(pull_request.author, ['author'])])
+            pull_request, [(pull_request.author, ['author'], False)],
+            pull_request.author)
         prs = PullRequestModel().get_awaiting_my_review(
             pull_request.target_repo, user_id=pull_request.author.user_id)
         assert isinstance(prs, list)
@@ -124,13 +128,14 b' class TestPullRequestModel:'
 
     def test_count_awaiting_my_review(self, pull_request):
         PullRequestModel().update_reviewers(
-            pull_request, [(pull_request.author, ['author'])])
+            pull_request, [(pull_request.author, ['author'], False)],
+            pull_request.author)
         pr_count = PullRequestModel().count_awaiting_my_review(
             pull_request.target_repo, user_id=pull_request.author.user_id)
         assert pr_count == 1
 
     def test_delete_calls_cleanup_merge(self, pull_request):
-        PullRequestModel().delete(pull_request)
+        PullRequestModel().delete(pull_request, pull_request.author)
 
         self.workspace_remove_mock.assert_called_once_with(
             self.workspace_id)
@@ -372,6 +377,7 b' class TestPullRequestModel:'
         assert type(title) == unicode
 
 
[e-mail]('config_stub')
 class TestIntegrationMerge(object):
     @pytest.mark.parametrize('extra_config', (
         {'vcs.hooks.protocol': 'http', 'vcs.hooks.direct_calls': False},
@@ -433,7 +439,7 b' class TestIntegrationMerge(object):'
     (True, 0, 1),
 ])
 def test_outdated_comments(
-        pr_util, use_outdated, inlines_count, outdated_count):
+        pr_util, use_outdated, inlines_count, outdated_count, config_stub):
     pull_request = pr_util.create_pull_request()
     pr_util.create_inline_comment(file_path='not_in_updated_diff')
 
@@ -465,6 +471,7 b' def merge_extras(user_regular):'
     return extras
 
 
[e-mail]('config_stub')
 class TestUpdateCommentHandling(object):
 
     @pytest.fixture(autouse=True, scope='class')
@@ -572,6 +579,7 b' class TestUpdateCommentHandling(object):'
             assert_inline_comments(pull_request, visible=0, outdated=1)
 
 
[e-mail]('config_stub')
 class TestUpdateChangedFiles(object):
 
     def test_no_changes_on_unchanged_diff(self, pr_util):
@@ -681,7 +689,7 b' class TestUpdateChangedFiles(object):'
             removed=['file_a', 'file_b', 'file_c'])
 
 
-def test_update_writes_snapshot_into_pull_request_version(pr_util):
+def test_update_writes_snapshot_into_pull_request_version(pr_util, config_stub):
     model = PullRequestModel()
     pull_request = pr_util.create_pull_request()
     pr_util.update_source_repository()
@@ -692,7 +700,7 b' def test_update_writes_snapshot_into_pul'
     assert len(model.get_versions(pull_request)) == 1
 
 
-def test_update_skips_new_version_if_unchanged(pr_util):
+def test_update_skips_new_version_if_unchanged(pr_util, config_stub):
     pull_request = pr_util.create_pull_request()
     model = PullRequestModel()
     model.update_commits(pull_request)
@@ -701,7 +709,7 b' def test_update_skips_new_version_if_unc'
     assert len(model.get_versions(pull_request)) == 0
 
 
-def test_update_assigns_comments_to_the_new_version(pr_util):
+def test_update_assigns_comments_to_the_new_version(pr_util, config_stub):
     model = PullRequestModel()
     pull_request = pr_util.create_pull_request()
     comment = pr_util.create_comment()
@@ -713,7 +721,7 b' def test_update_assigns_comments_to_the_'
     assert comment.pull_request_version == model.get_versions(pull_request)[0]
 
 
-def test_update_adds_a_comment_to_the_pull_request_about_the_change(pr_util):
+def test_update_adds_a_comment_to_the_pull_request_about_the_change(pr_util, config_stub):
     model = PullRequestModel()
     pull_request = pr_util.create_pull_request()
     pr_util.update_source_repository()
@@ -745,7 +753,7 b' def test_update_adds_a_comment_to_the_pu'
     assert update_comment.text == expected_message
 
 
-def test_create_version_from_snapshot_updates_attributes(pr_util):
+def test_create_version_from_snapshot_updates_attributes(pr_util, config_stub):
     pull_request = pr_util.create_pull_request()
 
     # Avoiding default values
@@ -784,7 +792,7 b' def test_create_version_from_snapshot_up'
     assert version.pull_request == pull_request
 
 
-def test_link_comments_to_version_only_updates_unlinked_comments(pr_util):
+def test_link_comments_to_version_only_updates_unlinked_comments(pr_util, config_stub):
     version1 = pr_util.create_version_of_pull_request()
     comment_linked = pr_util.create_comment(linked_to=version1)
     comment_unlinked = pr_util.create_comment()

rhodecode/tests/models/test_pullrequest_git.py

@@ -25,6 +25,7 b' from rhodecode.lib.vcs.exceptions import'
 from rhodecode.model.pull_request import PullRequestModel
 
 
[e-mail]('config_stub')
 @pytest.mark.backends('git')
 class TestGetDiffForPrOrVersion(object):
 

rhodecode/tests/models/test_repos.py

@@ -29,10 +29,9 b' from rhodecode.model.db import Repositor'
 from rhodecode.model.meta import Session
 from rhodecode.model.repo import RepoModel
 from rhodecode.model.scm import ScmModel
-from rhodecode.lib.utils2 import safe_unicode
 
 
-class TestRepoModel:
+class TestRepoModel(object):
 
     def test_remove_repo(self, backend):
         repo = backend.create_repo()
@@ -170,141 +169,3 b' class TestRepoModel:'
             repo.update_commit_cache(config=config)
             scm.assert_called_with(
                 cache=False, config=config)
-
-
-class TestGetUsers(object):
-    def test_returns_active_users(self, backend, user_util):
-        for i in range(4):
-            is_active = i % 2 == 0
-            user_util.create_user(active=is_active, lastname='Fake user')
-
-        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
-            users = RepoModel().get_users()
-        fake_users = [u for u in users if u['last_name'] == 'Fake user']
-        assert len(fake_users) == 2
-
-        expected_keys = (
-            'id', 'first_name', 'last_name', 'username', 'icon_link',
-            'value_display', 'value', 'value_type')
-        for user in users:
-            assert user['value_type'] is 'user'
-            for key in expected_keys:
-                assert key in user
-
-    def test_returns_user_filtered_by_last_name(self, backend, user_util):
-        keywords = ('aBc', u'ünicode')
-        for keyword in keywords:
-            for i in range(2):
-                user_util.create_user(
-                    active=True, lastname=u'Fake {} user'.format(keyword))
-
-        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
-            keyword = keywords[1].lower()
-            users = RepoModel().get_users(name_contains=keyword)
-
-        fake_users = [u for u in users if u['last_name'].startswith('Fake')]
-        assert len(fake_users) == 2
-        for user in fake_users:
-            assert user['last_name'] == safe_unicode('Fake ünicode user')
-
-    def test_returns_user_filtered_by_first_name(self, backend, user_util):
-        created_users = []
-        keywords = ('aBc', u'ünicode')
-        for keyword in keywords:
-            for i in range(2):
-                created_users.append(user_util.create_user(
-                    active=True, lastname='Fake user',
-                    firstname=u'Fake {} user'.format(keyword)))
-
-        keyword = keywords[1].lower()
-        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
-            users = RepoModel().get_users(name_contains=keyword)
-
-        fake_users = [u for u in users if u['last_name'].startswith('Fake')]
-        assert len(fake_users) == 2
-        for user in fake_users:
-            assert user['first_name'] == safe_unicode('Fake ünicode user')
-
-    def test_returns_user_filtered_by_username(self, backend, user_util):
-        created_users = []
-        for i in range(5):
-            created_users.append(user_util.create_user(
-                active=True, lastname='Fake user'))
-
-        user_filter = created_users[-1].username[-2:]
-        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
-            users = RepoModel().get_users(name_contains=user_filter)
-
-        fake_users = [u for u in users if u['last_name'].startswith('Fake')]
-        assert len(fake_users) == 1
-        assert fake_users[0]['username'] == created_users[-1].username
-
-    def test_returns_limited_user_list(self, backend, user_util):
-        created_users = []
-        for i in range(5):
-            created_users.append(user_util.create_user(
-                active=True, lastname='Fake user'))
-
-        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
-            users = RepoModel().get_users(name_contains='Fake', limit=3)
-
-        fake_users = [u for u in users if u['last_name'].startswith('Fake')]
-        assert len(fake_users) == 3
-
-
-class TestGetUserGroups(object):
-    def test_returns_filtered_list(self, backend, user_util):
-        created_groups = []
-        for i in range(4):
-            created_groups.append(
-                user_util.create_user_group(users_group_active=True))
-
-        group_filter = created_groups[-1].users_group_name[-2:]
-        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
-            with self._patch_user_group_list():
-                groups = RepoModel().get_user_groups(group_filter)
-
-        fake_groups = [
-            u for u in groups if u['value'].startswith('test_returns')]
-        assert len(fake_groups) == 1
-        assert fake_groups[0]['value'] == created_groups[-1].users_group_name
-        assert fake_groups[0]['value_display'].startswith(
-            'Group: test_returns')
-
-    def test_returns_limited_list(self, backend, user_util):
-        created_groups = []
-        for i in range(3):
-            created_groups.append(
-                user_util.create_user_group(users_group_active=True))
-        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
-            with self._patch_user_group_list():
-                groups = RepoModel().get_user_groups('test_returns')
-
-        fake_groups = [
-            u for u in groups if u['value'].startswith('test_returns')]
-        assert len(fake_groups) == 3
-
-    def test_returns_active_user_groups(self, backend, user_util):
-        for i in range(4):
-            is_active = i % 2 == 0
-            user_util.create_user_group(users_group_active=is_active)
-        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
-            with self._patch_user_group_list():
-                groups = RepoModel().get_user_groups()
-        expected = ('id', 'icon_link', 'value_display', 'value', 'value_type')
-        for group in groups:
-            assert group['value_type'] is 'user_group'
-            for key in expected:
-                assert key in group
-
-        fake_groups = [
-            u for u in groups if u['value'].startswith('test_returns')]
-        assert len(fake_groups) == 2
-        for user in fake_groups:
-            assert user['value_display'].startswith('Group: test_returns')
-
-    def _patch_user_group_list(self):
-        def side_effect(group_list, perm_set):
-            return group_list
-        return mock.patch(
-            'rhodecode.model.repo.UserGroupList', side_effect=side_effect)

rhodecode/tests/models/test_scm.py

@@ -27,6 +27,7 b' from mock import Mock, patch, DEFAULT'
 
 import rhodecode
 from rhodecode.model import db, scm
+from rhodecode.tests import no_newline_id_generator
 
 
 def test_scm_instance_config(backend):
@@ -295,7 +296,7 b' class TestCheckRhodecodeHook(object):'
     @pytest.mark.parametrize("file_content, expected_result", [
         ("RC_HOOK_VER = '3.3.3'\n", True),
         ("RC_HOOK = '3.3.3'\n", False),
-    ])
+    ], ids=no_newline_id_generator)
     @patch('os.path.exists', Mock(return_value=True))
     def test_signatures(self, file_content, expected_result):
         hook_content_patcher = patch.object(

rhodecode/tests/models/test_user_groups.py

@@ -35,6 +35,64 b' def teardown_module(self):'
     _delete_all_user_groups()
 
 
+class TestGetUserGroups(object):
+    def test_returns_filtered_list(self, backend, user_util):
+        created_groups = []
+        for i in range(4):
+            created_groups.append(
+                user_util.create_user_group(users_group_active=True))
+
+        group_filter = created_groups[-1].users_group_name[-2:]
+        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
+            with self._patch_user_group_list():
+                groups = UserGroupModel().get_user_groups(group_filter)
+
+        fake_groups = [
+            u for u in groups if u['value'].startswith('test_returns')]
+        assert len(fake_groups) == 1
+        assert fake_groups[0]['value'] == created_groups[-1].users_group_name
+        assert fake_groups[0]['value_display'].startswith(
+            'Group: test_returns')
+
+    def test_returns_limited_list(self, backend, user_util):
+        created_groups = []
+        for i in range(3):
+            created_groups.append(
+                user_util.create_user_group(users_group_active=True))
+        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
+            with self._patch_user_group_list():
+                groups = UserGroupModel().get_user_groups('test_returns')
+
+        fake_groups = [
+            u for u in groups if u['value'].startswith('test_returns')]
+        assert len(fake_groups) == 3
+
+    def test_returns_active_user_groups(self, backend, user_util):
+        for i in range(4):
+            is_active = i % 2 == 0
+            user_util.create_user_group(users_group_active=is_active)
+        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
+            with self._patch_user_group_list():
+                groups = UserGroupModel().get_user_groups()
+        expected = ('id', 'icon_link', 'value_display', 'value', 'value_type')
+        for group in groups:
+            assert group['value_type'] is 'user_group'
+            for key in expected:
+                assert key in group
+
+        fake_groups = [
+            u for u in groups if u['value'].startswith('test_returns')]
+        assert len(fake_groups) == 2
+        for user in fake_groups:
+            assert user['value_display'].startswith('Group: test_returns')
+
+    def _patch_user_group_list(self):
+        def side_effect(group_list, perm_set):
+            return group_list
+        return mock.patch(
+            'rhodecode.model.user_group.UserGroupList', side_effect=side_effect)
+
+
 @pytest.mark.parametrize(
     "pre_existing, regular_should_be, external_should_be, groups, "
     "expected", [

rhodecode/tests/models/test_users.py

@@ -19,10 +19,11 b''
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
 import pytest
-from sqlalchemy.sql.expression import true
+import mock
 
-from rhodecode.model.db import User, UserGroup, UserGroupMember, UserEmailMap,\
-    Permission, UserIpMap
+from rhodecode.lib.utils2 import safe_unicode
+from rhodecode.model.db import (
+    true, User, UserGroup, UserGroupMember, UserEmailMap, Permission, UserIpMap)
 from rhodecode.model.meta import Session
 from rhodecode.model.user import UserModel
 from rhodecode.model.user_group import UserGroupModel
@@ -33,6 +34,86 b' from rhodecode.tests.fixture import Fixt'
 fixture = Fixture()
 
 
+class TestGetUsers(object):
+    def test_returns_active_users(self, backend, user_util):
+        for i in range(4):
+            is_active = i % 2 == 0
+            user_util.create_user(active=is_active, lastname='Fake user')
+
+        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
+            users = UserModel().get_users()
+        fake_users = [u for u in users if u['last_name'] == 'Fake user']
+        assert len(fake_users) == 2
+
+        expected_keys = (
+            'id', 'first_name', 'last_name', 'username', 'icon_link',
+            'value_display', 'value', 'value_type')
+        for user in users:
+            assert user['value_type'] is 'user'
+            for key in expected_keys:
+                assert key in user
+
+    def test_returns_user_filtered_by_last_name(self, backend, user_util):
+        keywords = ('aBc', u'ünicode')
+        for keyword in keywords:
+            for i in range(2):
+                user_util.create_user(
+                    active=True, lastname=u'Fake {} user'.format(keyword))
+
+        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
+            keyword = keywords[1].lower()
+            users = UserModel().get_users(name_contains=keyword)
+
+        fake_users = [u for u in users if u['last_name'].startswith('Fake')]
+        assert len(fake_users) == 2
+        for user in fake_users:
+            assert user['last_name'] == safe_unicode('Fake ünicode user')
+
+    def test_returns_user_filtered_by_first_name(self, backend, user_util):
+        created_users = []
+        keywords = ('aBc', u'ünicode')
+        for keyword in keywords:
+            for i in range(2):
+                created_users.append(user_util.create_user(
+                    active=True, lastname='Fake user',
+                    firstname=u'Fake {} user'.format(keyword)))
+
+        keyword = keywords[1].lower()
+        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
+            users = UserModel().get_users(name_contains=keyword)
+
+        fake_users = [u for u in users if u['last_name'].startswith('Fake')]
+        assert len(fake_users) == 2
+        for user in fake_users:
+            assert user['first_name'] == safe_unicode('Fake ünicode user')
+
+    def test_returns_user_filtered_by_username(self, backend, user_util):
+        created_users = []
+        for i in range(5):
+            created_users.append(user_util.create_user(
+                active=True, lastname='Fake user'))
+
+        user_filter = created_users[-1].username[-2:]
+        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
+            users = UserModel().get_users(name_contains=user_filter)
+
+        fake_users = [u for u in users if u['last_name'].startswith('Fake')]
+        assert len(fake_users) == 1
+        assert fake_users[0]['username'] == created_users[-1].username
+
+    def test_returns_limited_user_list(self, backend, user_util):
+        created_users = []
+        for i in range(5):
+            created_users.append(user_util.create_user(
+                active=True, lastname='Fake user'))
+
+        with mock.patch('rhodecode.lib.helpers.gravatar_url'):
+            users = UserModel().get_users(name_contains='Fake', limit=3)
+
+        fake_users = [u for u in users if u['last_name'].startswith('Fake')]
+        assert len(fake_users) == 3
+
+
 @pytest.fixture
 def test_user(request, pylonsapp):
     usr = UserModel().create_or_update(

rhodecode/tests/other/test_libs.py

@@ -27,6 +27,8 b' import datetime'
 import string
 import mock
 import pytest
+
+from rhodecode.tests import no_newline_id_generator
 from rhodecode.tests.utils import run_test_concurrently
 from rhodecode.lib.helpers import InitialsGravatar
 
@@ -113,7 +115,7 b' def test_str2bool(str_bool, expected):'
 (pref+"user.dot  hej ! not-needed [e-mail]", []),
 (pref+"\n@marcin", ['marcin']),
 ]
-for pref in ['', '\n', 'hi !', '\t', '\n\n']]))
+for pref in ['', '\n', 'hi !', '\t', '\n\n']]), ids=no_newline_id_generator)
 def test_mention_extractor(text, expected):
     from rhodecode.lib.utils2 import extract_mentioned_users
     got = extract_mentioned_users(text)
@@ -330,8 +332,18 b' def test_initials_gravatar_mapping_algo('
 ])
 def test_clone_url_generator(tmpl, repo_name, overrides, prefix, expected):
     from rhodecode.lib.utils2 import get_clone_url
-    clone_url = get_clone_url(uri_tmpl=tmpl, qualifed_home_url='http://vps1:8000'+prefix,
-                              repo_name=repo_name, repo_id=23, **overrides)
+
+    class RequestStub(object):
+        def request_url(self, name):
+            return 'http://vps1:8000' + prefix
+
+        def route_url(self, name):
+            return self.request_url(name)
+
+    clone_url = get_clone_url(
+        request=RequestStub(),
+        uri_tmpl=tmpl,
+        repo_name=repo_name, repo_id=23, **overrides)
     assert clone_url == expected
 
 
@@ -378,7 +390,7 b' def _quick_url(text, tmpl="""<a class="r'
    some text url[123123123123]
    sometimes !
    """)
-])
+], ids=no_newline_id_generator)
 def test_urlify_commits(sample, expected):
     def fake_url(self, *args, **kwargs):
         return '/some-url'
@@ -410,7 +422,7 b' def test_urlify_commits(sample, expected'
      url[https://foo.bar.com]
      some text lalala""",
      "https://foo.bar.com")
-])
+], ids=no_newline_id_generator)
 def test_urlify_test(sample, expected, url_):
     from rhodecode.lib.helpers import urlify_text
     expected = _quick_url(expected, tmpl="""<a href="%s">%s</a>""", url_=url_)

rhodecode/tests/other/vcs_operations/__init__.py

@@ -131,6 +131,13 b' def _check_proper_git_push('
         assert "Setting default branch" not in stderr
 
 
+def _check_proper_hg_push(stdout, stderr, branch='default'):
+    assert 'pushing to' in stdout
+    assert 'searching for changes' in stdout
+
+    assert 'abort:' not in stderr
+
+
 def _check_proper_clone(stdout, stderr, vcs):
     if vcs == 'hg':
         assert 'requesting all changes' in stdout

rhodecode/tests/other/vcs_operations/conftest.py

@@ -41,8 +41,7 b' from rhodecode.model.settings import Set'
 from rhodecode.tests import (
     GIT_REPO, HG_REPO, TEST_USER_ADMIN_LOGIN, TEST_USER_ADMIN_PASS,)
 from rhodecode.tests.fixture import Fixture
-from rhodecode.tests.utils import (
-    set_anonymous_access, is_url_reachable, wait_for_url)
+from rhodecode.tests.utils import is_url_reachable, wait_for_url
 
 RC_LOG = os.path.join(tempfile.gettempdir(), 'rc.log')
 REPO_GROUP = 'a_repo_group'
@@ -84,6 +83,9 b' class RcWebServer(object):'
         _url = 'http://%(user)s:%(passwd)s@%(host)s/%(cloned_repo)s' % params
         return _url
 
+    def host_url(self):
+        return 'http://' + get_host_url(self.pylons_config)
+
 
 @pytest.fixture(scope="module")
 def rcextensions(request, pylonsapp, tmpdir_factory):
@@ -185,11 +187,6 b' def rc_web_server('
     return RcWebServer(rc_web_server_config)
 
 
[e-mail](scope='class', autouse=True)
-def disable_anonymous_user_access(pylonsapp):
-    set_anonymous_access(False)
-
-
 @pytest.fixture
 def disable_locking(pylonsapp):
     r = Repository.get_by_repo_name(GIT_REPO)

rhodecode/tests/other/vcs_operations/test_vcs_calls_custom_auth_code_403.py

@@ -43,8 +43,8 b' def rc_web_server_config(testini_factory'
     return testini_factory(CUSTOM_PARAMS)
 
 
[e-mail]("disable_locking")
-class TestVCSOperationsOnCustomIniConfig:
[e-mail]("disable_locking", "disable_anonymous_user")
+class TestVCSOperationsOnCustomIniConfig(object):
 
     def test_clone_wrong_credentials_hg_ret_code(self, rc_web_server, tmpdir):
         clone_url = rc_web_server.repo_clone_url(HG_REPO, passwd='bad!')

rhodecode/tests/other/vcs_operations/test_vcs_calls_custom_auth_code_404.py

@@ -43,8 +43,8 b' def rc_web_server_config(testini_factory'
     return testini_factory(CUSTOM_PARAMS)
 
 
[e-mail]("disable_locking")
-class TestVCSOperationsOnCustomIniConfig:
[e-mail]("disable_locking", "disable_anonymous_user")
+class TestVCSOperationsOnCustomIniConfig(object):
 
     def test_clone_wrong_credentials_hg_ret_code(self, rc_web_server, tmpdir):
         clone_url = rc_web_server.repo_clone_url(HG_REPO, passwd='bad!')

rhodecode/tests/other/vcs_operations/test_vcs_calls_custom_auth_code_bad_code.py

@@ -43,8 +43,8 b' def rc_web_server_config(testini_factory'
     return testini_factory(CUSTOM_PARAMS)
 
 
[e-mail]("disable_locking")
-class TestVCSOperationsOnCustomIniConfig:
[e-mail]("disable_locking", "disable_anonymous_user")
+class TestVCSOperationsOnCustomIniConfig(object):
 
     def test_clone_wrong_credentials_hg_ret_code(self, rc_web_server, tmpdir):
         clone_url = rc_web_server.repo_clone_url(HG_REPO, passwd='bad!')

rhodecode/tests/other/vcs_operations/test_vcs_operations.py

@@ -34,6 +34,7 b' import time'
 import pytest
 
 from rhodecode.lib.vcs.backends.git.repository import GitRepository
+from rhodecode.lib.vcs.backends.hg.repository import MercurialRepository
 from rhodecode.lib.vcs.nodes import FileNode
 from rhodecode.model.auth_token import AuthTokenModel
 from rhodecode.model.db import Repository, UserIpMap, CacheKey
@@ -42,11 +43,12 b' from rhodecode.model.user import UserMod'
 from rhodecode.tests import (GIT_REPO, HG_REPO, TEST_USER_ADMIN_LOGIN)
 
 from rhodecode.tests.other.vcs_operations import (
-    Command, _check_proper_clone, _check_proper_git_push, _add_files_and_push,
+    Command, _check_proper_clone, _check_proper_git_push,
+    _check_proper_hg_push, _add_files_and_push,
     HG_REPO_WITH_GROUP, GIT_REPO_WITH_GROUP)
 
 
[e-mail]("disable_locking")
[e-mail]("disable_locking", "disable_anonymous_user")
 class TestVCSOperations(object):
 
     def test_clone_hg_repo_by_admin(self, rc_web_server, tmpdir):
@@ -62,6 +64,13 b' class TestVCSOperations(object):'
         _check_proper_clone(stdout, stderr, 'git')
         cmd.assert_returncode_success()
 
+    def test_clone_git_repo_by_admin_with_git_suffix(self, rc_web_server, tmpdir):
+        clone_url = rc_web_server.repo_clone_url(GIT_REPO)
+        cmd = Command('/tmp')
+        stdout, stderr = cmd.execute('git clone', clone_url+".git", tmpdir.strpath)
+        _check_proper_clone(stdout, stderr, 'git')
+        cmd.assert_returncode_success()
+
     def test_clone_hg_repo_by_id_by_admin(self, rc_web_server, tmpdir):
         repo_id = Repository.get_by_repo_name(HG_REPO).repo_id
         clone_url = rc_web_server.repo_clone_url('_%s' % repo_id)
@@ -389,7 +398,6 b' class TestVCSOperations(object):'
             'hg clone', clone_url, tmpdir.strpath)
         assert 'abort: authorization failed' in stderr
 
-
     def test_clone_by_auth_token_with_scope(
             self, rc_web_server, tmpdir, user_util, enable_auth_plugins):
         enable_auth_plugins(['egg:rhodecode-enterprise-ce#token',
@@ -472,3 +480,176 b' def test_git_fetches_from_remote_reposit'
     source_repo = backend_git['annotated-tag']
     target_vcs_repo = backend_git.create_repo().scm_instance()
     target_vcs_repo.fetch(rc_web_server.repo_clone_url(source_repo.repo_name))
+
+
+def test_git_push_shows_pull_request_refs(backend_git, rc_web_server, tmpdir):
+    """
+    test if remote info about refs is visible
+    """
+    empty_repo = backend_git.create_repo()
+
+    clone_url = rc_web_server.repo_clone_url(empty_repo.repo_name)
+
+    cmd = Command(tmpdir.strpath)
+    cmd.execute('git clone', clone_url)
+
+    repo = GitRepository(os.path.join(tmpdir.strpath, empty_repo.repo_name))
+    repo.in_memory_commit.add(FileNode('readme.md', content='## Hello'))
+    repo.in_memory_commit.commit(
+        message='Commit on branch Master',
+        author='Automatic test',
+        branch='master')
+
+    repo_cmd = Command(repo.path)
+    stdout, stderr = repo_cmd.execute('git push --verbose origin master')
+    _check_proper_git_push(stdout, stderr, branch='master')
+
+    ref = '{}/{}/pull-request/new?branch=master'.format(
+        rc_web_server.host_url(), empty_repo.repo_name)
+    assert 'remote: RhodeCode: open pull request link: {}'.format(ref) in stderr
+    assert 'remote: RhodeCode: push completed' in stderr
+
+    # push on the same branch
+    repo = GitRepository(os.path.join(tmpdir.strpath, empty_repo.repo_name))
+    repo.in_memory_commit.add(FileNode('setup.py', content='print\n'))
+    repo.in_memory_commit.commit(
+        message='Commit2 on branch Master',
+        author='Automatic test2',
+        branch='master')
+
+    repo_cmd = Command(repo.path)
+    stdout, stderr = repo_cmd.execute('git push --verbose origin master')
+    _check_proper_git_push(stdout, stderr, branch='master')
+
+    assert 'remote: RhodeCode: open pull request link: {}'.format(ref) in stderr
+    assert 'remote: RhodeCode: push completed' in stderr
+
+    # new Branch
+    repo = GitRepository(os.path.join(tmpdir.strpath, empty_repo.repo_name))
+    repo.in_memory_commit.add(FileNode('feature1.py', content='## Hello world'))
+    repo.in_memory_commit.commit(
+        message='Commit on branch feature',
+        author='Automatic test',
+        branch='feature')
+
+    repo_cmd = Command(repo.path)
+    stdout, stderr = repo_cmd.execute('git push --verbose origin feature')
+    _check_proper_git_push(stdout, stderr, branch='feature')
+
+    ref = '{}/{}/pull-request/new?branch=feature'.format(
+        rc_web_server.host_url(), empty_repo.repo_name)
+    assert 'remote: RhodeCode: open pull request link: {}'.format(ref) in stderr
+    assert 'remote: RhodeCode: push completed' in stderr
+
+
+def test_hg_push_shows_pull_request_refs(backend_hg, rc_web_server, tmpdir):
+    empty_repo = backend_hg.create_repo()
+
+    clone_url = rc_web_server.repo_clone_url(empty_repo.repo_name)
+
+    cmd = Command(tmpdir.strpath)
+    cmd.execute('hg clone', clone_url)
+
+    repo = MercurialRepository(os.path.join(tmpdir.strpath, empty_repo.repo_name))
+    repo.in_memory_commit.add(FileNode(u'readme.md', content=u'## Hello'))
+    repo.in_memory_commit.commit(
+        message=u'Commit on branch default',
+        author=u'Automatic test',
+        branch='default')
+
+    repo_cmd = Command(repo.path)
+    repo_cmd.execute('hg checkout default')
+
+    stdout, stderr = repo_cmd.execute('hg push --verbose', clone_url)
+    _check_proper_hg_push(stdout, stderr, branch='default')
+
+    ref = '{}/{}/pull-request/new?branch=default'.format(
+        rc_web_server.host_url(), empty_repo.repo_name)
+    assert 'remote: RhodeCode: open pull request link: {}'.format(ref) in stdout
+    assert 'remote: RhodeCode: push completed' in stdout
+
+    # push on the same branch
+    repo = MercurialRepository(os.path.join(tmpdir.strpath, empty_repo.repo_name))
+    repo.in_memory_commit.add(FileNode(u'setup.py', content=u'print\n'))
+    repo.in_memory_commit.commit(
+        message=u'Commit2 on branch default',
+        author=u'Automatic test2',
+        branch=u'default')
+
+    repo_cmd = Command(repo.path)
+    repo_cmd.execute('hg checkout default')
+
+    stdout, stderr = repo_cmd.execute('hg push --verbose', clone_url)
+    _check_proper_hg_push(stdout, stderr, branch='default')
+
+    assert 'remote: RhodeCode: open pull request link: {}'.format(ref) in stdout
+    assert 'remote: RhodeCode: push completed' in stdout
+
+    # new Branch
+    repo = MercurialRepository(os.path.join(tmpdir.strpath, empty_repo.repo_name))
+    repo.in_memory_commit.add(FileNode(u'feature1.py', content=u'## Hello world'))
+    repo.in_memory_commit.commit(
+        message=u'Commit on branch feature',
+        author=u'Automatic test',
+        branch=u'feature')
+
+    repo_cmd = Command(repo.path)
+    repo_cmd.execute('hg checkout feature')
+
+    stdout, stderr = repo_cmd.execute('hg push --new-branch --verbose', clone_url)
+    _check_proper_hg_push(stdout, stderr, branch='feature')
+
+    ref = '{}/{}/pull-request/new?branch=feature'.format(
+        rc_web_server.host_url(), empty_repo.repo_name)
+    assert 'remote: RhodeCode: open pull request link: {}'.format(ref) in stdout
+    assert 'remote: RhodeCode: push completed' in stdout
+
+
+def test_hg_push_shows_pull_request_refs_book(backend_hg, rc_web_server, tmpdir):
+    empty_repo = backend_hg.create_repo()
+
+    clone_url = rc_web_server.repo_clone_url(empty_repo.repo_name)
+
+    cmd = Command(tmpdir.strpath)
+    cmd.execute('hg clone', clone_url)
+
+    repo = MercurialRepository(os.path.join(tmpdir.strpath, empty_repo.repo_name))
+    repo.in_memory_commit.add(FileNode(u'readme.md', content=u'## Hello'))
+    repo.in_memory_commit.commit(
+        message=u'Commit on branch default',
+        author=u'Automatic test',
+        branch='default')
+
+    repo_cmd = Command(repo.path)
+    repo_cmd.execute('hg checkout default')
+
+    stdout, stderr = repo_cmd.execute('hg push --verbose', clone_url)
+    _check_proper_hg_push(stdout, stderr, branch='default')
+
+    ref = '{}/{}/pull-request/new?branch=default'.format(
+        rc_web_server.host_url(), empty_repo.repo_name)
+    assert 'remote: RhodeCode: open pull request link: {}'.format(ref) in stdout
+    assert 'remote: RhodeCode: push completed' in stdout
+
+    # add bookmark
+    repo = MercurialRepository(os.path.join(tmpdir.strpath, empty_repo.repo_name))
+    repo.in_memory_commit.add(FileNode(u'setup.py', content=u'print\n'))
+    repo.in_memory_commit.commit(
+        message=u'Commit2 on branch default',
+        author=u'Automatic test2',
+        branch=u'default')
+
+    repo_cmd = Command(repo.path)
+    repo_cmd.execute('hg checkout default')
+    repo_cmd.execute('hg bookmark feature2')
+    stdout, stderr = repo_cmd.execute('hg push -B feature2 --verbose', clone_url)
+    _check_proper_hg_push(stdout, stderr, branch='default')
+
+    ref = '{}/{}/pull-request/new?branch=default'.format(
+        rc_web_server.host_url(), empty_repo.repo_name)
+    assert 'remote: RhodeCode: open pull request link: {}'.format(ref) in stdout
+    ref = '{}/{}/pull-request/new?bookmark=feature2'.format(
+        rc_web_server.host_url(), empty_repo.repo_name)
+    assert 'remote: RhodeCode: open pull request link: {}'.format(ref) in stdout
+    assert 'remote: RhodeCode: push completed' in stdout
+    assert 'exporting bookmark feature2' in stdout

rhodecode/tests/other/vcs_operations/test_vcs_operations_locking.py

@@ -50,8 +50,8 b' def rc_web_server_config(testini_factory'
     return testini_factory(CUSTOM_PARAMS)
 
 
[e-mail]("disable_locking")
-class TestVCSOperationsOnCustomIniConfig:
[e-mail]("disable_locking", "disable_anonymous_user")
+class TestVCSOperationsOnCustomIniConfig(object):
 
     def test_clone_and_create_lock_hg(self, rc_web_server, tmpdir):
         # enable locking

rhodecode/tests/other/vcs_operations/test_vcs_operations_locking_custom_code.py

@@ -49,8 +49,8 b' def rc_web_server_config(testini_factory'
     return testini_factory(CUSTOM_PARAMS)
 
 
[e-mail]("disable_locking")
-class TestVCSOperationsOnCustomIniConfig:
[e-mail]("disable_locking", "disable_anonymous_user")
+class TestVCSOperationsOnCustomIniConfig(object):
 
     def test_clone_after_repo_was_locked_hg(self, rc_web_server, tmpdir):
         # lock repo

rhodecode/tests/plugin.py

@@ -62,7 +62,7 b' from rhodecode.tests import ('
     login_user_session, get_new_dir, utils, TESTS_TMP_PATH,
     TEST_USER_ADMIN_LOGIN, TEST_USER_REGULAR_LOGIN, TEST_USER_REGULAR2_LOGIN,
     TEST_USER_REGULAR_PASS)
-from rhodecode.tests.utils import CustomTestApp
+from rhodecode.tests.utils import CustomTestApp, set_anonymous_access, add_test_routes
 from rhodecode.tests.fixture import Fixture
 
 
@@ -191,7 +191,15 b' def http_host_stub():'
     """
     Value of HTTP_HOST in the test run.
     """
-    return 'test.example.com:80'
+    return 'example.com:80'
+
+
[e-mail]
+def http_host_only_stub():
+    """
+    Value of HTTP_HOST in the test run.
+    """
+    return http_host_stub().split(':')[0]
 
 
 @pytest.fixture
@@ -204,7 +212,7 b' def http_environ(http_host_stub):'
     to override this for a specific test case.
     """
     return {
-        'SERVER_NAME': http_host_stub.split(':')[0],
+        'SERVER_NAME': http_host_only_stub(),
         'SERVER_PORT': http_host_stub.split(':')[1],
         'HTTP_HOST': http_host_stub,
         'HTTP_USER_AGENT': 'rc-test-agent',
@@ -213,7 +221,7 b' def http_environ(http_host_stub):'
 
 
 @pytest.fixture(scope='function')
-def app(request, pylonsapp, http_environ):
+def app(request, config_stub, pylonsapp, http_environ):
     app = CustomTestApp(
         pylonsapp,
         extra_environ=http_environ)
@@ -884,7 +892,7 b' class RepoServer(object):'
 
 
 @pytest.fixture
-def pr_util(backend, request):
+def pr_util(backend, request, config_stub):
     """
     Utility for tests of models and for functional tests around pull requests.
 
@@ -986,10 +994,9 b' class PRTestUtility(object):'
         return reference
 
     def _get_reviewers(self):
-        model = UserModel()
         return [
-            model.get_by_username(TEST_USER_REGULAR_LOGIN),
-            model.get_by_username(TEST_USER_REGULAR2_LOGIN),
+            (TEST_USER_REGULAR_LOGIN, ['default1'], False),
+            (TEST_USER_REGULAR2_LOGIN, ['default2'], False),
         ]
 
     def update_source_repository(self, head=None):
@@ -1078,7 +1085,7 b' class PRTestUtility(object):'
         # request will already be deleted.
         pull_request = PullRequest().get(self.pull_request_id)
         if pull_request:
-            PullRequestModel().delete(pull_request)
+            PullRequestModel().delete(pull_request, pull_request.author)
             Session().commit()
 
         if self.notification_patcher:
@@ -1641,14 +1648,6 b' def no_notifications(request):'
     request.addfinalizer(notification_patcher.stop)
 
 
[e-mail]
-def silence_action_logger(request):
-    notification_patcher = mock.patch(
-        'rhodecode.lib.utils.action_logger')
-    notification_patcher.start()
-    request.addfinalizer(notification_patcher.stop)
-
-
 @pytest.fixture(scope='session')
 def repeat(request):
     """
@@ -1676,11 +1675,21 b' def request_stub():'
 
 
 @pytest.fixture
+def context_stub():
+    """
+    Stub context object.
+    """
+    context = pyramid.testing.DummyResource()
+    return context
+
+
[e-mail]
 def config_stub(request, request_stub):
     """
     Set up pyramid.testing and return the Configurator.
     """
     config = pyramid.testing.setUp(request=request_stub)
+    add_test_routes(config)
 
     @request.addfinalizer
     def cleanup():
@@ -1701,7 +1710,7 b' def StubIntegrationType():'
 
         def __init__(self, settings):
             super(_StubIntegrationType, self).__init__(settings)
-            self.sent_events = [] # for testing
+            self.sent_events = []  # for testing
 
         def send_event(self, event):
             self.sent_events.append(event)
@@ -1812,3 +1821,12 b' def local_dt_to_utc():'
         return dt.replace(tzinfo=dateutil.tz.tzlocal()).astimezone(
             dateutil.tz.tzutc()).replace(tzinfo=None)
     return _factory
+
+
[e-mail]
+def disable_anonymous_user(request, pylonsapp):
+    set_anonymous_access(False)
+
+    @request.addfinalizer
+    def cleanup():
+        set_anonymous_access(True)

rhodecode/tests/scripts/test_concurency.py

@@ -138,14 +138,6 b' def create_test_repo(force=True):'
     print 'done'
 
 
-def set_anonymous_access(enable=True):
-    sa = get_session()
-    user = sa.query(User).filter(User.username == 'default').one()
-    user.active = enable
-    sa.add(user)
-    sa.commit()
-
-
 def get_anonymous_access():
     sa = get_session()
     return sa.query(User).filter(User.username == 'default').one().active

rhodecode/tests/utils.py

@@ -94,6 +94,14 b' class CustomTestResponse(TestResponse):'
     def assert_response(self):
         return AssertResponse(self)
 
+    def get_session_from_response(self):
+        """
+        This returns the session from a response object. Pylons has some magic
+        to make the session available as `response.session`. But pyramid
+        doesn't expose it.
+        """
+        return self.request.environ['beaker.session']
+
 
 class TestRequest(Request):
 
@@ -109,15 +117,13 b' class CustomTestApp(TestApp):'
     RequestClass = TestRequest
 
 
-
-
-
 def set_anonymous_access(enabled):
     """(Dis)allows anonymous access depending on parameter `enabled`"""
     user = User.get_default_user()
     user.active = enabled
     Session().add(user)
     Session().commit()
+    time.sleep(1.5)  # must sleep for cache (1s to expire)
     log.info('anonymous access is now: %s', enabled)
     assert enabled == User.get_default_user().active, (
         'Cannot set anonymous access')
@@ -357,16 +363,6 b' def is_url_reachable(url):'
     return True
 
 
-def get_session_from_response(response):
-    """
-    This returns the session from a response object. Pylons has some magic
-    to make the session available as `response.session`. But pyramid
-    doesn't expose it.
-    """
-    # TODO: Try to look up the session key also.
-    return response.request.environ['beaker.session']
-
-
 def repo_on_filesystem(repo_name):
     from rhodecode.lib import vcs
     from rhodecode.tests import TESTS_TMP_PATH
@@ -407,3 +403,21 b' def commit_change('
             f_path=filename
         )
     return commit
+
+
+def add_test_routes(config):
+    """
+    Adds test routing that can be used in different functional tests
+
+    """
+    config.add_route(name='home', pattern='/')
+    config.add_route(name='repo_summary', pattern='/{repo_name}')
+    config.add_route(name='repo_summary_explicit', pattern='/{repo_name}/summary')
+    config.add_route(name='repo_group_home', pattern='/{repo_group_name}')
+
+    config.add_route(name='pullrequest_show',
+                     pattern='/{repo_name}/pull-request/{pull_request_id}')
+    config.add_route(name='pull_requests_global',
+                     pattern='/pull-request/{pull_request_id}')
+    config.add_route(name='repo_commit',
+                     pattern='/{repo_name}/changeset/{commit_id}')

rhodecode/tests/vcs/test_hg_vcsserver_cache_invalidation.py

@@ -114,7 +114,7 b' class TestMercurialRemoteRepoInvalidatio'
         return shadow_repo, source_ref, target_ref
 
     @pytest.mark.backends('hg')
-    def test_commit_does_not_exist_error_happens(self, pr_util, pylonsapp):
+    def test_commit_does_not_exist_error_happens(self, pr_util, app):
         """
         This test is somewhat special. It does not really test the system
         instead it is more or less a precondition for the
@@ -152,8 +152,7 b' class TestMercurialRemoteRepoInvalidatio'
             shadow_repo.get_commit(source_ref.commit_id)
 
     @pytest.mark.backends('hg')
-    def test_commit_does_not_exist_error_does_not_happen(
-            self, pr_util, pylonsapp):
+    def test_commit_does_not_exist_error_does_not_happen(self, pr_util, app):
         """
         This test simulates a pull request merge in which the pull operations
         are handled by a different VCSServer process than all other operations.

rhodecode/controllers/admin/admin.py

@@ -1,89 +0,0 b''
-# -*- coding: utf-8 -*-
-
-# Copyright (C) 2010-2017 RhodeCode GmbH
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Affero General Public License, version 3
-# (only), as published by the Free Software Foundation.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU Affero General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-# This program is dual-licensed. If you wish to learn more about the
-# RhodeCode Enterprise Edition, including its added features, Support services,
-# and proprietary license terms, please see https://rhodecode.com/licenses/
-
-"""
-Controller for Admin panel of RhodeCode Enterprise
-"""
-
-
-import logging
-
-from pylons import request, tmpl_context as c, url
-from pylons.controllers.util import redirect
-from sqlalchemy.orm import joinedload
-
-from rhodecode.model.db import UserLog, PullRequest
-from rhodecode.lib.user_log_filter import user_log_filter
-from rhodecode.lib.auth import LoginRequired, HasPermissionAllDecorator
-from rhodecode.lib.base import BaseController, render
-from rhodecode.lib.utils2 import safe_int
-from rhodecode.lib.helpers import Page
-
-
-log = logging.getLogger(__name__)
-
-
-class AdminController(BaseController):
-
-    @LoginRequired()
-    def __before__(self):
-        super(AdminController, self).__before__()
-
-    @HasPermissionAllDecorator('hg.admin')
-    def index(self):
-        users_log = UserLog.query()\
-            .options(joinedload(UserLog.user))\
-            .options(joinedload(UserLog.repository))
-
-        # FILTERING
-        c.search_term = request.GET.get('filter')
-        try:
-            users_log = user_log_filter(users_log, c.search_term)
-        except Exception:
-            # we want this to crash for now
-            raise
-
-        users_log = users_log.order_by(UserLog.action_date.desc())
-
-        p = safe_int(request.GET.get('page', 1), 1)
-
-        def url_generator(**kw):
-            return url.current(filter=c.search_term, **kw)
-
-        c.users_log = Page(users_log, page=p, items_per_page=10,
-                           url=url_generator)
-        c.log_data = render('admin/admin_log.mako')
-
-        if request.is_xhr:
-            return c.log_data
-        return render('admin/admin.mako')
-
-    # global redirect doesn't need permissions
-    def pull_requests(self, pull_request_id):
-        """
-        Global redirect for Pull Requests
-
-        :param pull_request_id: id of pull requests in the system
-        """
-        pull_request = PullRequest.get_or_404(pull_request_id)
-        repo_name = pull_request.target_repo.repo_name
-        return redirect(url(
-            'pullrequest_show', repo_name=repo_name,
-            pull_request_id=pull_request_id))

rhodecode/controllers/base_references.py

@@ -1,85 +0,0 b''
-# -*- coding: utf-8 -*-
-
-# Copyright (C) 2010-2017 RhodeCode GmbH
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Affero General Public License, version 3
-# (only), as published by the Free Software Foundation.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU Affero General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-# This program is dual-licensed. If you wish to learn more about the
-# RhodeCode Enterprise Edition, including its added features, Support services,
-# and proprietary license terms, please see https://rhodecode.com/licenses/
-
-from pylons import tmpl_context as c
-
-from rhodecode.controllers import utils
-from rhodecode.lib import helpers as h
-from rhodecode.lib.auth import LoginRequired, HasRepoPermissionAnyDecorator
-from rhodecode.lib.base import BaseRepoController, render
-from rhodecode.lib.ext_json import json
-from rhodecode.lib.utils import PartialRenderer
-from rhodecode.lib.utils2 import datetime_to_time
-
-
-class BaseReferencesController(BaseRepoController):
-    """
-    Base for reference controllers for branches, tags and bookmarks.
-
-    Implement and set the following things:
-
-    - `partials_template` is the source for the partials to use.
-
-    - `template` is the template to render in the end.
-
-    - `_get_reference_items(repo)` should return a sequence of tuples which
-      map from `name` to `commit_id`.
-
-    """
-
-    @LoginRequired()
-    @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
-                                   'repository.admin')
-    def index(self):
-        _render = PartialRenderer(self.partials_template)
-        _data = []
-        pre_load = ["author", "date", "message"]
-        repo = c.rhodecode_repo
-        is_svn = h.is_svn(repo)
-        format_ref_id = utils.get_format_ref_id(repo)
-
-        for ref_name, commit_id in self._get_reference_items(repo):
-            commit = repo.get_commit(
-                commit_id=commit_id, pre_load=pre_load)
-
-            # TODO: johbo: Unify generation of reference links
-            use_commit_id = '/' in ref_name or is_svn
-            files_url = h.url(
-                'files_home',
-                repo_name=c.repo_name,
-                f_path=ref_name if is_svn else '',
-                revision=commit_id if use_commit_id else ref_name,
-                at=ref_name)
-
-            _data.append({
-                "name": _render('name', ref_name, files_url),
-                "name_raw": ref_name,
-                "date": _render('date', commit.date),
-                "date_raw": datetime_to_time(commit.date),
-                "author": _render('author', commit.author),
-                "commit": _render(
-                    'commit', commit.message, commit.raw_id, commit.idx),
-                "commit_raw": commit.idx,
-                "compare": _render(
-                    'compare', format_ref_id(ref_name, commit.raw_id)),
-            })
-        c.has_references = bool(_data)
-        c.data = json.dumps(_data)
-        return render(self.template)

rhodecode/controllers/bookmarks.py

@@ -1,46 +0,0 b''
-# -*- coding: utf-8 -*-
-
-# Copyright (C) 2011-2017 RhodeCode GmbH
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Affero General Public License, version 3
-# (only), as published by the Free Software Foundation.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU Affero General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-# This program is dual-licensed. If you wish to learn more about the
-# RhodeCode Enterprise Edition, including its added features, Support services,
-# and proprietary license terms, please see https://rhodecode.com/licenses/
-"""
-Bookmarks controller for rhodecode
-"""
-
-import logging
-
-from pylons import tmpl_context as c
-from webob.exc import HTTPNotFound
-
-from rhodecode.controllers.base_references import BaseReferencesController
-from rhodecode.lib import helpers as h
-
-log = logging.getLogger(__name__)
-
-
-class BookmarksController(BaseReferencesController):
-
-    partials_template = 'bookmarks/bookmarks_data.mako'
-    template = 'bookmarks/bookmarks.mako'
-
-    def __before__(self):
-        super(BookmarksController, self).__before__()
-        if not h.is_hg(c.rhodecode_repo):
-            raise HTTPNotFound()
-
-    def _get_reference_items(self, repo):
-        return repo.bookmarks.items()

rhodecode/controllers/branches.py

@@ -1,45 +0,0 b''
-# -*- coding: utf-8 -*-
-
-# Copyright (C) 2010-2017 RhodeCode GmbH
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Affero General Public License, version 3
-# (only), as published by the Free Software Foundation.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU Affero General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-# This program is dual-licensed. If you wish to learn more about the
-# RhodeCode Enterprise Edition, including its added features, Support services,
-# and proprietary license terms, please see https://rhodecode.com/licenses/
-
-"""
-branches controller for rhodecode
-"""
-
-import logging
-
-from pylons import tmpl_context as c
-
-from rhodecode.controllers.base_references import BaseReferencesController
-
-
-log = logging.getLogger(__name__)
-
-
-class BranchesController(BaseReferencesController):
-
-    partials_template = 'branches/branches_data.mako'
-    template = 'branches/branches.mako'
-
-    def __before__(self):
-        super(BranchesController, self).__before__()
-        c.closed_branches = c.rhodecode_repo.branches_closed
-
-    def _get_reference_items(self, repo):
-        return repo.branches_all.items()

rhodecode/controllers/search.py

@@ -1,111 +0,0 b''
-# -*- coding: utf-8 -*-
-
-# Copyright (C) 2010-2017 RhodeCode GmbH
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Affero General Public License, version 3
-# (only), as published by the Free Software Foundation.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU Affero General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-# This program is dual-licensed. If you wish to learn more about the
-# RhodeCode Enterprise Edition, including its added features, Support services,
-# and proprietary license terms, please see https://rhodecode.com/licenses/
-
-"""
-Search controller for RhodeCode
-"""
-
-import logging
-import urllib
-
-from pylons import request, config, tmpl_context as c
-
-from webhelpers.util import update_params
-
-from rhodecode.lib.auth import LoginRequired, AuthUser
-from rhodecode.lib.base import BaseRepoController, render
-from rhodecode.lib.helpers import Page
-from rhodecode.lib.utils2 import safe_str, safe_int
-from rhodecode.lib.index import searcher_from_config
-from rhodecode.model import validation_schema
-from rhodecode.model.validation_schema.schemas import search_schema
-
-log = logging.getLogger(__name__)
-
-
-class SearchController(BaseRepoController):
-
-    @LoginRequired()
-    def index(self, repo_name=None):
-
-        searcher = searcher_from_config(config)
-        formatted_results = []
-        execution_time = ''
-
-        schema = search_schema.SearchParamsSchema()
-
-        search_params = {}
-        errors = []
-        try:
-            search_params = schema.deserialize(
-                dict(search_query=request.GET.get('q'),
-                     search_type=request.GET.get('type'),
-                     search_sort=request.GET.get('sort'),
-                     page_limit=request.GET.get('page_limit'),
-                     requested_page=request.GET.get('page'))
-            )
-        except validation_schema.Invalid as e:
-            errors = e.children
-
-        def url_generator(**kw):
-            q = urllib.quote(safe_str(search_query))
-            return update_params(
-                "?q=%s&type=%s" % (q, safe_str(search_type)), **kw)
-
-        search_query = search_params.get('search_query')
-        search_type = search_params.get('search_type')
-        search_sort = search_params.get('search_sort')
-        if search_params.get('search_query'):
-            page_limit = search_params['page_limit']
-            requested_page = search_params['requested_page']
-
-            c.perm_user = AuthUser(user_id=c.rhodecode_user.user_id,
-                                   ip_addr=self.ip_addr)
-
-            try:
-                search_result = searcher.search(
-                    search_query, search_type, c.perm_user, repo_name,
-                    requested_page, page_limit, search_sort)
-
-                formatted_results = Page(
-                    search_result['results'], page=requested_page,
-                    item_count=search_result['count'],
-                    items_per_page=page_limit, url=url_generator)
-            finally:
-                searcher.cleanup()
-
-            if not search_result['error']:
-                execution_time = '%s results (%.3f seconds)' % (
-                    search_result['count'],
-                    search_result['runtime'])
-            elif not errors:
-                node = schema['search_query']
-                errors = [
-                    validation_schema.Invalid(node, search_result['error'])]
-
-        c.sort = search_sort
-        c.url_generator = url_generator
-        c.errors = errors
-        c.formatted_results = formatted_results
-        c.runtime = execution_time
-        c.cur_query = search_query
-        c.search_type = search_type
-        # Return a rendered template
-        return render('/search/search.mako')

rhodecode/controllers/summary.py

@@ -1,326 +0,0 b''
-# -*- coding: utf-8 -*-
-
-# Copyright (C) 2010-2017 RhodeCode GmbH
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Affero General Public License, version 3
-# (only), as published by the Free Software Foundation.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU Affero General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-# This program is dual-licensed. If you wish to learn more about the
-# RhodeCode Enterprise Edition, including its added features, Support services,
-# and proprietary license terms, please see https://rhodecode.com/licenses/
-
-"""
-Summary controller for RhodeCode Enterprise
-"""
-
-import logging
-from string import lower
-
-from pylons import tmpl_context as c, request
-from pylons.i18n.translation import _
-from beaker.cache import cache_region, region_invalidate
-
-from rhodecode.config.conf import (LANGUAGES_EXTENSIONS_MAP)
-from rhodecode.controllers import utils
-from rhodecode.controllers.changelog import _load_changelog_summary
-from rhodecode.lib import caches, helpers as h
-from rhodecode.lib.utils import jsonify
-from rhodecode.lib.utils2 import safe_str
-from rhodecode.lib.auth import (
-    LoginRequired, HasRepoPermissionAnyDecorator, NotAnonymous, XHRRequired)
-from rhodecode.lib.base import BaseRepoController, render
-from rhodecode.lib.markup_renderer import MarkupRenderer, relative_links
-from rhodecode.lib.ext_json import json
-from rhodecode.lib.vcs.backends.base import EmptyCommit
-from rhodecode.lib.vcs.exceptions import (
-    CommitError, EmptyRepositoryError, NodeDoesNotExistError)
-from rhodecode.model.db import Statistics, CacheKey, User
-from rhodecode.model.repo import ReadmeFinder
-
-
-log = logging.getLogger(__name__)
-
-
-class SummaryController(BaseRepoController):
-
-    def __before__(self):
-        super(SummaryController, self).__before__()
-
-    def __get_readme_data(self, db_repo):
-        repo_name = db_repo.repo_name
-        log.debug('Looking for README file')
-        default_renderer = c.visual.default_renderer
-
-        @cache_region('long_term')
-        def _generate_readme(cache_key):
-            readme_data = None
-            readme_node = None
-            readme_filename = None
-            commit = self._get_landing_commit_or_none(db_repo)
-            if commit:
-                log.debug("Searching for a README file.")
-                readme_node = ReadmeFinder(default_renderer).search(commit)
-            if readme_node:
-                relative_url = h.url('files_raw_home',
-                                     repo_name=repo_name,
-                                     revision=commit.raw_id,
-                                     f_path=readme_node.path)
-                readme_data = self._render_readme_or_none(
-                    commit, readme_node, relative_url)
-                readme_filename = readme_node.path
-            return readme_data, readme_filename
-
-        invalidator_context = CacheKey.repo_context_cache(
-            _generate_readme, repo_name, CacheKey.CACHE_TYPE_README)
-
-        with invalidator_context as context:
-            context.invalidate()
-            computed = context.compute()
-
-        return computed
-
-    def _get_landing_commit_or_none(self, db_repo):
-        log.debug("Getting the landing commit.")
-        try:
-            commit = db_repo.get_landing_commit()
-            if not isinstance(commit, EmptyCommit):
-                return commit
-            else:
-                log.debug("Repository is empty, no README to render.")
-        except CommitError:
-            log.exception(
-                "Problem getting commit when trying to render the README.")
-
-    def _render_readme_or_none(self, commit, readme_node, relative_url):
-        log.debug(
-            'Found README file `%s` rendering...', readme_node.path)
-        renderer = MarkupRenderer()
-        try:
-            html_source = renderer.render(
-                readme_node.content, filename=readme_node.path)
-            if relative_url:
-                return relative_links(html_source, relative_url)
-            return html_source
-        except Exception:
-            log.exception(
-                "Exception while trying to render the README")
-
-    @LoginRequired()
-    @HasRepoPermissionAnyDecorator(
-        'repository.read', 'repository.write', 'repository.admin')
-    def index(self, repo_name):
-
-        # Prepare the clone URL
-
-        username = ''
-        if c.rhodecode_user.username != User.DEFAULT_USER:
-            username = safe_str(c.rhodecode_user.username)
-
-        _def_clone_uri = _def_clone_uri_by_id = c.clone_uri_tmpl
-        if '{repo}' in _def_clone_uri:
-            _def_clone_uri_by_id = _def_clone_uri.replace(
-                '{repo}', '_{repoid}')
-        elif '{repoid}' in _def_clone_uri:
-            _def_clone_uri_by_id = _def_clone_uri.replace(
-                '_{repoid}', '{repo}')
-
-        c.clone_repo_url = c.rhodecode_db_repo.clone_url(
-            user=username, uri_tmpl=_def_clone_uri)
-        c.clone_repo_url_id = c.rhodecode_db_repo.clone_url(
-            user=username, uri_tmpl=_def_clone_uri_by_id)
-
-        # If enabled, get statistics data
-
-        c.show_stats = bool(c.rhodecode_db_repo.enable_statistics)
-
-        stats = self.sa.query(Statistics)\
-            .filter(Statistics.repository == c.rhodecode_db_repo)\
-            .scalar()
-
-        c.stats_percentage = 0
-
-        if stats and stats.languages:
-            c.no_data = False is c.rhodecode_db_repo.enable_statistics
-            lang_stats_d = json.loads(stats.languages)
-
-            # Sort first by decreasing count and second by the file extension,
-            # so we have a consistent output.
-            lang_stats_items = sorted(lang_stats_d.iteritems(),
-                                      key=lambda k: (-k[1], k[0]))[:10]
-            lang_stats = [(x, {"count": y,
-                               "desc": LANGUAGES_EXTENSIONS_MAP.get(x)})
-                          for x, y in lang_stats_items]
-
-            c.trending_languages = json.dumps(lang_stats)
-        else:
-            c.no_data = True
-            c.trending_languages = json.dumps({})
-
-        c.enable_downloads = c.rhodecode_db_repo.enable_downloads
-        c.repository_followers = self.scm_model.get_followers(
-            c.rhodecode_db_repo)
-        c.repository_forks = self.scm_model.get_forks(c.rhodecode_db_repo)
-        c.repository_is_user_following = self.scm_model.is_following_repo(
-            c.repo_name, c.rhodecode_user.user_id)
-
-        if c.repository_requirements_missing:
-            return render('summary/missing_requirements.mako')
-
-        c.readme_data, c.readme_file = \
-            self.__get_readme_data(c.rhodecode_db_repo)
-
-        _load_changelog_summary()
-
-        if request.is_xhr:
-            return render('changelog/changelog_summary_data.mako')
-
-        return render('summary/summary.mako')
-
-    @LoginRequired()
-    @XHRRequired()
-    @HasRepoPermissionAnyDecorator(
-        'repository.read', 'repository.write', 'repository.admin')
-    @jsonify
-    def repo_stats(self, repo_name, commit_id):
-        _namespace = caches.get_repo_namespace_key(
-            caches.SUMMARY_STATS, repo_name)
-        show_stats = bool(c.rhodecode_db_repo.enable_statistics)
-        cache_manager = caches.get_cache_manager('repo_cache_long', _namespace)
-        _cache_key = caches.compute_key_from_params(
-            repo_name, commit_id, show_stats)
-
-        def compute_stats():
-            code_stats = {}
-            size = 0
-            try:
-                scm_instance = c.rhodecode_db_repo.scm_instance()
-                commit = scm_instance.get_commit(commit_id)
-
-                for node in commit.get_filenodes_generator():
-                    size += node.size
-                    if not show_stats:
-                        continue
-                    ext = lower(node.extension)
-                    ext_info = LANGUAGES_EXTENSIONS_MAP.get(ext)
-                    if ext_info:
-                        if ext in code_stats:
-                            code_stats[ext]['count'] += 1
-                        else:
-                            code_stats[ext] = {"count": 1, "desc": ext_info}
-            except EmptyRepositoryError:
-                pass
-            return {'size': h.format_byte_size_binary(size),
-                    'code_stats': code_stats}
-
-        stats = cache_manager.get(_cache_key, createfunc=compute_stats)
-        return stats
-
-    def _switcher_reference_data(self, repo_name, references, is_svn):
-        """Prepare reference data for given `references`"""
-        items = []
-        for name, commit_id in references.items():
-            use_commit_id = '/' in name or is_svn
-            items.append({
-                'name': name,
-                'commit_id': commit_id,
-                'files_url': h.url(
-                    'files_home',
-                    repo_name=repo_name,
-                    f_path=name if is_svn else '',
-                    revision=commit_id if use_commit_id else name,
-                    at=name)
-            })
-        return items
-
-    @LoginRequired()
-    @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
-                                   'repository.admin')
-    @jsonify
-    def repo_refs_data(self, repo_name):
-        repo = c.rhodecode_repo
-        refs_to_create = [
-            (_("Branch"), repo.branches, 'branch'),
-            (_("Tag"), repo.tags, 'tag'),
-            (_("Bookmark"), repo.bookmarks, 'book'),
-        ]
-        res = self._create_reference_data(repo, repo_name, refs_to_create)
-        data = {
-            'more': False,
-            'results': res
-        }
-        return data
-
-    @LoginRequired()
-    @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
-                                   'repository.admin')
-    @jsonify
-    def repo_default_reviewers_data(self, repo_name):
-        return {
-            'reviewers': [utils.reviewer_as_json(
-                user=c.rhodecode_db_repo.user, reasons=None)]
-        }
-
-    @jsonify
-    def repo_refs_changelog_data(self, repo_name):
-        repo = c.rhodecode_repo
-
-        refs_to_create = [
-            (_("Branches"), repo.branches, 'branch'),
-            (_("Closed branches"), repo.branches_closed, 'branch_closed'),
-            # TODO: enable when vcs can handle bookmarks filters
-            # (_("Bookmarks"), repo.bookmarks, "book"),
-        ]
-        res = self._create_reference_data(repo, repo_name, refs_to_create)
-        data = {
-            'more': False,
-            'results': res
-        }
-        return data
-
-    def _create_reference_data(self, repo, full_repo_name, refs_to_create):
-        format_ref_id = utils.get_format_ref_id(repo)
-
-        result = []
-        for title, refs, ref_type in refs_to_create:
-            if refs:
-                result.append({
-                    'text': title,
-                    'children': self._create_reference_items(
-                        repo, full_repo_name, refs, ref_type, format_ref_id),
-                })
-        return result
-
-    def _create_reference_items(self, repo, full_repo_name, refs, ref_type,
-                                format_ref_id):
-        result = []
-        is_svn = h.is_svn(repo)
-        for ref_name, raw_id in refs.iteritems():
-            files_url = self._create_files_url(
-                repo, full_repo_name, ref_name, raw_id, is_svn)
-            result.append({
-                'text': ref_name,
-                'id': format_ref_id(ref_name, raw_id),
-                'raw_id': raw_id,
-                'type': ref_type,
-                'files_url': files_url,
-            })
-        return result
-
-    def _create_files_url(self, repo, full_repo_name, ref_name, raw_id,
-                          is_svn):
-        use_commit_id = '/' in ref_name or is_svn
-        return h.url(
-            'files_home',
-            repo_name=full_repo_name,
-            f_path=ref_name if is_svn else '',
-            revision=raw_id if use_commit_id else ref_name,
-            at=ref_name)

rhodecode/controllers/tags.py

@@ -1,38 +0,0 b''
-# -*- coding: utf-8 -*-
-
-# Copyright (C) 2010-2017 RhodeCode GmbH
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Affero General Public License, version 3
-# (only), as published by the Free Software Foundation.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU Affero General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-# This program is dual-licensed. If you wish to learn more about the
-# RhodeCode Enterprise Edition, including its added features, Support services,
-# and proprietary license terms, please see https://rhodecode.com/licenses/
-
-"""
-Tags controller for rhodecode
-"""
-
-import logging
-
-from rhodecode.controllers.base_references import BaseReferencesController
-
-log = logging.getLogger(__name__)
-
-
-class TagsController(BaseReferencesController):
-
-    partials_template = 'tags/tags_data.mako'
-    template = 'tags/tags.mako'
-
-    def _get_reference_items(self, repo):
-        return repo.tags.items()

rhodecode/templates/admin/admin_log.mako

@@ -1,60 +0,0 b''
-## -*- coding: utf-8 -*-
-<%namespace name="base" file="/base/base.mako"/>
-
-%if c.users_log:
-<table class="rctable admin_log">
-    <tr>
-        <th>${_('Username')}</th>
-        <th>${_('Action')}</th>
-        <th>${_('Repository')}</th>
-        <th>${_('Date')}</th>
-        <th>${_('From IP')}</th>
-    </tr>
-
-    %for cnt,l in enumerate(c.users_log):
-    <tr class="parity${cnt%2}">
-        <td class="td-user">
-            %if l.user is not None:
-              ${base.gravatar_with_user(l.user.email)}
-            %else:
-              ${l.username}
-            %endif
-        </td>
-        <td class="td-journalaction">${h.action_parser(l)[0]()}
-            <div class="journal_action_params">
-                ${h.literal(h.action_parser(l)[1]())}
-            </div>
-        </td>
-        <td class="td-componentname">
-            %if l.repository is not None:
-              ${h.link_to(l.repository.repo_name,h.url('summary_home',repo_name=l.repository.repo_name))}
-            %else:
-              ${l.repository_name}
-            %endif
-        </td>
-
-        <td class="td-time">${h.format_date(l.action_date)}</td>
-        <td class="td-ip">${l.user_ip}</td>
-    </tr>
-    %endfor
-</table>
-
-<div class="pagination-wh pagination-left">
-${c.users_log.pager('$link_previous ~2~ $link_next')}
-</div>
-%else:
-    ${_('No actions yet')}
-%endif
-
-<script type="text/javascript">
-    $(function(){
-        //because this is loaded on every pjax request, it must run only once
-        //therefore the .one method
-        $(document).on('pjax:complete',function(){
-            show_more_event();
-        });
-
-        $(document).pjax('#user_log .pager_link', '#user_log');
-    });
-</script>
-

rhodecode/templates/changelog/changelog_summary_data.mako

@@ -1,136 +0,0 b''
-## -*- coding: utf-8 -*-
-<%namespace name="base" file="/base/base.mako"/>
-%if c.repo_commits:
-<table class="rctable repo_summary table_disp">
-    <tr>
-
-        <th class="status" colspan="2"></th>
-        <th>${_('Commit')}</th>
-        <th>${_('Commit message')}</th>
-        <th>${_('Age')}</th>
-        <th>${_('Author')}</th>
-        <th>${_('Refs')}</th>
-    </tr>
-%for cnt,cs in enumerate(c.repo_commits):
-    <tr class="parity${cnt%2}">
-
-        <td class="td-status">
-            %if c.statuses.get(cs.raw_id):
-                <div class="changeset-status-ico shortlog">
-                    %if c.statuses.get(cs.raw_id)[2]:
-                    <a class="tooltip" title="${_('Commit status: %s\nClick to open associated pull request #%s') % (c.statuses.get(cs.raw_id)[0], c.statuses.get(cs.raw_id)[2])}" href="${h.url('pullrequest_show',repo_name=c.statuses.get(cs.raw_id)[3],pull_request_id=c.statuses.get(cs.raw_id)[2])}">
-                        <div class="${'flag_status %s' % c.statuses.get(cs.raw_id)[0]}"></div>
-                    </a>
-                    %else:
-                    <a class="tooltip" title="${_('Commit status: %s') % h.commit_status_lbl(c.statuses.get(cs.raw_id)[0])}" href="${h.url('changeset_home',repo_name=c.repo_name,revision=cs.raw_id,anchor='comment-%s' % c.comments[cs.raw_id][0].comment_id)}">
-                        <div class="${'flag_status %s' % c.statuses.get(cs.raw_id)[0]}"></div>
-                    </a>
-                    %endif
-                </div>
-            %else:
-                <div class="tooltip flag_status not_reviewed" title="${_('Commit status: Not Reviewed')}"></div>
-            %endif
-        </td>
-        <td class="td-comments">
-            %if c.comments.get(cs.raw_id,[]):
-            <a title="${_('Commit has comments')}" href="${h.url('changeset_home',repo_name=c.repo_name,revision=cs.raw_id,anchor='comment-%s' % c.comments[cs.raw_id][0].comment_id)}">
-                <i class="icon-comment"></i> ${len(c.comments[cs.raw_id])}
-            </a>
-            %endif
-        </td>
-        <td class="td-commit">
-            <pre><a href="${h.url('changeset_home', repo_name=c.repo_name, revision=cs.raw_id)}">${h.show_id(cs)}</a></pre>
-        </td>
-
-        <td class="td-description mid">
-          <div class="log-container truncate-wrap">
-              <div class="message truncate" id="c-${cs.raw_id}">${h.urlify_commit_message(cs.message, c.repo_name)}</div>
-          </div>
-        </td>
-
-        <td class="td-time">
-            ${h.age_component(cs.date)}
-        </td>
-        <td class="td-user author">
-            ${base.gravatar_with_user(cs.author)}
-        </td>
-
-        <td class="td-tags">
-          <div class="autoexpand">
-            %if h.is_hg(c.rhodecode_repo):
-                %for book in cs.bookmarks:
-                     <span class="booktag tag" title="${_('Bookmark %s') % book}">
-                     <a href="${h.url('files_home',repo_name=c.repo_name,revision=cs.raw_id)}"><i class="icon-bookmark"></i>${h.shorter(book)}</a>
-                     </span>
-                %endfor
-            %endif
-            ## tags
-            %for tag in cs.tags:
-             <span class="tagtag tag" title="${_('Tag %s') % tag}">
-             <a href="${h.url('files_home',repo_name=c.repo_name,revision=cs.raw_id)}"><i class="icon-tag"></i>${h.shorter(tag)}</a>
-             </span>
-            %endfor
-
-            ## branch
-            %if cs.branch:
-             <span class="branchtag tag" title="${_('Branch %s') % cs.branch}">
-              <a href="${h.url('changelog_home',repo_name=c.repo_name,branch=cs.branch)}"><i class="icon-code-fork"></i>${h.shorter(cs.branch)}</a>
-             </span>
-            %endif
-          </div>
-        </td>
-    </tr>
-%endfor
-
-</table>
-
-<script type="text/javascript">
-  $(document).pjax('#shortlog_data .pager_link','#shortlog_data', {timeout: 2000, scrollTo: false });
-  $(document).on('pjax:success', function(){ timeagoActivate(); });
-</script>
-
-<div class="pagination-wh pagination-left">
-${c.repo_commits.pager('$link_previous ~2~ $link_next')}
-</div>
-%else:
-
-%if h.HasRepoPermissionAny('repository.write','repository.admin')(c.repo_name):
-<div class="quick_start">
-  <div class="fieldset">
-    <div class="left-label">${_('Add or upload files directly via RhodeCode:')}</div>
-    <div class="right-content">
-      <div id="add_node_id" class="add_node">
-          <a href="${h.url('files_add_home',repo_name=c.repo_name,revision=0,f_path='', anchor='edit')}" class="btn btn-default">${_('Add New File')}</a>
-      </div>
-    </div>
-    %endif
-  </div>
-
-  %if not h.is_svn(c.rhodecode_repo):
-  <div class="fieldset">
-    <div class="left-label">${_('Push new repo:')}</div>
-    <div class="right-content">
-      <pre>
-${c.rhodecode_repo.alias} clone ${c.clone_repo_url}
-${c.rhodecode_repo.alias} add README # add first file
-${c.rhodecode_repo.alias} commit -m "Initial" # commit with message
-${c.rhodecode_repo.alias} push ${'origin master' if h.is_git(c.rhodecode_repo) else ''} # push changes back
-      </pre>
-    </div>
-  </div>
-  <div class="fieldset">
-    <div class="left-label">${_('Existing repository?')}</div>
-    <div class="right-content">
-      <pre>
-      %if h.is_git(c.rhodecode_repo):
-git remote add origin ${c.clone_repo_url}
-git push -u origin master
-      %else:
-hg push ${c.clone_repo_url}
-      %endif
-      </pre>
-    </div>
-  </div>
-  %endif
-</div>
-%endif

rhodecode/tests/functional/test_admin.py

@@ -1,172 +0,0 b''
-# -*- coding: utf-8 -*-
-
-# Copyright (C) 2010-2017 RhodeCode GmbH
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Affero General Public License, version 3
-# (only), as published by the Free Software Foundation.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU Affero General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-# This program is dual-licensed. If you wish to learn more about the
-# RhodeCode Enterprise Edition, including its added features, Support services,
-# and proprietary license terms, please see https://rhodecode.com/licenses/
-
-import os
-import csv
-import datetime
-
-import pytest
-
-from rhodecode.tests import *
-from rhodecode.model.db import UserLog
-from rhodecode.model.meta import Session
-from rhodecode.lib.utils2 import safe_unicode
-
-dn = os.path.dirname
-FIXTURES = os.path.join(dn(dn(os.path.abspath(__file__))), 'fixtures')
-
-
-class TestAdminController(TestController):
-
-    @pytest.fixture(scope='class', autouse=True)
-    def prepare(self, request, pylonsapp):
-        UserLog.query().delete()
-        Session().commit()
-
-        def strptime(val):
-            fmt = '%Y-%m-%d %H:%M:%S'
-            if '.' not in val:
-                return datetime.datetime.strptime(val, fmt)
-
-            nofrag, frag = val.split(".")
-            date = datetime.datetime.strptime(nofrag, fmt)
-
-            frag = frag[:6]  # truncate to microseconds
-            frag += (6 - len(frag)) * '0'  # add 0s
-            return date.replace(microsecond=int(frag))
-
-        with open(os.path.join(FIXTURES, 'journal_dump.csv')) as f:
-            for row in csv.DictReader(f):
-                ul = UserLog()
-                for k, v in row.iteritems():
-                    v = safe_unicode(v)
-                    if k == 'action_date':
-                        v = strptime(v)
-                    if k in ['user_id', 'repository_id']:
-                        # nullable due to FK problems
-                        v = None
-                    setattr(ul, k, v)
-                Session().add(ul)
-            Session().commit()
-
-        @request.addfinalizer
-        def cleanup():
-            UserLog.query().delete()
-            Session().commit()
-
-    def test_index(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index'))
-        response.mustcontain('Admin journal')
-
-    def test_filter_all_entries(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',))
-        response.mustcontain('2034 entries')
-
-    def test_filter_journal_filter_exact_match_on_repository(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',
-                                    filter='repository:rhodecode'))
-        response.mustcontain('3 entries')
-
-    def test_filter_journal_filter_exact_match_on_repository_CamelCase(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',
-                                    filter='repository:RhodeCode'))
-        response.mustcontain('3 entries')
-
-    def test_filter_journal_filter_wildcard_on_repository(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',
-                                    filter='repository:*test*'))
-        response.mustcontain('862 entries')
-
-    def test_filter_journal_filter_prefix_on_repository(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',
-                                    filter='repository:test*'))
-        response.mustcontain('257 entries')
-
-    def test_filter_journal_filter_prefix_on_repository_CamelCase(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',
-                                    filter='repository:Test*'))
-        response.mustcontain('257 entries')
-
-    def test_filter_journal_filter_prefix_on_repository_and_user(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',
-                                    filter='repository:test* AND username:demo'))
-        response.mustcontain('130 entries')
-
-    def test_filter_journal_filter_prefix_on_repository_or_target_repo(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',
-                                    filter='repository:test* OR repository:rhodecode'))
-        response.mustcontain('260 entries')  # 257 + 3
-
-    def test_filter_journal_filter_exact_match_on_username(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',
-                                    filter='username:demo'))
-        response.mustcontain('1087 entries')
-
-    def test_filter_journal_filter_exact_match_on_username_camelCase(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',
-                                    filter='username:DemO'))
-        response.mustcontain('1087 entries')
-
-    def test_filter_journal_filter_wildcard_on_username(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',
-                                    filter='username:*test*'))
-        response.mustcontain('100 entries')
-
-    def test_filter_journal_filter_prefix_on_username(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',
-                                    filter='username:demo*'))
-        response.mustcontain('1101 entries')
-
-    def test_filter_journal_filter_prefix_on_user_or_other_user(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',
-                                    filter='username:demo OR username:volcan'))
-        response.mustcontain('1095 entries')  # 1087 + 8
-
-    def test_filter_journal_filter_wildcard_on_action(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',
-                                    filter='action:*pull_request*'))
-        response.mustcontain('187 entries')
-
-    def test_filter_journal_filter_on_date(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',
-                                    filter='date:20121010'))
-        response.mustcontain('47 entries')
-
-    def test_filter_journal_filter_on_date_2(self):
-        self.log_user()
-        response = self.app.get(url(controller='admin/admin', action='index',
-                                    filter='date:20121020'))
-        response.mustcontain('17 entries')

rhodecode/tests/functional/test_admin_repo_settings.py

@@ -1,118 +0,0 b''
-# -*- coding: utf-8 -*-
-
-# Copyright (C) 2010-2017 RhodeCode GmbH
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Affero General Public License, version 3
-# (only), as published by the Free Software Foundation.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU Affero General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-# This program is dual-licensed. If you wish to learn more about the
-# RhodeCode Enterprise Edition, including its added features, Support services,
-# and proprietary license terms, please see https://rhodecode.com/licenses/
-
-import mock
-import pytest
-
-import rhodecode
-from rhodecode.model.settings import SettingsModel
-from rhodecode.tests import url, HG_REPO
-from rhodecode.tests.utils import AssertResponse
-
-
[e-mail]('autologin_user', 'app')
-class TestAdminRepoSettingsController:
-    @pytest.mark.parametrize('urlname', [
-        'edit_repo',
-        'edit_repo_perms',
-        'edit_repo_advanced',
-        'repo_vcs_settings',
-        'edit_repo_fields',
-        'repo_settings_issuetracker',
-        'edit_repo_caches',
-        'edit_repo_remote',
-        'edit_repo_statistics',
-    ])
-    def test_simple_get(self, urlname, app):
-        app.get(url(urlname, repo_name=HG_REPO))
-
-    @pytest.mark.parametrize('setting_name, setting_backends', [
-        ('hg_use_rebase_for_merging', ['hg']),
-    ])
-    def test_labs_settings_visible_if_enabled(
-            self, setting_name, setting_backends, backend):
-        if backend.alias not in setting_backends:
-            pytest.skip('Setting not available for backend {}'.format(backend))
-
-        vcs_settings_url = url(
-            'repo_vcs_settings', repo_name=backend.repo.repo_name)
-
-        with mock.patch.dict(
-                rhodecode.CONFIG, {'labs_settings_active': 'true'}):
-            response = self.app.get(vcs_settings_url)
-
-        assertr = AssertResponse(response)
-        assertr.one_element_exists('#rhodecode_{}'.format(setting_name))
-
-    @pytest.mark.parametrize('setting_name, setting_backends', [
-        ('hg_use_rebase_for_merging', ['hg']),
-    ])
-    def test_labs_settings_not_visible_if_disabled(
-            self, setting_name, setting_backends, backend):
-        if backend.alias not in setting_backends:
-            pytest.skip('Setting not available for backend {}'.format(backend))
-
-        vcs_settings_url = url(
-            'repo_vcs_settings', repo_name=backend.repo.repo_name)
-
-        with mock.patch.dict(
-                rhodecode.CONFIG, {'labs_settings_active': 'false'}):
-            response = self.app.get(vcs_settings_url)
-
-        assertr = AssertResponse(response)
-        assertr.no_element_exists('#rhodecode_{}'.format(setting_name))
-
-    @pytest.mark.parametrize('setting_name, setting_backends', [
-        ('hg_use_rebase_for_merging', ['hg']),
-    ])
-    def test_update_boolean_settings(
-            self, csrf_token, setting_name, setting_backends, backend):
-        if backend.alias not in setting_backends:
-            pytest.skip('Setting not available for backend {}'.format(backend))
-
-        repo = backend.create_repo()
-
-        settings_model = SettingsModel(repo=repo)
-        vcs_settings_url = url(
-            'repo_vcs_settings', repo_name=repo.repo_name)
-
-        self.app.post(
-            vcs_settings_url,
-            params={
-                'inherit_global_settings': False,
-                'new_svn_branch': 'dummy-value-for-testing',
-                'new_svn_tag': 'dummy-value-for-testing',
-                'rhodecode_{}'.format(setting_name): 'true',
-                'csrf_token': csrf_token,
-            })
-        setting = settings_model.get_setting_by_name(setting_name)
-        assert setting.app_settings_value
-
-        self.app.post(
-            vcs_settings_url,
-            params={
-                'inherit_global_settings': False,
-                'new_svn_branch': 'dummy-value-for-testing',
-                'new_svn_tag': 'dummy-value-for-testing',
-                'rhodecode_{}'.format(setting_name): 'false',
-                'csrf_token': csrf_token,
-            })
-        setting = settings_model.get_setting_by_name(setting_name)
-        assert not setting.app_settings_value

rhodecode/tests/functional/test_search.py

@@ -1,202 +0,0 b''
-# -*- coding: utf-8 -*-
-
-# Copyright (C) 2010-2017 RhodeCode GmbH
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Affero General Public License, version 3
-# (only), as published by the Free Software Foundation.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU Affero General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-# This program is dual-licensed. If you wish to learn more about the
-# RhodeCode Enterprise Edition, including its added features, Support services,
-# and proprietary license terms, please see https://rhodecode.com/licenses/
-
-import os
-
-import mock
-import pytest
-from whoosh import query
-
-from rhodecode.tests import (
-    TestController, url, SkipTest, HG_REPO,
-    TEST_USER_REGULAR_LOGIN, TEST_USER_REGULAR_PASS)
-from rhodecode.tests.utils import AssertResponse
-
-
-class TestSearchController(TestController):
-
-    def test_index(self):
-        self.log_user()
-        response = self.app.get(url(controller='search', action='index'))
-        assert_response = AssertResponse(response)
-        assert_response.one_element_exists('input#q')
-
-    def test_search_files_empty_search(self):
-        if os.path.isdir(self.index_location):
-            raise SkipTest('skipped due to existing index')
-        else:
-            self.log_user()
-            response = self.app.get(url(controller='search', action='index'),
-                                    {'q': HG_REPO})
-            response.mustcontain('There is no index to search in. '
-                                 'Please run whoosh indexer')
-
-    def test_search_validation(self):
-        self.log_user()
-        response = self.app.get(
-            url(controller='search', action='index'), {'q': query,
-                                                       'type': 'content',
-                                                       'page_limit': 1000})
-
-        response.mustcontain(
-            'page_limit - 1000 is greater than maximum value 500')
-
-    @pytest.mark.parametrize("query, expected_hits, expected_paths", [
-        ('todo', 23, [
-            'vcs/backends/hg/inmemory.py',
-            'vcs/tests/test_git.py']),
-        ('extension:rst installation', 6, [
-            'docs/index.rst',
-            'docs/installation.rst']),
-        ('def repo', 87, [
-            'vcs/tests/test_git.py',
-            'vcs/tests/test_changesets.py']),
-        ('repository:%s def test' % HG_REPO, 18, [
-            'vcs/tests/test_git.py',
-            'vcs/tests/test_changesets.py']),
-        ('"def main"', 9, [
-            'vcs/__init__.py',
-            'vcs/tests/__init__.py',
-            'vcs/utils/progressbar.py']),
-        ('owner:test_admin', 358, [
-            'vcs/tests/base.py',
-            'MANIFEST.in',
-            'vcs/utils/termcolors.py',
-            'docs/theme/ADC/static/documentation.png']),
-        ('owner:test_admin def main', 72, [
-            'vcs/__init__.py',
-            'vcs/tests/test_utils_filesize.py',
-            'vcs/tests/test_cli.py']),
-        ('owner:michał test', 0, []),
-    ])
-    def test_search_files(self, query, expected_hits, expected_paths):
-        self.log_user()
-        response = self.app.get(
-            url(controller='search', action='index'), {'q': query,
-                                                       'type': 'content',
-                                                       'page_limit': 500})
-
-        response.mustcontain('%s results' % expected_hits)
-        for path in expected_paths:
-            response.mustcontain(path)
-
-    @pytest.mark.parametrize("query, expected_hits, expected_commits", [
-        ('bother to ask where to fetch repo during tests', 3, [
-            ('hg', 'a00c1b6f5d7a6ae678fd553a8b81d92367f7ecf1'),
-            ('git', 'c6eb379775c578a95dad8ddab53f963b80894850'),
-            ('svn', '98')]),
-        ('michał', 0, []),
-        ('changed:tests/utils.py', 36, [
-            ('hg', 'a00c1b6f5d7a6ae678fd553a8b81d92367f7ecf1')]),
-        ('changed:vcs/utils/archivers.py', 11, [
-            ('hg', '25213a5fbb048dff8ba65d21e466a835536e5b70'),
-            ('hg', '47aedd538bf616eedcb0e7d630ea476df0e159c7'),
-            ('hg', 'f5d23247fad4856a1dabd5838afade1e0eed24fb'),
-            ('hg', '04ad456aefd6461aea24f90b63954b6b1ce07b3e'),
-            ('git', 'c994f0de03b2a0aa848a04fc2c0d7e737dba31fc'),
-            ('git', 'd1f898326327e20524fe22417c22d71064fe54a1'),
-            ('git', 'fe568b4081755c12abf6ba673ba777fc02a415f3'),
-            ('git', 'bafe786f0d8c2ff7da5c1dcfcfa577de0b5e92f1')]),
-        ('added:README.rst', 3, [
-            ('hg', '3803844fdbd3b711175fc3da9bdacfcd6d29a6fb'),
-            ('git', 'ff7ca51e58c505fec0dd2491de52c622bb7a806b'),
-            ('svn', '8')]),
-        ('changed:lazy.py', 15, [
-            ('hg', 'eaa291c5e6ae6126a203059de9854ccf7b5baa12'),
-            ('git', '17438a11f72b93f56d0e08e7d1fa79a378578a82'),
-            ('svn', '82'),
-            ('svn', '262'),
-            ('hg', 'f5d23247fad4856a1dabd5838afade1e0eed24fb'),
-            ('git', '33fa3223355104431402a888fa77a4e9956feb3e')
-            ]),
-        ('author:[e-mail] '
-         'commit_id:b986218ba1c9b0d6a259fac9b050b1724ed8e545', 1, [
-             ('hg', 'b986218ba1c9b0d6a259fac9b050b1724ed8e545')]),
-        ('b986218ba1c9b0d6a259fac9b050b1724ed8e545', 1, [
-             ('hg', 'b986218ba1c9b0d6a259fac9b050b1724ed8e545')]),
-        ('b986218b', 1, [
-             ('hg', 'b986218ba1c9b0d6a259fac9b050b1724ed8e545')]),
-    ])
-    def test_search_commit_messages(
-            self, query, expected_hits, expected_commits, enabled_backends):
-        self.log_user()
-        response = self.app.get(
-            url(controller='search', action='index'), {'q': query,
-                                                       'type': 'commit',
-                                                       'page_limit': 500})
-
-        response.mustcontain('%s results' % expected_hits)
-        for backend, commit_id in expected_commits:
-            if backend in enabled_backends:
-                response.mustcontain(commit_id)
-
-    @pytest.mark.parametrize("query, expected_hits, expected_paths", [
-        ('readme.rst', 3, []),
-        ('test*', 75, []),
-        ('*model*', 1, []),
-        ('extension:rst', 48, []),
-        ('extension:rst api', 24, []),
-    ])
-    def test_search_file_paths(self, query, expected_hits, expected_paths):
-        self.log_user()
-        response = self.app.get(
-            url(controller='search', action='index'), {'q': query,
-                                                       'type': 'path',
-                                                       'page_limit': 500})
-
-        response.mustcontain('%s results' % expected_hits)
-        for path in expected_paths:
-            response.mustcontain(path)
-
-    def test_search_commit_message_specific_repo(self, backend):
-        self.log_user()
-        response = self.app.get(
-            url(controller='search', action='index',
-                repo_name=backend.repo_name),
-            {'q': 'bother to ask where to fetch repo during tests',
-             'type': 'commit'})
-
-        response.mustcontain('1 results')
-
-    def test_filters_are_not_applied_for_admin_user(self):
-        self.log_user()
-        with mock.patch('whoosh.searching.Searcher.search') as search_mock:
-            self.app.get(
-                url(controller='search', action='index'),
-                {'q': 'test query', 'type': 'commit'})
-        assert search_mock.call_count == 1
-        _, kwargs = search_mock.call_args
-        assert kwargs['filter'] is None
-
-    def test_filters_are_applied_for_normal_user(self, enabled_backends):
-        self.log_user(TEST_USER_REGULAR_LOGIN, TEST_USER_REGULAR_PASS)
-        with mock.patch('whoosh.searching.Searcher.search') as search_mock:
-            self.app.get(
-                url(controller='search', action='index'),
-                {'q': 'test query', 'type': 'commit'})
-        assert search_mock.call_count == 1
-        _, kwargs = search_mock.call_args
-        assert isinstance(kwargs['filter'], query.Or)
-        expected_repositories = [
-            'vcs_test_{}'.format(b) for b in enabled_backends]
-        queried_repositories = [
-            name for type_, name in kwargs['filter'].all_terms()]
-        for repository in expected_repositories:
-            assert repository in queried_repositories