vcs-connection: report problems more explicitly if connections are not established and we want to use it

rhodecode/lib/vcs/connection.py

@@ -1,37 +1,45 b''
 # -*- coding: utf-8 -*-
 
 # Copyright (C) 2014-2020 RhodeCode GmbH
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU Affero General Public License, version 3
 # (only), as published by the Free Software Foundation.
 #
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 # This program is dual-licensed. If you wish to learn more about the
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
 """
 Holds connection for remote server.
 """
 
 
-def _not_initialized(*args, **kwargs):
+class NotInitializedConnection(object):
     """Placeholder for objects which have to be initialized first."""
+
+    def _raise_exc(self):
     raise Exception(
         "rhodecode.lib.vcs is not yet initialized. "
         "Make sure `vcs.server` is enabled in your configuration.")
 
-# TODO: figure out a nice default value for these things
-Service = _not_initialized
+    def __getattr__(self, item):
+        self._raise_exc()
+
+    def __call__(self, *args, **kwargs):
+        self._raise_exc()
 
-Git = _not_initialized
-Hg = _not_initialized
-Svn = _not_initialized
+# TODO: figure out a nice default value for these things
+Service = NotInitializedConnection()
+
+Git = NotInitializedConnection()
+Hg = NotInitializedConnection()
+Svn = NotInitializedConnection()