integrations: fixed code for python3

rhodecode/integrations/routes.py

@@ -1,243 +1,243 b''
 
 
 # Copyright (C) 2012-2020 RhodeCode GmbH
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU Affero General Public License, version 3
 # (only), as published by the Free Software Foundation.
 #
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 # This program is dual-licensed. If you wish to learn more about the
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
 import logging
 
 from rhodecode.apps._base import ADMIN_PREFIX, add_route_requirements
 from rhodecode.lib.utils2 import safe_int
 from rhodecode.model.db import Repository, Integration, RepoGroup
 from rhodecode.integrations import integration_type_registry
 from rhodecode.integrations.views import GlobalIntegrationsView
 from rhodecode.integrations.views import RepoGroupIntegrationsView
 from rhodecode.integrations.views import RepoIntegrationsView
 
 log = logging.getLogger(__name__)
 
 
 class ValidIntegrationPredicate(object):
     def __init__(self, val, config):
         self.val = val
 
     def text(self):
-        return 'valid_integration_route = %s' % self.val
+        return f'valid_integration_route = {self.val}'
 
     phash = text
 
     def __call__(self, info, request):
         integration_type = info['match']['integration']
         integration_id = info['match'].get('integration_id')
 
         if integration_type not in integration_type_registry:
             return False
 
         if integration_id:
             if not safe_int(integration_id):
                 return False
 
             integration = Integration.get(integration_id)
             if not integration:
                 return False
             if integration.integration_type != integration_type:
                 return False
 
             # match types to repo or repo group
             repo_name = info['match'].get('repo_name')
             repo_group_name = info['match'].get('repo_group_name')
             repo, repo_group = None, None
             if repo_name:
                 repo = Repository.get_by_repo_name(repo_name)
                 if not repo:
                     return False
 
             if repo_group_name:
                 repo_group = RepoGroup.get_by_group_name(repo_group_name)
                 if not repo_group:
                     return False
 
             if repo and repo.repo_id != integration.repo_id:
                 return False
             if repo_group and repo_group.group_id != integration.repo_group_id:
                 return False
 
         return True
 
 
 def includeme(config):
     config.add_route_predicate(
         'valid_integration', ValidIntegrationPredicate)
 
     # global integrations
     config.add_route('global_integrations_new',
                      ADMIN_PREFIX + '/integrations/new')
     config.add_view(GlobalIntegrationsView,
                     attr='new_integration',
                     renderer='rhodecode:templates/admin/integrations/new.mako',
                     request_method='GET',
                     route_name='global_integrations_new')
 
     config.add_route('global_integrations_home',
                      ADMIN_PREFIX + '/integrations')
     config.add_route('global_integrations_list',
                      ADMIN_PREFIX + '/integrations/{integration}')
     for route_name in ['global_integrations_home', 'global_integrations_list']:
         config.add_view(GlobalIntegrationsView,
                         attr='integration_list',
                         renderer='rhodecode:templates/admin/integrations/list.mako',
                         request_method='GET',
                         route_name=route_name)
 
     config.add_route('global_integrations_create',
                      ADMIN_PREFIX + '/integrations/{integration}/new',
                      valid_integration=True)
     config.add_route('global_integrations_edit',
                      ADMIN_PREFIX + '/integrations/{integration}/{integration_id}',
                      valid_integration=True)
 
     for route_name in ['global_integrations_create', 'global_integrations_edit']:
         config.add_view(GlobalIntegrationsView,
                         attr='settings_get',
                         renderer='rhodecode:templates/admin/integrations/form.mako',
                         request_method='GET',
                         route_name=route_name)
         config.add_view(GlobalIntegrationsView,
                         attr='settings_post',
                         renderer='rhodecode:templates/admin/integrations/form.mako',
                         request_method='POST',
                         route_name=route_name)
 
     # repo group integrations
     config.add_route('repo_group_integrations_home',
                      add_route_requirements('/{repo_group_name}/_settings/integrations'),
                      repo_group_route=True)
 
     config.add_view(RepoGroupIntegrationsView,
                     attr='integration_list',
                     renderer='rhodecode:templates/admin/integrations/list.mako',
                     request_method='GET',
                     route_name='repo_group_integrations_home')
 
     config.add_route('repo_group_integrations_new',
                      add_route_requirements('/{repo_group_name}/_settings/integrations/new'),
                      repo_group_route=True)
     config.add_view(RepoGroupIntegrationsView,
                     attr='new_integration',
                     renderer='rhodecode:templates/admin/integrations/new.mako',
                     request_method='GET',
                     route_name='repo_group_integrations_new')
 
     config.add_route('repo_group_integrations_list',
                      add_route_requirements('/{repo_group_name}/_settings/integrations/{integration}'),
                      repo_group_route=True,
                      valid_integration=True)
     config.add_view(RepoGroupIntegrationsView,
                     attr='integration_list',
                     renderer='rhodecode:templates/admin/integrations/list.mako',
                     request_method='GET',
                     route_name='repo_group_integrations_list')
 
     config.add_route('repo_group_integrations_create',
                      add_route_requirements('/{repo_group_name}/_settings/integrations/{integration}/new'),
                      repo_group_route=True,
                      valid_integration=True)
     config.add_view(RepoGroupIntegrationsView,
                     attr='settings_get',
                     renderer='rhodecode:templates/admin/integrations/form.mako',
                     request_method='GET',
                     route_name='repo_group_integrations_create')
     config.add_view(RepoGroupIntegrationsView,
                     attr='settings_post',
                     renderer='rhodecode:templates/admin/integrations/form.mako',
                     request_method='POST',
                     route_name='repo_group_integrations_create')
 
     config.add_route('repo_group_integrations_edit',
                      add_route_requirements('/{repo_group_name}/_settings/integrations/{integration}/{integration_id}'),
                      repo_group_route=True,
                      valid_integration=True)
 
     config.add_view(RepoGroupIntegrationsView,
                     attr='settings_get',
                     renderer='rhodecode:templates/admin/integrations/form.mako',
                     request_method='GET',
                     route_name='repo_group_integrations_edit')
     config.add_view(RepoGroupIntegrationsView,
                     attr='settings_post',
                     renderer='rhodecode:templates/admin/integrations/form.mako',
                     request_method='POST',
                     route_name='repo_group_integrations_edit')
 
     # repo integrations
     config.add_route('repo_integrations_home',
                      add_route_requirements('/{repo_name}/settings/integrations'),
                      repo_route=True)
     config.add_view(RepoIntegrationsView,
                     attr='integration_list',
                     request_method='GET',
                     renderer='rhodecode:templates/admin/integrations/list.mako',
                     route_name='repo_integrations_home')
 
     config.add_route('repo_integrations_new',
                      add_route_requirements('/{repo_name}/settings/integrations/new'),
                      repo_route=True)
     config.add_view(RepoIntegrationsView,
                     attr='new_integration',
                     renderer='rhodecode:templates/admin/integrations/new.mako',
                     request_method='GET',
                     route_name='repo_integrations_new')
 
     config.add_route('repo_integrations_list',
                      add_route_requirements('/{repo_name}/settings/integrations/{integration}'),
                      repo_route=True,
                      valid_integration=True)
     config.add_view(RepoIntegrationsView,
                     attr='integration_list',
                     request_method='GET',
                     renderer='rhodecode:templates/admin/integrations/list.mako',
                     route_name='repo_integrations_list')
 
     config.add_route('repo_integrations_create',
                      add_route_requirements('/{repo_name}/settings/integrations/{integration}/new'),
                      repo_route=True,
                      valid_integration=True)
     config.add_view(RepoIntegrationsView,
                     attr='settings_get',
                     renderer='rhodecode:templates/admin/integrations/form.mako',
                     request_method='GET',
                     route_name='repo_integrations_create')
     config.add_view(RepoIntegrationsView,
                     attr='settings_post',
                     renderer='rhodecode:templates/admin/integrations/form.mako',
                     request_method='POST',
                     route_name='repo_integrations_create')
 
     config.add_route('repo_integrations_edit',
                      add_route_requirements('/{repo_name}/settings/integrations/{integration}/{integration_id}'),
                      repo_route=True,
                      valid_integration=True)
     config.add_view(RepoIntegrationsView,
                     attr='settings_get',
                     renderer='rhodecode:templates/admin/integrations/form.mako',
                     request_method='GET',
                     route_name='repo_integrations_edit')
     config.add_view(RepoIntegrationsView,
                     attr='settings_post',
                     renderer='rhodecode:templates/admin/integrations/form.mako',
                     request_method='POST',
                     route_name='repo_integrations_edit')

rhodecode/integrations/tests/test_integrations.py

@@ -1,269 +1,269 b''
 
 # Copyright (C) 2010-2020 RhodeCode GmbH
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU Affero General Public License, version 3
 # (only), as published by the Free Software Foundation.
 #
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 # This program is dual-licensed. If you wish to learn more about the
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
 import pytest
 
 from rhodecode.apps._base import ADMIN_PREFIX
 from rhodecode.model.db import Integration
 from rhodecode.model.meta import Session
 from rhodecode.integrations import integration_type_registry
 
 
 def route_path(name, **kwargs):
     return {
         'home': '/',
     }[name].format(**kwargs)
 
 
 def _post_integration_test_helper(app, url, csrf_token, repo, repo_group,
                                   admin_view):
     """
     Posts form data to create integration at the url given then deletes it and
     checks if the redirect url is correct.
     """
     repo_name = repo.repo_name
     repo_group_name = repo_group.group_name
     app.post(url, params={}, status=403)  # missing csrf check
     response = app.post(url, params={'csrf_token': csrf_token})
     assert response.status_code == 200
     response.mustcontain('Errors exist')
 
     scopes_destinations = [
         ('global',
                 ADMIN_PREFIX + '/integrations'),
         ('root-repos',
                 ADMIN_PREFIX + '/integrations'),
         ('repo:%s' % repo_name,
                 '/%s/settings/integrations' % repo_name),
         ('repogroup:%s' % repo_group_name,
                 '/%s/_settings/integrations' % repo_group_name),
         ('repogroup-recursive:%s' % repo_group_name,
                 '/%s/_settings/integrations' % repo_group_name),
     ]
 
     for scope, destination in scopes_destinations:
         if admin_view:
             destination = ADMIN_PREFIX + '/integrations'
 
         form_data = [
             ('csrf_token', csrf_token),
             ('__start__', 'options:mapping'),
             ('name', 'test integration'),
             ('scope', scope),
             ('enabled', 'true'),
             ('__end__', 'options:mapping'),
             ('__start__', 'settings:mapping'),
             ('test_int_field', '34'),
             ('test_string_field', ''), # empty value on purpose as it's required
             ('__end__', 'settings:mapping'),
         ]
         errors_response = app.post(url, form_data)
-        assert 'Errors exist' in errors_response.body
+        assert 'Errors exist' in errors_response.text
 
         form_data[-2] = ('test_string_field', 'data!')
         assert Session().query(Integration).count() == 0
         created_response = app.post(url, form_data)
         assert Session().query(Integration).count() == 1
 
         delete_response = app.post(
             created_response.location,
             params={'csrf_token': csrf_token, 'delete': 'delete'})
 
         assert Session().query(Integration).count() == 0
         assert delete_response.location.endswith(destination)
 
 
 
 @pytest.mark.usefixtures('app', 'autologin_user')
 class TestIntegrationsView(object):
     pass
 
 
 class TestGlobalIntegrationsView(TestIntegrationsView):
     def test_index_no_integrations(self):
         url = ADMIN_PREFIX + '/integrations'
         response = self.app.get(url)
 
         assert response.status_code == 200
         response.mustcontain('exist yet')
 
     def test_index_with_integrations(self, global_integration_stub):
         url = ADMIN_PREFIX + '/integrations'
         response = self.app.get(url)
 
         assert response.status_code == 200
         response.mustcontain(no=['exist yet'])
         response.mustcontain(global_integration_stub.name)
 
     @pytest.mark.parametrize(
         'IntegrationType', integration_type_registry.values())
     def test_new_integration_page(self, IntegrationType):
         url = ADMIN_PREFIX + '/integrations/new'
 
         response = self.app.get(url, status=200)
         if not IntegrationType.is_dummy:
             url = (ADMIN_PREFIX + '/integrations/{integration}/new').format(
                     integration=IntegrationType.key)
             response.mustcontain(url)
 
     @pytest.mark.parametrize(
         'IntegrationType', integration_type_registry.values())
     def test_get_create_integration_page(self, IntegrationType):
         url = ADMIN_PREFIX + '/integrations/{integration_key}/new'.format(
             integration_key=IntegrationType.key)
         if IntegrationType.is_dummy:
             self.app.get(url, status=404)
         else:
             response = self.app.get(url, status=200)
             response.mustcontain(IntegrationType.display_name)
 
     def test_post_integration_page(self, StubIntegrationType, csrf_token,
                                    test_repo_group, backend_random):
         url = ADMIN_PREFIX + '/integrations/{integration_key}/new'.format(
             integration_key=StubIntegrationType.key)
 
         _post_integration_test_helper(
             self.app, url, csrf_token, admin_view=True,
             repo=backend_random.repo, repo_group=test_repo_group)
 
 
 class TestRepoIntegrationsView(TestIntegrationsView):
     def test_index_no_integrations(self, backend_random):
         url = '/{repo_name}/settings/integrations'.format(
             repo_name=backend_random.repo.repo_name)
         response = self.app.get(url)
 
         assert response.status_code == 200
         response.mustcontain('exist yet')
 
     def test_index_with_integrations(self, repo_integration_stub):
         url = '/{repo_name}/settings/integrations'.format(
             repo_name=repo_integration_stub.repo.repo_name)
         stub_name = repo_integration_stub.name
 
         response = self.app.get(url)
 
         assert response.status_code == 200
         response.mustcontain(stub_name)
         response.mustcontain(no=['exist yet'])
 
     @pytest.mark.parametrize(
         'IntegrationType', integration_type_registry.values())
     def test_new_integration_page(self, backend_random, IntegrationType):
         repo_name = backend_random.repo.repo_name
         url = '/{repo_name}/settings/integrations/new'.format(
             repo_name=repo_name)
 
         response = self.app.get(url, status=200)
 
         url = '/{repo_name}/settings/integrations/{integration}/new'.format(
                 repo_name=repo_name,
                 integration=IntegrationType.key)
         if not IntegrationType.is_dummy:
             response.mustcontain(url)
 
     @pytest.mark.parametrize(
         'IntegrationType', integration_type_registry.values())
     def test_get_create_integration_page(self, backend_random, IntegrationType):
         repo_name = backend_random.repo.repo_name
         url = '/{repo_name}/settings/integrations/{integration_key}/new'.format(
             repo_name=repo_name, integration_key=IntegrationType.key)
         if IntegrationType.is_dummy:
             self.app.get(url, status=404)
         else:
             response = self.app.get(url, status=200)
             response.mustcontain(IntegrationType.display_name)
 
     def test_post_integration_page(self, backend_random, test_repo_group,
                                    StubIntegrationType, csrf_token):
         repo_name = backend_random.repo.repo_name
         url = '/{repo_name}/settings/integrations/{integration_key}/new'.format(
             repo_name=repo_name, integration_key=StubIntegrationType.key)
 
         _post_integration_test_helper(
             self.app, url, csrf_token, admin_view=False,
             repo=backend_random.repo, repo_group=test_repo_group)
 
 
 class TestRepoGroupIntegrationsView(TestIntegrationsView):
     def test_index_no_integrations(self, test_repo_group):
         url = '/{repo_group_name}/_settings/integrations'.format(
             repo_group_name=test_repo_group.group_name)
         response = self.app.get(url)
 
         assert response.status_code == 200
         response.mustcontain('exist yet')
 
     def test_index_with_integrations(
             self, test_repo_group, repogroup_integration_stub):
 
         url = '/{repo_group_name}/_settings/integrations'.format(
             repo_group_name=test_repo_group.group_name)
 
         stub_name = repogroup_integration_stub.name
         response = self.app.get(url)
 
         assert response.status_code == 200
         response.mustcontain(no=['exist yet'])
         response.mustcontain(stub_name)
 
     def test_new_integration_page(self, test_repo_group):
         repo_group_name = test_repo_group.group_name
         url = '/{repo_group_name}/_settings/integrations/new'.format(
             repo_group_name=test_repo_group.group_name)
 
         response = self.app.get(url)
 
         assert response.status_code == 200
 
         for integration_key, integration_obj in integration_type_registry.items():
             if not integration_obj.is_dummy:
                 nurl = (
                     '/{repo_group_name}/_settings/integrations/{integration}/new').format(
                     repo_group_name=repo_group_name,
                     integration=integration_key)
                 response.mustcontain(nurl)
 
     @pytest.mark.parametrize(
         'IntegrationType', integration_type_registry.values())
     def test_get_create_integration_page(
             self, test_repo_group, IntegrationType):
 
         repo_group_name = test_repo_group.group_name
         url = ('/{repo_group_name}/_settings/integrations/{integration_key}/new'
                ).format(repo_group_name=repo_group_name,
                         integration_key=IntegrationType.key)
 
         if not IntegrationType.is_dummy:
             response = self.app.get(url, status=200)
             response.mustcontain(IntegrationType.display_name)
         else:
             self.app.get(url, status=404)
 
     def test_post_integration_page(self, test_repo_group, backend_random,
                                    StubIntegrationType, csrf_token):
 
         repo_group_name = test_repo_group.group_name
         url = ('/{repo_group_name}/_settings/integrations/{integration_key}/new'
                ).format(repo_group_name=repo_group_name,
                         integration_key=StubIntegrationType.key)
 
         _post_integration_test_helper(
             self.app, url, csrf_token, admin_view=False,
             repo=backend_random.repo, repo_group=test_repo_group)

rhodecode/integrations/types/base.py

@@ -1,450 +1,452 b''
 
 
 # Copyright (C) 2012-2020 RhodeCode GmbH
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU Affero General Public License, version 3
 # (only), as published by the Free Software Foundation.
 #
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 # This program is dual-licensed. If you wish to learn more about the
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
 import colander
 import string
 import collections
 import logging
 import requests
-import urllib.request, urllib.parse, urllib.error
+import urllib.request
+import urllib.parse
+import urllib.error
 from requests.adapters import HTTPAdapter
 from requests.packages.urllib3.util.retry import Retry
 
 from mako import exceptions
 
 from rhodecode.lib.utils2 import safe_str
 from rhodecode.translation import _
 
 
 log = logging.getLogger(__name__)
 
 
 class UrlTmpl(string.Template):
 
     def safe_substitute(self, **kws):
         # url encode the kw for usage in url
         kws = {k: urllib.parse.quote(safe_str(v)) for k, v in kws.items()}
         return super(UrlTmpl, self).safe_substitute(**kws)
 
 
 class IntegrationTypeBase(object):
     """ Base class for IntegrationType plugins """
     is_dummy = False
     description = ''
 
     @classmethod
     def icon(cls):
         return '''
         <?xml version="1.0" encoding="UTF-8" standalone="no"?>
         <svg
            xmlns:dc="http://purl.org/dc/elements/1.1/"
            xmlns:cc="http://creativecommons.org/ns#"
            xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
            xmlns:svg="http://www.w3.org/2000/svg"
            xmlns="http://www.w3.org/2000/svg"
            xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
            xmlns:inkscape="http://setwww.inkscape.org/namespaces/inkscape"
            viewBox="0 -256 1792 1792"
            id="svg3025"
            version="1.1"
            inkscape:version="0.48.3.1 r9886"
            width="100%"
            height="100%"
            sodipodi:docname="cog_font_awesome.svg">
           <metadata
              id="metadata3035">
             <rdf:RDF>
               <cc:Work
                  rdf:about="">
                 <dc:format>image/svg+xml</dc:format>
                 <dc:type
                    rdf:resource="http://purl.org/dc/dcmitype/StillImage" />
               </cc:Work>
             </rdf:RDF>
           </metadata>
           <defs
              id="defs3033" />
           <sodipodi:namedview
              pagecolor="#ffffff"
              bordercolor="#666666"
              borderopacity="1"
              objecttolerance="10"
              gridtolerance="10"
              guidetolerance="10"
              inkscape:pageopacity="0"
              inkscape:pageshadow="2"
              inkscape:window-width="640"
              inkscape:window-height="480"
              id="namedview3031"
              showgrid="false"
              inkscape:zoom="0.13169643"
              inkscape:cx="896"
              inkscape:cy="896"
              inkscape:window-x="0"
              inkscape:window-y="25"
              inkscape:window-maximized="0"
              inkscape:current-layer="svg3025" />
           <g
              transform="matrix(1,0,0,-1,121.49153,1285.4237)"
              id="g3027">
             <path
                d="m 1024,640 q 0,106 -75,181 -75,75 -181,75 -106,0 -181,-75 -75,-75 -75,-181 0,-106 75,-181 75,-75 181,-75 106,0 181,75 75,75 75,181 z m 512,109 V 527 q 0,-12 -8,-23 -8,-11 -20,-13 l -185,-28 q -19,-54 -39,-91 35,-50 107,-138 10,-12 10,-25 0,-13 -9,-23 -27,-37 -99,-108 -72,-71 -94,-71 -12,0 -26,9 l -138,108 q -44,-23 -91,-38 -16,-136 -29,-186 -7,-28 -36,-28 H 657 q -14,0 -24.5,8.5 Q 622,-111 621,-98 L 593,86 q -49,16 -90,37 L 362,16 Q 352,7 337,7 323,7 312,18 186,132 147,186 q -7,10 -7,23 0,12 8,23 15,21 51,66.5 36,45.5 54,70.5 -27,50 -41,99 L 29,495 Q 16,497 8,507.5 0,518 0,531 v 222 q 0,12 8,23 8,11 19,13 l 186,28 q 14,46 39,92 -40,57 -107,138 -10,12 -10,24 0,10 9,23 26,36 98.5,107.5 72.5,71.5 94.5,71.5 13,0 26,-10 l 138,-107 q 44,23 91,38 16,136 29,186 7,28 36,28 h 222 q 14,0 24.5,-8.5 Q 914,1391 915,1378 l 28,-184 q 49,-16 90,-37 l 142,107 q 9,9 24,9 13,0 25,-10 129,-119 165,-170 7,-8 7,-22 0,-12 -8,-23 -15,-21 -51,-66.5 -36,-45.5 -54,-70.5 26,-50 41,-98 l 183,-28 q 13,-2 21,-12.5 8,-10.5 8,-23.5 z"
                id="path3029"
                inkscape:connector-curvature="0"
                style="fill:currentColor" />
           </g>
         </svg>
         '''
 
     def __init__(self, settings):
         """
         :param settings: dict of settings to be used for the integration
         """
         self.settings = settings
 
     def settings_schema(self):
         """
         A colander schema of settings for the integration type
         """
         return colander.Schema()
 
     def event_enabled(self, event):
         """
         Checks if submitted event is enabled based on the plugin settings
         :param event:
         :return: bool
         """
         allowed_events = self.settings.get('events') or []
         if event.name not in allowed_events:
             log.debug('event ignored: %r event %s not in allowed set of events %s',
                       event, event.name, allowed_events)
             return False
         return True
 
 
 class EEIntegration(IntegrationTypeBase):
     description = 'Integration available in RhodeCode EE edition.'
     is_dummy = True
 
     def __init__(self, name, key, settings=None):
         self.display_name = name
         self.key = key
         super(EEIntegration, self).__init__(settings)
 
 
 # Helpers #
 # updating this required to update the `common_vars` as well.
 WEBHOOK_URL_VARS = [
     # GENERAL
     ('General', [
         ('event_name', 'Unique name of the event type, e.g pullrequest-update'),
         ('repo_name', 'Full name of the repository'),
         ('repo_type', 'VCS type of repository'),
         ('repo_id', 'Unique id of repository'),
         ('repo_url', 'Repository url'),
         ]
     ),
     # extra repo fields
     ('Repository', [
         ('extra:<extra_key_name>', 'Extra repo variables, read from its settings.'),
         ]
     ),
     # special attrs below that we handle, using multi-call
     ('Commit push - Multicalls', [
         ('branch', 'Name of each branch submitted, if any.'),
         ('branch_head', 'Head ID of pushed branch (full sha of last commit), if any.'),
         ('commit_id', 'ID (full sha) of each commit submitted, if any.'),
         ]
     ),
     # pr events vars
     ('Pull request', [
         ('pull_request_id', 'Unique ID of the pull request.'),
         ('pull_request_title', 'Title of the pull request.'),
         ('pull_request_url', 'Pull request url.'),
         ('pull_request_shadow_url', 'Pull request shadow repo clone url.'),
         ('pull_request_commits_uid', 'Calculated UID of all commits inside the PR. '
                                      'Changes after PR update'),
         ]
     ),
     # commit comment event vars
     ('Commit comment', [
         ('commit_comment_id', 'Unique ID of the comment made on a commit.'),
         ('commit_comment_text', 'Text of commit comment.'),
         ('commit_comment_type', 'Type of comment, e.g note/todo.'),
 
         ('commit_comment_f_path', 'Optionally path of file for inline comments.'),
         ('commit_comment_line_no', 'Line number of the file: eg o10, or n200'),
 
         ('commit_comment_commit_id', 'Commit id that comment was left at.'),
         ('commit_comment_commit_branch', 'Commit branch that comment was left at'),
         ('commit_comment_commit_message', 'Commit message that comment was left at'),
         ]
     ),
     # user who triggers the call
     ('Caller', [
         ('username', 'User who triggered the call.'),
         ('user_id', 'User id who triggered the call.'),
         ]
     ),
 ]
 
 # common vars for url template used for CI plugins. Shared with webhook
 CI_URL_VARS = WEBHOOK_URL_VARS
 
 
 class CommitParsingDataHandler(object):
 
     def aggregate_branch_data(self, branches, commits):
         branch_data = collections.OrderedDict()
         for obj in branches:
             branch_data[obj['name']] = obj
 
         branches_commits = collections.OrderedDict()
         for commit in commits:
             if commit.get('git_ref_change'):
                 # special case for GIT that allows creating tags,
                 # deleting branches without associated commit
                 continue
             commit_branch = commit['branch']
 
             if commit_branch not in branches_commits:
                 _branch = branch_data[commit_branch] \
                     if commit_branch else commit_branch
                 branch_commits = {'branch': _branch,
                                   'branch_head': '',
                                   'commits': []}
                 branches_commits[commit_branch] = branch_commits
 
             branch_commits = branches_commits[commit_branch]
             branch_commits['commits'].append(commit)
             branch_commits['branch_head'] = commit['raw_id']
         return branches_commits
 
 
 class WebhookDataHandler(CommitParsingDataHandler):
     name = 'webhook'
 
     def __init__(self, template_url, headers):
         self.template_url = template_url
         self.headers = headers
 
     def get_base_parsed_template(self, data):
         """
         initially parses the passed in template with some common variables
         available on ALL calls
         """
         # note: make sure to update the `WEBHOOK_URL_VARS` if this changes
         common_vars = {
             'repo_name': data['repo']['repo_name'],
             'repo_type': data['repo']['repo_type'],
             'repo_id': data['repo']['repo_id'],
             'repo_url': data['repo']['url'],
             'username': data['actor']['username'],
             'user_id': data['actor']['user_id'],
             'event_name': data['name']
         }
 
         extra_vars = {}
         for extra_key, extra_val in data['repo']['extra_fields'].items():
             extra_vars['extra__{}'.format(extra_key)] = extra_val
         common_vars.update(extra_vars)
 
         template_url = self.template_url.replace('${extra:', '${extra__')
         for k, v in common_vars.items():
             template_url = UrlTmpl(template_url).safe_substitute(**{k: v})
         return template_url
 
     def repo_push_event_handler(self, event, data):
         url = self.get_base_parsed_template(data)
         url_calls = []
 
         branches_commits = self.aggregate_branch_data(
             data['push']['branches'], data['push']['commits'])
         if '${branch}' in url or '${branch_head}' in url or '${commit_id}' in url:
             # call it multiple times, for each branch if used in variables
             for branch, commit_ids in branches_commits.items():
                 branch_url = UrlTmpl(url).safe_substitute(branch=branch)
 
                 if '${branch_head}' in branch_url:
                     # last commit in the aggregate is the head of the branch
                     branch_head = commit_ids['branch_head']
                     branch_url = UrlTmpl(branch_url).safe_substitute(branch_head=branch_head)
 
                 # call further down for each commit if used
                 if '${commit_id}' in branch_url:
                     for commit_data in commit_ids['commits']:
                         commit_id = commit_data['raw_id']
                         commit_url = UrlTmpl(branch_url).safe_substitute(commit_id=commit_id)
                         # register per-commit call
                         log.debug(
                             'register %s call(%s) to url %s',
                             self.name, event, commit_url)
                         url_calls.append(
                             (commit_url, self.headers, data))
 
                 else:
                     # register per-branch call
                     log.debug('register %s call(%s) to url %s',
                               self.name, event, branch_url)
                     url_calls.append((branch_url, self.headers, data))
 
         else:
             log.debug('register %s call(%s) to url %s', self.name, event, url)
             url_calls.append((url, self.headers, data))
 
         return url_calls
 
     def repo_commit_comment_handler(self, event, data):
         url = self.get_base_parsed_template(data)
         log.debug('register %s call(%s) to url %s', self.name, event, url)
         comment_vars = [
             ('commit_comment_id', data['comment']['comment_id']),
             ('commit_comment_text', data['comment']['comment_text']),
             ('commit_comment_type', data['comment']['comment_type']),
 
             ('commit_comment_f_path', data['comment']['comment_f_path']),
             ('commit_comment_line_no', data['comment']['comment_line_no']),
 
             ('commit_comment_commit_id', data['commit']['commit_id']),
             ('commit_comment_commit_branch', data['commit']['commit_branch']),
             ('commit_comment_commit_message', data['commit']['commit_message']),
         ]
         for k, v in comment_vars:
             url = UrlTmpl(url).safe_substitute(**{k: v})
 
         return [(url, self.headers, data)]
 
     def repo_commit_comment_edit_handler(self, event, data):
         url = self.get_base_parsed_template(data)
         log.debug('register %s call(%s) to url %s', self.name, event, url)
         comment_vars = [
             ('commit_comment_id', data['comment']['comment_id']),
             ('commit_comment_text', data['comment']['comment_text']),
             ('commit_comment_type', data['comment']['comment_type']),
 
             ('commit_comment_f_path', data['comment']['comment_f_path']),
             ('commit_comment_line_no', data['comment']['comment_line_no']),
 
             ('commit_comment_commit_id', data['commit']['commit_id']),
             ('commit_comment_commit_branch', data['commit']['commit_branch']),
             ('commit_comment_commit_message', data['commit']['commit_message']),
         ]
         for k, v in comment_vars:
             url = UrlTmpl(url).safe_substitute(**{k: v})
 
         return [(url, self.headers, data)]
 
     def repo_create_event_handler(self, event, data):
         url = self.get_base_parsed_template(data)
         log.debug('register %s call(%s) to url %s', self.name, event, url)
         return [(url, self.headers, data)]
 
     def pull_request_event_handler(self, event, data):
         url = self.get_base_parsed_template(data)
         log.debug('register %s call(%s) to url %s', self.name, event, url)
         pr_vars = [
             ('pull_request_id', data['pullrequest']['pull_request_id']),
             ('pull_request_title', data['pullrequest']['title']),
             ('pull_request_url', data['pullrequest']['url']),
             ('pull_request_shadow_url', data['pullrequest']['shadow_url']),
             ('pull_request_commits_uid', data['pullrequest']['commits_uid']),
         ]
         for k, v in pr_vars:
             url = UrlTmpl(url).safe_substitute(**{k: v})
 
         return [(url, self.headers, data)]
 
     def __call__(self, event, data):
         from rhodecode import events
 
         if isinstance(event, events.RepoPushEvent):
             return self.repo_push_event_handler(event, data)
         elif isinstance(event, events.RepoCreateEvent):
             return self.repo_create_event_handler(event, data)
         elif isinstance(event, events.RepoCommitCommentEvent):
             return self.repo_commit_comment_handler(event, data)
         elif isinstance(event, events.RepoCommitCommentEditEvent):
             return self.repo_commit_comment_edit_handler(event, data)
         elif isinstance(event, events.PullRequestEvent):
             return self.pull_request_event_handler(event, data)
         else:
             raise ValueError(
                 'event type `{}` has no handler defined'.format(event.__class__))
 
 
 def get_auth(settings):
     from requests.auth import HTTPBasicAuth
     username = settings.get('username')
     password = settings.get('password')
     if username and password:
         return HTTPBasicAuth(username, password)
     return None
 
 
 def get_web_token(settings):
     return settings['secret_token']
 
 
 def get_url_vars(url_vars):
     items = []
 
     for section, section_items in url_vars:
         items.append('\n*{}*'.format(section))
         for key, explanation in section_items:
             items.append('  {} - {}'.format('${' + key + '}', explanation))
     return '\n'.join(items)
 
 
 def render_with_traceback(template, *args, **kwargs):
     try:
         return template.render(*args, **kwargs)
     except Exception:
         log.error(exceptions.text_error_template().render())
         raise
 
 
 STATUS_400 = (400, 401, 403)
 STATUS_500 = (500, 502, 504)
 
 
 def requests_retry_call(
         retries=3, backoff_factor=0.3, status_forcelist=STATUS_400+STATUS_500,
         session=None):
     """
     session = requests_retry_session()
     response = session.get('http://example.com')
 
     :param retries:
     :param backoff_factor:
     :param status_forcelist:
     :param session:
     """
     session = session or requests.Session()
     retry = Retry(
         total=retries,
         read=retries,
         connect=retries,
         backoff_factor=backoff_factor,
         status_forcelist=status_forcelist,
     )
     adapter = HTTPAdapter(max_retries=retry)
     session.mount('http://', adapter)
     session.mount('https://', adapter)
     return session

rhodecode/integrations/views.py

@@ -1,469 +1,469 b''
 
 
 # Copyright (C) 2012-2020 RhodeCode GmbH
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU Affero General Public License, version 3
 # (only), as published by the Free Software Foundation.
 #
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 # This program is dual-licensed. If you wish to learn more about the
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
 import deform
 import logging
 import peppercorn
 
 from pyramid.httpexceptions import HTTPFound, HTTPForbidden, HTTPNotFound
 
 from rhodecode.integrations import integration_type_registry
 from rhodecode.apps._base import BaseAppView
 from rhodecode.apps._base.navigation import navigation_list
 from rhodecode.lib.auth import (
     LoginRequired, CSRFRequired, HasPermissionAnyDecorator,
     HasRepoPermissionAnyDecorator, HasRepoGroupPermissionAnyDecorator)
 from rhodecode.lib.utils2 import safe_int
 from rhodecode.lib.helpers import Page
 from rhodecode.lib import helpers as h
 from rhodecode.model.db import Repository, RepoGroup, Session, Integration
 from rhodecode.model.scm import ScmModel
 from rhodecode.model.integration import IntegrationModel
 from rhodecode.model.validation_schema.schemas.integration_schema import (
     make_integration_schema, IntegrationScopeType)
 
 log = logging.getLogger(__name__)
 
 
 class IntegrationSettingsViewBase(BaseAppView):
     """
     Base Integration settings view used by both repo / global settings
     """
 
     def __init__(self, context, request):
         super(IntegrationSettingsViewBase, self).__init__(context, request)
         self._load_view_context()
 
     def _load_view_context(self):
         """
         This avoids boilerplate for repo/global+list/edit+views/templates
         by doing all possible contexts at the same time however it should
         be split up into separate functions once more "contexts" exist
         """
 
         self.IntegrationType = None
         self.repo = None
         self.repo_group = None
         self.integration = None
         self.integrations = {}
 
         request = self.request
 
         if 'repo_name' in request.matchdict:  # in repo settings context
             repo_name = request.matchdict['repo_name']
             self.repo = Repository.get_by_repo_name(repo_name)
 
         if 'repo_group_name' in request.matchdict:  # in group settings context
             repo_group_name = request.matchdict['repo_group_name']
             self.repo_group = RepoGroup.get_by_group_name(repo_group_name)
 
         if 'integration' in request.matchdict:  # integration type context
             integration_type = request.matchdict['integration']
             if integration_type not in integration_type_registry:
                 raise HTTPNotFound()
 
             self.IntegrationType = integration_type_registry[integration_type]
             if self.IntegrationType.is_dummy:
                 raise HTTPNotFound()
 
         if 'integration_id' in request.matchdict:  # single integration context
             integration_id = request.matchdict['integration_id']
             self.integration = Integration.get(integration_id)
 
             # extra perms check just in case
             if not self._has_perms_for_integration(self.integration):
                 raise HTTPForbidden()
 
         self.settings = self.integration and self.integration.settings or {}
         self.admin_view = not (self.repo or self.repo_group)
 
     def _has_perms_for_integration(self, integration):
         perms = self.request.user.permissions
 
         if 'hg.admin' in perms['global']:
             return True
 
         if integration.repo:
             return perms['repositories'].get(
                 integration.repo.repo_name) == 'repository.admin'
 
         if integration.repo_group:
             return perms['repositories_groups'].get(
                 integration.repo_group.group_name) == 'group.admin'
 
         return False
 
     def _get_local_tmpl_context(self, include_app_defaults=True):
         _ = self.request.translate
         c = super(IntegrationSettingsViewBase, self)._get_local_tmpl_context(
             include_app_defaults=include_app_defaults)
         c.active = 'integrations'
 
         return c
 
     def _form_schema(self):
         schema = make_integration_schema(IntegrationType=self.IntegrationType,
                                          settings=self.settings)
 
         # returns a clone, important if mutating the schema later
         return schema.bind(
             permissions=self.request.user.permissions,
             no_scope=not self.admin_view)
 
     def _form_defaults(self):
         _ = self.request.translate
         defaults = {}
 
         if self.integration:
             defaults['settings'] = self.integration.settings or {}
             defaults['options'] = {
                 'name': self.integration.name,
                 'enabled': self.integration.enabled,
                 'scope': {
                     'repo': self.integration.repo,
                     'repo_group': self.integration.repo_group,
                     'child_repos_only': self.integration.child_repos_only,
                 },
             }
         else:
             if self.repo:
                 scope = _('{repo_name} repository').format(
                     repo_name=self.repo.repo_name)
             elif self.repo_group:
                 scope = _('{repo_group_name} repo group').format(
                     repo_group_name=self.repo_group.group_name)
             else:
                 scope = _('Global')
 
             defaults['options'] = {
                 'enabled': True,
                 'name': _('{name} integration').format(
                     name=self.IntegrationType.display_name),
             }
             defaults['options']['scope'] = {
                 'repo': self.repo,
                 'repo_group': self.repo_group,
             }
 
         return defaults
 
     def _delete_integration(self, integration):
         _ = self.request.translate
         Session().delete(integration)
         Session().commit()
         h.flash(
             _('Integration {integration_name} deleted successfully.').format(
                 integration_name=integration.name),
             category='success')
 
         if self.repo:
             redirect_to = self.request.route_path(
                 'repo_integrations_home', repo_name=self.repo.repo_name)
         elif self.repo_group:
             redirect_to = self.request.route_path(
                 'repo_group_integrations_home',
                 repo_group_name=self.repo_group.group_name)
         else:
             redirect_to = self.request.route_path('global_integrations_home')
         raise HTTPFound(redirect_to)
 
     def _integration_list(self):
         """ List integrations """
 
         c = self.load_default_context()
         if self.repo:
             scope = self.repo
         elif self.repo_group:
             scope = self.repo_group
         else:
             scope = 'all'
 
         integrations = []
 
         for IntType, integration in IntegrationModel().get_integrations(
                         scope=scope, IntegrationType=self.IntegrationType):
 
             # extra permissions check *just in case*
             if not self._has_perms_for_integration(integration):
                 continue
 
             integrations.append((IntType, integration))
 
         sort_arg = self.request.GET.get('sort', 'name:asc')
         sort_dir = 'asc'
         if ':' in sort_arg:
             sort_field, sort_dir = sort_arg.split(':')
         else:
             sort_field = sort_arg, 'asc'
 
         assert sort_field in ('name', 'integration_type', 'enabled', 'scope')
 
         integrations.sort(
             key=lambda x: getattr(x[1], sort_field),
             reverse=(sort_dir == 'desc'))
 
         def url_generator(page_num):
             query_params = {
                 'page': page_num
             }
             return self.request.current_route_path(_query=query_params)
 
         page = safe_int(self.request.GET.get('page', 1), 1)
 
         integrations = Page(
             integrations, page=page, items_per_page=10, url_maker=url_generator)
 
         c.rev_sort_dir = sort_dir != 'desc' and 'desc' or 'asc'
 
         c.current_IntegrationType = self.IntegrationType
         c.integrations_list = integrations
         c.available_integrations = integration_type_registry
 
         return self._get_template_context(c)
 
     def _settings_get(self, defaults=None, form=None):
         """
         View that displays the integration settings as a form.
         """
         c = self.load_default_context()
 
         defaults = defaults or self._form_defaults()
         schema = self._form_schema()
 
         if self.integration:
             buttons = ('submit', 'delete')
         else:
             buttons = ('submit',)
 
         form = form or deform.Form(schema, appstruct=defaults, buttons=buttons)
 
         c.form = form
         c.current_IntegrationType = self.IntegrationType
         c.integration = self.integration
 
         return self._get_template_context(c)
 
     def _settings_post(self):
         """
         View that validates and stores the integration settings.
         """
         _ = self.request.translate
 
-        controls = self.request.POST.items()
+        controls = list(self.request.POST.items())
         pstruct = peppercorn.parse(controls)
 
         if self.integration and pstruct.get('delete'):
             return self._delete_integration(self.integration)
 
         schema = self._form_schema()
 
         skip_settings_validation = False
         if self.integration and 'enabled' not in pstruct.get('options', {}):
             skip_settings_validation = True
             schema['settings'].validator = None
             for field in schema['settings'].children:
                 field.validator = None
                 field.missing = ''
 
         if self.integration:
             buttons = ('submit', 'delete')
         else:
             buttons = ('submit',)
 
         form = deform.Form(schema, buttons=buttons)
 
         if not self.admin_view:
             # scope is read only field in these cases, and has to be added
             options = pstruct.setdefault('options', {})
             if 'scope' not in options:
                 options['scope'] = IntegrationScopeType().serialize(None, {
                     'repo': self.repo,
                     'repo_group': self.repo_group,
                 })
 
         try:
             valid_data = form.validate_pstruct(pstruct)
         except deform.ValidationFailure as e:
             h.flash(
                 _('Errors exist when saving integration settings. '
                   'Please check the form inputs.'),
                 category='error')
             return self._settings_get(form=e)
 
         if not self.integration:
             self.integration = Integration()
             self.integration.integration_type = self.IntegrationType.key
             Session().add(self.integration)
 
         scope = valid_data['options']['scope']
 
         IntegrationModel().update_integration(self.integration,
             name=valid_data['options']['name'],
             enabled=valid_data['options']['enabled'],
             settings=valid_data['settings'],
             repo=scope['repo'],
             repo_group=scope['repo_group'],
             child_repos_only=scope['child_repos_only'],
         )
 
         self.integration.settings = valid_data['settings']
         Session().commit()
         # Display success message and redirect.
         h.flash(
             _('Integration {integration_name} updated successfully.').format(
                 integration_name=self.IntegrationType.display_name),
             category='success')
 
         # if integration scope changes, we must redirect to the right place
         # keeping in mind if the original view was for /repo/ or /_admin/
         admin_view = not (self.repo or self.repo_group)
 
         if self.integration.repo and not admin_view:
             redirect_to = self.request.route_path(
                 'repo_integrations_edit',
                 repo_name=self.integration.repo.repo_name,
                 integration=self.integration.integration_type,
                 integration_id=self.integration.integration_id)
         elif self.integration.repo_group and not admin_view:
             redirect_to = self.request.route_path(
                 'repo_group_integrations_edit',
                 repo_group_name=self.integration.repo_group.group_name,
                 integration=self.integration.integration_type,
                 integration_id=self.integration.integration_id)
         else:
             redirect_to = self.request.route_path(
                 'global_integrations_edit',
                 integration=self.integration.integration_type,
                 integration_id=self.integration.integration_id)
 
         return HTTPFound(redirect_to)
 
     def _new_integration(self):
         c = self.load_default_context()
         c.available_integrations = integration_type_registry
         return self._get_template_context(c)
 
     def load_default_context(self):
         raise NotImplementedError()
 
 
 class GlobalIntegrationsView(IntegrationSettingsViewBase):
     def load_default_context(self):
         c = self._get_local_tmpl_context()
         c.repo = self.repo
         c.repo_group = self.repo_group
         c.navlist = navigation_list(self.request)
 
         return c
 
     @LoginRequired()
     @HasPermissionAnyDecorator('hg.admin')
     def integration_list(self):
         return self._integration_list()
 
     @LoginRequired()
     @HasPermissionAnyDecorator('hg.admin')
     def settings_get(self):
         return self._settings_get()
 
     @LoginRequired()
     @HasPermissionAnyDecorator('hg.admin')
     @CSRFRequired()
     def settings_post(self):
         return self._settings_post()
 
     @LoginRequired()
     @HasPermissionAnyDecorator('hg.admin')
     def new_integration(self):
         return self._new_integration()
 
 
 class RepoIntegrationsView(IntegrationSettingsViewBase):
     def load_default_context(self):
         c = self._get_local_tmpl_context()
 
         c.repo = self.repo
         c.repo_group = self.repo_group
 
         self.db_repo = self.repo
         c.rhodecode_db_repo = self.repo
         c.repo_name = self.db_repo.repo_name
         c.repository_pull_requests = ScmModel().get_pull_requests(self.repo)
         c.repository_artifacts = ScmModel().get_artifacts(self.repo)
         c.repository_is_user_following = ScmModel().is_following_repo(
             c.repo_name, self._rhodecode_user.user_id)
         c.has_origin_repo_read_perm = False
         if self.db_repo.fork:
             c.has_origin_repo_read_perm = h.HasRepoPermissionAny(
                 'repository.write', 'repository.read', 'repository.admin')(
                 self.db_repo.fork.repo_name, 'summary fork link')
         return c
 
     @LoginRequired()
     @HasRepoPermissionAnyDecorator('repository.admin')
     def integration_list(self):
         return self._integration_list()
 
     @LoginRequired()
     @HasRepoPermissionAnyDecorator('repository.admin')
     def settings_get(self):
         return self._settings_get()
 
     @LoginRequired()
     @HasRepoPermissionAnyDecorator('repository.admin')
     @CSRFRequired()
     def settings_post(self):
         return self._settings_post()
 
     @LoginRequired()
     @HasRepoPermissionAnyDecorator('repository.admin')
     def new_integration(self):
         return self._new_integration()
 
 
 class RepoGroupIntegrationsView(IntegrationSettingsViewBase):
     def load_default_context(self):
         c = self._get_local_tmpl_context()
         c.repo = self.repo
         c.repo_group = self.repo_group
         c.navlist = navigation_list(self.request)
 
         return c
 
     @LoginRequired()
     @HasRepoGroupPermissionAnyDecorator('group.admin')
     def integration_list(self):
         return self._integration_list()
 
     @LoginRequired()
     @HasRepoGroupPermissionAnyDecorator('group.admin')
     def settings_get(self):
         return self._settings_get()
 
     @LoginRequired()
     @HasRepoGroupPermissionAnyDecorator('group.admin')
     @CSRFRequired()
     def settings_post(self):
         return self._settings_post()
 
     @LoginRequired()
     @HasRepoGroupPermissionAnyDecorator('group.admin')
     def new_integration(self):
         return self._new_integration()