permissions: use constant for fork enable/disable

rhodecode/api/views/repo_api.py

@@ -1212,7 +1212,7 b' def fork_repo(request, apiuser, repoid, '
         validate_repo_permissions(apiuser, repoid, repo, _perms)
 
         # check if the regular user has at least fork permissions as well
-        if not HasPermissionAnyApi('hg.fork.repository')(user=apiuser):
+        if not HasPermissionAnyApi(PermissionModel.FORKING_ENABLED)(user=apiuser):
             raise JSONRPCForbidden()
 
     # check if user can set owner parameter

rhodecode/apps/repository/views/repo_forks.py

@@ -165,7 +165,7 b' class RepoForksView(RepoAppView, DataGri'
 
     @LoginRequired()
     @NotAnonymous()
-    @HasPermissionAnyDecorator('hg.admin', 'hg.fork.repository')
+    @HasPermissionAnyDecorator('hg.admin', PermissionModel.FORKING_ENABLED)
     @HasRepoPermissionAnyDecorator(
         'repository.read', 'repository.write', 'repository.admin')
     def repo_fork_new(self):
@@ -191,7 +191,7 b' class RepoForksView(RepoAppView, DataGri'
 
     @LoginRequired()
     @NotAnonymous()
-    @HasPermissionAnyDecorator('hg.admin', 'hg.fork.repository')
+    @HasPermissionAnyDecorator('hg.admin', PermissionModel.FORKING_ENABLED)
     @HasRepoPermissionAnyDecorator(
         'repository.read', 'repository.write', 'repository.admin')
     @CSRFRequired()

rhodecode/lib/auth.py

@@ -524,8 +524,10 b' class PermissionCalculator(object):'
 
         # In case we want to extend this list we should make sure
         # this is in sync with User.DEFAULT_USER_PERMISSIONS definitions
+        from rhodecode.model.permission import PermissionModel
+
         _configurable = frozenset([
-            'hg.fork.none', 'hg.fork.repository',
+            PermissionModel.FORKING_DISABLED, PermissionModel.FORKING_ENABLED,
             'hg.create.none', 'hg.create.repository',
             'hg.usergroup.create.false', 'hg.usergroup.create.true',
             'hg.repogroup.create.false', 'hg.repogroup.create.true',

rhodecode/model/permission.py

@@ -41,6 +41,8 b' class PermissionModel(BaseModel):'
     """
     Permissions model for RhodeCode
     """
+    FORKING_DISABLED = 'hg.fork.none'
+    FORKING_ENABLED = 'hg.fork.repository'
 
     cls = Permission
     global_perms = {
@@ -122,8 +124,8 b' class PermissionModel(BaseModel):'
             ('hg.repogroup.create.true', _('Enabled'))]
 
         c_obj.fork_choices = [
-            ('hg.fork.none', _('Disabled')),
-            ('hg.fork.repository', _('Enabled'))]
+            (self.FORKING_DISABLED, _('Disabled')),
+            (self.FORKING_ENABLED, _('Enabled'))]
 
         c_obj.inherit_default_permission_choices = [
             ('hg.inherit_default_perms.false', _('Disabled')),