##// END OF EJS Templates
repo-schemas: refactor repository schemas and use it in API update/create functions....
repo-schemas: refactor repository schemas and use it in API update/create functions. - now it uses consistent way of serializing/validating data - parent groups are consistenty handled by name parameter - fixes #4133 - fixes other problems with bad data - changes API slightly - validation chain ordering, first permissions, then uniqness. Helps prevent resource disvovery

File last commit:

r1:854a839a default
r1153:0f1be4aa default
Show More
test_create_repo_group.py
199 lines | 7.6 KiB | text/x-python | PythonLexer
/ rhodecode / api / tests / test_create_repo_group.py
# -*- coding: utf-8 -*-
# Copyright (C) 2010-2016 RhodeCode GmbH
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License, version 3
# (only), as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# This program is dual-licensed. If you wish to learn more about the
# RhodeCode Enterprise Edition, including its added features, Support services,
# and proprietary license terms, please see https://rhodecode.com/licenses/
import mock
import pytest
from rhodecode.model.meta import Session
from rhodecode.model.repo_group import RepoGroupModel
from rhodecode.model.user import UserModel
from rhodecode.tests import TEST_USER_ADMIN_LOGIN
from rhodecode.api.tests.utils import (
build_data, api_call, assert_ok, assert_error, crash)
from rhodecode.tests.fixture import Fixture
fixture = Fixture()
@pytest.mark.usefixtures("testuser_api", "app")
class TestCreateRepoGroup(object):
def test_api_create_repo_group(self):
repo_group_name = 'api-repo-group'
repo_group = RepoGroupModel.cls.get_by_group_name(repo_group_name)
assert repo_group is None
id_, params = build_data(
self.apikey, 'create_repo_group',
group_name=repo_group_name,
owner=TEST_USER_ADMIN_LOGIN,)
response = api_call(self.app, params)
repo_group = RepoGroupModel.cls.get_by_group_name(repo_group_name)
assert repo_group is not None
ret = {
'msg': 'Created new repo group `%s`' % (repo_group_name,),
'repo_group': repo_group.get_api_data()
}
expected = ret
assert_ok(id_, expected, given=response.body)
fixture.destroy_repo_group(repo_group_name)
def test_api_create_repo_group_regular_user(self):
repo_group_name = 'api-repo-group'
usr = UserModel().get_by_username(self.TEST_USER_LOGIN)
usr.inherit_default_permissions = False
Session().add(usr)
UserModel().grant_perm(
self.TEST_USER_LOGIN, 'hg.repogroup.create.true')
Session().commit()
repo_group = RepoGroupModel.cls.get_by_group_name(repo_group_name)
assert repo_group is None
id_, params = build_data(
self.apikey_regular, 'create_repo_group',
group_name=repo_group_name,
owner=TEST_USER_ADMIN_LOGIN,)
response = api_call(self.app, params)
repo_group = RepoGroupModel.cls.get_by_group_name(repo_group_name)
assert repo_group is not None
ret = {
'msg': 'Created new repo group `%s`' % (repo_group_name,),
'repo_group': repo_group.get_api_data()
}
expected = ret
assert_ok(id_, expected, given=response.body)
fixture.destroy_repo_group(repo_group_name)
UserModel().revoke_perm(
self.TEST_USER_LOGIN, 'hg.repogroup.create.true')
usr = UserModel().get_by_username(self.TEST_USER_LOGIN)
usr.inherit_default_permissions = True
Session().add(usr)
Session().commit()
def test_api_create_repo_group_regular_user_no_permission(self):
repo_group_name = 'api-repo-group'
id_, params = build_data(
self.apikey_regular, 'create_repo_group',
group_name=repo_group_name,
owner=TEST_USER_ADMIN_LOGIN,)
response = api_call(self.app, params)
expected = "Access was denied to this resource."
assert_error(id_, expected, given=response.body)
def test_api_create_repo_group_in_another_group(self):
repo_group_name = 'api-repo-group'
repo_group = RepoGroupModel.cls.get_by_group_name(repo_group_name)
assert repo_group is None
# create the parent
fixture.create_repo_group(repo_group_name)
full_repo_group_name = repo_group_name+'/'+repo_group_name
id_, params = build_data(
self.apikey, 'create_repo_group',
group_name=full_repo_group_name,
owner=TEST_USER_ADMIN_LOGIN,
copy_permissions=True)
response = api_call(self.app, params)
repo_group = RepoGroupModel.cls.get_by_group_name(full_repo_group_name)
assert repo_group is not None
ret = {
'msg': 'Created new repo group `%s`' % (full_repo_group_name,),
'repo_group': repo_group.get_api_data()
}
expected = ret
assert_ok(id_, expected, given=response.body)
fixture.destroy_repo_group(full_repo_group_name)
fixture.destroy_repo_group(repo_group_name)
def test_api_create_repo_group_in_another_group_not_existing(self):
repo_group_name = 'api-repo-group-no'
repo_group = RepoGroupModel.cls.get_by_group_name(repo_group_name)
assert repo_group is None
full_repo_group_name = repo_group_name+'/'+repo_group_name
id_, params = build_data(
self.apikey, 'create_repo_group',
group_name=full_repo_group_name,
owner=TEST_USER_ADMIN_LOGIN,
copy_permissions=True)
response = api_call(self.app, params)
expected = 'repository group `%s` does not exist' % (repo_group_name,)
assert_error(id_, expected, given=response.body)
def test_api_create_repo_group_that_exists(self):
repo_group_name = 'api-repo-group'
repo_group = RepoGroupModel.cls.get_by_group_name(repo_group_name)
assert repo_group is None
fixture.create_repo_group(repo_group_name)
id_, params = build_data(
self.apikey, 'create_repo_group',
group_name=repo_group_name,
owner=TEST_USER_ADMIN_LOGIN,)
response = api_call(self.app, params)
expected = 'repo group `%s` already exist' % (repo_group_name,)
assert_error(id_, expected, given=response.body)
fixture.destroy_repo_group(repo_group_name)
@mock.patch.object(RepoGroupModel, 'create', crash)
def test_api_create_repo_group_exception_occurred(self):
repo_group_name = 'api-repo-group'
repo_group = RepoGroupModel.cls.get_by_group_name(repo_group_name)
assert repo_group is None
id_, params = build_data(
self.apikey, 'create_repo_group',
group_name=repo_group_name,
owner=TEST_USER_ADMIN_LOGIN,)
response = api_call(self.app, params)
expected = 'failed to create repo group `%s`' % (repo_group_name,)
assert_error(id_, expected, given=response.body)
def test_create_group_with_extra_slashes_in_name(self, user_util):
existing_repo_group = user_util.create_repo_group()
dirty_group_name = '//{}//group2//'.format(
existing_repo_group.group_name)
cleaned_group_name = '{}/group2'.format(
existing_repo_group.group_name)
id_, params = build_data(
self.apikey, 'create_repo_group',
group_name=dirty_group_name,
owner=TEST_USER_ADMIN_LOGIN,)
response = api_call(self.app, params)
repo_group = RepoGroupModel.cls.get_by_group_name(cleaned_group_name)
expected = {
'msg': 'Created new repo group `%s`' % (cleaned_group_name,),
'repo_group': repo_group.get_api_data()
}
assert_ok(id_, expected, given=response.body)
fixture.destroy_repo_group(cleaned_group_name)