##// END OF EJS Templates
vcs: Minimal change to expose the shadow repository...
vcs: Minimal change to expose the shadow repository Based on my original research, this was the "minimal" starting point. It shows that three concepts are needed for the "repo_name": * From the security standpoint we think of the shadow repository having the same ACL as the target repository of the pull request. This is because the pull request itself is considered to be a part of the target repository. Out of this thought, the variable "acl_repo_name" is used whenever we want to check permissions or when we need the database configuration of the repository. An alternative name would have been "db_repo_name", but the usage for ACL checking is the most important one. * From the web interaction perspective, we need the URL which was originally used to get to the repository. This is because based on this base URL commands can be identified. Especially for Git this is important, so that the commands are correctly recognized. Since the URL is in the focus, this is called "url_repo_name". * Finally we have to deal with the repository on the file system. This is what the VCS layer deal with normally, so this name is called "vcs_repo_name". The original repository interaction is a special case where all three names are the same. When interacting with a pull request, these three names are typically all different. This change is minimal in a sense that it just makes the interaction with a shadow repository barely work, without checking any special constraints yet. This was the starting point for further work on this topic.

File last commit:

r594:71243b44 default
r887:175782be default
Show More
appenlight.py
91 lines | 3.1 KiB | text/x-python | PythonLexer
# -*- coding: utf-8 -*-
# Copyright (C) 2010-2016 RhodeCode GmbH
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License, version 3
# (only), as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# This program is dual-licensed. If you wish to learn more about the
# RhodeCode Enterprise Edition, including its added features, Support services,
# and proprietary license terms, please see https://rhodecode.com/licenses/
"""
middleware to handle appenlight publishing of errors
"""
from appenlight_client import make_appenlight_middleware
from appenlight_client.exceptions import get_current_traceback
from appenlight_client.wsgi import AppenlightWSGIWrapper
def track_exception(environ):
if 'appenlight.client' not in environ:
return
# pass the traceback object to middleware
environ['appenlight.__traceback'] = get_current_traceback(
skip=1,
show_hidden_frames=True,
ignore_system_exceptions=True)
def track_extra_information(environ, section, value):
"""
Utility function to attach extra information in case of an error condition.
It will take care of attaching this information to the right place inside
of `environ`, so that the appenight client can pick it up.
"""
environ.setdefault('appenlight.extra', {})
environ['appenlight.extra'][section] = value
def wrap_in_appenlight_if_enabled(app, settings, appenlight_client=None):
"""
Wraps the given `app` for appenlight support.
.. important::
Appenlight expects that the wrapper is executed only once, that's why
the parameter `appenlight_client` can be used to pass in an already
existing client instance to avoid that decorators are applied more than
once.
This is in use to support our setup of the vcs related middlewares.
"""
if settings['appenlight']:
app = RemoteTracebackTracker(app)
if not appenlight_client:
app = make_appenlight_middleware(app, settings)
appenlight_client = app.appenlight_client
else:
app = AppenlightWSGIWrapper(app, appenlight_client)
return app, appenlight_client
class RemoteTracebackTracker(object):
"""
Utility middleware which forwards Pyro4 remote traceback information.
"""
def __init__(self, app):
self.application = app
def __call__(self, environ, start_response):
try:
return self.application(environ, start_response)
except Exception as e:
if hasattr(e, '_pyroTraceback'):
track_extra_information(
environ, 'remote_traceback', ''.join(e._pyroTraceback))
raise