##// END OF EJS Templates
vcs: Minimal change to expose the shadow repository...
vcs: Minimal change to expose the shadow repository Based on my original research, this was the "minimal" starting point. It shows that three concepts are needed for the "repo_name": * From the security standpoint we think of the shadow repository having the same ACL as the target repository of the pull request. This is because the pull request itself is considered to be a part of the target repository. Out of this thought, the variable "acl_repo_name" is used whenever we want to check permissions or when we need the database configuration of the repository. An alternative name would have been "db_repo_name", but the usage for ACL checking is the most important one. * From the web interaction perspective, we need the URL which was originally used to get to the repository. This is because based on this base URL commands can be identified. Especially for Git this is important, so that the commands are correctly recognized. Since the URL is in the focus, this is called "url_repo_name". * Finally we have to deal with the repository on the file system. This is what the VCS layer deal with normally, so this name is called "vcs_repo_name". The original repository interaction is a special case where all three names are the same. When interacting with a pull request, these three names are typically all different. This change is minimal in a sense that it just makes the interaction with a shadow repository barely work, without checking any special constraints yet. This was the starting point for further work on this topic.

File last commit:

r848:2956cade default
r887:175782be default
Show More
scm_app_http.py
140 lines | 4.3 KiB | text/x-python | PythonLexer
# -*- coding: utf-8 -*-
# Copyright (C) 2014-2016 RhodeCode GmbH
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License, version 3
# (only), as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# This program is dual-licensed. If you wish to learn more about the
# RhodeCode Enterprise Edition, including its added features, Support services,
# and proprietary license terms, please see https://rhodecode.com/licenses/
"""
Implementation of the scm_app interface using raw HTTP communication.
"""
import base64
import logging
import urlparse
import wsgiref.util
import msgpack
import requests
import webob.request
import rhodecode
log = logging.getLogger(__name__)
def create_git_wsgi_app(repo_path, repo_name, config, backend):
url = _vcs_streaming_url() + 'git/'
return VcsHttpProxy(url, repo_path, repo_name, config, backend)
def create_hg_wsgi_app(repo_path, repo_name, config, backend):
url = _vcs_streaming_url() + 'hg/'
return VcsHttpProxy(url, repo_path, repo_name, config, backend)
def _vcs_streaming_url():
template = 'http://{}/stream/'
return template.format(rhodecode.CONFIG['vcs.server'])
# TODO: johbo: Avoid the global.
session = requests.Session()
# Requests speedup, avoid reading .netrc and similar
session.trust_env = False
class VcsHttpProxy(object):
"""
A WSGI application which proxies vcs requests.
The goal is to shuffle the data around without touching it. The only
exception is the extra data from the config object which we send to the
server as well.
"""
def __init__(self, url, repo_path, repo_name, config, backend):
"""
:param str url: The URL of the VCSServer to call.
"""
self._url = url
self._repo_name = repo_name
self._repo_path = repo_path
self._config = config
self._backend = backend
log.debug(
"Creating VcsHttpProxy for repo %s, url %s",
repo_name, url)
def __call__(self, environ, start_response):
status = '200 OK'
config = msgpack.packb(self._config)
request = webob.request.Request(environ)
request_headers = request.headers
request_headers.update({
# TODO: johbo: Remove this, rely on URL path only
'X-RC-Repo-Name': self._repo_name,
'X-RC-Repo-Path': self._repo_path,
'X-RC-Path-Info': environ['PATH_INFO'],
# TODO: johbo: Avoid encoding and put this into payload?
'X-RC-Repo-Config': base64.b64encode(config),
})
data = environ['wsgi.input'].read()
method = environ['REQUEST_METHOD']
# Preserve the query string
url = self._url
url = urlparse.urljoin(url, self._repo_name)
if environ.get('QUERY_STRING'):
url += '?' + environ['QUERY_STRING']
response = session.request(
method, url,
data=data,
headers=request_headers,
stream=True)
# Preserve the headers of the response, except hop_by_hop ones
response_headers = [
(h, v) for h, v in response.headers.items()
if not wsgiref.util.is_hop_by_hop(h)
]
# Add custom response header to indicate that this is a VCS response
# and which backend is used.
response_headers.append(('X-RhodeCode-Backend', self._backend))
# TODO: johbo: Better way to get the status including text?
status = str(response.status_code)
start_response(status, response_headers)
return _maybe_stream(response)
def _maybe_stream(response):
"""
Try to generate chunks from the response if it is chunked.
"""
if _is_chunked(response):
return response.raw.read_chunked()
else:
return [response.content]
def _is_chunked(response):
return response.headers.get('Transfer-Encoding', '') == 'chunked'