rhodecode-enterprise-ce Files · rhodecode/lib/dbmigrate/migrate/versioning/script/sql.py

goto-switcher: optimized performance and query capabilities....

goto-switcher: optimized performance and query capabilities. - Previous implementation had on significant bug. The use of LIMIT 20 was limiting results BEFORE auth checks. In case of large ammount of similarly named repositories user didn't had access too, the result goto search was empty. This was becuase first 20 items fetched didn't pass permission checks and final auth list was empty. To fix this we now use proper filtering for auth using SQL. It means we first check user allowed repositories, and add this as a filter so end result from database is already to only the accessible repositories.

marcink - - Load All Authors

File last commit:

r1:854a839a default


                r2038:2bdf9d4d

default

Download file

             sql.py
        
                    49 lines
            
             | 1.7 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / rhodecode / lib / dbmigrate / migrate / versioning / script / sql.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #!/usr/bin/env python

      # -*- coding: utf-8 -*-

      import logging

      import shutil

      from rhodecode.lib.dbmigrate.migrate.versioning.script import base

      from rhodecode.lib.dbmigrate.migrate.versioning.template import Template

      log = logging.getLogger(__name__)

      class SqlScript(base.BaseScript):

          """A file containing plain SQL statements."""

          @classmethod

          def create(cls, path, **opts):

              """Create an empty migration script at specified path

              :returns: :class:`SqlScript instance <migrate.versioning.script.sql.SqlScript>`"""

              cls.require_notfound(path)

              src = Template(opts.pop('templates_path', None)).get_sql_script(theme=opts.pop('templates_theme', None))

              shutil.copy(src, path)

              return cls(path)

          # TODO: why is step parameter even here?

          def run(self, engine, step=None, executemany=True):

              """Runs SQL script through raw dbapi execute call"""

              text = self.source()

              # Don't rely on SA's autocommit here

              # (SA uses .startswith to check if a commit is needed. What if script

              # starts with a comment?)

              conn = engine.connect()

              try:

                  trans = conn.begin()

                  try:

                      # HACK: SQLite doesn't allow multiple statements through

                      # its execute() method, but it provides executescript() instead

                      dbapi = conn.engine.raw_connection()

                      if executemany and getattr(dbapi, 'executescript', None):

                          dbapi.executescript(text)

                      else:

                          conn.execute(text)

                      trans.commit()

                  except:

                      trans.rollback()

                      raise

              finally:

                  conn.close()

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#!/usr/bin/env python
				# -- coding: utf-8 --
				import logging
				import shutil

				from rhodecode.lib.dbmigrate.migrate.versioning.script import base
				from rhodecode.lib.dbmigrate.migrate.versioning.template import Template


				log = logging.getLogger(__name__)

				class SqlScript(base.BaseScript):
				"""A file containing plain SQL statements."""

				@classmethod
				def create(cls, path, **opts):
				"""Create an empty migration script at specified path

				:returns: :class:`SqlScript instance <migrate.versioning.script.sql.SqlScript>`"""
				cls.require_notfound(path)

				src = Template(opts.pop('templates_path', None)).get_sql_script(theme=opts.pop('templates_theme', None))
				shutil.copy(src, path)
				return cls(path)

				# TODO: why is step parameter even here?
				def run(self, engine, step=None, executemany=True):
				"""Runs SQL script through raw dbapi execute call"""
				text = self.source()
				# Don't rely on SA's autocommit here
				# (SA uses .startswith to check if a commit is needed. What if script
				# starts with a comment?)
				conn = engine.connect()
				try:
				trans = conn.begin()
				try:
				# HACK: SQLite doesn't allow multiple statements through
				# its execute() method, but it provides executescript() instead
				dbapi = conn.engine.raw_connection()
				if executemany and getattr(dbapi, 'executescript', None):
				dbapi.executescript(text)
				else:
				conn.execute(text)
				trans.commit()
				except:
				trans.rollback()
				raise
				finally:
				conn.close()