rhodecode-enterprise-ce Files · rhodecode/model/validation_schema/schemas/reviewer_schema.py

goto-switcher: optimized performance and query capabilities....

goto-switcher: optimized performance and query capabilities. - Previous implementation had on significant bug. The use of LIMIT 20 was limiting results BEFORE auth checks. In case of large ammount of similarly named repositories user didn't had access too, the result goto search was empty. This was becuase first 20 items fetched didn't pass permission checks and final auth list was empty. To fix this we now use proper filtering for auth using SQL. It means we first check user allowed repositories, and add this as a filter so end result from database is already to only the accessible repositories.

dan - - Load All Authors

File last commit:

r1795:4b1dac88 default


                r2038:2bdf9d4d

default

Download file

             reviewer_schema.py
        
                    34 lines
            
             | 1.3 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / rhodecode / model / validation_schema / schemas / reviewer_schema.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # -*- coding: utf-8 -*-

      # Copyright (C) 2016-2017 RhodeCode GmbH

      #

      # This program is free software: you can redistribute it and/or modify

      # it under the terms of the GNU Affero General Public License, version 3

      # (only), as published by the Free Software Foundation.

      #

      # This program is distributed in the hope that it will be useful,

      # but WITHOUT ANY WARRANTY; without even the implied warranty of

      # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

      # GNU General Public License for more details.

      #

      # You should have received a copy of the GNU Affero General Public License

      # along with this program.  If not, see <http://www.gnu.org/licenses/>.

      #

      # This program is dual-licensed. If you wish to learn more about the

      # RhodeCode Enterprise Edition, including its added features, Support services,

      # and proprietary license terms, please see https://rhodecode.com/licenses/

      import colander

      from rhodecode.model.validation_schema import validators, preparers, types

      class ReviewerSchema(colander.MappingSchema):

          username = colander.SchemaNode(types.StrOrIntType())

          reasons = colander.SchemaNode(colander.List(), missing=['no reason specified'])

          mandatory = colander.SchemaNode(colander.Boolean(), missing=False)

      class ReviewerListSchema(colander.SequenceSchema):

          reviewers = ReviewerSchema()

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# -- coding: utf-8 --

				# Copyright (C) 2016-2017 RhodeCode GmbH
				#
				# This program is free software: you can redistribute it and/or modify
				# it under the terms of the GNU Affero General Public License, version 3
				# (only), as published by the Free Software Foundation.
				#
				# This program is distributed in the hope that it will be useful,
				# but WITHOUT ANY WARRANTY; without even the implied warranty of
				# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
				# GNU General Public License for more details.
				#
				# You should have received a copy of the GNU Affero General Public License
				# along with this program. If not, see <http://www.gnu.org/licenses/>.
				#
				# This program is dual-licensed. If you wish to learn more about the
				# RhodeCode Enterprise Edition, including its added features, Support services,
				# and proprietary license terms, please see https://rhodecode.com/licenses/

				import colander
				from rhodecode.model.validation_schema import validators, preparers, types


				class ReviewerSchema(colander.MappingSchema):
				username = colander.SchemaNode(types.StrOrIntType())
				reasons = colander.SchemaNode(colander.List(), missing=['no reason specified'])
				mandatory = colander.SchemaNode(colander.Boolean(), missing=False)


				class ReviewerListSchema(colander.SequenceSchema):
				reviewers = ReviewerSchema()