rhodecode-enterprise-ce Files · rhodecode/templates/search/search_path.mako

goto-switcher: optimized performance and query capabilities....

goto-switcher: optimized performance and query capabilities. - Previous implementation had on significant bug. The use of LIMIT 20 was limiting results BEFORE auth checks. In case of large ammount of similarly named repositories user didn't had access too, the result goto search was empty. This was becuase first 20 items fetched didn't pass permission checks and final auth list was empty. To fix this we now use proper filtering for auth using SQL. It means we first check user allowed repositories, and add this as a filter so end result from database is already to only the accessible repositories.

marcink - - Load All Authors

File last commit:

r1927:e6df2b71 default


                r2038:2bdf9d4d

default

Download file

             search_path.mako
        
                    33 lines
            
             | 1.5 KiB
            
                | application/x-mako
            
             |
                MakoHtmlLexer
            
             / rhodecode / templates / search / search_path.mako
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      <table class="rctable search-results">

          <tr>

              <th>${_('Repository')}</th>

              <th>${_('File')}</th>

              ##TODO: add 'Last Change' and 'Author' here

          </tr>

          %for entry in c.formatted_results:

              ## search results are additionally filtered, and this check is just a safe gate

              % if h.HasRepoPermissionAny('repository.write','repository.read','repository.admin')(entry['repository'], 'search results path check'):

                  <tr class="body">

                      <td class="td-componentname">

                          %if h.get_repo_type_by_name(entry.get('repository')) == 'hg':

                              <i class="icon-hg"></i>

                          %elif h.get_repo_type_by_name(entry.get('repository')) == 'git':

                              <i class="icon-git"></i>

                          %elif h.get_repo_type_by_name(entry.get('repository')) == 'svn':

                              <i class="icon-svn"></i>

                          %endif

                          ${h.link_to(entry['repository'], h.route_path('repo_summary',repo_name=entry['repository']))}

                      </td>

                      <td class="td-componentname">

                          ${h.link_to(h.literal(entry['f_path']),

                              h.route_path('repo_files',repo_name=entry['repository'],commit_id='tip',f_path=entry['f_path']))}

                      </td>

                  </tr>

              % endif

          %endfor

      </table>

      %if c.cur_query and c.formatted_results:

      <div class="pagination-wh pagination-left">

          ${c.formatted_results.pager('$link_previous ~2~ $link_next')}

      </div>

      %endif

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				<table class="rctable search-results">
				<tr>
				<th>${_('Repository')}</th>
				<th>${_('File')}</th>
				##TODO: add 'Last Change' and 'Author' here
				</tr>
				%for entry in c.formatted_results:
				## search results are additionally filtered, and this check is just a safe gate
				% if h.HasRepoPermissionAny('repository.write','repository.read','repository.admin')(entry['repository'], 'search results path check'):
				<tr class="body">
				<td class="td-componentname">
				%if h.get_repo_type_by_name(entry.get('repository')) == 'hg':
				<i class="icon-hg"></i>
				%elif h.get_repo_type_by_name(entry.get('repository')) == 'git':
				<i class="icon-git"></i>
				%elif h.get_repo_type_by_name(entry.get('repository')) == 'svn':
				<i class="icon-svn"></i>
				%endif
				${h.link_to(entry['repository'], h.route_path('repo_summary',repo_name=entry['repository']))}
				</td>
				<td class="td-componentname">
				${h.link_to(h.literal(entry['f_path']),
				h.route_path('repo_files',repo_name=entry['repository'],commit_id='tip',f_path=entry['f_path']))}
				</td>
				</tr>
				% endif
				%endfor
				</table>

				%if c.cur_query and c.formatted_results:
				<div class="pagination-wh pagination-left">
				${c.formatted_results.pager('$link_previous ~2~ $link_next')}
				</div>
				%endif