rhodecode-enterprise-ce Pull Request !2251

Closed

Pull request !2251 Created on by

ewong

Bug 5509 - remove !important from css rules.

Commit flow:

branch:default of u/ewong/rhodecode-enterprise-ce-fork → branch:default of rhodecode-enterprise-ce

Versions:

Pull request versions not available.

Collapse 1 commit

ver	Time	Author	Commit		Description
`latest`	Thu, 06 Dec 2018 16:13:46	ewong	`r3048:ec80e5e97132`		Bug 5509 - remove \!important from css rules.
1 commit hidden, click expand to show them.

Collapse all files

No files

General Comments 4

ewong

|

Auto status change to "Under Review"

note

jenkins-tests

|

Build Succeeded: http://internal-jenkins.rhodecode.com/job/rhodecode-enterprise-ce-public-prs/8/

lisaq

|

Hi !

First thanks for your contributin. We really appriciate it.
Saddly after doing some checks this breaks a lot of things. We know having !important tags is bad, this is why we're going to remove them, but this has
to be done by our UI team, after checking 100s of UI elements styling.

I'm going to reject that, if you see any specific !important tags to be removed let us know in tickets on issues.rhodecode.com.

marcink

|

Closing with status change > Rejected.

No TODOs yet

		Closing with status change > Rejected.
		Hi !...
		Build Succeeded: http://internal-jenkins.rhodecode.com/job/rhodecode-enterprise-ce-public-prs/8/
		Auto status change to \|new_status\|...

In pull request description:

No Ticket data found.

In commit messages:

No Ticket data found.

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages