##// END OF EJS Templates
Closed
Pull request !2275 Created on Wed, 13 Feb 2019 21:07:07, by
  • Issue #5536 - ability to disable server-side SSH key generation
Pull request versions not available.
ver Time Author Commit Description
latest r3208:7d47a18b6391
Issue #5536 - another template typo
v2 r3207:55f6d5276de9
Issue #5536 - template typo. also make variable names more explicit
v1 r3206:c02cc55651b4
Issue #5536 - ability to disable server-side SSH key generation

No files

This file was removed from diff during updates to this pull-request.
There are still outdated/unresolved comments attached to it.
author

I did have that fixed on the live template. I just didn't sync it.

This file was removed from diff during updates to this pull-request.
There are still outdated/unresolved comments attached to it.
note

+1 for spelling fix ;)

author

fixed in r3207

General Comments 23
Under Review
author

Auto status change to "Under Review"

note
author

Changed one (untranslated) string, added one new string.
I'm writing against a running test instance. Did not touch translations folder.

note

Let me change the CI config so it sends the test results in a comment.

note
author

I meant to write

Changed two (untranslated) strings, added one new string.

Rejected

[PR tests] Build Failed on : build-log

Approved

CLA FOUND and APPROVED

note
author

I'm not clear on how the build log from the CI jenkins bot should work. I'm guessing you're still working on that.

note

There's a failing test, let me fix Jenkins to show the output.

Rejected

[PR tests] Build Failed on : build-log

Approved

CLA FOUND and APPROVED

note
author

This is entirely text editor based right now. I'll be in a much better position to test things with #5534 in place :)

Rejected

[PR tests] Build Failed: build-log

note
author

@marcink pretty sure@jenkins-tests posted the wrong build log. it's the same log as last time.

note

Yes, sorry about that. We did lots of Jenkins Changes receantly, and seems there are hickups!

Let me investigate.

Under Review
author

Pull request updated. Auto status change to "Under Review"

Changed commits:
  * 1 added
  * 0 removed

Changed files:
  * M rhodecode/templates/admin/users/user_edit_ssh_keys_generate.mako
Approved

CLA FOUND and APPROVED

note
author

So I'm going to make a small complaint about the fact that the public repository is missing the 4.15 branch and my test instance is up-to-date. This makes syncing things less than straight forward. Also, for some reason it looked to me like both build bot posts pointed to the same file. Looks ok now.

note

Yeah, i'd realized that now that infact 4.15 is not pushed to the public instance... This should be done automatically.
I'll make sure we re-sync the codebase today.

Approved

Build Succeeded!

Approved

Thank you for this contribution. This looks ok, i'll merge this manually on top of our current default develop branch.

Approved

Closing with status change > Approved.