# HG changeset patch # User Marcin Kuzminski # Date 2019-07-29 12:39:55 # Node ID 6e82d8074b0c7e3af95d1e1dea4a6d107c7f964f # Parent 9da6203b6d8ce7d3b558672ec1289d3de2e56af4 git: ensure diffs don't return None diff --git a/vcsserver/git.py b/vcsserver/git.py --- a/vcsserver/git.py +++ b/vcsserver/git.py @@ -988,14 +988,15 @@ class GitRemote(RemoteBase): comm2 = repo[commit_id_1] diff_obj = comm1.tree.diff_to_tree( comm2.tree, flags=flags, context_lines=context, swap=swap) - - diff_obj.find_similar(flags=pygit2.GIT_DIFF_FIND_RENAMES) + similar_flags = 0 + similar_flags |= pygit2.GIT_DIFF_FIND_RENAMES + diff_obj.find_similar(flags=similar_flags) if file_filter: for p in diff_obj: if p.delta.old_file.path == file_filter: - return p.patch - return diff_obj.patch + return p.patch or '' + return diff_obj.patch or '' @reraise_safe_exceptions def node_history(self, wire, commit_id, path, limit):