# HG changeset patch
# User Marcin Kuzminski <marcin@rhodecode.com>
# Date 2019-07-12 15:29:19
# Node ID ef69988e7edaf3536a375b3157c31d8b9e7238a0
# Parent  f9bf1351641787208c6b6ad8bc423aea03199c6e

libgit2: updated code for tests.

- listing all commits will use only subprocess as it will return empty list for empty repos
- updated logic for empty repos so it's the best combination of speed and correctness

diff --git a/vcsserver/git.py b/vcsserver/git.py
--- a/vcsserver/git.py
+++ b/vcsserver/git.py
@@ -161,9 +161,16 @@ class GitRemote(object):
         repo = self._factory.repo_libgit2(wire)
 
         try:
-            return not repo.head.name
+            has_head = repo.head.name
+            if has_head:
+                return False
+
+            # NOTE(marcink): check again using more expensive method
+            return repo.is_empty
         except Exception:
-            return True
+            pass
+
+        return True
 
     @reraise_safe_exceptions
     def add_object(self, wire, content):
@@ -783,8 +790,6 @@ class GitRemote(object):
 
     @reraise_safe_exceptions
     def get_all_commit_ids(self, wire):
-        if self.is_empty(wire):
-            return []
 
         cmd = ['rev-list', '--reverse', '--date-order', '--branches', '--tags']
         try: