# HG changeset patch
# User neko259 <neko259@gmail.com>
# Date 2015-03-18 16:50:57
# Node ID 4008735b1005a2d0e9ee64720335b847ebab8be5
# Parent  c71f42683a5d307b62e41d57b628253e3c874f05

Don't use JS and links in tag buttons. Use <button> instead

diff --git a/boards/static/css/base.css b/boards/static/css/base.css
--- a/boards/static/css/base.css
+++ b/boards/static/css/base.css
@@ -84,8 +84,10 @@ textarea, input {
     display: inline;
 }
 
-.post-button-form > input[type="submit"] {
+.post-button-form > button {
     border: none;
-    margin: 0;
-    padding: 0;
+    margin: inherit;
+    padding: inherit;
+    background: none;
+    font-size: inherit;
 }
diff --git a/boards/static/css/md/base_page.css b/boards/static/css/md/base_page.css
--- a/boards/static/css/md/base_page.css
+++ b/boards/static/css/md/base_page.css
@@ -509,3 +509,7 @@ ul {
 .highlight {
     background-color: #222;
 }
+
+.post-button-form > button:hover {
+    text-decoration: underline;
+}
diff --git a/boards/static/css/sw/base_page.css b/boards/static/css/sw/base_page.css
--- a/boards/static/css/sw/base_page.css
+++ b/boards/static/css/sw/base_page.css
@@ -397,3 +397,7 @@ li {
 .highlight {
     background-color: #D4F0F9;
 }
+
+.dead_post {
+    border-right: 1ex solid #666;
+}
diff --git a/boards/static/js/main.js b/boards/static/js/main.js
--- a/boards/static/js/main.js
+++ b/boards/static/js/main.js
@@ -81,21 +81,6 @@ function translate_time(node) {
     });
 }
 
-/**
- * We use buttons viewed as a form with link and hidden inputs to ensure
- * the search crawlers don't index or click them.
- *
- * But we need to submit the form by clicking the links. That's why these
- * handlers are here.
- */
-function addPostButtonActions() {
-    $('.post-button-form > a').each(function() {
-        $(this).click(function() {
-            $(this).parent().submit();
-        });
-    });
-}
-
 $( document ).ready(function() {
     hideEmailFromForm();
 
@@ -111,6 +96,4 @@ function addPostButtonActions() {
     highlightCode($(document));
 
     translate_time(null);
-
-    addPostButtonActions();
 });
diff --git a/boards/templates/boards/posting_general.html b/boards/templates/boards/posting_general.html
--- a/boards/templates/boards/posting_general.html
+++ b/boards/templates/boards/posting_general.html
@@ -41,22 +41,17 @@
     <div class="tag_info">
         <h2>
             <form action="{% url 'tag' tag.name %}" method="post" class="post-button-form">
-                <input type="hidden" name="method"
                 {% if is_favorite %}
-                    <input type="hidden" name="method" value="unsubscribe" />
-                    <a class="fav" href="#">★</a>
+                    <button name="method" value="unsubscribe" class="fav">★</button>
                 {% else %}
-                    <input type="hidden" name="method" value="subscribe" />
-                    <a class="not_fav" href="#">★</a>
+                    <button name="method" value="subscribe" class="not_fav">★</button>
                 {% endif %}
             </form>
             <form action="{% url 'tag' tag.name %}" method="post" class="post-button-form">
                 {% if is_hidden %}
-                    <input type="hidden" name="method" value="unhide" />
-                    <a class="fav" href="#">H</a>
+                    <button name="method" value="unhide" class="fav">H</button>
                 {% else %}
-                    <input type="hidden" name="method" value="hide" />
-                    <a class="not_fav" href="#">H</a>
+                    <button name="method" value="hide" class="not_fav">H</button>
                 {% endif %}
             </form>
             {% autoescape off %}