Divided settings manager into base settings manager class and session-based settings manager. This allowes to add other backends to the settings manager

boards/abstracts/settingsmanager.py

@@ -1,114 +1,143 b''
 from django.shortcuts import get_object_or_404
 from boards.models import Tag
 
 __author__ = 'neko259'
 
 SESSION_SETTING = 'setting'
 
 PERMISSION_MODERATE = 'moderator'
 
 SETTING_THEME = 'theme'
 SETTING_FAVORITE_TAGS = 'favorite_tags'
 SETTING_HIDDEN_TAGS = 'hidden_tags'
 SETTING_PERMISSIONS = 'permissions'
 
 DEFAULT_THEME = 'md'
 
 
-class SettingsManager:
+def get_settings_manager(request):
+    """
+    Get settings manager based on the request object. Currently only
+    session-based manager is supported. In the future, cookie-based or
+    database-based managers could be implemented.
+    """
+    return SessionSettingsManager(request.session)
 
-    def __init__(self, session):
-        self.session = session
+
+class SettingsManager:
+    """
+    Base settings manager class. get_setting and set_setting methods should
+    be overriden.
+    """
+    def __init__(self):
+        pass
 
     def get_theme(self):
         theme = self.get_setting(SETTING_THEME)
         if not theme:
             theme = DEFAULT_THEME
             self.set_setting(SETTING_THEME, theme)
 
         return theme
 
     def set_theme(self, theme):
         self.set_setting(SETTING_THEME, theme)
 
     def has_permission(self, permission):
         permissions = self.get_setting(SETTING_PERMISSIONS)
         if permissions:
             return permission in permissions
         else:
             return False
 
     def get_setting(self, setting):
-        if setting in self.session:
-            return self.session[setting]
-        else:
-            return None
+        pass
 
     def set_setting(self, setting, value):
-        self.session[setting] = value
+        pass
 
     def add_permission(self, permission):
         permissions = self.get_setting(SETTING_PERMISSIONS)
         if not permissions:
             permissions = [permission]
         else:
             permissions.append(permission)
         self.set_setting(SETTING_PERMISSIONS, permissions)
 
     def del_permission(self, permission):
         permissions = self.get_setting(SETTING_PERMISSIONS)
         if not permissions:
             permissions = []
         else:
             permissions.remove(permission)
         self.set_setting(SETTING_PERMISSIONS, permissions)
 
     def get_fav_tags(self):
         tag_names = self.get_setting(SETTING_FAVORITE_TAGS)
         tags = []
         if tag_names:
             for tag_name in tag_names:
                 tag = get_object_or_404(Tag, name=tag_name)
                 tags.append(tag)
 
         return tags
 
     def add_fav_tag(self, tag):
         tags = self.get_setting(SETTING_FAVORITE_TAGS)
         if not tags:
             tags = [tag.name]
         else:
             if not tag.name in tags:
                 tags.append(tag.name)
         self.set_setting(SETTING_FAVORITE_TAGS, tags)
 
     def del_fav_tag(self, tag):
         tags = self.get_setting(SETTING_FAVORITE_TAGS)
         if tag.name in tags:
             tags.remove(tag.name)
             self.set_setting(SETTING_FAVORITE_TAGS, tags)
 
     def get_hidden_tags(self):
         tag_names = self.get_setting(SETTING_HIDDEN_TAGS)
         tags = []
         if tag_names:
             for tag_name in tag_names:
                 tag = get_object_or_404(Tag, name=tag_name)
                 tags.append(tag)
 
         return tags
 
     def add_hidden_tag(self, tag):
         tags = self.get_setting(SETTING_HIDDEN_TAGS)
         if not tags:
             tags = [tag.name]
         else:
             if not tag.name in tags:
                 tags.append(tag.name)
         self.set_setting(SETTING_HIDDEN_TAGS, tags)
 
     def del_hidden_tag(self, tag):
         tags = self.get_setting(SETTING_HIDDEN_TAGS)
         if tag.name in tags:
             tags.remove(tag.name)
             self.set_setting(SETTING_HIDDEN_TAGS, tags)
+
+
+class SessionSettingsManager(SettingsManager):
+    """
+    Session-based settings manager. All settings are saved to the user's
+    session.
+    """
+    def __init__(self, session):
+        SettingsManager.__init__(self)
+        self.session = session
+
+    def get_setting(self, setting):
+        if setting in self.session:
+            return self.session[setting]
+        else:
+            return None
+
+    def set_setting(self, setting, value):
+        self.session[setting] = value
+

boards/context_processors.py

@@ -1,37 +1,37 b''
-from boards.abstracts.settingsmanager import SettingsManager, \
-    PERMISSION_MODERATE
+from boards.abstracts.settingsmanager import PERMISSION_MODERATE, \
+    get_settings_manager
 
 __author__ = 'neko259'
 
 from boards import settings
 from boards.models import Post
 
 CONTEXT_SITE_NAME = 'site_name'
 CONTEXT_VERSION = 'version'
 CONTEXT_MODERATOR = 'moderator'
 CONTEXT_THEME_CSS = 'theme_css'
 CONTEXT_THEME = 'theme'
 CONTEXT_PPD = 'posts_per_day'
 CONTEXT_TAGS = 'tags'
 CONTEXT_USER = 'user'
 
 
 def user_and_ui_processor(request):
     context = {}
 
     context[CONTEXT_PPD] = float(Post.objects.get_posts_per_day())
 
-    settings_manager = SettingsManager(request.session)
+    settings_manager = get_settings_manager(request)
     context[CONTEXT_TAGS] = settings_manager.get_fav_tags()
     theme = settings_manager.get_theme()
     context[CONTEXT_THEME] = theme
     context[CONTEXT_THEME_CSS] = 'css/' + theme + '/base_page.css'
 
     # This shows the moderator panel
     moderate = settings_manager.has_permission(PERMISSION_MODERATE)
     context[CONTEXT_MODERATOR] = moderate
 
     context[CONTEXT_VERSION] = settings.VERSION
     context[CONTEXT_SITE_NAME] = settings.SITE_NAME
 
     return context
  No newline at end of file

boards/tests.py

@@ -1,259 +1,275 b''
 # coding=utf-8
 import time
 import logging
 from django.core.paginator import Paginator
 
 from django.test import TestCase
 from django.test.client import Client
 from django.core.urlresolvers import reverse, NoReverseMatch
+from boards.abstracts.settingsmanager import get_settings_manager
 
 from boards.models import Post, Tag, Thread
 from boards import urls
 from boards import settings
 import neboard
 
 PAGE_404 = 'boards/404.html'
 
 TEST_TEXT = 'test text'
 
 NEW_THREAD_PAGE = '/'
 THREAD_PAGE_ONE = '/thread/1/'
 THREAD_PAGE = '/thread/'
 TAG_PAGE = '/tag/'
 HTTP_CODE_REDIRECT = 302
 HTTP_CODE_OK = 200
 HTTP_CODE_NOT_FOUND = 404
 
 logger = logging.getLogger(__name__)
 
 
 class PostTests(TestCase):
 
     def _create_post(self):
         return Post.objects.create_post(title='title', text='text')
 
     def test_post_add(self):
         """Test adding post"""
 
         post = self._create_post()
 
         self.assertIsNotNone(post, 'No post was created')
 
     def test_delete_post(self):
         """Test post deletion"""
 
         post = self._create_post()
         post_id = post.id
 
         Post.objects.delete_post(post)
 
         self.assertFalse(Post.objects.filter(id=post_id).exists())
 
     def test_delete_thread(self):
         """Test thread deletion"""
 
         opening_post = self._create_post()
         thread = opening_post.get_thread()
         reply = Post.objects.create_post("", "", thread=thread)
 
         thread.delete()
 
         self.assertFalse(Post.objects.filter(id=reply.id).exists())
 
     def test_post_to_thread(self):
         """Test adding post to a thread"""
 
         op = self._create_post()
         post = Post.objects.create_post("", "", thread=op.get_thread())
 
         self.assertIsNotNone(post, 'Reply to thread wasn\'t created')
         self.assertEqual(op.get_thread().last_edit_time, post.pub_time,
                          'Post\'s create time doesn\'t match thread last edit'
                          ' time')
 
     def test_delete_posts_by_ip(self):
         """Test deleting posts with the given ip"""
 
         post = self._create_post()
         post_id = post.id
 
         Post.objects.delete_posts_by_ip('0.0.0.0')
 
         self.assertFalse(Post.objects.filter(id=post_id).exists())
 
     def test_get_thread(self):
         """Test getting all posts of a thread"""
 
         opening_post = self._create_post()
 
         for i in range(0, 2):
             Post.objects.create_post('title', 'text',
                                      thread=opening_post.get_thread())
 
         thread = opening_post.get_thread()
 
         self.assertEqual(3, thread.replies.count())
 
     def test_create_post_with_tag(self):
         """Test adding tag to post"""
 
         tag = Tag.objects.create(name='test_tag')
         post = Post.objects.create_post(title='title', text='text', tags=[tag])
 
         thread = post.get_thread()
         self.assertIsNotNone(post, 'Post not created')
         self.assertTrue(tag in thread.tags.all(), 'Tag not added to thread')
         self.assertTrue(thread in tag.threads.all(), 'Thread not added to tag')
 
     def test_thread_max_count(self):
         """Test deletion of old posts when the max thread count is reached"""
 
         for i in range(settings.MAX_THREAD_COUNT + 1):
             self._create_post()
 
         self.assertEqual(settings.MAX_THREAD_COUNT,
                          len(Thread.objects.filter(archived=False)))
 
     def test_pages(self):
         """Test that the thread list is properly split into pages"""
 
         for i in range(settings.MAX_THREAD_COUNT):
             self._create_post()
 
         all_threads = Thread.objects.filter(archived=False)
 
         paginator = Paginator(Thread.objects.filter(archived=False),
                               settings.THREADS_PER_PAGE)
         posts_in_second_page = paginator.page(2).object_list
         first_post = posts_in_second_page[0]
 
         self.assertEqual(all_threads[settings.THREADS_PER_PAGE].id,
                          first_post.id)
 
     def test_linked_tag(self):
         """Test adding a linked tag"""
 
         linked_tag = Tag.objects.create(name=u'tag1')
         tag = Tag.objects.create(name=u'tag2', linked=linked_tag)
 
         post = Post.objects.create_post("", "", tags=[tag])
 
         self.assertTrue(linked_tag in post.get_thread().tags.all(),
                         'Linked tag was not added')
 
 
 class PagesTest(TestCase):
 
     def test_404(self):
         """Test receiving error 404 when opening a non-existent page"""
 
         tag_name = u'test_tag'
         tag = Tag.objects.create(name=tag_name)
         client = Client()
 
         Post.objects.create_post('title', TEST_TEXT, tags=[tag])
 
         existing_post_id = Post.objects.all()[0].id
         response_existing = client.get(THREAD_PAGE + str(existing_post_id) +
                                        '/')
         self.assertEqual(HTTP_CODE_OK, response_existing.status_code,
                          u'Cannot open existing thread')
 
         response_not_existing = client.get(THREAD_PAGE + str(
             existing_post_id + 1) + '/')
         self.assertEqual(PAGE_404, response_not_existing.templates[0].name,
                          u'Not existing thread is opened')
 
         response_existing = client.get(TAG_PAGE + tag_name + '/')
         self.assertEqual(HTTP_CODE_OK,
                          response_existing.status_code,
                          u'Cannot open existing tag')
 
         response_not_existing = client.get(TAG_PAGE + u'not_tag' + '/')
         self.assertEqual(PAGE_404,
                          response_not_existing.templates[0].name,
                          u'Not existing tag is opened')
 
         reply_id = Post.objects.create_post('', TEST_TEXT,
                                             thread=Post.objects.all()[0]
                                             .get_thread())
         response_not_existing = client.get(THREAD_PAGE + str(
             reply_id) + '/')
         self.assertEqual(PAGE_404,
                          response_not_existing.templates[0].name,
                          u'Reply is opened as a thread')
 
 
 class FormTest(TestCase):
     def test_post_validation(self):
         # Disable captcha for the test
         captcha_enabled = neboard.settings.ENABLE_CAPTCHA
         neboard.settings.ENABLE_CAPTCHA = False
 
         client = Client()
 
         valid_tags = u'tag1 tag_2 тег_3'
         invalid_tags = u'$%_356 ---'
 
         response = client.post(NEW_THREAD_PAGE, {'title': 'test title',
                                                  'text': TEST_TEXT,
                                                  'tags': valid_tags})
         self.assertEqual(response.status_code, HTTP_CODE_REDIRECT,
                          msg='Posting new message failed: got code ' +
                              str(response.status_code))
 
         self.assertEqual(1, Post.objects.count(),
                          msg='No posts were created')
 
         client.post(NEW_THREAD_PAGE, {'text': TEST_TEXT,
                                       'tags': invalid_tags})
         self.assertEqual(1, Post.objects.count(), msg='The validation passed '
                                                       'where it should fail')
 
         # Change posting delay so we don't have to wait for 30 seconds or more
         old_posting_delay = neboard.settings.POSTING_DELAY
         # Wait fot the posting delay or we won't be able to post
         settings.POSTING_DELAY = 1
         time.sleep(neboard.settings.POSTING_DELAY + 1)
         response = client.post(THREAD_PAGE_ONE, {'text': TEST_TEXT,
                                                  'tags': valid_tags})
         self.assertEqual(HTTP_CODE_REDIRECT, response.status_code,
                          msg=u'Posting new message failed: got code ' +
                              str(response.status_code))
         # Restore posting delay
         settings.POSTING_DELAY = old_posting_delay
 
         self.assertEqual(2, Post.objects.count(),
                          msg=u'No posts were created')
 
         # Restore captcha setting
         settings.ENABLE_CAPTCHA = captcha_enabled
 
 
 class ViewTest(TestCase):
 
     def test_all_views(self):
-        '''
+        """
         Try opening all views defined in ulrs.py that don't need additional
         parameters
-        '''
+        """
 
         client = Client()
         for url in urls.urlpatterns:
             try:
                 view_name = url.name
                 logger.debug('Testing view %s' % view_name)
 
                 try:
                     response = client.get(reverse(view_name))
 
                     self.assertEqual(HTTP_CODE_OK, response.status_code,
-                            '%s view not opened' % view_name)
+                                     '%s view not opened' % view_name)
                 except NoReverseMatch:
                     # This view just needs additional arguments
                     pass
                 except Exception, e:
                     self.fail('Got exception %s at %s view' % (e, view_name))
             except AttributeError:
                 # This is normal, some views do not have names
                 pass
+
+
+class AbstractTest(TestCase):
+    def test_settings_manager(self):
+        request = MockRequest()
+        settings_manager = get_settings_manager(request)
+
+        settings_manager.set_setting('test_setting', 'test_value')
+        self.assertEqual('test_value', settings_manager.get_setting(
+            'test_setting'), u'Setting update failed.')
+
+
+class MockRequest:
+    def __init__(self):
+        self.session = dict()
  No newline at end of file

boards/views/all_threads.py

@@ -1,139 +1,139 b''
 import string
 
 from django.db import transaction
 from django.shortcuts import render, redirect
 
 from boards import utils, settings
 from boards.abstracts.paginator import get_paginator
-from boards.abstracts.settingsmanager import SettingsManager
+from boards.abstracts.settingsmanager import get_settings_manager
 from boards.forms import ThreadForm, PlainErrorList
 from boards.models import Post, Thread, Ban, Tag
 from boards.views.banned import BannedView
 from boards.views.base import BaseBoardView, CONTEXT_FORM
 from boards.views.posting_mixin import PostMixin
 
 FORM_TAGS = 'tags'
 FORM_TEXT = 'text'
 FORM_TITLE = 'title'
 FORM_IMAGE = 'image'
 
 TAG_DELIMITER = ' '
 
 PARAMETER_CURRENT_PAGE = 'current_page'
 PARAMETER_PAGINATOR = 'paginator'
 PARAMETER_THREADS = 'threads'
 
 TEMPLATE = 'boards/posting_general.html'
 DEFAULT_PAGE = 1
 
 
 class AllThreadsView(PostMixin, BaseBoardView):
 
     def __init__(self):
         self.settings_manager = None
         super(AllThreadsView, self).__init__()
 
     def get(self, request, page=DEFAULT_PAGE, form=None):
         context = self.get_context_data(request=request)
 
         if not form:
             form = ThreadForm(error_class=PlainErrorList)
 
-        self.settings_manager = SettingsManager(request.session)
+        self.settings_manager = get_settings_manager(request)
         paginator = get_paginator(self.get_threads(),
                                   settings.THREADS_PER_PAGE)
         paginator.current_page = int(page)
 
         threads = paginator.page(page).object_list
 
         context[PARAMETER_THREADS] = threads
         context[CONTEXT_FORM] = form
 
         self._get_page_context(paginator, context, page)
 
         return render(request, TEMPLATE, context)
 
     def post(self, request, page=DEFAULT_PAGE):
         form = ThreadForm(request.POST, request.FILES,
                           error_class=PlainErrorList)
         form.session = request.session
 
         if form.is_valid():
             return self.create_thread(request, form)
         if form.need_to_ban:
             # Ban user because he is suspected to be a bot
             self._ban_current_user(request)
 
         return self.get(request, page, form)
 
     @staticmethod
     def _get_page_context(paginator, context, page):
         """
         Get pagination context variables
         """
 
         context[PARAMETER_PAGINATOR] = paginator
         context[PARAMETER_CURRENT_PAGE] = paginator.page(int(page))
 
     @staticmethod
     def parse_tags_string(tag_strings):
         """
         Parses tag list string and returns tag object list.
         """
 
         tags = []
 
         if tag_strings:
             tag_strings = tag_strings.split(TAG_DELIMITER)
             for tag_name in tag_strings:
                 tag_name = string.lower(tag_name.strip())
                 if len(tag_name) > 0:
                     tag, created = Tag.objects.get_or_create(name=tag_name)
                     tags.append(tag)
 
         return tags
 
     @transaction.atomic
     def create_thread(self, request, form, html_response=True):
         """
         Creates a new thread with an opening post.
         """
 
         ip = utils.get_client_ip(request)
         is_banned = Ban.objects.filter(ip=ip).exists()
 
         if is_banned:
             if html_response:
                 return redirect(BannedView().as_view())
             else:
                 return
 
         data = form.cleaned_data
 
         title = data[FORM_TITLE]
         text = data[FORM_TEXT]
 
         text = self._remove_invalid_links(text)
 
         if FORM_IMAGE in data.keys():
             image = data[FORM_IMAGE]
         else:
             image = None
 
         tag_strings = data[FORM_TAGS]
 
         tags = self.parse_tags_string(tag_strings)
 
         post = Post.objects.create_post(title=title, text=text, image=image,
                                         ip=ip, tags=tags)
 
         if html_response:
             return redirect(post.get_url())
 
     def get_threads(self):
         """
         Gets list of threads that will be shown on a page.
         """
 
         return Thread.objects.all().order_by('-bump_time')\
             .exclude(tags__in=self.settings_manager.get_hidden_tags())

boards/views/ban.py

@@ -1,26 +1,26 b''
 from django.db import transaction
 from django.shortcuts import get_object_or_404
 
-from boards.abstracts.settingsmanager import SettingsManager, \
-    PERMISSION_MODERATE
+from boards.abstracts.settingsmanager import PERMISSION_MODERATE, \
+    get_settings_manager
 from boards.views.base import BaseBoardView
 from boards.models import Post, Ban
 from boards.views.mixins import RedirectNextMixin
 
 
 class BanUserView(BaseBoardView, RedirectNextMixin):
 
     @transaction.atomic
     def get(self, request, post_id):
         post = get_object_or_404(Post, id=post_id)
 
-        settings_manager = SettingsManager(request.session)
+        settings_manager = get_settings_manager(request)
 
         if settings_manager.has_permission(PERMISSION_MODERATE):
             # TODO Show confirmation page before ban
             ban, created = Ban.objects.get_or_create(ip=post.poster_ip)
             if created:
                 ban.reason = 'Banned for post ' + str(post_id)
                 ban.save()
 
         return self.redirect_to_next(request)

boards/views/delete_post.py

@@ -1,28 +1,28 b''
 from django.shortcuts import redirect, get_object_or_404
 from django.db import transaction
 
-from boards.abstracts.settingsmanager import SettingsManager, \
-    PERMISSION_MODERATE
+from boards.abstracts.settingsmanager import PERMISSION_MODERATE,\
+    get_settings_manager
 from boards.views.base import BaseBoardView
 from boards.views.mixins import RedirectNextMixin
 from boards.models import Post
 
 
 class DeletePostView(BaseBoardView, RedirectNextMixin):
 
     @transaction.atomic
     def get(self, request, post_id):
         post = get_object_or_404(Post, id=post_id)
 
         opening_post = post.is_opening()
 
-        settings_manager = SettingsManager(request.session)
+        settings_manager = get_settings_manager(request)
         if settings_manager.has_permission(PERMISSION_MODERATE):
             # TODO Show confirmation page before deletion
             Post.objects.delete_post(post)
 
         if not opening_post:
             thread = post.thread_new
             return redirect('thread', post_id=thread.get_opening_post().id)
         else:
             return self.redirect_to_next(request)

boards/views/login.py

@@ -1,33 +1,33 b''
 from django.shortcuts import render, redirect
 
-from boards.abstracts.settingsmanager import SettingsManager, \
-    PERMISSION_MODERATE
+from boards.abstracts.settingsmanager import PERMISSION_MODERATE, \
+    get_settings_manager
 from boards.forms import LoginForm, PlainErrorList
 from boards.views.base import BaseBoardView, CONTEXT_FORM
 
 
 __author__ = 'neko259'
 
 
 class LoginView(BaseBoardView):
 
     def get(self, request, form=None):
         context = self.get_context_data(request=request)
 
         if not form:
             form = LoginForm()
         context[CONTEXT_FORM] = form
 
         return render(request, 'boards/login.html', context)
 
     def post(self, request):
         form = LoginForm(request.POST, request.FILES,
                          error_class=PlainErrorList)
         form.session = request.session
 
         if form.is_valid():
-            settings_manager = SettingsManager(request.session)
+            settings_manager = get_settings_manager(request)
             settings_manager.add_permission(PERMISSION_MODERATE)
             return redirect('index')
         else:
             return self.get(request, form)

boards/views/logout.py

@@ -1,24 +1,24 b''
 from django.shortcuts import render
 
-from boards.abstracts.settingsmanager import SettingsManager, \
-    PERMISSION_MODERATE
+from boards.abstracts.settingsmanager import PERMISSION_MODERATE,\
+    get_settings_manager
 from boards.forms import LoginForm
 from boards.views.base import BaseBoardView, CONTEXT_FORM
 
 
 __author__ = 'neko259'
 
 
 class LogoutView(BaseBoardView):
 
     def get(self, request, form=None):
-        settings_manager = SettingsManager(request.session)
+        settings_manager = get_settings_manager(request)
         settings_manager.del_permission(PERMISSION_MODERATE)
 
         context = self.get_context_data(request=request)
 
         if not form:
             form = LoginForm()
         context[CONTEXT_FORM] = form
 
         return render(request, 'boards/login.html', context)
  No newline at end of file

boards/views/post_admin.py

@@ -1,60 +1,60 b''
 from django.shortcuts import render, get_object_or_404, redirect
-from boards.abstracts.settingsmanager import SettingsManager, \
-    PERMISSION_MODERATE
 
+from boards.abstracts.settingsmanager import PERMISSION_MODERATE,\
+    get_settings_manager
 from boards.views.base import BaseBoardView
 from boards.views.mixins import DispatcherMixin
 from boards.models.post import Post
 from boards.models.tag import Tag
 from boards.forms import AddTagForm, PlainErrorList
 
 
 class PostAdminView(BaseBoardView, DispatcherMixin):
 
     def get(self, request, post_id, form=None):
-        settings_manager = SettingsManager(request.session)
+        settings_manager = get_settings_manager(request)
         if not settings_manager.has_permission(PERMISSION_MODERATE):
             redirect('index')
 
         post = get_object_or_404(Post, id=post_id)
 
         if not form:
             dispatch_result = self.dispatch_method(request, post)
             if dispatch_result:
                 return dispatch_result
             form = AddTagForm()
 
         context = self.get_context_data(request=request)
 
         context['post'] = post
 
         context['tag_form'] = form
 
         return render(request, 'boards/post_admin.html', context)
 
     def post(self, request, post_id):
-        settings_manager = SettingsManager(request.session)
+        settings_manager = get_settings_manager(request)
         if not settings_manager.has_permission(PERMISSION_MODERATE):
             redirect('index')
 
         post = get_object_or_404(Post, id=post_id)
         return self.dispatch_method(request, post)
 
     def delete_tag(self, request, post):
         tag_name = request.GET['tag']
         tag = get_object_or_404(Tag, name=tag_name)
 
         post.remove_tag(tag)
 
         return redirect('post_admin', post.id)
 
     def add_tag(self, request, post):
         form = AddTagForm(request.POST, error_class=PlainErrorList)
         if form.is_valid():
             tag_name = form.cleaned_data['tag']
             tag, created = Tag.objects.get_or_create(name=tag_name)
 
             post.add_tag(tag)
             return redirect('post_admin', post.id)
         else:
             return self.get(request, post.id, form)

boards/views/settings.py

@@ -1,35 +1,35 b''
 from django.db import transaction
 from django.shortcuts import render, redirect
-from boards.abstracts.settingsmanager import SettingsManager
 
+from boards.abstracts.settingsmanager import get_settings_manager
 from boards.views.base import BaseBoardView, CONTEXT_FORM
 from boards.forms import SettingsForm, PlainErrorList
 
 
 class SettingsView(BaseBoardView):
 
     def get(self, request):
         context = self.get_context_data(request=request)
-        settings_manager = SettingsManager(request.session)
+        settings_manager = get_settings_manager(request)
 
         selected_theme = settings_manager.get_theme()
 
         form = SettingsForm(initial={'theme': selected_theme},
                             error_class=PlainErrorList)
 
         context[CONTEXT_FORM] = form
 
         return render(request, 'boards/settings.html', context)
 
     def post(self, request):
-        settings_manager = SettingsManager(request.session)
+        settings_manager = get_settings_manager(request)
 
         with transaction.atomic():
             form = SettingsForm(request.POST, error_class=PlainErrorList)
 
             if form.is_valid():
                 selected_theme = form.cleaned_data['theme']
 
                 settings_manager.set_theme(selected_theme)
 
             return redirect('settings')

boards/views/tag_threads.py

@@ -1,91 +1,92 b''
 from django.shortcuts import get_object_or_404
-from boards import utils
-from boards.abstracts.settingsmanager import SettingsManager
-from boards.models import Tag, Post
+
+from boards.abstracts.settingsmanager import get_settings_manager
+from boards.models import Tag
 from boards.views.all_threads import AllThreadsView, DEFAULT_PAGE
 from boards.views.mixins import DispatcherMixin, RedirectNextMixin
 from boards.forms import ThreadForm, PlainErrorList
 
+
 __author__ = 'neko259'
 
 
 class TagView(AllThreadsView, DispatcherMixin, RedirectNextMixin):
 
     tag_name = None
 
     def get_threads(self):
         tag = get_object_or_404(Tag, name=self.tag_name)
 
         return tag.threads.all().order_by('-bump_time')
 
     def get_context_data(self, **kwargs):
         context = super(TagView, self).get_context_data(**kwargs)
 
-        settings_manager = SettingsManager(kwargs['request'].session)
+        settings_manager = get_settings_manager(kwargs['request'])
 
         tag = get_object_or_404(Tag, name=self.tag_name)
         context['tag'] = tag
 
         context['fav_tags'] = settings_manager.get_fav_tags()
         context['hidden_tags'] = settings_manager.get_hidden_tags()
 
         return context
 
     def get(self, request, tag_name, page=DEFAULT_PAGE, form=None):
         self.tag_name = tag_name
 
         dispatch_result = self.dispatch_method(request)
         if dispatch_result:
             return dispatch_result
         else:
             return super(TagView, self).get(request, page, form)
 
     def post(self, request, tag_name, page=DEFAULT_PAGE):
         form = ThreadForm(request.POST, request.FILES,
                           error_class=PlainErrorList)
         form.session = request.session
 
         if form.is_valid():
             return self.create_thread(request, form)
         if form.need_to_ban:
             # Ban user because he is suspected to be a bot
             self._ban_current_user(request)
 
         return self.get(request, tag_name, page, form)
 
     def subscribe(self, request):
         tag = get_object_or_404(Tag, name=self.tag_name)
 
-        settings_manager = SettingsManager(request.session)
+        settings_manager = get_settings_manager(request)
         settings_manager.add_fav_tag(tag)
 
         return self.redirect_to_next(request)
 
     def unsubscribe(self, request):
         tag = get_object_or_404(Tag, name=self.tag_name)
 
-        settings_manager = SettingsManager(request.session)
+        settings_manager = get_settings_manager(request)
         settings_manager.del_fav_tag(tag)
 
         return self.redirect_to_next(request)
 
     def hide(self, request):
         """
         Adds tag to user's hidden tags. Threads with this tag will not be
         shown.
         """
 
         tag = get_object_or_404(Tag, name=self.tag_name)
 
-        settings_manager = SettingsManager(request.session)
+        settings_manager = get_settings_manager(request)
         settings_manager.add_hidden_tag(tag)
 
     def unhide(self, request):
         """
         Removed tag from user's hidden tags.
         """
 
         tag = get_object_or_404(Tag, name=self.tag_name)
 
-        settings_manager = SettingsManager(request.session)
+        settings_manager = get_settings_manager(request)
         settings_manager.del_hidden_tag(tag)