##// END OF EJS Templates
vcs: Minimal change to expose the shadow repository...
vcs: Minimal change to expose the shadow repository Based on my original research, this was the "minimal" starting point. It shows that three concepts are needed for the "repo_name": * From the security standpoint we think of the shadow repository having the same ACL as the target repository of the pull request. This is because the pull request itself is considered to be a part of the target repository. Out of this thought, the variable "acl_repo_name" is used whenever we want to check permissions or when we need the database configuration of the repository. An alternative name would have been "db_repo_name", but the usage for ACL checking is the most important one. * From the web interaction perspective, we need the URL which was originally used to get to the repository. This is because based on this base URL commands can be identified. Especially for Git this is important, so that the commands are correctly recognized. Since the URL is in the focus, this is called "url_repo_name". * Finally we have to deal with the repository on the file system. This is what the VCS layer deal with normally, so this name is called "vcs_repo_name". The original repository interaction is a special case where all three names are the same. When interacting with a pull request, these three names are typically all different. This change is minimal in a sense that it just makes the interaction with a shadow repository barely work, without checking any special constraints yet. This was the starting point for further work on this topic.

File last commit:

r749:19af1ba9 default
r887:175782be default
Show More
settings_labs.html
58 lines | 2.3 KiB | text/html | HtmlLexer
project: added all source files and assets
r1 <div class="panel panel-default">
<div class="panel-heading">
<h3 class="panel-title">${_('Labs Settings')}</h3>
</div>
<div class="panel-body">
${h.secure_form(url('admin_settings_labs'), method='post')}
<div class="form">
<div class="fields">
labs: show a text that there are no active labs settings
r749 % if not c.lab_settings:
${_('There are no Labs settings currently')}
% else:
% for lab_setting in c.lab_settings:
<div class="field">
<div class="label">
<label>${lab_setting.group}:</label>
project: added all source files and assets
r1 </div>
labs: show a text that there are no active labs settings
r749 % if lab_setting.type == 'bool':
<div class="checkboxes">
<div class="checkbox">
${h.checkbox(lab_setting.key, 'True')}
% if lab_setting.label:
<label for="${lab_setting.key}">${lab_setting.label}</label>
% endif
</div>
% if lab_setting.help:
<p class="help-block">${lab_setting.help}</p>
% endif
</div>
% else:
<div class="input">
${h.text(lab_setting.key, size=60)}
## TODO: johbo: This style does not yet exist for our forms,
## the lab settings seem not to adhere to the structure which
## we use in other places.
% if lab_setting.label:
<label for="${lab_setting.key}">${lab_setting.label}</label>
% endif
% if lab_setting.help:
<p class="help-block">${lab_setting.help}</p>
% endif
</div>
project: added all source files and assets
r1 % endif
</div>
labs: show a text that there are no active labs settings
r749 % endfor
<div class="buttons">
${h.submit('save', _('Save settings'), class_='btn')}
${h.reset('reset', _('Reset'), class_='btn')}
project: added all source files and assets
r1 </div>
labs: show a text that there are no active labs settings
r749 % endif
project: added all source files and assets
r1 </div>
</div>
${h.end_form()}
</div>
</div>