##// END OF EJS Templates
vcs: Minimal change to expose the shadow repository...
vcs: Minimal change to expose the shadow repository Based on my original research, this was the "minimal" starting point. It shows that three concepts are needed for the "repo_name": * From the security standpoint we think of the shadow repository having the same ACL as the target repository of the pull request. This is because the pull request itself is considered to be a part of the target repository. Out of this thought, the variable "acl_repo_name" is used whenever we want to check permissions or when we need the database configuration of the repository. An alternative name would have been "db_repo_name", but the usage for ACL checking is the most important one. * From the web interaction perspective, we need the URL which was originally used to get to the repository. This is because based on this base URL commands can be identified. Especially for Git this is important, so that the commands are correctly recognized. Since the URL is in the focus, this is called "url_repo_name". * Finally we have to deal with the repository on the file system. This is what the VCS layer deal with normally, so this name is called "vcs_repo_name". The original repository interaction is a special case where all three names are the same. When interacting with a pull request, these three names are typically all different. This change is minimal in a sense that it just makes the interaction with a shadow repository barely work, without checking any special constraints yet. This was the starting point for further work on this topic.

File last commit:

r411:df8dc98d default
r887:175782be default
Show More
test_repo.py
116 lines | 3.9 KiB | text/x-python | PythonLexer
dan
events: add event system for RepoEvents
r375 # -*- coding: utf-8 -*-
# Copyright (C) 2010-2016 RhodeCode GmbH
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License, version 3
# (only), as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# This program is dual-licensed. If you wish to learn more about the
# RhodeCode Enterprise Edition, including its added features, Support services,
# and proprietary license terms, please see https://rhodecode.com/licenses/
import pytest
dan
events: use context manager for testing fired events
r376 from rhodecode.tests.events.conftest import EventCatcher
dan
events: add event system for RepoEvents
r375
from rhodecode.lib import hooks_base, utils2
from rhodecode.model.repo import RepoModel
from rhodecode.events.repo import (
RepoPrePullEvent, RepoPullEvent,
RepoPrePushEvent, RepoPushEvent,
dan
integrations: add integration support...
r411 RepoPreCreateEvent, RepoCreateEvent,
RepoPreDeleteEvent, RepoDeleteEvent,
dan
events: add event system for RepoEvents
r375 )
@pytest.fixture
def scm_extras(user_regular, repo_stub):
extras = utils2.AttributeDict({
'ip': '127.0.0.1',
'username': user_regular.username,
'action': '',
'repository': repo_stub.repo_name,
'scm': repo_stub.scm_instance().alias,
'config': '',
'server_url': 'http://example.com',
'make_lock': None,
'locked_by': [None],
'commit_ids': ['a' * 40] * 3,
})
return extras
dan
events: fix bugs with serialization of repo/pr events and add tests for those cases
r389 # TODO: dan: make the serialization tests complete json comparisons
@pytest.mark.parametrize('EventClass', [
dan
integrations: add integration support...
r411 RepoPreCreateEvent, RepoCreateEvent,
RepoPreDeleteEvent, RepoDeleteEvent,
dan
events: fix bugs with serialization of repo/pr events and add tests for those cases
r389 ])
def test_repo_events_serialized(repo_stub, EventClass):
event = EventClass(repo_stub)
data = event.as_dict()
assert data['name'] == EventClass.name
assert data['repo']['repo_name'] == repo_stub.repo_name
dan
events: fix bug, 'url' was not in dict
r392 assert data['repo']['url']
dan
events: fix bugs with serialization of repo/pr events and add tests for those cases
r389
@pytest.mark.parametrize('EventClass', [
RepoPrePullEvent, RepoPullEvent, RepoPrePushEvent
])
def test_vcs_repo_events_serialize(repo_stub, scm_extras, EventClass):
event = EventClass(repo_name=repo_stub.repo_name, extras=scm_extras)
data = event.as_dict()
assert data['name'] == EventClass.name
assert data['repo']['repo_name'] == repo_stub.repo_name
dan
events: fix bug, 'url' was not in dict
r392 assert data['repo']['url']
dan
events: fix bugs with serialization of repo/pr events and add tests for those cases
r389
@pytest.mark.parametrize('EventClass', [RepoPushEvent])
dan
events: fix bug, 'url' was not in dict
r392 def test_vcs_repo_push_event_serialize(repo_stub, scm_extras, EventClass):
dan
events: fix bugs with serialization of repo/pr events and add tests for those cases
r389 event = EventClass(repo_name=repo_stub.repo_name,
pushed_commit_ids=scm_extras['commit_ids'],
extras=scm_extras)
data = event.as_dict()
assert data['name'] == EventClass.name
assert data['repo']['repo_name'] == repo_stub.repo_name
dan
events: fix bug, 'url' was not in dict
r392 assert data['repo']['url']
dan
events: fix bugs with serialization of repo/pr events and add tests for those cases
r389
dan
events: add event system for RepoEvents
r375 def test_create_delete_repo_fires_events(backend):
dan
events: use context manager for testing fired events
r376 with EventCatcher() as event_catcher:
repo = backend.create_repo()
dan
integrations: add integration support...
r411 assert event_catcher.events_types == [RepoPreCreateEvent, RepoCreateEvent]
dan
events: use context manager for testing fired events
r376
with EventCatcher() as event_catcher:
RepoModel().delete(repo)
dan
integrations: add integration support...
r411 assert event_catcher.events_types == [RepoPreDeleteEvent, RepoDeleteEvent]
dan
events: add event system for RepoEvents
r375
def test_pull_fires_events(scm_extras):
dan
events: use context manager for testing fired events
r376 with EventCatcher() as event_catcher:
hooks_base.pre_push(scm_extras)
dan
events: rename event_type to events_types as it's multiple
r377 assert event_catcher.events_types == [RepoPrePushEvent]
dan
events: use context manager for testing fired events
r376
with EventCatcher() as event_catcher:
hooks_base.post_push(scm_extras)
dan
events: rename event_type to events_types as it's multiple
r377 assert event_catcher.events_types == [RepoPushEvent]
dan
events: add event system for RepoEvents
r375
def test_push_fires_events(scm_extras):
dan
events: use context manager for testing fired events
r376 with EventCatcher() as event_catcher:
hooks_base.pre_pull(scm_extras)
dan
events: rename event_type to events_types as it's multiple
r377 assert event_catcher.events_types == [RepoPrePullEvent]
dan
events: use context manager for testing fired events
r376
with EventCatcher() as event_catcher:
hooks_base.post_pull(scm_extras)
dan
events: rename event_type to events_types as it's multiple
r377 assert event_catcher.events_types == [RepoPullEvent]
dan
events: fix bugs with serialization of repo/pr events and add tests for those cases
r389