##// END OF EJS Templates
goto-switcher: optimized performance and query capabilities....
goto-switcher: optimized performance and query capabilities. - Previous implementation had on significant bug. The use of LIMIT 20 was limiting results BEFORE auth checks. In case of large ammount of similarly named repositories user didn't had access too, the result goto search was empty. This was becuase first 20 items fetched didn't pass permission checks and final auth list was empty. To fix this we now use proper filtering for auth using SQL. It means we first check user allowed repositories, and add this as a filter so end result from database is already to only the accessible repositories.

File last commit:

r2014:b776c5e0 default
r2038:2bdf9d4d default
Show More
test_vcs_settings.py
104 lines | 3.9 KiB | text/x-python | PythonLexer
tests: fixed tests for new repo settings...
r1721 # -*- coding: utf-8 -*-
# Copyright (C) 2010-2017 RhodeCode GmbH
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License, version 3
# (only), as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# This program is dual-licensed. If you wish to learn more about the
# RhodeCode Enterprise Edition, including its added features, Support services,
# and proprietary license terms, please see https://rhodecode.com/licenses/
import mock
import pytest
import rhodecode
tests: fixed few possible cases of detached instance errors.
r1902 from rhodecode.model.db import Repository
tests: fixed tests for new repo settings...
r1721 from rhodecode.model.settings import SettingsModel
from rhodecode.tests.utils import AssertResponse
def route_path(name, params=None, **kwargs):
import urllib
base_url = {
'edit_repo': '/{repo_name}/settings',
repositories: rewrote whole admin section to pyramid....
r2014 'edit_repo_vcs': '/{repo_name}/settings/vcs',
'edit_repo_vcs_update': '/{repo_name}/settings/vcs/update',
tests: fixed tests for new repo settings...
r1721 }[name].format(**kwargs)
if params:
base_url = '{}?{}'.format(base_url, urllib.urlencode(params))
return base_url
@pytest.mark.usefixtures('autologin_user', 'app')
class TestAdminRepoVcsSettings(object):
@pytest.mark.parametrize('setting_name, setting_backends', [
('hg_use_rebase_for_merging', ['hg']),
])
def test_labs_settings_visible_if_enabled(
self, setting_name, setting_backends, backend):
if backend.alias not in setting_backends:
pytest.skip('Setting not available for backend {}'.format(backend))
repositories: rewrote whole admin section to pyramid....
r2014 vcs_settings_url = route_path(
'edit_repo_vcs', repo_name=backend.repo.repo_name)
tests: fixed tests for new repo settings...
r1721
with mock.patch.dict(
rhodecode.CONFIG, {'labs_settings_active': 'true'}):
response = self.app.get(vcs_settings_url)
assertr = AssertResponse(response)
assertr.one_element_exists('#rhodecode_{}'.format(setting_name))
@pytest.mark.parametrize('setting_name, setting_backends', [
('hg_use_rebase_for_merging', ['hg']),
])
def test_update_boolean_settings(
self, csrf_token, setting_name, setting_backends, backend):
if backend.alias not in setting_backends:
pytest.skip('Setting not available for backend {}'.format(backend))
repo = backend.create_repo()
tests: fixed few possible cases of detached instance errors.
r1902 repo_name = repo.repo_name
tests: fixed tests for new repo settings...
r1721
settings_model = SettingsModel(repo=repo)
repositories: rewrote whole admin section to pyramid....
r2014 vcs_settings_url = route_path(
'edit_repo_vcs_update', repo_name=repo_name)
tests: fixed tests for new repo settings...
r1721
self.app.post(
vcs_settings_url,
params={
'inherit_global_settings': False,
'new_svn_branch': 'dummy-value-for-testing',
'new_svn_tag': 'dummy-value-for-testing',
'rhodecode_{}'.format(setting_name): 'true',
'csrf_token': csrf_token,
})
tests: fixed few possible cases of detached instance errors.
r1902 settings_model = SettingsModel(repo=Repository.get_by_repo_name(repo_name))
tests: fixed tests for new repo settings...
r1721 setting = settings_model.get_setting_by_name(setting_name)
assert setting.app_settings_value
self.app.post(
vcs_settings_url,
params={
'inherit_global_settings': False,
'new_svn_branch': 'dummy-value-for-testing',
'new_svn_tag': 'dummy-value-for-testing',
'rhodecode_{}'.format(setting_name): 'false',
'csrf_token': csrf_token,
})
tests: fixed few possible cases of detached instance errors.
r1902 settings_model = SettingsModel(repo=Repository.get_by_repo_name(repo_name))
tests: fixed tests for new repo settings...
r1721 setting = settings_model.get_setting_by_name(setting_name)
assert not setting.app_settings_value