##// END OF EJS Templates
goto-switcher: optimized performance and query capabilities....
goto-switcher: optimized performance and query capabilities. - Previous implementation had on significant bug. The use of LIMIT 20 was limiting results BEFORE auth checks. In case of large ammount of similarly named repositories user didn't had access too, the result goto search was empty. This was becuase first 20 items fetched didn't pass permission checks and final auth list was empty. To fix this we now use proper filtering for auth using SQL. It means we first check user allowed repositories, and add this as a filter so end result from database is already to only the accessible repositories.

File last commit:

r1761:8612110c default
r2038:2bdf9d4d default
Show More
test_webhook.py
98 lines | 4.1 KiB | text/x-python | PythonLexer
webhooks: added variables into the call URL. Fixes #4211
r938 # -*- coding: utf-8 -*-
license: updated copyright year to 2017
r1271 # Copyright (C) 2010-2017 RhodeCode GmbH
webhooks: added variables into the call URL. Fixes #4211
r938 #
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License, version 3
# (only), as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# This program is dual-licensed. If you wish to learn more about the
# RhodeCode Enterprise Edition, including its added features, Support services,
# and proprietary license terms, please see https://rhodecode.com/licenses/
import pytest
from rhodecode import events
from rhodecode.lib.utils2 import AttributeDict
from rhodecode.integrations.types.webhook import WebhookHandler
@pytest.fixture
def base_data():
return {
'repo': {
'repo_name': 'foo',
'repo_type': 'hg',
'repo_id': '12',
integrations: expose actor user_id, and username in webhook integration templates args....
r1709 'url': 'http://repo.url/foo',
webhook: enable support of extra repo variables as replacement in template url.
r1761 'extra_fields': {},
integrations: expose actor user_id, and username in webhook integration templates args....
r1709 },
'actor': {
'username': 'actor_name',
'user_id': 1
webhooks: added variables into the call URL. Fixes #4211
r938 }
}
def test_webhook_parse_url_invalid_event():
template_url = 'http://server.com/${repo_name}/build'
handler = WebhookHandler(template_url, 'secret_token')
with pytest.raises(ValueError) as err:
handler(events.RepoDeleteEvent(''), {})
assert str(err.value).startswith('event type not supported')
@pytest.mark.parametrize('template,expected_urls', [
('http://server.com/${repo_name}/build', ['http://server.com/foo/build']),
('http://server.com/${repo_name}/${repo_type}', ['http://server.com/foo/hg']),
('http://${server}.com/${repo_name}/${repo_id}', ['http://${server}.com/foo/12']),
('http://server.com/${branch}/build', ['http://server.com/${branch}/build']),
])
def test_webook_parse_url_for_create_event(base_data, template, expected_urls):
handler = WebhookHandler(template, 'secret_token')
urls = handler(events.RepoCreateEvent(''), base_data)
assert urls == [(url, 'secret_token', base_data) for url in expected_urls]
@pytest.mark.parametrize('template,expected_urls', [
('http://server.com/${repo_name}/${pull_request_id}', ['http://server.com/foo/999']),
('http://server.com/${repo_name}/${pull_request_url}', ['http://server.com/foo/http://pr-url.com']),
])
def test_webook_parse_url_for_pull_request_event(base_data, template, expected_urls):
base_data['pullrequest'] = {
'pull_request_id': 999,
'url': 'http://pr-url.com',
}
handler = WebhookHandler(template, 'secret_token')
urls = handler(events.PullRequestCreateEvent(
AttributeDict({'target_repo': 'foo'})), base_data)
assert urls == [(url, 'secret_token', base_data) for url in expected_urls]
@pytest.mark.parametrize('template,expected_urls', [
('http://server.com/${branch}/build', ['http://server.com/stable/build',
'http://server.com/dev/build']),
('http://server.com/${branch}/${commit_id}', ['http://server.com/stable/stable-xxx',
'http://server.com/stable/stable-yyy',
'http://server.com/dev/dev-xxx',
'http://server.com/dev/dev-yyy']),
])
def test_webook_parse_url_for_push_event(pylonsapp, repo_push_event, base_data, template, expected_urls):
base_data['push'] = {
'branches': [{'name': 'stable'}, {'name': 'dev'}],
'commits': [{'branch': 'stable', 'raw_id': 'stable-xxx'},
{'branch': 'stable', 'raw_id': 'stable-yyy'},
{'branch': 'dev', 'raw_id': 'dev-xxx'},
{'branch': 'dev', 'raw_id': 'dev-yyy'}]
}
handler = WebhookHandler(template, 'secret_token')
urls = handler(repo_push_event, base_data)
assert urls == [(url, 'secret_token', base_data) for url in expected_urls]