u/ewong/rhodecode-enterprise-ce-fork Files · docs/collaboration/approve-pull-request.rst

repos, repo groups, user groups: allow to use disabled users in owner field....

repos, repo groups, user groups: allow to use disabled users in owner field. This fixes . There's no good benefit of having possibility to prevent setting disabled user from beeing an owner. It can happen that we start preperating a system and use disabled accounts. Also users shouldn't be forbidden to edit settings on an disabled owner.

marcink - - Load All Authors

File last commit:

r1:854a839a default


                r224:c6a3436d

default

Download file

             approve-pull-request.rst
        
                    19 lines
            
             | 690 B
            
                | text/x-rst
            
             |
                RstLexer
            
             / docs / collaboration / approve-pull-request.rst
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        marcink
    
project: added all source files and assets

              r1
            
      Approve |prs|

      -------------

      To approve a |pr|, use the following steps:

      1. Select :menuselection:`username --> Notifications --> Pull Requests`

         and open the |pr| you with to approve

      2. Leave your review comments inline, or in the commit message.

      3. Leave a commit message that outlines the review.

      4. Set the review status to :guilabel:`Approved`

      5. Select :guilabel:`Comment`

      If you approve the |pr|, you will be able to merge automatically if |RCM|

      detects that it can do so safely. You will see this message:

      :guilabel:`This pull request can be automatically merged.`

      Otherwise you will need to merge the |pr| locally and push your changes, see

      :ref:`manual-merge-requests-ref`.

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

marcink project: added all source files and assets	r1	Approve \|prs\|
		-------------

		To approve a \|pr\|, use the following steps:

		1. Select :menuselection:`username --> Notifications --> Pull Requests`
		and open the \|pr\| you with to approve
		2. Leave your review comments inline, or in the commit message.
		3. Leave a commit message that outlines the review.
		4. Set the review status to :guilabel:`Approved`
		5. Select :guilabel:`Comment`

		If you approve the \|pr\|, you will be able to merge automatically if \|RCM\|
		detects that it can do so safely. You will see this message:

		:guilabel:`This pull request can be automatically merged.`

		Otherwise you will need to merge the \|pr\| locally and push your changes, see
		:ref:`manual-merge-requests-ref`.