##// END OF EJS Templates
vcs: Use a thread scoped cache invalidation context to cache repository objects....
vcs: Use a thread scoped cache invalidation context to cache repository objects. Without this change the cache is on a process scope. If running with multiple threads this leads to sharing the cached object between threads. This will cause exceptions if multiple threads are trying to access the same curl object. Even worse it allows multiple threads to operate on the same repository object concurrently.

File last commit:

r1:854a839a default
r614:cbe55781 default
Show More
reviewing-best-practices.rst
20 lines | 1.0 KiB | text/x-rst | RstLexer
/ docs / code-review / reviewing-best-practices.rst
project: added all source files and assets
r1 .. _code-best-practices-ref:
Code Review - Best Practices
----------------------------
The following is a list of best practices for reviewing code gathered from
various sources:
* **Implement a Core Review standard**, because the yield of the Code Review
phase is 50 to 80% better than that of the Test phase.
* Review between **100 and 300 lines of code** at a time and spend 30-60 minutes
doing it for best results.
* **Avoid code review meetings**, because meetings contributed only 4% of the
defects found in the code inspections.
* Slow down to a comfortable pace, as reviewers **slower than 400 lines per
hour are above average** in their ability to uncover defects. But when faster
than 450 lines/hour the defect density is below average in 87% of the cases.
* Take a time-out, because defects are found at relatively constant rates
through the first **60 minutes of inspection**. At that point the
checklist-style review levels off sharply; the other review styles level
off slightly later. In no case is a defect discovered after 90 minutes.