# HG changeset patch
# User Marcin Kuzminski <marcin@rhodecode.com>
# Date 2017-02-15 16:05:35
# Node ID 2af6893f4c2713b1ebc6e0d9f231ecaeb990ea7b
# Parent  934edf37c141d0f95066809c1b874d0ada61355b

pull-requests: forbid browsing versions on closed pull request.

diff --git a/rhodecode/controllers/pullrequests.py b/rhodecode/controllers/pullrequests.py
--- a/rhodecode/controllers/pullrequests.py
+++ b/rhodecode/controllers/pullrequests.py
@@ -644,6 +644,13 @@ class PullrequestsController(BaseRepoCon
          pull_request_display_obj,
          at_version) = self._get_pr_version(
             pull_request_id, version=version)
+        pr_closed = pull_request_latest.is_closed()
+
+        if pr_closed and (version or from_version):
+            # not allow to browse versions
+            return redirect(h.url('pullrequest_show', repo_name=repo_name,
+                                  pull_request_id=pull_request_id))
+
         versions = pull_request_display_obj.versions()
 
         c.at_version = at_version
@@ -681,7 +688,6 @@ class PullrequestsController(BaseRepoCon
         c.pull_request = pull_request_display_obj
         c.pull_request_latest = pull_request_latest
 
-        pr_closed = pull_request_latest.is_closed()
         if compare or (at_version and not at_version == 'latest'):
             c.allowed_to_change_status = False
             c.allowed_to_update = False