vcs: use proper attributes/inits on base and child classes.

rhodecode/lib/vcs/backends/base.py

@@ -249,6 +249,20 b' class BaseRepository(object):'
         raise NotImplementedError
 
     @LazyProperty
+    def branches_closed(self):
+        """
+        A `dict` which maps tags names to commit ids.
+        """
+        raise NotImplementedError
+
+    @LazyProperty
+    def bookmarks(self):
+        """
+        A `dict` which maps tags names to commit ids.
+        """
+        raise NotImplementedError
+
+    @LazyProperty
     def tags(self):
         """
         A `dict` which maps tags names to commit ids.

rhodecode/lib/vcs/backends/git/repository.py

@@ -71,8 +71,6 b' class GitRepository(BaseRepository):'
         # caches
         self._commit_ids = {}
 
-        self.bookmarks = {}
-
     @LazyProperty
     def bare(self):
         return self._remote.bare()
@@ -323,6 +321,10 b' class GitRepository(BaseRepository):'
         return {}
 
     @LazyProperty
+    def bookmarks(self):
+        return {}
+
+    @LazyProperty
     def branches_all(self):
         all_branches = {}
         all_branches.update(self.branches)

rhodecode/lib/vcs/backends/svn/repository.py

@@ -77,8 +77,6 b' class SubversionRepository(base.BaseRepo'
 
         self._init_repo(create, src_url)
 
-        self.bookmarks = {}
-
     def _init_repo(self, create, src_url):
         if create and os.path.exists(self.path):
             raise RepositoryError(
@@ -107,6 +105,10 b' class SubversionRepository(base.BaseRepo'
         return {}
 
     @LazyProperty
+    def bookmarks(self):
+        return {}
+
+    @LazyProperty
     def branches_all(self):
         # TODO: johbo: Implement proper branch support
         all_branches = {}