##// END OF EJS Templates
vcs: Minimal change to expose the shadow repository...
vcs: Minimal change to expose the shadow repository Based on my original research, this was the "minimal" starting point. It shows that three concepts are needed for the "repo_name": * From the security standpoint we think of the shadow repository having the same ACL as the target repository of the pull request. This is because the pull request itself is considered to be a part of the target repository. Out of this thought, the variable "acl_repo_name" is used whenever we want to check permissions or when we need the database configuration of the repository. An alternative name would have been "db_repo_name", but the usage for ACL checking is the most important one. * From the web interaction perspective, we need the URL which was originally used to get to the repository. This is because based on this base URL commands can be identified. Especially for Git this is important, so that the commands are correctly recognized. Since the URL is in the focus, this is called "url_repo_name". * Finally we have to deal with the repository on the file system. This is what the VCS layer deal with normally, so this name is called "vcs_repo_name". The original repository interaction is a special case where all three names are the same. When interacting with a pull request, these three names are typically all different. This change is minimal in a sense that it just makes the interaction with a shadow repository barely work, without checking any special constraints yet. This was the starting point for further work on this topic.

File last commit:

r821:618c046d default
r887:175782be default
Show More
utils.py
106 lines | 3.3 KiB | text/x-python | PythonLexer
# -*- coding: utf-8 -*-
# Copyright (C) 2010-2016 RhodeCode GmbH
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License, version 3
# (only), as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# This program is dual-licensed. If you wish to learn more about the
# RhodeCode Enterprise Edition, including its added features, Support services,
# and proprietary license terms, please see https://rhodecode.com/licenses/
"""
Utilities to be shared by multiple controllers.
Should only contain utilities to be shared in the controller layer.
"""
from rhodecode.lib import helpers as h
from rhodecode.lib.vcs.exceptions import RepositoryError
def parse_path_ref(ref, default_path=None):
"""
Parse out a path and reference combination and return both parts of it.
This is used to allow support of path based comparisons for Subversion
as an iterim solution in parameter handling.
"""
if '@' in ref:
return ref.rsplit('@', 1)
else:
return default_path, ref
def get_format_ref_id(repo):
"""Returns a `repo` specific reference formatter function"""
if h.is_svn(repo):
return _format_ref_id_svn
else:
return _format_ref_id
def _format_ref_id(name, raw_id):
"""Default formatting of a given reference `name`"""
return name
def _format_ref_id_svn(name, raw_id):
"""Special way of formatting a reference for Subversion including path"""
return '%s@%s' % (name, raw_id)
def get_commit_from_ref_name(repo, ref_name, ref_type=None):
"""
Gets the commit for a `ref_name` taking into account `ref_type`.
Needed in case a bookmark / tag share the same name.
:param repo: the repo instance
:param ref_name: the name of the ref to get
:param ref_type: optional, used to disambiguate colliding refs
"""
repo_scm = repo.scm_instance()
ref_type_mapping = {
'book': repo_scm.bookmarks,
'bookmark': repo_scm.bookmarks,
'tag': repo_scm.tags,
'branch': repo_scm.branches,
}
commit_id = ref_name
if repo_scm.alias != 'svn': # pass svn refs straight to backend until
# the branch issue with svn is fixed
if ref_type and ref_type in ref_type_mapping:
try:
commit_id = ref_type_mapping[ref_type][ref_name]
except KeyError:
raise RepositoryError(
'%s "%s" does not exist' % (ref_type, ref_name))
return repo_scm.get_commit(commit_id)
def reviewer_as_json(user, reasons):
"""
Returns json struct of a reviewer for frontend
:param user: the reviewer
:param reasons: list of strings of why they are reviewers
"""
return {
'user_id': user.user_id,
'reasons': reasons,
'username': user.username,
'firstname': user.firstname,
'lastname': user.lastname,
'gravatar_link': h.gravatar_url(user.email, 14),
}