u/ewong/rhodecode-enterprise-ce-fork Files · rhodecode/tests/lib/test_mako_emails.py

vcs: Minimal change to expose the shadow repository...

vcs: Minimal change to expose the shadow repository Based on my original research, this was the "minimal" starting point. It shows that three concepts are needed for the "repo_name": * From the security standpoint we think of the shadow repository having the same ACL as the target repository of the pull request. This is because the pull request itself is considered to be a part of the target repository. Out of this thought, the variable "acl_repo_name" is used whenever we want to check permissions or when we need the database configuration of the repository. An alternative name would have been "db_repo_name", but the usage for ACL checking is the most important one. * From the web interaction perspective, we need the URL which was originally used to get to the repository. This is because based on this base URL commands can be identified. Especially for Git this is important, so that the commands are correctly recognized. Since the URL is in the focus, this is called "url_repo_name". * Finally we have to deal with the repository on the file system. This is what the VCS layer deal with normally, so this name is called "vcs_repo_name". The original repository interaction is a special case where all three names are the same. When interacting with a pull request, these three names are typically all different. This change is minimal in a sense that it just makes the interaction with a shadow repository barely work, without checking any special constraints yet. This was the starting point for further work on this topic.

lisaq - - Load All Authors

File last commit:

r512:fafa37cf default


                r887:175782be

default

Download file

             test_mako_emails.py
        
                    68 lines
            
             | 2.0 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / rhodecode / tests / lib / test_mako_emails.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      import collections

      import pytest

      from rhodecode.lib.utils import PartialRenderer

      from rhodecode.model.notification import EmailNotificationModel

      def test_get_template_obj(pylonsapp):

          template = EmailNotificationModel().get_renderer(

              EmailNotificationModel.TYPE_TEST)

          assert isinstance(template, PartialRenderer)

      def test_render_email(pylonsapp):

          kwargs = {}

          subject, headers, body, body_plaintext = EmailNotificationModel().render_email(

              EmailNotificationModel.TYPE_TEST, **kwargs)

          # subject

          assert subject == 'Test "Subject" hello "world"'

          # headers

          assert headers == 'X=Y'

          # body plaintext

          assert body_plaintext == 'Email Plaintext Body'

          # body

          assert 'This is a notification ' \

                 'from RhodeCode. http://test.example.com:80/' in body

          assert 'Email Body' in body

      def test_render_pr_email(pylonsapp, user_admin):

          ref = collections.namedtuple('Ref',

              'name, type')(

              'fxies123', 'book'

              )

          pr = collections.namedtuple('PullRequest',

              'pull_request_id, title, description, source_ref_parts, source_ref_name, target_ref_parts, target_ref_name')(

              200, 'Example Pull Request', 'Desc of PR', ref, 'bookmark', ref, 'Branch')

          source_repo = target_repo = collections.namedtuple('Repo',

              'type, repo_name')(

              'hg', 'pull_request_1')

          kwargs = {

              'user': '<marcin@rhodecode.com> Marcin Kuzminski',

              'pull_request': pr,

              'pull_request_commits': [],

              'pull_request_target_repo': target_repo,

              'pull_request_target_repo_url': 'x',

              'pull_request_source_repo': source_repo,

              'pull_request_source_repo_url': 'x',

              'pull_request_url': 'http://localhost/pr1',

          }

          subject, headers, body, body_plaintext = EmailNotificationModel().render_email(

              EmailNotificationModel.TYPE_PULL_REQUEST, **kwargs)

          # subject

          assert subject == 'Marcin Kuzminski wants you to review pull request #200: "Example Pull Request"'

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				import collections

				import pytest

				from rhodecode.lib.utils import PartialRenderer
				from rhodecode.model.notification import EmailNotificationModel


				def test_get_template_obj(pylonsapp):
				template = EmailNotificationModel().get_renderer(
				EmailNotificationModel.TYPE_TEST)
				assert isinstance(template, PartialRenderer)


				def test_render_email(pylonsapp):
				kwargs = {}
				subject, headers, body, body_plaintext = EmailNotificationModel().render_email(
				EmailNotificationModel.TYPE_TEST, **kwargs)

				# subject
				assert subject == 'Test "Subject" hello "world"'

				# headers
				assert headers == 'X=Y'

				# body plaintext
				assert body_plaintext == 'Email Plaintext Body'

				# body
				assert 'This is a notification ' \
				'from RhodeCode. http://test.example.com:80/' in body
				assert 'Email Body' in body


				def test_render_pr_email(pylonsapp, user_admin):

				ref = collections.namedtuple('Ref',
				'name, type')(
				'fxies123', 'book'
				)

				pr = collections.namedtuple('PullRequest',
				'pull_request_id, title, description, source_ref_parts, source_ref_name, target_ref_parts, target_ref_name')(
				200, 'Example Pull Request', 'Desc of PR', ref, 'bookmark', ref, 'Branch')

				source_repo = target_repo = collections.namedtuple('Repo',
				'type, repo_name')(
				'hg', 'pull_request_1')

				kwargs = {
				'user': '<marcin@rhodecode.com> Marcin Kuzminski',
				'pull_request': pr,
				'pull_request_commits': [],

				'pull_request_target_repo': target_repo,
				'pull_request_target_repo_url': 'x',

				'pull_request_source_repo': source_repo,
				'pull_request_source_repo_url': 'x',

				'pull_request_url': 'http://localhost/pr1',
				}

				subject, headers, body, body_plaintext = EmailNotificationModel().render_email(
				EmailNotificationModel.TYPE_PULL_REQUEST, **kwargs)

				# subject
				assert subject == 'Marcin Kuzminski wants you to review pull request #200: "Example Pull Request"'