u/ewong/rhodecode-enterprise-ce-fork Files · rhodecode/templates/admin/notifications/notifications_data.mako

goto-switcher: optimized performance and query capabilities....

goto-switcher: optimized performance and query capabilities. - Previous implementation had on significant bug. The use of LIMIT 20 was limiting results BEFORE auth checks. In case of large ammount of similarly named repositories user didn't had access too, the result goto search was empty. This was becuase first 20 items fetched didn't pass permission checks and final auth list was empty. To fix this we now use proper filtering for auth using SQL. It means we first check user allowed repositories, and add this as a filter so end result from database is already to only the accessible repositories.

marcink - - Load All Authors

File last commit:

r1921:12a61bbb default


                r2038:2bdf9d4d

default

Download file

             notifications_data.mako
        
                    46 lines
            
             | 1.9 KiB
            
                | application/x-mako
            
             |
                MakoHtmlLexer
            
             / rhodecode / templates / admin / notifications / notifications_data.mako
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      <%namespace name="base" file="/base/base.mako"/>

      <div class="panel panel-default">

        <div class="panel-heading">

          <h3 class="panel-title">${_('My notifications')}</h3>

        </div>

        <div class="panel-body">

          %if c.notifications:

              <div class="notification-list  notification-table">

                  %for notification in c.notifications:

                  <div id="notification_${notification.notification.notification_id}" class="container ${'unread' if not notification.read else '' }">

                  <div class="notification-header">

                    <div class="desc ${'unread' if not notification.read else '' }">

                      <a href="${h.route_path('notifications_show', notification_id=notification.notification.notification_id)}">

                        ${base.gravatar(notification.notification.created_by_user.email, 16)}

                        ${h.notification_description(notification.notification, request)}

                      </a>

                    </div>

                    <div class="delete-notifications">

                      <span onclick="deleteNotification(${notification.notification.notification_id})" class="delete-notification tooltip" title="${_('Delete')}"><i class="icon-delete"></i></span>

                    </div>

                    <div class="read-notifications">

                    %if not notification.read:

                      <span onclick="readNotification(${notification.notification.notification_id})" class="read-notification tooltip" title="${_('Mark as read')}"><i class="icon-ok"></i></span>

                    %endif

                    </div>

                  </div>

                      <div class="notification-subject"></div>

                  </div>

                  %endfor

              </div>

              <div class="notification-paginator">

                  <div class="pagination-wh pagination-left">

                      ${c.notifications.pager('$link_previous ~2~ $link_next')}

                  </div>

              </div>

          %else:

              <div class="table">${_('No notifications here yet')}</div>

          %endif

        </div>

      </div>

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				<%namespace name="base" file="/base/base.mako"/>

				<div class="panel panel-default">
				<div class="panel-heading">
				<h3 class="panel-title">${_('My notifications')}</h3>
				</div>

				<div class="panel-body">
				%if c.notifications:

				<div class="notification-list notification-table">
				%for notification in c.notifications:
				<div id="notification_${notification.notification.notification_id}" class="container ${'unread' if not notification.read else '' }">
				<div class="notification-header">
				<div class="desc ${'unread' if not notification.read else '' }">
				<a href="${h.route_path('notifications_show', notification_id=notification.notification.notification_id)}">
				${base.gravatar(notification.notification.created_by_user.email, 16)}
				${h.notification_description(notification.notification, request)}
				</a>
				</div>
				<div class="delete-notifications">
				<span onclick="deleteNotification(${notification.notification.notification_id})" class="delete-notification tooltip" title="${_('Delete')}"><i class="icon-delete"></i></span>
				</div>
				<div class="read-notifications">
				%if not notification.read:
				<span onclick="readNotification(${notification.notification.notification_id})" class="read-notification tooltip" title="${_('Mark as read')}"><i class="icon-ok"></i></span>
				%endif
				</div>
				</div>
				<div class="notification-subject"></div>
				</div>
				%endfor
				</div>

				<div class="notification-paginator">
				<div class="pagination-wh pagination-left">
				${c.notifications.pager('$link_previous ~2~ $link_next')}
				</div>
				</div>

				%else:
				<div class="table">${_('No notifications here yet')}</div>
				%endif

				</div>
				</div>