##// END OF EJS Templates
goto-switcher: optimized performance and query capabilities....
goto-switcher: optimized performance and query capabilities. - Previous implementation had on significant bug. The use of LIMIT 20 was limiting results BEFORE auth checks. In case of large ammount of similarly named repositories user didn't had access too, the result goto search was empty. This was becuase first 20 items fetched didn't pass permission checks and final auth list was empty. To fix this we now use proper filtering for auth using SQL. It means we first check user allowed repositories, and add this as a filter so end result from database is already to only the accessible repositories.

File last commit:

r1271:47a44c03 default
r2038:2bdf9d4d default
Show More
test_slack.py
66 lines | 2.2 KiB | text/x-python | PythonLexer
# -*- coding: utf-8 -*-
# Copyright (C) 2010-2017 RhodeCode GmbH
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License, version 3
# (only), as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# This program is dual-licensed. If you wish to learn more about the
# RhodeCode Enterprise Edition, including its added features, Support services,
# and proprietary license terms, please see https://rhodecode.com/licenses/
import pytest
from mock import patch
from rhodecode import events
from rhodecode.model.db import Session, Integration
from rhodecode.integrations.types.slack import SlackIntegrationType
@pytest.fixture
def slack_settings():
return {
"service": "mock://slackintegration",
"events": [
"pullrequest-create",
"repo-push",
],
"channel": "#testing",
"icon_emoji": ":recycle:",
"username": "rhodecode-test"
}
@pytest.fixture
def slack_integration(request, app, slack_settings):
integration = Integration()
integration.name = 'test slack integration'
integration.enabled = True
integration.integration_type = SlackIntegrationType.key
integration.settings = slack_settings
Session().add(integration)
Session().commit()
request.addfinalizer(lambda: Session().delete(integration))
return integration
def test_slack_push(slack_integration, repo_push_event):
with patch('rhodecode.integrations.types.slack.post_text_to_slack') as call:
events.trigger(repo_push_event)
assert 'pushed to' in call.call_args[0][1]
slack_integration.settings['events'] = []
Session().commit()
with patch('rhodecode.integrations.types.slack.post_text_to_slack') as call:
events.trigger(repo_push_event)
assert not call.call_args