diffs: use whole chunk diff to calculate if it's oversized or not....

diffs: use whole chunk diff to calculate if it's oversized or not. - This fixes an issue if a file is added that has very large number of small lines. In this case the time to detect if the diff should be limited was very very long and CPU intensive.

marcink - - Load All Authors

File last commit:

r1:854a839a default


                r2070:7939c6bf

default

Download file

             approve-pull-request.rst
        
                    19 lines
            
             | 690 B
            
                | text/x-rst
            
             |
                RstLexer

/ docs / collaboration / approve-pull-request.rst

History | Annotation | Raw |Copy content |Copy permalink

Approve |prs|

To approve a |pr|, use the following steps:

Select :menuselection:`username --> Notifications --> Pull Requests` and open the |pr| you with to approve
Leave your review comments inline, or in the commit message.
Leave a commit message that outlines the review.
Set the review status to :guilabel:`Approved`
Select :guilabel:`Comment`

If you approve the |pr|, you will be able to merge automatically if |RCM| detects that it can do so safely. You will see this message:

:guilabel:`This pull request can be automatically merged.`

Otherwise you will need to merge the |pr| locally and push your changes, see :ref:`manual-merge-requests-ref`.

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages