##// END OF EJS Templates
u » ewong » rhodecode-enterprise-ce-fork
RSS

Fork of rhodecode-enterprise-ce

auth: don't break hashing in case of user with empty password....
auth: don't break hashing in case of user with empty password. In some cases such as LDAP user created via external scripts users might set the passwords to empty. The hashing uses the md5(password_hash) to store reference to detect password changes and forbid using the same password. In case of pure LDAP users this is not valid, and we shouldn't raise Errors in such case. This change makes it work for empty passwords now.
marcink - - Load All Authors

File last commit:

r1:854a839a default
r2203:8a18c3c3 default
Show More
review-pull-request.rst
27 lines | 850 B | text/x-rst | RstLexer
/ docs / collaboration / review-pull-request.rst
History | Annotation | Raw |Copy content |Copy permalink

Review a |pr|

To review a pull request, use the following steps:

  1. Open the review request from :menuselection:`Admin --> Repositories --> repo name --> Pull Requests --> Awaiting my review`
  2. Leave your review comments inline, or in the commit message.
  3. Set the review status from one of the following options:
    • :guilabel:`Not Reviewed`
    • :guilabel:`Approved`
    • :guilabel:`Approved & Closed`
    • :guilabel:`Rejected`
    • :guilabel:`Rejected & Closed`
    • :guilabel:`Under Review`
  4. Select Comment

When the |pr| is approved by all reviewers you will be able to merge automatically if |RCM| detects that it can do so safely. You will see this message: This pull request can be automatically merged.

If rejected, you can fix the issues raised during review and then update the |pr|.